From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:23042 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751619AbaL1PBL (ORCPT ); Sun, 28 Dec 2014 10:01:11 -0500 Message-ID: <54A01B34.4000002@broadcom.com> (sfid-20141228_160127_506450_B332C3E0) Date: Sun, 28 Dec 2014 16:01:08 +0100 From: Arend van Spriel MIME-Version: 1.0 To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= CC: Sedat Dilek , Oscar Forner Martinez , "linux-wireless@vger.kernel.org" , Linux Kernel Mailing List Subject: Re: [PATCH] bcma: fix three coding style issues, more than 80 characters per line References: <1419708268-14114-1-git-send-email-oscar.forner.martinez@gmail.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 12/28/14 15:02, Rafał Miłecki wrote: > On 28 December 2014 at 10:12, Sedat Dilek wrote: >> On Sun, Dec 28, 2014 at 9:53 AM, Rafał Miłecki wrote: >>> On 28 December 2014 at 06:50, Sedat Dilek wrote: >>>> On Sun, Dec 28, 2014 at 12:44 AM, Rafał Miłecki wrote: >>>>> On 27 December 2014 at 20:24, Oscar Forner Martinez >>>>> wrote: >>>>>> Three lines with more than 80 characters per line have been split in several lines. >>>>>> >>>>>> Signed-off-by: Oscar Forner Martinez >>>>> >>>>> Acked-by: Rafał Miłecki >>>>> >>>> >>>> As for the comment-line changes... 80+ chars are allowed for better readability. >>>> So, please don't do that. >>>> [ Checkpatch should not warn on this especially for comments. ] >>> >>> We almost always split long comments into separated lines in the >>> kernel. What's different with this case? >>> >> >> 1st it is not mandatory. >> >> 2nd it is more readable in one line. >> >> - /* 4706 CC and PMU watchdogs are clocked at >> 1/4 of ALP clock */ >> + /* 4706 CC and PMU watchdogs are clocked at 1/4 of ALP >> + * clock >> + */ >> >> I agree with you when the comment would be longer. > > So I guess there is some rule like > "Don't use 2 lines if there is 80 chars + one word" > ? Where can I find such rules? Personally, I don't like taking this sliding slope. Just stick to the 80 characters rule and add a few words in the comment, eg: /* The BCM4706 ChipCommon and PMU watchdogs are * clocked at one quarter of the ALP clock. */ Regards, Arend