From: Larry Finger <Larry.Finger@lwfinger.net>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Chaoming Li <chaoming_li@realsil.com.cn>
Cc: Kalle Valo <kvalo@adurom.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Fengguang Wu <fengguang.wu@intel.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: wireless: rtlwifi: btcoexist: halbtc8821a2ant: Remove some unused functions
Date: Sat, 03 Jan 2015 00:05:24 -0600 [thread overview]
Message-ID: <54A786A4.2050202@lwfinger.net> (raw)
In-Reply-To: <1420230361-1862-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On 01/02/2015 02:26 PM, Rickard Strandqvist wrote:
> Removes some functions that are not used anywhere:
> ex_halbtc8821a2ant_periodical() ex_halbtc8821a2ant_halt_notify()
> ex_halbtc8821a2ant_bt_info_notify()
> ex_halbtc8821a2ant_special_packet_notify()
> ex_halbtc8821a2ant_connect_notify() ex_halbtc8821a2ant_scan_notify()
> ex_halbtc8821a2ant_lps_notify() ex_halbtc8821a2ant_ips_notify()
> ex_halbtc8821a2ant_display_coex_info() ex_halbtc8821a2ant_init_coex_dm()
> ex_halbtc8821a2ant_init_hwconfig()
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
I know that you have been told that including "net: wireless:" in the subject
line is discouraged. Please do not do this again. The staging directory is
different as GregKH uses "staging:" in the subject to route patches, but
wireless does not.
As to the patch, NACK for the simple reason that I am currently working on a
number of changes to btcoexist. Some of these routines may end up being removed,
but others will not. Having your patch remove them, and one of mine adding them
back just constitutes a lot of churning of the source. In addition, it greatly
increases the probability of the source trees becoming unsynchronized and
getting merge conflicts.
Larry
next prev parent reply other threads:[~2015-01-03 6:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-02 20:26 [PATCH] net: wireless: rtlwifi: btcoexist: halbtc8821a2ant: Remove some unused functions Rickard Strandqvist
2015-01-03 6:05 ` Larry Finger [this message]
[not found] ` <CAKXHbyOYO29uKA127qyYrCfpgQ2zoqBS9rAJME513oZ8JVdOug@mail.gmail.com>
2015-01-05 1:45 ` Larry Finger
2015-01-05 4:05 ` Julian Calaby
2015-01-05 10:28 ` Kalle Valo
2015-01-06 18:14 ` Kalle Valo
2015-01-09 17:23 ` Rickard Strandqvist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A786A4.2050202@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kvalo@adurom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).