From: Larry Finger <Larry.Finger@lwfinger.net>
To: nick <xerofoify@gmail.com>, Kalle Valo <kvalo@codeaurora.org>
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
b43-dev@lists.infradead.org, stefano.brivio@polimi.it,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers:net:wireless: Add proper locking for the function, b43_op_beacon_set_tim in main.c
Date: Mon, 05 Jan 2015 11:46:40 -0600 [thread overview]
Message-ID: <54AACE00.8060407@lwfinger.net> (raw)
In-Reply-To: <54AAC6EE.2000603@gmail.com>
On 01/05/2015 11:16 AM, nick wrote:
> Kalle,
> That's fine. On the other hand I am interested in the
> reasons why this patch was dropped so I can send in a
> version 2 of this patch.
> Regards Nick
Apparently you missed Michael Büsch's comment:
"Thanks for the patch.
However, this does not work. We are in atomic context here.
Please see the b43-dev mailing list archives for a recent thread about that.
I'm also pretty sure that this is safe without lock, due to the higher level
locks in mac80211."
Did you actually test the patch? If Michael is right, and I trust him on this
matter, your patch should lock the system.
Larry
prev parent reply other threads:[~2015-01-05 17:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1420184041-6788-1-git-send-email-xerofoify@gmail.com>
2015-01-02 9:27 ` [PATCH] drivers:net:wireless: Add proper locking for the function, b43_op_beacon_set_tim in main.c Michael Büsch
2015-01-02 11:19 ` Rafał Miłecki
2015-01-02 11:42 ` Michael Büsch
2015-01-02 16:40 ` Larry Finger
2015-01-05 9:29 ` Kalle Valo
[not found] ` <54AAC6EE.2000603@gmail.com>
2015-01-05 17:46 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AACE00.8060407@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefano.brivio@polimi.it \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).