linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arend van Spriel <arend@broadcom.com>
To: Sujith Manoharan <sujith@msujith.org>
Cc: Kalle Valo <kvalo@codeaurora.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	<ath9k-devel@lists.ath9k.org>
Subject: Re: [PATCH] ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries
Date: Thu, 8 Jan 2015 21:10:24 +0100	[thread overview]
Message-ID: <54AEE430.2070706@broadcom.com> (raw)
In-Reply-To: <21677.63268.657151.679992@gargle.gargle.HOWL>

On 01/08/15 04:19, Sujith Manoharan wrote:
>> Arend van Spriel<arend@broadcom.com>  writes:
>>
>>> Use the helper to get rid of the file operations per debugfs file. The
>>> device driver data contains struct ieee80211_hw pointer and the
>>> struct ath9k_softc pointer is assigned to ieee80211_hw::priv so it can
>>> be accessed in the seq_file read operation.
>>>
>>> Cc: ath9k-devel@lists.ath9k.org
>>> Signed-off-by: Arend van Spriel<arend@broadcom.com>
>
> Thanks for the patch.
>
>> Can someone with ath9k hardware test this, please? I'm hesitant to apply
>> this without testing.
>
> I tested it and there were no crashes.

Thanks, Sujith

So the content of the modified debugfs files looks sane?

Regards,
Arend

> Sujith


  reply	other threads:[~2015-01-08 20:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-27 13:13 [PATCH] ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries Arend van Spriel
2015-01-07 18:05 ` Kalle Valo
2015-01-08  3:19   ` Sujith Manoharan
2015-01-08 20:10     ` Arend van Spriel [this message]
2015-01-09  0:34       ` Sujith Manoharan
2015-01-09  9:59         ` Arend van Spriel
2015-01-15 12:39 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54AEE430.2070706@broadcom.com \
    --to=arend@broadcom.com \
    --cc=ath9k-devel@lists.ath9k.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sujith@msujith.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).