[PATCH] mwifiex: set netif carrier off in ndo_open

[PATCH] mwifiex: set netif carrier off in ndo_open

[Avinash Patil]

From: Johannes Berg <johannes@sipsolutions.net>

This patch adds fix to set carrier state off during ndo_open.
Carrier should be set to ON when device is ready to send data.
In case of station/adhoc interface device is able to transfer
data after successful association/join operation.
For AP this would be after bss_active event.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Avinash Patil <patila@marvell.com>
---
 drivers/net/wireless/mwifiex/main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mwifiex/main.c b/drivers/net/wireless/mwifiex/main.c
index effea6e..48e7c63 100644
--- a/drivers/net/wireless/mwifiex/main.c
+++ b/drivers/net/wireless/mwifiex/main.c
@@ -562,7 +562,8 @@ static int mwifiex_init_hw_fw(struct mwifiex_adapter *adapter)
 static int
 mwifiex_open(struct net_device *dev)
 {
-	netif_tx_start_all_queues(dev);
+	netif_carrier_off(dev);
+
 	return 0;
 }
 
-- 
1.8.1.4

mwifiex - question

[wim torfs]

Hi,

I just noticed - from the mails passing through - that mwifiex is 
located in net/wireless and that it contains its own functions besides 
those of mac80211, while the description on the wiki mentions that it is 
a driver for Marvell SDIO chips.

Is there any specific reason why it is not using mac80211 and why it is 
located in net/wireless instead of drivers/net/wireless, or is this an 
artifact of past choices that need to be cleaned up?

Thanks,
Wim.

RE: mwifiex - question

[Avinash Patil]

Hi Wim,

Mwifiex is FullMac driver; we have our own thick FW for managing MLME.  This is reason why we do not use mac80211.
Mwifiex is very much located under drivers/net/wireless; its not in net/wireless. net/wireless has cfg80211 driver.

Thanks,
Avinash.
________________________________________
From: linux-wireless-owner@vger.kernel.org [linux-wireless-owner@vger.kernel.org] On Behalf Of wim torfs [wtorfs@gmail.com]
Sent: Tuesday, January 13, 2015 7:04 PM
To: linux-wireless@vger.kernel.org
Subject: mwifiex - question

Hi,

I just noticed - from the mails passing through - that mwifiex is
located in net/wireless and that it contains its own functions besides
those of mac80211, while the description on the wiki mentions that it is
a driver for Marvell SDIO chips.

Is there any specific reason why it is not using mac80211 and why it is
located in net/wireless instead of drivers/net/wireless, or is this an
artifact of past choices that need to be cleaned up?

Thanks,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: mwifiex - question

[wim torfs]

Hi Avinash,

Thanks for the clarification.
Obviously I missed the most important part of the path, which caused the 
confusion.

Thanks,
Wim.


On 01/13/2015 02:44 PM, Avinash Patil wrote:
> Hi Wim,
>
> Mwifiex is FullMac driver; we have our own thick FW for managing MLME.  This is reason why we do not use mac80211.
> Mwifiex is very much located under drivers/net/wireless; its not in net/wireless. net/wireless has cfg80211 driver.
>
> Thanks,
> Avinash.
> ________________________________________
> From: linux-wireless-owner@vger.kernel.org [linux-wireless-owner@vger.kernel.org] On Behalf Of wim torfs [wtorfs@gmail.com]
> Sent: Tuesday, January 13, 2015 7:04 PM
> To: linux-wireless@vger.kernel.org
> Subject: mwifiex - question
>
> Hi,
>
> I just noticed - from the mails passing through - that mwifiex is
> located in net/wireless and that it contains its own functions besides
> those of mac80211, while the description on the wiki mentions that it is
> a driver for Marvell SDIO chips.
>
> Is there any specific reason why it is not using mac80211 and why it is
> located in net/wireless instead of drivers/net/wireless, or is this an
> artifact of past choices that need to be cleaned up?
>
> Thanks,
> Wim.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mwifiex: set netif carrier off in ndo_open

[Avinash Patil]

Hi Kalle,

Could you please mark this patch for stable as well?

Thanks,
Avinash

On Mon, 2015-01-12 at 04:24 -0800, Avinash Patil wrote:
> From: Johannes Berg <johannes@sipsolutions.net>
> 
> This patch adds fix to set carrier state off during ndo_open.
> Carrier should be set to ON when device is ready to send data.
> In case of station/adhoc interface device is able to transfer
> data after successful association/join operation.
> For AP this would be after bss_active event.
> 
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Avinash Patil <patila@marvell.com>
> ---
>  drivers/net/wireless/mwifiex/main.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/mwifiex/main.c b/drivers/net/wireless/mwifiex/main.c
> index effea6e..48e7c63 100644
> --- a/drivers/net/wireless/mwifiex/main.c
> +++ b/drivers/net/wireless/mwifiex/main.c
> @@ -562,7 +562,8 @@ static int mwifiex_init_hw_fw(struct mwifiex_adapter *adapter)
>  static int
>  mwifiex_open(struct net_device *dev)
>  {
> -	netif_tx_start_all_queues(dev);
> +	netif_carrier_off(dev);
> +
>  	return 0;
>  }
>  

Re: [PATCH] mwifiex: set netif carrier off in ndo_open

[Kalle Valo]

Avinash Patil <patila@marvell.com> writes:

> Could you please mark this patch for stable as well?

Better that you do it, so please resend.

-- 
Kalle Valo