From: Larry Finger <Larry.Finger@lwfinger.net>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org,
Troy Tan <troy_tan@realsil.com.cn>,
netdev@vger.kernel.org
Subject: Re: [PATCH 3/6] rtlwifi: btcoexist: Add routines for RTL8812AE with single antenna
Date: Fri, 23 Jan 2015 14:24:27 -0600 [thread overview]
Message-ID: <54C2ADFB.2080806@lwfinger.net> (raw)
In-Reply-To: <87r3uljm7o.fsf@kamboji.qca.qualcomm.com>
On 01/23/2015 02:06 PM, Kalle Valo wrote:
> Larry Finger <Larry.Finger@lwfinger.net> writes:
>
>> From: Troy Tan <troy_tan@realsil.com.cn>
>>
>> The RTL8812AE needs different BT coexistence routines than does the
>> RTL8821AE. This patch adds the necessary routines for devices with a
>> single antenna.
>>
>> Signed-off-by: Troy Tan <troy_tan@realsil.com.cn>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> ---
>> .../wireless/rtlwifi/btcoexist/halbtc8812a1ant.c | 2073 ++++++++++++++++++++
>> .../wireless/rtlwifi/btcoexist/halbtc8812a1ant.h | 152 ++
>> 2 files changed, 2225 insertions(+)
>> create mode 100644 drivers/net/wireless/rtlwifi/btcoexist/halbtc8812a1ant.c
>> create mode 100644 drivers/net/wireless/rtlwifi/btcoexist/halbtc8812a1ant.h
>>
>> diff --git a/drivers/net/wireless/rtlwifi/btcoexist/halbtc8812a1ant.c b/drivers/net/wireless/rtlwifi/btcoexist/halbtc8812a1ant.c
>> new file mode 100644
>> index 0000000..11ae66b
>> --- /dev/null
>> +++ b/drivers/net/wireless/rtlwifi/btcoexist/halbtc8812a1ant.c
>> @@ -0,0 +1,2073 @@
>> +/* */
>> +/* Description: */
>> +/* */
>> +/* This file is for 8812a1ant Co-exist mechanism */
>> +/* */
>> +/* History */
>> +/* 2012/11/15 Cosa first check in. */
>> +/* */
>> +/* */
>> +
>> +/* */
>> +/* include files */
>> +/* */
>
> One problem I see is that there's no license on either of the files. It
> would be much better if the files had that.
I will add that and send a V2 after I wait a while for any other comments.
Thanks,
Larry
next prev parent reply other threads:[~2015-01-23 20:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 17:10 [PATCH 0/6] Some changes for rtlwifi Larry Finger
2015-01-23 17:10 ` [PATCH 1/6] rtlwifi: Change logging level for key change Larry Finger
2015-01-23 17:10 ` [PATCH 2/6] rtlwifi: btcoexist: Remove typedef statements Larry Finger
2015-01-23 17:10 ` [PATCH 3/6] rtlwifi: btcoexist: Add routines for RTL8812AE with single antenna Larry Finger
2015-01-23 20:06 ` Kalle Valo
2015-01-23 20:24 ` Larry Finger [this message]
2015-01-23 17:10 ` [PATCH 4/6 for NEXT] rtlwifi: btcoexist: Add routines for RTL8812AE with dual antennae Larry Finger
2015-01-23 17:10 ` [PATCH 5/6] rtlwifi: btcoexist: Add routines for RTL8812AE - all configs Larry Finger
2015-01-23 20:12 ` Kalle Valo
2015-01-23 17:10 ` [PATCH 6/6] rtlwifi: btcoexist: Enable new routines for RTL8812AE Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C2ADFB.2080806@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=troy_tan@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).