From: Ben Greear <greearb@candelatech.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Michal Kazior <michal.kazior@tieto.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
eyalpe@dev.mellanox.co.il
Subject: Re: Throughput regression with `tcp: refine TSO autosizing`
Date: Mon, 02 Feb 2015 13:25:26 -0800 [thread overview]
Message-ID: <54CFEB46.3050006@candelatech.com> (raw)
In-Reply-To: <1422903136.21689.114.camel@edumazet-glaptop2.roam.corp.google.com>
On 02/02/2015 10:52 AM, Eric Dumazet wrote:
> On Mon, 2015-02-02 at 11:27 +0100, Michal Kazior wrote:
>
>> While testing I've had my internal GRO patch for ath10k and no stretch
>> ack patches.
>
> Thanks for the data, I took a look at it.
>
> I am afraid this GRO patch might be the problem.
>
> It seems to break ACK clocking badly (linux stack has a somewhat buggy
> tcp_tso_should_defer(), which relies on ACK being received smoothly, as
> no timer is setup to split the TSO packet.)
It is a big throughput win to have fewer TCP ack packets on
wireless since it is a half-duplex environment. Is there anything
we could improve so that we can have fewer acks and still get
good tcp stack behaviour?
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2015-02-02 21:25 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 11:48 Throughput regression with `tcp: refine TSO autosizing` Michal Kazior
2015-01-29 13:14 ` Eric Dumazet
2015-01-30 10:29 ` Arend van Spriel
2015-01-30 13:19 ` Eric Dumazet
2015-01-30 13:47 ` Arend van Spriel
2015-01-30 14:37 ` Eric Dumazet
[not found] ` <CAA93jw5fqhz0Hiw74L2GXgtZ9JsMg+NtYydKxKzGDrvQcZn4hA@mail.gmail.com>
[not found] ` <CAA93jw7b0E9jjQYXrEPzjLLC9j8xNC0TFYXpWVtgFameJaNBdw@mail.gmail.com>
[not found] ` <1422741065.199624134@apps.rackspace.com>
[not found] ` <CAPp0ZBb2nkA6Y0s=W0kw=zvyn0wi0NMBRsBCw_xcD61ScOmgQg@mail.gmail.com>
[not found] ` <CAA_e5Z46Bu+zZZFzf_ejzA35Gw3g1_OG85yv6yd7MpbwZcE-nw@mail.gmail.com>
[not found] ` <CAA93jw7=oTex0Mp-0ThvuDRUnfR0N8tzdOQ8DD7QYWphp1b=4w@mail.gmail.com>
[not found] ` <CAJq5cE3ETbpEtecFHmhgHQveNRUhVfrzjTOygHm-TRCTwHNyKA@mail.gmail.com>
[not found] ` <1422801814.796219699@apps.rackspace.com>
[not found] ` <CAA_e5Z5PfimZeC5cqSk_xFpKOBeZ74htLeEdwtKieAYWJaEX+A@mail.gmail.com>
2015-02-02 4:04 ` [Cerowrt-devel] Fwd: " Avery Pennarun
2015-02-02 15:25 ` Jim Gettys
2015-02-02 4:21 ` Avery Pennarun
2015-02-02 7:07 ` David Lang
2015-01-30 13:39 ` Michal Kazior
2015-01-30 14:40 ` Eric Dumazet
2015-02-02 10:27 ` Michal Kazior
2015-02-02 18:52 ` Eric Dumazet
2015-02-02 21:25 ` Ben Greear [this message]
2015-02-02 23:06 ` Eric Dumazet
2015-02-03 9:00 ` Michal Kazior
2015-02-03 1:18 ` Eric Dumazet
2015-02-03 11:50 ` Michal Kazior
2015-02-03 14:27 ` Eric Dumazet
2015-02-03 15:03 ` Eric Dumazet
2015-02-04 11:35 ` Michal Kazior
2015-02-04 11:57 ` Eric Dumazet
2015-02-04 12:22 ` Michal Kazior
2015-02-04 12:38 ` Eric Dumazet
2015-02-04 12:53 ` Michal Kazior
2015-02-04 12:55 ` Johannes Berg
2015-02-04 13:16 ` Eric Dumazet
2015-02-04 13:29 ` Eric Dumazet
2015-02-04 21:11 ` Eric Dumazet
2015-02-05 6:46 ` Michal Kazior
2015-02-05 13:03 ` Eric Dumazet
2015-02-05 8:38 ` Michal Kazior
2015-02-05 12:57 ` Eric Dumazet
2015-02-05 13:19 ` Eric Dumazet
2015-02-05 13:33 ` Eric Dumazet
2015-02-05 13:44 ` Michal Kazior
2015-02-05 14:41 ` Eric Dumazet
2015-02-05 17:10 ` Eric Dumazet
2015-02-06 9:42 ` Michal Kazior
2015-02-06 13:40 ` Eric Dumazet
2015-02-06 13:53 ` Eric Dumazet
2015-02-06 14:09 ` Michal Kazior
2015-02-09 13:47 ` Michal Kazior
2015-02-09 15:11 ` Eric Dumazet
2015-02-10 10:33 ` Michal Kazior
2015-02-10 12:54 ` Eric Dumazet
2015-02-10 13:05 ` Eric Dumazet
2015-02-10 13:14 ` Eric Dumazet
2015-02-11 8:33 ` Michal Kazior
2015-02-11 13:17 ` Eric Dumazet
2015-02-12 7:16 ` Michal Kazior
2015-02-10 14:19 ` Johannes Berg
2015-02-10 15:09 ` Eric Dumazet
2015-02-11 8:57 ` Michal Kazior
2015-02-12 7:48 ` Michal Kazior
2015-02-12 8:33 ` Dave Taht
2015-02-24 10:24 ` Johannes Berg
2015-02-24 10:30 ` Johannes Berg
2015-02-24 10:59 ` Johannes Berg
2015-03-31 11:08 ` Johannes Berg
2015-02-06 14:10 ` Eric Dumazet
2015-02-06 14:31 ` David Laight
2015-02-06 15:02 ` Eric Dumazet
2015-02-06 14:08 ` Michal Kazior
2015-02-06 14:35 ` Eric Dumazet
2015-02-06 17:48 ` Rick Jones
2015-02-05 14:48 ` Eric Dumazet
2015-02-06 9:39 ` Nicolas Cavallari
2015-02-05 19:50 ` Dave Taht
2015-02-06 9:57 ` Michal Kazior
2015-02-03 8:44 ` Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CFEB46.3050006@candelatech.com \
--to=greearb@candelatech.com \
--cc=eric.dumazet@gmail.com \
--cc=eyalpe@dev.mellanox.co.il \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).