[PATCH] * Add support for Philips (or NXP) PTA01 Wireless Adapter

[PATCH] * Add support for Philips (or NXP) PTA01 Wireless Adapter

[Leon Nardella]

Signed-off-by: Leon Nardella <leon.nardella@gmail.com>
---
 drivers/net/wireless/ath/ath9k/hif_usb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c
index 8e7153b..10c02f5 100644
--- a/drivers/net/wireless/ath/ath9k/hif_usb.c
+++ b/drivers/net/wireless/ath/ath9k/hif_usb.c
@@ -40,6 +40,7 @@ static struct usb_device_id ath9k_hif_usb_ids[] = {
 	{ USB_DEVICE(0x0cf3, 0xb003) }, /* Ubiquiti WifiStation Ext */
 	{ USB_DEVICE(0x0cf3, 0xb002) }, /* Ubiquiti WifiStation */
 	{ USB_DEVICE(0x057c, 0x8403) }, /* AVM FRITZ!WLAN 11N v2 USB */
+	{ USB_DEVICE(0x0471, 0x209e) }, /* Philips (or NXP) PTA01 */
 
 	{ USB_DEVICE(0x0cf3, 0x7015),
 	  .driver_info = AR9287_USB },  /* Atheros */
-- 
2.1.0

Re: [PATCH] * Add support for Philips (or NXP) PTA01 Wireless Adapter

[Larry Finger]

On 02/07/2015 04:46 AM, Leon Nardella wrote:
> Signed-off-by: Leon Nardella <leon.nardella@gmail.com>
> ---
>   drivers/net/wireless/ath/ath9k/hif_usb.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c
> index 8e7153b..10c02f5 100644
> --- a/drivers/net/wireless/ath/ath9k/hif_usb.c
> +++ b/drivers/net/wireless/ath/ath9k/hif_usb.c
> @@ -40,6 +40,7 @@ static struct usb_device_id ath9k_hif_usb_ids[] = {
>   	{ USB_DEVICE(0x0cf3, 0xb003) }, /* Ubiquiti WifiStation Ext */
>   	{ USB_DEVICE(0x0cf3, 0xb002) }, /* Ubiquiti WifiStation */
>   	{ USB_DEVICE(0x057c, 0x8403) }, /* AVM FRITZ!WLAN 11N v2 USB */
> +	{ USB_DEVICE(0x0471, 0x209e) }, /* Philips (or NXP) PTA01 */
>
>   	{ USB_DEVICE(0x0cf3, 0x7015),
>   	  .driver_info = AR9287_USB },  /* Atheros */

Leon,

Your patch is correct, but your subject and commit message needs a little work.

When I add a new USB ID for a driver, my subject usually includes the driver 
name followed by a colon, and the "Add new USB ID". In your case, that would be 
"[PATCH] ath9k_htc: Add new USB ID". Then in the commit message I include the 
make and model of the device, and some indication of why that device ID should 
be added. For example, was that ID found in a Windows driver? Finally, indicate 
that the patch has been tested. Such a statement should not be necessary, but 
recently there have been a number of patches submitted that have not been tested 
on real hardware.

Larry

Re: [PATCH] * Add support for Philips (or NXP) PTA01 Wireless Adapter

[Leon Nardella]

Larry,


Thank for your remarks! I'll submit it again!



Att,

Leon Nardella

On Sat, Feb 7, 2015 at 3:16 PM, Larry Finger <Larry.Finger@lwfinger.net> wrote:
> On 02/07/2015 04:46 AM, Leon Nardella wrote:
>>
>> Signed-off-by: Leon Nardella <leon.nardella@gmail.com>
>> ---
>>   drivers/net/wireless/ath/ath9k/hif_usb.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c
>> b/drivers/net/wireless/ath/ath9k/hif_usb.c
>> index 8e7153b..10c02f5 100644
>> --- a/drivers/net/wireless/ath/ath9k/hif_usb.c
>> +++ b/drivers/net/wireless/ath/ath9k/hif_usb.c
>> @@ -40,6 +40,7 @@ static struct usb_device_id ath9k_hif_usb_ids[] = {
>>         { USB_DEVICE(0x0cf3, 0xb003) }, /* Ubiquiti WifiStation Ext */
>>         { USB_DEVICE(0x0cf3, 0xb002) }, /* Ubiquiti WifiStation */
>>         { USB_DEVICE(0x057c, 0x8403) }, /* AVM FRITZ!WLAN 11N v2 USB */
>> +       { USB_DEVICE(0x0471, 0x209e) }, /* Philips (or NXP) PTA01 */
>>
>>         { USB_DEVICE(0x0cf3, 0x7015),
>>           .driver_info = AR9287_USB },  /* Atheros */
>
>
> Leon,
>
> Your patch is correct, but your subject and commit message needs a little
> work.
>
> When I add a new USB ID for a driver, my subject usually includes the driver
> name followed by a colon, and the "Add new USB ID". In your case, that would
> be "[PATCH] ath9k_htc: Add new USB ID". Then in the commit message I include
> the make and model of the device, and some indication of why that device ID
> should be added. For example, was that ID found in a Windows driver?
> Finally, indicate that the patch has been tested. Such a statement should
> not be necessary, but recently there have been a number of patches submitted
> that have not been tested on real hardware.
>
> Larry
>
>