linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arend van Spriel <arend@broadcom.com>
To: Jouni Malinen <jouni@qca.qualcomm.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	<linux-wireless@vger.kernel.org>,
	Ahmad Kholaif <akholaif@qca.qualcomm.com>
Subject: Re: [PATCH 1/2] cfg80211: Allow NL80211_ATTR_IFINDEX to be added to vendor events
Date: Fri, 20 Feb 2015 20:28:58 +0100	[thread overview]
Message-ID: <54E78AFA.1000400@broadcom.com> (raw)
In-Reply-To: <1424442925-10778-1-git-send-email-jouni@qca.qualcomm.com>

On 02/20/15 15:35, Jouni Malinen wrote:
> @@ -7405,6 +7405,12 @@ __cfg80211_alloc_vendor_skb(struct cfg80211_registered_device *rdev,
>   			goto nla_put_failure;
>   	}
>
> +	if (wdev&&  wdev->netdev) {
> +		if (nla_put_u32(skb, NL80211_ATTR_IFINDEX,
> +				wdev->netdev->ifindex))
> +			goto nla_put_failure;
> +	}
> +

Could consider putting wdev id in there as well.

Regards,
Arend

  parent reply	other threads:[~2015-02-20 19:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-20 14:35 [PATCH 1/2] cfg80211: Allow NL80211_ATTR_IFINDEX to be added to vendor events Jouni Malinen
2015-02-20 14:35 ` [PATCH 2/2] mac80211_hwsim: Add ifindex to the example vendor event Jouni Malinen
2015-02-20 19:28 ` Arend van Spriel [this message]
2015-02-23 15:37 ` [PATCH 1/2] cfg80211: Allow NL80211_ATTR_IFINDEX to be added to vendor events Johannes Berg
2015-02-23 19:51   ` Kholaif, Ahmad
2015-02-24  8:05     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54E78AFA.1000400@broadcom.com \
    --to=arend@broadcom.com \
    --cc=akholaif@qca.qualcomm.com \
    --cc=johannes@sipsolutions.net \
    --cc=jouni@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).