* [PATCH] rtlwifi: rtl8192cu: Add case in rtl92cu_get_hw_reg
@ 2015-02-25 17:58 Taehee Yoo
2015-02-25 18:33 ` Larry Finger
0 siblings, 1 reply; 7+ messages in thread
From: Taehee Yoo @ 2015-02-25 17:58 UTC (permalink / raw)
To: Larry.Finger, ap420073; +Cc: linux-wireless
rtl_op_stop get wowlan state but rtl92cu_get_hw_reg has not process.
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
---
drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
index fe4b699..f6ad959 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
@@ -1589,6 +1589,12 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
case HW_VAR_DATA_FILTER:
*((u16 *) (val)) = rtl_read_word(rtlpriv, REG_RXFLTMAP2);
break;
+ case HAL_DEF_WOWLAN:
+ if (ppsc->wo_wlan_mode)
+ *((bool *)(val)) = true;
+ else
+ *((bool *)(val)) = false;
+ break;
default:
RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
"switch case not processed\n");
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] rtlwifi: rtl8192cu: Add case in rtl92cu_get_hw_reg
2015-02-25 17:58 [PATCH] rtlwifi: rtl8192cu: Add case in rtl92cu_get_hw_reg Taehee Yoo
@ 2015-02-25 18:33 ` Larry Finger
2015-02-25 18:59 ` ap420073 .
0 siblings, 1 reply; 7+ messages in thread
From: Larry Finger @ 2015-02-25 18:33 UTC (permalink / raw)
To: Taehee Yoo; +Cc: linux-wireless
On 02/25/2015 11:58 AM, Taehee Yoo wrote:
> rtl_op_stop get wowlan state but rtl92cu_get_hw_reg has not process.
>
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Has this been tested? I am not aware that the RTL8192CU firmware could handle
WOWLAN.
Larry
> ---
> drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> index fe4b699..f6ad959 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> @@ -1589,6 +1589,12 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
> case HW_VAR_DATA_FILTER:
> *((u16 *) (val)) = rtl_read_word(rtlpriv, REG_RXFLTMAP2);
> break;
> + case HAL_DEF_WOWLAN:
> + if (ppsc->wo_wlan_mode)
> + *((bool *)(val)) = true;
> + else
> + *((bool *)(val)) = false;
> + break;
> default:
> RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
> "switch case not processed\n");
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] rtlwifi: rtl8192cu: Add case in rtl92cu_get_hw_reg
2015-02-25 18:33 ` Larry Finger
@ 2015-02-25 18:59 ` ap420073 .
2015-02-25 19:12 ` Larry Finger
0 siblings, 1 reply; 7+ messages in thread
From: ap420073 . @ 2015-02-25 18:59 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless@vger.kernel.org, ap420073
2015-02-26 3:33 GMT+09:00 Larry Finger <Larry.Finger@lwfinger.net>:
> On 02/25/2015 11:58 AM, Taehee Yoo wrote:
>>
>> rtl_op_stop get wowlan state but rtl92cu_get_hw_reg has not process.
>>
>> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
>
>
> Has this been tested? I am not aware that the RTL8192CU firmware could
> handle WOWLAN.
>
> Larry
>
>
>> ---
>> drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>> b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>> index fe4b699..f6ad959 100644
>> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>> @@ -1589,6 +1589,12 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8
>> variable, u8 *val)
>> case HW_VAR_DATA_FILTER:
>> *((u16 *) (val)) = rtl_read_word(rtlpriv, REG_RXFLTMAP2);
>> break;
>> + case HAL_DEF_WOWLAN:
>> + if (ppsc->wo_wlan_mode)
>> + *((bool *)(val)) = true;
>> + else
>> + *((bool *)(val)) = false;
>> + break;
>> default:
>> RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
>> "switch case not processed\n");
>>
>
As far as i know, rtl8192cu is not support WOWLAN.
in rtl8192cu, this code is no effect. so, It is care of unnecessary
debug message.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] rtlwifi: rtl8192cu: Add case in rtl92cu_get_hw_reg
2015-02-25 18:59 ` ap420073 .
@ 2015-02-25 19:12 ` Larry Finger
2015-02-25 19:24 ` ap420073 .
0 siblings, 1 reply; 7+ messages in thread
From: Larry Finger @ 2015-02-25 19:12 UTC (permalink / raw)
To: ap420073 .; +Cc: linux-wireless@vger.kernel.org
On 02/25/2015 12:59 PM, ap420073 . wrote:
> 2015-02-26 3:33 GMT+09:00 Larry Finger <Larry.Finger@lwfinger.net>:
>> On 02/25/2015 11:58 AM, Taehee Yoo wrote:
>>>
>>> rtl_op_stop get wowlan state but rtl92cu_get_hw_reg has not process.
>>>
>>> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
>>
>>
>> Has this been tested? I am not aware that the RTL8192CU firmware could
>> handle WOWLAN.
>>
>> Larry
>>
>>
>>> ---
>>> drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>>
>>> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>>> b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>>> index fe4b699..f6ad959 100644
>>> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>>> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>>> @@ -1589,6 +1589,12 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8
>>> variable, u8 *val)
>>> case HW_VAR_DATA_FILTER:
>>> *((u16 *) (val)) = rtl_read_word(rtlpriv, REG_RXFLTMAP2);
>>> break;
>>> + case HAL_DEF_WOWLAN:
>>> + if (ppsc->wo_wlan_mode)
>>> + *((bool *)(val)) = true;
>>> + else
>>> + *((bool *)(val)) = false;
>>> + break;
>>> default:
>>> RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
>>> "switch case not processed\n");
>>>
>>
>
> As far as i know, rtl8192cu is not support WOWLAN.
> in rtl8192cu, this code is no effect. so, It is care of unnecessary
> debug message.
That is what I thought. In that case, the new code should be
case HAL_DEF_WOWLAN:
break;
Larry
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] rtlwifi: rtl8192cu: Add case in rtl92cu_get_hw_reg
2015-02-25 19:12 ` Larry Finger
@ 2015-02-25 19:24 ` ap420073 .
0 siblings, 0 replies; 7+ messages in thread
From: ap420073 . @ 2015-02-25 19:24 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless@vger.kernel.org, ap420073
2015-02-26 4:12 GMT+09:00 Larry Finger <Larry.Finger@lwfinger.net>:
> On 02/25/2015 12:59 PM, ap420073 . wrote:
>>
>> 2015-02-26 3:33 GMT+09:00 Larry Finger <Larry.Finger@lwfinger.net>:
>>>
>>> On 02/25/2015 11:58 AM, Taehee Yoo wrote:
>>>>
>>>>
>>>> rtl_op_stop get wowlan state but rtl92cu_get_hw_reg has not process.
>>>>
>>>> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
>>>
>>>
>>>
>>> Has this been tested? I am not aware that the RTL8192CU firmware could
>>> handle WOWLAN.
>>>
>>> Larry
>>>
>>>
>>>> ---
>>>> drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 6 ++++++
>>>> 1 file changed, 6 insertions(+)
>>>>
>>>> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>>>> b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>>>> index fe4b699..f6ad959 100644
>>>> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>>>> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
>>>> @@ -1589,6 +1589,12 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw,
>>>> u8
>>>> variable, u8 *val)
>>>> case HW_VAR_DATA_FILTER:
>>>> *((u16 *) (val)) = rtl_read_word(rtlpriv,
>>>> REG_RXFLTMAP2);
>>>> break;
>>>> + case HAL_DEF_WOWLAN:
>>>> + if (ppsc->wo_wlan_mode)
>>>> + *((bool *)(val)) = true;
>>>> + else
>>>> + *((bool *)(val)) = false;
>>>> + break;
>>>> default:
>>>> RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
>>>> "switch case not processed\n");
>>>>
>>>
>>
>> As far as i know, rtl8192cu is not support WOWLAN.
>> in rtl8192cu, this code is no effect. so, It is care of unnecessary
>> debug message.
>
>
> That is what I thought. In that case, the new code should be
>
> case HAL_DEF_WOWLAN:
> break;
>
> Larry
>
Thanks!
I would send a new code.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] rtlwifi: rtl8192cu: Add case in rtl92cu_get_hw_reg
@ 2015-02-25 19:34 Taehee Yoo
2015-02-25 20:23 ` Larry Finger
0 siblings, 1 reply; 7+ messages in thread
From: Taehee Yoo @ 2015-02-25 19:34 UTC (permalink / raw)
To: Larry.Finger, ap420073; +Cc: linux-wireless
Add HAL_DEF_WOWLAN case in rtl92cu_get_hw_reg
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
---
drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
index fe4b699..96bae39 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
@@ -1589,6 +1589,8 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
case HW_VAR_DATA_FILTER:
*((u16 *) (val)) = rtl_read_word(rtlpriv, REG_RXFLTMAP2);
break;
+ case HAL_DEF_WOWLAN:
+ break;
default:
RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
"switch case not processed\n");
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] rtlwifi: rtl8192cu: Add case in rtl92cu_get_hw_reg
2015-02-25 19:34 Taehee Yoo
@ 2015-02-25 20:23 ` Larry Finger
0 siblings, 0 replies; 7+ messages in thread
From: Larry Finger @ 2015-02-25 20:23 UTC (permalink / raw)
To: Taehee Yoo; +Cc: linux-wireless
On 02/25/2015 01:34 PM, Taehee Yoo wrote:
> Add HAL_DEF_WOWLAN case in rtl92cu_get_hw_reg
>
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
@Kalle: This is V2. V1 is not OK.
Larry
> ---
> drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> index fe4b699..96bae39 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> @@ -1589,6 +1589,8 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
> case HW_VAR_DATA_FILTER:
> *((u16 *) (val)) = rtl_read_word(rtlpriv, REG_RXFLTMAP2);
> break;
> + case HAL_DEF_WOWLAN:
> + break;
> default:
> RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
> "switch case not processed\n");
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-02-25 20:23 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-25 17:58 [PATCH] rtlwifi: rtl8192cu: Add case in rtl92cu_get_hw_reg Taehee Yoo
2015-02-25 18:33 ` Larry Finger
2015-02-25 18:59 ` ap420073 .
2015-02-25 19:12 ` Larry Finger
2015-02-25 19:24 ` ap420073 .
-- strict thread matches above, loose matches on Subject: below --
2015-02-25 19:34 Taehee Yoo
2015-02-25 20:23 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).