Re: [PATCH] rtlwifi: rtl8192cu: Remove unnecessary parameter

[Larry Finger <Larry.Finger@lwfinger.net>]

On 03/09/2015 10:07 AM, Taehee Yoo wrote:
> Remove unnecessary parameter in rtl8192cu/hw.c
>
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
> ---
>   drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)

The patch is OK, but the subject is awful. When I first saw it, I thought that 
you were removing a module parameter. On inspection, I see that you are removing 
function arguments from _beacon_function_enable(). Why not say that?

Larry

>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> index 0c20dd7..43b2b20 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> @@ -1471,8 +1471,7 @@ static void _InitBeaconParameters(struct ieee80211_hw *hw)
>   		rtl_write_word(rtlpriv, REG_BCNTCFG, 0x66FF);
>   }
>
> -static void _beacon_function_enable(struct ieee80211_hw *hw, bool Enable,
> -				    bool Linked)
> +static void _beacon_function_enable(struct ieee80211_hw *hw)
>   {
>   	struct rtl_priv *rtlpriv = rtl_priv(hw);
>
> @@ -1517,7 +1516,7 @@ void rtl92cu_set_beacon_related_registers(struct ieee80211_hw *hw)
>   		rtl_write_byte(rtlpriv, REG_RXTSF_OFFSET_CCK, 0x50);
>   		rtl_write_byte(rtlpriv, REG_RXTSF_OFFSET_OFDM, 0x50);
>   	}
> -	_beacon_function_enable(hw, true, true);
> +	_beacon_function_enable(hw);
>   }
>
>   void rtl92cu_set_beacon_interval(struct ieee80211_hw *hw)
>