From: Marc Kleine-Budde <mkl@pengutronix.de>
To: linux-wireless@vger.kernel.org
Cc: Eliad Peller <eliad@wizery.com>,
Kobi Leibovitch <kobi.lev100@gmail.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH 06/13] wlcore: enable sleep during AP mode operation
Date: Wed, 25 Mar 2015 13:27:40 +0100 [thread overview]
Message-ID: <5512A9BC.5010902@pengutronix.de> (raw)
In-Reply-To: <1419834253-18331-6-git-send-email-eliad@wizery.com>
[-- Attachment #1: Type: text/plain, Size: 2562 bytes --]
On 12/29/2014 07:24 AM, Eliad Peller wrote:
> From: Kobi L <kobi.lev100@gmail.com>
>
> Enable ELP authorization in AP mode and enable the use
> of the wakeup bit in the ELP register.
>
> Introduce AP role sleep configuration which is disabled
> by default. When configured, it allows the AP to sleep
> when ELP is authorized for it.
>
> Signed-off-by: Kobi Leibovitch <kobi.lev100@gmail.com>
> Signed-off-by: Arik Nemtsov <arik@wizery.com>
> Signed-off-by: Eliad Peller <eliad@wizery.com>
[...]
> diff --git a/drivers/net/wireless/ti/wl18xx/conf.h b/drivers/net/wireless/ti/wl18xx/conf.h
> index e34302e..71f1ec4 100644
> --- a/drivers/net/wireless/ti/wl18xx/conf.h
> +++ b/drivers/net/wireless/ti/wl18xx/conf.h
> @@ -23,7 +23,7 @@
> #define __WL18XX_CONF_H__
>
> #define WL18XX_CONF_MAGIC 0x10e100ca
> -#define WL18XX_CONF_VERSION (WLCORE_CONF_VERSION | 0x0006)
> +#define WL18XX_CONF_VERSION (WLCORE_CONF_VERSION | 0x0007)
> #define WL18XX_CONF_MASK 0x0000ffff
> #define WL18XX_CONF_SIZE (WLCORE_CONF_SIZE + \
> sizeof(struct wl18xx_priv_conf))
> @@ -110,12 +110,33 @@ struct wl18xx_ht_settings {
> u8 mode;
> } __packed;
>
> +struct conf_ap_sleep_settings {
> + /* Duty Cycle (20-80% of staying Awake) for IDLE AP
> + * (0: disable)
> + */
> + u8 idle_duty_cycle;
> + /* Duty Cycle (20-80% of staying Awake) for Connected AP
> + * (0: disable)
> + */
> + u8 connected_duty_cycle;
> + /* Maximum stations that are allowed to be connected to AP
> + * (255: no limit)
> + */
> + u8 max_stations_thresh;
> + /* Timeout till enabling the Sleep Mechanism after data stops
> + * [unit: 100 msec]
> + */
> + u8 idle_conn_thresh;
> +} __packed;
> +
> struct wl18xx_priv_conf {
> /* Module params structures */
> struct wl18xx_ht_settings ht;
>
> /* this structure is copied wholesale to FW */
> struct wl18xx_mac_and_phy_params phy;
> +
> + struct conf_ap_sleep_settings ap_sleep;
> } __packed;
This patch requires a new firmware, loading of "wl18xx-conf.bin" from
[1] fails with:
> wlcore: ERROR configuration binary file size is wrong, expected 1226 got 1221
regards,
Marc
[1]
http://git.kernel.org/cgit/linux/kernel/git/firmware/linux-firmware.git/tree/ti-connectivity
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-03-25 12:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-29 6:24 [PATCH 01/13] wlcore: fix WLCORE_VENDOR_ATTR_GROUP_KEY policy Eliad Peller
2014-12-29 6:24 ` [PATCH 02/13] wlcore: fix sparse warning Eliad Peller
2014-12-29 6:24 ` [PATCH 03/13] wlcore/wl18xx: handle rc updates in a separate work Eliad Peller
2014-12-29 6:24 ` [PATCH 04/13] wlcore: add ability to reduce FW interrupts during suspend Eliad Peller
2014-12-29 6:24 ` [PATCH 05/13] wlcore: enable AP wowlan Eliad Peller
2014-12-29 6:24 ` [PATCH 06/13] wlcore: enable sleep during AP mode operation Eliad Peller
2015-03-25 12:27 ` Marc Kleine-Budde [this message]
2015-03-25 12:58 ` Eliad Peller
2015-03-25 13:24 ` Marc Kleine-Budde
2015-03-25 13:45 ` Eliad Peller
2015-05-04 9:16 ` Yegor Yefremov
2015-05-06 8:32 ` Eliad Peller
2015-05-06 9:03 ` Yegor Yefremov
2014-12-29 6:24 ` [PATCH 07/13] wl18xx: add radar detection implementation Eliad Peller
2014-12-29 6:24 ` [PATCH 08/13] wl18xx: add debugfs file to emulate radar event Eliad Peller
2014-12-29 6:24 ` [PATCH 09/13] wlcore: add support for ap csa Eliad Peller
2014-12-29 6:24 ` [PATCH 10/13] wlcore: add dfs master restart calls Eliad Peller
2014-12-29 6:24 ` [PATCH 11/13] wlcore: allow using dfs channels Eliad Peller
2014-12-29 6:24 ` [PATCH 12/13] wlcore: add dfs region to reg domain update cmd Eliad Peller
2014-12-29 6:24 ` [PATCH 13/13] wl18xx: declare radar_detect_widths support for ap interfaces Eliad Peller
2015-01-07 17:55 ` [PATCH 01/13] wlcore: fix WLCORE_VENDOR_ATTR_GROUP_KEY policy Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5512A9BC.5010902@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=eliad@wizery.com \
--cc=kernel@pengutronix.de \
--cc=kobi.lev100@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).