[PATCH] staging: vt6656: vnt_rf_setpower: fix missing rate RATE_12M

[PATCH] staging: vt6656: vnt_rf_setpower: fix missing rate RATE_12M

[Malcolm Priestley]

When the driver sets this rate a power of zero value is set causing
data flow stoppage until another rate is tried.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Cc: <stable@vger.kernel.org> # v3.17+
---
 drivers/staging/vt6656/rf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
index c42cde5..c4286cc 100644
--- a/drivers/staging/vt6656/rf.c
+++ b/drivers/staging/vt6656/rf.c
@@ -640,6 +640,7 @@ int vnt_rf_setpower(struct vnt_private *priv, u32 rate, u32 channel)
 		break;
 	case RATE_6M:
 	case RATE_9M:
+	case RATE_12M:
 	case RATE_18M:
 	case RATE_24M:
 	case RATE_36M:
-- 
2.1.4

Re: [PATCH] staging: vt6656: vnt_rf_setpower: fix missing rate RATE_12M

[Luis Henriques]

Hi Malcolm,

On Sat, Mar 07, 2015 at 04:36:37PM +0000, Malcolm Priestley wrote:
> When the driver sets this rate a power of zero value is set causing
> data flow stoppage until another rate is tried.
> 
> Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
> Cc: <stable@vger.kernel.org> # v3.17+

Is there a reason for this patch being tagged for stable v3.17+ ?

I'm asking because there's a similar commit for vt6655 (40c8790bcb7a
"vt6655: RFbSetPower fix missing rate RATE_12M") which was tagged for
stable without the "v3.17+", and thus I assume applicable to other
trees as well (e.g. 3.16).

Cheers,
--
Luís

> ---
>  drivers/staging/vt6656/rf.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
> index c42cde5..c4286cc 100644
> --- a/drivers/staging/vt6656/rf.c
> +++ b/drivers/staging/vt6656/rf.c
> @@ -640,6 +640,7 @@ int vnt_rf_setpower(struct vnt_private *priv, u32 rate, u32 channel)
>  		break;
>  	case RATE_6M:
>  	case RATE_9M:
> +	case RATE_12M:
>  	case RATE_18M:
>  	case RATE_24M:
>  	case RATE_36M:
> -- 
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] staging: vt6656: vnt_rf_setpower: fix missing rate RATE_12M

[Malcolm Priestley]

On 26/03/15 15:22, Luis Henriques wrote:
> Hi Malcolm,
>
> On Sat, Mar 07, 2015 at 04:36:37PM +0000, Malcolm Priestley wrote:
>> When the driver sets this rate a power of zero value is set causing
>> data flow stoppage until another rate is tried.
>>
>> Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
>> Cc: <stable@vger.kernel.org> # v3.17+
>
> Is there a reason for this patch being tagged for stable v3.17+ ?
Hi Luis

Sorry I thought it wouldn't apply to 3.16.

I need to do a backport patch for earlier kernels.

Regards

Malcolm

Re: [PATCH] staging: vt6656: vnt_rf_setpower: fix missing rate RATE_12M

[Luis Henriques]

On Thu, Mar 26, 2015 at 06:33:18PM +0000, Malcolm Priestley wrote:
> 
> 
> On 26/03/15 15:22, Luis Henriques wrote:
> >Hi Malcolm,
> >
> >On Sat, Mar 07, 2015 at 04:36:37PM +0000, Malcolm Priestley wrote:
> >>When the driver sets this rate a power of zero value is set causing
> >>data flow stoppage until another rate is tried.
> >>
> >>Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
> >>Cc: <stable@vger.kernel.org> # v3.17+
> >
> >Is there a reason for this patch being tagged for stable v3.17+ ?
> Hi Luis
> 
> Sorry I thought it wouldn't apply to 3.16.
> 
> I need to do a backport patch for earlier kernels.
> 

Awesome, thanks for the quick reply.

Commit 163fe301b9f78b6de57d0014eafe504fd20c0cd4 is a clean cherry-pick
to 3.16 kernel, but I haven't check which other kernels it should also
be applied to.

Cheers,
--
Luís

> Regards
> 
> Malcolm
>