linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arend van Spriel <arend@broadcom.com>
To: Luca Coelho <luca@coelho.fi>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	Jouni Malinen <j@w1.fi>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: broadcast ssid in scheduled scan
Date: Wed, 1 Apr 2015 11:01:53 +0200	[thread overview]
Message-ID: <551BB401.7070607@broadcom.com> (raw)
In-Reply-To: <1427869720.10642.6.camel@coelho.fi>

On 04/01/15 08:28, Luca Coelho wrote:
> On Tue, 2015-03-31 at 16:21 +0200, Johannes Berg wrote:
>> On Mon, 2015-03-23 at 19:38 +0100, Arend van Spriel wrote:
>>> Johannes, Jouni,
>>>
>>> I have noticed that under some circumstances wpa_supplicant initiates a
>>> scheduled scan with broadcast ssid. This is something our firmware can
>>> not do so could this be avoided? Maybe by adding a feature flag for it.
>>
>> I guess this would be difficult to do since you'd basically have to
>> "remove" support for normal scheduled scan (that assumes this ability)
>> and add support for another scheduled scan (that doesn't assume it) in
>> nl80211 ... just to be compatible with older implementations of
>> wpa_supplicant etc.
>>
>> I do wonder why the firmware cannot do this though - there's no
>> fundamental reason the 0-length SSID is all that different from a 1-byte
>> one?
>
> Is the problem in having a 0-length SSID in the probe_reqs or is it in
> having it in the matches (i.e. it doesn't support "pass all")? The
> latter makes a bit more sense, since filtering on a 0-length SSID, if
> not treated specially, would return nothing (since it would never match,
> unless an AP does send an SSID IE with 0-length).

This is indeed the issue. The scheduled scan firmware implementation 
sits on top of the scan engine and tries to match found bss'es. So 
having a broadcast ssid in struct cfg80211_sched_scan_request::ssids but 
it is for struct cfg80211_sched_scan_request::match_sets.

> It doesn't make much sense to have a "match all" scheduled scan though,
> unless wpa_s needs to find more SSIDs than what the driver supports.
> Even in that case, it wouldn't make much difference than using a normal
> scan periodically...

That is what scheduled scan with only broadcast ssid intends to do, 
right? I guess the advantage is that host can be idle.

Regards,
Arend

> --
> Luca.
>


      reply	other threads:[~2015-04-01  9:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-23 18:38 broadcast ssid in scheduled scan Arend van Spriel
2015-03-23 21:37 ` Arend van Spriel
2015-03-31 14:21 ` Johannes Berg
2015-04-01  6:28   ` Luca Coelho
2015-04-01  9:01     ` Arend van Spriel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551BB401.7070607@broadcom.com \
    --to=arend@broadcom.com \
    --cc=j@w1.fi \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luca@coelho.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).