* [PATCH] staging: vt6655: Fix TX retransmission race condition
@ 2015-04-11 23:47 Malcolm Priestley
2015-04-18 7:18 ` Malcolm Priestley
0 siblings, 1 reply; 2+ messages in thread
From: Malcolm Priestley @ 2015-04-11 23:47 UTC (permalink / raw)
To: gregkh; +Cc: linux-wireless, Malcolm Priestley, stable
With high tx flow the same buffer can transmit more than
once and get stuck in loop.
Reset TCR to zero in device_tx_srv.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Cc: <stable@vger.kernel.org> # v3.19+
---
drivers/staging/vt6655/device_main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index c5f8233..9b5d840 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -963,6 +963,9 @@ static int device_tx_srv(struct vnt_private *pDevice, unsigned int uIdx)
vnt_int_report_rate(pDevice, pTD->pTDInfo, byTsr0, byTsr1);
device_free_tx_buf(pDevice, pTD);
+
+ /* Done with TCR reset to avoid retransmission */
+ pTD->m_td1TD1.byTCR = 0;
pDevice->iTDUsed[uIdx]--;
}
}
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: vt6655: Fix TX retransmission race condition
2015-04-11 23:47 [PATCH] staging: vt6655: Fix TX retransmission race condition Malcolm Priestley
@ 2015-04-18 7:18 ` Malcolm Priestley
0 siblings, 0 replies; 2+ messages in thread
From: Malcolm Priestley @ 2015-04-18 7:18 UTC (permalink / raw)
To: gregkh; +Cc: linux-wireless, stable
On 12/04/15 00:47, Malcolm Priestley wrote:
> With high tx flow the same buffer can transmit more than
> once and get stuck in loop.
>
> Reset TCR to zero in device_tx_srv.
>
> Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
> Cc: <stable@vger.kernel.org> # v3.19+
> ---
> drivers/staging/vt6655/device_main.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index c5f8233..9b5d840 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -963,6 +963,9 @@ static int device_tx_srv(struct vnt_private *pDevice, unsigned int uIdx)
> vnt_int_report_rate(pDevice, pTD->pTDInfo, byTsr0, byTsr1);
>
> device_free_tx_buf(pDevice, pTD);
> +
> + /* Done with TCR reset to avoid retransmission */
> + pTD->m_td1TD1.byTCR = 0;
> pDevice->iTDUsed[uIdx]--;
> }
> }
Hi Greg
Please could you drop this patch, it causes a regression in driver.
Thanks
Malcolm
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-18 7:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-11 23:47 [PATCH] staging: vt6655: Fix TX retransmission race condition Malcolm Priestley
2015-04-18 7:18 ` Malcolm Priestley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).