From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-gw3-out.broadcom.com ([216.31.210.64]:17842 "EHLO mail-gw3-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751705AbbDTUQi (ORCPT ); Mon, 20 Apr 2015 16:16:38 -0400 Message-ID: <55355E9D.30209@broadcom.com> (sfid-20150420_221641_319807_82AC59CB) Date: Mon, 20 Apr 2015 22:16:29 +0200 From: Arend van Spriel MIME-Version: 1.0 To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= CC: Hante Meuleman , "linux-wireless@vger.kernel.org" , Kalle Valo , mailinglist , Florian Fainelli Subject: Re: [PATCH 10/10] brcmfmac: Add support for multiple PCIE devices in nvram. References: <1429035033-14076-1-git-send-email-arend@broadcom.com> <1429035033-14076-11-git-send-email-arend@broadcom.com> <5530C940.6010407@broadcom.com> <55353364.3050101@broadcom.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 04/20/15 20:49, Rafał Miłecki wrote: > On 20 April 2015 at 19:12, Arend van Spriel wrote: >> On 04/20/15 13:26, Rafał Miłecki wrote: >>> >>> On 17 April 2015 at 10:50, Arend van Spriel wrote: >>>> Another option is to add the parsing stuff in that nvram code and have an >>>> api to get the appropriate portion based on pcie domain and bus number as >>>> used in brcmf_fw_get_firmwares_pcie(). However, I would prefer to have >>>> this >>>> in the driver and not in arch specific code as there may be other >>>> platforms >>>> like our set-top boxes needing this. >>> >>> >>> This is some plan for the future I was lacking from the beginning. It >>> makes things more clear now, thanks. >> >> You're welcome. Do you want to see this clarification in the commit message? > > I don't really need that, I'm leaving it up to you :) > > The last remaining question from me is if about this NVRAM validation > function (if it exists). Ok. I can try to answer that one. The nvram parsing code in firmware.c intends to do just that. So apart from stripping comments and whitespace it validates each line and gives off a warning if a wrongly formatted entry is found. Regards, Arend