From: Arend van Spriel <arend@broadcom.com>
To: "Fu, Zhonghui" <zhonghui.fu@linux.intel.com>
Cc: "brudley@broadcom.com" <brudley@broadcom.com>,
Franky Lin <frankyl@broadcom.com>,
"meuleman@broadcom.com" <meuleman@broadcom.com>,
Kalle Valo <kvalo@codeaurora.org>,
"pieterpg@broadcom.com" <pieterpg@broadcom.com>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"brcm80211-dev-list@broadcom.com"
<brcm80211-dev-list@broadcom.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 1/2] brcmfmac: prohibit ACPI power management for brcmfmac driver
Date: Mon, 27 Apr 2015 10:59:06 +0200 [thread overview]
Message-ID: <553DFA5A.3090802@broadcom.com> (raw)
In-Reply-To: <553DC280.6080503@linux.intel.com>
On 04/27/15 07:00, Fu, Zhonghui wrote:
> ACPI will manage WiFi chip's power state during suspend/resume
> process on some tablet platforms(such as ASUS T100TA). This is
> not supported by brcmfmac driver now, and the context of WiFi
> chip will be damaged after resume. This patch disconnects the
> relationship between WiFi chip and it's ACPI companion, and
> prohibit ACPI PM for it.
Nice. However, ACPI may contain configuration data that brcmfmac needs
on some platforms and Adrian Hunter is looking into this. So it is
probably better to do this operation at the end of the probe before
returning successful.
Regards,
Arend
> Signed-off-by: Zhonghui Fu<zhonghui.fu@linux.intel.com>
> ---
> drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
next prev parent reply other threads:[~2015-04-27 8:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 5:00 [PATCH 1/2] brcmfmac: prohibit ACPI power management for brcmfmac driver Fu, Zhonghui
2015-04-27 8:59 ` Arend van Spriel [this message]
2015-05-03 15:30 ` Fu, Zhonghui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553DFA5A.3090802@broadcom.com \
--to=arend@broadcom.com \
--cc=adrian.hunter@intel.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brudley@broadcom.com \
--cc=frankyl@broadcom.com \
--cc=hdegoede@redhat.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=meuleman@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pieterpg@broadcom.com \
--cc=zhonghui.fu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).