From: "Clément Perrochaud" <clement.perrochaud@effinnov.com>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: sameo@linux.intel.com, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, lauro.venancio@openbossa.org,
aloisio.almeida@openbossa.org, Paul Bolle <pebolle@tiscali.nl>,
Andreas Ruprecht <rupran@einserver.de>,
hengelein Stefan <stefan.hengelein@fau.de>
Subject: Re: NFC: CONFIG_NFC_DEBUG not defined
Date: Tue, 28 Apr 2015 10:23:30 +0200 [thread overview]
Message-ID: <553F4382.2070402@effinnov.com> (raw)
In-Reply-To: <CAD3Xx4+eZOrgm_ae9UeUWB+EfUdi5B1jqs1R-CxYzYZ5AvHyfQ@mail.gmail.com>
On Mon, Apr 27, 2015 at 9:03 AM, Valentin Rothberg wrote:
> Hi Clément,
>
> your commit dece45855a8b ("NFC: nxp-nci: Add support for NXP NCI
> chips") adds the Makefile drivers/nfc/nxp-nci/Makefile with the
> following line:
>
> +ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG
>
> The Kconfig option NFC_DEBUG is not defined so the line turns out to
> be a nop. There is another reference in drivers/nfc/Makefile. Is
> there a patch queued somewhere to add the option?
>
> I found this issue with ./scripts/checkkconfigsymbols.py by diffing
> v4.0 and v4.1-rc1.
Hi Valentin,
I only included this line because it was present in the upper-level
Makefile drivers/nfc/Makefile . As far as I know, there is no plan to
add this option to the configuration.
What would the most sensible solution to this issue be ? Add the NFC
Debug feature to the configuration ? Remove it altogether ?
Regards,
--
Clément Perrochaud
Eff'Innov Technologies
Caen, Aix-En-Provence, Grenoble
Eff'Innov Technologies
Campus EffiScience
2, Esplanade Anton Philips
14460 Colombelles, FRANCE
http://www.effinnov.com
next prev parent reply other threads:[~2015-04-28 10:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 7:03 NFC: CONFIG_NFC_DEBUG not defined Valentin Rothberg
2015-04-27 7:06 ` Valentin Rothberg
2015-04-28 8:23 ` Clément Perrochaud [this message]
2015-04-28 8:35 ` Valentin Rothberg
2015-04-28 8:38 ` Clément Perrochaud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553F4382.2070402@effinnov.com \
--to=clement.perrochaud@effinnov.com \
--cc=aloisio.almeida@openbossa.org \
--cc=lauro.venancio@openbossa.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=rupran@einserver.de \
--cc=sameo@linux.intel.com \
--cc=stefan.hengelein@fau.de \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).