* NFC: CONFIG_NFC_DEBUG not defined
@ 2015-04-27 7:03 Valentin Rothberg
2015-04-27 7:06 ` Valentin Rothberg
0 siblings, 1 reply; 5+ messages in thread
From: Valentin Rothberg @ 2015-04-27 7:03 UTC (permalink / raw)
To: clement.perrochaud
Cc: sameo, linux-wireless, linux-kernel, lauro.venancio,
aloisio.almeida, Paul Bolle, Andreas Ruprecht, hengelein Stefan
Hi Clément,
your commit dece45855a8b ("NFC: nxp-nci: Add support for NXP NCI
chips") adds the Makefile drivers/nfc/nxp-nci/Makefile with the
following line:
+ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG
The Kconfig option NFC_DEBUG is not defined so the line turns out to
be a nop. There is another reference in drivers/nfc/Makefile. Is
there a patch queued somewhere to add the option?
I found this issue with ./scripts/checkkconfigsymbols.py by diffing
v4.0 and v4.1-rc1.
Kind regards,
Valentin
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: NFC: CONFIG_NFC_DEBUG not defined 2015-04-27 7:03 NFC: CONFIG_NFC_DEBUG not defined Valentin Rothberg @ 2015-04-27 7:06 ` Valentin Rothberg 2015-04-28 8:23 ` Clément Perrochaud 0 siblings, 1 reply; 5+ messages in thread From: Valentin Rothberg @ 2015-04-27 7:06 UTC (permalink / raw) To: clement.perrochaud Cc: sameo, linux-wireless, linux-kernel, lauro.venancio, aloisio.almeida, Paul Bolle, Andreas Ruprecht, hengelein Stefan I took the email from the author field of the commit, which does not exists anymore. Now I added Clément's correct email address. On Mon, Apr 27, 2015 at 9:03 AM, Valentin Rothberg <valentinrothberg@gmail.com> wrote: > Hi Clément, > > your commit dece45855a8b ("NFC: nxp-nci: Add support for NXP NCI > chips") adds the Makefile drivers/nfc/nxp-nci/Makefile with the > following line: > > +ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG > > The Kconfig option NFC_DEBUG is not defined so the line turns out to > be a nop. There is another reference in drivers/nfc/Makefile. Is > there a patch queued somewhere to add the option? > > I found this issue with ./scripts/checkkconfigsymbols.py by diffing > v4.0 and v4.1-rc1. > > Kind regards, > Valentin ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: NFC: CONFIG_NFC_DEBUG not defined 2015-04-27 7:06 ` Valentin Rothberg @ 2015-04-28 8:23 ` Clément Perrochaud 2015-04-28 8:35 ` Valentin Rothberg 0 siblings, 1 reply; 5+ messages in thread From: Clément Perrochaud @ 2015-04-28 8:23 UTC (permalink / raw) To: Valentin Rothberg Cc: sameo, linux-wireless, linux-kernel, lauro.venancio, aloisio.almeida, Paul Bolle, Andreas Ruprecht, hengelein Stefan On Mon, Apr 27, 2015 at 9:03 AM, Valentin Rothberg wrote: > Hi Clément, > > your commit dece45855a8b ("NFC: nxp-nci: Add support for NXP NCI > chips") adds the Makefile drivers/nfc/nxp-nci/Makefile with the > following line: > > +ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG > > The Kconfig option NFC_DEBUG is not defined so the line turns out to > be a nop. There is another reference in drivers/nfc/Makefile. Is > there a patch queued somewhere to add the option? > > I found this issue with ./scripts/checkkconfigsymbols.py by diffing > v4.0 and v4.1-rc1. Hi Valentin, I only included this line because it was present in the upper-level Makefile drivers/nfc/Makefile . As far as I know, there is no plan to add this option to the configuration. What would the most sensible solution to this issue be ? Add the NFC Debug feature to the configuration ? Remove it altogether ? Regards, -- Clément Perrochaud Eff'Innov Technologies Caen, Aix-En-Provence, Grenoble Eff'Innov Technologies Campus EffiScience 2, Esplanade Anton Philips 14460 Colombelles, FRANCE http://www.effinnov.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: NFC: CONFIG_NFC_DEBUG not defined 2015-04-28 8:23 ` Clément Perrochaud @ 2015-04-28 8:35 ` Valentin Rothberg 2015-04-28 8:38 ` Clément Perrochaud 0 siblings, 1 reply; 5+ messages in thread From: Valentin Rothberg @ 2015-04-28 8:35 UTC (permalink / raw) To: Clément Perrochaud Cc: sameo, linux-wireless, linux-kernel, lauro.venancio, aloisio.almeida, Paul Bolle, Andreas Ruprecht, hengelein Stefan Hi Clément, thanks for your answer. On Tue, Apr 28, 2015 at 10:23 AM, Clément Perrochaud <clement.perrochaud@effinnov.com> wrote: > On Mon, Apr 27, 2015 at 9:03 AM, Valentin Rothberg wrote: >> Hi Clément, >> >> your commit dece45855a8b ("NFC: nxp-nci: Add support for NXP NCI >> chips") adds the Makefile drivers/nfc/nxp-nci/Makefile with the >> following line: >> >> +ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG >> >> The Kconfig option NFC_DEBUG is not defined so the line turns out to >> be a nop. There is another reference in drivers/nfc/Makefile. Is >> there a patch queued somewhere to add the option? >> >> I found this issue with ./scripts/checkkconfigsymbols.py by diffing >> v4.0 and v4.1-rc1. > > Hi Valentin, > > I only included this line because it was present in the upper-level > Makefile drivers/nfc/Makefile . As far as I know, there is no plan to > add this option to the configuration. > > What would the most sensible solution to this issue be ? Add the NFC > Debug feature to the configuration ? Remove it altogether ? DEBUG is not used in any of the files in drivers/nfc/ so I think we can safely remove the two lines from the Makefiles. Do you want me to prepare a patch? Kind regards, Valentin > Regards, > > -- > Clément Perrochaud > > Eff'Innov Technologies > Caen, Aix-En-Provence, Grenoble > > Eff'Innov Technologies > Campus EffiScience > 2, Esplanade Anton Philips > 14460 Colombelles, FRANCE > > http://www.effinnov.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: NFC: CONFIG_NFC_DEBUG not defined 2015-04-28 8:35 ` Valentin Rothberg @ 2015-04-28 8:38 ` Clément Perrochaud 0 siblings, 0 replies; 5+ messages in thread From: Clément Perrochaud @ 2015-04-28 8:38 UTC (permalink / raw) To: Valentin Rothberg Cc: sameo, linux-wireless, linux-kernel, lauro.venancio, aloisio.almeida, Paul Bolle, Andreas Ruprecht, hengelein Stefan On 04/28/2015 10:35 AM, Valentin Rothberg wrote: > DEBUG is not used in any of the files in drivers/nfc/ so I think we > can safely remove the two lines from the Makefiles. Do you want me to > prepare a patch? That would be great, thanks. -- Clément Perrochaud Eff'Innov Technologies Caen, Aix-En-Provence, Grenoble Eff'Innov Technologies Campus EffiScience 2, Esplanade Anton Philips 14460 Colombelles, FRANCE http://www.effinnov.com ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-04-28 11:06 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-04-27 7:03 NFC: CONFIG_NFC_DEBUG not defined Valentin Rothberg 2015-04-27 7:06 ` Valentin Rothberg 2015-04-28 8:23 ` Clément Perrochaud 2015-04-28 8:35 ` Valentin Rothberg 2015-04-28 8:38 ` Clément Perrochaud
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).