From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Kalle Valo <kvalo@kernel.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
linux-wireless@vger.kernel.org, Ping-Ke Shih <pkshih@realtek.com>,
Bjorn Helgaas <bhelgaas@google.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 7/7] rtlwifi: rtl8821ae: Access full PMCS reg and use pci_regs.h
Date: Mon, 20 Nov 2023 12:06:17 +0200 (EET) [thread overview]
Message-ID: <553cda39-ffe7-e9b3-a38b-d1f3381b485@linux.intel.com> (raw)
In-Reply-To: <20231117224842.GA96270@bhelgaas>
[-- Attachment #1: Type: text/plain, Size: 771 bytes --]
On Fri, 17 Nov 2023, Bjorn Helgaas wrote:
> On Fri, Nov 17, 2023 at 11:44:25AM +0200, Ilpo Järvinen wrote:
> > _rtl8821ae_clear_pci_pme_status() accesses the upper byte of the Power
> > Management Control/Status register (PMCS) with literal 5 offset.
> >
> > Access the entire PMCS register using defines from pci_regs.h to
> > improve code readability.
> >
> > While at it, remove the obvious comment and tweak debug prints
> > slightly to not sound misleading.
>
> OK, ignore my previous comments ;) I should read all the way through
> before responding.
Please don't do that because then you'll just end up forgetting useful
comments. :-)
I had this all in one patch initially but thought it's better to split it
a bit.
Thanks a lot for reviewing.
--
i.
prev parent reply other threads:[~2023-11-20 10:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 9:44 [PATCH 0/7] rtlwifi: PCIe capability access fix + improvements Ilpo Järvinen
2023-11-17 9:44 ` [PATCH 1/7] wifi: rtlwifi: Convert LNKCTL change to PCIe cap RMW accessors Ilpo Järvinen
2023-11-17 22:24 ` Bjorn Helgaas
2023-11-20 9:25 ` Ilpo Järvinen
2023-11-22 14:54 ` Kalle Valo
2023-11-17 9:44 ` [PATCH 2/7] wifi: rtlwifi: Convert to use PCIe capability accessors Ilpo Järvinen
2023-11-17 22:37 ` Bjorn Helgaas
2023-11-20 8:54 ` Ilpo Järvinen
2023-11-17 9:44 ` [PATCH 3/7] rtlwifi: rtl8821ae: Remove unnecessary PME_Status bit set Ilpo Järvinen
2023-11-17 9:44 ` [PATCH 4/7] rtlwifi: rtl8821ae: Reverse PM capability exists check Ilpo Järvinen
2023-11-17 22:44 ` Bjorn Helgaas
2023-11-20 9:59 ` Ilpo Järvinen
2023-11-17 9:44 ` [PATCH 5/7] rtlwifi: rtl8821ae: Use pci_find_capability() Ilpo Järvinen
2023-11-17 22:46 ` Bjorn Helgaas
2023-11-17 9:44 ` [PATCH 6/7] rtlwifi: rtl8821ae: Add pdev into _rtl8821ae_clear_pci_pme_status() Ilpo Järvinen
2023-11-17 9:44 ` [PATCH 7/7] rtlwifi: rtl8821ae: Access full PMCS reg and use pci_regs.h Ilpo Järvinen
2023-11-17 22:48 ` Bjorn Helgaas
2023-11-20 10:06 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553cda39-ffe7-e9b3-a38b-d1f3381b485@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=Larry.Finger@lwfinger.net \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).