* Re: [PATCH 1/1] New driver: rtl8723au (mac80211)
@ 2015-05-05 20:04 Xose Vazquez Perez
2015-05-05 21:40 ` Jes Sorensen
0 siblings, 1 reply; 35+ messages in thread
From: Xose Vazquez Perez @ 2015-05-05 20:04 UTC (permalink / raw)
To: Jes Sorensen, linux-wireless
Jes Sorensen wrote:
> [...]
> diff --git a/drivers/net/wireless/Makefile b/drivers/net/wireless/Makefile
> index 0c88916..e3911cc 100644
> --- a/drivers/net/wireless/Makefile
> +++ b/drivers/net/wireless/Makefile
> @@ -39,6 +39,8 @@ obj-$(CONFIG_LIBERTAS_THINFIRM) += libertas_tf/
>
> obj-$(CONFIG_ADM8211) += adm8211.o
>
> +obj-$(CONFIG_RTL8XXXU) += rtl8xxxu.o
> +
> [...]
rtl8xxxu is a really bad name.
You can see at: https://wireless.wiki.kernel.org/en/users/drivers/rtl819x
the normalized nomenclature for realtek drivers.
^ permalink raw reply [flat|nested] 35+ messages in thread* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-05-05 20:04 [PATCH 1/1] New driver: rtl8723au (mac80211) Xose Vazquez Perez @ 2015-05-05 21:40 ` Jes Sorensen 2015-05-07 9:43 ` Xose Vazquez Perez 0 siblings, 1 reply; 35+ messages in thread From: Jes Sorensen @ 2015-05-05 21:40 UTC (permalink / raw) To: Xose Vazquez Perez; +Cc: linux-wireless Xose Vazquez Perez <xose.vazquez@gmail.com> writes: > Jes Sorensen wrote: > >> [...] >> diff --git a/drivers/net/wireless/Makefile b/drivers/net/wireless/Makefile >> index 0c88916..e3911cc 100644 >> --- a/drivers/net/wireless/Makefile >> +++ b/drivers/net/wireless/Makefile >> @@ -39,6 +39,8 @@ obj-$(CONFIG_LIBERTAS_THINFIRM) += libertas_tf/ >> >> obj-$(CONFIG_ADM8211) += adm8211.o >> >> +obj-$(CONFIG_RTL8XXXU) += rtl8xxxu.o >> + >> [...] > > rtl8xxxu is a really bad name. > > You can see at: https://wireless.wiki.kernel.org/en/users/drivers/rtl819x > the normalized nomenclature for realtek drivers. Right, the driver covers USB devices, hence the u at the end of the name. As I posted elsewhere, I intend to add support for other rtl8xxx USB chips, hence the 8xxx name. What is your issue? Jes ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-05-05 21:40 ` Jes Sorensen @ 2015-05-07 9:43 ` Xose Vazquez Perez 2015-05-07 15:43 ` Larry Finger 0 siblings, 1 reply; 35+ messages in thread From: Xose Vazquez Perez @ 2015-05-07 9:43 UTC (permalink / raw) To: Jes Sorensen; +Cc: linux-wireless On 05/05/2015 11:40 PM, Jes Sorensen wrote: > As I posted elsewhere, I intend to add support for other rtl8xxx > USB chips, hence the 8xxx name. How many kinds of chips will support ? ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-05-07 9:43 ` Xose Vazquez Perez @ 2015-05-07 15:43 ` Larry Finger 0 siblings, 0 replies; 35+ messages in thread From: Larry Finger @ 2015-05-07 15:43 UTC (permalink / raw) To: Xose Vazquez Perez, Jes Sorensen; +Cc: linux-wireless On 05/07/2015 04:43 AM, Xose Vazquez Perez wrote: > On 05/05/2015 11:40 PM, Jes Sorensen wrote: > >> As I posted elsewhere, I intend to add support for other rtl8xxx >> USB chips, hence the 8xxx name. > > How many kinds of chips will support ? The potential list of USB chips includes RTL8192DU, RTL8723BU, RTL8812AU, and RTL8188EU. In addition, the SDIO chips RTL8723AS and RTL8723BS might fit under this umbrella. Larry ^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH v3 0/1] New driver: rtl8723au (mac80211) @ 2015-03-23 20:24 Jes.Sorensen 2015-03-23 20:25 ` [PATCH 1/1] " Jes.Sorensen 0 siblings, 1 reply; 35+ messages in thread From: Jes.Sorensen @ 2015-03-23 20:24 UTC (permalink / raw) To: linux-wireless; +Cc: Larry.Finger From: Jes Sorensen <Jes.Sorensen@redhat.com> This is a new driver for the rtl8723au which was written from scratch, to utilize the Linux mac80211 stack. This has been a pet project for me for some time I finally feel it is stable enough to submit. I have used it for a while without any serious issues. I started working on cleaning up the vendor provided driver in staging/rtl8723au over a year ago. After spending 6 months on it, it became obvious to me that it was a rather hopeless task, and I started writing this driver from scratch. I do not have any specs for the chip, so everything is based on knowledge I obtained from dissecting the vendor driver. Special thanks to Larry Finger for help with the original rtl8723au driver, and Johannes Berg for answering all my silly questions about 802.11 innards and the mac80211 stack. Had I known then what I know today about 802.11, I probably would never have so mad as to start this project in the first place! v2 fixes an endian problem reported by Joe Perches, and adds a module debug parameter so one doesn't have to recompile the driver to change the debug mask (I was convinced I had that as a module parameter already). The latter was suggested by Larry Finger. v3 resolves the issues and suggestions provided by Johannes Berg to the v2 patch. Discussing with Johannes we agreed it was cleaner to keep the flow folling the BSS_CHANGED events rather than sticking it into sta_state(). In addition I fixed cleaned up a couple of other parts of the code. There are still some debug portions and code that is #if 0'ed out. I prefer to keep this in place for now as some of it is meant to be enabled later, and other portions I use to match up tables and code to the vendor driver when trying to trace issues when debugging. The code is still work in progress, in particular I want to get AMPDU for TX going, but it will be a little while before I get time to address that. Cheers, Jes Jes Sorensen (1): New driver: rtl8723au (mac80211) MAINTAINERS | 8 + drivers/net/wireless/Kconfig | 19 + drivers/net/wireless/Makefile | 2 + drivers/net/wireless/rtl8xxxu.c | 4500 ++++++++++++++++++++++++++++++++++ drivers/net/wireless/rtl8xxxu.h | 497 ++++ drivers/net/wireless/rtl8xxxu_regs.h | 941 +++++++ 6 files changed, 5967 insertions(+) create mode 100644 drivers/net/wireless/rtl8xxxu.c create mode 100644 drivers/net/wireless/rtl8xxxu.h create mode 100644 drivers/net/wireless/rtl8xxxu_regs.h -- 2.1.0 ^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-03-23 20:24 [PATCH v3 0/1] " Jes.Sorensen @ 2015-03-23 20:25 ` Jes.Sorensen 2015-03-23 22:51 ` Joe Perches 2015-04-28 8:37 ` Kalle Valo 0 siblings, 2 replies; 35+ messages in thread From: Jes.Sorensen @ 2015-03-23 20:25 UTC (permalink / raw) To: linux-wireless; +Cc: Larry.Finger From: Jes Sorensen <Jes.Sorensen@redhat.com> This is an alternate driver for the Realtek 8723AU (rtl8723au) written from scratch utilizing the mac80211 stack. After spending months cleaning up the vendor provided rtl8723au driver, which comes with it's own 802.11 stack included, I decided to rewrite this driver from the bottom up. Many thanks to Johannes Berg for 802.11 insights and help and Larry Finger for help with the vendor driver. The full git log for the development of this driver can be found here: git git://git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git branch rtl8723au-mac80211 This driver is still experimental, but has proven to be rather stable for me. It lacks some features found in the staging driver, such as power management, AMPDU, and 40MHz channel support. In addition there is no AP and monitor support at this point. Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> --- MAINTAINERS | 8 + drivers/net/wireless/Kconfig | 19 + drivers/net/wireless/Makefile | 2 + drivers/net/wireless/rtl8xxxu.c | 4500 ++++++++++++++++++++++++++++++++++ drivers/net/wireless/rtl8xxxu.h | 497 ++++ drivers/net/wireless/rtl8xxxu_regs.h | 941 +++++++ 6 files changed, 5967 insertions(+) create mode 100644 drivers/net/wireless/rtl8xxxu.c create mode 100644 drivers/net/wireless/rtl8xxxu.h create mode 100644 drivers/net/wireless/rtl8xxxu_regs.h diff --git a/MAINTAINERS b/MAINTAINERS index 42f686f..1b7ff9d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8297,6 +8297,14 @@ S: Maintained F: drivers/net/wireless/rtlwifi/ F: drivers/net/wireless/rtlwifi/rtl8192ce/ +RTL8XXXU WIRELESS DRIVER (rtl8xxxu) +M: Jes Sorensen <Jes.Sorensen@redhat.com> +L: linux-wireless@vger.kernel.org +W: http://intellinuxwireless.org +T: git git://git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git rtl8723au-mac80211 +S: Maintained +F: drivers/net/wireless/rtl8xxxu*.[ch] + S3 SAVAGE FRAMEBUFFER DRIVER M: Antonino Daplas <adaplas@gmail.com> L: linux-fbdev@vger.kernel.org diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig index 16604bd..dda80d6 100644 --- a/drivers/net/wireless/Kconfig +++ b/drivers/net/wireless/Kconfig @@ -243,6 +243,25 @@ config ADM8211 Thanks to Infineon-ADMtek for their support of this driver. +config RTL8XXXU + tristate "RTL8723AU (mac80211) support (EXPERIMENTAL)" + depends on MAC80211 && USB + ---help--- + This is an alternative driver for the RTL8723AU, written to + utilize the Linux mac80211 stack. + + This driver is under development and has a limited feature + set. In particular it does not yet support 40MHz channels, + AMPDU, and power management. However it should have a + smaller memory footprint than the vendor driver and benetifs + from the in kernel mac80211 stack. + + It can coexist with the driver from drivers/staging/rtl8723au, + but you will need to control which module you wish to load. + + To compile this driver as a module, choose M here: the module will + be called r8xxxu. If unsure, say N. + config MAC80211_HWSIM tristate "Simulated radio testing tool for mac80211" depends on MAC80211 diff --git a/drivers/net/wireless/Makefile b/drivers/net/wireless/Makefile index 0c88916..e3911cc 100644 --- a/drivers/net/wireless/Makefile +++ b/drivers/net/wireless/Makefile @@ -39,6 +39,8 @@ obj-$(CONFIG_LIBERTAS_THINFIRM) += libertas_tf/ obj-$(CONFIG_ADM8211) += adm8211.o +obj-$(CONFIG_RTL8XXXU) += rtl8xxxu.o + obj-$(CONFIG_MWL8K) += mwl8k.o obj-$(CONFIG_IWLWIFI) += iwlwifi/ diff --git a/drivers/net/wireless/rtl8xxxu.c b/drivers/net/wireless/rtl8xxxu.c new file mode 100644 index 0000000..6dcf89c --- /dev/null +++ b/drivers/net/wireless/rtl8xxxu.c @@ -0,0 +1,4500 @@ +/* + * RTL8723au mac80211 USB driver + * + * Copyright (c) 2014 - 2015 Jes Sorensen <Jes.Sorensen@redhat.com> + * + * Portions, notably calibration code: + * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved. + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of version 2 of the GNU General Public License as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + */ + +#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/sched.h> +#include <linux/errno.h> +#include <linux/slab.h> +#include <linux/module.h> +#include <linux/spinlock.h> +#include <linux/list.h> +#include <linux/usb.h> +#include <linux/netdevice.h> +#include <linux/etherdevice.h> +#include <linux/ethtool.h> +#include <linux/wireless.h> +#include <linux/firmware.h> +#include <linux/moduleparam.h> +#include <net/mac80211.h> +#include "rtl8xxxu.h" +#include "rtl8xxxu_regs.h" + +#define DRIVER_NAME "rtl8xxxu" + +static int rtl8xxxu_debug = 0; + +MODULE_AUTHOR("Jes Sorensen <Jes.Sorensen@redhat.com>"); +MODULE_DESCRIPTION("RTL8723au USB mac80211 Wireless LAN Driver"); +MODULE_LICENSE("GPL"); +MODULE_FIRMWARE("rtlwifi/rtl8723aufw_A.bin"); +MODULE_FIRMWARE("rtlwifi/rtl8723aufw_B.bin"); +MODULE_FIRMWARE("rtlwifi/rtl8723aufw_B_NoBT.bin"); + +module_param_named(debug, rtl8xxxu_debug, int, 0600); +MODULE_PARM_DESC(debug, "Set debug mask"); + +#define USB_VENDER_ID_REALTEK 0x0BDA +/* Minimum IEEE80211_MAX_FRAME_LEN */ +#define RTL_RX_BUFFER_SIZE IEEE80211_MAX_FRAME_LEN + +static struct usb_device_id dev_table[] = { + {USB_DEVICE_AND_INTERFACE_INFO(USB_VENDER_ID_REALTEK, 0x8724, + 0xff, 0xff, 0xff)}, + {USB_DEVICE_AND_INTERFACE_INFO(USB_VENDER_ID_REALTEK, 0x1724, + 0xff, 0xff, 0xff)}, + {USB_DEVICE_AND_INTERFACE_INFO(USB_VENDER_ID_REALTEK, 0x0724, + 0xff, 0xff, 0xff)}, + { } +}; + +MODULE_DEVICE_TABLE(usb, dev_table); + +static int rtl8xxxu_submit_rx_urb(struct rtl8xxxu_priv *priv, + struct rtl8xxxu_rx_urb *rx_urb); + +static struct ieee80211_rate rtl8xxxu_rates[] = { + { .bitrate = 10, .hw_value = DESC_RATE_1M, .flags = 0 }, + { .bitrate = 20, .hw_value = DESC_RATE_2M, .flags = 0 }, + { .bitrate = 55, .hw_value = DESC_RATE_5_5M, .flags = 0 }, + { .bitrate = 110, .hw_value = DESC_RATE_11M, .flags = 0 }, + { .bitrate = 60, .hw_value = DESC_RATE_6M, .flags = 0 }, + { .bitrate = 90, .hw_value = DESC_RATE_9M, .flags = 0 }, + { .bitrate = 120, .hw_value = DESC_RATE_12M, .flags = 0 }, + { .bitrate = 180, .hw_value = DESC_RATE_18M, .flags = 0 }, + { .bitrate = 240, .hw_value = DESC_RATE_24M, .flags = 0 }, + { .bitrate = 360, .hw_value = DESC_RATE_36M, .flags = 0 }, + { .bitrate = 480, .hw_value = DESC_RATE_48M, .flags = 0 }, + { .bitrate = 540, .hw_value = DESC_RATE_54M, .flags = 0 }, +}; + +static struct ieee80211_channel rtl8xxxu_channels_2g[] = { + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2412, + .hw_value = 1, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2417, + .hw_value = 2, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2422, + .hw_value = 3, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2427, + .hw_value = 4, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2432, + .hw_value = 5, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2437, + .hw_value = 6, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2442, + .hw_value = 7, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2447, + .hw_value = 8, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2452, + .hw_value = 9, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2457, + .hw_value = 10, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2462, + .hw_value = 11, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2467, + .hw_value = 12, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2472, + .hw_value = 13, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2484, + .hw_value = 14, .max_power = 30 } +}; + +static struct ieee80211_supported_band rtl8xxxu_supported_band = { + .channels = rtl8xxxu_channels_2g, + .n_channels = ARRAY_SIZE(rtl8xxxu_channels_2g), + .bitrates = rtl8xxxu_rates, + .n_bitrates = ARRAY_SIZE(rtl8xxxu_rates), +}; + +static struct rtl8xxxu_reg8val rtl8723a_mac_init_table[] = { + {0x420, 0x80}, {0x423, 0x00}, {0x430, 0x00}, {0x431, 0x00}, + {0x432, 0x00}, {0x433, 0x01}, {0x434, 0x04}, {0x435, 0x05}, + {0x436, 0x06}, {0x437, 0x07}, {0x438, 0x00}, {0x439, 0x00}, + {0x43a, 0x00}, {0x43b, 0x01}, {0x43c, 0x04}, {0x43d, 0x05}, + {0x43e, 0x06}, {0x43f, 0x07}, {0x440, 0x5d}, {0x441, 0x01}, + {0x442, 0x00}, {0x444, 0x15}, {0x445, 0xf0}, {0x446, 0x0f}, + {0x447, 0x00}, {0x458, 0x41}, {0x459, 0xa8}, {0x45a, 0x72}, + {0x45b, 0xb9}, {0x460, 0x66}, {0x461, 0x66}, {0x462, 0x08}, + {0x463, 0x03}, {0x4c8, 0xff}, {0x4c9, 0x08}, {0x4cc, 0xff}, + {0x4cd, 0xff}, {0x4ce, 0x01}, {0x500, 0x26}, {0x501, 0xa2}, + {0x502, 0x2f}, {0x503, 0x00}, {0x504, 0x28}, {0x505, 0xa3}, + {0x506, 0x5e}, {0x507, 0x00}, {0x508, 0x2b}, {0x509, 0xa4}, + {0x50a, 0x5e}, {0x50b, 0x00}, {0x50c, 0x4f}, {0x50d, 0xa4}, + {0x50e, 0x00}, {0x50f, 0x00}, {0x512, 0x1c}, {0x514, 0x0a}, + {0x515, 0x10}, {0x516, 0x0a}, {0x517, 0x10}, {0x51a, 0x16}, + {0x524, 0x0f}, {0x525, 0x4f}, {0x546, 0x40}, {0x547, 0x00}, + {0x550, 0x10}, {0x551, 0x10}, {0x559, 0x02}, {0x55a, 0x02}, + {0x55d, 0xff}, {0x605, 0x30}, {0x608, 0x0e}, {0x609, 0x2a}, + {0x652, 0x20}, {0x63c, 0x0a}, {0x63d, 0x0a}, {0x63e, 0x0e}, + {0x63f, 0x0e}, {0x66e, 0x05}, {0x700, 0x21}, {0x701, 0x43}, + {0x702, 0x65}, {0x703, 0x87}, {0x708, 0x21}, {0x709, 0x43}, + {0x70a, 0x65}, {0x70b, 0x87}, {0xffff, 0xff}, +}; + +static struct rtl8xxxu_reg32val rtl8723a_phy_1t_init_table[] = { + {0x800, 0x80040000}, {0x804, 0x00000003}, + {0x808, 0x0000fc00}, {0x80c, 0x0000000a}, + {0x810, 0x10001331}, {0x814, 0x020c3d10}, + {0x818, 0x02200385}, {0x81c, 0x00000000}, + {0x820, 0x01000100}, {0x824, 0x00390004}, + {0x828, 0x00000000}, {0x82c, 0x00000000}, + {0x830, 0x00000000}, {0x834, 0x00000000}, + {0x838, 0x00000000}, {0x83c, 0x00000000}, + {0x840, 0x00010000}, {0x844, 0x00000000}, + {0x848, 0x00000000}, {0x84c, 0x00000000}, + {0x850, 0x00000000}, {0x854, 0x00000000}, + {0x858, 0x569a569a}, {0x85c, 0x001b25a4}, + {0x860, 0x66f60110}, {0x864, 0x061f0130}, + {0x868, 0x00000000}, {0x86c, 0x32323200}, + {0x870, 0x07000760}, {0x874, 0x22004000}, + {0x878, 0x00000808}, {0x87c, 0x00000000}, + {0x880, 0xc0083070}, {0x884, 0x000004d5}, + {0x888, 0x00000000}, {0x88c, 0xccc000c0}, + {0x890, 0x00000800}, {0x894, 0xfffffffe}, + {0x898, 0x40302010}, {0x89c, 0x00706050}, + {0x900, 0x00000000}, {0x904, 0x00000023}, + {0x908, 0x00000000}, {0x90c, 0x81121111}, + {0xa00, 0x00d047c8}, {0xa04, 0x80ff000c}, + {0xa08, 0x8c838300}, {0xa0c, 0x2e68120f}, + {0xa10, 0x9500bb78}, {0xa14, 0x11144028}, + {0xa18, 0x00881117}, {0xa1c, 0x89140f00}, + {0xa20, 0x1a1b0000}, {0xa24, 0x090e1317}, + {0xa28, 0x00000204}, {0xa2c, 0x00d30000}, + {0xa70, 0x101fbf00}, {0xa74, 0x00000007}, + {0xa78, 0x00000900}, {0xc00, 0x48071d40}, + {0xc04, 0x03a05611}, {0xc08, 0x000000e4}, + {0xc0c, 0x6c6c6c6c}, {0xc10, 0x08800000}, + {0xc14, 0x40000100}, {0xc18, 0x08800000}, + {0xc1c, 0x40000100}, {0xc20, 0x00000000}, + {0xc24, 0x00000000}, {0xc28, 0x00000000}, + {0xc2c, 0x00000000}, {0xc30, 0x69e9ac44}, +#if 0 /* Not for USB */ + {0xff0f011f, 0xabcd}, + {0xc34, 0x469652cf}, + {0xcdcdcdcd, 0xcdcd}, +#endif + {0xc34, 0x469652af}, +#if 0 + {0xff0f011f, 0xdead}, +#endif + {0xc38, 0x49795994}, + {0xc3c, 0x0a97971c}, {0xc40, 0x1f7c403f}, + {0xc44, 0x000100b7}, {0xc48, 0xec020107}, + {0xc4c, 0x007f037f}, {0xc50, 0x69543420}, + {0xc54, 0x43bc0094}, {0xc58, 0x69543420}, + {0xc5c, 0x433c0094}, {0xc60, 0x00000000}, +#if 0 /* Not for USB */ + {0xff0f011f, 0xabcd}, + {0xc64, 0x7116848b}, + {0xcdcdcdcd, 0xcdcd}, +#endif + {0xc64, 0x7112848b}, +#if 0 + {0xff0f011f, 0xdead}, +#endif + {0xc68, 0x47c00bff}, + {0xc6c, 0x00000036}, {0xc70, 0x2c7f000d}, + {0xc74, 0x018610db}, {0xc78, 0x0000001f}, + {0xc7c, 0x00b91612}, {0xc80, 0x40000100}, + {0xc84, 0x20f60000}, {0xc88, 0x40000100}, + {0xc8c, 0x20200000}, {0xc90, 0x00121820}, + {0xc94, 0x00000000}, {0xc98, 0x00121820}, + {0xc9c, 0x00007f7f}, {0xca0, 0x00000000}, + {0xca4, 0x00000080}, {0xca8, 0x00000000}, + {0xcac, 0x00000000}, {0xcb0, 0x00000000}, + {0xcb4, 0x00000000}, {0xcb8, 0x00000000}, + {0xcbc, 0x28000000}, {0xcc0, 0x00000000}, + {0xcc4, 0x00000000}, {0xcc8, 0x00000000}, + {0xccc, 0x00000000}, {0xcd0, 0x00000000}, + {0xcd4, 0x00000000}, {0xcd8, 0x64b22427}, + {0xcdc, 0x00766932}, {0xce0, 0x00222222}, + {0xce4, 0x00000000}, {0xce8, 0x37644302}, + {0xcec, 0x2f97d40c}, {0xd00, 0x00080740}, + {0xd04, 0x00020401}, {0xd08, 0x0000907f}, + {0xd0c, 0x20010201}, {0xd10, 0xa0633333}, + {0xd14, 0x3333bc43}, {0xd18, 0x7a8f5b6b}, + {0xd2c, 0xcc979975}, {0xd30, 0x00000000}, + {0xd34, 0x80608000}, {0xd38, 0x00000000}, + {0xd3c, 0x00027293}, {0xd40, 0x00000000}, + {0xd44, 0x00000000}, {0xd48, 0x00000000}, + {0xd4c, 0x00000000}, {0xd50, 0x6437140a}, + {0xd54, 0x00000000}, {0xd58, 0x00000000}, + {0xd5c, 0x30032064}, {0xd60, 0x4653de68}, + {0xd64, 0x04518a3c}, {0xd68, 0x00002101}, + {0xd6c, 0x2a201c16}, {0xd70, 0x1812362e}, + {0xd74, 0x322c2220}, {0xd78, 0x000e3c24}, + {0xe00, 0x2a2a2a2a}, {0xe04, 0x2a2a2a2a}, + {0xe08, 0x03902a2a}, {0xe10, 0x2a2a2a2a}, + {0xe14, 0x2a2a2a2a}, {0xe18, 0x2a2a2a2a}, + {0xe1c, 0x2a2a2a2a}, {0xe28, 0x00000000}, + {0xe30, 0x1000dc1f}, {0xe34, 0x10008c1f}, + {0xe38, 0x02140102}, {0xe3c, 0x681604c2}, + {0xe40, 0x01007c00}, {0xe44, 0x01004800}, + {0xe48, 0xfb000000}, {0xe4c, 0x000028d1}, + {0xe50, 0x1000dc1f}, {0xe54, 0x10008c1f}, + {0xe58, 0x02140102}, {0xe5c, 0x28160d05}, + {0xe60, 0x00000008}, {0xe68, 0x001b25a4}, + {0xe6c, 0x631b25a0}, {0xe70, 0x631b25a0}, + {0xe74, 0x081b25a0}, {0xe78, 0x081b25a0}, + {0xe7c, 0x081b25a0}, {0xe80, 0x081b25a0}, + {0xe84, 0x631b25a0}, {0xe88, 0x081b25a0}, + {0xe8c, 0x631b25a0}, {0xed0, 0x631b25a0}, + {0xed4, 0x631b25a0}, {0xed8, 0x631b25a0}, + {0xedc, 0x001b25a0}, {0xee0, 0x001b25a0}, + {0xeec, 0x6b1b25a0}, {0xf14, 0x00000003}, + {0xf4c, 0x00000000}, {0xf00, 0x00000300}, + {0xffff, 0xffffffff}, +}; + +static struct rtl8xxxu_reg32val rtl8723a_agc_1t_init_table[] = { + {0xc78, 0x7b000001}, {0xc78, 0x7b010001}, + {0xc78, 0x7b020001}, {0xc78, 0x7b030001}, + {0xc78, 0x7b040001}, {0xc78, 0x7b050001}, + {0xc78, 0x7a060001}, {0xc78, 0x79070001}, + {0xc78, 0x78080001}, {0xc78, 0x77090001}, + {0xc78, 0x760a0001}, {0xc78, 0x750b0001}, + {0xc78, 0x740c0001}, {0xc78, 0x730d0001}, + {0xc78, 0x720e0001}, {0xc78, 0x710f0001}, + {0xc78, 0x70100001}, {0xc78, 0x6f110001}, + {0xc78, 0x6e120001}, {0xc78, 0x6d130001}, + {0xc78, 0x6c140001}, {0xc78, 0x6b150001}, + {0xc78, 0x6a160001}, {0xc78, 0x69170001}, + {0xc78, 0x68180001}, {0xc78, 0x67190001}, + {0xc78, 0x661a0001}, {0xc78, 0x651b0001}, + {0xc78, 0x641c0001}, {0xc78, 0x631d0001}, + {0xc78, 0x621e0001}, {0xc78, 0x611f0001}, + {0xc78, 0x60200001}, {0xc78, 0x49210001}, + {0xc78, 0x48220001}, {0xc78, 0x47230001}, + {0xc78, 0x46240001}, {0xc78, 0x45250001}, + {0xc78, 0x44260001}, {0xc78, 0x43270001}, + {0xc78, 0x42280001}, {0xc78, 0x41290001}, + {0xc78, 0x402a0001}, {0xc78, 0x262b0001}, + {0xc78, 0x252c0001}, {0xc78, 0x242d0001}, + {0xc78, 0x232e0001}, {0xc78, 0x222f0001}, + {0xc78, 0x21300001}, {0xc78, 0x20310001}, + {0xc78, 0x06320001}, {0xc78, 0x05330001}, + {0xc78, 0x04340001}, {0xc78, 0x03350001}, + {0xc78, 0x02360001}, {0xc78, 0x01370001}, + {0xc78, 0x00380001}, {0xc78, 0x00390001}, + {0xc78, 0x003a0001}, {0xc78, 0x003b0001}, + {0xc78, 0x003c0001}, {0xc78, 0x003d0001}, + {0xc78, 0x003e0001}, {0xc78, 0x003f0001}, + {0xc78, 0x7b400001}, {0xc78, 0x7b410001}, + {0xc78, 0x7b420001}, {0xc78, 0x7b430001}, + {0xc78, 0x7b440001}, {0xc78, 0x7b450001}, + {0xc78, 0x7a460001}, {0xc78, 0x79470001}, + {0xc78, 0x78480001}, {0xc78, 0x77490001}, + {0xc78, 0x764a0001}, {0xc78, 0x754b0001}, + {0xc78, 0x744c0001}, {0xc78, 0x734d0001}, + {0xc78, 0x724e0001}, {0xc78, 0x714f0001}, + {0xc78, 0x70500001}, {0xc78, 0x6f510001}, + {0xc78, 0x6e520001}, {0xc78, 0x6d530001}, + {0xc78, 0x6c540001}, {0xc78, 0x6b550001}, + {0xc78, 0x6a560001}, {0xc78, 0x69570001}, + {0xc78, 0x68580001}, {0xc78, 0x67590001}, + {0xc78, 0x665a0001}, {0xc78, 0x655b0001}, + {0xc78, 0x645c0001}, {0xc78, 0x635d0001}, + {0xc78, 0x625e0001}, {0xc78, 0x615f0001}, + {0xc78, 0x60600001}, {0xc78, 0x49610001}, + {0xc78, 0x48620001}, {0xc78, 0x47630001}, + {0xc78, 0x46640001}, {0xc78, 0x45650001}, + {0xc78, 0x44660001}, {0xc78, 0x43670001}, + {0xc78, 0x42680001}, {0xc78, 0x41690001}, + {0xc78, 0x406a0001}, {0xc78, 0x266b0001}, + {0xc78, 0x256c0001}, {0xc78, 0x246d0001}, + {0xc78, 0x236e0001}, {0xc78, 0x226f0001}, + {0xc78, 0x21700001}, {0xc78, 0x20710001}, + {0xc78, 0x06720001}, {0xc78, 0x05730001}, + {0xc78, 0x04740001}, {0xc78, 0x03750001}, + {0xc78, 0x02760001}, {0xc78, 0x01770001}, + {0xc78, 0x00780001}, {0xc78, 0x00790001}, + {0xc78, 0x007a0001}, {0xc78, 0x007b0001}, + {0xc78, 0x007c0001}, {0xc78, 0x007d0001}, + {0xc78, 0x007e0001}, {0xc78, 0x007f0001}, + {0xc78, 0x3800001e}, {0xc78, 0x3801001e}, + {0xc78, 0x3802001e}, {0xc78, 0x3803001e}, + {0xc78, 0x3804001e}, {0xc78, 0x3805001e}, + {0xc78, 0x3806001e}, {0xc78, 0x3807001e}, + {0xc78, 0x3808001e}, {0xc78, 0x3c09001e}, + {0xc78, 0x3e0a001e}, {0xc78, 0x400b001e}, + {0xc78, 0x440c001e}, {0xc78, 0x480d001e}, + {0xc78, 0x4c0e001e}, {0xc78, 0x500f001e}, + {0xc78, 0x5210001e}, {0xc78, 0x5611001e}, + {0xc78, 0x5a12001e}, {0xc78, 0x5e13001e}, + {0xc78, 0x6014001e}, {0xc78, 0x6015001e}, + {0xc78, 0x6016001e}, {0xc78, 0x6217001e}, + {0xc78, 0x6218001e}, {0xc78, 0x6219001e}, + {0xc78, 0x621a001e}, {0xc78, 0x621b001e}, + {0xc78, 0x621c001e}, {0xc78, 0x621d001e}, + {0xc78, 0x621e001e}, {0xc78, 0x621f001e}, + {0xffff, 0xffffffff} +}; + +static struct rtl8xxxu_rfregval rtl8723au_radioa_rf6052_1t_init_table[] = { + {0x00, 0x00030159}, {0x01, 0x00031284}, + {0x02, 0x00098000}, +#if 0 /* Only for PCIE */ + {0xff0f011f, 0xabcd}, + {0x03, 0x00018c63}, + {0xcdcdcdcd, 0xcdcd}, +#endif + {0x03, 0x00039c63}, +#if 0 + {0xff0f011f, 0xdead}, +#endif + {0x04, 0x000210e7}, {0x09, 0x0002044f}, + {0x0a, 0x0001a3f1}, {0x0b, 0x00014787}, + {0x0c, 0x000896fe}, {0x0d, 0x0000e02c}, + {0x0e, 0x00039ce7}, {0x0f, 0x00000451}, + {0x19, 0x00000000}, {0x1a, 0x00030355}, + {0x1b, 0x00060a00}, {0x1c, 0x000fc378}, + {0x1d, 0x000a1250}, {0x1e, 0x0000024f}, + {0x1f, 0x00000000}, {0x20, 0x0000b614}, + {0x21, 0x0006c000}, {0x22, 0x00000000}, + {0x23, 0x00001558}, {0x24, 0x00000060}, + {0x25, 0x00000483}, {0x26, 0x0004f000}, + {0x27, 0x000ec7d9}, {0x28, 0x00057730}, + {0x29, 0x00004783}, {0x2a, 0x00000001}, + {0x2b, 0x00021334}, {0x2a, 0x00000000}, + {0x2b, 0x00000054}, {0x2a, 0x00000001}, + {0x2b, 0x00000808}, {0x2b, 0x00053333}, + {0x2c, 0x0000000c}, {0x2a, 0x00000002}, + {0x2b, 0x00000808}, {0x2b, 0x0005b333}, + {0x2c, 0x0000000d}, {0x2a, 0x00000003}, + {0x2b, 0x00000808}, {0x2b, 0x00063333}, + {0x2c, 0x0000000d}, {0x2a, 0x00000004}, + {0x2b, 0x00000808}, {0x2b, 0x0006b333}, + {0x2c, 0x0000000d}, {0x2a, 0x00000005}, + {0x2b, 0x00000808}, {0x2b, 0x00073333}, + {0x2c, 0x0000000d}, {0x2a, 0x00000006}, + {0x2b, 0x00000709}, {0x2b, 0x0005b333}, + {0x2c, 0x0000000d}, {0x2a, 0x00000007}, + {0x2b, 0x00000709}, {0x2b, 0x00063333}, + {0x2c, 0x0000000d}, {0x2a, 0x00000008}, + {0x2b, 0x0000060a}, {0x2b, 0x0004b333}, + {0x2c, 0x0000000d}, {0x2a, 0x00000009}, + {0x2b, 0x0000060a}, {0x2b, 0x00053333}, + {0x2c, 0x0000000d}, {0x2a, 0x0000000a}, + {0x2b, 0x0000060a}, {0x2b, 0x0005b333}, + {0x2c, 0x0000000d}, {0x2a, 0x0000000b}, + {0x2b, 0x0000060a}, {0x2b, 0x00063333}, + {0x2c, 0x0000000d}, {0x2a, 0x0000000c}, + {0x2b, 0x0000060a}, {0x2b, 0x0006b333}, + {0x2c, 0x0000000d}, {0x2a, 0x0000000d}, + {0x2b, 0x0000060a}, {0x2b, 0x00073333}, + {0x2c, 0x0000000d}, {0x2a, 0x0000000e}, + {0x2b, 0x0000050b}, {0x2b, 0x00066666}, + {0x2c, 0x0000001a}, {0x2a, 0x000e0000}, + {0x10, 0x0004000f}, {0x11, 0x000e31fc}, + {0x10, 0x0006000f}, {0x11, 0x000ff9f8}, + {0x10, 0x0002000f}, {0x11, 0x000203f9}, + {0x10, 0x0003000f}, {0x11, 0x000ff500}, + {0x10, 0x00000000}, {0x11, 0x00000000}, + {0x10, 0x0008000f}, {0x11, 0x0003f100}, + {0x10, 0x0009000f}, {0x11, 0x00023100}, + {0x12, 0x00032000}, {0x12, 0x00071000}, + {0x12, 0x000b0000}, {0x12, 0x000fc000}, + {0x13, 0x000287b3}, {0x13, 0x000244b7}, + {0x13, 0x000204ab}, {0x13, 0x0001c49f}, + {0x13, 0x00018493}, {0x13, 0x0001429b}, + {0x13, 0x00010299}, {0x13, 0x0000c29c}, + {0x13, 0x000081a0}, {0x13, 0x000040ac}, + {0x13, 0x00000020}, {0x14, 0x0001944c}, + {0x14, 0x00059444}, {0x14, 0x0009944c}, + {0x14, 0x000d9444}, +#if 0 /* Only for PCIE */ + {0xff0f011f, 0xabcd}, + {0x15, 0x0000f424}, + {0x15, 0x0004f424}, + {0x15, 0x0008f424}, + {0x15, 0x000cf424}, + {0xcdcdcdcd, 0xcdcd}, +#endif + {0x15, 0x0000f474}, {0x15, 0x0004f477}, + {0x15, 0x0008f455}, {0x15, 0x000cf455}, +#if 0 + {0xff0f011f, 0xdead}, +#endif + {0x16, 0x00000339}, {0x16, 0x00040339}, + {0x16, 0x00080339}, +#if 0 /* Only for PCIE */ + {0xff0f011f, 0xabcd}, + {0x16, 0x000c0356}, + {0xcdcdcdcd, 0xcdcd}, +#endif + {0x16, 0x000c0366}, +#if 0 + {0xff0f011f, 0xdead}, +#endif + {0x00, 0x00010159}, {0x18, 0x0000f401}, + {0xfe, 0x00000000}, {0xfe, 0x00000000}, + {0x1f, 0x00000003}, {0xfe, 0x00000000}, + {0xfe, 0x00000000}, {0x1e, 0x00000247}, + {0x1f, 0x00000000}, {0x00, 0x00030159}, + {0xff, 0xffffffff} +}; + +static const u32 rtl8723au_iqk_phy_iq_bb_reg[RTL8XXXU_BB_REGS] = { + REG_OFDM0_XA_RX_IQ_IMBALANCE, + REG_OFDM0_XB_RX_IQ_IMBALANCE, + REG_OFDM0_ENERGY_CCA_THRES, + REG_OFDM0_AGCR_SSI_TABLE, + REG_OFDM0_XA_TX_IQ_IMBALANCE, + REG_OFDM0_XB_TX_IQ_IMBALANCE, + REG_OFDM0_XC_TX_AFE, + REG_OFDM0_XD_TX_AFE, + REG_OFDM0_RX_IQ_EXT_ANTA +}; + +static u8 rtl8723au_read8(struct rtl8xxxu_priv *priv, u16 addr) +{ + struct usb_device *udev = priv->udev; + int len; + u8 data; + + mutex_lock(&priv->usb_buf_mutex); + len = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), + REALTEK_USB_CMD_REQ, REALTEK_USB_READ, + addr, 0, &priv->usb_buf.val8, sizeof(u8), + RTW_USB_CONTROL_MSG_TIMEOUT); + data = priv->usb_buf.val8; + mutex_unlock(&priv->usb_buf_mutex); + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_REG_READ) + dev_info(&udev->dev, "%s(%04x) = 0x%02x, len %i\n", + __func__, addr, data, len); + return data; +} + +static u16 rtl8723au_read16(struct rtl8xxxu_priv *priv, u16 addr) +{ + struct usb_device *udev = priv->udev; + int len; + u16 data; + + mutex_lock(&priv->usb_buf_mutex); + len = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), + REALTEK_USB_CMD_REQ, REALTEK_USB_READ, + addr, 0, &priv->usb_buf.val16, sizeof(u16), + RTW_USB_CONTROL_MSG_TIMEOUT); + data = le16_to_cpu(priv->usb_buf.val16); + mutex_unlock(&priv->usb_buf_mutex); + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_REG_READ) + dev_info(&udev->dev, "%s(%04x) = 0x%04x, len %i\n", + __func__, addr, data, len); + return data; +} + +static u32 rtl8723au_read32(struct rtl8xxxu_priv *priv, u16 addr) +{ + struct usb_device *udev = priv->udev; + int len; + u32 data; + + mutex_lock(&priv->usb_buf_mutex); + len = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), + REALTEK_USB_CMD_REQ, REALTEK_USB_READ, + addr, 0, &priv->usb_buf.val32, sizeof(u32), + RTW_USB_CONTROL_MSG_TIMEOUT); + data = le32_to_cpu(priv->usb_buf.val32); + mutex_unlock(&priv->usb_buf_mutex); + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_REG_READ) + dev_info(&udev->dev, "%s(%04x) = 0x%08x, len %i\n", + __func__, addr, data, len); + return data; +} + +static int rtl8723au_write8(struct rtl8xxxu_priv *priv, u16 addr, u8 val) +{ + struct usb_device *udev = priv->udev; + int ret; + + mutex_lock(&priv->usb_buf_mutex); + priv->usb_buf.val8 = val; + ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), + REALTEK_USB_CMD_REQ, REALTEK_USB_WRITE, + addr, 0, &priv->usb_buf.val8, sizeof(u8), + RTW_USB_CONTROL_MSG_TIMEOUT); + + mutex_unlock(&priv->usb_buf_mutex); + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_REG_WRITE) + dev_info(&udev->dev, "%s(%04x) = 0x%02x\n", + __func__, addr, val); + return ret; +} + +static int rtl8723au_write16(struct rtl8xxxu_priv *priv, u16 addr, u16 val) +{ + struct usb_device *udev = priv->udev; + int ret; + + mutex_lock(&priv->usb_buf_mutex); + priv->usb_buf.val16 = cpu_to_le16(val); + ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), + REALTEK_USB_CMD_REQ, REALTEK_USB_WRITE, + addr, 0, &priv->usb_buf.val16, sizeof(u16), + RTW_USB_CONTROL_MSG_TIMEOUT); + mutex_unlock(&priv->usb_buf_mutex); + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_REG_WRITE) + dev_info(&udev->dev, "%s(%04x) = 0x%04x\n", + __func__, addr, val); + return ret; +} + +static int rtl8723au_write32(struct rtl8xxxu_priv *priv, u16 addr, u32 val) +{ + struct usb_device *udev = priv->udev; + int ret; + + mutex_lock(&priv->usb_buf_mutex); + priv->usb_buf.val32 = cpu_to_le32(val); + ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), + REALTEK_USB_CMD_REQ, REALTEK_USB_WRITE, + addr, 0, &priv->usb_buf.val32, sizeof(u32), + RTW_USB_CONTROL_MSG_TIMEOUT); + mutex_unlock(&priv->usb_buf_mutex); + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_REG_WRITE) + dev_info(&udev->dev, "%s(%04x) = 0x%08x\n", + __func__, addr, val); + return ret; +} + +static int +rtl8723au_writeN(struct rtl8xxxu_priv *priv, u16 addr, u8 *buf, u16 len) +{ + struct usb_device *udev = priv->udev; + int ret; + + ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), + REALTEK_USB_CMD_REQ, REALTEK_USB_WRITE, + addr, 0, buf, len, RTW_USB_CONTROL_MSG_TIMEOUT); + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_REG_WRITE) + dev_info(&udev->dev, "%s(%04x) = %p, len 0x%02x\n", + __func__, addr, buf, len); + return ret; +} + +static u32 rtl8723au_read_rfreg(struct rtl8xxxu_priv *priv, u8 reg) +{ + u32 hssia, val32, retval; + + hssia = rtl8723au_read32(priv, REG_FPGA0_XA_HSSI_PARM2); + /* + * For path B it seems we should be reading REG_FPGA0_XB_HSSI_PARM1 + * into val32 + */ + val32 = hssia; + val32 &= ~FPGA0_HSSI_PARM2_ADDR_MASK; + val32 |= (reg << FPGA0_HSSI_PARM2_ADDR_SHIFT) | + FPGA0_HSSI_PARM2_EDGE_READ; + hssia &= ~FPGA0_HSSI_PARM2_EDGE_READ; + rtl8723au_write32(priv, REG_FPGA0_XA_HSSI_PARM2, hssia); + + udelay(10); + /* Here use XB for path B */ + rtl8723au_write32(priv, REG_FPGA0_XA_HSSI_PARM2, val32); + udelay(100); + + hssia |= FPGA0_HSSI_PARM2_EDGE_READ; + rtl8723au_write32(priv, REG_FPGA0_XA_HSSI_PARM2, hssia); + udelay(10); + + /* Use XB for path B */ + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_HSSI_PARM1); + if (val32 & FPGA0_HSSI_PARM1_PI) + retval = rtl8723au_read32(priv, REG_HSPI_XA_READBACK); + else + retval = rtl8723au_read32(priv, REG_FPGA0_XA_LSSI_READBACK); + + retval &= 0xfffff; + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_RFREG_READ) + dev_info(&priv->udev->dev, "%s(%02x) = 0x%06x\n", + __func__, reg, retval); + return retval; +} + +static int rtl8723au_write_rfreg(struct rtl8xxxu_priv *priv, u8 reg, u32 data) +{ + int ret, retval; + u32 dataaddr; + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_RFREG_WRITE) + dev_info(&priv->udev->dev, "%s(%02x) = 0x%06x\n", + __func__, reg, data); + + data &= FPGA0_LSSI_PARM_DATA_MASK; + dataaddr = (reg << FPGA0_LSSI_PARM_ADDR_SHIFT) | data; + + /* Use XB for path B */ + ret = rtl8723au_write32(priv, REG_FPGA0_XA_LSSI_PARM, dataaddr); + if (ret != sizeof(dataaddr)) + retval = -EIO; + else + retval = 0; + + udelay(1); + + return retval; +} + +static int rtl8723a_h2c_cmd(struct rtl8xxxu_priv *priv, struct h2c_cmd *h2c) +{ + struct device *dev = &priv->udev->dev; + int mbox_nr, retry, retval = 0; + int mbox_reg, mbox_ext_reg; + u8 val8; + + mbox_nr = priv->next_mbox; + + mbox_reg = REG_HMBOX_0 + (mbox_nr * 4); + mbox_ext_reg = REG_HMBOX_EXT_0 + (mbox_nr * 2); + + mutex_lock(&priv->h2c_mutex); + /* + * MBOX ready? + */ + retry = 100; + do { + val8 = rtl8723au_read8(priv, REG_HMTFR); + if (!(val8 & BIT(mbox_nr))) + break; + } while (retry--); + + if (!retry) { + dev_dbg(dev, "%s: Mailbox busy\n", __func__); + retval = -EBUSY; + goto error; + } + + /* + * Need to swap as it's being swapped again by rtl8723au_write16/32() + */ + if (h2c->cmd.cmd & H2C_EXT) { + rtl8723au_write16(priv, mbox_ext_reg, + le16_to_cpu(h2c->raw.ext)); + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_H2C) + dev_info(dev, "H2C_EXT %04x\n", + le16_to_cpu(h2c->raw.ext)); + } + rtl8723au_write32(priv, mbox_reg, le32_to_cpu(h2c->raw.data)); + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_H2C) + dev_info(dev, "H2C %08x\n", le16_to_cpu(h2c->raw.data)); + + priv->next_mbox = (mbox_nr + 1) % H2C_MAX_MBOX; + +error: + mutex_unlock(&priv->h2c_mutex); + return retval; +} + +static void rtl8723a_enable_rf(struct rtl8xxxu_priv *priv) +{ + u8 val8; + u32 val32; + + val8 = rtl8723au_read8(priv, REG_SPS0_CTRL); + val8 |= BIT(0) | BIT(3); + rtl8723au_write8(priv, REG_SPS0_CTRL, val8); + + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_RF_PARM); + val32 &= ~(BIT(4) | BIT(5)); + val32 |= BIT(3); + rtl8723au_write32(priv, REG_FPGA0_XA_RF_PARM, val32); + + val32 = rtl8723au_read32(priv, REG_OFDM0_TRX_PATH_ENABLE); + val32 &= ~(BIT(4) | BIT(5) | BIT(6) | BIT(7)); + val32 |= BIT(4); + rtl8723au_write32(priv, REG_OFDM0_TRX_PATH_ENABLE, val32); + + val32 = rtl8723au_read32(priv, REG_FPGA0_RF_MODE); + val32 &= ~FPGA_RF_MODE_JAPAN; + rtl8723au_write32(priv, REG_FPGA0_RF_MODE, val32); + + rtl8723au_write32(priv, REG_RX_WAIT_CCA, 0x631B25A0); + + rtl8723au_write_rfreg(priv, RF6052_REG_AC, 0x32d95); + +#if 0 + rtl8723au_write8(priv, REG_SYS_FUNC, 0xE3); + rtl8723au_write8(priv, REG_APSD_CTRL, 0x00); + rtl8723au_write8(priv, REG_SYS_FUNC, 0xE2); + rtl8723au_write8(priv, REG_SYS_FUNC, 0xE3); +#endif + rtl8723au_write8(priv, REG_TXPAUSE, 0x00); +} + +static void rtl8723a_disable_rf(struct rtl8xxxu_priv *priv) +{ + u8 sps0; + u32 val32; + + rtl8723au_write8(priv, REG_TXPAUSE, 0xff); + + sps0 = rtl8723au_read8(priv, REG_SPS0_CTRL); + + /* RF RX code for preamble power saving */ + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_RF_PARM); + val32 &= ~(BIT(3) | BIT(4) | BIT(5)); + rtl8723au_write32(priv, REG_FPGA0_XA_RF_PARM, val32); + + /* Disable all packet detection for all four paths */ + val32 = rtl8723au_read32(priv, REG_OFDM0_TRX_PATH_ENABLE); + val32 &= ~(BIT(4) | BIT(5) | BIT(6) | BIT(7)); + rtl8723au_write32(priv, REG_OFDM0_TRX_PATH_ENABLE, val32); + + /* Enable power saving */ + val32 = rtl8723au_read32(priv, REG_FPGA0_RF_MODE); + val32 |= FPGA_RF_MODE_JAPAN; + rtl8723au_write32(priv, REG_FPGA0_RF_MODE, val32); + + /* AFE control register to power down bits [30:22] */ + rtl8723au_write32(priv, REG_RX_WAIT_CCA, 0x001b25a0); + + /* Power down RF module */ + rtl8723au_write_rfreg(priv, RF6052_REG_AC, 0); + + sps0 &= ~(BIT(0) | BIT(3)); + rtl8723au_write8(priv, REG_SPS0_CTRL, sps0); +} + + +static void rtl8723a_stop_tx_beacon(struct rtl8xxxu_priv *priv) +{ + u8 val8; + + val8 = rtl8723au_read8(priv, REG_FWHW_TXQ_CTRL + 2); + val8 &= ~BIT(6); + rtl8723au_write8(priv, REG_FWHW_TXQ_CTRL + 2, val8); + + rtl8723au_write8(priv, REG_TBTT_PROHIBIT + 1, 0x64); + val8 = rtl8723au_read8(priv, REG_TBTT_PROHIBIT + 2); + val8 &= ~BIT(0); + rtl8723au_write8(priv, REG_TBTT_PROHIBIT + 2, val8); +} + + +/* + * The rtl8723a has 3 channel groups for it's efuse settings. It only + * supports the 2.4GHz band, so channels 1 - 14: + * group 0: channels 1 - 3 + * group 1: channels 4 - 9 + * group 2: channels 10 - 14 + * + * Note: We index from 0 in the code + */ +static int rtl8723a_channel_to_group(int channel) +{ + int group; + + if (channel < 4) + group = 0; + else if (channel < 10) + group = 1; + else + group = 2; + + return group; +} + +static void rtl8723au_config_channel(struct ieee80211_hw *hw) +{ + struct rtl8xxxu_priv *priv = hw->priv; + u32 val32, rsr; + u8 val8, opmode; + bool ht = true; + int sec_ch_above; + + val32 = rtl8723au_read_rfreg(priv, RF6052_REG_MODE_AG); + val32 &= ~MODE_AG_CHANNEL_MASK; + val32 |= hw->conf.chandef.chan->hw_value; + rtl8723au_write_rfreg(priv, RF6052_REG_MODE_AG, val32); + + opmode = rtl8723au_read8(priv, REG_BW_OPMODE); + rsr = rtl8723au_read32(priv, REG_RESPONSE_RATE_SET); + + switch (hw->conf.chandef.width) { + case NL80211_CHAN_WIDTH_20_NOHT: + ht = false; + case NL80211_CHAN_WIDTH_20: + opmode |= BW_OPMODE_20MHZ; + rtl8723au_write8(priv, REG_BW_OPMODE, opmode); + + val32 = rtl8723au_read32(priv, REG_FPGA0_RF_MODE); + val32 &= ~FPGA_RF_MODE; + rtl8723au_write32(priv, REG_FPGA0_RF_MODE, val32); + + val32 = rtl8723au_read32(priv, REG_FPGA1_RF_MODE); + val32 &= ~FPGA_RF_MODE; + rtl8723au_write32(priv, REG_FPGA1_RF_MODE, val32); + + val32 = rtl8723au_read32(priv, REG_FPGA0_ANALOG2); + val32 |= BIT(10); + rtl8723au_write32(priv, REG_FPGA0_ANALOG2, val32); + break; + case NL80211_CHAN_WIDTH_40: + if (hw->conf.chandef.center_freq1 > + hw->conf.chandef.chan->center_freq) + sec_ch_above = 1; + else + sec_ch_above = 0; + + opmode &= ~BW_OPMODE_20MHZ; + rtl8723au_write8(priv, REG_BW_OPMODE, opmode); + rsr &= ~RSR_RSC_BANDWIDTH_40M; + if (sec_ch_above) + rsr |= RSR_RSC_UPPER_SUB_CHANNEL; + else + rsr |= RSR_RSC_LOWER_SUB_CHANNEL; + rtl8723au_write32(priv, REG_RESPONSE_RATE_SET, rsr); + + val32 = rtl8723au_read32(priv, REG_FPGA0_RF_MODE); + val32 |= FPGA_RF_MODE; + rtl8723au_write32(priv, REG_FPGA0_RF_MODE, val32); + + val32 = rtl8723au_read32(priv, REG_FPGA1_RF_MODE); + val32 |= FPGA_RF_MODE; + rtl8723au_write32(priv, REG_FPGA1_RF_MODE, val32); + + /* + * Set Control channel to upper or lower. These settings + * are required only for 40MHz + */ + val32 = rtl8723au_read32(priv, REG_CCK0_SYSTEM); + val32 &= ~CCK0_SIDEBAND; + if (!sec_ch_above) + val32 |= CCK0_SIDEBAND; + rtl8723au_write32(priv, REG_CCK0_SYSTEM, val32); + + val32 = rtl8723au_read32(priv, REG_OFDM1_LSTF); + val32 &= ~(BIT(10) | BIT(11)); /* 0xc00 */ + if (sec_ch_above) + val32 |= BIT(10); + else + val32 |= BIT(11); + rtl8723au_write32(priv, REG_OFDM1_LSTF, val32); + + val32 = rtl8723au_read32(priv, REG_FPGA0_ANALOG2); + val32 &= ~BIT(10); + rtl8723au_write32(priv, REG_FPGA0_ANALOG2, val32); + + val32 = rtl8723au_read32(priv, REG_FPGA0_POWER_SAVE); + val32 &= ~(FPGA0_PS_LOWER_CHANNEL | FPGA0_PS_UPPER_CHANNEL); + if (sec_ch_above) + val32 |= FPGA0_PS_UPPER_CHANNEL; + else + val32 |= FPGA0_PS_LOWER_CHANNEL; + rtl8723au_write32(priv, REG_FPGA0_POWER_SAVE, val32); + break; + + default: + break; + } + + if (ht) + val8 = 0x0e; + else + val8 = 0x0a; + + rtl8723au_write8(priv, REG_SIFS_CCK + 1, val8); + rtl8723au_write8(priv, REG_SIFS_OFDM + 1, val8); + + rtl8723au_write16(priv, REG_R2T_SIFS, 0x0808); + rtl8723au_write16(priv, REG_T2T_SIFS, 0x0a0a); + + val32 = rtl8723au_read_rfreg(priv, RF6052_REG_MODE_AG); + if (hw->conf.chandef.width == NL80211_CHAN_WIDTH_40) + val32 &= ~MODE_AG_CHANNEL_20MHZ; + else + val32 |= MODE_AG_CHANNEL_20MHZ; + rtl8723au_write_rfreg(priv, RF6052_REG_MODE_AG, val32); +} + +static void +rtl8723a_set_tx_power(struct rtl8xxxu_priv *priv, int channel, bool ht40) +{ + struct rtl8723au_efuse *efuse; + u8 cck[RTL8723A_MAX_RF_PATHS], ofdm[RTL8723A_MAX_RF_PATHS]; + u8 ofdmbase[RTL8723A_MAX_RF_PATHS], mcsbase[RTL8723A_MAX_RF_PATHS]; + u32 val32, ofdm_a, ofdm_b, mcs_a, mcs_b; + u8 val8; + int group, i; + + efuse = &priv->efuse_wifi.efuse; + + group = rtl8723a_channel_to_group(channel); + + cck[0] = efuse->cck_tx_power_index_A[group]; + ofdm[0] = efuse->ht40_1s_tx_power_index_A[group]; + + if (priv->rf_paths > 1) { + cck[1] = efuse->cck_tx_power_index_B[group]; + ofdm[1] = efuse->ht40_1s_tx_power_index_B[group]; + } else { + cck[1] = 0; + ofdm[1] = 0; + } + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_CHANNEL) + dev_info(&priv->udev->dev, + "%s: Setting TX power CCK A: %02x, " + "CCK B: %02x, OFDM A: %02x, OFDM B: %02x\n", + __func__, cck[0], cck[1], ofdm[0], ofdm[1]); + + for (i = 0; i < RTL8723A_MAX_RF_PATHS; i++) { + if (cck[i] > RF6052_MAX_TX_PWR) + cck[i] = RF6052_MAX_TX_PWR; + if (ofdm[i] > RF6052_MAX_TX_PWR) + ofdm[i] = RF6052_MAX_TX_PWR; + } + + val32 = rtl8723au_read32(priv, REG_TX_AGC_A_CCK1_MCS32); + val32 &= 0xffff00ff; + val32 |= (cck[0] << 8); + rtl8723au_write32(priv, REG_TX_AGC_A_CCK1_MCS32, val32); + + val32 = rtl8723au_read32(priv, REG_TX_AGC_B_CCK11_A_CCK2_11); + val32 &= 0xff; + val32 |= ((cck[0] << 8) | (cck[0] << 16) | (cck[0] << 24)); + rtl8723au_write32(priv, REG_TX_AGC_B_CCK11_A_CCK2_11, val32); + + val32 = rtl8723au_read32(priv, REG_TX_AGC_B_CCK11_A_CCK2_11); + val32 &= 0xffffff00; + val32 |= cck[1]; + rtl8723au_write32(priv, REG_TX_AGC_B_CCK11_A_CCK2_11, val32); + + val32 = rtl8723au_read32(priv, REG_TX_AGC_B_CCK1_55_MCS32); + val32 &= 0xff; + val32 |= ((cck[1] << 8) | (cck[1] << 16) | (cck[1] << 24)); + rtl8723au_write32(priv, REG_TX_AGC_B_CCK1_55_MCS32, val32); + + ofdmbase[0] = ofdm[0] + efuse->ofdm_tx_power_index_diff[group].a; + mcsbase[0] = ofdm[0]; + if (!ht40) + mcsbase[0] += efuse->ht20_tx_power_index_diff[group].a; + + ofdmbase[1] = ofdm[1] + efuse->ofdm_tx_power_index_diff[group].b; + mcsbase[1] = ofdm[1]; + if (!ht40) + mcsbase[1] += efuse->ht20_tx_power_index_diff[group].b; + + ofdm_a = ofdmbase[0] | ofdmbase[0] << 8 | + ofdmbase[0] << 16 | ofdmbase[0] << 24; + ofdm_b = ofdmbase[1] | ofdmbase[1] << 8 | + ofdmbase[1] << 16 | ofdmbase[1] << 24; + rtl8723au_write32(priv, REG_TX_AGC_A_RATE18_06, ofdm_a); + rtl8723au_write32(priv, REG_TX_AGC_B_RATE18_06, ofdm_b); + + rtl8723au_write32(priv, REG_TX_AGC_A_RATE54_24, ofdm_a); + rtl8723au_write32(priv, REG_TX_AGC_B_RATE54_24, ofdm_b); + + mcs_a = mcsbase[0] | mcsbase[0] << 8 | + mcsbase[0] << 16 | mcsbase[0] << 24; + mcs_b = mcsbase[1] | mcsbase[1] << 8 | + mcsbase[1] << 16 | mcsbase[1] << 24; + + rtl8723au_write32(priv, REG_TX_AGC_A_MCS03_MCS00, mcs_a); + rtl8723au_write32(priv, REG_TX_AGC_B_MCS03_MCS00, mcs_b); + + rtl8723au_write32(priv, REG_TX_AGC_A_MCS07_MCS04, mcs_a); + rtl8723au_write32(priv, REG_TX_AGC_B_MCS07_MCS04, mcs_b); + + rtl8723au_write32(priv, REG_TX_AGC_A_MCS11_MCS08, mcs_a); + rtl8723au_write32(priv, REG_TX_AGC_B_MCS11_MCS08, mcs_b); + + rtl8723au_write32(priv, REG_TX_AGC_A_MCS15_MCS12, mcs_a); + for (i = 0; i < 3; i++) { + if (i != 2) + val8 = (mcsbase[0] > 8) ? (mcsbase[0] - 8) : 0; + else + val8 = (mcsbase[0] > 6) ? (mcsbase[0] - 6) : 0; + rtl8723au_write8(priv, REG_OFDM0_XC_TX_IQ_IMBALANCE + i, val8); + } + rtl8723au_write32(priv, REG_TX_AGC_B_MCS15_MCS12, mcs_b); + for (i = 0; i < 3; i++) { + if (i != 2) + val8 = (mcsbase[1] > 8) ? (mcsbase[1] - 8) : 0; + else + val8 = (mcsbase[1] > 6) ? (mcsbase[1] - 6) : 0; + rtl8723au_write8(priv, REG_OFDM0_XD_TX_IQ_IMBALANCE + i, val8); + } +} + +static void rtl8xxxu_set_linktype(struct rtl8xxxu_priv *priv, + enum nl80211_iftype linktype) +{ + u16 val8; + + val8 = rtl8723au_read16(priv, REG_MSR); + val8 &= ~MSR_LINKTYPE_MASK; + + switch (linktype) { + case NL80211_IFTYPE_UNSPECIFIED: + val8 |= MSR_LINKTYPE_NONE; + break; + case NL80211_IFTYPE_ADHOC: + val8 |= MSR_LINKTYPE_ADHOC; + break; + case NL80211_IFTYPE_STATION: + val8 |= MSR_LINKTYPE_STATION; + break; + case NL80211_IFTYPE_AP: + val8 |= MSR_LINKTYPE_AP; + break; + default: + goto out; + } + + rtl8723au_write8(priv, REG_MSR, val8); +out: + return; +} + +static void +rtl8xxxu_set_retry(struct rtl8xxxu_priv *priv, u16 short_retry, u16 long_retry) +{ + u16 val16; + + val16 = ((short_retry << RETRY_LIMIT_SHORT_SHIFT) & + RETRY_LIMIT_SHORT_MASK) | + ((long_retry << RETRY_LIMIT_LONG_SHIFT) & + RETRY_LIMIT_LONG_MASK); + + rtl8723au_write16(priv, REG_RETRY_LIMIT, val16); +} + +static void +rtl8xxxu_set_spec_sifs(struct rtl8xxxu_priv *priv, u16 cck, u16 ofdm) +{ + u16 val16; + + val16 = ((cck << SPEC_SIFS_CCK_SHIFT) & SPEC_SIFS_CCK_MASK) | + ((ofdm << SPEC_SIFS_OFDM_SHIFT) & SPEC_SIFS_OFDM_MASK); + + rtl8723au_write16(priv, REG_SPEC_SIFS, val16); +} + +static void rtl8xxxu_8723au_identify_chip(struct rtl8xxxu_priv *priv) +{ + struct device *dev = &priv->udev->dev; + u32 val32; + u16 val16; + char *cut; + + val32 = rtl8723au_read32(priv, REG_SYS_CFG); + priv->chip_cut = (val32 & SYS_CFG_CHIP_VERSION_MASK) >> + SYS_CFG_CHIP_VERSION_SHIFT; + switch (priv->chip_cut) { + case 0: + cut = "A"; + break; + case 1: + cut = "B"; + break; + default: + cut = "unknown"; + } + + val32 = rtl8723au_read32(priv, REG_GPIO_OUTSTS); + priv->rom_rev = (val32 & GPIO_RF_RL_ID) >> 28; + + val32 = rtl8723au_read32(priv, REG_MULTI_FUNC_CTRL); + if (val32 & MULTI_WIFI_FUNC_EN) + priv->has_wifi = 1; + if (val32 & MULTI_BT_FUNC_EN) + priv->has_bluetooth = 1; + if (val32 & MULTI_GPS_FUNC_EN) + priv->has_gps = 1; + + if (val32 & SYS_CFG_VENDOR_ID) + priv->vendor_umc = 1; + + /* The rtl8192 presumably can have 2 */ + priv->rf_paths = 1; + + val16 = rtl8723au_read16(priv, REG_NORMAL_SIE_EP_TX); + if (val16 & NORMAL_SIE_EP_TX_HIGH_MASK) { + priv->ep_tx_high_queue = 1; + priv->ep_tx_count++; + } + + if (val16 & NORMAL_SIE_EP_TX_NORMAL_MASK) { + priv->ep_tx_normal_queue = 1; + priv->ep_tx_count++; + } + + if (val16 & NORMAL_SIE_EP_TX_LOW_MASK) { + priv->ep_tx_low_queue = 1; + priv->ep_tx_count++; + } + + dev_info(dev, "RTL8723au rev %s, features: WiFi=%i, BT=%i, GPS=%i\n", + cut, priv->has_wifi, priv->has_bluetooth, priv->has_gps); + + dev_info(dev, "%s: RTL8723au number of TX queues: %i\n", + __func__, priv->ep_tx_count); +} + +static int +rtl8xxxu_read_efuse8(struct rtl8xxxu_priv *priv, u16 offset, u8 *data) +{ + int i; + u8 val8; + u32 val32; + + /* Write Address */ + rtl8723au_write8(priv, REG_EFUSE_CTRL + 1, offset & 0xff); + val8 = rtl8723au_read8(priv, REG_EFUSE_CTRL + 2); + val8 &= 0xfc; + val8 |= (offset >> 8) & 0x03; + rtl8723au_write8(priv, REG_EFUSE_CTRL + 2, val8); + + val8 = rtl8723au_read8(priv, REG_EFUSE_CTRL + 3); + rtl8723au_write8(priv, REG_EFUSE_CTRL + 3, val8 & 0x7f); + + /* Poll for data read */ + val32 = rtl8723au_read32(priv, REG_EFUSE_CTRL); + for (i = 0; i < RTL8XXXU_MAX_REG_POLL; i++) { + val32 = rtl8723au_read32(priv, REG_EFUSE_CTRL); + if (val32 & BIT(31)) + break; + } + + if (i == RTL8XXXU_MAX_REG_POLL) + return -EIO; + + udelay(50); + val32 = rtl8723au_read32(priv, REG_EFUSE_CTRL); + + *data = val32 & 0xff; + return 0; +} + +static int rtl8xxxu_read_efuse(struct rtl8xxxu_priv *priv) +{ + struct device *dev = &priv->udev->dev; + int i, ret = 0; + u8 val8, word_mask, header, extheader; + u16 val16, efuse_addr, offset; + u32 val32; + + val16 = rtl8723au_read16(priv, REG_9346CR); + if (val16 & EEPROM_ENABLE) + priv->has_eeprom = 1; + if (val16 & EEPROM_BOOT) + priv->boot_eeprom = 1; + + val32 = rtl8723au_read32(priv, REG_EFUSE_TEST); + val32 = (val32 & ~EFUSE_SELECT_MASK) | EFUSE_WIFI_SELECT; + rtl8723au_write32(priv, REG_EFUSE_TEST, val32); + + dev_dbg(dev, "Booting from %s\n", + priv->boot_eeprom ? "EEPROM" : "EFUSE"); + + rtl8723au_write8(priv, REG_EFUSE_ACCESS, EFUSE_ACCESS_ENABLE); + + /* 1.2V Power: From VDDON with Power Cut(0x0000[15]), default valid */ + val16 = rtl8723au_read16(priv, REG_SYS_ISO_CTRL); + if (!(val16 & SYS_ISO_PWC_EV12V)) { + val16 |= SYS_ISO_PWC_EV12V; + rtl8723au_write16(priv, REG_SYS_ISO_CTRL, val16); + } + /* Reset: 0x0000[28], default valid */ + val16 = rtl8723au_read16(priv, REG_SYS_FUNC); + if (!(val16 & SYS_FUNC_ELDR)) { + val16 |= SYS_FUNC_ELDR; + rtl8723au_write16(priv, REG_SYS_FUNC, val16); + } + + /* + * Clock: Gated(0x0008[5]) 8M(0x0008[1]) clock from ANA, default valid + */ + val16 = rtl8723au_read16(priv, REG_SYS_CLKR); + if (!(val16 & SYS_CLK_LOADER_ENABLE) || !(val16 & SYS_CLK_ANA8M)) { + val16 |= (SYS_CLK_LOADER_ENABLE | SYS_CLK_ANA8M); + rtl8723au_write16(priv, REG_SYS_CLKR, val16); + } + + /* Default value is 0xff */ + memset(priv->efuse_wifi.raw, 0xff, EFUSE_MAP_LEN_8723A); + + efuse_addr = 0; + while (efuse_addr < EFUSE_REAL_CONTENT_LEN_8723A) { + ret = rtl8xxxu_read_efuse8(priv, efuse_addr++, &header); + if (ret || header == 0xff) + goto exit; + + if ((header & 0x1f) == 0x0f) { /* extended header */ + offset = (header & 0xe0) >> 5; + + ret = rtl8xxxu_read_efuse8(priv, efuse_addr++, + &extheader); + if (ret) + goto exit; + /* All words disabled */ + if ((extheader & 0x0f) == 0x0f) + continue; + + offset |= ((extheader & 0xf0) >> 1); + word_mask = extheader & 0x0f; + } else { + offset = (header >> 4) & 0x0f; + word_mask = header & 0x0f; + } + + if (offset < EFUSE_MAX_SECTION_8723A) { + u16 map_addr; + /* Get word enable value from PG header */ + + /* We have 8 bits to indicate validity */ + map_addr = offset * 8; + if (map_addr >= EFUSE_MAP_LEN_8723A) { + dev_warn(dev, "%s: Illegal map_addr (%04x), " + "efuse corrupt!\n", + __func__, map_addr); + ret = -EINVAL; + goto exit; + } + for (i = 0; i < EFUSE_MAX_WORD_UNIT; i++) { + /* Check word enable condition in the section */ + if (!(word_mask & BIT(i))) { + ret = rtl8xxxu_read_efuse8(priv, + efuse_addr++, + &val8); + priv->efuse_wifi.raw[map_addr++] = val8; + + ret = rtl8xxxu_read_efuse8(priv, + efuse_addr++, + &val8); + priv->efuse_wifi.raw[map_addr++] = val8; + } else + map_addr += 2; + } + } else { + dev_warn(dev, + "%s: Illegal offset (%04x), efuse corrupt!\n", + __func__, offset); + ret = -EINVAL; + goto exit; + } + } + +exit: + rtl8723au_write8(priv, REG_EFUSE_ACCESS, EFUSE_ACCESS_DISABLE); + + if (priv->efuse_wifi.efuse.rtl_id != cpu_to_le16(0x8129)) + ret = EINVAL; + + return ret; +} + +static int rtl8xxxu_start_firmware(struct rtl8xxxu_priv *priv) +{ + struct device *dev = &priv->udev->dev; + int ret = 0, i; + u32 val32; + + /* Poll checksum report */ + for (i = 0; i < RTL8XXXU_FIRMWARE_POLL_MAX; i++) { + val32 = rtl8723au_read32(priv, REG_MCU_FW_DL); + if (val32 & MCU_FW_DL_CSUM_REPORT) + break; + } + + if (i == RTL8XXXU_FIRMWARE_POLL_MAX) { + dev_warn(dev, "Firmware checksum poll timed out\n"); + ret = -EAGAIN; + goto exit; + } + + val32 = rtl8723au_read32(priv, REG_MCU_FW_DL); + val32 |= MCU_FW_DL_READY; + val32 &= ~MCU_WINT_INIT_READY; + rtl8723au_write32(priv, REG_MCU_FW_DL, val32); + + /* Wait for firmware to become ready */ + for (i = 0; i < RTL8XXXU_FIRMWARE_POLL_MAX; i++) { + val32 = rtl8723au_read32(priv, REG_MCU_FW_DL); + if (val32 & MCU_WINT_INIT_READY) + break; + + udelay(100); + } + + if (i == RTL8XXXU_FIRMWARE_POLL_MAX) { + dev_warn(dev, "Firmware failed to start\n"); + ret = -EAGAIN; + goto exit; + } + +exit: + return ret; +} + +static int rtl8xxxu_download_firmware(struct rtl8xxxu_priv *priv) +{ + int pages, remainder, i, ret; + u8 val8; + u16 val16; + u32 val32; + u8 *fwptr; + + val8 = rtl8723au_read8(priv, REG_SYS_FUNC + 1); + val8 |= 4; + rtl8723au_write8(priv, REG_SYS_FUNC + 1, val8); + + /* 8051 enable */ + val16 = rtl8723au_read16(priv, REG_SYS_FUNC); + rtl8723au_write16(priv, REG_SYS_FUNC, val16 | SYS_FUNC_CPU_ENABLE); + + /* MCU firmware download enable */ + val8 = rtl8723au_read8(priv, REG_MCU_FW_DL); + rtl8723au_write8(priv, REG_MCU_FW_DL, val8 | MCU_FW_DL_ENABLE); + + /* 8051 reset */ + val32 = rtl8723au_read32(priv, REG_MCU_FW_DL); + rtl8723au_write32(priv, REG_MCU_FW_DL, val32 & ~BIT(19)); + + /* Reset firmware download checksum */ + val8 = rtl8723au_read8(priv, REG_MCU_FW_DL); + rtl8723au_write8(priv, REG_MCU_FW_DL, val8 | MCU_FW_DL_CSUM_REPORT); + + pages = priv->fw_size / RTL_FW_PAGE_SIZE; + remainder = priv->fw_size % RTL_FW_PAGE_SIZE; + + fwptr = priv->fw_data->data; + + for (i = 0; i < pages; i++) { + val8 = rtl8723au_read8(priv, REG_MCU_FW_DL + 2) & 0xF8; + rtl8723au_write8(priv, REG_MCU_FW_DL + 2, val8 | i); + + ret = rtl8723au_writeN(priv, REG_8723A_FW_START_ADDRESS, + fwptr, RTL_FW_PAGE_SIZE); + if (ret != RTL_FW_PAGE_SIZE) { + ret = -EAGAIN; + goto fw_abort; + } + + fwptr += RTL_FW_PAGE_SIZE; + } + + if (remainder) { + val8 = rtl8723au_read8(priv, REG_MCU_FW_DL + 2) & 0xF8; + rtl8723au_write8(priv, REG_MCU_FW_DL + 2, val8 | i); + ret = rtl8723au_writeN(priv, REG_8723A_FW_START_ADDRESS, + fwptr, remainder); + if (ret != remainder) { + ret = -EAGAIN; + goto fw_abort; + } + } + + ret = 0; +fw_abort: + /* MCU firmware download disable */ + val16 = rtl8723au_read16(priv, REG_MCU_FW_DL); + rtl8723au_write16(priv, REG_MCU_FW_DL, + val16 & (~MCU_FW_DL_ENABLE & 0xff)); + + return ret; +} + +static int rtl8xxxu_load_firmware(struct rtl8xxxu_priv *priv) +{ + struct device *dev = &priv->udev->dev; + const struct firmware *fw; + char *fw_name; + int ret = 0; + u16 signature; + + switch (priv->chip_cut) { + case 0: + fw_name = "rtlwifi/rtl8723aufw_A.bin"; + break; + case 1: + if (priv->enable_bluetooth) + fw_name = "rtlwifi/rtl8723aufw_B.bin"; + else + fw_name = "rtlwifi/rtl8723aufw_B_NoBT.bin"; + + break; + default: + return -EINVAL; + } + + dev_info(dev, "%s: Loading firmware %s\n", DRIVER_NAME, fw_name); + if (request_firmware(&fw, fw_name, &priv->udev->dev)) { + dev_warn(dev, "request_firmware(%s) failed\n", fw_name); + ret = -EAGAIN; + goto exit; + } + if (!fw) { + dev_warn(dev, "Firmware data not available\n"); + ret = -EINVAL; + goto exit; + } + + priv->fw_data = kmemdup(fw->data, fw->size, GFP_KERNEL); + priv->fw_size = fw->size - sizeof(struct rtl8xxxu_firmware_header); + + signature = le16_to_cpu(priv->fw_data->signature); + switch (signature & 0xfff0) { + case 0x92c0: + case 0x88c0: + case 0x2300: + break; + default: + ret = -EINVAL; + dev_warn(dev, "%s: Invalid firmware signature: 0x%04x\n", + __func__, signature); + } + + dev_info(dev, "Firmware revision %i.%i (signature 0x%04x)\n", + le16_to_cpu(priv->fw_data->major_version), + priv->fw_data->minor_version, signature); + +exit: + release_firmware(fw); + return ret; +} + +static void rtl8xxxu_firmware_self_reset(struct rtl8xxxu_priv *priv) +{ + u16 val16; + int i = 100; + + /* Inform 8051 to perform reset */ + rtl8723au_write8(priv, REG_HMTFR + 3, 0x20); + + for (i = 100; i > 0; i--) { + val16 = rtl8723au_read16(priv, REG_SYS_FUNC); + + if (!(val16 & SYS_FUNC_CPU_ENABLE)) { + dev_dbg(&priv->udev->dev, + "%s: Firmware self reset success!\n", __func__); + break; + } + udelay(50); + } + + if (!i) { + /* Force firmware reset */ + val16 = rtl8723au_read16(priv, REG_SYS_FUNC); + val16 &= ~SYS_FUNC_CPU_ENABLE; + rtl8723au_write16(priv, REG_SYS_FUNC, val16); + } +} + +static int +rtl8xxxu_init_mac(struct rtl8xxxu_priv *priv, struct rtl8xxxu_reg8val *array) +{ + int i, ret; + u16 reg; + u8 val; + + for (i = 0; ; i++) { + reg = array[i].reg; + val = array[i].val; + + if (reg == 0xffff && val == 0xff) + break; + + ret = rtl8723au_write8(priv, reg, val); + if (ret != 1) { + dev_warn(&priv->udev->dev, + "Failed to initialize MAC\n"); + return -EAGAIN; + } + } + + rtl8723au_write8(priv, REG_MAX_AGGR_NUM, 0x0a); + + return 0; +} + +static int rtl8xxxu_init_phy_regs(struct rtl8xxxu_priv *priv, + struct rtl8xxxu_reg32val *array) +{ + int i, ret; + u16 reg; + u32 val; + + for (i = 0; ; i++) { + reg = array[i].reg; + val = array[i].val; + + if (reg == 0xffff && val == 0xffffffff) + break; + + ret = rtl8723au_write32(priv, reg, val); + if (ret != sizeof(val)) { + dev_warn(&priv->udev->dev, + "Failed to initialize PHY\n"); + return -EAGAIN; + } + udelay(1); + } + + return 0; +} + +/* + * Most of this is black magic retrieved from the old rtl8723au driver + */ +static int rtl8xxxu_init_phy_bb(struct rtl8xxxu_priv *priv) +{ + u8 val8, ldoa15, ldov12d, lpldo, ldohci12; + u32 val32; + + /* + * Todo: The vendor driver maintains a table of PHY register + * addresses, which is initialized here. Do we need this? + */ + + val8 = rtl8723au_read8(priv, REG_AFE_PLL_CTRL); + udelay(2); + val8 |= AFE_PLL_320_ENABLE; + rtl8723au_write8(priv, REG_AFE_PLL_CTRL, val8); + udelay(2); + + rtl8723au_write8(priv, REG_AFE_PLL_CTRL + 1, 0xff); + udelay(2); + + val8 = rtl8723au_read8(priv, REG_SYS_FUNC); + val8 |= SYS_FUNC_BB_GLB_RSTN | SYS_FUNC_BBRSTB; + rtl8723au_write8(priv, REG_SYS_FUNC, val8); + + /* AFE_XTAL_RF_GATE (bit 14) if addressing as 32 bit register */ + val8 = rtl8723au_read8(priv, REG_AFE_XTAL_CTRL + 1); + val8 &= ~BIT(6); + rtl8723au_write8(priv, REG_AFE_XTAL_CTRL + 1, val8); + + /* AFE_XTAL_BT_GATE (bit 20) if addressing as 32 bit register */ + val8 = rtl8723au_read8(priv, REG_AFE_XTAL_CTRL + 2); + val8 &= ~BIT(4); + rtl8723au_write8(priv, REG_AFE_XTAL_CTRL + 2, val8); + + /* 6. 0x1f[7:0] = 0x07 */ + val8 = RF_ENABLE | RF_RSTB | RF_SDMRSTB; + rtl8723au_write8(priv, REG_RF_CTRL, val8); + + rtl8xxxu_init_phy_regs(priv, rtl8723a_phy_1t_init_table); + + rtl8xxxu_init_phy_regs(priv, rtl8723a_agc_1t_init_table); + if (priv->efuse_wifi.efuse.version >= 0x01) { + val32 = rtl8723au_read32(priv, REG_MAC_PHY_CTRL); + + val8 = priv->efuse_wifi.efuse.xtal_k & 0x3f; + val32 &= 0xff000fff; + val32 |= ((val8 | (val8 << 6)) << 12); + + rtl8723au_write32(priv, REG_MAC_PHY_CTRL, val32); + } + + ldoa15 = LDOA15_ENABLE | LDOA15_OBUF; + ldov12d = LDOV12D_ENABLE | BIT(2) | (2 << LDOV12D_VADJ_SHIFT); + ldohci12 = 0x57; + lpldo = 1; + val32 = (lpldo << 24) | (ldohci12 << 16) | (ldov12d << 8) | ldoa15; + + rtl8723au_write32(priv, REG_LDOA15_CTRL, val32); + + return 0; +} + +static int rtl8xxxu_init_rf_regs(struct rtl8xxxu_priv *priv, + struct rtl8xxxu_rfregval *array) +{ + int i, ret; + u8 reg; + u32 val; + + for (i = 0; ; i++) { + reg = array[i].reg; + val = array[i].val; + + if (reg == 0xff && val == 0xffffffff) + break; + + switch (reg) { + case 0xfe: + msleep(50); + continue; + case 0xfd: + mdelay(5); + continue; + case 0xfc: + mdelay(1); + continue; + case 0xfb: + udelay(50); + continue; + case 0xfa: + udelay(5); + continue; + case 0xf9: + udelay(1); + continue; + } + + reg &= 0x3f; + + ret = rtl8723au_write_rfreg(priv, reg, val); + if (ret) { + dev_warn(&priv->udev->dev, + "Failed to initialize RF\n"); + return -EAGAIN; + } + udelay(1); + } + + return 0; +} + +static int rtl8xxxu_init_phy_rf(struct rtl8xxxu_priv *priv) +{ + u32 val32; + u16 val16, rfsi_rfenv; + + /* For path B, use XB */ + rfsi_rfenv = rtl8723au_read16(priv, REG_FPGA0_XA_RF_SW_CTRL); + rfsi_rfenv &= FPGA0_RF_RFENV; + + /* + * These two we might be able to optimize into one + */ + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_RF_INT_OE); + val32 |= BIT(20); /* 0x10 << 16 */ + rtl8723au_write32(priv, REG_FPGA0_XA_RF_INT_OE, val32); + udelay(1); + + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_RF_INT_OE); + val32 |= BIT(4); + rtl8723au_write32(priv, REG_FPGA0_XA_RF_INT_OE, val32); + udelay(1); + + /* + * These two we might be able to optimize into one + */ + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_HSSI_PARM2); + val32 &= ~FPGA0_HSSI_3WIRE_ADDR_LEN; + rtl8723au_write32(priv, REG_FPGA0_XA_HSSI_PARM2, val32); + udelay(1); + + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_HSSI_PARM2); + val32 &= ~FPGA0_HSSI_3WIRE_DATA_LEN; + rtl8723au_write32(priv, REG_FPGA0_XA_HSSI_PARM2, val32); + udelay(1); + + rtl8xxxu_init_rf_regs(priv, rtl8723au_radioa_rf6052_1t_init_table); + + /* For path B, use XB */ + val16 = rtl8723au_read16(priv, REG_FPGA0_XA_RF_SW_CTRL); + val16 &= ~FPGA0_RF_RFENV; + val16 |= rfsi_rfenv; + rtl8723au_write16(priv, REG_FPGA0_XA_RF_SW_CTRL, val16); + + return 0; +} + +static int rtl8xxxu_llt_write(struct rtl8xxxu_priv *priv, u8 address, u8 data) +{ + int ret = -EBUSY; + int count = 0; + u32 value; + + value = LLT_OP_WRITE | address << 8 | data; + + rtl8723au_write32(priv, REG_LLT_INIT, value); + + do { + value = rtl8723au_read32(priv, REG_LLT_INIT); + if ((value & LLT_OP_MASK) == LLT_OP_INACTIVE) { + ret = 0; + break; + } + } while (count++ < 20); + + return ret; +} + +static int rtl8xxxu_init_llt_table(struct rtl8xxxu_priv *priv, u8 last_tx_page) +{ + int ret; + int i; + + for (i = 0; i < last_tx_page; i++) { + ret = rtl8xxxu_llt_write(priv, i, i + 1); + if (ret) + goto exit; + } + + ret = rtl8xxxu_llt_write(priv, last_tx_page, 0xff); + if (ret) + goto exit; + + /* Mark remaining pages as a ring buffer */ + for (i = last_tx_page + 1; i < 0xff; i++) { + ret = rtl8xxxu_llt_write(priv, i, (i + 1)); + if (ret) + goto exit; + } + + /* Let last entry point to the start entry of ring buffer */ + ret = rtl8xxxu_llt_write(priv, 0xff, last_tx_page + 1); + if (ret) + goto exit; + +exit: + return ret; +} + +static int rtl8xxxu_init_queue_priority(struct rtl8xxxu_priv *priv) +{ + u16 val16, hi, lo; + u16 hiq, mgq, bkq, beq, viq, voq; + int hip, mgp, bkp, bep, vip, vop; + int ret = 0; + + switch (priv->ep_tx_count) { + case 1: + if (priv->ep_tx_high_queue) { + hi = TRXDMA_QUEUE_HIGH; + } else if (priv->ep_tx_low_queue) { + hi = TRXDMA_QUEUE_LOW; + } else if (priv->ep_tx_normal_queue) { + hi = TRXDMA_QUEUE_NORMAL; + } else { + hi = 0; + ret = -EINVAL; + } + + hiq = hi; + mgq = hi; + bkq = hi; + beq = hi; + viq = hi; + voq = hi; + + hip = 0; + mgp = 0; + bkp = 0; + bep = 0; + vip = 0; + vop = 0; + break; + case 2: + if (priv->ep_tx_high_queue && priv->ep_tx_low_queue) { + hi = TRXDMA_QUEUE_HIGH; + lo = TRXDMA_QUEUE_LOW; + } else if (priv->ep_tx_normal_queue && priv->ep_tx_low_queue) { + hi = TRXDMA_QUEUE_NORMAL; + lo = TRXDMA_QUEUE_LOW; + } else if (priv->ep_tx_high_queue && priv->ep_tx_normal_queue) { + hi = TRXDMA_QUEUE_HIGH; + lo = TRXDMA_QUEUE_NORMAL; + } else { + ret = -EINVAL; + hi = 0; + lo = 0; + } + + hiq = hi; + mgq = hi; + bkq = lo; + beq = lo; + viq = hi; + voq = hi; + + hip = 0; + mgp = 0; + bkp = 1; + bep = 1; + vip = 0; + vop = 0; + break; + case 3: + beq = TRXDMA_QUEUE_LOW; + bkq = TRXDMA_QUEUE_LOW; + viq = TRXDMA_QUEUE_NORMAL; + voq = TRXDMA_QUEUE_HIGH; + mgq = TRXDMA_QUEUE_HIGH; + hiq = TRXDMA_QUEUE_HIGH; + + hip = hiq ^ 3; + mgp = mgq ^ 3; + bkp = bkq ^ 3; + bep = beq ^ 3; + vip = viq ^ 3; + vop = viq ^ 3; + break; + default: + ret = -EINVAL; + } + + /* + * None of the vendor drivers are configuring the beacon + * queue here .... why? + */ + if (!ret) { + val16 = rtl8723au_read16(priv, REG_TRXDMA_CTRL); + val16 &= 0x7; + val16 |= (voq << TRXDMA_CTRL_VOQ_SHIFT) | + (viq << TRXDMA_CTRL_VIQ_SHIFT) | + (beq << TRXDMA_CTRL_BEQ_SHIFT) | + (bkq << TRXDMA_CTRL_BKQ_SHIFT) | + (mgq << TRXDMA_CTRL_MGQ_SHIFT) | + (hiq << TRXDMA_CTRL_HIQ_SHIFT); + rtl8723au_write16(priv, REG_TRXDMA_CTRL, val16); + + priv->pipe_out[TXDESC_QUEUE_VO] = + usb_sndbulkpipe(priv->udev, priv->out_ep[vop]); + priv->pipe_out[TXDESC_QUEUE_VI] = + usb_sndbulkpipe(priv->udev, priv->out_ep[vip]); + priv->pipe_out[TXDESC_QUEUE_BE] = + usb_sndbulkpipe(priv->udev, priv->out_ep[bep]); + priv->pipe_out[TXDESC_QUEUE_BK] = + usb_sndbulkpipe(priv->udev, priv->out_ep[bkp]); + priv->pipe_out[TXDESC_QUEUE_BEACON] = + usb_sndbulkpipe(priv->udev, priv->out_ep[0]); + priv->pipe_out[TXDESC_QUEUE_MGNT] = + usb_sndbulkpipe(priv->udev, priv->out_ep[mgp]); + priv->pipe_out[TXDESC_QUEUE_HIGH] = + usb_sndbulkpipe(priv->udev, priv->out_ep[hip]); + priv->pipe_out[TXDESC_QUEUE_CMD] = + usb_sndbulkpipe(priv->udev, priv->out_ep[0]); + } + + return ret; +} + +static void rtl8xxxu_fill_iqk_matrix_a(struct rtl8xxxu_priv *priv, + bool iqk_ok, int result[][8], + int candidate, bool tx_only) +{ + u32 oldval, x, tx0_a, reg; + int y, tx0_c; + u32 val32; + + if (!iqk_ok) + return; + + val32 = rtl8723au_read32(priv, REG_OFDM0_XA_TX_IQ_IMBALANCE); + oldval = val32 >> 22; + + x = result[candidate][0]; + if ((x & 0x00000200) != 0) + x = x | 0xfffffc00; + tx0_a = (x * oldval) >> 8; + + val32 = rtl8723au_read32(priv, REG_OFDM0_XA_TX_IQ_IMBALANCE); + val32 &= ~0x3ff; + val32 |= tx0_a; + rtl8723au_write32(priv, REG_OFDM0_XA_TX_IQ_IMBALANCE, val32); + + val32 = rtl8723au_read32(priv, REG_OFDM0_ENERGY_CCA_THRES); + val32 &= ~BIT(31); + if ((x * oldval >> 7) & 0x1) + val32 |= BIT(31); + rtl8723au_write32(priv, REG_OFDM0_ENERGY_CCA_THRES, val32); + + y = result[candidate][1]; + if ((y & 0x00000200) != 0) + y = y | 0xfffffc00; + tx0_c = (y * oldval) >> 8; + + val32 = rtl8723au_read32(priv, REG_OFDM0_XC_TX_AFE); + val32 &= ~0xf0000000; + val32 |= (((tx0_c & 0x3c0) >> 6) << 28); + rtl8723au_write32(priv, REG_OFDM0_XC_TX_AFE, val32); + + val32 = rtl8723au_read32(priv, REG_OFDM0_XA_TX_IQ_IMBALANCE); + val32 &= ~0x003f0000; + val32 |= ((tx0_c & 0x3f) << 16); + rtl8723au_write32(priv, REG_OFDM0_XA_TX_IQ_IMBALANCE, val32); + + val32 = rtl8723au_read32(priv, REG_OFDM0_ENERGY_CCA_THRES); + val32 &= ~BIT(29); + if ((y * oldval >> 7) & 0x1) + val32 |= BIT(29); + rtl8723au_write32(priv, REG_OFDM0_ENERGY_CCA_THRES, val32); + + if (tx_only) { + dev_dbg(&priv->udev->dev, "%s: only TX\n", __func__); + return; + } + + reg = result[candidate][2]; + + val32 = rtl8723au_read32(priv, REG_OFDM0_XA_RX_IQ_IMBALANCE); + val32 &= ~0x3ff; + val32 |= (reg & 0x3ff); + rtl8723au_write32(priv, REG_OFDM0_XA_RX_IQ_IMBALANCE, val32); + + reg = result[candidate][3] & 0x3F; + + val32 = rtl8723au_read32(priv, REG_OFDM0_XA_RX_IQ_IMBALANCE); + val32 &= ~0xfc00; + val32 |= ((reg << 10) & 0xfc00); + rtl8723au_write32(priv, REG_OFDM0_XA_RX_IQ_IMBALANCE, val32); + + reg = (result[candidate][3] >> 6) & 0xF; + + val32 = rtl8723au_read32(priv, REG_OFDM0_RX_IQ_EXT_ANTA); + val32 &= ~0xf0000000; + val32 |= (reg << 28); + rtl8723au_write32(priv, REG_OFDM0_RX_IQ_EXT_ANTA, val32); +} + +#define MAX_TOLERANCE 5 + +static bool rtl8xxxu_simularity_compare(struct rtl8xxxu_priv *priv, + int result[][8], int c1, int c2) +{ + u32 i, j, diff, simubitmap, bound = 0; + int candidate[2] = {-1, -1}; /* for path A and path B */ + bool retval = true, is_2t = false; + + if (is_2t) + bound = 8; + else + bound = 4; + + simubitmap = 0; + + for (i = 0; i < bound; i++) { + diff = (result[c1][i] > result[c2][i]) ? + (result[c1][i] - result[c2][i]) : + (result[c2][i] - result[c1][i]); + if (diff > MAX_TOLERANCE) { + if ((i == 2 || i == 6) && !simubitmap) { + if (result[c1][i] + result[c1][i + 1] == 0) + candidate[(i / 4)] = c2; + else if (result[c2][i] + result[c2][i + 1] == 0) + candidate[(i / 4)] = c1; + else + simubitmap = simubitmap | (1 << i); + } else { + simubitmap = simubitmap | (1 << i); + } + } + } + + if (simubitmap == 0) { + for (i = 0; i < (bound / 4); i++) { + if (candidate[i] >= 0) { + for (j = i * 4; j < (i + 1) * 4 - 2; j++) + result[3][j] = result[candidate[i]][j]; + retval = false; + } + } + return retval; + } else if (!(simubitmap & 0x0f)) { + /* path A OK */ + for (i = 0; i < 4; i++) + result[3][i] = result[c1][i]; + } else if (!(simubitmap & 0xf0) && is_2t) { + /* path B OK */ + for (i = 4; i < 8; i++) + result[3][i] = result[c1][i]; + } + + return false; +} + +static void +rtl8xxxu_save_mac_regs(struct rtl8xxxu_priv *priv, const u32 *reg, u32 *backup) +{ + int i; + + for (i = 0; i < (RTL8XXXU_MAC_REGS - 1); i++) + backup[i] = rtl8723au_read8(priv, reg[i]); + + backup[i] = rtl8723au_read32(priv, reg[i]); +} + +static void rtl8xxxu_restore_mac_regs(struct rtl8xxxu_priv *priv, + const u32 *reg, u32 *backup) +{ + int i; + + for (i = 0; i < (RTL8XXXU_MAC_REGS - 1); i++) + rtl8723au_write8(priv, reg[i], backup[i]); + + rtl8723au_write32(priv, reg[i], backup[i]); +} + +static void rtl8xxxu_save_regs(struct rtl8xxxu_priv *priv, const u32 *regs, + u32 *backup, int count) +{ + int i; + + for (i = 0; i < count; i++) + backup[i] = rtl8723au_read32(priv, regs[i]); +} + +static void rtl8xxxu_restore_regs(struct rtl8xxxu_priv *priv, const u32 *regs, + u32 *backup, int count) +{ + int i; + + for (i = 0; i < count; i++) + rtl8723au_write32(priv, regs[i], backup[i]); +} + + +static void rtl8xxxu_path_adda_on(struct rtl8xxxu_priv *priv, const u32 *regs, + bool path_a_on, bool is_2t) +{ + u32 path_on; + int i; + + path_on = path_a_on ? 0x04db25a4 : 0x0b1b25a4; + if (!is_2t) { + path_on = 0x0bdb25a0; + rtl8723au_write32(priv, regs[0], 0x0b1b25a0); + } else { + rtl8723au_write32(priv, regs[0], path_on); + } + + for (i = 1 ; i < RTL8XXXU_ADDA_REGS ; i++) + rtl8723au_write32(priv, regs[i], path_on); +} + +static void rtl8xxxu_mac_calibration(struct rtl8xxxu_priv *priv, + const u32 *regs, u32 *backup) +{ + int i = 0; + + rtl8723au_write8(priv, regs[i], 0x3f); + + for (i = 1 ; i < (RTL8XXXU_MAC_REGS - 1); i++) { + rtl8723au_write8(priv, regs[i], + (u8)(backup[i] & ~BIT(3))); + } + rtl8723au_write8(priv, regs[i], (u8)(backup[i] & ~BIT(5))); +} + +static int rtl8xxxu_iqk_path_a(struct rtl8xxxu_priv *priv, bool configpathb) +{ + u32 reg_eac, reg_e94, reg_e9c, reg_ea4; + int result = 0; + + /* path-A IQK setting */ + rtl8723au_write32(priv, REG_TX_IQK_TONE_A, 0x10008c1f); + rtl8723au_write32(priv, REG_RX_IQK_TONE_A, 0x10008c1f); + rtl8723au_write32(priv, REG_TX_IQK_PI_A, 0x82140102); + + rtl8723au_write32(priv, REG_RX_IQK_PI_A, configpathb ? 0x28160202 : + /*IS_81xxC_VENDOR_UMC_B_CUT(pHalData->VersionID)?0x28160202: */ 0x28160502); + + /* path-B IQK setting */ + if (configpathb) { + rtl8723au_write32(priv, REG_TX_IQK_TONE_B, 0x10008c22); + rtl8723au_write32(priv, REG_RX_IQK_TONE_B, 0x10008c22); + rtl8723au_write32(priv, REG_TX_IQK_PI_B, 0x82140102); + rtl8723au_write32(priv, REG_RX_IQK_PI_B, 0x28160202); + } + + /* LO calibration setting */ + rtl8723au_write32(priv, REG_IQK_AGC_RSP, 0x001028d1); + + /* One shot, path A LOK & IQK */ + rtl8723au_write32(priv, REG_IQK_AGC_PTS, 0xf9000000); + rtl8723au_write32(priv, REG_IQK_AGC_PTS, 0xf8000000); + + mdelay(1); + + /* Check failed */ + reg_eac = rtl8723au_read32(priv, REG_RX_POWER_AFTER_IQK_A_2); + reg_e94 = rtl8723au_read32(priv, REG_TX_POWER_BEFORE_IQK_A); + reg_e9c = rtl8723au_read32(priv, REG_TX_POWER_AFTER_IQK_A); + reg_ea4 = rtl8723au_read32(priv, REG_RX_POWER_BEFORE_IQK_A_2); + + if (!(reg_eac & BIT(28)) && + ((reg_e94 & 0x03ff0000) != 0x01420000) && + ((reg_e9c & 0x03ff0000) != 0x00420000)) + result |= 0x01; + else /* If TX not OK, ignore RX */ + goto out; + + /* If TX is OK, check whether RX is OK */ + if (!(reg_eac & BIT(27)) && + ((reg_ea4 & 0x03ff0000) != 0x01320000) && + ((reg_eac & 0x03ff0000) != 0x00360000)) + result |= 0x02; + else + dev_warn(&priv->udev->dev, "%s: Path A RX IQK failed!\n", + __func__); +out: + return result; +} + +static void rtl8xxxu_phy_iqcalibrate(struct rtl8xxxu_priv *priv, + int result[][8], int t, bool is_2t) +{ + struct device *dev = &priv->udev->dev; + u32 i, val32; + int path_a_ok /*, path_b_ok */; + int retry = 2; + const u32 adda_regs[RTL8XXXU_ADDA_REGS] = { + REG_FPGA0_XCD_SWITCH_CTRL, REG_BLUETOOTH, + REG_RX_WAIT_CCA, REG_TX_CCK_RFON, + REG_TX_CCK_BBON, REG_TX_OFDM_RFON, + REG_TX_OFDM_BBON, REG_TX_TO_RX, + REG_TX_TO_TX, REG_RX_CCK, + REG_RX_OFDM, REG_RX_WAIT_RIFS, + REG_RX_TO_RX, REG_STANDBY, + REG_SLEEP, REG_PMPD_ANAEN + }; + const u32 iqk_mac_regs[RTL8XXXU_MAC_REGS] = { + REG_TXPAUSE, REG_BEACON_CTRL, + REG_BEACON_CTRL_1, REG_GPIO_MUXCFG + }; + const u32 iqk_bb_regs[RTL8XXXU_BB_REGS] = { + REG_OFDM0_TRX_PATH_ENABLE, REG_OFDM0_TR_MUX_PAR, + REG_FPGA0_XCD_RF_SW_CTRL, REG_CONFIG_ANT_A, REG_CONFIG_ANT_B, + REG_FPGA0_XAB_RF_SW_CTRL, REG_FPGA0_XA_RF_INT_OE, + REG_FPGA0_XB_RF_INT_OE, REG_FPGA0_RF_MODE + }; + + /* + * Note: IQ calibration must be performed after loading + * PHY_REG.txt , and radio_a, radio_b.txt + */ + + if (t == 0) { + /* Save ADDA parameters, turn Path A ADDA on */ + rtl8xxxu_save_regs(priv, adda_regs, priv->adda_backup, + RTL8XXXU_ADDA_REGS); + rtl8xxxu_save_mac_regs(priv, iqk_mac_regs, priv->mac_backup); + rtl8xxxu_save_regs(priv, iqk_bb_regs, + priv->bb_backup, RTL8XXXU_BB_REGS); + } + + rtl8xxxu_path_adda_on(priv, adda_regs, true, is_2t); + + if (t == 0) { + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_HSSI_PARM1); + if (val32 & FPGA0_HSSI_PARM1_PI) + priv->pi_enabled = 1; + } + + if (!priv->pi_enabled) { + /* Switch BB to PI mode to do IQ Calibration. */ + rtl8723au_write32(priv, REG_FPGA0_XA_HSSI_PARM1, + 0x01000100); + rtl8723au_write32(priv, REG_FPGA0_XB_HSSI_PARM1, + 0x01000100); + } + + val32 = rtl8723au_read32(priv, REG_FPGA0_RF_MODE); + val32 &= ~FPGA_RF_MODE_CCK; + rtl8723au_write32(priv, REG_FPGA0_RF_MODE, val32); + + rtl8723au_write32(priv, REG_OFDM0_TRX_PATH_ENABLE, 0x03a05600); + rtl8723au_write32(priv, REG_OFDM0_TR_MUX_PAR, 0x000800e4); + rtl8723au_write32(priv, REG_FPGA0_XCD_RF_SW_CTRL, 0x22204000); + + val32 = rtl8723au_read32(priv, REG_FPGA0_XAB_RF_SW_CTRL); + val32 |= (FPGA0_RF_PAPE | (FPGA0_RF_PAPE << FPGA0_RF_BD_CTRL_SHIFT)); + rtl8723au_write32(priv, REG_FPGA0_XAB_RF_SW_CTRL, val32); + + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_RF_INT_OE); + val32 &= ~BIT(10); + rtl8723au_write32(priv, REG_FPGA0_XA_RF_INT_OE, val32); + val32 = rtl8723au_read32(priv, REG_FPGA0_XB_RF_INT_OE); + val32 &= ~BIT(10); + rtl8723au_write32(priv, REG_FPGA0_XB_RF_INT_OE, val32); + + if (is_2t) { + rtl8723au_write32(priv, REG_FPGA0_XA_LSSI_PARM, 0x00010000); + rtl8723au_write32(priv, REG_FPGA0_XB_LSSI_PARM, 0x00010000); + } + + /* MAC settings */ + rtl8xxxu_mac_calibration(priv, iqk_mac_regs, priv->mac_backup); + + /* Page B init */ + rtl8723au_write32(priv, REG_CONFIG_ANT_A, 0x00080000); + + if (is_2t) + rtl8723au_write32(priv, REG_CONFIG_ANT_B, 0x00080000); + + /* IQ calibration setting */ + rtl8723au_write32(priv, REG_FPGA0_IQK, 0x80800000); + rtl8723au_write32(priv, REG_TX_IQK, 0x01007c00); + rtl8723au_write32(priv, REG_RX_IQK, 0x01004800); + + for (i = 0; i < retry; i++) { + path_a_ok = rtl8xxxu_iqk_path_a(priv, is_2t); + if (path_a_ok == 0x03) { + val32 = rtl8723au_read32(priv, + REG_TX_POWER_BEFORE_IQK_A); + result[t][0] = (val32 >> 16) & 0x3ff; + val32 = rtl8723au_read32(priv, + REG_TX_POWER_AFTER_IQK_A); + result[t][1] = (val32 >> 16) & 0x3ff; + val32 = rtl8723au_read32(priv, + REG_RX_POWER_BEFORE_IQK_A_2); + result[t][2] = (val32 >> 16) & 0x3ff; + val32 = rtl8723au_read32(priv, + REG_RX_POWER_AFTER_IQK_A_2); + result[t][3] = (val32 >> 16) & 0x3ff; + break; + } else if (i == (retry - 1) && path_a_ok == 0x01) { + /* TX IQK OK */ + dev_dbg(dev, "%s: Path A IQK Only Tx Success!!\n", + __func__); + + val32 = rtl8723au_read32(priv, + REG_TX_POWER_BEFORE_IQK_A); + result[t][0] = (val32 >> 16) & 0x3ff; + val32 = rtl8723au_read32(priv, + REG_TX_POWER_AFTER_IQK_A); + result[t][1] = (val32 >> 16) & 0x3ff; + } + } + + if (!path_a_ok) + dev_dbg(dev, "%s: Path A IQK failed!\n", __func__); + +#if 0 + if (is_2t) { + rtl8xxxu_phy_path_a_standby(priv); + + /* Turn Path B ADDA on */ + rtl8xxxu_phy_path_adda_on(priv, ADDA_REG, false, is_2t); + + for (i = 0; i < retry; i++) { + path_b_ok = _PHY_PathB_IQK(priv); + if (path_b_ok == 0x03) { + val32 = rtl8723au_read32(priv, REG_TX_POWER_BEFORE_IQK_B); + result[t][4] = (val32 >> 16) & 0x3ff; + val32 = rtl8723au_read32(priv, REG_TX_POWER_AFTER_IQK_B); + result[t][5] = (val32 >> 16) & 0x3ff; + val32 = rtl8723au_read32(priv, REG_RX_POWER_BEFORE_IQK_B_2); + result[t][6] = (val32 >> 16) & 0x3ff; + val32 = rtl8723au_read32(priv, REG_RX_POWER_AFTER_IQK_B_2); + result[t][7] = (val32 >> 16) & 0x3ff; + break; + } else if (i == (retry - 1) && path_b_ok == 0x01) { + /* TX IQK OK */ + val32 = rtl8723au_read32(priv, REG_TX_POWER_BEFORE_IQK_B); + result[t][4] = (val32 >> 16) & 0x3ff; + val32 = rtl8723au_read32(priv, REG_TX_POWER_AFTER_IQK_B); + result[t][5] = (val32 >> 16) & 0x3ff; + } + } + + if (!path_b_ok) + dev_dbg(dev, "%s: Path B IQK failed!\n", __func__); + } +#endif + + /* Back to BB mode, load original value */ + rtl8723au_write32(priv, REG_FPGA0_IQK, 0); + + if (t) { + if (!priv->pi_enabled) { + /* + * Switch back BB to SI mode after finishing + * IQ Calibration + */ + val32 = 0x01000000; + rtl8723au_write32(priv, REG_FPGA0_XA_HSSI_PARM1, val32); + rtl8723au_write32(priv, REG_FPGA0_XB_HSSI_PARM1, val32); + } + + /* Reload ADDA power saving parameters */ + rtl8xxxu_restore_regs(priv, adda_regs, priv->adda_backup, + RTL8XXXU_ADDA_REGS); + + /* Reload MAC parameters */ + rtl8xxxu_restore_mac_regs(priv, iqk_mac_regs, priv->mac_backup); + + /* Reload BB parameters */ + rtl8xxxu_restore_regs(priv, iqk_bb_regs, + priv->bb_backup, RTL8XXXU_BB_REGS); + + /* Restore RX initial gain */ + rtl8723au_write32(priv, REG_FPGA0_XA_LSSI_PARM, 0x00032ed3); + + if (is_2t) { + rtl8723au_write32(priv, REG_FPGA0_XB_LSSI_PARM, + 0x00032ed3); + } + + /* Load 0xe30 IQC default value */ + rtl8723au_write32(priv, REG_TX_IQK_TONE_A, 0x01008c00); + rtl8723au_write32(priv, REG_RX_IQK_TONE_A, 0x01008c00); + } +} + +static void rtl8723a_phy_iq_calibrate(struct rtl8xxxu_priv *priv) +{ + struct device *dev = &priv->udev->dev; + int result[4][8]; /* last is final result */ + int i, candidate; + bool path_a_ok /*, path_b_ok */; + u32 reg_e94, reg_e9c, reg_ea4, reg_eac; + u32 reg_eb4, reg_ebc, reg_ec4, reg_ecc; + s32 reg_tmp = 0; + bool simu; + + memset(result, 0, sizeof(result)); + candidate = -1; + + path_a_ok = false; +#if 0 + path_b_ok = false; +#endif + rtl8723au_read32(priv, REG_FPGA0_RF_MODE); + + for (i = 0; i < 3; i++) { + rtl8xxxu_phy_iqcalibrate(priv, result, i, false); + + if (i == 1) { + simu = rtl8xxxu_simularity_compare(priv, result, 0, 1); + if (simu) { + candidate = 0; + break; + } + } + + if (i == 2) { + simu = rtl8xxxu_simularity_compare(priv, result, 0, 2); + if (simu) { + candidate = 0; + break; + } + + simu = rtl8xxxu_simularity_compare(priv, result, 1, 2); + if (simu) { + candidate = 1; + } else { + for (i = 0; i < 8; i++) + reg_tmp += result[3][i]; + + if (reg_tmp) + candidate = 3; + else + candidate = -1; + } + } + } + + for (i = 0; i < 4; i++) { + reg_e94 = result[i][0]; + reg_e9c = result[i][1]; + reg_ea4 = result[i][2]; + reg_eac = result[i][3]; + reg_eb4 = result[i][4]; + reg_ebc = result[i][5]; + reg_ec4 = result[i][6]; + reg_ecc = result[i][7]; + } + + if (candidate >= 0) { + reg_e94 = result[candidate][0]; + priv->rege94 = reg_e94; + reg_e9c = result[candidate][1]; + priv->rege9c = reg_e9c; + reg_ea4 = result[candidate][2]; + reg_eac = result[candidate][3]; + reg_eb4 = result[candidate][4]; + priv->regeb4 = reg_eb4; + reg_ebc = result[candidate][5]; + priv->regebc = reg_ebc; + reg_ec4 = result[candidate][6]; + reg_ecc = result[candidate][7]; + dev_dbg(dev, "%s: candidate is %x\n", __func__, candidate); + dev_dbg(dev, "%s: reg_e94 =%x reg_e9C =%x reg_eA4 =%x " + "reg_eAC =%x reg_eB4 =%x reg_eBC =%x reg_eC4 =%x " + "reg_eCC =%x\n ", __func__, reg_e94, reg_e9c, + reg_ea4, reg_eac, reg_eb4, reg_ebc, reg_ec4, reg_ecc); + path_a_ok = true; +#if 0 + path_b_ok = true; +#endif + } else { + reg_e94 = reg_eb4 = priv->rege94 = priv->regeb4 = 0x100; + reg_e9c = reg_ebc = priv->rege9c = priv->regebc = 0x0; + } + + if (reg_e94 && candidate >= 0) + rtl8xxxu_fill_iqk_matrix_a(priv, path_a_ok, result, + candidate, (reg_ea4 == 0)); + + rtl8xxxu_save_regs(priv, rtl8723au_iqk_phy_iq_bb_reg, + priv->bb_recovery_backup, RTL8XXXU_BB_REGS); +} + +static void rtl8723a_phy_lc_calibrate(struct rtl8xxxu_priv *priv) +{ + u32 val32; + u32 rf_amode, lstf; + + /* Check continuous TX and Packet TX */ + lstf = rtl8723au_read32(priv, REG_OFDM1_LSTF); + + if (lstf & OFDM_LSTF_MASK) { + /* Disable all continuous TX */ + val32 = lstf & ~OFDM_LSTF_MASK; + rtl8723au_write32(priv, REG_OFDM1_LSTF, val32); + + /* Read original RF mode Path A */ + rf_amode = rtl8723au_read_rfreg(priv, RF6052_REG_AC); + +#if 0 + /* Path-B */ + if (is_2t) + rf_bmode = PHY_QueryRFReg(priv, RF_PATH_B, RF_AC, + bMask12Bits); +#endif + + /* Set RF mode to standby Path A */ + rtl8723au_write_rfreg(priv, RF6052_REG_AC, + (rf_amode & 0xfff) | 0x10000); + +#if 0 + /* Path-B */ + if (is_2t) + PHY_SetRFReg(priv, RF_PATH_B, RF_AC, bMask12Bits, + (RF_Bmode & 0x8ffff) | 0x10000); +#endif + } else { + /* Deal with Packet TX case */ + /* block all queues */ + rtl8723au_write8(priv, REG_TXPAUSE, 0xff); + } + + /* Start LC calibration */ + val32 = rtl8723au_read_rfreg(priv, RF6052_REG_MODE_AG); + val32 |= 0x08000; + rtl8723au_write_rfreg(priv, RF6052_REG_MODE_AG, val32); + + msleep(100); + + /* Restore original parameters */ + if (lstf & OFDM_LSTF_MASK) { + /* Path-A */ + rtl8723au_write32(priv, REG_OFDM1_LSTF, lstf); + rtl8723au_write_rfreg(priv, RF6052_REG_AC, rf_amode); + +#if 0 + /* Path-B */ + if (is_2t) + PHY_SetRFReg(priv, RF_PATH_B, RF_AC, bMask12Bits, + RF_Bmode); +#endif + } else /* Deal with Packet TX case */ + rtl8723au_write8(priv, REG_TXPAUSE, 0x00); +} + +static int rtl8xxxu_set_mac(struct rtl8xxxu_priv *priv) +{ + int i; + u16 reg; + + reg = REG_MACID; + + for (i = 0; i < ETH_ALEN; i++) + rtl8723au_write8(priv, reg + i, priv->mac_addr[i]); + + return 0; +} + +static int rtl8xxxu_set_bssid(struct rtl8xxxu_priv *priv, const u8 *bssid) +{ + int i; + u16 reg; + + dev_dbg(&priv->udev->dev, "%s: (%pM)\n", __func__, bssid); + + reg = REG_BSSID; + + for (i = 0; i < ETH_ALEN; i++) + rtl8723au_write8(priv, reg + i, bssid[i]); + + return 0; +} + +static void +rtl8xxxu_set_ampdu_factor(struct rtl8xxxu_priv *priv, u8 ampdu_factor) +{ + u8 vals[4] = { 0x41, 0xa8, 0x72, 0xb9 }; + u8 max_agg = 0xf; + int i; + + ampdu_factor = 1 << (ampdu_factor + 2); + if (ampdu_factor > max_agg) + ampdu_factor = max_agg; + + for (i = 0; i < 4; i++) { + if ((vals[i] & 0xf0) > (ampdu_factor << 4)) + vals[i] = (vals[i] & 0x0f) | (ampdu_factor << 4); + + if ((vals[i] & 0x0f) > ampdu_factor) + vals[i] = (vals[i] & 0xf0) | ampdu_factor; + + rtl8723au_write8(priv, REG_AGGLEN_LMT + i, vals[i]); + } +} + +static void rtl8xxxu_set_ampdu_min_space(struct rtl8xxxu_priv *priv, u8 density) +{ + u8 val8; + + val8 = rtl8723au_read8(priv, REG_AMPDU_MIN_SPACE); + val8 &= 0xf8; + val8 |= density; + rtl8723au_write8(priv, REG_AMPDU_MIN_SPACE, val8); +} + +static int rtl8xxxu_active_to_emu(struct rtl8xxxu_priv *priv) +{ + u8 val8; + int count, ret; + + /* Start of rtl8723AU_card_enable_flow */ + /* Act to Cardemu sequence*/ + /* Turn off RF */ + rtl8723au_write8(priv, REG_RF_CTRL, 0); + + /* 0x004E[7] = 0, switch DPDT_SEL_P output from register 0x0065[2] */ + val8 = rtl8723au_read8(priv, REG_LEDCFG2); + val8 &= ~LEDCFG2_DPDT_SELECT; + rtl8723au_write8(priv, REG_LEDCFG2, val8); + + /* 0x0005[1] = 1 turn off MAC by HW state machine*/ + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 1); + val8 |= BIT(1); + rtl8723au_write8(priv, REG_APS_FSMCO + 1, val8); + + for (count = RTL8XXXU_MAX_REG_POLL; count; count--) { + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 1); + if ((val8 & BIT(1)) == 0) + break; + udelay(10); + } + + if (!count) { + dev_warn(&priv->udev->dev, "%s: Disabling MAC timed out\n", + __func__); + ret = -EBUSY; + goto exit; + } + + /* 0x0000[5] = 1 analog Ips to digital, 1:isolation */ + val8 = rtl8723au_read8(priv, REG_SYS_ISO_CTRL); + val8 |= SYS_ISO_ANALOG_IPS; + rtl8723au_write8(priv, REG_SYS_ISO_CTRL, val8); + + /* 0x0020[0] = 0 disable LDOA12 MACRO block*/ + val8 = rtl8723au_read8(priv, REG_LDOA15_CTRL); + val8 &= ~LDOA15_ENABLE; + rtl8723au_write8(priv, REG_LDOA15_CTRL, val8); + +exit: + return ret; +} + +static int rtl8xxxu_active_to_lps(struct rtl8xxxu_priv *priv) +{ + u8 val8; + u8 val32; + int count, ret; + + rtl8723au_write8(priv, REG_TXPAUSE, 0xff); + + /* + * Poll - wait for RX packet to complete + */ + for (count = RTL8XXXU_MAX_REG_POLL; count; count--) { + val32 = rtl8723au_read8(priv, 0x5f8); + if (!val32) + break; + udelay(10); + } + + if (!count) { + dev_warn(&priv->udev->dev, + "%s: RX poll timed out (0x05f8)\n", __func__); + ret = -EBUSY; + goto exit; + } + + /* Disable CCK and OFDM, clock gated */ + val8 = rtl8723au_read8(priv, REG_SYS_FUNC); + val8 &= ~SYS_FUNC_BBRSTB; + rtl8723au_write8(priv, REG_SYS_FUNC, val8); + + udelay(2); + + /* Reset baseband */ + val8 = rtl8723au_read8(priv, REG_SYS_FUNC); + val8 &= ~SYS_FUNC_BB_GLB_RSTN; + rtl8723au_write8(priv, REG_SYS_FUNC, val8); + + /* Reset MAC TRX */ + val8 = rtl8723au_read8(priv, REG_CR); + val8 = CR_HCI_TXDMA_ENABLE | CR_HCI_RXDMA_ENABLE; + rtl8723au_write8(priv, REG_CR, val8); + + /* Reset MAC TRX */ + val8 = rtl8723au_read8(priv, REG_CR + 1); + val8 &= ~BIT(1); /* CR_SECURITY_ENABLE */ + rtl8723au_write8(priv, REG_CR + 1, val8); + + /* Respond TX OK to scheduler */ + val8 = rtl8723au_read8(priv, REG_DUAL_TSF_RST); + val8 |= BIT(5); + rtl8723au_write8(priv, REG_DUAL_TSF_RST, val8); + +exit: + return ret; +} + +static void rtl8xxxu_disabled_to_emu(struct rtl8xxxu_priv *priv) +{ + u8 val8; + + /* Clear suspend enable and power down enable*/ + val8 = rtl8723au_read8(priv, 0x05); + val8 &= ~(BIT(3) | BIT(7)); + rtl8723au_write8(priv, 0x05, val8); + + /* 0x48[16] = 0 to disable GPIO9 as EXT WAKEUP*/ + val8 = rtl8723au_read8(priv, 0x4a); + val8 &= ~BIT(0); + rtl8723au_write8(priv, 0x4a, val8); + + /* 0x04[12:11] = 11 enable WL suspend*/ + val8 = rtl8723au_read8(priv, 0x05); + val8 &= ~(BIT(3) | BIT(4)); + rtl8723au_write8(priv, 0x05, val8); +} + +static int rtl8xxxu_emu_to_active(struct rtl8xxxu_priv *priv) +{ + u8 val8; + u32 val32; + int count, ret = 0; + + /* 0x20[0] = 1 enable LDOA12 MACRO block for all interface*/ + val8 = rtl8723au_read8(priv, REG_LDOA15_CTRL); + val8 |= LDOA15_ENABLE; + rtl8723au_write8(priv, REG_LDOA15_CTRL, val8); + + /* 0x67[0] = 0 to disable BT_GPS_SEL pins*/ + val8 = rtl8723au_read8(priv, 0x0067); + val8 &= ~BIT(4); + rtl8723au_write8(priv, 0x0067, val8); + + mdelay(1); + + /* 0x00[5] = 0 release analog Ips to digital, 1:isolation */ + val8 = rtl8723au_read8(priv, REG_SYS_ISO_CTRL); + val8 &= ~BIT(5); + rtl8723au_write8(priv, REG_SYS_ISO_CTRL, val8); + + /* disable SW LPS 0x04[10]= 0 */ + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 1); + val8 &= ~BIT(2); + rtl8723au_write8(priv, REG_APS_FSMCO + 1, val8); + + /* wait till 0x04[17] = 1 power ready*/ + for (count = RTL8XXXU_MAX_REG_POLL; count; count--) { + val32 = rtl8723au_read32(priv, REG_APS_FSMCO); + if (val32 & BIT(17)) + break; + + udelay(10); + } + + if (!count) { + ret = -EBUSY; + goto exit; + } + + /* We should be able to optimize the following three entries into one */ + + /* release WLON reset 0x04[16]= 1*/ + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 2); + val8 |= BIT(0); + rtl8723au_write8(priv, REG_APS_FSMCO + 2, val8); + + /* disable HWPDN 0x04[15]= 0*/ + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 1); + val8 &= ~BIT(7); + rtl8723au_write8(priv, REG_APS_FSMCO + 1, val8); + + /* disable WL suspend*/ + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 1); + val8 &= ~(BIT(3) | BIT(4)); + rtl8723au_write8(priv, REG_APS_FSMCO + 1, val8); + + /* set, then poll until 0 */ + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 1); + val8 |= BIT(0); + rtl8723au_write8(priv, REG_APS_FSMCO + 1, val8); + + for (count = RTL8XXXU_MAX_REG_POLL; count; count--) { + val32 = rtl8723au_read32(priv, REG_APS_FSMCO); + if ((val32 & BIT(8)) == 0) { + ret = 0; + break; + } + udelay(10); + } + + if (!count) { + ret = -EBUSY; + goto exit; + } + + /* 0x4C[23] = 0x4E[7] = 1, switch DPDT_SEL_P output from WL BB */ + /* + * Note: Vendor driver actually clears this bit, despite the + * documentation claims it's being set! + */ + val8 = rtl8723au_read8(priv, REG_LEDCFG2); + val8 |= LEDCFG2_DPDT_SELECT; + val8 &= ~LEDCFG2_DPDT_SELECT; + rtl8723au_write8(priv, REG_LEDCFG2, val8); + +exit: + return ret; +} + +static int rtl8xxxu_emu_to_disabled(struct rtl8xxxu_priv *priv) +{ + u8 val8; + + /* 0x0007[7:0] = 0x20 SOP option to disable BG/MB */ + rtl8723au_write8(priv, REG_APS_FSMCO + 3, 0x20); + + /* 0x04[12:11] = 01 enable WL suspend */ + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 1); + val8 &= ~BIT(4); + val8 |= BIT(3); + rtl8723au_write8(priv, REG_APS_FSMCO + 1, val8); + + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 1); + val8 |= BIT(7); + rtl8723au_write8(priv, REG_APS_FSMCO + 1, val8); + + /* 0x48[16] = 1 to enable GPIO9 as EXT wakeup */ + val8 = rtl8723au_read8(priv, REG_GPIO_INTM + 2); + val8 |= BIT(0); + rtl8723au_write8(priv, REG_GPIO_INTM + 2, val8); + + return 0; +} + +static int rtl8xxxu_power_on(struct rtl8xxxu_priv *priv) +{ + u8 val8; + u16 val16; + u32 val32; + int ret; + + /* + * RSV_CTRL 0x001C[7:0] = 0x00, unlock ISO/CLK/Power control register + */ + rtl8723au_write8(priv, REG_RSV_CTRL, 0x0); + + rtl8xxxu_disabled_to_emu(priv); + + ret = rtl8xxxu_emu_to_active(priv); + if (ret) + goto exit; + + /* + * 0x0004[19] = 1, reset 8051 + */ + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 2); + val8 |= BIT(3); + rtl8723au_write8(priv, REG_APS_FSMCO + 2, val8); + + /* + * Enable MAC DMA/WMAC/SCHEDULE/SEC block + * Set CR bit10 to enable 32k calibration. + */ + val16 = rtl8723au_read16(priv, REG_CR); + val16 |= (CR_HCI_TXDMA_ENABLE | CR_HCI_RXDMA_ENABLE | + CR_TXDMA_ENABLE | CR_RXDMA_ENABLE | + CR_PROTOCOL_ENABLE | CR_SCHEDULE_ENABLE | + CR_MAC_TX_ENABLE | CR_MAC_RX_ENABLE | + CR_SECURITY_ENABLE | CR_CALTIMER_ENABLE); + rtl8723au_write16(priv, REG_CR, val16); + + /* For EFuse PG */ + val32 = rtl8723au_read32(priv, REG_EFUSE_CTRL); + val32 &= ~(BIT(28) | BIT(29) | BIT(30)); + val32 |= (0x06 << 28); + rtl8723au_write32(priv, REG_EFUSE_CTRL, val32); +exit: + return ret; +} + +static void rtl8xxxu_power_off(struct rtl8xxxu_priv *priv) +{ + u8 val8; + u16 val16; + + rtl8xxxu_active_to_lps(priv); + + /* Turn off RF */ + rtl8723au_write8(priv, REG_RF_CTRL, 0x00); + + /* Reset Firmware if running in RAM */ + if (rtl8723au_read8(priv, REG_MCU_FW_DL) & MCU_FW_RAM_SEL) + rtl8xxxu_firmware_self_reset(priv); + + /* Reset MCU */ + val16 = rtl8723au_read16(priv, REG_SYS_FUNC); + val16 &= ~SYS_FUNC_CPU_ENABLE; + rtl8723au_write16(priv, REG_SYS_FUNC, val16); + + /* Reset MCU ready status */ + rtl8723au_write8(priv, REG_MCU_FW_DL, 0x00); + + rtl8xxxu_active_to_emu(priv); + rtl8xxxu_emu_to_disabled(priv); + + /* Reset MCU IO Wrapper */ + val8 = rtl8723au_read8(priv, REG_RSV_CTRL + 1); + val8 &= ~BIT(0); + rtl8723au_write8(priv, REG_RSV_CTRL + 1, val8); + + val8 = rtl8723au_read8(priv, REG_RSV_CTRL + 1); + val8 |= BIT(0); + rtl8723au_write8(priv, REG_RSV_CTRL + 1, val8); + + /* RSV_CTRL 0x1C[7:0] = 0x0e lock ISO/CLK/Power control register */ + rtl8723au_write8(priv, REG_RSV_CTRL, 0x0e); +} + +static int rtl8xxxu_init_device(struct ieee80211_hw *hw) +{ + struct rtl8xxxu_priv *priv = hw->priv; + struct device *dev = &priv->udev->dev; + bool macpower; + int ret; + u8 val8; + u16 val16; + u32 val32; + + /* Check if MAC is already powered on */ + val8 = rtl8723au_read8(priv, REG_CR); + + /* + * Fix 92DU-VC S3 hang with the reason is that secondary mac is not + * initialized. First MAC returns 0xea, second MAC returns 0x00 + */ + if (val8 == 0xea) + macpower = false; + else + macpower = true; + + ret = rtl8xxxu_power_on(priv); + if (ret < 0) { + dev_warn(dev, "%s: Failed power on\n", __func__); + goto exit; + } + + dev_dbg(dev, "%s: macpower %i\n", __func__, macpower); + if (!macpower) { + ret = rtl8xxxu_init_llt_table(priv, TX_TOTAL_PAGE_NUM); + if (ret) { + dev_warn(dev, "%s: LLT table init failed\n", __func__); + goto exit; + } + } + + ret = rtl8xxxu_download_firmware(priv); + if (ret) + goto exit; + ret = rtl8xxxu_start_firmware(priv); + if (ret) + goto exit; + + ret = rtl8xxxu_init_mac(priv, rtl8723a_mac_init_table); + if (ret) + goto exit; + + ret = rtl8xxxu_init_phy_bb(priv); + if (ret) + goto exit; + + ret = rtl8xxxu_init_phy_rf(priv); + if (ret) + goto exit; + + /* Reduce 80M spur */ + rtl8723au_write32(priv, REG_AFE_XTAL_CTRL, 0x0381808d); + rtl8723au_write32(priv, REG_AFE_PLL_CTRL, 0xf0ffff83); + rtl8723au_write32(priv, REG_AFE_PLL_CTRL, 0xf0ffff82); + rtl8723au_write32(priv, REG_AFE_PLL_CTRL, 0xf0ffff83); + + /* RFSW Control - clear bit 14 ?? */ + rtl8723au_write32(priv, REG_FPGA0_TXINFO, 0x00000003); + /* 0x07000760 */ + val32 = FPGA0_RF_TRSW | FPGA0_RF_TRSWB | FPGA0_RF_ANTSW | + FPGA0_RF_ANTSWB | FPGA0_RF_PAPE | + ((FPGA0_RF_ANTSW | FPGA0_RF_ANTSWB | FPGA0_RF_PAPE) << + FPGA0_RF_BD_CTRL_SHIFT); + rtl8723au_write32(priv, REG_FPGA0_XAB_RF_SW_CTRL, val32); + /* 0x860[6:5]= 00 - why? - this sets antenna B */ + rtl8723au_write32(priv, REG_FPGA0_XA_RF_INT_OE, 0x66F60210); + + priv->rf_mode_ag[0] = rtl8723au_read_rfreg(priv, RF6052_REG_MODE_AG); + + if (!macpower) { + if (priv->ep_tx_normal_queue) + val8 = TX_PAGE_NUM_NORM_PQ; + else + val8 = 0; + + rtl8723au_write8(priv, REG_RQPN_NPQ, val8); + + val32 = (TX_PAGE_NUM_PUBQ << RQPN_NORM_PQ_SHIFT) | RQPN_LOAD; + + if (priv->ep_tx_high_queue) + val32 |= (TX_PAGE_NUM_HI_PQ << RQPN_HI_PQ_SHIFT); + if (priv->ep_tx_low_queue) + val32 |= (TX_PAGE_NUM_LO_PQ << RQPN_LO_PQ_SHIFT); + + rtl8723au_write32(priv, REG_RQPN, val32); + + /* + * Set TX buffer boundary + */ + val8 = TX_TOTAL_PAGE_NUM + 1; + rtl8723au_write8(priv, REG_TXPKTBUF_BCNQ_BDNY, val8); + rtl8723au_write8(priv, REG_TXPKTBUF_MGQ_BDNY, val8); + rtl8723au_write8(priv, REG_TXPKTBUF_WMAC_LBK_BF_HD, val8); + rtl8723au_write8(priv, REG_TRXFF_BNDY, val8); + rtl8723au_write8(priv, REG_TDECTRL + 1, val8); + } + + ret = rtl8xxxu_init_queue_priority(priv); + if (ret) + goto exit; + + /* + * Set RX page boundary + */ + rtl8723au_write16(priv, REG_TRXFF_BNDY + 2, 0x27ff); + /* + * Transfer page size is always 128 + */ + val8 = (PBP_PAGE_SIZE_128 << PBP_PAGE_SIZE_RX_SHIFT) | + (PBP_PAGE_SIZE_128 << PBP_PAGE_SIZE_TX_SHIFT); + rtl8723au_write8(priv, REG_PBP, val8); + + /* + * Unit in 8 bytes, not obvious what it is used for + */ + rtl8723au_write8(priv, REG_RX_DRVINFO_SZ, 4); + + /* + * Enable all interrupts - not obvious USB needs to do this + */ + rtl8723au_write32(priv, REG_HISR, 0xffffffff); + rtl8723au_write32(priv, REG_HIMR, 0xffffffff); + + rtl8xxxu_set_mac(priv); + rtl8xxxu_set_linktype(priv, NL80211_IFTYPE_STATION); + + /* + * Configure initial WMAC settings + */ + val32 = RCR_ACCEPT_PHYS_MATCH | RCR_ACCEPT_MCAST | RCR_ACCEPT_BCAST | + /* RCR_CHECK_BSSID_MATCH | RCR_CHECK_BSSID_BEACON | */ + RCR_ACCEPT_MGMT_FRAME | RCR_HTC_LOC_CTRL | + RCR_APPEND_PHYSTAT | RCR_APPEND_ICV | RCR_APPEND_MIC; + rtl8723au_write32(priv, REG_RCR, val32); + + /* + * Accept all multicast + */ + rtl8723au_write32(priv, REG_MAR, 0xffffffff); + rtl8723au_write32(priv, REG_MAR + 4, 0xffffffff); + + /* + * Init adaptive controls + */ + val32 = rtl8723au_read32(priv, REG_RESPONSE_RATE_SET); + val32 &= ~RESPONSE_RATE_BITMAP_ALL; + val32 |= RESPONSE_RATE_RRSR_CCK_ONLY_1M; + rtl8723au_write32(priv, REG_RESPONSE_RATE_SET, val32); + + /* CCK = 0x0a, OFDM = 0x10 */ +#if 0 + rtl8xxxu_set_spec_sifs(priv, 0x0a, 0x10); +#else + rtl8xxxu_set_spec_sifs(priv, 0x10, 0x10); +#endif + rtl8xxxu_set_retry(priv, 0x30, 0x30); + rtl8xxxu_set_spec_sifs(priv, 0x0a, 0x10); + + /* + * Init EDCA + */ + rtl8723au_write16(priv, REG_MAC_SPEC_SIFS, 0x100a); + + /* Set CCK SIFS */ + rtl8723au_write16(priv, REG_SIFS_CCK, 0x100a); + + /* Set OFDM SIFS */ + rtl8723au_write16(priv, REG_SIFS_OFDM, 0x100a); + + /* TXOP */ + rtl8723au_write32(priv, REG_EDCA_BE_PARAM, 0x005ea42b); + rtl8723au_write32(priv, REG_EDCA_BK_PARAM, 0x0000a44f); + rtl8723au_write32(priv, REG_EDCA_VI_PARAM, 0x005ea324); + rtl8723au_write32(priv, REG_EDCA_VO_PARAM, 0x002fa226); + + /* Set data auto rate fallback retry count */ + rtl8723au_write32(priv, REG_DARFRC, 0x00000000); + rtl8723au_write32(priv, REG_DARFRC + 4, 0x10080404); + rtl8723au_write32(priv, REG_RARFRC, 0x04030201); + rtl8723au_write32(priv, REG_RARFRC + 4, 0x08070605); + + val8 = rtl8723au_read8(priv, REG_FWHW_TXQ_CTRL); + val8 |= FWHW_TXQ_CTRL_AMPDU_RETRY; + rtl8723au_write8(priv, REG_FWHW_TXQ_CTRL, val8); + + /* Set ACK timeout */ + rtl8723au_write8(priv, REG_ACKTO, 0x40); + + /* + * Initialize beacon parameters + */ + val16 = BEACON_DISABLE_TSF_UPDATE | (BEACON_DISABLE_TSF_UPDATE << 8); + rtl8723au_write16(priv, REG_BEACON_CTRL, val16); + rtl8723au_write16(priv, REG_TBTT_PROHIBIT, 0x6404); + rtl8723au_write8(priv, REG_DRIVER_EARLY_INT, DRIVER_EARLY_INT_TIME); + rtl8723au_write8(priv, REG_BEACON_DMA_TIME, BEACON_DMA_ATIME_INT_TIME); + rtl8723au_write16(priv, REG_BEACON_TCFG, 0x660F); + + /* + * Enable CCK and OFDM block + */ + val32 = rtl8723au_read32(priv, REG_FPGA0_RF_MODE); + val32 |= (FPGA_RF_MODE_CCK | FPGA_RF_MODE_OFDM); + rtl8723au_write32(priv, REG_FPGA0_RF_MODE, val32); + + /* + * Invalidate all CAM entries - bit 30 is undocumented + */ + rtl8723au_write32(priv, REG_CAM_CMD, CAM_CMD_POLLING | BIT(30)); + + /* + * Start out with default power levels for channel 6, 20MHz + */ + rtl8723a_set_tx_power(priv, 1, false); + + /* Let the 8051 take control of antenna setting */ + val8 = rtl8723au_read8(priv, REG_LEDCFG2); + val8 |= LEDCFG2_DPDT_SELECT; + rtl8723au_write8(priv, REG_LEDCFG2, val8); + + rtl8723au_write8(priv, REG_HWSEQ_CTRL, 0xff); + + /* Disable BAR - not sure if this has any effect on USB */ + rtl8723au_write32(priv, REG_BAR_MODE_CTRL, 0x0201ffff); + +#if 0 + if (priv->wifi_spec) + rtl8723au_write16(priv, REG_FAST_EDCA_CTRL, 0); +#endif + rtl8723au_write16(priv, REG_FAST_EDCA_CTRL, 0); + +#if 0 + /* + * From 8192cu driver + */ + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_RF_INT_OE); + val32 &= ~BIT(6); + val32 |= BIT(5); + rtl8723au_write32(priv, REG_FPGA0_XA_RF_INT_OE, val32); +#endif + + /* + * Not sure if we should get into this at all + */ + if (priv->iqk_initialized) { + rtl8xxxu_restore_regs(priv, rtl8723au_iqk_phy_iq_bb_reg, + priv->bb_recovery_backup, + RTL8XXXU_BB_REGS); + } else { + rtl8723a_phy_iq_calibrate(priv); + priv->iqk_initialized = true; + } + + /* + * This should enable thermal meter + */ + rtl8723au_write_rfreg(priv, RF6052_REG_T_METER, 0x60); + + rtl8723a_phy_lc_calibrate(priv); + + /* fix USB interface interference issue */ + rtl8723au_write8(priv, 0xfe40, 0xe0); + rtl8723au_write8(priv, 0xfe41, 0x8d); + rtl8723au_write8(priv, 0xfe42, 0x80); + rtl8723au_write32(priv, REG_TXDMA_OFFSET_CHK, 0xfd0320); + + /* Solve too many protocol error on USB bus */ + /* Can't do this for 8188/8192 UMC A cut parts */ + rtl8723au_write8(priv, 0xfe40, 0xe6); + rtl8723au_write8(priv, 0xfe41, 0x94); + rtl8723au_write8(priv, 0xfe42, 0x80); + + rtl8723au_write8(priv, 0xfe40, 0xe0); + rtl8723au_write8(priv, 0xfe41, 0x19); + rtl8723au_write8(priv, 0xfe42, 0x80); + + rtl8723au_write8(priv, 0xfe40, 0xe5); + rtl8723au_write8(priv, 0xfe41, 0x91); + rtl8723au_write8(priv, 0xfe42, 0x80); + + rtl8723au_write8(priv, 0xfe40, 0xe2); + rtl8723au_write8(priv, 0xfe41, 0x81); + rtl8723au_write8(priv, 0xfe42, 0x80); + +#if 0 + /* Init BT hw config. */ + rtl8723a_init_bt(priv); +#endif + + /* + * Not sure if we really need to save these parameters, but the + * vendor driver does + */ + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_HSSI_PARM2); + if (val32 & FPGA0_HSSI_PARM2_CCK_HIGH_PWR) + priv->path_a_hi_power = 1; + + val32 = rtl8723au_read32(priv, REG_OFDM0_TRX_PATH_ENABLE); + priv->path_a_rf_paths = val32 & OFDM0_RF_PATH_RX_MASK; + + val32 = rtl8723au_read32(priv, REG_OFDM0_XA_AGC_CORE1); + priv->path_a_ig_value = val32 & OFDM0_X_AGC_CORE1_IGI_MASK; + + /* Set NAV_UPPER to 30000us */ + val8 = ((30000 + NAV_UPPER_UNIT - 1) / NAV_UPPER_UNIT); + rtl8723au_write8(priv, REG_NAV_UPPER, val8); + + /* + * 2011/03/09 MH debug only, UMC-B cut pass 2500 S5 test, + * but we need to fin root cause. + */ + val32 = rtl8723au_read32(priv, REG_FPGA0_RF_MODE); + if ((val32 & 0xff000000) != 0x83000000) { + val32 |= FPGA_RF_MODE_CCK; + rtl8723au_write32(priv, REG_FPGA0_RF_MODE, val32); + } + + val32 = rtl8723au_read32(priv, REG_FWHW_TXQ_CTRL); + val32 |= FWHW_TXQ_CTRL_XMIT_MGMT_ACK; + /* ack for xmit mgmt frames. */ + rtl8723au_write32(priv, REG_FWHW_TXQ_CTRL, val32); + +exit: + return ret; +} + +static void rtl8xxxu_disable_device(struct ieee80211_hw *hw) +{ + struct rtl8xxxu_priv *priv = hw->priv; + + rtl8xxxu_power_off(priv); +} + +static void rtl8xxxu_cam_write(struct rtl8xxxu_priv *priv, + struct ieee80211_key_conf *key, const u8 *mac) +{ + u32 cmd, val32, addr, ctrl; + int j, i, tmp_debug; + + tmp_debug = rtl8xxxu_debug; + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_KEY) + rtl8xxxu_debug |= RTL8XXXU_DEBUG_REG_WRITE; + + addr = key->keyidx << CAM_CMD_KEY_SHIFT; + ctrl = (key->cipher & 0x0f) << 2 | key->keyidx | CAM_WRITE_VALID; + + for (j = 5; j >= 0; j--) { + switch (j) { + case 0: + val32 = ctrl | (mac[0] << 16) | (mac[1] << 24); + break; + case 1: + val32 = mac[2] | (mac[3] << 8) | + (mac[4] << 16) | (mac[5] << 24); + break; + default: + i = (j - 2) << 2; + val32 = key->key[i] | (key->key[i + 1] << 8) | + key->key[i + 2] << 16 | key->key[i + 3] << 24; + break; + } + + rtl8723au_write32(priv, REG_CAM_WRITE, val32); + cmd = CAM_CMD_POLLING | CAM_CMD_WRITE | (addr + j); + rtl8723au_write32(priv, REG_CAM_CMD, cmd); + udelay(100); + } + + rtl8xxxu_debug = tmp_debug; +} + +static void rtl8xxxu_sw_scan_start(struct ieee80211_hw *hw, + struct ieee80211_vif *vif, const u8 *mac) +{ +#if 0 + struct rtl8xxxu_priv *priv = hw->priv; + u32 val32; + + val32 = rtl8723au_read32(priv, REG_RCR); + val32 &= ~(RCR_CHECK_BSSID_MATCH | RCR_CHECK_BSSID_BEACON); + rtl8723au_write32(priv, REG_RCR, val32); + + rtl8723au_write8(priv, REG_BEACON_CTRL, BEACON_ATIM | + BEACON_FUNCTION_ENABLE | BEACON_DISABLE_TSF_UPDATE); + + dev_dbg(&priv->udev->dev, "%s\n", __func__); +#endif +} + +static void rtl8xxxu_sw_scan_complete(struct ieee80211_hw *hw, + struct ieee80211_vif *vif) +{ + struct rtl8xxxu_priv *priv = hw->priv; + u8 val8; + +#if 0 + dev_dbg(&priv->udev->dev, "%s\n", __func__); +#endif + + val8 = rtl8723au_read8(priv, REG_BEACON_CTRL); + val8 &= ~BEACON_DISABLE_TSF_UPDATE; + rtl8723au_write8(priv, REG_BEACON_CTRL, val8); +} + +static void rtl8xxxu_update_rate_mask(struct rtl8xxxu_priv *priv, + struct ieee80211_sta *sta) +{ + struct h2c_cmd h2c; + u32 ramask; + + /* TODO: Set bits 28-31 for rate adaptive id */ + ramask = (sta->supp_rates[0] & 0xfff) | + sta->ht_cap.mcs.rx_mask[0] << 12 | + sta->ht_cap.mcs.rx_mask[1] << 20; + + h2c.ramask.cmd = H2C_SET_RATE_MASK; + h2c.ramask.mask_lo = cpu_to_le16(ramask & 0xffff); + h2c.ramask.mask_hi = cpu_to_le16(ramask >> 16); + + h2c.ramask.arg = 0x80; + if (sta->ht_cap.cap & + (IEEE80211_HT_CAP_SGI_40 | IEEE80211_HT_CAP_SGI_20)) { + h2c.ramask.arg |= 0x20; + priv->use_shortgi = true; + } else { + priv->use_shortgi = false; + } + + dev_dbg(&priv->udev->dev, "%s: rate mask %08x, arg %02x\n", __func__, + ramask, h2c.ramask.arg); + rtl8723a_h2c_cmd(priv, &h2c); +} + +static void rtl8xxxu_set_basic_rates(struct rtl8xxxu_priv *priv, u32 rate_cfg) +{ + u32 val32; + u8 rate_idx = 0; + + rate_cfg &= RESPONSE_RATE_BITMAP_ALL; + + val32 = rtl8723au_read32(priv, REG_RESPONSE_RATE_SET); + val32 &= ~RESPONSE_RATE_BITMAP_ALL; + val32 |= rate_cfg; + rtl8723au_write32(priv, REG_RESPONSE_RATE_SET, val32); + + dev_dbg(&priv->udev->dev, "%s: rates %08x\n", __func__, rate_cfg); + + while (rate_cfg) { + rate_cfg = (rate_cfg >> 1); + rate_idx++; + } + rtl8723au_write8(priv, REG_INIRTS_RATE_SEL, rate_idx); +} + +static void +rtl8xxxu_bss_info_changed(struct ieee80211_hw *hw, struct ieee80211_vif *vif, + struct ieee80211_bss_conf *bss_conf, u32 changed) +{ + struct rtl8xxxu_priv *priv = hw->priv; + struct device *dev = &priv->udev->dev; + struct ieee80211_sta *sta; + u32 val32; +#if 0 + u16 val16; +#endif + u8 val8; + + if (changed & BSS_CHANGED_ASSOC) { + struct h2c_cmd h2c; + + dev_dbg(dev, "Changed ASSOC: %i!\n", bss_conf->assoc); + + memset(&h2c, 0, sizeof(struct h2c_cmd)); + rtl8xxxu_set_linktype(priv, vif->type); + + if (bss_conf->assoc) { + rcu_read_lock(); + sta = ieee80211_find_sta(vif, bss_conf->bssid); + if (!sta) { + dev_info(dev, "%s: ASSOC no sta found\n", + __func__); + rcu_read_unlock(); + goto error; + } + + if (sta->ht_cap.ht_supported) + dev_info(dev, "%s: HT supported\n", __func__); + if (sta->vht_cap.vht_supported) + dev_info(dev, "%s: VHT supported\n", __func__); + rtl8xxxu_update_rate_mask(priv, sta); + rcu_read_unlock(); + + val32 = rtl8723au_read32(priv, REG_RCR); + val32 |= RCR_CHECK_BSSID_MATCH | RCR_CHECK_BSSID_BEACON; + rtl8723au_write32(priv, REG_RCR, val32); + + /* Enable RX of data frames */ + rtl8723au_write16(priv, REG_RXFLTMAP2, 0xffff); + + rtl8723au_write8(priv, REG_BCN_MAX_ERR, 0xff); + + rtl8723a_stop_tx_beacon(priv); + + /* joinbss sequence */ + rtl8723au_write16(priv, REG_BCN_PSR_RPT, + 0xc000 | bss_conf->aid); + +#if 0 + val16 = rtl8723au_read16(priv, REG_CR); + val16 |= CR_SW_BEACON_ENABLE; + rtl8723au_read16(priv, REG_CR, val16); + + val8 = rtl8723au_read8(priv, REG_BEACON_CTRL); + val8 &= ~BEACON_FUNCTION_ENABLE; + val8 |= BEACON_DISABLE_TSF_UPDATE; + rtl8723au_write8(priv, REG_BEACON_CTRL, val8); + + val8 = rtl8723au_read8(priv, REG_FWHW_TXQ_CTRL + 2); + if (val8 & BIT(6)) + recover = true; + + val8 &= ~BIT(6); + rtl8723au_write8(priv, REG_FWHW_TXQ_CTRL + 2, val8); + + /* build fake beacon */ + + val8 = rtl8723au_read8(priv, REG_BEACON_CTRL); + val8 |= BEACON_FUNCTION_ENABLE; + val8 &= ~BEACON_DISABLE_TSF_UPDATE; + rtl8723au_write8(priv, REG_BEACON_CTRL, val8); + + if (recover) { + val8 = rtl8723au_read8(priv, + REG_FWHW_TXQ_CTRL + 2); + val8 |= BIT(6); + rtl8723au_write8(priv, REG_FWHW_TXQ_CTRL + 2, + val8); + } + val16 = rtl8723au_read16(priv, REG_CR); + val16 &= ~CR_SW_BEACON_ENABLE; + rtl8723au_read16(priv, REG_CR, val16); +#endif + h2c.joinbss.data = H2C_JOIN_BSS_CONNECT; + } else { + val32 = rtl8723au_read32(priv, REG_RCR); + val32 &= ~(RCR_CHECK_BSSID_MATCH | + RCR_CHECK_BSSID_BEACON); + rtl8723au_write32(priv, REG_RCR, val32); + + val8 = rtl8723au_read8(priv, REG_BEACON_CTRL); + val8 |= BEACON_DISABLE_TSF_UPDATE; + rtl8723au_write8(priv, REG_BEACON_CTRL, val8); + + /* Disable RX of data frames */ + rtl8723au_write16(priv, REG_RXFLTMAP2, 0x0000); + h2c.joinbss.data = H2C_JOIN_BSS_DISCONNECT; + } + h2c.joinbss.cmd = H2C_JOIN_BSS_REPORT; + rtl8723a_h2c_cmd(priv, &h2c); + } + + if (changed & BSS_CHANGED_ERP_PREAMBLE) { + dev_dbg(dev, "Changed ERP_PREAMBLE: Use short preamble %02x\n", + bss_conf->use_short_preamble); + val32 = rtl8723au_read32(priv, REG_RESPONSE_RATE_SET); + if (bss_conf->use_short_preamble) + val32 |= RSR_ACK_SHORT_PREAMBLE; + else + val32 &= ~RSR_ACK_SHORT_PREAMBLE; + rtl8723au_write32(priv, REG_RESPONSE_RATE_SET, val32); + } + + if (changed & BSS_CHANGED_ERP_SLOT) { + dev_dbg(dev, "Changed ERP_SLOT: short_slot_time %i\n", + bss_conf->use_short_slot); + + if (bss_conf->use_short_slot) + val8 = 9; + else + val8 = 20; + rtl8723au_write8(priv, REG_SLOT, val8); + } + + if (changed & BSS_CHANGED_BSSID) { + dev_dbg(dev, "Changed BSSID!\n"); + rtl8xxxu_set_bssid(priv, bss_conf->bssid); + } + + if (changed & BSS_CHANGED_BASIC_RATES) { + dev_dbg(dev, "Changed BASIC_RATES!\n"); + rtl8xxxu_set_basic_rates(priv, bss_conf->basic_rates); + } +error: + return; +} + +static u32 rtl8xxxu_80211_to_rtl_queue(u32 queue) +{ + u32 rtlqueue; + + switch (queue) { + case IEEE80211_AC_VO: + rtlqueue = TXDESC_QUEUE_VO; + break; + case IEEE80211_AC_VI: + rtlqueue = TXDESC_QUEUE_VI; + break; + case IEEE80211_AC_BE: + rtlqueue = TXDESC_QUEUE_BE; + break; + case IEEE80211_AC_BK: + rtlqueue = TXDESC_QUEUE_BK; + break; + default: + rtlqueue = TXDESC_QUEUE_BE; + } + + return rtlqueue; +} + +static u32 rtl8xxxu_queue_select(struct ieee80211_hw *hw, struct sk_buff *skb) +{ + struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data; + u32 queue; + + if (ieee80211_is_mgmt(hdr->frame_control)) + queue = TXDESC_QUEUE_MGNT; + else + queue = rtl8xxxu_80211_to_rtl_queue(skb_get_queue_mapping(skb)); + + return queue; +} + +static void rtl8xxxu_calc_tx_desc_csum(struct rtl8xxxu_tx_desc *tx_desc) +{ + u16 *ptr = (u16 *)tx_desc; + u16 csum = 0; + int i; + + /* + * Clear csum field before calculation, as the csum field is + * in the middle of the struct. + */ + tx_desc->csum = cpu_to_le16(0); + + for (i = 0; i < (sizeof(struct rtl8xxxu_tx_desc) / sizeof(u16)); i++) + csum = csum ^ le16_to_cpu(ptr[i]); + + tx_desc->csum |= cpu_to_le16(csum); +} + +static void rtl8xxxu_tx_complete(struct urb *urb) +{ + struct sk_buff *skb = (struct sk_buff *)urb->context; + struct ieee80211_tx_info *tx_info; + struct ieee80211_hw *hw; + + tx_info = IEEE80211_SKB_CB(skb); + hw = tx_info->rate_driver_data[0]; + + skb_pull(skb, sizeof(struct rtl8xxxu_tx_desc)); + + ieee80211_tx_info_clear_status(tx_info); + tx_info->status.rates[0].idx = -1; + tx_info->status.rates[0].count = 0; + +#if 0 + /* + * Until we figure out how to obtain the info, + * do not fool the stack. + */ + tx_info->flags |= IEEE80211_TX_STAT_ACK; +#endif + + ieee80211_tx_status_irqsafe(hw, skb); + + usb_free_urb(urb); +} + +static void rtl8xxxu_dump_action(struct device *dev, + struct ieee80211_hdr *hdr) +{ + struct ieee80211_mgmt *mgmt = (struct ieee80211_mgmt *)hdr; + u16 cap, timeout; + + if (!(rtl8xxxu_debug & RTL8XXXU_DEBUG_ACTION)) + return; + + switch (mgmt->u.action.u.addba_resp.action_code) { + case WLAN_ACTION_ADDBA_RESP: + cap = le16_to_cpu(mgmt->u.action.u.addba_resp.capab); + timeout = le16_to_cpu(mgmt->u.action.u.addba_resp.timeout); + dev_info(dev, "WLAN_ACTION_ADDBA_RESP: " + "timeout %i, tid %02x, buf_size %02x, policy %02x, " + "status %02x\n", + timeout, + (cap & IEEE80211_ADDBA_PARAM_TID_MASK) >> 2, + (cap & IEEE80211_ADDBA_PARAM_BUF_SIZE_MASK) >> 6, + (cap >> 1) & 0x1, + le16_to_cpu(mgmt->u.action.u.addba_resp.status)); + break; + case WLAN_ACTION_ADDBA_REQ: + cap = le16_to_cpu(mgmt->u.action.u.addba_req.capab); + timeout = le16_to_cpu(mgmt->u.action.u.addba_req.timeout); + dev_info(dev, "WLAN_ACTION_ADDBA_REQ: " + "timeout %i, tid %02x, buf_size %02x, policy %02x\n", + timeout, + (cap & IEEE80211_ADDBA_PARAM_TID_MASK) >> 2, + (cap & IEEE80211_ADDBA_PARAM_BUF_SIZE_MASK) >> 6, + (cap >> 1) & 0x1); + break; + default: + dev_info(dev, "action frame %02x\n", + mgmt->u.action.u.addba_resp.action_code); + break; + } +} + +static void rtl8xxxu_tx(struct ieee80211_hw *hw, + struct ieee80211_tx_control *control, + struct sk_buff *skb) +{ + struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data; + struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(skb); + struct ieee80211_rate *tx_rate = ieee80211_get_tx_rate(hw, tx_info); + struct rtl8xxxu_priv *priv = hw->priv; + struct rtl8xxxu_tx_desc *tx_desc; + struct device *dev = &priv->udev->dev; + struct urb *urb; + u32 queue, rate; + u16 pktlen = skb->len; + u16 seq_number; + u16 rate_flag = tx_info->control.rates[0].flags; + int ret; + + if (skb_headroom(skb) < sizeof(struct rtl8xxxu_tx_desc)) { + dev_warn(dev, + "%s: Not enough headroom (%i) for tx descriptor\n", + __func__, skb_headroom(skb)); + goto error; + } + + if (unlikely(skb->len > (65535 - sizeof(struct rtl8xxxu_tx_desc)))) { + dev_warn(dev, "%s: Trying to send over-sized skb (%i)\n", + __func__, skb->len); + goto error; + } + + urb = usb_alloc_urb(0, GFP_KERNEL); + if (!urb) { + dev_warn(dev, "%s: Unable to allocate urb\n", __func__); + goto error; + } + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_TX) + dev_info(dev, "%s: TX rate: %d (%d), pkt size %d\n", + __func__, tx_rate->bitrate, tx_rate->hw_value, pktlen); + + if (ieee80211_is_action(hdr->frame_control)) + rtl8xxxu_dump_action(dev, hdr); + + tx_info->rate_driver_data[0] = hw; + + tx_desc = (struct rtl8xxxu_tx_desc *) + skb_push(skb, sizeof(struct rtl8xxxu_tx_desc)); + + memset(tx_desc, 0, sizeof(struct rtl8xxxu_tx_desc)); + tx_desc->pkt_size = cpu_to_le16(pktlen); + tx_desc->pkt_offset = sizeof(struct rtl8xxxu_tx_desc); + + tx_desc->txdw0 = TXDESC_OWN | TXDESC_FSG | TXDESC_LSG; + if (is_multicast_ether_addr(ieee80211_get_DA(hdr)) || + is_broadcast_ether_addr(ieee80211_get_DA(hdr))) + tx_desc->txdw0 |= TXDESC_BROADMULTICAST; + + queue = rtl8xxxu_queue_select(hw, skb); + tx_desc->txdw1 = cpu_to_le32(queue << TXDESC_QUEUE_SHIFT); + + if (tx_info->control.hw_key) { + switch (tx_info->control.hw_key->cipher) { + case WLAN_CIPHER_SUITE_WEP40: + case WLAN_CIPHER_SUITE_WEP104: + case WLAN_CIPHER_SUITE_TKIP: + tx_desc->txdw1 |= cpu_to_le32(TXDESC_SEC_RC4); + break; + case WLAN_CIPHER_SUITE_CCMP: + tx_desc->txdw1 |= cpu_to_le32(TXDESC_SEC_AES); + break; + default: + break; + } + } + + seq_number = IEEE80211_SEQ_TO_SN(le16_to_cpu(hdr->seq_ctrl)); + tx_desc->txdw3 = cpu_to_le32((u32)seq_number << TXDESC_SEQ_SHIFT); + + if (rate_flag & IEEE80211_TX_RC_MCS) + rate = tx_info->control.rates[0].idx + DESC_RATE_MCS0; + else + rate = tx_rate->hw_value; + tx_desc->txdw5 = cpu_to_le32(rate); + + if (ieee80211_is_data(hdr->frame_control)) { + tx_desc->txdw5 |= cpu_to_le32(0x0001ff00); + + if (/* (tx_info->flags & IEEE80211_TX_CTL_AMPDU) && */ + control && control->sta && + control->sta->ht_cap.ht_supported) { + u8 ampdu = control->sta->ht_cap.ampdu_density; + + tx_desc->txdw2 |= + cpu_to_le32(ampdu << TXDESC_AMPDU_DENSITY_SHIFT); + tx_desc->txdw1 |= cpu_to_le32(TXDESC_AGG_ENABLE); + } else + tx_desc->txdw1 |= cpu_to_le32(TXDESC_BK); + } else + tx_desc->txdw1 |= cpu_to_le32(TXDESC_BK); + + if (ieee80211_is_data_qos(hdr->frame_control)) + tx_desc->txdw4 |= cpu_to_le32(TXDESC_QOS); + if (rate_flag & IEEE80211_TX_RC_USE_SHORT_PREAMBLE) + tx_desc->txdw4 |= cpu_to_le32(TXDESC_SHORT_PREAMBLE); + if (rate_flag & IEEE80211_TX_RC_SHORT_GI || priv->use_shortgi) + tx_desc->txdw5 |= cpu_to_le32(TXDESC_SHORT_GI); + if (ieee80211_is_mgmt(hdr->frame_control)) { + tx_desc->txdw5 = cpu_to_le32(tx_rate->hw_value); + tx_desc->txdw4 |= cpu_to_le32(TXDESC_USE_DRIVER_RATE); + tx_desc->txdw5 |= cpu_to_le32(6 << TXDESC_RETRY_LIMIT_SHIFT); + tx_desc->txdw5 |= cpu_to_le32(TXDESC_RETRY_LIMIT_ENABLE); + } + + if (rate_flag & IEEE80211_TX_RC_USE_RTS_CTS) { + /* Use RTS rate 24M - does the mac80211 tell us which to use? */ + tx_desc->txdw4 |= cpu_to_le32(DESC_RATE_24M); + tx_desc->txdw4 |= cpu_to_le32(TXDESC_RTS_CTS_ENABLE); + tx_desc->txdw4 |= cpu_to_le32(TXDESC_HW_RTS_ENABLE); + } + + rtl8xxxu_calc_tx_desc_csum(tx_desc); + + usb_fill_bulk_urb(urb, priv->udev, priv->pipe_out[queue], skb->data, + skb->len, rtl8xxxu_tx_complete, skb); + + usb_anchor_urb(urb, &priv->tx_anchor); + ret = usb_submit_urb(urb, GFP_KERNEL); + if (ret) { + usb_unanchor_urb(urb); + goto error; + } + return; +error: + dev_kfree_skb(skb); +} + +static void rtl8xxxu_rx_complete(struct urb *urb) +{ + struct rtl8xxxu_rx_urb *rx_urb = + container_of(urb, struct rtl8xxxu_rx_urb, urb); + struct ieee80211_hw *hw = rx_urb->hw; + struct rtl8xxxu_priv *priv = hw->priv; + struct sk_buff *skb = (struct sk_buff *)urb->context; + struct rtl8xxxu_rx_desc *rx_desc = (struct rtl8xxxu_rx_desc *)skb->data; + struct rtl8723au_phy_stats *phy_stats; + struct ieee80211_rx_status *rx_status = IEEE80211_SKB_RXCB(skb); + struct ieee80211_mgmt *mgmt; + struct device *dev = &priv->udev->dev; + __le32 *_rx_desc_le = (__le32 *)skb->data; + u32 *_rx_desc = (u32 *)skb->data; + int cnt, len, drvinfo_sz, desc_shift, i, ret; + + for (i = 0; i < (sizeof(struct rtl8xxxu_rx_desc) / sizeof(u32)); i++) + _rx_desc[i] = le32_to_cpu(_rx_desc_le[i]); + + cnt = rx_desc->frag; + len = rx_desc->pktlen; + drvinfo_sz = rx_desc->drvinfo_sz * 8; + desc_shift = rx_desc->shift; + skb_put(skb, urb->actual_length); + + if (urb->status == 0) { + skb_pull(skb, sizeof(struct rtl8xxxu_rx_desc)); + phy_stats = (struct rtl8723au_phy_stats *)skb->data; + + skb_pull(skb, drvinfo_sz + desc_shift); + + mgmt = (struct ieee80211_mgmt *)skb->data; + + memset(rx_status, 0, sizeof(struct ieee80211_rx_status)); + + /* + * Note this is valid for CCK rates only - FIXME + */ + if (rx_desc->phy_stats) { + u8 cck_agc_rpt = phy_stats->cck_agc_rpt_ofdm_cfosho_a; + + switch (cck_agc_rpt & 0xc0) { + case 0xc0: + rx_status->signal = -46 - (cck_agc_rpt & 0x3e); + break; + case 0x80: + rx_status->signal = -26 - (cck_agc_rpt & 0x3e); + break; + case 0x40: + rx_status->signal = -12 - (cck_agc_rpt & 0x3e); + break; + case 0x00: + rx_status->signal = 16 - (cck_agc_rpt & 0x3e); + break; + } + } + + rx_status->freq = hw->conf.chandef.chan->center_freq; + rx_status->band = hw->conf.chandef.chan->band; + + if (!rx_desc->swdec) + rx_status->flag |= RX_FLAG_DECRYPTED; + if (rx_desc->crc32) + rx_status->flag |= RX_FLAG_FAILED_FCS_CRC; + if (rx_desc->bw) + rx_status->flag |= RX_FLAG_40MHZ; + + if (rx_desc->rxht) { + rx_status->flag |= RX_FLAG_HT; + rx_status->rate_idx = rx_desc->rxmcs - DESC_RATE_MCS0; + } else { + rx_status->rate_idx = rx_desc->rxmcs; + } + + ieee80211_rx_irqsafe(hw, skb); + skb = NULL; + ret = rtl8xxxu_submit_rx_urb(priv, rx_urb); + if (ret) { + dev_warn(dev, "%s: Unable to allocate skb\n", __func__); + goto cleanup; + } + } else { + dev_dbg(dev, "%s: status %i\n", __func__, urb->status); + goto cleanup; + } + return; + +cleanup: + usb_free_urb(urb); + dev_kfree_skb(skb); + return; +} + +static int rtl8xxxu_submit_rx_urb(struct rtl8xxxu_priv *priv, + struct rtl8xxxu_rx_urb *rx_urb) +{ + struct sk_buff *skb; + int skb_size; + int ret; + + skb_size = sizeof(struct rtl8xxxu_rx_desc) + RTL_RX_BUFFER_SIZE; + skb = dev_alloc_skb(skb_size); + if (!skb) + return -ENOMEM; + + memset(skb->data, 0, sizeof(struct rtl8xxxu_rx_desc)); + usb_fill_bulk_urb(&rx_urb->urb, priv->udev, priv->pipe_in, skb->data, + skb_size, rtl8xxxu_rx_complete, skb); + usb_anchor_urb(&rx_urb->urb, &priv->rx_anchor); + ret = usb_submit_urb(&rx_urb->urb, GFP_ATOMIC); + if (ret) + usb_unanchor_urb(&rx_urb->urb); + return ret; +} + +static void rtl8xxxu_int_complete(struct urb *urb) +{ + struct rtl8xxxu_priv *priv = (struct rtl8xxxu_priv *)urb->context; + struct device *dev = &priv->udev->dev; + int i, ret; + + dev_dbg(dev, "%s: status %i\n", __func__, urb->status); + if (urb->status == 0) { + for (i = 0; i < USB_INTR_CONTENT_LENGTH; i++) { + printk("%02x ", priv->int_buf[i]); + if ((i & 0x0f) == 0x0f) + printk("\n"); + } + + usb_anchor_urb(urb, &priv->int_anchor); + ret = usb_submit_urb(urb, GFP_ATOMIC); + if (ret) + usb_unanchor_urb(urb); + } else { + dev_info(dev, "%s: Error %i\n", __func__, urb->status); + } +} + + +static int rtl8xxxu_submit_int_urb(struct ieee80211_hw *hw) +{ + struct rtl8xxxu_priv *priv = hw->priv; + struct urb *urb; + u32 val32; + int ret; + + urb = usb_alloc_urb(0, GFP_KERNEL); + if (!urb) + return -ENOMEM; + + usb_fill_int_urb(urb, priv->udev, priv->pipe_interrupt, + priv->int_buf, USB_INTR_CONTENT_LENGTH, + rtl8xxxu_int_complete, priv, 1); + usb_anchor_urb(urb, &priv->int_anchor); + ret = usb_submit_urb(urb, GFP_KERNEL); + if (ret) { + usb_unanchor_urb(urb); + goto error; + } + + val32 = rtl8723au_read32(priv, REG_USB_HIMR); + val32 |= USB_HIMR_CPWM; + rtl8723au_write32(priv, REG_USB_HIMR, val32); + +error: + return ret; +} + +static int rtl8xxxu_add_interface(struct ieee80211_hw *hw, + struct ieee80211_vif *vif) +{ + struct rtl8xxxu_priv *priv = hw->priv; + int ret; + u8 val8; + + switch (vif->type) { + case NL80211_IFTYPE_STATION: + rtl8723a_stop_tx_beacon(priv); + + val8 = rtl8723au_read8(priv, REG_BEACON_CTRL); + val8 |= BEACON_ATIM | BEACON_FUNCTION_ENABLE | + BEACON_DISABLE_TSF_UPDATE; + rtl8723au_write8(priv, REG_BEACON_CTRL, val8); + ret = 0; + break; + default: + ret = -EOPNOTSUPP; + } + + rtl8xxxu_set_linktype(priv, vif->type); + + return ret; +} + +static void rtl8xxxu_remove_interface(struct ieee80211_hw *hw, + struct ieee80211_vif *vif) +{ + struct rtl8xxxu_priv *priv = hw->priv; + + dev_dbg(&priv->udev->dev, "%s\n", __func__); +} + +static int rtl8xxxu_config(struct ieee80211_hw *hw, u32 changed) +{ + struct rtl8xxxu_priv *priv = hw->priv; + struct device *dev = &priv->udev->dev; + u16 val16; + int ret = 0, channel; + bool ht40; + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_CHANNEL) + dev_info(dev, + "%s: channel: %i (changed %08x chandef.width %02x)\n", + __func__, hw->conf.chandef.chan->hw_value, + changed, hw->conf.chandef.width); + + if (changed & IEEE80211_CONF_CHANGE_RETRY_LIMITS) { + val16 = ((hw->conf.long_frame_max_tx_count << + RETRY_LIMIT_LONG_SHIFT) & RETRY_LIMIT_LONG_MASK) | + ((hw->conf.short_frame_max_tx_count << + RETRY_LIMIT_SHORT_SHIFT) & RETRY_LIMIT_SHORT_MASK); + rtl8723au_write16(priv, REG_RETRY_LIMIT, val16); + } + + if (changed & IEEE80211_CONF_CHANGE_CHANNEL) { + switch (hw->conf.chandef.width) { + case NL80211_CHAN_WIDTH_20_NOHT: + case NL80211_CHAN_WIDTH_20: + ht40 = false; + break; + case NL80211_CHAN_WIDTH_40: + ht40 = true; + break; + default: + ret = -ENOTSUPP; + goto exit; + } + + channel = hw->conf.chandef.chan->hw_value; + + rtl8723a_set_tx_power(priv, channel, ht40); + + rtl8723au_config_channel(hw); + } + +exit: + return ret; +} + +static int rtl8xxxu_conf_tx(struct ieee80211_hw *hw, + struct ieee80211_vif *vif, u16 queue, + const struct ieee80211_tx_queue_params *param) +{ + struct rtl8xxxu_priv *priv = hw->priv; + struct device *dev = &priv->udev->dev; + u32 val32; + u16 cw_min, cw_max, txop; + u8 aifs, acm_ctrl, acm_bit; + + aifs = param->aifs; + cw_min = cpu_to_le16(param->cw_min); + cw_max = cpu_to_le16(param->cw_max); + txop = cpu_to_le16(param->txop); + + val32 = aifs | + (cw_min & 0xf) << EDCA_PARAM_ECW_MIN_SHIFT | + (cw_max & 0xf) << EDCA_PARAM_ECW_MAX_SHIFT | + txop << EDCA_PARAM_TXOP_SHIFT; + + acm_ctrl = rtl8723au_read8(priv, REG_ACM_HW_CTRL); + dev_dbg(dev, + "%s: IEEE80211 queue %02x val %08x, acm %i, acm_ctrl %02x\n", + __func__, queue, val32, param->acm, acm_ctrl); + + switch (queue) { + case IEEE80211_AC_VO: + acm_bit = ACM_HW_CTRL_VO; + rtl8723au_write32(priv, REG_EDCA_VO_PARAM, val32); + break; + case IEEE80211_AC_VI: + acm_bit = ACM_HW_CTRL_VI; + rtl8723au_write32(priv, REG_EDCA_VI_PARAM, val32); + break; + case IEEE80211_AC_BE: + acm_bit = ACM_HW_CTRL_BE; + rtl8723au_write32(priv, REG_EDCA_BE_PARAM, val32); + break; + case IEEE80211_AC_BK: + acm_bit = ACM_HW_CTRL_BK; + rtl8723au_write32(priv, REG_EDCA_BK_PARAM, val32); + break; + default: + acm_bit = 0; + break; + } + + if (param->acm) + acm_ctrl |= acm_bit; + else + acm_ctrl &= ~acm_bit; + rtl8723au_write8(priv, REG_ACM_HW_CTRL, acm_ctrl); + + return 0; +} + +static void rtl8xxxu_configure_filter(struct ieee80211_hw *hw, + unsigned int changed_flags, + unsigned int *total_flags, u64 multicast) +{ + struct rtl8xxxu_priv *priv = hw->priv; + + dev_dbg(&priv->udev->dev, "%s: changed_flags %08x, total_flags %08x\n", + __func__, changed_flags, *total_flags); + + *total_flags &= (FIF_ALLMULTI | FIF_CONTROL | FIF_BCN_PRBRESP_PROMISC); +} + +static int rtl8xxxu_set_rts_threshold(struct ieee80211_hw *hw, u32 rts) +{ + if (rts > 2347) + return -EINVAL; + + return 0; +} + +static int rtl8xxxu_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd, + struct ieee80211_vif *vif, + struct ieee80211_sta *sta, + struct ieee80211_key_conf *key) +{ + struct rtl8xxxu_priv *priv = hw->priv; + struct device *dev = &priv->udev->dev; + u8 mac_addr[ETH_ALEN]; + u8 val8; + u16 val16; + u32 val32; + int retval = -EOPNOTSUPP; + + dev_dbg(dev, "%s: cmd %02x, cipher %08x, index %i\n", + __func__, cmd, key->cipher, key->keyidx); + + if (vif->type != NL80211_IFTYPE_STATION) + return -EOPNOTSUPP; + + if (key->keyidx > 3) + return -EOPNOTSUPP; + + switch (key->cipher) { + case WLAN_CIPHER_SUITE_WEP40: + case WLAN_CIPHER_SUITE_WEP104: + + break; + case WLAN_CIPHER_SUITE_CCMP: + key->flags |= IEEE80211_KEY_FLAG_SW_MGMT_TX; + break; + case WLAN_CIPHER_SUITE_TKIP: + key->flags |= IEEE80211_KEY_FLAG_GENERATE_MMIC; + default: + return -EOPNOTSUPP; + } + + if (key->flags & IEEE80211_KEY_FLAG_PAIRWISE) { + dev_dbg(dev, "%s: pairwise key\n", __func__); + ether_addr_copy(mac_addr, sta->addr); + } else { + dev_dbg(dev, "%s: group key\n", __func__); + eth_broadcast_addr(mac_addr); + } + + val16 = rtl8723au_read16(priv, REG_CR); + val16 |= CR_SECURITY_ENABLE; + rtl8723au_write16(priv, REG_CR, val16); + + val8 = SEC_CFG_TX_SEC_ENABLE | SEC_CFG_TXBC_USE_DEFKEY | + SEC_CFG_RX_SEC_ENABLE | SEC_CFG_RXBC_USE_DEFKEY; + val8 |= SEC_CFG_TX_USE_DEFKEY | SEC_CFG_RX_USE_DEFKEY; + rtl8723au_write8(priv, REG_SECURITY_CFG, val8); + + switch (cmd) { + case SET_KEY: + /* + * This is a bit of a hack - the lower bits of the cipher + * suite selector happens to match the cipher index in the + * CAM + */ + key->hw_key_idx = key->keyidx; + key->flags |= IEEE80211_KEY_FLAG_GENERATE_IV; + rtl8xxxu_cam_write(priv, key, mac_addr); + retval = 0; + break; + case DISABLE_KEY: + rtl8723au_write32(priv, REG_CAM_WRITE, 0x00000000); + val32 = CAM_CMD_POLLING | CAM_CMD_WRITE | + key->keyidx << CAM_CMD_KEY_SHIFT; + rtl8723au_write32(priv, REG_CAM_CMD, val32); + retval = 0; + break; + default: + dev_warn(dev, "%s: Unsupported command %02x\n", __func__, cmd); + } + + return retval; +} + +static int +rtl8xxxu_ampdu_action(struct ieee80211_hw *hw, struct ieee80211_vif *vif, + enum ieee80211_ampdu_mlme_action action, + struct ieee80211_sta *sta, u16 tid, u16 *ssn, u8 buf_size) +{ + struct rtl8xxxu_priv *priv = hw->priv; + struct device *dev = &priv->udev->dev; + u8 ampdu_factor, ampdu_density; + + switch (action) { + case IEEE80211_AMPDU_TX_START: + dev_info(dev, "%s: IEEE80211_AMPDU_TX_START\n", __func__); + ampdu_factor = sta->ht_cap.ampdu_factor; + ampdu_density = sta->ht_cap.ampdu_density; + rtl8xxxu_set_ampdu_factor(priv, ampdu_factor); + rtl8xxxu_set_ampdu_min_space(priv, ampdu_density); + dev_dbg(dev, + "Changed HT: ampdu_factor %02x, ampdu_density %02x\n", + ampdu_factor, ampdu_density); + break; + case IEEE80211_AMPDU_TX_STOP_FLUSH: + dev_info(dev, "%s: IEEE80211_AMPDU_TX_STOP_FLUSH\n", __func__); + rtl8xxxu_set_ampdu_factor(priv, 0); + rtl8xxxu_set_ampdu_min_space(priv, 0); + break; + case IEEE80211_AMPDU_TX_STOP_FLUSH_CONT: + dev_info(dev, "%s: IEEE80211_AMPDU_TX_STOP_FLUSH_CONT\n", + __func__); + rtl8xxxu_set_ampdu_factor(priv, 0); + rtl8xxxu_set_ampdu_min_space(priv, 0); + break; + case IEEE80211_AMPDU_RX_START: + dev_info(dev, "%s: IEEE80211_AMPDU_RX_START\n", __func__); + break; + case IEEE80211_AMPDU_RX_STOP: + dev_info(dev, "%s: IEEE80211_AMPDU_RX_STOP\n", __func__); + break; + default: + break; + } + return 0; +} + +static int rtl8xxxu_start(struct ieee80211_hw *hw) +{ + struct rtl8xxxu_priv *priv = hw->priv; + struct rtl8xxxu_rx_urb *rx_urb; + int ret, i; + + ret = 0; + + init_usb_anchor(&priv->rx_anchor); + init_usb_anchor(&priv->tx_anchor); + init_usb_anchor(&priv->int_anchor); + + rtl8723a_enable_rf(priv); + ret = rtl8xxxu_submit_int_urb(hw); + if (ret) + goto exit; + + for (i = 0; i < 32; i++) { + rx_urb = kmalloc(sizeof(struct rtl8xxxu_rx_urb), GFP_ATOMIC); + if (!rx_urb) { + if (!i) + ret = -ENOMEM; + + goto exit; + } + usb_init_urb(&rx_urb->urb); + rx_urb->hw = hw; + + ret = rtl8xxxu_submit_rx_urb(priv, rx_urb); + } +exit: + /* + * Disable all data frames + */ + rtl8723au_write16(priv, REG_RXFLTMAP2, 0x0000); + /* + * Accept all mgmt frames + */ + rtl8723au_write16(priv, REG_RXFLTMAP0, 0xffff); + + rtl8723au_write32(priv, REG_OFDM0_XA_AGC_CORE1, 0x6954341e); + + return ret; +} + +static void rtl8xxxu_stop(struct ieee80211_hw *hw) +{ + struct rtl8xxxu_priv *priv = hw->priv; + + rtl8723au_write8(priv, REG_TXPAUSE, 0xff); + + rtl8723au_write16(priv, REG_RXFLTMAP0, 0x0000); + rtl8723au_write16(priv, REG_RXFLTMAP2, 0x0000); + + usb_kill_anchored_urbs(&priv->rx_anchor); + usb_kill_anchored_urbs(&priv->tx_anchor); + usb_kill_anchored_urbs(&priv->int_anchor); + + rtl8723a_disable_rf(priv); + + /* + * Disable interrupts + */ + rtl8723au_write32(priv, REG_USB_HIMR, 0); +} + +static const struct ieee80211_ops rtl8xxxu_ops = { + .tx = rtl8xxxu_tx, + .add_interface = rtl8xxxu_add_interface, + .remove_interface = rtl8xxxu_remove_interface, + .config = rtl8xxxu_config, + .conf_tx = rtl8xxxu_conf_tx, + .bss_info_changed = rtl8xxxu_bss_info_changed, + .configure_filter = rtl8xxxu_configure_filter, + .set_rts_threshold = rtl8xxxu_set_rts_threshold, + .start = rtl8xxxu_start, + .stop = rtl8xxxu_stop, + .sw_scan_start = rtl8xxxu_sw_scan_start, + .sw_scan_complete = rtl8xxxu_sw_scan_complete, + .set_key = rtl8xxxu_set_key, + .ampdu_action = rtl8xxxu_ampdu_action, +}; + +static int rtl8xxxu_parse_usb(struct rtl8xxxu_priv *priv, + struct usb_interface *interface) +{ + struct usb_interface_descriptor *interface_desc; + struct usb_host_interface *host_interface; + struct usb_endpoint_descriptor *endpoint; + struct device *dev = &priv->udev->dev; + int i, j = 0, endpoints; + u8 dir, xtype, num; + int ret = 0; + + host_interface = &interface->altsetting[0]; + interface_desc = &host_interface->desc; + endpoints = interface_desc->bNumEndpoints; + + for (i = 0; i < endpoints; i++) { + endpoint = &host_interface->endpoint[i].desc; + + dir = endpoint->bEndpointAddress & USB_ENDPOINT_DIR_MASK; + num = usb_endpoint_num(endpoint); + xtype = usb_endpoint_type(endpoint); + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_USB) + dev_dbg(dev, + "%s: endpoint: dir %02x, # %02x, type %02x\n", + __func__, dir, num, xtype); + if (usb_endpoint_dir_in(endpoint) && + usb_endpoint_xfer_bulk(endpoint)) { + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_USB) + dev_dbg(dev, "%s: in endpoint num %i\n", + __func__, num); + + if (priv->pipe_in) { + dev_warn(dev, + "%s: Too many IN pipes\n", __func__); + ret = -EINVAL; + goto exit; + } + + priv->pipe_in = usb_rcvbulkpipe(priv->udev, num); + } + + if (usb_endpoint_dir_in(endpoint) && + usb_endpoint_xfer_int(endpoint)) { + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_USB) + dev_dbg(dev, "%s: interrupt endpoint num %i\n", + __func__, num); + + if (priv->pipe_interrupt) { + dev_warn(dev, "%s: Too many INTERRUPT pipes\n", + __func__); + ret = -EINVAL; + goto exit; + } + + priv->pipe_interrupt = usb_rcvintpipe(priv->udev, num); + } + + if (usb_endpoint_dir_out(endpoint) && + usb_endpoint_xfer_bulk(endpoint)) { + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_USB) + dev_dbg(dev, "%s: out endpoint num %i\n", + __func__, num); + if (j >= RTL8XXXU_OUT_ENDPOINTS) { + dev_warn(dev, + "%s: Too many OUT pipes\n", __func__); + ret = -EINVAL; + goto exit; + } + priv->out_ep[j++] = num; + } + } +exit: + return ret; +} + +static int rtl8xxxu_probe(struct usb_interface *interface, + const struct usb_device_id *id) +{ + struct rtl8xxxu_priv *priv; + struct ieee80211_hw *hw; + struct usb_device *udev; + struct ieee80211_supported_band *sband; + int ret = 0; + + udev = usb_get_dev(interface_to_usbdev(interface)); + + hw = ieee80211_alloc_hw(sizeof(struct rtl8xxxu_priv), &rtl8xxxu_ops); + if (!hw) { + ret = -ENOMEM; + goto exit; + } + + priv = hw->priv; + priv->hw = hw; + priv->udev = udev; + mutex_init(&priv->usb_buf_mutex); + mutex_init(&priv->h2c_mutex); + + usb_set_intfdata(interface, hw); + + ret = rtl8xxxu_parse_usb(priv, interface); + if (ret) + goto exit; + + rtl8xxxu_8723au_identify_chip(priv); + rtl8xxxu_read_efuse(priv); + ether_addr_copy(priv->mac_addr, priv->efuse_wifi.efuse.mac_addr); + + dev_info(&udev->dev, "RTL8723au MAC %pM\n", + priv->efuse_wifi.efuse.mac_addr); + + rtl8xxxu_load_firmware(priv); + + ret = rtl8xxxu_init_device(hw); + + hw->wiphy->max_scan_ssids = 1; + hw->wiphy->max_scan_ie_len = IEEE80211_MAX_DATA_LEN; + hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION); + hw->queues = 4; + + sband = &rtl8xxxu_supported_band; + sband->ht_cap.ht_supported = true; + sband->ht_cap.ampdu_factor = IEEE80211_HT_MAX_AMPDU_64K; + sband->ht_cap.ampdu_density = IEEE80211_HT_MPDU_DENSITY_16; + sband->ht_cap.cap = /* IEEE80211_HT_CAP_SUP_WIDTH_20_40 | */ + IEEE80211_HT_CAP_SGI_20 | IEEE80211_HT_CAP_SGI_40; + memset(&sband->ht_cap.mcs, 0, sizeof(sband->ht_cap.mcs)); + sband->ht_cap.mcs.rx_mask[0] = 0xff; + sband->ht_cap.mcs.rx_mask[4] = 0x01; + if (priv->rf_paths > 1) { + sband->ht_cap.mcs.rx_mask[1] = 0xff; + sband->ht_cap.cap |= IEEE80211_HT_CAP_SGI_40; + } + sband->ht_cap.mcs.tx_params = IEEE80211_HT_MCS_TX_DEFINED; + hw->wiphy->bands[IEEE80211_BAND_2GHZ] = sband; + + hw->wiphy->rts_threshold = 2347; + + SET_IEEE80211_DEV(priv->hw, &interface->dev); + SET_IEEE80211_PERM_ADDR(hw, priv->mac_addr); + + hw->extra_tx_headroom = sizeof(struct rtl8xxxu_tx_desc); + hw->flags = IEEE80211_HW_SIGNAL_DBM; + /* + * The firmware handles rate control + */ + hw->flags |= IEEE80211_HW_HAS_RATE_CONTROL; + + ret = ieee80211_register_hw(priv->hw); + if (ret) { + dev_err(&udev->dev, "%s: Failed to register: %i\n", + __func__, ret); + goto exit; + } + +exit: + if (ret < 0) + usb_put_dev(udev); + return ret; +} + +static void rtl8xxxu_disconnect(struct usb_interface *interface) +{ + struct rtl8xxxu_priv *priv; + struct ieee80211_hw *hw; + + hw = usb_get_intfdata(interface); + priv = hw->priv; + + rtl8xxxu_disable_device(hw); + usb_set_intfdata(interface, NULL); + + ieee80211_unregister_hw(hw); + + kfree(priv->fw_data); + mutex_destroy(&priv->usb_buf_mutex); + mutex_destroy(&priv->h2c_mutex); + + usb_put_dev(priv->udev); + ieee80211_free_hw(hw); + + wiphy_info(hw->wiphy, "disconnecting\n"); +} + +static struct usb_driver rtl8xxxu_driver = { + .name = DRIVER_NAME, + .probe = rtl8xxxu_probe, + .disconnect = rtl8xxxu_disconnect, + .id_table = dev_table, + .disable_hub_initiated_lpm = 1, +}; + +static int __init rtl8xxxu_module_init(void) +{ + int res; + + res = usb_register(&rtl8xxxu_driver); + if (res < 0) + pr_err(DRIVER_NAME ": usb_register() failed (%i)\n", res); + + return res; +} + +static void __exit rtl8xxxu_module_exit(void) +{ + usb_deregister(&rtl8xxxu_driver); +} + +module_init(rtl8xxxu_module_init); +module_exit(rtl8xxxu_module_exit); diff --git a/drivers/net/wireless/rtl8xxxu.h b/drivers/net/wireless/rtl8xxxu.h new file mode 100644 index 0000000..2d34904 --- /dev/null +++ b/drivers/net/wireless/rtl8xxxu.h @@ -0,0 +1,497 @@ +/* + * Copyright (c) 2014 - 2015 Jes Sorensen <Jes.Sorensen@redhat.com> + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of version 2 of the GNU General Public License as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * Register definitions taken from original Realtek rtl8723au driver + */ + +#include <asm/byteorder.h> + +#define RTL8XXXU_DEBUG_REG_WRITE 0x01 +#define RTL8XXXU_DEBUG_REG_READ 0x02 +#define RTL8XXXU_DEBUG_RFREG_WRITE 0x04 +#define RTL8XXXU_DEBUG_RFREG_READ 0x08 +#define RTL8XXXU_DEBUG_CHANNEL 0x10 +#define RTL8XXXU_DEBUG_TX 0x20 +#define RTL8XXXU_DEBUG_TX_DUMP 0x40 +#define RTL8XXXU_DEBUG_RX 0x80 +#define RTL8XXXU_DEBUG_RX_DUMP 0x100 +#define RTL8XXXU_DEBUG_USB 0x200 +#define RTL8XXXU_DEBUG_KEY 0x400 +#define RTL8XXXU_DEBUG_H2C 0x800 +#define RTL8XXXU_DEBUG_ACTION 0x1000 + +#define RTW_USB_CONTROL_MSG_TIMEOUT 500 +#define RTL8XXXU_MAX_REG_POLL 500 +#define USB_INTR_CONTENT_LENGTH 56 + +#define RTL8XXXU_OUT_ENDPOINTS 3 + +#define REALTEK_USB_READ 0xc0 +#define REALTEK_USB_WRITE 0x40 +#define REALTEK_USB_CMD_REQ 0x05 +#define REALTEK_USB_CMD_IDX 0x00 + +#define TX_TOTAL_PAGE_NUM 0xf8 +/* (HPQ + LPQ + NPQ + PUBQ) = TX_TOTAL_PAGE_NUM */ +#define TX_PAGE_NUM_PUBQ 0xe7 +#define TX_PAGE_NUM_HI_PQ 0x0c +#define TX_PAGE_NUM_LO_PQ 0x02 +#define TX_PAGE_NUM_NORM_PQ 0x02 + +#define RTL_FW_PAGE_SIZE 4096 +#define RTL8XXXU_FIRMWARE_POLL_MAX 1000 + +#define RTL8723A_CHANNEL_GROUPS 3 +#define RTL8723A_MAX_RF_PATHS 2 +#define RF6052_MAX_TX_PWR 0x3f + +#define EFUSE_MAP_LEN_8723A 256 +#define EFUSE_MAX_SECTION_8723A 32 +#define EFUSE_REAL_CONTENT_LEN_8723A 512 +#define EFUSE_BT_MAP_LEN_8723A 1024 +#define EFUSE_MAX_WORD_UNIT 4 + +struct rtl8xxxu_rx_desc { + u32 pktlen:14; + u32 crc32:1; + u32 icverr:1; + u32 drvinfo_sz:4; + u32 security:3; + u32 qos:1; + u32 shift:2; + u32 phy_stats:1; + u32 swdec:1; + u32 ls:1; + u32 fs:1; + u32 eor:1; + u32 own:1; + + u32 macid:5; + u32 tid:4; + u32 hwrsvd:4; + u32 amsdu:1; + u32 paggr:1; + u32 faggr:1; + u32 a1fit:4; + u32 a2fit:4; + u32 pam:1; + u32 pwr:1; + u32 md:1; + u32 mf:1; + u32 type:2; + u32 mc:1; + u32 bc:1; + + u32 seq:12; + u32 frag:4; + u32 nextpktlen:14; + u32 nextind:1; + u32 reserved0:1; + + u32 rxmcs:6; + u32 rxht:1; + u32 gf:1; + u32 splcp:1; + u32 bw:1; + u32 htc:1; + u32 eosp:1; + u32 bssidfit:2; + u32 reserved1:16; + u32 unicastwake:1; + u32 magicwake:1; + + u32 pattern0match:1; + u32 pattern1match:1; + u32 pattern2match:1; + u32 pattern3match:1; + u32 pattern4match:1; + u32 pattern5match:1; + u32 pattern6match:1; + u32 pattern7match:1; + u32 pattern8match:1; + u32 pattern9match:1; + u32 patternamatch:1; + u32 patternbmatch:1; + u32 patterncmatch:1; + u32 reserved2:19; + + u32 tsfl; +#if 0 + u32 bassn:12; + u32 bavld:1; + u32 reserved3:19; +#endif +}; + +struct rtl8xxxu_tx_desc { + __le16 pkt_size; + u8 pkt_offset; + u8 txdw0; + __le32 txdw1; + __le32 txdw2; + __le32 txdw3; + __le32 txdw4; + __le32 txdw5; + __le32 txdw6; + __le16 csum; + __le16 txdw7; +}; + +/* CCK Rates, TxHT = 0 */ +#define DESC_RATE_1M 0x00 +#define DESC_RATE_2M 0x01 +#define DESC_RATE_5_5M 0x02 +#define DESC_RATE_11M 0x03 + +/* OFDM Rates, TxHT = 0 */ +#define DESC_RATE_6M 0x04 +#define DESC_RATE_9M 0x05 +#define DESC_RATE_12M 0x06 +#define DESC_RATE_18M 0x07 +#define DESC_RATE_24M 0x08 +#define DESC_RATE_36M 0x09 +#define DESC_RATE_48M 0x0a +#define DESC_RATE_54M 0x0b + +/* MCS Rates, TxHT = 1 */ +#define DESC_RATE_MCS0 0x0c +#define DESC_RATE_MCS1 0x0d +#define DESC_RATE_MCS2 0x0e +#define DESC_RATE_MCS3 0x0f +#define DESC_RATE_MCS4 0x10 +#define DESC_RATE_MCS5 0x11 +#define DESC_RATE_MCS6 0x12 +#define DESC_RATE_MCS7 0x13 +#define DESC_RATE_MCS8 0x14 +#define DESC_RATE_MCS9 0x15 +#define DESC_RATE_MCS10 0x16 +#define DESC_RATE_MCS11 0x17 +#define DESC_RATE_MCS12 0x18 +#define DESC_RATE_MCS13 0x19 +#define DESC_RATE_MCS14 0x1a +#define DESC_RATE_MCS15 0x1b +#define DESC_RATE_MCS15_SG 0x1c +#define DESC_RATE_MCS32 0x20 + +#define TXDESC_OFFSET_SZ 0 +#define TXDESC_OFFSET_SHT 16 +#if 0 +#define TXDESC_BMC BIT(24) +#define TXDESC_LSG BIT(26) +#define TXDESC_FSG BIT(27) +#define TXDESC_OWN BIT(31) +#else +#define TXDESC_BROADMULTICAST BIT(0) +#define TXDESC_LSG BIT(2) +#define TXDESC_FSG BIT(3) +#define TXDESC_OWN BIT(7) +#endif + +/* Word 1 */ +#define TXDESC_PKT_OFFSET_SZ 0 +#define TXDESC_AGG_ENABLE BIT(5) +#define TXDESC_BK BIT(6) +#define TXDESC_QUEUE_SHIFT 8 +#define TXDESC_QUEUE_MASK 0x1f00 +#define TXDESC_QUEUE_BK 0x2 +#define TXDESC_QUEUE_BE 0x0 +#define TXDESC_QUEUE_VI 0x5 +#define TXDESC_QUEUE_VO 0x7 +#define TXDESC_QUEUE_BEACON 0x10 +#define TXDESC_QUEUE_HIGH 0x11 +#define TXDESC_QUEUE_MGNT 0x12 +#define TXDESC_QUEUE_CMD 0x13 +#define TXDESC_QUEUE_MAX (TXDESC_QUEUE_CMD + 1) + +#define DESC_RATE_ID_SHIFT 16 +#define DESC_RATE_ID_MASK 0xf +#define TXDESC_NAVUSEHDR BIT(20) +#define TXDESC_SEC_RC4 0x00400000 +#define TXDESC_SEC_AES 0x00c00000 +#define TXDESC_PKT_OFFSET_SHIFT 26 +#define TXDESC_HWPC BIT(31) + +/* Word 2 */ +#define TXDESC_AMPDU_DENSITY_SHIFT 20 +#define TXDESC_AGG_EN BIT(29) + +/* Word 3 */ +#define TXDESC_SEQ_SHIFT 16 +#define TXDESC_SEQ_MASK 0x000fff0000 + +/* Word 4 */ +#define TXDESC_QOS BIT(6) +#define TXDESC_HW_SEQ_ENABLE BIT(7) +#define TXDESC_USE_DRIVER_RATE BIT(8) +#define TXDESC_DISABLE_DATA_FB BIT(10) +#define TXDESC_CTS_SELF_ENABLE BIT(11) +#define TXDESC_RTS_CTS_ENABLE BIT(12) +#define TXDESC_HW_RTS_ENABLE BIT(13) +#define TXDESC_SHORT_PREAMBLE BIT(24) +#define TXDESC_DATA_BW BIT(25) + +/* Word 5 */ +#define TXDESC_RTS_RATE_SHIFT 0 +#define TXDESC_RTS_RATE_MASK 0x3f +#define TXDESC_SHORT_GI BIT(6) +#define TXDESC_CCX_TAG BIT(7) +#define TXDESC_RETRY_LIMIT_ENABLE BIT(17) +#define TXDESC_RETRY_LIMIT_SHIFT 18 +#define TXDESC_RETRY_LIMIT_MASK 0x00fc0000 + +struct phy_rx_agc_info { +#ifdef __LITTLE_ENDIAN + u8 gain:7, trsw:1; +#else + u8 trsw:1, gain:7; +#endif +}; + +struct rtl8723au_phy_stats { + struct phy_rx_agc_info path_agc[RTL8723A_MAX_RF_PATHS]; + u8 ch_corr[RTL8723A_MAX_RF_PATHS]; + u8 cck_sig_qual_ofdm_pwdb_all; + u8 cck_agc_rpt_ofdm_cfosho_a; + u8 cck_rpt_b_ofdm_cfosho_b; + u8 reserved_1; + u8 noise_power_db_msb; + u8 path_cfotail[RTL8723A_MAX_RF_PATHS]; + u8 pcts_mask[RTL8723A_MAX_RF_PATHS]; + s8 stream_rxevm[RTL8723A_MAX_RF_PATHS]; + u8 path_rxsnr[RTL8723A_MAX_RF_PATHS]; + u8 noise_power_db_lsb; + u8 reserved_2[3]; + u8 stream_csi[RTL8723A_MAX_RF_PATHS]; + u8 stream_target_csi[RTL8723A_MAX_RF_PATHS]; + s8 sig_evm; + u8 reserved_3; + +#ifdef __LITTLE_ENDIAN + u8 antsel_rx_keep_2:1; /* ex_intf_flg:1; */ + u8 sgi_en:1; + u8 rxsc:2; + u8 idle_long:1; + u8 r_ant_train_en:1; + u8 antenna_select_b:1; + u8 antenna_select:1; +#else /* _BIG_ENDIAN_ */ + u8 antenna_select:1; + u8 antenna_select_b:1; + u8 r_ant_train_en:1; + u8 idle_long:1; + u8 rxsc:2; + u8 sgi_en:1; + u8 antsel_rx_keep_2:1; /* ex_intf_flg:1; */ +#endif +}; + +/* + * Regs to backup + */ +#define RTL8XXXU_ADDA_REGS 16 +#define RTL8XXXU_MAC_REGS 4 +#define RTL8XXXU_BB_REGS 9 + +struct rtl8xxxu_firmware_header { + __le16 signature; /* 92C0: test chip; 92C, + 88C0: test chip; + 88C1: MP A-cut; + 92C1: MP A-cut */ + u8 category; /* AP/NIC and USB/PCI */ + u8 function; + + __le16 major_version; /* FW Version */ + u8 minor_version; /* FW Subversion, default 0x00 */ + u8 reserved1; + + u8 month; /* Release time Month field */ + u8 date; /* Release time Date field */ + u8 hour; /* Release time Hour field */ + u8 minute; /* Release time Minute field */ + + __le16 ramcodesize; /* Size of RAM code */ + u16 reserved2; + + __le32 svn_idx; /* SVN entry index */ + u32 reserved3; + + u32 reserved4; + u32 reserved5; + + u8 data[0]; +}; + +/* + * The 8723au has 3 channel groups: 1-3, 4-9, and 10-14 + */ +struct rtl8723au_idx { +#ifdef __LITTLE_ENDIAN + int a:4; + int b:4; +#else + int b:4; + int a:4; +#endif +} __attribute__((packed)); + +struct rtl8723au_efuse { + __le16 rtl_id; + u8 res0[0xe]; + u8 cck_tx_power_index_A[3]; /* 0x10 */ + u8 cck_tx_power_index_B[3]; + u8 ht40_1s_tx_power_index_A[3]; /* 0x16 */ + u8 ht40_1s_tx_power_index_B[3]; + /* + * The following entries are half-bytes split as: + * bits 0-3: path A, bits 4-7: path B, all values 4 bits signed + */ + struct rtl8723au_idx ht20_tx_power_index_diff[3]; + struct rtl8723au_idx ofdm_tx_power_index_diff[3]; + struct rtl8723au_idx ht40_max_power_offset[3]; + struct rtl8723au_idx ht20_max_power_offset[3]; + u8 channel_plan; /* 0x28 */ + u8 tssi_a; + u8 thermal_meter; + u8 rf_regulatory; + u8 rf_option_2; + u8 rf_option_3; + u8 rf_option_4; + u8 res7; + u8 version /* 0x30 */; + u8 customer_id_major; + u8 customer_id_minor; + u8 xtal_k; + u8 chipset; /* 0x34 */ + u8 res8[0x82]; + u8 vid; /* 0xb7 */ + u8 res9; + u8 pid; /* 0xb9 */ + u8 res10[0x0c]; + u8 mac_addr[ETH_ALEN]; /* 0xc6 */ + u8 res11[2]; + u8 vendor_name[7]; + u8 res12[2]; + u8 device_name[0x29]; /* 0xd7 */ +}; + +struct rtl8xxxu_reg8val { + u16 reg; + u8 val; +}; + +struct rtl8xxxu_reg32val { + u16 reg; + u32 val; +}; + +struct rtl8xxxu_rfregval { + u8 reg; + u32 val; +}; + +#define H2C_MAX_MBOX 4 +#define H2C_EXT BIT(7) +#define H2C_SET_POWER_MODE 1 +#define H2C_JOIN_BSS_REPORT 2 +#define H2C_JOIN_BSS_DISCONNECT 0 +#define H2C_JOIN_BSS_CONNECT 1 +#define H2C_SET_RSSI 5 +#define H2C_SET_RATE_MASK (6 | H2C_EXT) + +struct h2c_cmd { + union { + struct { + u8 cmd; + u8 data[5]; + } __packed cmd; + struct { + __le32 data; + __le16 ext; + } __packed raw; + struct { + u8 cmd; + u8 data; + u8 pad[4]; + } __packed joinbss; + struct { + u8 cmd; + __le16 mask_hi; + u8 arg; + __le16 mask_lo; + } __packed ramask; + }; +}; + +struct rtl8xxxu_priv { + struct ieee80211_hw *hw; + struct usb_device *udev; + u8 mac_addr[ETH_ALEN]; + u32 chip_cut:4; + u32 rom_rev:4; + u32 has_wifi:1; + u32 has_bluetooth:1; + u32 enable_bluetooth:1; + u32 has_gps:1; + u32 vendor_umc:1; + u32 has_polarity_ctrl:1; + u32 has_eeprom:1; + u32 boot_eeprom:1; + u32 ep_tx_high_queue:1; + u32 ep_tx_normal_queue:1; + u32 ep_tx_low_queue:1; + u32 path_a_hi_power:1; + u32 path_a_rf_paths:4; + unsigned int pipe_interrupt; + unsigned int pipe_in; + unsigned int pipe_out[TXDESC_QUEUE_MAX]; + u8 out_ep[RTL8XXXU_OUT_ENDPOINTS]; + u8 path_a_ig_value; + int ep_tx_count; + int rf_paths; + u32 rf_mode_ag[2]; + u32 rege94; + u32 rege9c; + u32 regeb4; + u32 regebc; + int next_mbox; + + struct mutex h2c_mutex; + + struct usb_anchor rx_anchor; + struct usb_anchor tx_anchor; + struct usb_anchor int_anchor; + struct rtl8xxxu_firmware_header *fw_data; + size_t fw_size; + struct mutex usb_buf_mutex; + union { + __le32 val32; + __le16 val16; + u8 val8; + } usb_buf; + union { + u8 raw[EFUSE_MAP_LEN_8723A]; + struct rtl8723au_efuse efuse; + } efuse_wifi; + u32 adda_backup[RTL8XXXU_ADDA_REGS]; + u32 mac_backup[RTL8XXXU_MAC_REGS]; + u32 bb_backup[RTL8XXXU_BB_REGS]; + u32 bb_recovery_backup[RTL8XXXU_BB_REGS]; + u8 pi_enabled:1; + u8 iqk_initialized:1; + u8 int_buf[USB_INTR_CONTENT_LENGTH]; + bool use_shortgi; +}; + +struct rtl8xxxu_rx_urb { + struct urb urb; + struct ieee80211_hw *hw; +}; diff --git a/drivers/net/wireless/rtl8xxxu_regs.h b/drivers/net/wireless/rtl8xxxu_regs.h new file mode 100644 index 0000000..53039a4 --- /dev/null +++ b/drivers/net/wireless/rtl8xxxu_regs.h @@ -0,0 +1,941 @@ +/* + * Copyright (c) 2014 - 2015 Jes Sorensen <Jes.Sorensen@redhat.com> + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of version 2 of the GNU General Public License as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * Register definitions taken from original Realtek rtl8723au driver + */ + +/* 0x0000 ~ 0x00FF System Configuration */ +#define REG_SYS_ISO_CTRL 0x0000 +#define SYS_ISO_PWC_EV25V BIT(14) +#define SYS_ISO_PWC_EV12V BIT(15) +#define SYS_ISO_ANALOG_IPS BIT(5) + +#define REG_SYS_FUNC 0x0002 +#define SYS_FUNC_BBRSTB BIT(0) +#define SYS_FUNC_BB_GLB_RSTN BIT(1) +#define SYS_FUNC_USBA BIT(2) +#define SYS_FUNC_UPLL BIT(3) +#define SYS_FUNC_USBD BIT(4) +#define SYS_FUNC_DIO_PCIE BIT(5) +#define SYS_FUNC_PCIEA BIT(6) +#define SYS_FUNC_PPLL BIT(7) +#define SYS_FUNC_PCIED BIT(8) +#define SYS_FUNC_DIOE BIT(9) +#define SYS_FUNC_CPU_ENABLE BIT(10) +#define SYS_FUNC_DCORE BIT(11) +#define SYS_FUNC_ELDR BIT(12) +#define SYS_FUNC_DIO_RF BIT(13) +#define SYS_FUNC_HWPDN BIT(14) +#define SYS_FUNC_MREGEN BIT(15) + +#define REG_APS_FSMCO 0x0004 +#define APS_FSMCO_HW_POWERDOWN BIT(15) +#define APS_FSMCO_WLON_RESET BIT(16) + +#define REG_SYS_CLKR 0x0008 +#define SYS_CLK_ANAD16V_ENABLE BIT(0) +#define SYS_CLK_ANA8M BIT(1) +#define SYS_CLK_MACSLP BIT(4) +#define SYS_CLK_LOADER_ENABLE BIT(5) +#define SYS_CLK_80M_SSC_DISABLE BIT(7) +#define SYS_CLK_80M_SSC_ENABLE_HO BIT(8) +#define SYS_CLK_PHY_SSC_RSTB BIT(9) +#define SYS_CLK_SEC_CLK_ENABLE BIT(10) +#define SYS_CLK_MAC_CLK_ENABLE BIT(11) +#define SYS_CLK_ENABLE BIT(12) +#define SYS_CLK_RING_CLK_ENABLE BIT(13) + +#define REG_9346CR 0x000a +#define EEPROM_BOOT BIT(4) +#define EEPROM_ENABLE BIT(5) + +#define REG_EE_VPD 0x000c +#define REG_AFE_MISC 0x0010 +#define REG_SPS0_CTRL 0x0011 +#define REG_SPS_OCP_CFG 0x0018 +#define REG_RSV_CTRL 0x001c + +#define REG_RF_CTRL 0x001f +#define RF_ENABLE BIT(0) +#define RF_RSTB BIT(1) +#define RF_SDMRSTB BIT(2) + +#define REG_LDOA15_CTRL 0x0020 +#define LDOA15_ENABLE BIT(0) +#define LDOA15_STANDBY BIT(1) +#define LDOA15_OBUF BIT(2) +#define LDOA15_REG_VOS BIT(3) +#define LDOA15_VOADJ_SHIFT 4 + +#define REG_LDOV12D_CTRL 0x0021 +#define LDOV12D_ENABLE BIT(0) +#define LDOV12D_STANDBY BIT(1) +#define LDOV12D_VADJ_SHIFT 4 + +#define REG_LDOHCI12_CTRL 0x0022 + +#define REG_LPLDO_CTRL 0x0023 +#define LPLDO_HSM BIT(2) +#define LPLDO_LSM_DIS BIT(3) + +#define REG_AFE_XTAL_CTRL 0x0024 +#define AFE_XTAL_ENABLE BIT(0) +#define AFE_XTAL_B_SELECT BIT(1) +#define AFE_XTAL_RF_GATE BIT(14) +#define AFE_XTAL_BT_GATE BIT(20) + +#define REG_AFE_PLL_CTRL 0x0028 +#define AFE_PLL_ENABLE BIT(0) +#define AFE_PLL_320_ENABLE BIT(1) +#define APE_PLL_FREF_SELECT BIT(2) +#define AFE_PLL_EDGE_SELECT BIT(3) +#define AFE_PLL_WDOGB BIT(4) +#define AFE_PLL_LPF_ENABLE BIT(5) + +#define REG_MAC_PHY_CTRL 0x002c + +#define REG_EFUSE_CTRL 0x0030 +#define REG_EFUSE_TEST 0x0034 +#define EFUSE_TRPT BIT(7) + /* 00: Wifi Efuse, 01: BT Efuse0, 10: BT Efuse1, 11: BT Efuse2 */ +#define EFUSE_CELL_SEL (BIT(8) | BIT(9)) +#define EFUSE_LDOE25_ENABLE BIT(31) +#define EFUSE_SELECT_MASK 0x0300 +#define EFUSE_WIFI_SELECT 0x0000 +#define EFUSE_BT0_SELECT 0x0100 +#define EFUSE_BT1_SELECT 0x0200 +#define EFUSE_BT2_SELECT 0x0300 + +#define EFUSE_ACCESS_ENABLE 0x69 /* RTL8723 only */ +#define EFUSE_ACCESS_DISABLE 0x00 /* RTL8723 only */ + +#define REG_PWR_DATA 0x0038 +#define REG_CAL_TIMER 0x003c +#define REG_ACLK_MON 0x003e +#define REG_GPIO_MUXCFG 0x0040 +#define REG_GPIO_IO_SEL 0x0042 +#define REG_MAC_PINMUX_CFG 0x0043 +#define REG_GPIO_PIN_CTRL 0x0044 +#define REG_GPIO_INTM 0x0048 +#define REG_LEDCFG0 0x004c +#define REG_LEDCFG1 0x004d +#define REG_LEDCFG2 0x004e +#define LEDCFG2_DPDT_SELECT BIT(7) +#define REG_LEDCFG3 0x004f +#define REG_LEDCFG REG_LEDCFG2 +#define REG_FSIMR 0x0050 +#define REG_FSISR 0x0054 +#define REG_HSIMR 0x0058 +#define REG_HSISR 0x005c +/* RTL8723 WIFI/BT/GPS Multi-Function GPIO Pin Control. */ +#define REG_GPIO_PIN_CTRL_2 0x0060 +/* RTL8723 WIFI/BT/GPS Multi-Function GPIO Select. */ +#define REG_GPIO_IO_SEL_2 0x0062 + +/* RTL8723 only WIFI/BT/GPS Multi-Function control source. */ +#define REG_MULTI_FUNC_CTRL 0x0068 + +#define MULTI_FN_WIFI_HW_PWRDOWN_EN BIT(0) /* Enable GPIO[9] as WiFi HW + powerdown source */ +#define MULTI_FN_WIFI_HW_PWRDOWN_SL BIT(1) /* WiFi HW powerdown polarity + control */ +#define MULTI_WIFI_FUNC_EN BIT(2) /* WiFi function enable */ + +#define MULTI_WIFI_HW_ROF_EN BIT(3) /* Enable GPIO[9] as WiFi RF HW + powerdown source */ +#define MULTI_BT_HW_PWRDOWN_EN BIT(16) /* Enable GPIO[11] as BT HW + powerdown source */ +#define MULTI_BT_HW_PWRDOWN_SL BIT(17) /* BT HW powerdown polarity + control */ +#define MULTI_BT_FUNC_EN BIT(18) /* BT function enable */ +#define MULTI_BT_HW_ROF_EN BIT(19) /* Enable GPIO[11] as BT/GPS + RF HW powerdown source */ +#define MULTI_GPS_HW_PWRDOWN_EN BIT(20) /* Enable GPIO[10] as GPS HW + powerdown source */ +#define MULTI_GPS_HW_PWRDOWN_SL BIT(21) /* GPS HW powerdown polarity + control */ +#define MULTI_GPS_FUNC_EN BIT(22) /* GPS function enable */ + + +#define REG_MCU_FW_DL 0x0080 +#define MCU_FW_DL_ENABLE BIT(0) +#define MCU_FW_DL_READY BIT(1) +#define MCU_FW_DL_CSUM_REPORT BIT(2) +#define MCU_MAC_INIT_READY BIT(3) +#define MCU_BB_INIT_READY BIT(4) +#define MCU_RF_INIT_READY BIT(5) +#define MCU_WINT_INIT_READY BIT(6) +#define MCU_FW_RAM_SEL BIT(7) /* 1: RAM, 0:ROM */ +#define MCU_CP_RESET BIT(23) + +#define REG_HMBOX_EXT_0 0x0088 +#define REG_HMBOX_EXT_1 0x008a +#define REG_HMBOX_EXT_2 0x008c +#define REG_HMBOX_EXT_3 0x008e +/* Host suspend counter on FPGA platform */ +#define REG_HOST_SUSP_CNT 0x00bc +/* Efuse access protection for RTL8723 */ +#define REG_EFUSE_ACCESS 0x00cf +#define REG_BIST_SCAN 0x00d0 +#define REG_BIST_RPT 0x00d4 +#define REG_BIST_ROM_RPT 0x00d8 +#define REG_USB_SIE_INTF 0x00e0 +#define REG_PCIE_MIO_INTF 0x00e4 +#define REG_PCIE_MIO_INTD 0x00e8 +#define REG_HPON_FSM 0x00ec +#define REG_SYS_CFG 0x00f0 +#define SYS_CFG_XCLK_VLD BIT(0) +#define SYS_CFG_ACLK_VLD BIT(1) +#define SYS_CFG_UCLK_VLD BIT(2) +#define SYS_CFG_PCLK_VLD BIT(3) +#define SYS_CFG_PCIRSTB BIT(4) +#define SYS_CFG_V15_VLD BIT(5) +#define SYS_CFG_TRP_B15V_EN BIT(7) +#define SYS_CFG_SIC_IDLE BIT(8) +#define SYS_CFG_BD_MAC2 BIT(9) +#define SYS_CFG_BD_MAC1 BIT(10) +#define SYS_CFG_IC_MACPHY_MODE BIT(11) +#define SYS_CFG_CHIP_VER (BIT(12) | BIT(13) | BIT(14) | BIT(15)) +#define SYS_CFG_BT_FUNC BIT(16) +#define SYS_CFG_VENDOR_ID BIT(19) +#define SYS_CFG_PAD_HWPD_IDN BIT(22) +#define SYS_CFG_TRP_VAUX_EN BIT(23) +#define SYS_CFG_TRP_BT_EN BIT(24) +#define SYS_CFG_BD_PKG_SEL BIT(25) +#define SYS_CFG_BD_HCI_SEL BIT(26) +#define SYS_CFG_TYPE_ID BIT(27) +#define SYS_CFG_RTL_ID BIT(23) /* TestChip ID, + 1:Test(RLE); 0:MP(RL) */ +#define SYS_CFG_SPS_SEL BIT(24) /* 1:LDO regulator mode; + 0:Switching regulator mode*/ +#define SYS_CFG_CHIP_VERSION_MASK 0xf000 /* Bit 12 - 15 */ +#define SYS_CFG_CHIP_VERSION_SHIFT 12 + + +#define REG_GPIO_OUTSTS 0x00f4 /* For RTL8723 only. */ +#define GPIO_EFS_HCI_SEL (BIT(0) | BIT(1)) +#define GPIO_PAD_HCI_SEL (BIT(2) | BIT(3)) +#define GPIO_HCI_SEL (BIT(4) | BIT(5)) +#define GPIO_PKG_SEL_HCI BIT(6) +#define GPIO_FEN_GPS BIT(7) +#define GPIO_FEN_BT BIT(8) +#define GPIO_FEN_WL BIT(9) +#define GPIO_FEN_PCI BIT(10) +#define GPIO_FEN_USB BIT(11) +#define GPIO_BTRF_HWPDN_N BIT(12) +#define GPIO_WLRF_HWPDN_N BIT(13) +#define GPIO_PDN_BT_N BIT(14) +#define GPIO_PDN_GPS_N BIT(15) +#define GPIO_BT_CTL_HWPDN BIT(16) +#define GPIO_GPS_CTL_HWPDN BIT(17) +#define GPIO_PPHY_SUSB BIT(20) +#define GPIO_UPHY_SUSB BIT(21) +#define GPIO_PCI_SUSEN BIT(22) +#define GPIO_USB_SUSEN BIT(23) +#define GPIO_RF_RL_ID (BIT(31) | BIT(30) | BIT(29) | BIT(28)) + +/* 0x0100 ~ 0x01FF MACTOP General Configuration */ +#define REG_CR 0x0100 +#define CR_HCI_TXDMA_ENABLE BIT(0) +#define CR_HCI_RXDMA_ENABLE BIT(1) +#define CR_TXDMA_ENABLE BIT(2) +#define CR_RXDMA_ENABLE BIT(3) +#define CR_PROTOCOL_ENABLE BIT(4) +#define CR_SCHEDULE_ENABLE BIT(5) +#define CR_MAC_TX_ENABLE BIT(6) +#define CR_MAC_RX_ENABLE BIT(7) +#define CR_SW_BEACON_ENABLE BIT(8) +#define CR_SECURITY_ENABLE BIT(9) +#define CR_CALTIMER_ENABLE BIT(10) + +/* Media Status Register */ +#define REG_MSR 0x0102 +#define MSR_LINKTYPE_MASK 0x3 +#define MSR_LINKTYPE_NONE 0x0 +#define MSR_LINKTYPE_ADHOC 0x1 +#define MSR_LINKTYPE_STATION 0x2 +#define MSR_LINKTYPE_AP 0x3 + +#define REG_PBP 0x0104 +#define PBP_PAGE_SIZE_RX_SHIFT 0 +#define PBP_PAGE_SIZE_TX_SHIFT 4 +#define PBP_PAGE_SIZE_64 0x0 +#define PBP_PAGE_SIZE_128 0x1 +#define PBP_PAGE_SIZE_256 0x2 +#define PBP_PAGE_SIZE_512 0x3 +#define PBP_PAGE_SIZE_1024 0x4 + +#define REG_TRXDMA_CTRL 0x010c +#define TRXDMA_CTRL_VOQ_SHIFT 4 +#define TRXDMA_CTRL_VIQ_SHIFT 6 +#define TRXDMA_CTRL_BEQ_SHIFT 8 +#define TRXDMA_CTRL_BKQ_SHIFT 10 +#define TRXDMA_CTRL_MGQ_SHIFT 12 +#define TRXDMA_CTRL_HIQ_SHIFT 14 +#define TRXDMA_QUEUE_LOW 1 +#define TRXDMA_QUEUE_NORMAL 2 +#define TRXDMA_QUEUE_HIGH 3 + + +#define REG_TRXFF_BNDY 0x0114 +#define REG_TRXFF_STATUS 0x0118 +#define REG_RXFF_PTR 0x011c +#define REG_HIMR 0x0120 +#define REG_HISR 0x0124 +#define REG_HIMRE 0x0128 +#define REG_HISRE 0x012c +#define REG_CPWM 0x012f +#define REG_FWIMR 0x0130 +#define REG_FWISR 0x0134 +#define REG_PKTBUF_DBG_CTRL 0x0140 +#define REG_PKTBUF_DBG_DATA_L 0x0144 +#define REG_PKTBUF_DBG_DATA_H 0x0148 + +#define REG_TC0_CTRL 0x0150 +#define REG_TC1_CTRL 0x0154 +#define REG_TC2_CTRL 0x0158 +#define REG_TC3_CTRL 0x015c +#define REG_TC4_CTRL 0x0160 +#define REG_TCUNIT_BASE 0x0164 +#define REG_MBIST_START 0x0174 +#define REG_MBIST_DONE 0x0178 +#define REG_MBIST_FAIL 0x017c +#define REG_C2HEVT_MSG_NORMAL 0x01a0 +#define REG_C2HEVT_CLEAR 0x01af +#define REG_C2HEVT_MSG_TEST 0x01b8 +#define REG_MCUTST_1 0x01c0 +#define REG_FMTHR 0x01c8 +#define REG_HMTFR 0x01cc +#define REG_HMBOX_0 0x01d0 +#define REG_HMBOX_1 0x01d4 +#define REG_HMBOX_2 0x01d8 +#define REG_HMBOX_3 0x01dc + +#define REG_LLT_INIT 0x01e0 +#define LLT_OP_INACTIVE 0x0 +#define LLT_OP_WRITE (0x1 << 30) +#define LLT_OP_READ (0x2 << 30) +#define LLT_OP_MASK (0x3 << 30) + +#define REG_BB_ACCEESS_CTRL 0x01e8 +#define REG_BB_ACCESS_DATA 0x01ec + +/* 0x0200 ~ 0x027F TXDMA Configuration */ +#define REG_RQPN 0x0200 +#define RQPN_HI_PQ_SHIFT 0 +#define RQPN_LO_PQ_SHIFT 8 +#define RQPN_NORM_PQ_SHIFT 16 +#define RQPN_LOAD BIT(31) + +#define REG_FIFOPAGE 0x0204 +#define REG_TDECTRL 0x0208 +#define REG_TXDMA_OFFSET_CHK 0x020c +#define REG_TXDMA_STATUS 0x0210 +#define REG_RQPN_NPQ 0x0214 + +/* 0x0280 ~ 0x02FF RXDMA Configuration */ +#define REG_RXDMA_AGG_PG_TH 0x0280 +#define REG_RXPKT_NUM 0x0284 +#define REG_RXDMA_STATUS 0x0288 + +#define REG_RF_BB_CMD_ADDR 0x02c0 +#define REG_RF_BB_CMD_DATA 0x02c4 + +/* spec version 11 */ +/* 0x0400 ~ 0x047F Protocol Configuration */ +#define REG_VOQ_INFORMATION 0x0400 +#define REG_VIQ_INFORMATION 0x0404 +#define REG_BEQ_INFORMATION 0x0408 +#define REG_BKQ_INFORMATION 0x040c +#define REG_MGQ_INFORMATION 0x0410 +#define REG_HGQ_INFORMATION 0x0414 +#define REG_BCNQ_INFORMATION 0x0418 + + +#define REG_CPU_MGQ_INFORMATION 0x041c +#define REG_FWHW_TXQ_CTRL 0x0420 +#define FWHW_TXQ_CTRL_AMPDU_RETRY BIT(7) +#define FWHW_TXQ_CTRL_XMIT_MGMT_ACK BIT(12) + +#define REG_HWSEQ_CTRL 0x0423 +#define REG_TXPKTBUF_BCNQ_BDNY 0x0424 +#define REG_TXPKTBUF_MGQ_BDNY 0x0425 +#define REG_LIFETIME_EN 0x0426 +#define REG_MULTI_BCNQ_OFFSET 0x0427 + +#define REG_SPEC_SIFS 0x0428 +#define SPEC_SIFS_CCK_MASK 0x00ff +#define SPEC_SIFS_CCK_SHIFT 0 +#define SPEC_SIFS_OFDM_MASK 0xff00 +#define SPEC_SIFS_OFDM_SHIFT 8 + +#define REG_RETRY_LIMIT 0x042a +#define RETRY_LIMIT_LONG_SHIFT 0 +#define RETRY_LIMIT_LONG_MASK 0x003f +#define RETRY_LIMIT_SHORT_SHIFT 8 +#define RETRY_LIMIT_SHORT_MASK 0x3f00 + +#define REG_DARFRC 0x0430 +#define REG_RARFRC 0x0438 +#define REG_RESPONSE_RATE_SET 0x0440 +#define RESPONSE_RATE_BITMAP_ALL 0xfffff +#define RESPONSE_RATE_RRSR_CCK_ONLY_1M 0xffff1 +#define RSR_1M BIT(0) +#define RSR_2M BIT(1) +#define RSR_5_5M BIT(2) +#define RSR_11M BIT(3) +#define RSR_6M BIT(4) +#define RSR_9M BIT(5) +#define RSR_12M BIT(6) +#define RSR_18M BIT(7) +#define RSR_24M BIT(8) +#define RSR_36M BIT(9) +#define RSR_48M BIT(10) +#define RSR_54M BIT(11) +#define RSR_MCS0 BIT(12) +#define RSR_MCS1 BIT(13) +#define RSR_MCS2 BIT(14) +#define RSR_MCS3 BIT(15) +#define RSR_MCS4 BIT(16) +#define RSR_MCS5 BIT(17) +#define RSR_MCS6 BIT(18) +#define RSR_MCS7 BIT(19) +#define RSR_RSC_LOWER_SUB_CHANNEL BIT(21) /* 0x200000 */ +#define RSR_RSC_UPPER_SUB_CHANNEL BIT(22) /* 0x400000 */ +#define RSR_RSC_BANDWIDTH_40M (RSR_RSC_UPPER_SUB_CHANNEL | \ + RSR_RSC_LOWER_SUB_CHANNEL) +#define RSR_ACK_SHORT_PREAMBLE BIT(23) + +#define REG_ARFR0 0x0444 +#define REG_ARFR1 0x0448 +#define REG_ARFR2 0x044c +#define REG_ARFR3 0x0450 +#define REG_AGGLEN_LMT 0x0458 +#define REG_AMPDU_MIN_SPACE 0x045c +#define REG_TXPKTBUF_WMAC_LBK_BF_HD 0x045d +#define REG_FAST_EDCA_CTRL 0x0460 +#define REG_RD_RESP_PKT_TH 0x0463 +#define REG_INIRTS_RATE_SEL 0x0480 +#define REG_INIDATA_RATE_SEL 0x0484 + + +#define REG_POWER_STATUS 0x04a4 +#define REG_POWER_STAGE1 0x04b4 +#define REG_POWER_STAGE2 0x04b8 +#define REG_PKT_VO_VI_LIFE_TIME 0x04c0 +#define REG_PKT_BE_BK_LIFE_TIME 0x04c2 +#define REG_STBC_SETTING 0x04c4 +#define REG_PROT_MODE_CTRL 0x04c8 +#define REG_MAX_AGGR_NUM 0x04ca +#define REG_RTS_MAX_AGGR_NUM 0x04cb +#define REG_BAR_MODE_CTRL 0x04cc +#define REG_RA_TRY_RATE_AGG_LMT 0x04cf +#define REG_NQOS_SEQ 0x04dc +#define REG_QOS_SEQ 0x04de +#define REG_NEED_CPU_HANDLE 0x04e0 +#define REG_PKT_LOSE_RPT 0x04e1 +#define REG_PTCL_ERR_STATUS 0x04e2 +#define REG_DUMMY 0x04fc + + +/* 0x0500 ~ 0x05FF EDCA Configuration */ +#define REG_EDCA_VO_PARAM 0x0500 +#define REG_EDCA_VI_PARAM 0x0504 +#define REG_EDCA_BE_PARAM 0x0508 +#define REG_EDCA_BK_PARAM 0x050c +#define EDCA_PARAM_ECW_MIN_SHIFT 8 +#define EDCA_PARAM_ECW_MAX_SHIFT 12 +#define EDCA_PARAM_TXOP_SHIFT 16 +#define REG_BEACON_TCFG 0x0510 +#define REG_PIFS 0x0512 +#define REG_RDG_PIFS 0x0513 +#define REG_SIFS_CCK 0x0514 +#define REG_SIFS_OFDM 0x0516 +#define REG_TSFTR_SYN_OFFSET 0x0518 +#define REG_AGGR_BREAK_TIME 0x051a +#define REG_SLOT 0x051b +#define REG_TX_PTCL_CTRL 0x0520 +#define REG_TXPAUSE 0x0522 +#define REG_DIS_TXREQ_CLR 0x0523 +#define REG_RD_CTRL 0x0524 +#define REG_TBTT_PROHIBIT 0x0540 +#define REG_RD_NAV_NXT 0x0544 +#define REG_NAV_PROT_LEN 0x0546 + +#define REG_BEACON_CTRL 0x0550 +#define REG_BEACON_CTRL_1 0x0551 +#define BEACON_ATIM BIT(0) +#define BEACON_CTRL_MBSSID BIT(1) +#define BEACON_CTRL_TX_BEACON_RPT BIT(2) +#define BEACON_FUNCTION_ENABLE BIT(3) +#define BEACON_DISABLE_TSF_UPDATE BIT(4) + +#define REG_MBID_NUM 0x0552 +#define REG_DUAL_TSF_RST 0x0553 + /* The same as REG_MBSSID_BCN_SPACE */ +#define REG_BCN_INTERVAL 0x0554 +#define REG_MBSSID_BCN_SPACE 0x0554 + +#define REG_DRIVER_EARLY_INT 0x0558 +#define DRIVER_EARLY_INT_TIME 5 + +#define REG_BEACON_DMA_TIME 0x0559 +#define BEACON_DMA_ATIME_INT_TIME 2 + +#define REG_ATIMWND 0x055a +#define REG_BCN_MAX_ERR 0x055d +#define REG_RXTSF_OFFSET_CCK 0x055e +#define REG_RXTSF_OFFSET_OFDM 0x055f +#define REG_TSFTR 0x0560 +#define REG_TSFTR1 0x0568 +#define REG_INIT_TSFTR 0x0564 +#define REG_ATIMWND_1 0x0570 +#define REG_PSTIMER 0x0580 +#define REG_TIMER0 0x0584 +#define REG_TIMER1 0x0588 +#define REG_ACM_HW_CTRL 0x05c0 +#define ACM_HW_CTRL_BK BIT(0) +#define ACM_HW_CTRL_BE BIT(1) +#define ACM_HW_CTRL_VI BIT(2) +#define ACM_HW_CTRL_VO BIT(3) +#define REG_ACM_RST_CTRL 0x05c1 +#define REG_ACMAVG 0x05c2 +#define REG_VO_ADMTIME 0x05c4 +#define REG_VI_ADMTIME 0x05c6 +#define REG_BE_ADMTIME 0x05c8 +#define REG_EDCA_RANDOM_GEN 0x05cc +#define REG_SCH_TXCMD 0x05d0 + +/* define REG_FW_TSF_SYNC_CNT 0x04a0 */ +#define REG_FW_RESET_TSF_CNT_1 0x05fc +#define REG_FW_RESET_TSF_CNT_0 0x05fd +#define REG_FW_BCN_DIS_CNT 0x05fe + +/* 0x0600 ~ 0x07FF WMAC Configuration */ +#define REG_APSD_CTRL 0x0600 +#define REG_BW_OPMODE 0x0603 +#define BW_OPMODE_20MHZ BIT(2) +#define BW_OPMODE_5G BIT(1) +#define BW_OPMODE_11J BIT(0) + +#define REG_TCR 0x0604 + +/* Receive Configuration Register */ +#define REG_RCR 0x0608 +#define RCR_ACCEPT_AP BIT(0) /* Accept all unicast packet */ +#define RCR_ACCEPT_PHYS_MATCH BIT(1) /* Accept phys match packet */ +#define RCR_ACCEPT_MCAST BIT(2) +#define RCR_ACCEPT_BCAST BIT(3) +#define RCR_ACCEPT_ADDR3 BIT(4) /* Accept address 3 match + packet */ +#define RCR_ACCEPT_PM BIT(5) /* Accept power management + packet */ +#define RCR_CHECK_BSSID_MATCH BIT(6) /* Accept BSSID match packet */ +#define RCR_CHECK_BSSID_BEACON BIT(7) /* Accept BSSID match packet + (Rx beacon, probe rsp) */ +#define RCR_ACCEPT_CRC32 BIT(8) /* Accept CRC32 error packet */ +#define RCR_ACCEPT_ICV BIT(9) /* Accept ICV error packet */ +#define RCR_ACCEPT_DATA_FRAME BIT(11) +#define RCR_ACCEPT_CTRL_FRAME BIT(12) +#define RCR_ACCEPT_MGMT_FRAME BIT(13) +#define RCR_HTC_LOC_CTRL BIT(14) /* MFC<--HTC=1 MFC-->HTC=0 */ +#define RCR_MFBEN BIT(22) +#define RCR_LSIGEN BIT(23) +#define RCR_MULTI_BSSID_ENABLE BIT(24) /* Enable Multiple BssId */ +#define RCR_ACCEPT_BA_SSN BIT(27) /* Accept BA SSN */ +#define RCR_APPEND_PHYSTAT BIT(28) +#define RCR_APPEND_ICV BIT(29) +#define RCR_APPEND_MIC BIT(30) +#define RCR_APPEND_FCS BIT(31) /* WMAC append FCS after */ + +#define REG_RX_PKT_LIMIT 0x060c +#define REG_RX_DLK_TIME 0x060d +#define REG_RX_DRVINFO_SZ 0x060f + +#define REG_MACID 0x0610 +#define REG_BSSID 0x0618 +#define REG_MAR 0x0620 +#define REG_MBIDCAMCFG 0x0628 + +#define REG_USTIME_EDCA 0x0638 +#define REG_MAC_SPEC_SIFS 0x063a + +/* 20100719 Joseph: Hardware register definition change. (HW datasheet v54) */ + /* [15:8]SIFS_R2T_OFDM, [7:0]SIFS_R2T_CCK */ +#define REG_R2T_SIFS 0x063c + /* [15:8]SIFS_T2T_OFDM, [7:0]SIFS_T2T_CCK */ +#define REG_T2T_SIFS 0x063e +#define REG_ACKTO 0x0640 +#define REG_CTS2TO 0x0641 +#define REG_EIFS 0x0642 + +/* WMA, BA, CCX */ +#define REG_NAV_CTRL 0x0650 +/* In units of 128us */ +#define REG_NAV_UPPER 0x0652 +#define NAV_UPPER_UNIT 128 + +#define REG_BACAMCMD 0x0654 +#define REG_BACAMCONTENT 0x0658 +#define REG_LBDLY 0x0660 +#define REG_FWDLY 0x0661 +#define REG_RXERR_RPT 0x0664 +#define REG_WMAC_TRXPTCL_CTL 0x0668 + + +/* Security */ +#define REG_CAM_CMD 0x0670 +#define CAM_CMD_POLLING BIT(31) +#define CAM_CMD_WRITE BIT(16) +#define CAM_CMD_KEY_SHIFT 3 +#define REG_CAM_WRITE 0x0674 +#define CAM_WRITE_VALID BIT(15) +#define REG_CAM_READ 0x0678 +#define REG_CAM_DEBUG 0x067c +#define REG_SECURITY_CFG 0x0680 +#define SEC_CFG_TX_USE_DEFKEY BIT(0) +#define SEC_CFG_RX_USE_DEFKEY BIT(1) +#define SEC_CFG_TX_SEC_ENABLE BIT(2) +#define SEC_CFG_RX_SEC_ENABLE BIT(3) +#define SEC_CFG_SKByA2 BIT(4) +#define SEC_CFG_NO_SKMC BIT(5) +#define SEC_CFG_TXBC_USE_DEFKEY BIT(6) +#define SEC_CFG_RXBC_USE_DEFKEY BIT(7) + +/* Power */ +#define REG_WOW_CTRL 0x0690 +#define REG_PSSTATUS 0x0691 +#define REG_PS_RX_INFO 0x0692 +#define REG_LPNAV_CTRL 0x0694 +#define REG_WKFMCAM_CMD 0x0698 +#define REG_WKFMCAM_RWD 0x069c +#define REG_RXFLTMAP0 0x06a0 +#define REG_RXFLTMAP1 0x06a2 +#define REG_RXFLTMAP2 0x06a4 +#define REG_BCN_PSR_RPT 0x06a8 +#define REG_CALB32K_CTRL 0x06ac +#define REG_PKT_MON_CTRL 0x06b4 +#define REG_BT_COEX_TABLE 0x06c0 +#define REG_WMAC_RESP_TXINFO 0x06d8 + +#define REG_MACID1 0x0700 +#define REG_BSSID1 0x0708 + +#define REG_FPGA0_RF_MODE 0x0800 +#define FPGA_RF_MODE BIT(0) +#define FPGA_RF_MODE_JAPAN BIT(1) +#define FPGA_RF_MODE_CCK BIT(24) +#define FPGA_RF_MODE_OFDM BIT(25) + +#define REG_FPGA0_TXINFO 0x0804 +#define REG_FPGA0_PSD_FUNC 0x0808 +#define REG_FPGA0_TX_GAIN 0x080c +#define REG_FPGA0_POWER_SAVE 0x0818 +#define FPGA0_PS_LOWER_CHANNEL BIT(26) +#define FPGA0_PS_UPPER_CHANNEL BIT(27) + +#define REG_FPGA0_XA_HSSI_PARM1 0x0820 /* RF 3 wire register */ +#define FPGA0_HSSI_PARM1_PI BIT(8) +#define REG_FPGA0_XA_HSSI_PARM2 0x0824 +#define REG_FPGA0_XB_HSSI_PARM1 0x0828 +#define REG_FPGA0_XB_HSSI_PARM2 0x082c +#define FPGA0_HSSI_3WIRE_DATA_LEN 0x800 +#define FPGA0_HSSI_3WIRE_ADDR_LEN 0x400 +#define FPGA0_HSSI_PARM2_ADDR_SHIFT 23 +#define FPGA0_HSSI_PARM2_ADDR_MASK 0x7f800000 /* 0xff << 23 */ +#define FPGA0_HSSI_PARM2_CCK_HIGH_PWR BIT(9) +#define FPGA0_HSSI_PARM2_EDGE_READ BIT(31) + +#define REG_TX_AGC_B_RATE18_06 0x0830 +#define REG_TX_AGC_B_RATE54_24 0x0834 +#define REG_TX_AGC_B_CCK1_55_MCS32 0x0838 +#define REG_TX_AGC_B_MCS03_MCS00 0x083c + +#define REG_FPGA0_XA_LSSI_PARM 0x0840 +#define REG_FPGA0_XB_LSSI_PARM 0x0844 +#define FPGA0_LSSI_PARM_ADDR_SHIFT 20 +#define FPGA0_LSSI_PARM_ADDR_MASK 0x0ff00000 +#define FPGA0_LSSI_PARM_DATA_MASK 0x000fffff + +#define REG_TX_AGC_B_MCS07_MCS04 0x0848 +#define REG_TX_AGC_B_MCS11_MCS08 0x084c + +#define REG_FPGA0_XCD_SWITCH_CTRL 0x085c + +#define REG_FPGA0_XA_RF_INT_OE 0x0860 /* RF Channel switch */ +#define REG_FPGA0_XB_RF_INT_OE 0x0864 +#define FPGA0_INT_OE_ANTENNA_AB_OPEN 0x000 +#define FPGA0_INT_OE_ANTENNA_A 0x100 +#define FPGA0_INT_OE_ANTENNA_B 0x200 +#define FPGA0_INT_OE_ANTENNA_MASK 0x300 + +#define REG_TX_AGC_B_MCS15_MCS12 0x0868 +#define REG_TX_AGC_B_CCK11_A_CCK2_11 0x086c + +#define REG_FPGA0_XAB_RF_SW_CTRL 0x0870 +#define REG_FPGA0_XA_RF_SW_CTRL 0x0870 /* 16 bit */ +#define REG_FPGA0_XB_RF_SW_CTRL 0x0872 /* 16 bit */ +#define REG_FPGA0_XCD_RF_SW_CTRL 0x0874 +#define REG_FPGA0_XC_RF_SW_CTRL 0x0874 /* 16 bit */ +#define REG_FPGA0_XD_RF_SW_CTRL 0x0876 /* 16 bit */ +#define FPGA0_RF_3WIRE_DATA BIT(0) +#define FPGA0_RF_3WIRE_CLOC BIT(1) +#define FPGA0_RF_3WIRE_LOAD BIT(2) +#define FPGA0_RF_3WIRE_RW BIT(3) +#define FPGA0_RF_3WIRE_MASK 0xf +#define FPGA0_RF_RFENV BIT(4) +#define FPGA0_RF_TRSW BIT(5) /* Useless now */ +#define FPGA0_RF_TRSWB BIT(6) +#define FPGA0_RF_ANTSW BIT(8) +#define FPGA0_RF_ANTSWB BIT(9) +#define FPGA0_RF_PAPE BIT(10) +#define FPGA0_RF_PAPE5G BIT(11) +#define FPGA0_RF_BD_CTRL_SHIFT 16 + +#define REG_FPGA0_XAB_RF_PARM 0x0878 /* Antenna select path in ODM */ +#define REG_FPGA0_XA_RF_PARM 0x0878 /* 16 bit */ +#define REG_FPGA0_XB_RF_PARM 0x087a /* 16 bit */ +#define REG_FPGA0_XCD_RF_PARM 0x087c +#define REG_FPGA0_XC_RF_PARM 0x087c /* 16 bit */ +#define REG_FPGA0_XD_RF_PARM 0x087e /* 16 bit */ + +#define REG_FPGA0_ANALOG1 0x0880 +#define REG_FPGA0_ANALOG2 0x0884 +#define REG_FPGA0_ANALOG3 0x0888 +#define REG_FPGA0_ANALOG4 0x088c + +#define REG_FPGA0_XA_LSSI_READBACK 0x08a0 /* Tranceiver LSSI Readback */ +#define REG_FPGA0_XB_LSSI_READBACK 0x08a4 +#define REG_HSPI_XA_READBACK 0x08b8 /* Transceiver A HSPI read */ +#define REG_HSPI_XB_READBACK 0x08bc /* Transceiver B HSPI read */ + +#define REG_FPGA1_RF_MODE 0x0900 + +#define REG_CCK0_SYSTEM 0x0a00 +#define CCK0_SIDEBAND BIT(4) + +#define REG_CONFIG_ANT_A 0x0b68 +#define REG_CONFIG_ANT_B 0x0b6c + +#define REG_OFDM0_TRX_PATH_ENABLE 0x0c04 +#define OFDM0_RF_PATH_RX_MASK 0x0f + +#define REG_OFDM0_TR_MUX_PAR 0x0c08 + +#define REG_OFDM0_XA_RX_IQ_IMBALANCE 0x0c14 +#define REG_OFDM0_XB_RX_IQ_IMBALANCE 0x0c1c + +#define REG_OFDM0_ENERGY_CCA_THRES 0x0c4c + +#define REG_OFDM0_XA_AGC_CORE1 0x0c50 +#define REG_OFDM0_XA_AGC_CORE2 0x0c54 +#define REG_OFDM0_XB_AGC_CORE1 0x0c58 +#define REG_OFDM0_XB_AGC_CORE2 0x0c5c +#define REG_OFDM0_XC_AGC_CORE1 0x0c60 +#define REG_OFDM0_XC_AGC_CORE2 0x0c64 +#define REG_OFDM0_XD_AGC_CORE1 0x0c68 +#define REG_OFDM0_XD_AGC_CORE2 0x0c6c +#define OFDM0_X_AGC_CORE1_IGI_MASK 0x0000007F + +#define REG_OFDM0_AGCR_SSI_TABLE 0x0c78 + +#define REG_OFDM0_XA_TX_IQ_IMBALANCE 0x0c80 +#define REG_OFDM0_XB_TX_IQ_IMBALANCE 0x0c88 +#define REG_OFDM0_XC_TX_IQ_IMBALANCE 0x0c90 +#define REG_OFDM0_XD_TX_IQ_IMBALANCE 0x0c98 + +#define REG_OFDM0_XC_TX_AFE 0x0c94 +#define REG_OFDM0_XD_TX_AFE 0x0c9c + +#define REG_OFDM0_RX_IQ_EXT_ANTA 0x0ca0 + +#define REG_OFDM1_LSTF 0x0d00 +#define OFDM_CONTINUE_TX 0x10000000 +#define OFDM_SINGLE_CARRIER 0x20000000 +#define OFDM_SINGLE_TONE 0x40000000 +#define OFDM_LSTF_MASK 0x70000000 + +#define REG_OFDM1_TRX_PATH_ENABLE 0x0d04 + +#define REG_TX_AGC_A_RATE18_06 0x0e00 +#define REG_TX_AGC_A_RATE54_24 0x0e04 +#define REG_TX_AGC_A_CCK1_MCS32 0x0e08 +#define REG_TX_AGC_A_MCS03_MCS00 0x0e10 +#define REG_TX_AGC_A_MCS07_MCS04 0x0e14 +#define REG_TX_AGC_A_MCS11_MCS08 0x0e18 +#define REG_TX_AGC_A_MCS15_MCS12 0x0e1c + +#define REG_FPGA0_IQK 0x0e28 + +#define REG_TX_IQK_TONE_A 0x0e30 +#define REG_RX_IQK_TONE_A 0x0e34 +#define REG_TX_IQK_PI_A 0x0e38 +#define REG_RX_IQK_PI_A 0x0e3c + +#define REG_TX_IQK 0x0e40 +#define REG_RX_IQK 0x0e44 +#define REG_IQK_AGC_PTS 0x0e48 +#define REG_IQK_AGC_RSP 0x0e4c +#define REG_TX_IQK_TONE_B 0x0e50 +#define REG_RX_IQK_TONE_B 0x0e54 +#define REG_TX_IQK_PI_B 0x0e58 +#define REG_RX_IQK_PI_B 0x0e5c +#define REG_IQK_AGC_CONT 0x0e60 + +#define REG_BLUETOOTH 0x0e6c +#define REG_RX_WAIT_CCA 0x0e70 +#define REG_TX_CCK_RFON 0x0e74 +#define REG_TX_CCK_BBON 0x0e78 +#define REG_TX_OFDM_RFON 0x0e7c +#define REG_TX_OFDM_BBON 0x0e80 +#define REG_TX_TO_RX 0x0e84 +#define REG_TX_TO_TX 0x0e88 +#define REG_RX_CCK 0x0e8c + +#define REG_TX_POWER_BEFORE_IQK_A 0x0e94 +#define REG_TX_POWER_AFTER_IQK_A 0x0e9c + +#define REG_RX_POWER_BEFORE_IQK_A 0x0ea0 +#define REG_RX_POWER_BEFORE_IQK_A_2 0x0ea4 +#define REG_RX_POWER_AFTER_IQK_A 0x0ea8 +#define REG_RX_POWER_AFTER_IQK_A_2 0x0eac + +#define REG_TX_POWER_BEFORE_IQK_B 0x0eb4 +#define REG_TX_POWER_AFTER_IQK_B 0x0ebc + +#define REG_RX_POWER_BEFORE_IQK_B 0x0ec0 +#define REG_RX_POWER_BEFORE_IQK_B_2 0x0ec4 +#define REG_RX_POWER_AFTER_IQK_B 0x0ec8 +#define REG_RX_POWER_AFTER_IQK_B_2 0x0ecc + +#define REG_RX_OFDM 0x0ed0 +#define REG_RX_WAIT_RIFS 0x0ed4 +#define REG_RX_TO_RX 0x0ed8 +#define REG_STANDBY 0x0edc +#define REG_SLEEP 0x0ee0 +#define REG_PMPD_ANAEN 0x0eec + +#define REG_8723A_FW_START_ADDRESS 0x1000 + +#define REG_USB_INFO 0xfe17 +#define REG_USB_HIMR 0xfe38 +#define USB_HIMR_TIMEOUT2 BIT(31) +#define USB_HIMR_TIMEOUT1 BIT(30) +#define USB_HIMR_PSTIMEOUT BIT(29) +#define USB_HIMR_GTINT4 BIT(28) +#define USB_HIMR_GTINT3 BIT(27) +#define USB_HIMR_TXBCNERR BIT(26) +#define USB_HIMR_TXBCNOK BIT(25) +#define USB_HIMR_TSF_BIT32_TOGGLE BIT(24) +#define USB_HIMR_BCNDMAINT3 BIT(23) +#define USB_HIMR_BCNDMAINT2 BIT(22) +#define USB_HIMR_BCNDMAINT1 BIT(21) +#define USB_HIMR_BCNDMAINT0 BIT(20) +#define USB_HIMR_BCNDOK3 BIT(19) +#define USB_HIMR_BCNDOK2 BIT(18) +#define USB_HIMR_BCNDOK1 BIT(17) +#define USB_HIMR_BCNDOK0 BIT(16) +#define USB_HIMR_HSISR_IND BIT(15) +#define USB_HIMR_BCNDMAINT_E BIT(14) +/* RSVD BIT(13) */ +#define USB_HIMR_CTW_END BIT(12) +/* RSVD BIT(11) */ +#define USB_HIMR_C2HCMD BIT(10) +#define USB_HIMR_CPWM2 BIT(9) +#define USB_HIMR_CPWM BIT(8) +#define USB_HIMR_HIGHDOK BIT(7) /* High Queue DMA OK + Interrupt */ +#define USB_HIMR_MGNTDOK BIT(6) /* Management Queue DMA OK + Interrupt */ +#define USB_HIMR_BKDOK BIT(5) /* AC_BK DMA OK Interrupt */ +#define USB_HIMR_BEDOK BIT(4) /* AC_BE DMA OK Interrupt */ +#define USB_HIMR_VIDOK BIT(3) /* AC_VI DMA OK Interrupt */ +#define USB_HIMR_VODOK BIT(2) /* AC_VO DMA Interrupt */ +#define USB_HIMR_RDU BIT(1) /* Receive Descriptor + Unavailable */ +#define USB_HIMR_ROK BIT(0) /* Receive DMA OK Interrupt */ + +#define REG_USB_SPECIAL_OPTION 0xfe55 +#define REG_USB_DMA_AGG_TO 0xfe5b +#define REG_USB_AGG_TO 0xfe5c +#define REG_USB_AGG_TH 0xfe5d + +#define REG_NORMAL_SIE_VID 0xfe60 /* 0xfe60 - 0xfe61 */ +#define REG_NORMAL_SIE_PID 0xfe62 /* 0xfe62 - 0xfe63 */ +#define REG_NORMAL_SIE_OPTIONAL 0xfe64 +#define REG_NORMAL_SIE_EP 0xfe65 /* 0xfe65 - 0xfe67 */ +#define REG_NORMAL_SIE_EP_TX 0xfe66 +#define NORMAL_SIE_EP_TX_HIGH_MASK 0x000f +#define NORMAL_SIE_EP_TX_NORMAL_MASK 0x00f0 +#define NORMAL_SIE_EP_TX_LOW_MASK 0x0f00 + +#define REG_NORMAL_SIE_PHY 0xfe68 /* 0xfe68 - 0xfe6b */ +#define REG_NORMAL_SIE_OPTIONAL2 0xfe6c +#define REG_NORMAL_SIE_GPS_EP 0xfe6d /* RTL8723 only */ +#define REG_NORMAL_SIE_MAC_ADDR 0xfe70 /* 0xfe70 - 0xfe75 */ +#define REG_NORMAL_SIE_STRING 0xfe80 /* 0xfe80 - 0xfedf */ + +/* RF6052 registers */ +#define RF6052_REG_AC 0x00 +#define RF6052_REG_IQADJ_G1 0x01 +#define RF6052_REG_IQADJ_G2 0x02 +#define RF6052_REG_BS_PA_APSET_G1_G4 0x03 +#define RF6052_REG_BS_PA_APSET_G5_G8 0x04 +#define RF6052_REG_POW_TRSW 0x05 +#define RF6052_REG_GAIN_RX 0x06 +#define RF6052_REG_GAIN_TX 0x07 +#define RF6052_REG_TXM_IDAC 0x08 +#define RF6052_REG_IPA_G 0x09 +#define RF6052_REG_TXBIAS_G 0x0a +#define RF6052_REG_TXPA_AG 0x0b +#define RF6052_REG_IPA_A 0x0c +#define RF6052_REG_TXBIAS_A 0x0d +#define RF6052_REG_BS_PA_APSET_G9_G11 0x0e +#define RF6052_REG_BS_IQGEN 0x0f +#define RF6052_REG_MODE1 0x10 +#define RF6052_REG_MODE2 0x11 +#define RF6052_REG_RX_AGC_HP 0x12 +#define RF6052_REG_TX_AGC 0x13 +#define RF6052_REG_BIAS 0x14 +#define RF6052_REG_IPA 0x15 +#define RF6052_REG_TXBIAS 0x16 +#define RF6052_REG_POW_ABILITY 0x17 +#define RF6052_REG_MODE_AG 0x18 /* RF channel and BW switch */ +#define MODE_AG_CHANNEL_MASK 0x3ff +#define MODE_AG_CHANNEL_20MHZ BIT(10) + +#define RF6052_REG_TOP 0x19 +#define RF6052_REG_RX_G1 0x1a +#define RF6052_REG_RX_G2 0x1b +#define RF6052_REG_RX_BB2 0x1c +#define RF6052_REG_RX_BB1 0x1d +#define RF6052_REG_RCK1 0x1e +#define RF6052_REG_RCK2 0x1f +#define RF6052_REG_TX_G1 0x20 +#define RF6052_REG_TX_G2 0x21 +#define RF6052_REG_TX_G3 0x22 +#define RF6052_REG_TX_BB1 0x23 +#define RF6052_REG_T_METER 0x24 +#define RF6052_REG_SYN_G1 0x25 /* RF TX Power control */ +#define RF6052_REG_SYN_G2 0x26 /* RF TX Power control */ +#define RF6052_REG_SYN_G3 0x27 /* RF TX Power control */ +#define RF6052_REG_SYN_G4 0x28 /* RF TX Power control */ +#define RF6052_REG_SYN_G5 0x29 /* RF TX Power control */ +#define RF6052_REG_SYN_G6 0x2a /* RF TX Power control */ +#define RF6052_REG_SYN_G7 0x2b /* RF TX Power control */ +#define RF6052_REG_SYN_G8 0x2c /* RF TX Power control */ + +#define RF6052_REG_RCK_OS 0x30 /* RF TX PA control */ + +#define RF6052_REG_TXPA_G1 0x31 /* RF TX PA control */ +#define RF6052_REG_TXPA_G2 0x32 /* RF TX PA control */ +#define RF6052_REG_TXPA_G3 0x33 /* RF TX PA control */ -- 2.1.0 ^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-03-23 20:25 ` [PATCH 1/1] " Jes.Sorensen @ 2015-03-23 22:51 ` Joe Perches 2015-03-24 1:25 ` Jes Sorensen 2015-04-28 8:37 ` Kalle Valo 1 sibling, 1 reply; 35+ messages in thread From: Joe Perches @ 2015-03-23 22:51 UTC (permalink / raw) To: Jes.Sorensen; +Cc: linux-wireless, Larry.Finger On Mon, 2015-03-23 at 16:25 -0400, Jes.Sorensen@redhat.com wrote: > From: Jes Sorensen <Jes.Sorensen@redhat.com> > > This is an alternate driver for the Realtek 8723AU (rtl8723au) written > from scratch utilizing the mac80211 stack. trivia: > diff --git a/drivers/net/wireless/rtl8xxxu.c b/drivers/net/wireless/rtl8xxxu.c [ > +#define USB_VENDER_ID_REALTEK 0x0BDA realtek can't spell. VENDOR > +/* Minimum IEEE80211_MAX_FRAME_LEN */ > +#define RTL_RX_BUFFER_SIZE IEEE80211_MAX_FRAME_LEN > + > +static struct usb_device_id dev_table[] = { const > + {USB_DEVICE_AND_INTERFACE_INFO(USB_VENDER_ID_REALTEK, 0x8724, > + 0xff, 0xff, 0xff)}, > + {USB_DEVICE_AND_INTERFACE_INFO(USB_VENDER_ID_REALTEK, 0x1724, > + 0xff, 0xff, 0xff)}, > + {USB_DEVICE_AND_INTERFACE_INFO(USB_VENDER_ID_REALTEK, 0x0724, > + 0xff, 0xff, 0xff)}, > + { } > +}; > +static int rtl8xxxu_read_efuse(struct rtl8xxxu_priv *priv) > +{ [] > + while (efuse_addr < EFUSE_REAL_CONTENT_LEN_8723A) { > + ret = rtl8xxxu_read_efuse8(priv, efuse_addr++, &header); > + if (ret || header == 0xff) > + goto exit; break and no exit label would be more common [] > +exit: > + rtl8723au_write8(priv, REG_EFUSE_ACCESS, EFUSE_ACCESS_DISABLE); > + > + if (priv->efuse_wifi.efuse.rtl_id != cpu_to_le16(0x8129)) > + ret = EINVAL; -EINVAL > +static bool rtl8xxxu_simularity_compare(struct rtl8xxxu_priv *priv, > + int result[][8], int c1, int c2) Looking through git history, simularity seems to be used because realtek can't spell. ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-03-23 22:51 ` Joe Perches @ 2015-03-24 1:25 ` Jes Sorensen 0 siblings, 0 replies; 35+ messages in thread From: Jes Sorensen @ 2015-03-24 1:25 UTC (permalink / raw) To: Joe Perches; +Cc: linux-wireless, Larry.Finger Joe Perches <joe@perches.com> writes: > On Mon, 2015-03-23 at 16:25 -0400, Jes.Sorensen@redhat.com wrote: >> From: Jes Sorensen <Jes.Sorensen@redhat.com> >> >> This is an alternate driver for the Realtek 8723AU (rtl8723au) written >> from scratch utilizing the mac80211 stack. > > trivia: > >> diff --git a/drivers/net/wireless/rtl8xxxu.c b/drivers/net/wireless/rtl8xxxu.c > [ >> +#define USB_VENDER_ID_REALTEK 0x0BDA > > realtek can't spell. VENDOR Rather minor, but sure, I'll fix that up. >> +/* Minimum IEEE80211_MAX_FRAME_LEN */ >> +#define RTL_RX_BUFFER_SIZE IEEE80211_MAX_FRAME_LEN >> + >> +static struct usb_device_id dev_table[] = { > > const > >> + {USB_DEVICE_AND_INTERFACE_INFO(USB_VENDER_ID_REALTEK, 0x8724, >> + 0xff, 0xff, 0xff)}, >> + {USB_DEVICE_AND_INTERFACE_INFO(USB_VENDER_ID_REALTEK, 0x1724, >> + 0xff, 0xff, 0xff)}, >> + {USB_DEVICE_AND_INTERFACE_INFO(USB_VENDER_ID_REALTEK, 0x0724, >> + 0xff, 0xff, 0xff)}, >> + { } >> +}; > >> +static int rtl8xxxu_read_efuse(struct rtl8xxxu_priv *priv) >> +{ > > [] > >> + while (efuse_addr < EFUSE_REAL_CONTENT_LEN_8723A) { >> + ret = rtl8xxxu_read_efuse8(priv, efuse_addr++, &header); >> + if (ret || header == 0xff) >> + goto exit; > > break and no exit label would be more common > > [] > >> +exit: >> + rtl8723au_write8(priv, REG_EFUSE_ACCESS, EFUSE_ACCESS_DISABLE); >> + >> + if (priv->efuse_wifi.efuse.rtl_id != cpu_to_le16(0x8129)) >> + ret = EINVAL; > > -EINVAL This needs to be fixed, however the return code isn't actually checked at present, which is a bigger issue. It's a highly unlikely error condition, so it can easily be fixed in a follow-on patch. >> +static bool rtl8xxxu_simularity_compare(struct rtl8xxxu_priv *priv, >> + int result[][8], int c1, int c2) > > Looking through git history, simularity seems to be used > because realtek can't spell. It might be the case, but until I see some actual evidence of this, I am not going to spend cycles on it. It's hardly something justifying the patch noise in the first place. Jes ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-03-23 20:25 ` [PATCH 1/1] " Jes.Sorensen 2015-03-23 22:51 ` Joe Perches @ 2015-04-28 8:37 ` Kalle Valo 2015-04-28 12:55 ` Kalle Valo 2015-04-28 14:27 ` Jes Sorensen 1 sibling, 2 replies; 35+ messages in thread From: Kalle Valo @ 2015-04-28 8:37 UTC (permalink / raw) To: Jes.Sorensen; +Cc: linux-wireless, Larry.Finger Jes.Sorensen@redhat.com writes: > From: Jes Sorensen <Jes.Sorensen@redhat.com> > > This is an alternate driver for the Realtek 8723AU (rtl8723au) written > from scratch utilizing the mac80211 stack. > > After spending months cleaning up the vendor provided rtl8723au > driver, which comes with it's own 802.11 stack included, I decided to > rewrite this driver from the bottom up. Where is the vendor driver available, in staging or somewhere else? It would be good to mention that in the commit log. > Many thanks to Johannes Berg for 802.11 insights and help and Larry > Finger for help with the vendor driver. > > The full git log for the development of this driver can be found here: > git git://git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git > branch rtl8723au-mac80211 > > This driver is still experimental, but has proven to be rather stable > for me. It lacks some features found in the staging driver, such as > power management, AMPDU, and 40MHz channel support. In addition there > is no AP and monitor support at this point. It's nice to document in the commit log what features are verified to be working. Also I see incosistencies with driver naming, in some places I see RTL8723au and elsewhere rtl8xxxu. And commit log title could be improved, for example something like "rtl8xxxu: new wireless mac80211 driver for rtl8723au chipsets" And I would like to understand the relationship with rtlwifi, can you describe that a bit more? Why a separate driver instead of extending rtlwifi? When I look at the directory drivers/net/wireless/rtlwifi/rtl8723ae I'm confused what's the bigger plan here. Larry? > MAINTAINERS | 8 + > drivers/net/wireless/Kconfig | 19 + > drivers/net/wireless/Makefile | 2 + > drivers/net/wireless/rtl8xxxu.c | 4500 ++++++++++++++++++++++++++++++++++ > drivers/net/wireless/rtl8xxxu.h | 497 ++++ > drivers/net/wireless/rtl8xxxu_regs.h | 941 +++++++ I think someone else already mentioned, but it would be better that has it's own directory. Or should this actually be under rtlwifi directory? > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -8297,6 +8297,14 @@ S: Maintained > F: drivers/net/wireless/rtlwifi/ > F: drivers/net/wireless/rtlwifi/rtl8192ce/ > > +RTL8XXXU WIRELESS DRIVER (rtl8xxxu) > +M: Jes Sorensen <Jes.Sorensen@redhat.com> > +L: linux-wireless@vger.kernel.org > +W: http://intellinuxwireless.org The link cannot be right. > +T: git git://git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git rtl8723au-mac80211 I doubt that this will be in active enough development that a separate git tree is needed. wireless-drivers trees should be enough and this line can be removed. I'll do more detailed code review later, but my first impression was that there was a lot of #if 0 code which is frowned upon. And I pushed this to wireless-drivers-next.git pending branch so that kbuild will run it's tests with this driver. -- Kalle Valo ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-04-28 8:37 ` Kalle Valo @ 2015-04-28 12:55 ` Kalle Valo 2015-04-28 14:27 ` Jes Sorensen 1 sibling, 0 replies; 35+ messages in thread From: Kalle Valo @ 2015-04-28 12:55 UTC (permalink / raw) To: Jes.Sorensen; +Cc: linux-wireless, Larry.Finger Kalle Valo <kvalo@codeaurora.org> writes: > And I pushed this to wireless-drivers-next.git pending branch so that > kbuild will run it's tests with this driver. There was one warning from kbuild, but I didn't check if it's just a false warning or what: drivers/net/wireless/rtl8xxxu.c: In function 'rtl8723a_phy_lc_calibrate': drivers/net/wireless/rtl8xxxu.c:2457: warning: 'rf_amode' may be used uninitialized in this function -- Kalle Valo ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-04-28 8:37 ` Kalle Valo 2015-04-28 12:55 ` Kalle Valo @ 2015-04-28 14:27 ` Jes Sorensen 2015-04-28 15:15 ` Larry Finger 2015-09-06 13:38 ` Kalle Valo 1 sibling, 2 replies; 35+ messages in thread From: Jes Sorensen @ 2015-04-28 14:27 UTC (permalink / raw) To: Kalle Valo; +Cc: linux-wireless, Larry.Finger Kalle Valo <kvalo@codeaurora.org> writes: > Jes.Sorensen@redhat.com writes: > >> From: Jes Sorensen <Jes.Sorensen@redhat.com> >> >> This is an alternate driver for the Realtek 8723AU (rtl8723au) written >> from scratch utilizing the mac80211 stack. >> >> After spending months cleaning up the vendor provided rtl8723au >> driver, which comes with it's own 802.11 stack included, I decided to >> rewrite this driver from the bottom up. > > Where is the vendor driver available, in staging or somewhere else? It > would be good to mention that in the commit log. Hi Kalle, Thanks for the feedback, the vendor driver is drivers/staging/rtl8723au/ >> Many thanks to Johannes Berg for 802.11 insights and help and Larry >> Finger for help with the vendor driver. >> >> The full git log for the development of this driver can be found here: >> git git://git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git >> branch rtl8723au-mac80211 >> >> This driver is still experimental, but has proven to be rather stable >> for me. It lacks some features found in the staging driver, such as >> power management, AMPDU, and 40MHz channel support. In addition there >> is no AP and monitor support at this point. > > It's nice to document in the commit log what features are verified to be > working. > > Also I see incosistencies with driver naming, in some places I see > RTL8723au and elsewhere rtl8xxxu. And commit log title could be > improved, for example something like "rtl8xxxu: new wireless mac80211 > driver for rtl8723au chipsets" The reason for the inconsistencies is that I anticipate adding support for more chips in the future, so the 8723au named functions are ones that are more likely to be chip specific. > And I would like to understand the relationship with rtlwifi, can you > describe that a bit more? Why a separate driver instead of extending > rtlwifi? When I look at the directory drivers/net/wireless/rtlwifi/rtl8723ae > I'm confused what's the bigger plan here. Larry? I looked at rtlwifi and while it has changed a lot from the vendor driver, it still has a strong legacy of the vendor codebase. I could have opted to do a smaller mini-driver for rtlwifi, but I felt it was better to start from scratch and write the driver from the bottom up for Linux. >> MAINTAINERS | 8 + >> drivers/net/wireless/Kconfig | 19 + >> drivers/net/wireless/Makefile | 2 + >> drivers/net/wireless/rtl8xxxu.c | 4500 >> ++++++++++++++++++++++++++++++++++ >> drivers/net/wireless/rtl8xxxu.h | 497 ++++ >> drivers/net/wireless/rtl8xxxu_regs.h | 941 +++++++ > > I think someone else already mentioned, but it would be better that has > it's own directory. Or should this actually be under rtlwifi > directory? I didn't see the need here - it's just 3 files, as long as it doesn't have a huge hierachy of files, a new directory doesn't add much value. If it becomes an issue later, we can move it into a subdirectory. >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -8297,6 +8297,14 @@ S: Maintained >> F: drivers/net/wireless/rtlwifi/ >> F: drivers/net/wireless/rtlwifi/rtl8192ce/ >> >> +RTL8XXXU WIRELESS DRIVER (rtl8xxxu) >> +M: Jes Sorensen <Jes.Sorensen@redhat.com> >> +L: linux-wireless@vger.kernel.org >> +W: http://intellinuxwireless.org > > The link cannot be right. That is a mistake for sure, I must have copied an entry as a template and forgotten to remove that one. >> +T: git git://git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git >> rtl8723au-mac80211 > > I doubt that this will be in active enough development that a separate > git tree is needed. wireless-drivers trees should be enough and this > line can be removed. I would like to keep this line, it points to my development tree, which allows users to go back and look through my full development logs, as well as see ongoing work before it's pushed upstream. > I'll do more detailed code review later, but my first impression was > that there was a lot of #if 0 code which is frowned upon. Johannes already brought up the #if 0 pieces. I left those in because I am not done with the driver, and this helps me map the flow of the vendor driver codebase. Those #if 0 lines are not there to sit and rot, but to help future development. > And I pushed this to wireless-drivers-next.git pending branch so that > kbuild will run it's tests with this driver. I saw the kbuild warning, it was a false positive, which I do plan to address down the line. Cheers, Jes ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-04-28 14:27 ` Jes Sorensen @ 2015-04-28 15:15 ` Larry Finger 2015-09-06 13:38 ` Kalle Valo 1 sibling, 0 replies; 35+ messages in thread From: Larry Finger @ 2015-04-28 15:15 UTC (permalink / raw) To: Jes Sorensen, Kalle Valo; +Cc: linux-wireless On 04/28/2015 09:27 AM, Jes Sorensen wrote: > Kalle Valo <kvalo@codeaurora.org> writes: >> Jes.Sorensen@redhat.com writes: >> >>> From: Jes Sorensen <Jes.Sorensen@redhat.com> >>> >>> This is an alternate driver for the Realtek 8723AU (rtl8723au) written >>> from scratch utilizing the mac80211 stack. >>> >>> After spending months cleaning up the vendor provided rtl8723au >>> driver, which comes with it's own 802.11 stack included, I decided to >>> rewrite this driver from the bottom up. >> >> Where is the vendor driver available, in staging or somewhere else? It >> would be good to mention that in the commit log. > > Hi Kalle, > > Thanks for the feedback, the vendor driver is drivers/staging/rtl8723au/ > >>> Many thanks to Johannes Berg for 802.11 insights and help and Larry >>> Finger for help with the vendor driver. >>> >>> The full git log for the development of this driver can be found here: >>> git git://git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git >>> branch rtl8723au-mac80211 >>> >>> This driver is still experimental, but has proven to be rather stable >>> for me. It lacks some features found in the staging driver, such as >>> power management, AMPDU, and 40MHz channel support. In addition there >>> is no AP and monitor support at this point. >> >> It's nice to document in the commit log what features are verified to be >> working. >> >> Also I see incosistencies with driver naming, in some places I see >> RTL8723au and elsewhere rtl8xxxu. And commit log title could be >> improved, for example something like "rtl8xxxu: new wireless mac80211 >> driver for rtl8723au chipsets" > > The reason for the inconsistencies is that I anticipate adding support > for more chips in the future, so the 8723au named functions are ones > that are more likely to be chip specific. > >> And I would like to understand the relationship with rtlwifi, can you >> describe that a bit more? Why a separate driver instead of extending >> rtlwifi? When I look at the directory drivers/net/wireless/rtlwifi/rtl8723ae >> I'm confused what's the bigger plan here. Larry? > > I looked at rtlwifi and while it has changed a lot from the vendor > driver, it still has a strong legacy of the vendor codebase. I could > have opted to do a smaller mini-driver for rtlwifi, but I felt it was > better to start from scratch and write the driver from the bottom up for > Linux. > >>> MAINTAINERS | 8 + >>> drivers/net/wireless/Kconfig | 19 + >>> drivers/net/wireless/Makefile | 2 + >>> drivers/net/wireless/rtl8xxxu.c | 4500 >>> ++++++++++++++++++++++++++++++++++ >>> drivers/net/wireless/rtl8xxxu.h | 497 ++++ >>> drivers/net/wireless/rtl8xxxu_regs.h | 941 +++++++ >> >> I think someone else already mentioned, but it would be better that has >> it's own directory. Or should this actually be under rtlwifi >> directory? > > I didn't see the need here - it's just 3 files, as long as it doesn't > have a huge hierachy of files, a new directory doesn't add much > value. If it becomes an issue later, we can move it into a subdirectory. > >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -8297,6 +8297,14 @@ S: Maintained >>> F: drivers/net/wireless/rtlwifi/ >>> F: drivers/net/wireless/rtlwifi/rtl8192ce/ >>> >>> +RTL8XXXU WIRELESS DRIVER (rtl8xxxu) >>> +M: Jes Sorensen <Jes.Sorensen@redhat.com> >>> +L: linux-wireless@vger.kernel.org >>> +W: http://intellinuxwireless.org >> >> The link cannot be right. > > That is a mistake for sure, I must have copied an entry as a template > and forgotten to remove that one. > >>> +T: git git://git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git >>> rtl8723au-mac80211 >> >> I doubt that this will be in active enough development that a separate >> git tree is needed. wireless-drivers trees should be enough and this >> line can be removed. > > I would like to keep this line, it points to my development tree, which > allows users to go back and look through my full development logs, as > well as see ongoing work before it's pushed upstream. > >> I'll do more detailed code review later, but my first impression was >> that there was a lot of #if 0 code which is frowned upon. > > Johannes already brought up the #if 0 pieces. I left those in because I > am not done with the driver, and this helps me map the flow of the > vendor driver codebase. Those #if 0 lines are not there to sit and rot, > but to help future development. > >> And I pushed this to wireless-drivers-next.git pending branch so that >> kbuild will run it's tests with this driver. > > I saw the kbuild warning, it was a false positive, which I do plan to > address down the line. Kalle, Jes has covered most of the points very well. I will add just a little explanation from my point of view. There are two major software groups that write the original drivers for the Realtek chips. The PCI group, which is located in China, has worked very hard at their Linux drivers and have written the mac80211 versions found in rtlwifi. I have contributed to cleaning up their code and fixing kernel crashes, but the code is largely theirs. The USB group, which is located in Taiwan, also provide Linux drivers, but their drivers contain their own software 802.11 stack. The only exception is the driver for the RTL8192CU, which is in rtlwifi. The distributed USB drivers come with conditional code that can build drivers for Linux, Windows, and FreeBSD. This leads to a lot of dead code in each of the drivers. In addition, they release new versions somewhat infrequently and can be quite slow to update their drivers for new kernel APIs. Some time ago, I started getting requests for a driver for the RTL8723AU, which was only found in the Lenovo Yoga 13 tablet. As I have no budget to purchase a $1000 machine only for testing a new driver, I did the best I could by creating a public GitHub repo and posted the code after modifying it to build on all kernel versions. I also did some cleanup of dead code and some cosmetic changes to make the code easier to read. That chip is now more widely used. Jes, who owns the Yoga 13, contacted me about adding this driver to staging, which lack of test equipment prevented me from doing. I helped him with part of that step, but he soon was reworking the code in more advanced ways. From the feedback I get from users, the staging driver is extremely stable. From that start, Jes has now written this version. Rather than modifying the staging driver to use mac80211 instead of its own stack, he started fresh. That avoids a lot of crufty code, and I am very impressed with the result. The points about extensibility are very important. At present, I have 7 other drivers for Realtek USB devices at GitHub that are in various stages of development; however, all use the Realtek 802.11 stack. These could be pushed into staging, but now that there is an option of converting these into the framework that Jes has provided, why not go all the way with quality code? As I only have the hardware for 2 of these devices, a lot of help from the community will be needed for testing. In addition, some of the devices will likely be available as inexpensive USB plugins, and can be added to my available devices. I will be happy to answer any questions. Larry ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-04-28 14:27 ` Jes Sorensen 2015-04-28 15:15 ` Larry Finger @ 2015-09-06 13:38 ` Kalle Valo 2015-09-06 16:41 ` Larry Finger 2015-09-07 18:43 ` Jes Sorensen 1 sibling, 2 replies; 35+ messages in thread From: Kalle Valo @ 2015-09-06 13:38 UTC (permalink / raw) To: Jes Sorensen; +Cc: linux-wireless, Larry.Finger Hi, replying to an old thread first. Jes Sorensen <Jes.Sorensen@redhat.com> writes: > Kalle Valo <kvalo@codeaurora.org> writes: >> Jes.Sorensen@redhat.com writes: >> >>> MAINTAINERS | 8 + >>> drivers/net/wireless/Kconfig | 19 + >>> drivers/net/wireless/Makefile | 2 + >>> drivers/net/wireless/rtl8xxxu.c | 4500 >>> ++++++++++++++++++++++++++++++++++ >>> drivers/net/wireless/rtl8xxxu.h | 497 ++++ >>> drivers/net/wireless/rtl8xxxu_regs.h | 941 +++++++ >> >> I think someone else already mentioned, but it would be better that has >> it's own directory. Or should this actually be under rtlwifi >> directory? > > I didn't see the need here - it's just 3 files, as long as it doesn't > have a huge hierachy of files, a new directory doesn't add much > value. If it becomes an issue later, we can move it into a > subdirectory. It's easier that the driver has it's on directory as everything (makefile, kconfig etc) is cleanly separated. And actually I would like to create a new vendor directory for realtek and have this in drivers/net/wireless/realtek/rtl8xxxu/. And later we could move rtlwifi under realtek directory as well. >>> +T: git git://git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git >>> rtl8723au-mac80211 >> >> I doubt that this will be in active enough development that a separate >> git tree is needed. wireless-drivers trees should be enough and this >> line can be removed. > > I would like to keep this line, it points to my development tree, which > allows users to go back and look through my full development logs, as > well as see ongoing work before it's pushed upstream. I prefer that wireless-drivers(-next).git is used as the baseline for wireless driver patches, so please remove this tag. You can document your git server in the wiki, commit log and so on. >> I'll do more detailed code review later, but my first impression was >> that there was a lot of #if 0 code which is frowned upon. > > Johannes already brought up the #if 0 pieces. I left those in because I > am not done with the driver, and this helps me map the flow of the > vendor driver codebase. Those #if 0 lines are not there to sit and rot, > but to help future development. Yeah, I guessed that. But I suspect once the driver is applied we start getting patches removing dead code (and rightly so). You could have a separate branch with these #if 0 lines if they are important to you. -- Kalle Valo ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-09-06 13:38 ` Kalle Valo @ 2015-09-06 16:41 ` Larry Finger 2015-09-07 13:37 ` Kalle Valo 2015-09-07 18:43 ` Jes Sorensen 1 sibling, 1 reply; 35+ messages in thread From: Larry Finger @ 2015-09-06 16:41 UTC (permalink / raw) To: Kalle Valo, Jes Sorensen; +Cc: linux-wireless On 09/06/2015 08:38 AM, Kalle Valo wrote: > Hi, > > replying to an old thread first. > > Jes Sorensen <Jes.Sorensen@redhat.com> writes: > >> Kalle Valo <kvalo@codeaurora.org> writes: >>> Jes.Sorensen@redhat.com writes: >>> >>>> MAINTAINERS | 8 + >>>> drivers/net/wireless/Kconfig | 19 + >>>> drivers/net/wireless/Makefile | 2 + >>>> drivers/net/wireless/rtl8xxxu.c | 4500 >>>> ++++++++++++++++++++++++++++++++++ >>>> drivers/net/wireless/rtl8xxxu.h | 497 ++++ >>>> drivers/net/wireless/rtl8xxxu_regs.h | 941 +++++++ >>> >>> I think someone else already mentioned, but it would be better that has >>> it's own directory. Or should this actually be under rtlwifi >>> directory? >> >> I didn't see the need here - it's just 3 files, as long as it doesn't >> have a huge hierachy of files, a new directory doesn't add much >> value. If it becomes an issue later, we can move it into a >> subdirectory. > > It's easier that the driver has it's on directory as everything > (makefile, kconfig etc) is cleanly separated. And actually I would like > to create a new vendor directory for realtek and have this in > drivers/net/wireless/realtek/rtl8xxxu/. And later we could move rtlwifi > under realtek directory as well. I agree with the proposal for this driver to be under a separate directory. As this driver evolves to support more devices, it will likely be useful to split the current single .c file into a set of files, each containing the specific code needed for a given device. At that point, placing these files into a separate directory will be needed to keep the base drivers/net/wireless/ as clean as possible. We might as well do that now. I have no objections to moving rtlwifi under drivers/net/wireless/realtek/. We should even move rtl818x as well. Larry ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-09-06 16:41 ` Larry Finger @ 2015-09-07 13:37 ` Kalle Valo 0 siblings, 0 replies; 35+ messages in thread From: Kalle Valo @ 2015-09-07 13:37 UTC (permalink / raw) To: Larry Finger; +Cc: Jes Sorensen, linux-wireless Larry Finger <Larry.Finger@lwfinger.net> writes: >> It's easier that the driver has it's on directory as everything >> (makefile, kconfig etc) is cleanly separated. And actually I would like >> to create a new vendor directory for realtek and have this in >> drivers/net/wireless/realtek/rtl8xxxu/. And later we could move rtlwifi >> under realtek directory as well. > > I agree with the proposal for this driver to be under a separate > directory. As this driver evolves to support more devices, it will > likely be useful to split the current single .c file into a set of > files, each containing the specific code needed for a given device. At > that point, placing these files into a separate directory will be > needed to keep the base drivers/net/wireless/ as clean as possible. We > might as well do that now. I have no objections to moving rtlwifi > under drivers/net/wireless/realtek/. Great. > We should even move rtl818x as well. Good point, need to remember that. -- Kalle Valo ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-09-06 13:38 ` Kalle Valo 2015-09-06 16:41 ` Larry Finger @ 2015-09-07 18:43 ` Jes Sorensen 2015-09-07 18:50 ` Larry Finger 2015-09-29 8:56 ` Kalle Valo 1 sibling, 2 replies; 35+ messages in thread From: Jes Sorensen @ 2015-09-07 18:43 UTC (permalink / raw) To: Kalle Valo; +Cc: linux-wireless, Larry.Finger Kalle Valo <kvalo@codeaurora.org> writes: > Hi, > > replying to an old thread first. > > Jes Sorensen <Jes.Sorensen@redhat.com> writes: > >> Kalle Valo <kvalo@codeaurora.org> writes: >>> Jes.Sorensen@redhat.com writes: >>> >>>> MAINTAINERS | 8 + >>>> drivers/net/wireless/Kconfig | 19 + >>>> drivers/net/wireless/Makefile | 2 + >>>> drivers/net/wireless/rtl8xxxu.c | 4500 >>>> ++++++++++++++++++++++++++++++++++ >>>> drivers/net/wireless/rtl8xxxu.h | 497 ++++ >>>> drivers/net/wireless/rtl8xxxu_regs.h | 941 +++++++ >>> >>> I think someone else already mentioned, but it would be better that has >>> it's own directory. Or should this actually be under rtlwifi >>> directory? >> >> I didn't see the need here - it's just 3 files, as long as it doesn't >> have a huge hierachy of files, a new directory doesn't add much >> value. If it becomes an issue later, we can move it into a >> subdirectory. > > It's easier that the driver has it's on directory as everything > (makefile, kconfig etc) is cleanly separated. And actually I would like > to create a new vendor directory for realtek and have this in > drivers/net/wireless/realtek/rtl8xxxu/. And later we could move rtlwifi > under realtek directory as well. If you want to create drivers/net/wireless/realtek, that is fine with me, but maybe you can go ahead and create that first and move the existing drivers in there? >>>> +T: git git://git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git >>>> rtl8723au-mac80211 >>> >>> I doubt that this will be in active enough development that a separate >>> git tree is needed. wireless-drivers trees should be enough and this >>> line can be removed. >> >> I would like to keep this line, it points to my development tree, which >> allows users to go back and look through my full development logs, as >> well as see ongoing work before it's pushed upstream. > > I prefer that wireless-drivers(-next).git is used as the baseline for > wireless driver patches, so please remove this tag. You can document > your git server in the wiki, commit log and so on. I will insist on keeping my branch listed as long as I maintain the driver. Other drivers do the same thing, like iwlwifi. I'm happy to send you patches against wireless-drivers-next.git though. >>> I'll do more detailed code review later, but my first impression was >>> that there was a lot of #if 0 code which is frowned upon. >> >> Johannes already brought up the #if 0 pieces. I left those in because I >> am not done with the driver, and this helps me map the flow of the >> vendor driver codebase. Those #if 0 lines are not there to sit and rot, >> but to help future development. > > Yeah, I guessed that. But I suspect once the driver is applied we start > getting patches removing dead code (and rightly so). You could have a > separate branch with these #if 0 lines if they are important to you. Most of this is gone by now, so this part of the discussion is less relevant by now :) Cheers, Jes ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-09-07 18:43 ` Jes Sorensen @ 2015-09-07 18:50 ` Larry Finger 2015-09-09 14:16 ` Jes Sorensen 2015-09-29 8:56 ` Kalle Valo 1 sibling, 1 reply; 35+ messages in thread From: Larry Finger @ 2015-09-07 18:50 UTC (permalink / raw) To: Jes Sorensen, Kalle Valo; +Cc: linux-wireless On 09/07/2015 01:43 PM, Jes Sorensen wrote: > Kalle Valo <kvalo@codeaurora.org> writes: >> Hi, >> >> replying to an old thread first. >> >> Jes Sorensen <Jes.Sorensen@redhat.com> writes: >> >>> Kalle Valo <kvalo@codeaurora.org> writes: >>>> Jes.Sorensen@redhat.com writes: >>>> >>>>> MAINTAINERS | 8 + >>>>> drivers/net/wireless/Kconfig | 19 + >>>>> drivers/net/wireless/Makefile | 2 + >>>>> drivers/net/wireless/rtl8xxxu.c | 4500 >>>>> ++++++++++++++++++++++++++++++++++ >>>>> drivers/net/wireless/rtl8xxxu.h | 497 ++++ >>>>> drivers/net/wireless/rtl8xxxu_regs.h | 941 +++++++ >>>> >>>> I think someone else already mentioned, but it would be better that has >>>> it's own directory. Or should this actually be under rtlwifi >>>> directory? >>> >>> I didn't see the need here - it's just 3 files, as long as it doesn't >>> have a huge hierachy of files, a new directory doesn't add much >>> value. If it becomes an issue later, we can move it into a >>> subdirectory. >> >> It's easier that the driver has it's on directory as everything >> (makefile, kconfig etc) is cleanly separated. And actually I would like >> to create a new vendor directory for realtek and have this in >> drivers/net/wireless/realtek/rtl8xxxu/. And later we could move rtlwifi >> under realtek directory as well. > > If you want to create drivers/net/wireless/realtek, that is fine with > me, but maybe you can go ahead and create that first and move the > existing drivers in there? I will submit a patch to do that. Larry ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-09-07 18:50 ` Larry Finger @ 2015-09-09 14:16 ` Jes Sorensen 0 siblings, 0 replies; 35+ messages in thread From: Jes Sorensen @ 2015-09-09 14:16 UTC (permalink / raw) To: Larry Finger; +Cc: Kalle Valo, linux-wireless Larry Finger <Larry.Finger@lwfinger.net> writes: > On 09/07/2015 01:43 PM, Jes Sorensen wrote: >> Kalle Valo <kvalo@codeaurora.org> writes: >>> Hi, >>> >>> replying to an old thread first. >>> >>> Jes Sorensen <Jes.Sorensen@redhat.com> writes: >>> >>>> Kalle Valo <kvalo@codeaurora.org> writes: >>>>> Jes.Sorensen@redhat.com writes: >>>>> >>>>>> MAINTAINERS | 8 + >>>>>> drivers/net/wireless/Kconfig | 19 + >>>>>> drivers/net/wireless/Makefile | 2 + >>>>>> drivers/net/wireless/rtl8xxxu.c | 4500 >>>>>> ++++++++++++++++++++++++++++++++++ >>>>>> drivers/net/wireless/rtl8xxxu.h | 497 ++++ >>>>>> drivers/net/wireless/rtl8xxxu_regs.h | 941 +++++++ >>>>> >>>>> I think someone else already mentioned, but it would be better that has >>>>> it's own directory. Or should this actually be under rtlwifi >>>>> directory? >>>> >>>> I didn't see the need here - it's just 3 files, as long as it doesn't >>>> have a huge hierachy of files, a new directory doesn't add much >>>> value. If it becomes an issue later, we can move it into a >>>> subdirectory. >>> >>> It's easier that the driver has it's on directory as everything >>> (makefile, kconfig etc) is cleanly separated. And actually I would like >>> to create a new vendor directory for realtek and have this in >>> drivers/net/wireless/realtek/rtl8xxxu/. And later we could move rtlwifi >>> under realtek directory as well. >> >> If you want to create drivers/net/wireless/realtek, that is fine with >> me, but maybe you can go ahead and create that first and move the >> existing drivers in there? > > I will submit a patch to do that. Awesome, once I see that go in, I'll move rtl8xxxu into that directory. Cheers, Jes ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-09-07 18:43 ` Jes Sorensen 2015-09-07 18:50 ` Larry Finger @ 2015-09-29 8:56 ` Kalle Valo 2015-09-29 10:42 ` Jes Sorensen 1 sibling, 1 reply; 35+ messages in thread From: Kalle Valo @ 2015-09-29 8:56 UTC (permalink / raw) To: Jes Sorensen; +Cc: linux-wireless, Larry.Finger Jes Sorensen <Jes.Sorensen@redhat.com> writes: >>>> I doubt that this will be in active enough development that a separate >>>> git tree is needed. wireless-drivers trees should be enough and this >>>> line can be removed. >>> >>> I would like to keep this line, it points to my development tree, which >>> allows users to go back and look through my full development logs, as >>> well as see ongoing work before it's pushed upstream. >> >> I prefer that wireless-drivers(-next).git is used as the baseline for >> wireless driver patches, so please remove this tag. You can document >> your git server in the wiki, commit log and so on. > > I will insist on keeping my branch listed as long as I maintain the > driver. Other drivers do the same thing, like iwlwifi. I'm happy to send > you patches against wireless-drivers-next.git though. To keep things simple for me I want that the patches are based on wireless-drivers-next.git. iwlwifi is under so active development that an extra tree is justified, but having a dedicated tree for a not so active driver is just extra work for me which I do not want to have. With rtlwifi it goes so that Larry acks the patches on the list and patchwork automatically adds the ack to the commit log when I apply the patch, which is easy and fast for everyone. The same should go with rtl8723au. -- Kalle Valo ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-09-29 8:56 ` Kalle Valo @ 2015-09-29 10:42 ` Jes Sorensen 0 siblings, 0 replies; 35+ messages in thread From: Jes Sorensen @ 2015-09-29 10:42 UTC (permalink / raw) To: Kalle Valo; +Cc: linux-wireless, Larry.Finger Kalle Valo <kvalo@codeaurora.org> writes: > Jes Sorensen <Jes.Sorensen@redhat.com> writes: > >>>>> I doubt that this will be in active enough development that a separate >>>>> git tree is needed. wireless-drivers trees should be enough and this >>>>> line can be removed. >>>> >>>> I would like to keep this line, it points to my development tree, which >>>> allows users to go back and look through my full development logs, as >>>> well as see ongoing work before it's pushed upstream. >>> >>> I prefer that wireless-drivers(-next).git is used as the baseline for >>> wireless driver patches, so please remove this tag. You can document >>> your git server in the wiki, commit log and so on. >> >> I will insist on keeping my branch listed as long as I maintain the >> driver. Other drivers do the same thing, like iwlwifi. I'm happy to send >> you patches against wireless-drivers-next.git though. > > To keep things simple for me I want that the patches are based on > wireless-drivers-next.git. iwlwifi is under so active development that > an extra tree is justified, but having a dedicated tree for a not so > active driver is just extra work for me which I do not want to have. > > With rtlwifi it goes so that Larry acks the patches on the list and > patchwork automatically adds the ack to the commit log when I apply the > patch, which is easy and fast for everyone. The same should go with > rtl8723au. The rtl8xxxu branch is there because that is where I do the active development, and work actively on the driver. If people post patches for it and it's smaller fixes, sure just take them, if they post larger changes, please punt them to me and I will integrate them and send them on to you. Jes ^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH v2 0/1] New driver: rtl8723au (mac80211) @ 2015-03-09 17:00 Jes.Sorensen 2015-03-09 17:00 ` [PATCH 1/1] " Jes.Sorensen 0 siblings, 1 reply; 35+ messages in thread From: Jes.Sorensen @ 2015-03-09 17:00 UTC (permalink / raw) To: linux-wireless; +Cc: Larry.Finger, Jes Sorensen From: Jes Sorensen <Jes.Sorensen@redhat.com> This is a new driver for the rtl8723au which was written from scratch, to utilize the Linux mac80211 stack. This has been a pet project for me for some time I finally feel it is stable enough to submit. I have used it for a while without any serious issues. I started working on cleaning up the vendor provided driver in staging/rtl8723au over a year ago. After spending 6 months on it, it became obvious to me that it was a rather hopeless task, and I started writing this driver from scratch. I do not have any specs for the chip, so everything is based on knowledge I obtained from dissecting the vendor driver. Special thanks to Larry Finger for help with the original rtl8723au driver, and Johannes Berg for answering all my silly questions about 802.11 innards and the mac80211 stack. Had I known then what I know today about 802.11, I probably would never have so mad as to start this project in the first place! v2 of the patch fixes the endian problem reported by Joe Perches, and adds a module debug parameter so one doesn't have to recompile the driver to change the debug mask (I was convinced I had that as a module parameter already). The latter was suggested by Larry Finger. In addition I fixed up a few cases of trailing whitespaces, a few indentation issues, and a few workarounds to reduce the scriptkiddies complaining about checkpatch warnings. I did run checkpatch on this one, and there are zero legitimate warnings left that needs to be dealt with. There are still some debug portions and code that is #if 0'ed out. I prefer to keep this in place for now as some of it is meant to be enabled later, and other portions I use to match up tables and code to the vendor driver when trying to trace issues when debugging. Cheers, Jes Jes Sorensen (1): New driver: rtl8723au (mac80211) MAINTAINERS | 9 + drivers/net/wireless/Kconfig | 19 + drivers/net/wireless/Makefile | 2 + drivers/net/wireless/rtl8xxxu.c | 4502 ++++++++++++++++++++++++++++++++++ drivers/net/wireless/rtl8xxxu.h | 494 ++++ drivers/net/wireless/rtl8xxxu_regs.h | 940 +++++++ 6 files changed, 5966 insertions(+) create mode 100644 drivers/net/wireless/rtl8xxxu.c create mode 100644 drivers/net/wireless/rtl8xxxu.h create mode 100644 drivers/net/wireless/rtl8xxxu_regs.h -- 2.1.0 ^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-03-09 17:00 [PATCH v2 0/1] " Jes.Sorensen @ 2015-03-09 17:00 ` Jes.Sorensen 2015-03-09 17:46 ` Johannes Berg 2015-03-09 18:20 ` Joe Perches 0 siblings, 2 replies; 35+ messages in thread From: Jes.Sorensen @ 2015-03-09 17:00 UTC (permalink / raw) To: linux-wireless; +Cc: Larry.Finger, Jes Sorensen From: Jes Sorensen <Jes.Sorensen@redhat.com> This is an alternate driver for the Realtek 8723AU (rtl8723au) written from scratch utilizing the mac80211 stack. After spending months cleaning up the vendor provided rtl8723au driver, which comes with it's own 802.11 stack included, I decided to rewrite this driver from the bottom up. Many thanks to Johannes Berg for 802.11 insights and help and Larry Finger for help with the vendor driver. The full git log for the development of this driver can be found here: git git://git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git branch rtl8723au-mac80211 This driver is still experimental, but has proven to be rather stable for me. It lacks some features found in the staging driver, such as power management, AMPDU, and 40MHz channel support. In addition there is no AP and monitor support at this point. Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> --- MAINTAINERS | 9 + drivers/net/wireless/Kconfig | 19 + drivers/net/wireless/Makefile | 2 + drivers/net/wireless/rtl8xxxu.c | 4502 ++++++++++++++++++++++++++++++++++ drivers/net/wireless/rtl8xxxu.h | 494 ++++ drivers/net/wireless/rtl8xxxu_regs.h | 940 +++++++ 6 files changed, 5966 insertions(+) create mode 100644 drivers/net/wireless/rtl8xxxu.c create mode 100644 drivers/net/wireless/rtl8xxxu.h create mode 100644 drivers/net/wireless/rtl8xxxu_regs.h diff --git a/MAINTAINERS b/MAINTAINERS index 42f686f..8ce6297 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8297,6 +8297,15 @@ S: Maintained F: drivers/net/wireless/rtlwifi/ F: drivers/net/wireless/rtlwifi/rtl8192ce/ +RTL8XXXU WIRELESS DRIVER (rtl8xxxu) +M: Jes Sorensen <Jes.Sorensen@redhat.com> +L: linux-wireless@vger.kernel.org +W: http://intellinuxwireless.org +T: git git://git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git + git branch rtl8723au-mac80211 +S: Maintained +F: drivers/net/wireless/rtl8xxxu*.[ch] + S3 SAVAGE FRAMEBUFFER DRIVER M: Antonino Daplas <adaplas@gmail.com> L: linux-fbdev@vger.kernel.org diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig index 16604bd..dda80d6 100644 --- a/drivers/net/wireless/Kconfig +++ b/drivers/net/wireless/Kconfig @@ -243,6 +243,25 @@ config ADM8211 Thanks to Infineon-ADMtek for their support of this driver. +config RTL8XXXU + tristate "RTL8723AU (mac80211) support (EXPERIMENTAL)" + depends on MAC80211 && USB + ---help--- + This is an alternative driver for the RTL8723AU, written to + utilize the Linux mac80211 stack. + + This driver is under development and has a limited feature + set. In particular it does not yet support 40MHz channels, + AMPDU, and power management. However it should have a + smaller memory footprint than the vendor driver and benetifs + from the in kernel mac80211 stack. + + It can coexist with the driver from drivers/staging/rtl8723au, + but you will need to control which module you wish to load. + + To compile this driver as a module, choose M here: the module will + be called r8xxxu. If unsure, say N. + config MAC80211_HWSIM tristate "Simulated radio testing tool for mac80211" depends on MAC80211 diff --git a/drivers/net/wireless/Makefile b/drivers/net/wireless/Makefile index 0c88916..e3911cc 100644 --- a/drivers/net/wireless/Makefile +++ b/drivers/net/wireless/Makefile @@ -39,6 +39,8 @@ obj-$(CONFIG_LIBERTAS_THINFIRM) += libertas_tf/ obj-$(CONFIG_ADM8211) += adm8211.o +obj-$(CONFIG_RTL8XXXU) += rtl8xxxu.o + obj-$(CONFIG_MWL8K) += mwl8k.o obj-$(CONFIG_IWLWIFI) += iwlwifi/ diff --git a/drivers/net/wireless/rtl8xxxu.c b/drivers/net/wireless/rtl8xxxu.c new file mode 100644 index 0000000..effe88c --- /dev/null +++ b/drivers/net/wireless/rtl8xxxu.c @@ -0,0 +1,4502 @@ +/* + * RTL8723au mac80211 USB driver + * + * Copyright (c) 2014 Jes Sorensen <Jes.Sorensen@redhat.com> + * + * Portions, notably calibration code: + * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved. + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of version 2 of the GNU General Public License as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + */ + +#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/sched.h> +#include <linux/errno.h> +#include <linux/slab.h> +#include <linux/module.h> +#include <linux/spinlock.h> +#include <linux/list.h> +#include <linux/usb.h> +#include <linux/netdevice.h> +#include <linux/etherdevice.h> +#include <linux/ethtool.h> +#include <linux/wireless.h> +#include <linux/firmware.h> +#include <linux/moduleparam.h> +#include <net/mac80211.h> +#include "rtl8xxxu.h" +#include "rtl8xxxu_regs.h" + +#define DRIVER_NAME "rtl8xxxu" + +static int rtl8xxxu_debug = 0; + +MODULE_AUTHOR("Jes Sorensen <Jes.Sorensen@redhat.com>"); +MODULE_DESCRIPTION("RTL8723au USB mac80211 Wireless LAN Driver"); +MODULE_LICENSE("GPL"); +MODULE_FIRMWARE("rtlwifi/rtl8723aufw_A.bin"); +MODULE_FIRMWARE("rtlwifi/rtl8723aufw_B.bin"); +MODULE_FIRMWARE("rtlwifi/rtl8723aufw_B_NoBT.bin"); + +module_param_named(debug, rtl8xxxu_debug, int, 0600); +MODULE_PARM_DESC(debug, "Set debug mask"); + +#define USB_VENDER_ID_REALTEK 0x0BDA +/* Minimum IEEE80211_MAX_FRAME_LEN */ +#define RTL_RX_BUFFER_SIZE IEEE80211_MAX_FRAME_LEN + +static struct usb_device_id dev_table[] = { + {USB_DEVICE_AND_INTERFACE_INFO(USB_VENDER_ID_REALTEK, 0x8724, + 0xff, 0xff, 0xff)}, + {USB_DEVICE_AND_INTERFACE_INFO(USB_VENDER_ID_REALTEK, 0x1724, + 0xff, 0xff, 0xff)}, + {USB_DEVICE_AND_INTERFACE_INFO(USB_VENDER_ID_REALTEK, 0x0724, + 0xff, 0xff, 0xff)}, + { } +}; + +MODULE_DEVICE_TABLE(usb, dev_table); + +static struct ieee80211_rate rtl8xxxu_rates[] = { + { .bitrate = 10, .hw_value = DESC_RATE_1M, .flags = 0 }, + { .bitrate = 20, .hw_value = DESC_RATE_2M, .flags = 0 }, + { .bitrate = 55, .hw_value = DESC_RATE_5_5M, .flags = 0 }, + { .bitrate = 110, .hw_value = DESC_RATE_11M, .flags = 0 }, + { .bitrate = 60, .hw_value = DESC_RATE_6M, .flags = 0 }, + { .bitrate = 90, .hw_value = DESC_RATE_9M, .flags = 0 }, + { .bitrate = 120, .hw_value = DESC_RATE_12M, .flags = 0 }, + { .bitrate = 180, .hw_value = DESC_RATE_18M, .flags = 0 }, + { .bitrate = 240, .hw_value = DESC_RATE_24M, .flags = 0 }, + { .bitrate = 360, .hw_value = DESC_RATE_36M, .flags = 0 }, + { .bitrate = 480, .hw_value = DESC_RATE_48M, .flags = 0 }, + { .bitrate = 540, .hw_value = DESC_RATE_54M, .flags = 0 }, +}; + +static struct ieee80211_channel rtl8xxxu_channels_2g[] = { + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2412, + .hw_value = 1, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2417, + .hw_value = 2, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2422, + .hw_value = 3, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2427, + .hw_value = 4, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2432, + .hw_value = 5, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2437, + .hw_value = 6, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2442, + .hw_value = 7, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2447, + .hw_value = 8, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2452, + .hw_value = 9, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2457, + .hw_value = 10, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2462, + .hw_value = 11, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2467, + .hw_value = 12, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2472, + .hw_value = 13, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2484, + .hw_value = 14, .max_power = 30 } +}; + +static struct ieee80211_supported_band rtl8xxxu_supported_band = { + .channels = rtl8xxxu_channels_2g, + .n_channels = ARRAY_SIZE(rtl8xxxu_channels_2g), + .bitrates = rtl8xxxu_rates, + .n_bitrates = ARRAY_SIZE(rtl8xxxu_rates), +}; + +static const u32 rtl8xxxu_cipher_suites[] = { + WLAN_CIPHER_SUITE_WEP40, + WLAN_CIPHER_SUITE_WEP104, + WLAN_CIPHER_SUITE_TKIP, + WLAN_CIPHER_SUITE_CCMP, +}; + +static struct rtl8xxxu_reg8val rtl8723a_mac_init_table[] = { + {0x420, 0x80}, {0x423, 0x00}, {0x430, 0x00}, {0x431, 0x00}, + {0x432, 0x00}, {0x433, 0x01}, {0x434, 0x04}, {0x435, 0x05}, + {0x436, 0x06}, {0x437, 0x07}, {0x438, 0x00}, {0x439, 0x00}, + {0x43a, 0x00}, {0x43b, 0x01}, {0x43c, 0x04}, {0x43d, 0x05}, + {0x43e, 0x06}, {0x43f, 0x07}, {0x440, 0x5d}, {0x441, 0x01}, + {0x442, 0x00}, {0x444, 0x15}, {0x445, 0xf0}, {0x446, 0x0f}, + {0x447, 0x00}, {0x458, 0x41}, {0x459, 0xa8}, {0x45a, 0x72}, + {0x45b, 0xb9}, {0x460, 0x66}, {0x461, 0x66}, {0x462, 0x08}, + {0x463, 0x03}, {0x4c8, 0xff}, {0x4c9, 0x08}, {0x4cc, 0xff}, + {0x4cd, 0xff}, {0x4ce, 0x01}, {0x500, 0x26}, {0x501, 0xa2}, + {0x502, 0x2f}, {0x503, 0x00}, {0x504, 0x28}, {0x505, 0xa3}, + {0x506, 0x5e}, {0x507, 0x00}, {0x508, 0x2b}, {0x509, 0xa4}, + {0x50a, 0x5e}, {0x50b, 0x00}, {0x50c, 0x4f}, {0x50d, 0xa4}, + {0x50e, 0x00}, {0x50f, 0x00}, {0x512, 0x1c}, {0x514, 0x0a}, + {0x515, 0x10}, {0x516, 0x0a}, {0x517, 0x10}, {0x51a, 0x16}, + {0x524, 0x0f}, {0x525, 0x4f}, {0x546, 0x40}, {0x547, 0x00}, + {0x550, 0x10}, {0x551, 0x10}, {0x559, 0x02}, {0x55a, 0x02}, + {0x55d, 0xff}, {0x605, 0x30}, {0x608, 0x0e}, {0x609, 0x2a}, + {0x652, 0x20}, {0x63c, 0x0a}, {0x63d, 0x0a}, {0x63e, 0x0e}, + {0x63f, 0x0e}, {0x66e, 0x05}, {0x700, 0x21}, {0x701, 0x43}, + {0x702, 0x65}, {0x703, 0x87}, {0x708, 0x21}, {0x709, 0x43}, + {0x70a, 0x65}, {0x70b, 0x87}, {0xffff, 0xff}, +}; + +static struct rtl8xxxu_reg32val rtl8723a_phy_1t_init_table[] = { + {0x800, 0x80040000}, {0x804, 0x00000003}, + {0x808, 0x0000fc00}, {0x80c, 0x0000000a}, + {0x810, 0x10001331}, {0x814, 0x020c3d10}, + {0x818, 0x02200385}, {0x81c, 0x00000000}, + {0x820, 0x01000100}, {0x824, 0x00390004}, + {0x828, 0x00000000}, {0x82c, 0x00000000}, + {0x830, 0x00000000}, {0x834, 0x00000000}, + {0x838, 0x00000000}, {0x83c, 0x00000000}, + {0x840, 0x00010000}, {0x844, 0x00000000}, + {0x848, 0x00000000}, {0x84c, 0x00000000}, + {0x850, 0x00000000}, {0x854, 0x00000000}, + {0x858, 0x569a569a}, {0x85c, 0x001b25a4}, + {0x860, 0x66f60110}, {0x864, 0x061f0130}, + {0x868, 0x00000000}, {0x86c, 0x32323200}, + {0x870, 0x07000760}, {0x874, 0x22004000}, + {0x878, 0x00000808}, {0x87c, 0x00000000}, + {0x880, 0xc0083070}, {0x884, 0x000004d5}, + {0x888, 0x00000000}, {0x88c, 0xccc000c0}, + {0x890, 0x00000800}, {0x894, 0xfffffffe}, + {0x898, 0x40302010}, {0x89c, 0x00706050}, + {0x900, 0x00000000}, {0x904, 0x00000023}, + {0x908, 0x00000000}, {0x90c, 0x81121111}, + {0xa00, 0x00d047c8}, {0xa04, 0x80ff000c}, + {0xa08, 0x8c838300}, {0xa0c, 0x2e68120f}, + {0xa10, 0x9500bb78}, {0xa14, 0x11144028}, + {0xa18, 0x00881117}, {0xa1c, 0x89140f00}, + {0xa20, 0x1a1b0000}, {0xa24, 0x090e1317}, + {0xa28, 0x00000204}, {0xa2c, 0x00d30000}, + {0xa70, 0x101fbf00}, {0xa74, 0x00000007}, + {0xa78, 0x00000900}, {0xc00, 0x48071d40}, + {0xc04, 0x03a05611}, {0xc08, 0x000000e4}, + {0xc0c, 0x6c6c6c6c}, {0xc10, 0x08800000}, + {0xc14, 0x40000100}, {0xc18, 0x08800000}, + {0xc1c, 0x40000100}, {0xc20, 0x00000000}, + {0xc24, 0x00000000}, {0xc28, 0x00000000}, + {0xc2c, 0x00000000}, {0xc30, 0x69e9ac44}, +#if 0 /* Not for USB */ + {0xff0f011f, 0xabcd}, + {0xc34, 0x469652cf}, + {0xcdcdcdcd, 0xcdcd}, +#endif + {0xc34, 0x469652af}, +#if 0 + {0xff0f011f, 0xdead}, +#endif + {0xc38, 0x49795994}, + {0xc3c, 0x0a97971c}, {0xc40, 0x1f7c403f}, + {0xc44, 0x000100b7}, {0xc48, 0xec020107}, + {0xc4c, 0x007f037f}, {0xc50, 0x69543420}, + {0xc54, 0x43bc0094}, {0xc58, 0x69543420}, + {0xc5c, 0x433c0094}, {0xc60, 0x00000000}, +#if 0 /* Not for USB */ + {0xff0f011f, 0xabcd}, + {0xc64, 0x7116848b}, + {0xcdcdcdcd, 0xcdcd}, +#endif + {0xc64, 0x7112848b}, +#if 0 + {0xff0f011f, 0xdead}, +#endif + {0xc68, 0x47c00bff}, + {0xc6c, 0x00000036}, {0xc70, 0x2c7f000d}, + {0xc74, 0x018610db}, {0xc78, 0x0000001f}, + {0xc7c, 0x00b91612}, {0xc80, 0x40000100}, + {0xc84, 0x20f60000}, {0xc88, 0x40000100}, + {0xc8c, 0x20200000}, {0xc90, 0x00121820}, + {0xc94, 0x00000000}, {0xc98, 0x00121820}, + {0xc9c, 0x00007f7f}, {0xca0, 0x00000000}, + {0xca4, 0x00000080}, {0xca8, 0x00000000}, + {0xcac, 0x00000000}, {0xcb0, 0x00000000}, + {0xcb4, 0x00000000}, {0xcb8, 0x00000000}, + {0xcbc, 0x28000000}, {0xcc0, 0x00000000}, + {0xcc4, 0x00000000}, {0xcc8, 0x00000000}, + {0xccc, 0x00000000}, {0xcd0, 0x00000000}, + {0xcd4, 0x00000000}, {0xcd8, 0x64b22427}, + {0xcdc, 0x00766932}, {0xce0, 0x00222222}, + {0xce4, 0x00000000}, {0xce8, 0x37644302}, + {0xcec, 0x2f97d40c}, {0xd00, 0x00080740}, + {0xd04, 0x00020401}, {0xd08, 0x0000907f}, + {0xd0c, 0x20010201}, {0xd10, 0xa0633333}, + {0xd14, 0x3333bc43}, {0xd18, 0x7a8f5b6b}, + {0xd2c, 0xcc979975}, {0xd30, 0x00000000}, + {0xd34, 0x80608000}, {0xd38, 0x00000000}, + {0xd3c, 0x00027293}, {0xd40, 0x00000000}, + {0xd44, 0x00000000}, {0xd48, 0x00000000}, + {0xd4c, 0x00000000}, {0xd50, 0x6437140a}, + {0xd54, 0x00000000}, {0xd58, 0x00000000}, + {0xd5c, 0x30032064}, {0xd60, 0x4653de68}, + {0xd64, 0x04518a3c}, {0xd68, 0x00002101}, + {0xd6c, 0x2a201c16}, {0xd70, 0x1812362e}, + {0xd74, 0x322c2220}, {0xd78, 0x000e3c24}, + {0xe00, 0x2a2a2a2a}, {0xe04, 0x2a2a2a2a}, + {0xe08, 0x03902a2a}, {0xe10, 0x2a2a2a2a}, + {0xe14, 0x2a2a2a2a}, {0xe18, 0x2a2a2a2a}, + {0xe1c, 0x2a2a2a2a}, {0xe28, 0x00000000}, + {0xe30, 0x1000dc1f}, {0xe34, 0x10008c1f}, + {0xe38, 0x02140102}, {0xe3c, 0x681604c2}, + {0xe40, 0x01007c00}, {0xe44, 0x01004800}, + {0xe48, 0xfb000000}, {0xe4c, 0x000028d1}, + {0xe50, 0x1000dc1f}, {0xe54, 0x10008c1f}, + {0xe58, 0x02140102}, {0xe5c, 0x28160d05}, + {0xe60, 0x00000008}, {0xe68, 0x001b25a4}, + {0xe6c, 0x631b25a0}, {0xe70, 0x631b25a0}, + {0xe74, 0x081b25a0}, {0xe78, 0x081b25a0}, + {0xe7c, 0x081b25a0}, {0xe80, 0x081b25a0}, + {0xe84, 0x631b25a0}, {0xe88, 0x081b25a0}, + {0xe8c, 0x631b25a0}, {0xed0, 0x631b25a0}, + {0xed4, 0x631b25a0}, {0xed8, 0x631b25a0}, + {0xedc, 0x001b25a0}, {0xee0, 0x001b25a0}, + {0xeec, 0x6b1b25a0}, {0xf14, 0x00000003}, + {0xf4c, 0x00000000}, {0xf00, 0x00000300}, + {0xffff, 0xffffffff}, +}; + +static struct rtl8xxxu_reg32val rtl8723a_agc_1t_init_table[] = { + {0xc78, 0x7b000001}, {0xc78, 0x7b010001}, + {0xc78, 0x7b020001}, {0xc78, 0x7b030001}, + {0xc78, 0x7b040001}, {0xc78, 0x7b050001}, + {0xc78, 0x7a060001}, {0xc78, 0x79070001}, + {0xc78, 0x78080001}, {0xc78, 0x77090001}, + {0xc78, 0x760a0001}, {0xc78, 0x750b0001}, + {0xc78, 0x740c0001}, {0xc78, 0x730d0001}, + {0xc78, 0x720e0001}, {0xc78, 0x710f0001}, + {0xc78, 0x70100001}, {0xc78, 0x6f110001}, + {0xc78, 0x6e120001}, {0xc78, 0x6d130001}, + {0xc78, 0x6c140001}, {0xc78, 0x6b150001}, + {0xc78, 0x6a160001}, {0xc78, 0x69170001}, + {0xc78, 0x68180001}, {0xc78, 0x67190001}, + {0xc78, 0x661a0001}, {0xc78, 0x651b0001}, + {0xc78, 0x641c0001}, {0xc78, 0x631d0001}, + {0xc78, 0x621e0001}, {0xc78, 0x611f0001}, + {0xc78, 0x60200001}, {0xc78, 0x49210001}, + {0xc78, 0x48220001}, {0xc78, 0x47230001}, + {0xc78, 0x46240001}, {0xc78, 0x45250001}, + {0xc78, 0x44260001}, {0xc78, 0x43270001}, + {0xc78, 0x42280001}, {0xc78, 0x41290001}, + {0xc78, 0x402a0001}, {0xc78, 0x262b0001}, + {0xc78, 0x252c0001}, {0xc78, 0x242d0001}, + {0xc78, 0x232e0001}, {0xc78, 0x222f0001}, + {0xc78, 0x21300001}, {0xc78, 0x20310001}, + {0xc78, 0x06320001}, {0xc78, 0x05330001}, + {0xc78, 0x04340001}, {0xc78, 0x03350001}, + {0xc78, 0x02360001}, {0xc78, 0x01370001}, + {0xc78, 0x00380001}, {0xc78, 0x00390001}, + {0xc78, 0x003a0001}, {0xc78, 0x003b0001}, + {0xc78, 0x003c0001}, {0xc78, 0x003d0001}, + {0xc78, 0x003e0001}, {0xc78, 0x003f0001}, + {0xc78, 0x7b400001}, {0xc78, 0x7b410001}, + {0xc78, 0x7b420001}, {0xc78, 0x7b430001}, + {0xc78, 0x7b440001}, {0xc78, 0x7b450001}, + {0xc78, 0x7a460001}, {0xc78, 0x79470001}, + {0xc78, 0x78480001}, {0xc78, 0x77490001}, + {0xc78, 0x764a0001}, {0xc78, 0x754b0001}, + {0xc78, 0x744c0001}, {0xc78, 0x734d0001}, + {0xc78, 0x724e0001}, {0xc78, 0x714f0001}, + {0xc78, 0x70500001}, {0xc78, 0x6f510001}, + {0xc78, 0x6e520001}, {0xc78, 0x6d530001}, + {0xc78, 0x6c540001}, {0xc78, 0x6b550001}, + {0xc78, 0x6a560001}, {0xc78, 0x69570001}, + {0xc78, 0x68580001}, {0xc78, 0x67590001}, + {0xc78, 0x665a0001}, {0xc78, 0x655b0001}, + {0xc78, 0x645c0001}, {0xc78, 0x635d0001}, + {0xc78, 0x625e0001}, {0xc78, 0x615f0001}, + {0xc78, 0x60600001}, {0xc78, 0x49610001}, + {0xc78, 0x48620001}, {0xc78, 0x47630001}, + {0xc78, 0x46640001}, {0xc78, 0x45650001}, + {0xc78, 0x44660001}, {0xc78, 0x43670001}, + {0xc78, 0x42680001}, {0xc78, 0x41690001}, + {0xc78, 0x406a0001}, {0xc78, 0x266b0001}, + {0xc78, 0x256c0001}, {0xc78, 0x246d0001}, + {0xc78, 0x236e0001}, {0xc78, 0x226f0001}, + {0xc78, 0x21700001}, {0xc78, 0x20710001}, + {0xc78, 0x06720001}, {0xc78, 0x05730001}, + {0xc78, 0x04740001}, {0xc78, 0x03750001}, + {0xc78, 0x02760001}, {0xc78, 0x01770001}, + {0xc78, 0x00780001}, {0xc78, 0x00790001}, + {0xc78, 0x007a0001}, {0xc78, 0x007b0001}, + {0xc78, 0x007c0001}, {0xc78, 0x007d0001}, + {0xc78, 0x007e0001}, {0xc78, 0x007f0001}, + {0xc78, 0x3800001e}, {0xc78, 0x3801001e}, + {0xc78, 0x3802001e}, {0xc78, 0x3803001e}, + {0xc78, 0x3804001e}, {0xc78, 0x3805001e}, + {0xc78, 0x3806001e}, {0xc78, 0x3807001e}, + {0xc78, 0x3808001e}, {0xc78, 0x3c09001e}, + {0xc78, 0x3e0a001e}, {0xc78, 0x400b001e}, + {0xc78, 0x440c001e}, {0xc78, 0x480d001e}, + {0xc78, 0x4c0e001e}, {0xc78, 0x500f001e}, + {0xc78, 0x5210001e}, {0xc78, 0x5611001e}, + {0xc78, 0x5a12001e}, {0xc78, 0x5e13001e}, + {0xc78, 0x6014001e}, {0xc78, 0x6015001e}, + {0xc78, 0x6016001e}, {0xc78, 0x6217001e}, + {0xc78, 0x6218001e}, {0xc78, 0x6219001e}, + {0xc78, 0x621a001e}, {0xc78, 0x621b001e}, + {0xc78, 0x621c001e}, {0xc78, 0x621d001e}, + {0xc78, 0x621e001e}, {0xc78, 0x621f001e}, + {0xffff, 0xffffffff} +}; + +static struct rtl8xxxu_rfregval rtl8723au_radioa_rf6052_1t_init_table[] = { + {0x00, 0x00030159}, {0x01, 0x00031284}, + {0x02, 0x00098000}, +#if 0 /* Only for PCIE */ + {0xff0f011f, 0xabcd}, + {0x03, 0x00018c63}, + {0xcdcdcdcd, 0xcdcd}, +#endif + {0x03, 0x00039c63}, +#if 0 + {0xff0f011f, 0xdead}, +#endif + {0x04, 0x000210e7}, {0x09, 0x0002044f}, + {0x0a, 0x0001a3f1}, {0x0b, 0x00014787}, + {0x0c, 0x000896fe}, {0x0d, 0x0000e02c}, + {0x0e, 0x00039ce7}, {0x0f, 0x00000451}, + {0x19, 0x00000000}, {0x1a, 0x00030355}, + {0x1b, 0x00060a00}, {0x1c, 0x000fc378}, + {0x1d, 0x000a1250}, {0x1e, 0x0000024f}, + {0x1f, 0x00000000}, {0x20, 0x0000b614}, + {0x21, 0x0006c000}, {0x22, 0x00000000}, + {0x23, 0x00001558}, {0x24, 0x00000060}, + {0x25, 0x00000483}, {0x26, 0x0004f000}, + {0x27, 0x000ec7d9}, {0x28, 0x00057730}, + {0x29, 0x00004783}, {0x2a, 0x00000001}, + {0x2b, 0x00021334}, {0x2a, 0x00000000}, + {0x2b, 0x00000054}, {0x2a, 0x00000001}, + {0x2b, 0x00000808}, {0x2b, 0x00053333}, + {0x2c, 0x0000000c}, {0x2a, 0x00000002}, + {0x2b, 0x00000808}, {0x2b, 0x0005b333}, + {0x2c, 0x0000000d}, {0x2a, 0x00000003}, + {0x2b, 0x00000808}, {0x2b, 0x00063333}, + {0x2c, 0x0000000d}, {0x2a, 0x00000004}, + {0x2b, 0x00000808}, {0x2b, 0x0006b333}, + {0x2c, 0x0000000d}, {0x2a, 0x00000005}, + {0x2b, 0x00000808}, {0x2b, 0x00073333}, + {0x2c, 0x0000000d}, {0x2a, 0x00000006}, + {0x2b, 0x00000709}, {0x2b, 0x0005b333}, + {0x2c, 0x0000000d}, {0x2a, 0x00000007}, + {0x2b, 0x00000709}, {0x2b, 0x00063333}, + {0x2c, 0x0000000d}, {0x2a, 0x00000008}, + {0x2b, 0x0000060a}, {0x2b, 0x0004b333}, + {0x2c, 0x0000000d}, {0x2a, 0x00000009}, + {0x2b, 0x0000060a}, {0x2b, 0x00053333}, + {0x2c, 0x0000000d}, {0x2a, 0x0000000a}, + {0x2b, 0x0000060a}, {0x2b, 0x0005b333}, + {0x2c, 0x0000000d}, {0x2a, 0x0000000b}, + {0x2b, 0x0000060a}, {0x2b, 0x00063333}, + {0x2c, 0x0000000d}, {0x2a, 0x0000000c}, + {0x2b, 0x0000060a}, {0x2b, 0x0006b333}, + {0x2c, 0x0000000d}, {0x2a, 0x0000000d}, + {0x2b, 0x0000060a}, {0x2b, 0x00073333}, + {0x2c, 0x0000000d}, {0x2a, 0x0000000e}, + {0x2b, 0x0000050b}, {0x2b, 0x00066666}, + {0x2c, 0x0000001a}, {0x2a, 0x000e0000}, + {0x10, 0x0004000f}, {0x11, 0x000e31fc}, + {0x10, 0x0006000f}, {0x11, 0x000ff9f8}, + {0x10, 0x0002000f}, {0x11, 0x000203f9}, + {0x10, 0x0003000f}, {0x11, 0x000ff500}, + {0x10, 0x00000000}, {0x11, 0x00000000}, + {0x10, 0x0008000f}, {0x11, 0x0003f100}, + {0x10, 0x0009000f}, {0x11, 0x00023100}, + {0x12, 0x00032000}, {0x12, 0x00071000}, + {0x12, 0x000b0000}, {0x12, 0x000fc000}, + {0x13, 0x000287b3}, {0x13, 0x000244b7}, + {0x13, 0x000204ab}, {0x13, 0x0001c49f}, + {0x13, 0x00018493}, {0x13, 0x0001429b}, + {0x13, 0x00010299}, {0x13, 0x0000c29c}, + {0x13, 0x000081a0}, {0x13, 0x000040ac}, + {0x13, 0x00000020}, {0x14, 0x0001944c}, + {0x14, 0x00059444}, {0x14, 0x0009944c}, + {0x14, 0x000d9444}, +#if 0 /* Only for PCIE */ + {0xff0f011f, 0xabcd}, + {0x15, 0x0000f424}, + {0x15, 0x0004f424}, + {0x15, 0x0008f424}, + {0x15, 0x000cf424}, + {0xcdcdcdcd, 0xcdcd}, +#endif + {0x15, 0x0000f474}, {0x15, 0x0004f477}, + {0x15, 0x0008f455}, {0x15, 0x000cf455}, +#if 0 + {0xff0f011f, 0xdead}, +#endif + {0x16, 0x00000339}, {0x16, 0x00040339}, + {0x16, 0x00080339}, +#if 0 /* Only for PCIE */ + {0xff0f011f, 0xabcd}, + {0x16, 0x000c0356}, + {0xcdcdcdcd, 0xcdcd}, +#endif + {0x16, 0x000c0366}, +#if 0 + {0xff0f011f, 0xdead}, +#endif + {0x00, 0x00010159}, {0x18, 0x0000f401}, + {0xfe, 0x00000000}, {0xfe, 0x00000000}, + {0x1f, 0x00000003}, {0xfe, 0x00000000}, + {0xfe, 0x00000000}, {0x1e, 0x00000247}, + {0x1f, 0x00000000}, {0x00, 0x00030159}, + {0xff, 0xffffffff} +}; + +static u8 rtl8723au_read8(struct rtl8xxxu_priv *priv, u16 addr) +{ + struct usb_device *udev = priv->udev; + int len; + u8 data; + + mutex_lock(&priv->usb_buf_mutex); + len = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), + REALTEK_USB_CMD_REQ, REALTEK_USB_READ, + addr, 0, &priv->usb_buf.val8, sizeof(u8), + RTW_USB_CONTROL_MSG_TIMEOUT); + data = priv->usb_buf.val8; + mutex_unlock(&priv->usb_buf_mutex); + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_REG_READ) + dev_info(&udev->dev, "%s(%04x) = 0x%02x, len %i\n", + __func__, addr, data, len); + return data; +} + +static u16 rtl8723au_read16(struct rtl8xxxu_priv *priv, u16 addr) +{ + struct usb_device *udev = priv->udev; + int len; + u16 data; + + mutex_lock(&priv->usb_buf_mutex); + len = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), + REALTEK_USB_CMD_REQ, REALTEK_USB_READ, + addr, 0, &priv->usb_buf.val16, sizeof(u16), + RTW_USB_CONTROL_MSG_TIMEOUT); + data = le16_to_cpu(priv->usb_buf.val16); + mutex_unlock(&priv->usb_buf_mutex); + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_REG_READ) + dev_info(&udev->dev, "%s(%04x) = 0x%04x, len %i\n", + __func__, addr, data, len); + return data; +} + +static u32 rtl8723au_read32(struct rtl8xxxu_priv *priv, u16 addr) +{ + struct usb_device *udev = priv->udev; + int len; + u32 data; + + mutex_lock(&priv->usb_buf_mutex); + len = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), + REALTEK_USB_CMD_REQ, REALTEK_USB_READ, + addr, 0, &priv->usb_buf.val32, sizeof(u32), + RTW_USB_CONTROL_MSG_TIMEOUT); + data = le32_to_cpu(priv->usb_buf.val32); + mutex_unlock(&priv->usb_buf_mutex); + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_REG_READ) + dev_info(&udev->dev, "%s(%04x) = 0x%08x, len %i\n", + __func__, addr, data, len); + return data; +} + +static int rtl8723au_write8(struct rtl8xxxu_priv *priv, u16 addr, u8 val) +{ + struct usb_device *udev = priv->udev; + int ret; + + mutex_lock(&priv->usb_buf_mutex); + priv->usb_buf.val8 = val; + ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), + REALTEK_USB_CMD_REQ, REALTEK_USB_WRITE, + addr, 0, &priv->usb_buf.val8, sizeof(u8), + RTW_USB_CONTROL_MSG_TIMEOUT); + + mutex_unlock(&priv->usb_buf_mutex); + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_REG_WRITE) + dev_info(&udev->dev, "%s(%04x) = 0x%02x\n", + __func__, addr, val); + return ret; +} + +static int rtl8723au_write16(struct rtl8xxxu_priv *priv, u16 addr, u16 val) +{ + struct usb_device *udev = priv->udev; + int ret; + + mutex_lock(&priv->usb_buf_mutex); + priv->usb_buf.val16 = cpu_to_le16(val); + ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), + REALTEK_USB_CMD_REQ, REALTEK_USB_WRITE, + addr, 0, &priv->usb_buf.val16, sizeof(u16), + RTW_USB_CONTROL_MSG_TIMEOUT); + mutex_unlock(&priv->usb_buf_mutex); + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_REG_WRITE) + dev_info(&udev->dev, "%s(%04x) = 0x%04x\n", + __func__, addr, val); + return ret; +} + +static int rtl8723au_write32(struct rtl8xxxu_priv *priv, u16 addr, u32 val) +{ + struct usb_device *udev = priv->udev; + int ret; + + mutex_lock(&priv->usb_buf_mutex); + priv->usb_buf.val32 = cpu_to_le32(val); + ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), + REALTEK_USB_CMD_REQ, REALTEK_USB_WRITE, + addr, 0, &priv->usb_buf.val32, sizeof(u32), + RTW_USB_CONTROL_MSG_TIMEOUT); + mutex_unlock(&priv->usb_buf_mutex); + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_REG_WRITE) + dev_info(&udev->dev, "%s(%04x) = 0x%08x\n", + __func__, addr, val); + return ret; +} + +static int +rtl8723au_writeN(struct rtl8xxxu_priv *priv, u16 addr, u8 *buf, u16 len) +{ + struct usb_device *udev = priv->udev; + int ret; + + ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), + REALTEK_USB_CMD_REQ, REALTEK_USB_WRITE, + addr, 0, buf, len, RTW_USB_CONTROL_MSG_TIMEOUT); + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_REG_WRITE) + dev_info(&udev->dev, "%s(%04x) = %p, len 0x%02x\n", + __func__, addr, buf, len); + return ret; +} + +static u32 rtl8723au_read_rfreg(struct rtl8xxxu_priv *priv, u8 reg) +{ + u32 hssia, val32, retval; + + hssia = rtl8723au_read32(priv, REG_FPGA0_XA_HSSI_PARM2); + /* + * For path B it seems we should be reading REG_FPGA0_XB_HSSI_PARM1 + * into val32 + */ + val32 = hssia; + val32 &= ~FPGA0_HSSI_PARM2_ADDR_MASK; + val32 |= (reg << FPGA0_HSSI_PARM2_ADDR_SHIFT) | + FPGA0_HSSI_PARM2_EDGE_READ; + rtl8723au_write32(priv, REG_FPGA0_XA_HSSI_PARM2, + hssia &= ~FPGA0_HSSI_PARM2_EDGE_READ); + udelay(10); + /* Here use XB for path B */ + rtl8723au_write32(priv, REG_FPGA0_XA_HSSI_PARM2, val32); + udelay(100); + rtl8723au_write32(priv, REG_FPGA0_XA_HSSI_PARM2, + hssia |= FPGA0_HSSI_PARM2_EDGE_READ); + udelay(10); + /* Use XB for path B */ + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_HSSI_PARM1); + if (val32 & BIT(8)) /* RF PI enabled */ + retval = rtl8723au_read32(priv, REG_HSPI_XA_READBACK); + else + retval = rtl8723au_read32(priv, REG_FPGA0_XA_LSSI_READBACK); + + retval &= 0xfffff; + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_RFREG_READ) + dev_info(&priv->udev->dev, "%s(%02x) = 0x%06x\n", + __func__, reg, retval); + return retval; +} + +static int rtl8723au_write_rfreg(struct rtl8xxxu_priv *priv, u8 reg, u32 data) +{ + int ret, retval; + u32 dataaddr; + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_RFREG_WRITE) + dev_info(&priv->udev->dev, "%s(%02x) = 0x%06x\n", + __func__, reg, data); + + data &= FPGA0_LSSI_PARM_DATA_MASK; + dataaddr = (reg << FPGA0_LSSI_PARM_ADDR_SHIFT) | data; + + /* Use XB for path B */ + ret = rtl8723au_write32(priv, REG_FPGA0_XA_LSSI_PARM, dataaddr); + if (ret != sizeof(dataaddr)) + retval = -EIO; + else + retval = 0; + + udelay(1); + + return retval; +} + +static int rtl8723a_h2c_cmd(struct rtl8xxxu_priv *priv, struct h2c_cmd *h2c) +{ + struct device *dev = &priv->udev->dev; + int mbox_nr, retry, retval = 0; + int mbox_reg, mbox_ext_reg; + u8 val8; + + mbox_nr = priv->next_mbox; + + mbox_reg = REG_HMBOX_0 + (mbox_nr * 4); + mbox_ext_reg = REG_HMBOX_EXT_0 + (mbox_nr * 2); + + mutex_lock(&priv->h2c_mutex); + /* + * MBOX ready? + */ + retry = 100; + do { + val8 = rtl8723au_read8(priv, REG_HMTFR); + if (!(val8 & BIT(mbox_nr))) + break; + } while (retry--); + + if (!retry) { + dev_dbg(dev, "%s: Mailbox busy\n", __func__); + retval = -EBUSY; + goto error; + } + + /* + * Need to swap as it's being swapped again by rtl8723au_write16/32() + */ + if (h2c->cmd.cmd & H2C_EXT) { + rtl8723au_write16(priv, mbox_ext_reg, + le16_to_cpu(h2c->raw.ext)); + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_H2C) + dev_info(dev, "H2C_EXT %04x\n", + le16_to_cpu(h2c->raw.ext)); + } + rtl8723au_write32(priv, mbox_reg, le32_to_cpu(h2c->raw.data)); + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_H2C) + dev_info(dev, "H2C %08x\n", le16_to_cpu(h2c->raw.data)); + + priv->next_mbox = (mbox_nr + 1) % H2C_MAX_MBOX; + +error: + mutex_unlock(&priv->h2c_mutex); + return retval; +} + +static void rtl8723a_enable_rf(struct rtl8xxxu_priv *priv) +{ + u8 val8; + u32 val32; + + val8 = rtl8723au_read8(priv, REG_SPS0_CTRL); + val8 |= BIT(0) | BIT(3); + rtl8723au_write8(priv, REG_SPS0_CTRL, val8); + + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_RF_PARM); + val32 &= ~(BIT(4) | BIT(5)); + val32 |= BIT(3); + rtl8723au_write32(priv, REG_FPGA0_XA_RF_PARM, val32); + + val32 = rtl8723au_read32(priv, REG_OFDM0_TRX_PATH_ENABLE); + val32 &= ~(BIT(4) | BIT(5) | BIT(6) | BIT(7)); + val32 |= BIT(4); + rtl8723au_write32(priv, REG_OFDM0_TRX_PATH_ENABLE, val32); + + val32 = rtl8723au_read32(priv, REG_FPGA0_RF_MODE); + val32 &= ~FPGA_RF_MODE_JAPAN; + rtl8723au_write32(priv, REG_FPGA0_RF_MODE, val32); + + rtl8723au_write32(priv, REG_RX_WAIT_CCA, 0x631B25A0); + + rtl8723au_write_rfreg(priv, RF6052_REG_AC, 0x32d95); + +#if 0 + rtl8723au_write8(priv, REG_SYS_FUNC, 0xE3); + rtl8723au_write8(priv, REG_APSD_CTRL, 0x00); + rtl8723au_write8(priv, REG_SYS_FUNC, 0xE2); + rtl8723au_write8(priv, REG_SYS_FUNC, 0xE3); +#endif + rtl8723au_write8(priv, REG_TXPAUSE, 0x00); +} + +static void rtl8723a_disable_rf(struct rtl8xxxu_priv *priv) +{ + u8 sps0; + u32 val32; + + rtl8723au_write8(priv, REG_TXPAUSE, 0xff); + + sps0 = rtl8723au_read8(priv, REG_SPS0_CTRL); + + /* RF RX code for preamble power saving */ + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_RF_PARM); + val32 &= ~(BIT(3) | BIT(4) | BIT(5)); + rtl8723au_write32(priv, REG_FPGA0_XA_RF_PARM, val32); + + /* Disable all packet detection for all four paths */ + val32 = rtl8723au_read32(priv, REG_OFDM0_TRX_PATH_ENABLE); + val32 &= ~(BIT(4) | BIT(5) | BIT(6) | BIT(7)); + rtl8723au_write32(priv, REG_OFDM0_TRX_PATH_ENABLE, val32); + + /* Enable power saving */ + val32 = rtl8723au_read32(priv, REG_FPGA0_RF_MODE); + val32 |= FPGA_RF_MODE_JAPAN; + rtl8723au_write32(priv, REG_FPGA0_RF_MODE, val32); + + /* AFE control register to power down bits [30:22] */ + rtl8723au_write32(priv, REG_RX_WAIT_CCA, 0x001b25a0); + + /* Power down RF module */ + rtl8723au_write_rfreg(priv, RF6052_REG_AC, 0); + + sps0 &= ~(BIT(0) | BIT(3)); + rtl8723au_write8(priv, REG_SPS0_CTRL, sps0); +} + + +static void rtl8723a_stop_tx_beacon(struct rtl8xxxu_priv *priv) +{ + u8 val8; + + val8 = rtl8723au_read8(priv, REG_FWHW_TXQ_CTRL + 2); + val8 &= ~BIT(6); + val8 = 0x00; /* FIXME */ + rtl8723au_write8(priv, REG_FWHW_TXQ_CTRL + 2, val8); + + rtl8723au_write8(priv, REG_TBTT_PROHIBIT + 1, 0x64); + val8 = rtl8723au_read8(priv, REG_TBTT_PROHIBIT + 2); + val8 &= ~BIT(0); + val8 = 0x00; /* FIXME */ + rtl8723au_write8(priv, REG_TBTT_PROHIBIT + 2, val8); +} + + +/* + * The rtl8723a has 3 channel groups for it's efuse settings. It only + * supports the 2.4GHz band, so channels 1 - 14: + * group 0: channels 1 - 3 + * group 1: channels 4 - 9 + * group 2: channels 10 - 14 + * + * Note: We index from 0 in the code + */ +static int rtl8723a_channel_to_group(int channel) +{ + int group; + + if (channel < 4) + group = 0; + else if (channel < 10) + group = 1; + else + group = 2; + + return group; +} + +static void rtl8723au_config_channel(struct ieee80211_hw *hw) +{ + struct rtl8xxxu_priv *priv = hw->priv; + u32 val32, rsr; + u8 val8, opmode; + bool ht = true; + int sec_ch_above; + + val32 = rtl8723au_read_rfreg(priv, RF6052_REG_MODE_AG); + val32 &= ~MODE_AG_CHANNEL_MASK; + val32 |= hw->conf.chandef.chan->hw_value; + rtl8723au_write_rfreg(priv, RF6052_REG_MODE_AG, val32); + + opmode = rtl8723au_read8(priv, REG_BW_OPMODE); + rsr = rtl8723au_read32(priv, REG_RESPONSE_RATE_SET); + + switch (hw->conf.chandef.width) { + case NL80211_CHAN_WIDTH_20_NOHT: + ht = false; + case NL80211_CHAN_WIDTH_20: + opmode |= BW_OPMODE_20MHZ; + rtl8723au_write8(priv, REG_BW_OPMODE, opmode); + + val32 = rtl8723au_read32(priv, REG_FPGA0_RF_MODE); + val32 &= ~FPGA_RF_MODE; + rtl8723au_write32(priv, REG_FPGA0_RF_MODE, val32); + + val32 = rtl8723au_read32(priv, REG_FPGA1_RF_MODE); + val32 &= ~FPGA_RF_MODE; + rtl8723au_write32(priv, REG_FPGA1_RF_MODE, val32); + + val32 = rtl8723au_read32(priv, REG_FPGA0_ANALOG2); + val32 |= BIT(10); + rtl8723au_write32(priv, REG_FPGA0_ANALOG2, val32); + break; + case NL80211_CHAN_WIDTH_40: + if (hw->conf.chandef.center_freq1 > + hw->conf.chandef.chan->center_freq) + sec_ch_above = 1; + else + sec_ch_above = 0; + + opmode &= ~BW_OPMODE_20MHZ; + rtl8723au_write8(priv, REG_BW_OPMODE, opmode); + rsr &= ~RSR_RSC_BANDWIDTH_40M; + if (sec_ch_above) + rsr |= RSR_RSC_UPPER_SUB_CHANNEL; + else + rsr |= RSR_RSC_LOWER_SUB_CHANNEL; + rtl8723au_write32(priv, REG_RESPONSE_RATE_SET, rsr); + + val32 = rtl8723au_read32(priv, REG_FPGA0_RF_MODE); + val32 |= FPGA_RF_MODE; + rtl8723au_write32(priv, REG_FPGA0_RF_MODE, val32); + + val32 = rtl8723au_read32(priv, REG_FPGA1_RF_MODE); + val32 |= FPGA_RF_MODE; + rtl8723au_write32(priv, REG_FPGA1_RF_MODE, val32); + + /* + * Set Control channel to upper or lower. These settings + * are required only for 40MHz + */ + val32 = rtl8723au_read32(priv, REG_CCK0_SYSTEM); + val32 &= ~CCK0_SIDEBAND; + if (!sec_ch_above) + val32 |= CCK0_SIDEBAND; + rtl8723au_write32(priv, REG_CCK0_SYSTEM, val32); + + val32 = rtl8723au_read32(priv, REG_OFDM1_LSTF); + val32 &= ~(BIT(10) | BIT(11)); /* 0xc00 */ + if (sec_ch_above) + val32 |= BIT(10); + else + val32 |= BIT(11); + rtl8723au_write32(priv, REG_OFDM1_LSTF, val32); + + val32 = rtl8723au_read32(priv, REG_FPGA0_ANALOG2); + val32 &= ~BIT(10); + rtl8723au_write32(priv, REG_FPGA0_ANALOG2, val32); + + val32 = rtl8723au_read32(priv, REG_FPGA0_POWER_SAVE); + val32 &= ~(FPGA0_PS_LOWER_CHANNEL | FPGA0_PS_UPPER_CHANNEL); + if (sec_ch_above) + val32 |= FPGA0_PS_UPPER_CHANNEL; + else + val32 |= FPGA0_PS_LOWER_CHANNEL; + rtl8723au_write32(priv, REG_FPGA0_POWER_SAVE, val32); + break; + + default: + break; + } + + if (ht) + val8 = 0x0e; + else + val8 = 0x0a; + + rtl8723au_write8(priv, REG_SIFS_CCK + 1, val8); + rtl8723au_write8(priv, REG_SIFS_OFDM + 1, val8); + + rtl8723au_write16(priv, REG_R2T_SIFS, 0x0808); + rtl8723au_write16(priv, REG_T2T_SIFS, 0x0a0a); + + val32 = rtl8723au_read_rfreg(priv, RF6052_REG_MODE_AG); + if (hw->conf.chandef.width == NL80211_CHAN_WIDTH_40) + val32 &= ~MODE_AG_CHANNEL_20MHZ; + else + val32 |= MODE_AG_CHANNEL_20MHZ; + rtl8723au_write_rfreg(priv, RF6052_REG_MODE_AG, val32); +} + +static void +rtl8723a_set_tx_power(struct rtl8xxxu_priv *priv, int channel, bool ht40) +{ + struct rtl8723au_efuse *efuse; + u8 cck[RTL8723A_MAX_RF_PATHS], ofdm[RTL8723A_MAX_RF_PATHS]; + u8 ofdmbase[RTL8723A_MAX_RF_PATHS], mcsbase[RTL8723A_MAX_RF_PATHS]; + u32 val32, ofdm_a, ofdm_b, mcs_a, mcs_b; + u8 val8; + int group, i; + + efuse = &priv->efuse_wifi.efuse; + + group = rtl8723a_channel_to_group(channel); + + cck[0] = efuse->cck_tx_power_index_A[group]; + ofdm[0] = efuse->ht40_1s_tx_power_index_A[group]; + + if (priv->rf_paths > 1) { + cck[1] = efuse->cck_tx_power_index_B[group]; + ofdm[1] = efuse->ht40_1s_tx_power_index_B[group]; + } else { + cck[1] = 0; + ofdm[1] = 0; + } + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_CHANNEL) + dev_info(&priv->udev->dev, + "%s: Setting TX power CCK A: %02x, " + "CCK B: %02x, OFDM A: %02x, OFDM B: %02x\n", + __func__, cck[0], cck[1], ofdm[0], ofdm[1]); + + for (i = 0; i < RTL8723A_MAX_RF_PATHS; i++) { + if (cck[i] > RF6052_MAX_TX_PWR) + cck[i] = RF6052_MAX_TX_PWR; + if (ofdm[i] > RF6052_MAX_TX_PWR) + ofdm[i] = RF6052_MAX_TX_PWR; + } + + val32 = rtl8723au_read32(priv, REG_TX_AGC_A_CCK1_MCS32); + val32 &= 0xffff00ff; + val32 |= (cck[0] << 8); + rtl8723au_write32(priv, REG_TX_AGC_A_CCK1_MCS32, val32); + + val32 = rtl8723au_read32(priv, REG_TX_AGC_B_CCK11_A_CCK2_11); + val32 &= 0xff; + val32 |= ((cck[0] << 8) | (cck[0] << 16) | (cck[0] << 24)); + rtl8723au_write32(priv, REG_TX_AGC_B_CCK11_A_CCK2_11, val32); + + val32 = rtl8723au_read32(priv, REG_TX_AGC_B_CCK11_A_CCK2_11); + val32 &= 0xffffff00; + val32 |= cck[1]; + rtl8723au_write32(priv, REG_TX_AGC_B_CCK11_A_CCK2_11, val32); + + val32 = rtl8723au_read32(priv, REG_TX_AGC_B_CCK1_55_MCS32); + val32 &= 0xff; + val32 |= ((cck[1] << 8) | (cck[1] << 16) | (cck[1] << 24)); + rtl8723au_write32(priv, REG_TX_AGC_B_CCK1_55_MCS32, val32); + + ofdmbase[0] = ofdm[0] + efuse->ofdm_tx_power_index_diff[group].a; + mcsbase[0] = ofdm[0]; + if (!ht40) + mcsbase[0] += efuse->ht20_tx_power_index_diff[group].a; + + ofdmbase[1] = ofdm[1] + efuse->ofdm_tx_power_index_diff[group].b; + mcsbase[1] = ofdm[1]; + if (!ht40) + mcsbase[1] += efuse->ht20_tx_power_index_diff[group].b; + + ofdm_a = ofdmbase[0] | ofdmbase[0] << 8 | + ofdmbase[0] << 16 | ofdmbase[0] << 24; + ofdm_b = ofdmbase[1] | ofdmbase[1] << 8 | + ofdmbase[1] << 16 | ofdmbase[1] << 24; + rtl8723au_write32(priv, REG_TX_AGC_A_RATE18_06, ofdm_a); + rtl8723au_write32(priv, REG_TX_AGC_B_RATE18_06, ofdm_b); + + rtl8723au_write32(priv, REG_TX_AGC_A_RATE54_24, ofdm_a); + rtl8723au_write32(priv, REG_TX_AGC_B_RATE54_24, ofdm_b); + + mcs_a = mcsbase[0] | mcsbase[0] << 8 | + mcsbase[0] << 16 | mcsbase[0] << 24; + mcs_b = mcsbase[1] | mcsbase[1] << 8 | + mcsbase[1] << 16 | mcsbase[1] << 24; + + rtl8723au_write32(priv, REG_TX_AGC_A_MCS03_MCS00, mcs_a); + rtl8723au_write32(priv, REG_TX_AGC_B_MCS03_MCS00, mcs_b); + + rtl8723au_write32(priv, REG_TX_AGC_A_MCS07_MCS04, mcs_a); + rtl8723au_write32(priv, REG_TX_AGC_B_MCS07_MCS04, mcs_b); + + rtl8723au_write32(priv, REG_TX_AGC_A_MCS11_MCS08, mcs_a); + rtl8723au_write32(priv, REG_TX_AGC_B_MCS11_MCS08, mcs_b); + + rtl8723au_write32(priv, REG_TX_AGC_A_MCS15_MCS12, mcs_a); + for (i = 0; i < 3; i++) { + if (i != 2) + val8 = (mcsbase[0] > 8) ? (mcsbase[0] - 8) : 0; + else + val8 = (mcsbase[0] > 6) ? (mcsbase[0] - 6) : 0; + rtl8723au_write8(priv, REG_OFDM0_XC_TX_IQ_IMBALANCE + i, val8); + } + rtl8723au_write32(priv, REG_TX_AGC_B_MCS15_MCS12, mcs_b); + for (i = 0; i < 3; i++) { + if (i != 2) + val8 = (mcsbase[1] > 8) ? (mcsbase[1] - 8) : 0; + else + val8 = (mcsbase[1] > 6) ? (mcsbase[1] - 6) : 0; + rtl8723au_write8(priv, REG_OFDM0_XD_TX_IQ_IMBALANCE + i, val8); + } +} + +static void rtl8xxxu_set_linktype(struct rtl8xxxu_priv *priv, + enum nl80211_iftype linktype) +{ + u16 val8; + + val8 = rtl8723au_read16(priv, REG_MSR); + val8 &= ~MSR_LINKTYPE_MASK; + + switch (linktype) { + case NL80211_IFTYPE_UNSPECIFIED: + val8 |= MSR_LINKTYPE_NONE; + break; + case NL80211_IFTYPE_ADHOC: + val8 |= MSR_LINKTYPE_ADHOC; + break; + case NL80211_IFTYPE_STATION: + val8 |= MSR_LINKTYPE_STATION; + break; + case NL80211_IFTYPE_AP: + val8 |= MSR_LINKTYPE_AP; + break; + default: + goto out; + } + + rtl8723au_write8(priv, REG_MSR, val8); +out: + return; +} + +static void +rtl8xxxu_set_retry(struct rtl8xxxu_priv *priv, u16 short_retry, u16 long_retry) +{ + u16 val16; + + val16 = ((short_retry << RETRY_LIMIT_SHORT_SHIFT) & + RETRY_LIMIT_SHORT_MASK) | + ((long_retry << RETRY_LIMIT_LONG_SHIFT) & + RETRY_LIMIT_LONG_MASK); + + rtl8723au_write16(priv, REG_RETRY_LIMIT, val16); +} + +static void +rtl8xxxu_set_spec_sifs(struct rtl8xxxu_priv *priv, u16 cck, u16 ofdm) +{ + u16 val16; + + val16 = ((cck << SPEC_SIFS_CCK_SHIFT) & SPEC_SIFS_CCK_MASK) | + ((ofdm << SPEC_SIFS_OFDM_SHIFT) & SPEC_SIFS_OFDM_MASK); + + rtl8723au_write16(priv, REG_SPEC_SIFS, val16); +} + +static void rtl8xxxu_8723au_identify_chip(struct rtl8xxxu_priv *priv) +{ + struct device *dev = &priv->udev->dev; + u32 val32; + u16 val16; + char *cut; + + val32 = rtl8723au_read32(priv, REG_SYS_CFG); + priv->chip_cut = (val32 & SYS_CFG_CHIP_VERSION_MASK) >> + SYS_CFG_CHIP_VERSION_SHIFT; + switch (priv->chip_cut) { + case 0: + cut = "A"; + break; + case 1: + cut = "B"; + break; + default: + cut = "unknown"; + } + + val32 = rtl8723au_read32(priv, REG_GPIO_OUTSTS); + priv->rom_rev = (val32 & GPIO_RF_RL_ID) >> 28; + + val32 = rtl8723au_read32(priv, REG_MULTI_FUNC_CTRL); + if (val32 & MULTI_WIFI_FUNC_EN) + priv->has_wifi = 1; + if (val32 & MULTI_BT_FUNC_EN) + priv->has_bluetooth = 1; + if (val32 & MULTI_GPS_FUNC_EN) + priv->has_gps = 1; + + if (val32 & SYS_CFG_VENDOR_ID) + priv->vendor_umc = 1; + + /* The rtl8192 presumably can have 2 */ + priv->rf_paths = 1; + + val16 = rtl8723au_read16(priv, REG_NORMAL_SIE_EP_TX); + if (val16 & NORMAL_SIE_EP_TX_HIGH_MASK) { + priv->ep_tx_high_queue = 1; + priv->ep_tx_count++; + } + + if (val16 & NORMAL_SIE_EP_TX_NORMAL_MASK) { + priv->ep_tx_normal_queue = 1; + priv->ep_tx_count++; + } + + if (val16 & NORMAL_SIE_EP_TX_LOW_MASK) { + priv->ep_tx_low_queue = 1; + priv->ep_tx_count++; + } + + dev_info(dev, "RTL8723au rev %s, features: WiFi=%i, BT=%i, GPS=%i\n", + cut, priv->has_wifi, priv->has_bluetooth, priv->has_gps); + + dev_info(dev, "%s: RTL8723au number of TX queues: %i\n", + __func__, priv->ep_tx_count); +} + +static int +rtl8xxxu_read_efuse8(struct rtl8xxxu_priv *priv, u16 offset, u8 *data) +{ + int i; + u8 val8; + u32 val32; + + /* Write Address */ + rtl8723au_write8(priv, REG_EFUSE_CTRL + 1, offset & 0xff); + val8 = rtl8723au_read8(priv, REG_EFUSE_CTRL + 2); + val8 &= 0xfc; + val8 |= (offset >> 8) & 0x03; + rtl8723au_write8(priv, REG_EFUSE_CTRL + 2, val8); + + val8 = rtl8723au_read8(priv, REG_EFUSE_CTRL + 3); + rtl8723au_write8(priv, REG_EFUSE_CTRL + 3, val8 & 0x7f); + + /* Poll for data read */ + val32 = rtl8723au_read32(priv, REG_EFUSE_CTRL); + for (i = 0; i < RTL8XXXU_MAX_REG_POLL; i++) { + val32 = rtl8723au_read32(priv, REG_EFUSE_CTRL); + if (val32 & BIT(31)) + break; + } + + if (i == RTL8XXXU_MAX_REG_POLL) + return -EIO; + + udelay(50); + val32 = rtl8723au_read32(priv, REG_EFUSE_CTRL); + + *data = val32 & 0xff; + return 0; +} + +static int rtl8xxxu_read_efuse(struct rtl8xxxu_priv *priv) +{ + struct device *dev = &priv->udev->dev; + int i, ret = 0; + u8 val8, word_mask, header, extheader; + u16 val16, efuse_addr, offset; + u32 val32; + + val16 = rtl8723au_read16(priv, REG_9346CR); + if (val16 & EEPROM_ENABLE) + priv->has_eeprom = 1; + if (val16 & EEPROM_BOOT) + priv->boot_eeprom = 1; + + val32 = rtl8723au_read32(priv, REG_EFUSE_TEST); + val32 = (val32 & ~EFUSE_SELECT_MASK) | EFUSE_WIFI_SELECT; + rtl8723au_write32(priv, REG_EFUSE_TEST, val32); + + dev_dbg(dev, "Booting from %s\n", + priv->boot_eeprom ? "EEPROM" : "EFUSE"); + + rtl8723au_write8(priv, REG_EFUSE_ACCESS, EFUSE_ACCESS_ENABLE); + + /* 1.2V Power: From VDDON with Power Cut(0x0000[15]), default valid */ + val16 = rtl8723au_read16(priv, REG_SYS_ISO_CTRL); + if (!(val16 & SYS_ISO_PWC_EV12V)) { + val16 |= SYS_ISO_PWC_EV12V; + rtl8723au_write16(priv, REG_SYS_ISO_CTRL, val16); + } + /* Reset: 0x0000[28], default valid */ + val16 = rtl8723au_read16(priv, REG_SYS_FUNC); + if (!(val16 & SYS_FUNC_ELDR)) { + val16 |= SYS_FUNC_ELDR; + rtl8723au_write16(priv, REG_SYS_FUNC, val16); + } + + /* + * Clock: Gated(0x0008[5]) 8M(0x0008[1]) clock from ANA, default valid + */ + val16 = rtl8723au_read16(priv, REG_SYS_CLKR); + if (!(val16 & SYS_CLK_LOADER_ENABLE) || !(val16 & SYS_CLK_ANA8M)) { + val16 |= (SYS_CLK_LOADER_ENABLE | SYS_CLK_ANA8M); + rtl8723au_write16(priv, REG_SYS_CLKR, val16); + } + + /* Default value is 0xff */ + memset(priv->efuse_wifi.raw, 0xff, EFUSE_MAP_LEN_8723A); + + efuse_addr = 0; + while (efuse_addr < EFUSE_REAL_CONTENT_LEN_8723A) { + ret = rtl8xxxu_read_efuse8(priv, efuse_addr++, &header); + if (ret || header == 0xff) + goto exit; + + if ((header & 0x1f) == 0x0f) { /* extended header */ + offset = (header & 0xe0) >> 5; + + ret = rtl8xxxu_read_efuse8(priv, efuse_addr++, + &extheader); + if (ret) + goto exit; + /* All words disabled */ + if ((extheader & 0x0f) == 0x0f) + continue; + + offset |= ((extheader & 0xf0) >> 1); + word_mask = extheader & 0x0f; + } else { + offset = (header >> 4) & 0x0f; + word_mask = header & 0x0f; + } + + if (offset < EFUSE_MAX_SECTION_8723A) { + u16 map_addr; + /* Get word enable value from PG header */ + + /* We have 8 bits to indicate validity */ + map_addr = offset * 8; + if (map_addr >= EFUSE_MAP_LEN_8723A) { + dev_warn(dev, "%s: Illegal map_addr (%04x), " + "efuse corrupt!\n", + __func__, map_addr); + ret = -EINVAL; + goto exit; + } + for (i = 0; i < EFUSE_MAX_WORD_UNIT; i++) { + /* Check word enable condition in the section */ + if (!(word_mask & BIT(i))) { + ret = rtl8xxxu_read_efuse8(priv, + efuse_addr++, + &val8); + priv->efuse_wifi.raw[map_addr++] = val8; + + ret = rtl8xxxu_read_efuse8(priv, + efuse_addr++, + &val8); + priv->efuse_wifi.raw[map_addr++] = val8; + } else + map_addr += 2; + } + } else { + dev_warn(dev, + "%s: Illegal offset (%04x), efuse corrupt!\n", + __func__, offset); + ret = -EINVAL; + goto exit; + } + } + +exit: + rtl8723au_write8(priv, REG_EFUSE_ACCESS, EFUSE_ACCESS_DISABLE); + + if (priv->efuse_wifi.efuse.rtl_id != cpu_to_le16(0x8129)) + ret = EINVAL; + + return ret; +} + +static int rtl8xxxu_start_firmware(struct rtl8xxxu_priv *priv) +{ + struct device *dev = &priv->udev->dev; + int ret = 0, i; + u32 val32; + + /* Poll checksum report */ + for (i = 0; i < RTL8XXXU_FIRMWARE_POLL_MAX; i++) { + val32 = rtl8723au_read32(priv, REG_MCU_FW_DL); + if (val32 & MCU_FW_DL_CSUM_REPORT) + break; + } + + if (i == RTL8XXXU_FIRMWARE_POLL_MAX) { + dev_warn(dev, "Firmware checksum poll timed out\n"); + ret = -EAGAIN; + goto exit; + } + + val32 = rtl8723au_read32(priv, REG_MCU_FW_DL); + val32 |= MCU_FW_DL_READY; + val32 &= ~MCU_WINT_INIT_READY; + rtl8723au_write32(priv, REG_MCU_FW_DL, val32); + + /* Wait for firmware to become ready */ + for (i = 0; i < RTL8XXXU_FIRMWARE_POLL_MAX; i++) { + val32 = rtl8723au_read32(priv, REG_MCU_FW_DL); + if (val32 & MCU_WINT_INIT_READY) + break; + + udelay(100); + } + + if (i == RTL8XXXU_FIRMWARE_POLL_MAX) { + dev_warn(dev, "Firmware failed to start\n"); + ret = -EAGAIN; + goto exit; + } + +exit: + return ret; +} + +static int rtl8xxxu_download_firmware(struct rtl8xxxu_priv *priv) +{ + int pages, remainder, i, ret; + u8 val8; + u16 val16; + u32 val32; + u8 *fwptr; + + val8 = rtl8723au_read8(priv, REG_SYS_FUNC + 1); + val8 |= 4; + rtl8723au_write8(priv, REG_SYS_FUNC + 1, val8); + + /* 8051 enable */ + val16 = rtl8723au_read16(priv, REG_SYS_FUNC); + rtl8723au_write16(priv, REG_SYS_FUNC, val16 | SYS_FUNC_CPU_ENABLE); + + /* MCU firmware download enable */ + val8 = rtl8723au_read8(priv, REG_MCU_FW_DL); + rtl8723au_write8(priv, REG_MCU_FW_DL, val8 | MCU_FW_DL_ENABLE); + + /* 8051 reset */ + val32 = rtl8723au_read32(priv, REG_MCU_FW_DL); + rtl8723au_write32(priv, REG_MCU_FW_DL, val32 & ~BIT(19)); + + /* Reset firmware download checksum */ + val8 = rtl8723au_read8(priv, REG_MCU_FW_DL); + rtl8723au_write8(priv, REG_MCU_FW_DL, val8 | MCU_FW_DL_CSUM_REPORT); + + pages = priv->fw_size / RTL_FW_PAGE_SIZE; + remainder = priv->fw_size % RTL_FW_PAGE_SIZE; + + fwptr = priv->fw_data->data; + + for (i = 0; i < pages; i++) { + val8 = rtl8723au_read8(priv, REG_MCU_FW_DL + 2) & 0xF8; + rtl8723au_write8(priv, REG_MCU_FW_DL + 2, val8 | i); + + ret = rtl8723au_writeN(priv, REG_8723A_FW_START_ADDRESS, + fwptr, RTL_FW_PAGE_SIZE); + if (ret != RTL_FW_PAGE_SIZE) { + ret = -EAGAIN; + goto fw_abort; + } + + fwptr += RTL_FW_PAGE_SIZE; + } + + if (remainder) { + val8 = rtl8723au_read8(priv, REG_MCU_FW_DL + 2) & 0xF8; + rtl8723au_write8(priv, REG_MCU_FW_DL + 2, val8 | i); + ret = rtl8723au_writeN(priv, REG_8723A_FW_START_ADDRESS, + fwptr, remainder); + if (ret != remainder) { + ret = -EAGAIN; + goto fw_abort; + } + } + + ret = 0; +fw_abort: + /* MCU firmware download disable */ + val16 = rtl8723au_read16(priv, REG_MCU_FW_DL); + rtl8723au_write16(priv, REG_MCU_FW_DL, + val16 & (~MCU_FW_DL_ENABLE & 0xff)); + + return ret; +} + +static int rtl8xxxu_load_firmware(struct rtl8xxxu_priv *priv) +{ + struct device *dev = &priv->udev->dev; + const struct firmware *fw; + char *fw_name; + int ret = 0; + u16 signature; + + switch (priv->chip_cut) { + case 0: + fw_name = "rtlwifi/rtl8723aufw_A.bin"; + break; + case 1: + if (priv->enable_bluetooth) + fw_name = "rtlwifi/rtl8723aufw_B.bin"; + else + fw_name = "rtlwifi/rtl8723aufw_B_NoBT.bin"; + + break; + default: + return -EINVAL; + } + + dev_info(dev, "%s: Loading firmware %s\n", DRIVER_NAME, fw_name); + if (request_firmware(&fw, fw_name, &priv->udev->dev)) { + dev_warn(dev, "request_firmware(%s) failed\n", fw_name); + ret = -EAGAIN; + goto exit; + } + if (!fw) { + dev_warn(dev, "Firmware data not available\n"); + ret = -EINVAL; + goto exit; + } + + priv->fw_data = kmemdup(fw->data, fw->size, GFP_KERNEL); + priv->fw_size = fw->size - sizeof(struct rtl8xxxu_firmware_header); + + signature = le16_to_cpu(priv->fw_data->signature); + switch (signature & 0xfff0) { + case 0x92c0: + case 0x88c0: + case 0x2300: + break; + default: + ret = -EINVAL; + dev_warn(dev, "%s: Invalid firmware signature: 0x%04x\n", + __func__, signature); + } + + dev_info(dev, "Firmware revision %i.%i (signature 0x%04x)\n", + le16_to_cpu(priv->fw_data->major_version), + priv->fw_data->minor_version, signature); + +exit: + release_firmware(fw); + return ret; +} + +static void rtl8xxxu_firmware_self_reset(struct rtl8xxxu_priv *priv) +{ + u16 val16; + int i = 100; + + /* Inform 8051 to perform reset */ + rtl8723au_write8(priv, REG_HMTFR + 3, 0x20); + + for (i = 100; i > 0; i--) { + val16 = rtl8723au_read16(priv, REG_SYS_FUNC); + + if (!(val16 & SYS_FUNC_CPU_ENABLE)) { + dev_dbg(&priv->udev->dev, + "%s: Firmware self reset success!\n", __func__); + break; + } + udelay(50); + } + + if (!i) { + /* Force firmware reset */ + val16 = rtl8723au_read16(priv, REG_SYS_FUNC); + val16 &= ~SYS_FUNC_CPU_ENABLE; + rtl8723au_write16(priv, REG_SYS_FUNC, val16); + } +} + +static int +rtl8xxxu_init_mac(struct rtl8xxxu_priv *priv, struct rtl8xxxu_reg8val *array) +{ + int i, ret; + u16 reg; + u8 val; + + for (i = 0; ; i++) { + reg = array[i].reg; + val = array[i].val; + + if (reg == 0xffff && val == 0xff) + break; + + ret = rtl8723au_write8(priv, reg, val); + if (ret != 1) { + dev_warn(&priv->udev->dev, + "Failed to initialize MAC\n"); + return -EAGAIN; + } + } + + rtl8723au_write8(priv, REG_MAX_AGGR_NUM, 0x0a); + + return 0; +} + +static int rtl8xxxu_init_phy_regs(struct rtl8xxxu_priv *priv, + struct rtl8xxxu_reg32val *array) +{ + int i, ret; + u16 reg; + u32 val; + + for (i = 0; ; i++) { + reg = array[i].reg; + val = array[i].val; + + if (reg == 0xffff && val == 0xffffffff) + break; + + ret = rtl8723au_write32(priv, reg, val); + if (ret != sizeof(val)) { + dev_warn(&priv->udev->dev, + "Failed to initialize PHY\n"); + return -EAGAIN; + } + udelay(1); + } + + return 0; +} + +/* + * Most of this is black magic retrieved from the old rtl8723au driver + */ +static int rtl8xxxu_init_phy_bb(struct rtl8xxxu_priv *priv) +{ + u8 val8, ldoa15, ldov12d, lpldo, ldohci12; + u32 val32; + + /* + * Todo: The vendor driver maintains a table of PHY register + * addresses, which is initialized here. Do we need this? + */ + + val8 = rtl8723au_read8(priv, REG_AFE_PLL_CTRL); + udelay(2); + val8 |= AFE_PLL_320_ENABLE; + rtl8723au_write8(priv, REG_AFE_PLL_CTRL, val8); + udelay(2); + + rtl8723au_write8(priv, REG_AFE_PLL_CTRL + 1, 0xff); + udelay(2); + + val8 = rtl8723au_read8(priv, REG_SYS_FUNC); + val8 |= SYS_FUNC_BB_GLB_RSTN | SYS_FUNC_BBRSTB; + rtl8723au_write8(priv, REG_SYS_FUNC, val8); + + /* AFE_XTAL_RF_GATE (bit 14) if addressing as 32 bit register */ + val8 = rtl8723au_read8(priv, REG_AFE_XTAL_CTRL + 1); + val8 &= ~BIT(6); + rtl8723au_write8(priv, REG_AFE_XTAL_CTRL + 1, val8); + + /* AFE_XTAL_BT_GATE (bit 20) if addressing as 32 bit register */ + val8 = rtl8723au_read8(priv, REG_AFE_XTAL_CTRL + 2); + val8 &= ~BIT(4); + rtl8723au_write8(priv, REG_AFE_XTAL_CTRL + 2, val8); + + /* 6. 0x1f[7:0] = 0x07 */ + val8 = RF_ENABLE | RF_RSTB | RF_SDMRSTB; + rtl8723au_write8(priv, REG_RF_CTRL, val8); + + rtl8xxxu_init_phy_regs(priv, rtl8723a_phy_1t_init_table); + + rtl8xxxu_init_phy_regs(priv, rtl8723a_agc_1t_init_table); + if (priv->efuse_wifi.efuse.version >= 0x01) { + val32 = rtl8723au_read32(priv, REG_MAC_PHY_CTRL); + + val8 = priv->efuse_wifi.efuse.xtal_k & 0x3f; + val32 &= 0xff000fff; + val32 |= ((val8 | (val8 << 6)) << 12); + + rtl8723au_write32(priv, REG_MAC_PHY_CTRL, val32); + } + + ldoa15 = LDOA15_ENABLE | LDOA15_OBUF; + ldov12d = LDOV12D_ENABLE | BIT(2) | (2 << LDOV12D_VADJ_SHIFT); + ldohci12 = 0x57; + lpldo = 1; + val32 = (lpldo << 24) | (ldohci12 << 16) | (ldov12d << 8) | ldoa15; + + rtl8723au_write32(priv, REG_LDOA15_CTRL, val32); + + return 0; +} + +static int rtl8xxxu_init_rf_regs(struct rtl8xxxu_priv *priv, + struct rtl8xxxu_rfregval *array) +{ + int i, ret; + u8 reg; + u32 val; + + for (i = 0; ; i++) { + reg = array[i].reg; + val = array[i].val; + + if (reg == 0xff && val == 0xffffffff) + break; + + switch (reg) { + case 0xfe: + msleep(50); + continue; + case 0xfd: + mdelay(5); + continue; + case 0xfc: + mdelay(1); + continue; + case 0xfb: + udelay(50); + continue; + case 0xfa: + udelay(5); + continue; + case 0xf9: + udelay(1); + continue; + } + + reg &= 0x3f; + + ret = rtl8723au_write_rfreg(priv, reg, val); + if (ret) { + dev_warn(&priv->udev->dev, + "Failed to initialize RF\n"); + return -EAGAIN; + } + udelay(1); + } + + return 0; +} + +static int rtl8xxxu_init_phy_rf(struct rtl8xxxu_priv *priv) +{ + u32 val32; + u16 val16, rfsi_rfenv; + + /* For path B, use XB */ + rfsi_rfenv = rtl8723au_read16(priv, REG_FPGA0_XA_RF_SW_CTRL); + rfsi_rfenv &= FPGA0_RF_RFENV; + + /* + * These two we might be able to optimize into one + */ + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_RF_INT_OE); + val32 |= BIT(20); /* 0x10 << 16 */ + rtl8723au_write32(priv, REG_FPGA0_XA_RF_INT_OE, val32); + udelay(1); + + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_RF_INT_OE); + val32 |= BIT(4); + rtl8723au_write32(priv, REG_FPGA0_XA_RF_INT_OE, val32); + udelay(1); + + /* + * These two we might be able to optimize into one + */ + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_HSSI_PARM2); + val32 &= ~FPGA0_HSSI_3WIRE_ADDR_LEN; + rtl8723au_write32(priv, REG_FPGA0_XA_HSSI_PARM2, val32); + udelay(1); + + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_HSSI_PARM2); + val32 &= ~FPGA0_HSSI_3WIRE_DATA_LEN; + rtl8723au_write32(priv, REG_FPGA0_XA_HSSI_PARM2, val32); + udelay(1); + + rtl8xxxu_init_rf_regs(priv, rtl8723au_radioa_rf6052_1t_init_table); + + /* For path B, use XB */ + val16 = rtl8723au_read16(priv, REG_FPGA0_XA_RF_SW_CTRL); + val16 &= ~FPGA0_RF_RFENV; + val16 |= rfsi_rfenv; + rtl8723au_write16(priv, REG_FPGA0_XA_RF_SW_CTRL, val16); + + return 0; +} + +static int rtl8xxxu_llt_write(struct rtl8xxxu_priv *priv, u8 address, u8 data) +{ + int ret = -EBUSY; + int count = 0; + u32 value; + + value = LLT_OP_WRITE | address << 8 | data; + + rtl8723au_write32(priv, REG_LLT_INIT, value); + + do { + value = rtl8723au_read32(priv, REG_LLT_INIT); + if ((value & LLT_OP_MASK) == LLT_OP_INACTIVE) { + ret = 0; + break; + } + } while (count++ < 20); + + return ret; +} + +static int rtl8xxxu_init_llt_table(struct rtl8xxxu_priv *priv, u8 last_tx_page) +{ + int ret; + int i; + + for (i = 0; i < last_tx_page; i++) { + ret = rtl8xxxu_llt_write(priv, i, i + 1); + if (ret) + goto exit; + } + + ret = rtl8xxxu_llt_write(priv, last_tx_page, 0xff); + if (ret) + goto exit; + + /* Mark remaining pages as a ring buffer */ + for (i = last_tx_page + 1; i < 0xff; i++) { + ret = rtl8xxxu_llt_write(priv, i, (i + 1)); + if (ret) + goto exit; + } + + /* Let last entry point to the start entry of ring buffer */ + ret = rtl8xxxu_llt_write(priv, 0xff, last_tx_page + 1); + if (ret) + goto exit; + +exit: + return ret; +} + +static int rtl8xxxu_init_queue_priority(struct rtl8xxxu_priv *priv) +{ + u16 val16, hi, lo; + u16 hiq, mgq, bkq, beq, viq, voq; + int hip, mgp, bkp, bep, vip, vop; + int ret = 0; + + switch (priv->ep_tx_count) { + case 1: + if (priv->ep_tx_high_queue) { + hi = TRXDMA_QUEUE_HIGH; + } else if (priv->ep_tx_low_queue) { + hi = TRXDMA_QUEUE_LOW; + } else if (priv->ep_tx_normal_queue) { + hi = TRXDMA_QUEUE_NORMAL; + } else { + hi = 0; + ret = -EINVAL; + } + + hiq = hi; + mgq = hi; + bkq = hi; + beq = hi; + viq = hi; + voq = hi; + + hip = 0; + mgp = 0; + bkp = 0; + bep = 0; + vip = 0; + vop = 0; + break; + case 2: + if (priv->ep_tx_high_queue && priv->ep_tx_low_queue) { + hi = TRXDMA_QUEUE_HIGH; + lo = TRXDMA_QUEUE_LOW; + } else if (priv->ep_tx_normal_queue && priv->ep_tx_low_queue) { + hi = TRXDMA_QUEUE_NORMAL; + lo = TRXDMA_QUEUE_LOW; + } else if (priv->ep_tx_high_queue && priv->ep_tx_normal_queue) { + hi = TRXDMA_QUEUE_HIGH; + lo = TRXDMA_QUEUE_NORMAL; + } else { + ret = -EINVAL; + hi = 0; + lo = 0; + } + + hiq = hi; + mgq = hi; + bkq = lo; + beq = lo; + viq = hi; + voq = hi; + + hip = 0; + mgp = 0; + bkp = 1; + bep = 1; + vip = 0; + vop = 0; + break; + case 3: + beq = TRXDMA_QUEUE_LOW; + bkq = TRXDMA_QUEUE_LOW; + viq = TRXDMA_QUEUE_NORMAL; + voq = TRXDMA_QUEUE_HIGH; + mgq = TRXDMA_QUEUE_HIGH; + hiq = TRXDMA_QUEUE_HIGH; + + hip = hiq ^ 3; + mgp = mgq ^ 3; + bkp = bkq ^ 3; + bep = beq ^ 3; + vip = viq ^ 3; + vop = viq ^ 3; + break; + default: + ret = -EINVAL; + } + + /* + * None of the vendor drivers are configuring the beacon + * queue here .... why? + */ + if (!ret) { + val16 = rtl8723au_read16(priv, REG_TRXDMA_CTRL); + val16 &= 0x7; + val16 |= (voq << TRXDMA_CTRL_VOQ_SHIFT) | + (viq << TRXDMA_CTRL_VIQ_SHIFT) | + (beq << TRXDMA_CTRL_BEQ_SHIFT) | + (bkq << TRXDMA_CTRL_BKQ_SHIFT) | + (mgq << TRXDMA_CTRL_MGQ_SHIFT) | + (hiq << TRXDMA_CTRL_HIQ_SHIFT); + rtl8723au_write16(priv, REG_TRXDMA_CTRL, val16); + + priv->pipe_out[TXDESC_QUEUE_VO] = + usb_sndbulkpipe(priv->udev, priv->out_ep[vop]); + priv->pipe_out[TXDESC_QUEUE_VI] = + usb_sndbulkpipe(priv->udev, priv->out_ep[vip]); + priv->pipe_out[TXDESC_QUEUE_BE] = + usb_sndbulkpipe(priv->udev, priv->out_ep[bep]); + priv->pipe_out[TXDESC_QUEUE_BK] = + usb_sndbulkpipe(priv->udev, priv->out_ep[bkp]); + priv->pipe_out[TXDESC_QUEUE_BEACON] = + usb_sndbulkpipe(priv->udev, priv->out_ep[0]); + priv->pipe_out[TXDESC_QUEUE_MGNT] = + usb_sndbulkpipe(priv->udev, priv->out_ep[mgp]); + priv->pipe_out[TXDESC_QUEUE_HIGH] = + usb_sndbulkpipe(priv->udev, priv->out_ep[hip]); + priv->pipe_out[TXDESC_QUEUE_CMD] = + usb_sndbulkpipe(priv->udev, priv->out_ep[0]); + } + + return ret; +} + +static void rtl8xxxu_fill_iqk_matrix_a(struct rtl8xxxu_priv *priv, + bool iqk_ok, int result[][8], + int candidate, bool tx_only) +{ + u32 oldval, x, tx0_a, reg; + int y, tx0_c; + u32 val32; + + if (!iqk_ok) + return; + + val32 = rtl8723au_read32(priv, REG_OFDM0_XA_TX_IQ_IMBALANCE); + oldval = val32 >> 22; + + x = result[candidate][0]; + if ((x & 0x00000200) != 0) + x = x | 0xfffffc00; + tx0_a = (x * oldval) >> 8; + + val32 = rtl8723au_read32(priv, REG_OFDM0_XA_TX_IQ_IMBALANCE); + val32 &= ~0x3ff; + val32 |= tx0_a; + rtl8723au_write32(priv, REG_OFDM0_XA_TX_IQ_IMBALANCE, val32); + + val32 = rtl8723au_read32(priv, REG_OFDM0_ENERGY_CCA_THRES); + val32 &= ~BIT(31); + if ((x * oldval >> 7) & 0x1) + val32 |= BIT(31); + rtl8723au_write32(priv, REG_OFDM0_ENERGY_CCA_THRES, val32); + + y = result[candidate][1]; + if ((y & 0x00000200) != 0) + y = y | 0xfffffc00; + tx0_c = (y * oldval) >> 8; + + val32 = rtl8723au_read32(priv, REG_OFDM0_XC_TX_AFE); + val32 &= ~0xf0000000; + val32 |= (((tx0_c & 0x3c0) >> 6) << 28); + rtl8723au_write32(priv, REG_OFDM0_XC_TX_AFE, val32); + + val32 = rtl8723au_read32(priv, REG_OFDM0_XA_TX_IQ_IMBALANCE); + val32 &= ~0x003f0000; + val32 |= ((tx0_c & 0x3f) << 16); + rtl8723au_write32(priv, REG_OFDM0_XA_TX_IQ_IMBALANCE, val32); + + val32 = rtl8723au_read32(priv, REG_OFDM0_ENERGY_CCA_THRES); + val32 &= ~BIT(29); + if ((y * oldval >> 7) & 0x1) + val32 |= BIT(29); + rtl8723au_write32(priv, REG_OFDM0_ENERGY_CCA_THRES, val32); + + if (tx_only) { + dev_dbg(&priv->udev->dev, "%s: only TX\n", __func__); + return; + } + + reg = result[candidate][2]; + + val32 = rtl8723au_read32(priv, REG_OFDM0_XA_RX_IQ_IMBALANCE); + val32 &= ~0x3ff; + val32 |= (reg & 0x3ff); + rtl8723au_write32(priv, REG_OFDM0_XA_RX_IQ_IMBALANCE, val32); + + reg = result[candidate][3] & 0x3F; + + val32 = rtl8723au_read32(priv, REG_OFDM0_XA_RX_IQ_IMBALANCE); + val32 &= ~0xfc00; + val32 |= ((reg << 10) & 0xfc00); + rtl8723au_write32(priv, REG_OFDM0_XA_RX_IQ_IMBALANCE, val32); + + reg = (result[candidate][3] >> 6) & 0xF; + + val32 = rtl8723au_read32(priv, REG_OFDM0_RX_IQ_EXT_ANTA); + val32 &= ~0xf0000000; + val32 |= (reg << 28); + rtl8723au_write32(priv, REG_OFDM0_RX_IQ_EXT_ANTA, val32); +} + +#define MAX_TOLERANCE 5 + +static bool rtl8xxxu_simularity_compare(struct rtl8xxxu_priv *priv, + int result[][8], int c1, int c2) +{ + u32 i, j, diff, simubitmap, bound = 0; + int candidate[2] = {-1, -1}; /* for path A and path B */ + bool retval = true, is_2t = false; + + if (is_2t) + bound = 8; + else + bound = 4; + + simubitmap = 0; + + for (i = 0; i < bound; i++) { + diff = (result[c1][i] > result[c2][i]) ? + (result[c1][i] - result[c2][i]) : + (result[c2][i] - result[c1][i]); + if (diff > MAX_TOLERANCE) { + if ((i == 2 || i == 6) && !simubitmap) { + if (result[c1][i] + result[c1][i + 1] == 0) + candidate[(i / 4)] = c2; + else if (result[c2][i] + result[c2][i + 1] == 0) + candidate[(i / 4)] = c1; + else + simubitmap = simubitmap | (1 << i); + } else { + simubitmap = simubitmap | (1 << i); + } + } + } + + if (simubitmap == 0) { + for (i = 0; i < (bound / 4); i++) { + if (candidate[i] >= 0) { + for (j = i * 4; j < (i + 1) * 4 - 2; j++) + result[3][j] = result[candidate[i]][j]; + retval = false; + } + } + return retval; + } else if (!(simubitmap & 0x0f)) { + /* path A OK */ + for (i = 0; i < 4; i++) + result[3][i] = result[c1][i]; + } else if (!(simubitmap & 0xf0) && is_2t) { + /* path B OK */ + for (i = 4; i < 8; i++) + result[3][i] = result[c1][i]; + } + + return false; +} + +static void +rtl8xxxu_save_mac_regs(struct rtl8xxxu_priv *priv, u32 *reg, u32 *backup) +{ + int i; + + for (i = 0; i < (RTL8XXXU_MAC_REGS - 1); i++) + backup[i] = rtl8723au_read8(priv, reg[i]); + + backup[i] = rtl8723au_read32(priv, reg[i]); +} + +static void +rtl8xxxu_restore_mac_regs(struct rtl8xxxu_priv *priv, u32 *reg, u32 *backup) +{ + int i; + + for (i = 0; i < (RTL8XXXU_MAC_REGS - 1); i++) + rtl8723au_write8(priv, reg[i], backup[i]); + + rtl8723au_write32(priv, reg[i], backup[i]); +} + +static void rtl8xxxu_save_regs(struct rtl8xxxu_priv *priv, u32 *regs, + u32 *backup, int count) +{ + int i; + + for (i = 0; i < count; i++) + backup[i] = rtl8723au_read32(priv, regs[i]); +} + +static void rtl8xxxu_restore_regs(struct rtl8xxxu_priv *priv, u32 *regs, + u32 *backup, int count) +{ + int i; + + for (i = 0; i < count; i++) + rtl8723au_write32(priv, regs[i], backup[i]); +} + + +static void rtl8xxxu_path_adda_on(struct rtl8xxxu_priv *priv, u32 *regs, + bool path_a_on, bool is_2t) +{ + u32 path_on; + int i; + + path_on = path_a_on ? 0x04db25a4 : 0x0b1b25a4; + if (!is_2t) { + path_on = 0x0bdb25a0; + rtl8723au_write32(priv, regs[0], 0x0b1b25a0); + } else { + rtl8723au_write32(priv, regs[0], path_on); + } + + for (i = 1 ; i < RTL8XXXU_ADDA_REGS ; i++) + rtl8723au_write32(priv, regs[i], path_on); +} + +static void +rtl8xxxu_mac_calibration(struct rtl8xxxu_priv *priv, u32 *regs, u32 *backup) +{ + int i = 0; + + rtl8723au_write8(priv, regs[i], 0x3f); + + for (i = 1 ; i < (RTL8XXXU_MAC_REGS - 1); i++) { + rtl8723au_write8(priv, regs[i], + (u8)(backup[i] & ~BIT(3))); + } + rtl8723au_write8(priv, regs[i], (u8)(backup[i] & ~BIT(5))); +} + +static int rtl8xxxu_iqk_path_a(struct rtl8xxxu_priv *priv, bool configpathb) +{ + u32 reg_eac, reg_e94, reg_e9c, reg_ea4; + int result = 0; + + /* path-A IQK setting */ + rtl8723au_write32(priv, REG_TX_IQK_TONE_A, 0x10008c1f); + rtl8723au_write32(priv, REG_RX_IQK_TONE_A, 0x10008c1f); + rtl8723au_write32(priv, REG_TX_IQK_PI_A, 0x82140102); + + rtl8723au_write32(priv, REG_RX_IQK_PI_A, configpathb ? 0x28160202 : + /*IS_81xxC_VENDOR_UMC_B_CUT(pHalData->VersionID)?0x28160202: */ 0x28160502); + + /* path-B IQK setting */ + if (configpathb) { + rtl8723au_write32(priv, REG_TX_IQK_TONE_B, 0x10008c22); + rtl8723au_write32(priv, REG_RX_IQK_TONE_B, 0x10008c22); + rtl8723au_write32(priv, REG_TX_IQK_PI_B, 0x82140102); + rtl8723au_write32(priv, REG_RX_IQK_PI_B, 0x28160202); + } + + /* LO calibration setting */ + rtl8723au_write32(priv, REG_IQK_AGC_RSP, 0x001028d1); + + /* One shot, path A LOK & IQK */ + rtl8723au_write32(priv, REG_IQK_AGC_PTS, 0xf9000000); + rtl8723au_write32(priv, REG_IQK_AGC_PTS, 0xf8000000); + + mdelay(1); + + /* Check failed */ + reg_eac = rtl8723au_read32(priv, REG_RX_POWER_AFTER_IQK_A_2); + reg_e94 = rtl8723au_read32(priv, REG_TX_POWER_BEFORE_IQK_A); + reg_e9c = rtl8723au_read32(priv, REG_TX_POWER_AFTER_IQK_A); + reg_ea4 = rtl8723au_read32(priv, REG_RX_POWER_BEFORE_IQK_A_2); + + if (!(reg_eac & BIT(28)) && + ((reg_e94 & 0x03ff0000) != 0x01420000) && + ((reg_e9c & 0x03ff0000) != 0x00420000)) + result |= 0x01; + else /* If TX not OK, ignore RX */ + goto out; + + /* If TX is OK, check whether RX is OK */ + if (!(reg_eac & BIT(27)) && + ((reg_ea4 & 0x03ff0000) != 0x01320000) && + ((reg_eac & 0x03ff0000) != 0x00360000)) + result |= 0x02; + else + dev_warn(&priv->udev->dev, "%s: Path A RX IQK failed!\n", + __func__); +out: + return result; +} + +static void rtl8xxxu_phy_iqcalibrate(struct rtl8xxxu_priv *priv, + int result[][8], int t, bool is_2t) +{ + struct device *dev = &priv->udev->dev; + u32 i, val32; + int path_a_ok /*, path_b_ok */; + int retry = 2; + + u32 ADDA_REG[RTL8XXXU_ADDA_REGS] = { + REG_FPGA0_XCD_SWITCH_CTRL, REG_BLUETOOTH, + REG_RX_WAIT_CCA, REG_TX_CCK_RFON, + REG_TX_CCK_BBON, REG_TX_OFDM_RFON, + REG_TX_OFDM_BBON, REG_TX_TO_RX, + REG_TX_TO_TX, REG_RX_CCK, + REG_RX_OFDM, REG_RX_WAIT_RIFS, + REG_RX_TO_RX, REG_STANDBY, + REG_SLEEP, REG_PMPD_ANAEN + }; + + u32 IQK_MAC_REG[RTL8XXXU_MAC_REGS] = { + REG_TXPAUSE, REG_BEACON_CTRL, + REG_BEACON_CTRL_1, REG_GPIO_MUXCFG + }; + + u32 IQK_BB_REG_92C[RTL8XXXU_BB_REGS] = { + REG_OFDM0_TRX_PATH_ENABLE, REG_OFDM0_TR_MUX_PAR, + REG_FPGA0_XCD_RF_SW_CTRL, REG_CONFIG_ANT_A, REG_CONFIG_ANT_B, + REG_FPGA0_XAB_RF_SW_CTRL, REG_FPGA0_XA_RF_INT_OE, + REG_FPGA0_XB_RF_INT_OE, REG_FPGA0_RF_MODE + }; + + /* Note: IQ calibration must be performed after loading */ + /* PHY_REG.txt , and radio_a, radio_b.txt */ + + if (t == 0) { + /* Save ADDA parameters, turn Path A ADDA on */ + rtl8xxxu_save_regs(priv, ADDA_REG, priv->adda_backup, + RTL8XXXU_ADDA_REGS); + rtl8xxxu_save_mac_regs(priv, IQK_MAC_REG, priv->mac_backup); + rtl8xxxu_save_regs(priv, IQK_BB_REG_92C, + priv->bb_backup, RTL8XXXU_BB_REGS); + } + + rtl8xxxu_path_adda_on(priv, ADDA_REG, true, is_2t); + + if (t == 0) { + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_HSSI_PARM1); + if (val32 & FPGA0_HSSI_PARM1_PI) + priv->pi_enabled = 1; + } + + if (!priv->pi_enabled) { + /* Switch BB to PI mode to do IQ Calibration. */ + rtl8723au_write32(priv, REG_FPGA0_XA_HSSI_PARM1, + 0x01000100); + rtl8723au_write32(priv, REG_FPGA0_XB_HSSI_PARM1, + 0x01000100); + } + + val32 = rtl8723au_read32(priv, REG_FPGA0_RF_MODE); + val32 &= ~FPGA_RF_MODE_CCK; + rtl8723au_write32(priv, REG_FPGA0_RF_MODE, val32); + + rtl8723au_write32(priv, REG_OFDM0_TRX_PATH_ENABLE, 0x03a05600); + rtl8723au_write32(priv, REG_OFDM0_TR_MUX_PAR, 0x000800e4); + rtl8723au_write32(priv, REG_FPGA0_XCD_RF_SW_CTRL, 0x22204000); + + val32 = rtl8723au_read32(priv, REG_FPGA0_XAB_RF_SW_CTRL); + val32 |= (BIT(10) | BIT(26)); + rtl8723au_write32(priv, REG_FPGA0_XAB_RF_SW_CTRL, val32); + + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_RF_INT_OE); + val32 &= ~BIT(10); + rtl8723au_write32(priv, REG_FPGA0_XA_RF_INT_OE, val32); + val32 = rtl8723au_read32(priv, REG_FPGA0_XB_RF_INT_OE); + val32 &= ~BIT(10); + rtl8723au_write32(priv, REG_FPGA0_XB_RF_INT_OE, val32); + + if (is_2t) { + rtl8723au_write32(priv, REG_FPGA0_XA_LSSI_PARM, 0x00010000); + rtl8723au_write32(priv, REG_FPGA0_XB_LSSI_PARM, 0x00010000); + } + + /* MAC settings */ + rtl8xxxu_mac_calibration(priv, IQK_MAC_REG, priv->mac_backup); + + /* Page B init */ + rtl8723au_write32(priv, REG_CONFIG_ANT_A, 0x00080000); + + if (is_2t) + rtl8723au_write32(priv, REG_CONFIG_ANT_B, 0x00080000); + + /* IQ calibration setting */ + rtl8723au_write32(priv, REG_FPGA0_IQK, 0x80800000); + rtl8723au_write32(priv, REG_TX_IQK, 0x01007c00); + rtl8723au_write32(priv, REG_RX_IQK, 0x01004800); + + for (i = 0; i < retry; i++) { + path_a_ok = rtl8xxxu_iqk_path_a(priv, is_2t); + if (path_a_ok == 0x03) { + val32 = rtl8723au_read32(priv, + REG_TX_POWER_BEFORE_IQK_A); + result[t][0] = (val32 >> 16) & 0x3ff; + val32 = rtl8723au_read32(priv, + REG_TX_POWER_AFTER_IQK_A); + result[t][1] = (val32 >> 16) & 0x3ff; + val32 = rtl8723au_read32(priv, + REG_RX_POWER_BEFORE_IQK_A_2); + result[t][2] = (val32 >> 16) & 0x3ff; + val32 = rtl8723au_read32(priv, + REG_RX_POWER_AFTER_IQK_A_2); + result[t][3] = (val32 >> 16) & 0x3ff; + break; + } else if (i == (retry - 1) && path_a_ok == 0x01) { + /* TX IQK OK */ + dev_dbg(dev, "%s: Path A IQK Only Tx Success!!\n", + __func__); + + val32 = rtl8723au_read32(priv, + REG_TX_POWER_BEFORE_IQK_A); + result[t][0] = (val32 >> 16) & 0x3ff; + val32 = rtl8723au_read32(priv, + REG_TX_POWER_AFTER_IQK_A); + result[t][1] = (val32 >> 16) & 0x3ff; + } + } + + if (!path_a_ok) + dev_dbg(dev, "%s: Path A IQK failed!\n", __func__); + +#if 0 + if (is_2t) { + rtl8xxxu_phy_path_a_standby(priv); + + /* Turn Path B ADDA on */ + rtl8xxxu_phy_path_adda_on(priv, ADDA_REG, false, is_2t); + + for (i = 0; i < retry; i++) { + path_b_ok = _PHY_PathB_IQK(priv); + if (path_b_ok == 0x03) { + val32 = rtl8723au_read32(priv, REG_TX_POWER_BEFORE_IQK_B); + result[t][4] = (val32 >> 16) & 0x3ff; + val32 = rtl8723au_read32(priv, REG_TX_POWER_AFTER_IQK_B); + result[t][5] = (val32 >> 16) & 0x3ff; + val32 = rtl8723au_read32(priv, REG_RX_POWER_BEFORE_IQK_B_2); + result[t][6] = (val32 >> 16) & 0x3ff; + val32 = rtl8723au_read32(priv, REG_RX_POWER_AFTER_IQK_B_2); + result[t][7] = (val32 >> 16) & 0x3ff; + break; + } else if (i == (retry - 1) && path_b_ok == 0x01) { + /* TX IQK OK */ + val32 = rtl8723au_read32(priv, REG_TX_POWER_BEFORE_IQK_B); + result[t][4] = (val32 >> 16) & 0x3ff; + val32 = rtl8723au_read32(priv, REG_TX_POWER_AFTER_IQK_B); + result[t][5] = (val32 >> 16) & 0x3ff; + } + } + + if (!path_b_ok) + dev_dbg(dev, "%s: Path B IQK failed!\n", __func__); + } +#endif + + /* Back to BB mode, load original value */ + rtl8723au_write32(priv, REG_FPGA0_IQK, 0); + + if (t) { + if (!priv->pi_enabled) { + /* + * Switch back BB to SI mode after finishing + * IQ Calibration + */ + val32 = 0x01000000; + rtl8723au_write32(priv, REG_FPGA0_XA_HSSI_PARM1, val32); + rtl8723au_write32(priv, REG_FPGA0_XB_HSSI_PARM1, val32); + } + + /* Reload ADDA power saving parameters */ + rtl8xxxu_restore_regs(priv, ADDA_REG, priv->adda_backup, + RTL8XXXU_ADDA_REGS); + + /* Reload MAC parameters */ + rtl8xxxu_restore_mac_regs(priv, IQK_MAC_REG, priv->mac_backup); + + /* Reload BB parameters */ + rtl8xxxu_restore_regs(priv, IQK_BB_REG_92C, + priv->bb_backup, RTL8XXXU_BB_REGS); + + /* Restore RX initial gain */ + rtl8723au_write32(priv, REG_FPGA0_XA_LSSI_PARM, 0x00032ed3); + + if (is_2t) { + rtl8723au_write32(priv, REG_FPGA0_XB_LSSI_PARM, + 0x00032ed3); + } + + /* load 0xe30 IQC default value */ + rtl8723au_write32(priv, REG_TX_IQK_TONE_A, 0x01008c00); + rtl8723au_write32(priv, REG_RX_IQK_TONE_A, 0x01008c00); + } +} + +static void rtl8723a_phy_iq_calibrate(struct rtl8xxxu_priv *priv, bool recovery) +{ + struct device *dev = &priv->udev->dev; + int result[4][8]; /* last is final result */ + int i, candidate; + bool path_a_ok /*, path_b_ok */; + u32 reg_e94, reg_e9c, reg_ea4, reg_eac; + u32 reg_eb4, reg_ebc, reg_ec4, reg_ecc; + s32 reg_tmp = 0; + bool simu; + u32 iqk_bb_reg_92c[RTL8XXXU_BB_REGS] = { + REG_OFDM0_XA_RX_IQ_IMBALANCE, REG_OFDM0_XB_RX_IQ_IMBALANCE, + REG_OFDM0_ENERGY_CCA_THRES, REG_OFDM0_AGCR_SSI_TABLE, + REG_OFDM0_XA_TX_IQ_IMBALANCE, REG_OFDM0_XB_TX_IQ_IMBALANCE, + REG_OFDM0_XC_TX_AFE, REG_OFDM0_XD_TX_AFE, + REG_OFDM0_RX_IQ_EXT_ANTA + }; + + if (recovery) { + rtl8xxxu_restore_regs(priv, iqk_bb_reg_92c, + priv->bb_recovery_backup, + RTL8XXXU_BB_REGS); + return; + } + + memset(result, 0, sizeof(result)); + candidate = -1; + + path_a_ok = false; +#if 0 + path_b_ok = false; +#endif + rtl8723au_read32(priv, REG_FPGA0_RF_MODE); + + for (i = 0; i < 3; i++) { + rtl8xxxu_phy_iqcalibrate(priv, result, i, false); + + if (i == 1) { + simu = rtl8xxxu_simularity_compare(priv, result, 0, 1); + if (simu) { + candidate = 0; + break; + } + } + + if (i == 2) { + simu = rtl8xxxu_simularity_compare(priv, result, 0, 2); + if (simu) { + candidate = 0; + break; + } + + simu = rtl8xxxu_simularity_compare(priv, result, 1, 2); + if (simu) { + candidate = 1; + } else { + for (i = 0; i < 8; i++) + reg_tmp += result[3][i]; + + if (reg_tmp) + candidate = 3; + else + candidate = -1; + } + } + } + + for (i = 0; i < 4; i++) { + reg_e94 = result[i][0]; + reg_e9c = result[i][1]; + reg_ea4 = result[i][2]; + reg_eac = result[i][3]; + reg_eb4 = result[i][4]; + reg_ebc = result[i][5]; + reg_ec4 = result[i][6]; + reg_ecc = result[i][7]; + } + + if (candidate >= 0) { + reg_e94 = result[candidate][0]; + priv->rege94 = reg_e94; + reg_e9c = result[candidate][1]; + priv->rege9c = reg_e9c; + reg_ea4 = result[candidate][2]; + reg_eac = result[candidate][3]; + reg_eb4 = result[candidate][4]; + priv->regeb4 = reg_eb4; + reg_ebc = result[candidate][5]; + priv->regebc = reg_ebc; + reg_ec4 = result[candidate][6]; + reg_ecc = result[candidate][7]; + dev_dbg(dev, "%s: candidate is %x\n", __func__, candidate); + dev_dbg(dev, "%s: reg_e94 =%x reg_e9C =%x reg_eA4 =%x " + "reg_eAC =%x reg_eB4 =%x reg_eBC =%x reg_eC4 =%x " + "reg_eCC =%x\n ", __func__, reg_e94, reg_e9c, + reg_ea4, reg_eac, reg_eb4, reg_ebc, reg_ec4, reg_ecc); + path_a_ok = true; +#if 0 + path_b_ok = true; +#endif + } else { + reg_e94 = reg_eb4 = priv->rege94 = priv->regeb4 = 0x100; + reg_e9c = reg_ebc = priv->rege9c = priv->regebc = 0x0; + } + + if (reg_e94 && candidate >= 0) + rtl8xxxu_fill_iqk_matrix_a(priv, path_a_ok, result, + candidate, (reg_ea4 == 0)); + + rtl8xxxu_save_regs(priv, iqk_bb_reg_92c, + priv->bb_recovery_backup, RTL8XXXU_BB_REGS); +} + +static void rtl8723a_phy_lc_calibrate(struct rtl8xxxu_priv *priv) +{ + u32 val32; + u32 rf_amode, lstf; + + /* Check continuous TX and Packet TX */ + lstf = rtl8723au_read32(priv, REG_OFDM1_LSTF); + + if (lstf & OFDM_LSTF_MASK) { + /* Disable all continuous TX */ + val32 = lstf & ~OFDM_LSTF_MASK; + rtl8723au_write32(priv, REG_OFDM1_LSTF, val32); + + /* Read original RF mode Path A */ + rf_amode = rtl8723au_read_rfreg(priv, RF6052_REG_AC); + +#if 0 + /* Path-B */ + if (is_2t) + rf_bmode = PHY_QueryRFReg(priv, RF_PATH_B, RF_AC, + bMask12Bits); +#endif + + /* Set RF mode to standby Path A */ + rtl8723au_write_rfreg(priv, RF6052_REG_AC, + (rf_amode & 0xfff) | 0x10000); + +#if 0 + /* Path-B */ + if (is_2t) + PHY_SetRFReg(priv, RF_PATH_B, RF_AC, bMask12Bits, + (RF_Bmode & 0x8ffff) | 0x10000); +#endif + } else { + /* Deal with Packet TX case */ + /* block all queues */ + rtl8723au_write8(priv, REG_TXPAUSE, 0xff); + } + + /* Start LC calibration */ + val32 = rtl8723au_read_rfreg(priv, RF6052_REG_MODE_AG); + val32 |= 0x08000; + rtl8723au_write_rfreg(priv, RF6052_REG_MODE_AG, val32); + + msleep(100); + + /* Restore original parameters */ + if (lstf & OFDM_LSTF_MASK) { + /* Path-A */ + rtl8723au_write32(priv, REG_OFDM1_LSTF, lstf); + rtl8723au_write_rfreg(priv, RF6052_REG_AC, rf_amode); + +#if 0 + /* Path-B */ + if (is_2t) + PHY_SetRFReg(priv, RF_PATH_B, RF_AC, bMask12Bits, + RF_Bmode); +#endif + } else /* Deal with Packet TX case */ + rtl8723au_write8(priv, REG_TXPAUSE, 0x00); +} + +static int rtl8xxxu_set_mac(struct rtl8xxxu_priv *priv) +{ + int i; + u16 reg; + + reg = REG_MACID; + + for (i = 0; i < ETH_ALEN; i++) + rtl8723au_write8(priv, reg + i, priv->mac_addr[i]); + + return 0; +} + +static int rtl8xxxu_set_bssid(struct rtl8xxxu_priv *priv, const u8 *bssid) +{ + int i; + u16 reg; + + dev_dbg(&priv->udev->dev, + "%s: (%02x:%02x:%02x:%02x:%02x:%02x)\n", __func__, + bssid[0], bssid[1], bssid[2], bssid[3], bssid[4], bssid[5]); + + reg = REG_BSSID; + + for (i = 0; i < ETH_ALEN; i++) + rtl8723au_write8(priv, reg + i, bssid[i]); + + return 0; +} + +void rtl8xxxu_set_ampdu_factor(struct rtl8xxxu_priv *priv, u8 ampdu_factor) +{ + u8 vals[4] = { 0x41, 0xa8, 0x72, 0xb9 }; + u8 max_agg = 0xf; + int i; + + ampdu_factor = 1 << (ampdu_factor + 2); + if (ampdu_factor > max_agg) + ampdu_factor = max_agg; + + for (i = 0; i < 4; i++) { + if ((vals[i] & 0xf0) > (ampdu_factor << 4)) + vals[i] = (vals[i] & 0x0f) | (ampdu_factor << 4); + + if ((vals[i] & 0x0f) > ampdu_factor) + vals[i] = (vals[i] & 0xf0) | ampdu_factor; + + rtl8723au_write8(priv, REG_AGGLEN_LMT + i, vals[i]); + } +} + +void rtl8xxxu_set_ampdu_min_space(struct rtl8xxxu_priv *priv, u8 density) +{ + u8 val8; + + val8 = rtl8723au_read8(priv, REG_AMPDU_MIN_SPACE); + val8 &= 0xf8; + val8 |= density; + rtl8723au_write8(priv, REG_AMPDU_MIN_SPACE, val8); +} + +static int rtl8xxxu_active_to_emu(struct rtl8xxxu_priv *priv) +{ + u8 val8; + int count, ret; + + /* Start of rtl8723AU_card_enable_flow */ + /* Act to Cardemu sequence*/ + /* Turn off RF */ + rtl8723au_write8(priv, REG_RF_CTRL, 0); + + /* 0x004E[7] = 0, switch DPDT_SEL_P output from register 0x0065[2] */ + val8 = rtl8723au_read8(priv, REG_LEDCFG2); + val8 &= ~LEDCFG2_DPDT_SELECT; + rtl8723au_write8(priv, REG_LEDCFG2, val8); + + /* 0x0005[1] = 1 turn off MAC by HW state machine*/ + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 1); + val8 |= BIT(1); + rtl8723au_write8(priv, REG_APS_FSMCO + 1, val8); + + for (count = RTL8XXXU_MAX_REG_POLL; count; count--) { + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 1); + if ((val8 & BIT(1)) == 0) + break; + udelay(10); + } + + if (!count) { + dev_warn(&priv->udev->dev, "%s: Disabling MAC timed out\n", + __func__); + ret = -EBUSY; + goto exit; + } + + /* 0x0000[5] = 1 analog Ips to digital, 1:isolation */ + val8 = rtl8723au_read8(priv, REG_SYS_ISO_CTRL); + val8 |= SYS_ISO_ANALOG_IPS; + rtl8723au_write8(priv, REG_SYS_ISO_CTRL, val8); + + /* 0x0020[0] = 0 disable LDOA12 MACRO block*/ + val8 = rtl8723au_read8(priv, REG_LDOA15_CTRL); + val8 &= ~LDOA15_ENABLE; + rtl8723au_write8(priv, REG_LDOA15_CTRL, val8); + +exit: + return ret; +} + +static int rtl8xxxu_active_to_lps(struct rtl8xxxu_priv *priv) +{ + u8 val8; + u8 val32; + int count, ret; + + rtl8723au_write8(priv, REG_TXPAUSE, 0xff); + + /* + * Poll - wait for RX packet to complete + */ + for (count = RTL8XXXU_MAX_REG_POLL; count; count--) { + val32 = rtl8723au_read8(priv, 0x5f8); + if (!val32) + break; + udelay(10); + } + + if (!count) { + dev_warn(&priv->udev->dev, + "%s: RX poll timed out (0x05f8)\n", __func__); + ret = -EBUSY; + goto exit; + } + + /* Disable CCK and OFDM, clock gated */ + val8 = rtl8723au_read8(priv, REG_SYS_FUNC); + val8 &= ~SYS_FUNC_BBRSTB; + rtl8723au_write8(priv, REG_SYS_FUNC, val8); + + udelay(2); + + /* Reset baseband */ + val8 = rtl8723au_read8(priv, REG_SYS_FUNC); + val8 &= ~SYS_FUNC_BB_GLB_RSTN; + rtl8723au_write8(priv, REG_SYS_FUNC, val8); + + /* Reset MAC TRX */ + val8 = rtl8723au_read8(priv, REG_CR); + val8 = CR_HCI_TXDMA_ENABLE | CR_HCI_RXDMA_ENABLE; + rtl8723au_write8(priv, REG_CR, val8); + + /* Reset MAC TRX */ + val8 = rtl8723au_read8(priv, REG_CR + 1); + val8 &= ~BIT(1); /* CR_SECURITY_ENABLE */ + rtl8723au_write8(priv, REG_CR + 1, val8); + + /* Respond TX OK to scheduler */ + val8 = rtl8723au_read8(priv, REG_DUAL_TSF_RST); + val8 |= BIT(5); + rtl8723au_write8(priv, REG_DUAL_TSF_RST, val8); + +exit: + return ret; +} + +static void rtl8xxxu_disabled_to_emu(struct rtl8xxxu_priv *priv) +{ + u8 val8; + + /* Clear suspend enable and power down enable*/ + val8 = rtl8723au_read8(priv, 0x05); + val8 &= ~(BIT(3) | BIT(7)); + rtl8723au_write8(priv, 0x05, val8); + + /* 0x48[16] = 0 to disable GPIO9 as EXT WAKEUP*/ + val8 = rtl8723au_read8(priv, 0x4a); + val8 &= ~BIT(0); + rtl8723au_write8(priv, 0x4a, val8); + + /* 0x04[12:11] = 11 enable WL suspend*/ + val8 = rtl8723au_read8(priv, 0x05); + val8 &= ~(BIT(3) | BIT(4)); + rtl8723au_write8(priv, 0x05, val8); +} + +static int rtl8xxxu_emu_to_active(struct rtl8xxxu_priv *priv) +{ + u8 val8; + u32 val32; + int count, ret = 0; + + /* 0x20[0] = 1 enable LDOA12 MACRO block for all interface*/ + val8 = rtl8723au_read8(priv, REG_LDOA15_CTRL); + val8 |= LDOA15_ENABLE; + rtl8723au_write8(priv, REG_LDOA15_CTRL, val8); + + /* 0x67[0] = 0 to disable BT_GPS_SEL pins*/ + val8 = rtl8723au_read8(priv, 0x0067); + val8 &= ~BIT(4); + rtl8723au_write8(priv, 0x0067, val8); + + mdelay(1); + + /* 0x00[5] = 0 release analog Ips to digital, 1:isolation */ + val8 = rtl8723au_read8(priv, REG_SYS_ISO_CTRL); + val8 &= ~BIT(5); + rtl8723au_write8(priv, REG_SYS_ISO_CTRL, val8); + + /* disable SW LPS 0x04[10]= 0 */ + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 1); + val8 &= ~BIT(2); + rtl8723au_write8(priv, REG_APS_FSMCO + 1, val8); + + /* wait till 0x04[17] = 1 power ready*/ + for (count = RTL8XXXU_MAX_REG_POLL; count; count--) { + val32 = rtl8723au_read32(priv, REG_APS_FSMCO); + if (val32 & BIT(17)) + break; + + udelay(10); + } + + if (!count) { + ret = -EBUSY; + goto exit; + } + + /* We should be able to optimize the following three entries into one */ + + /* release WLON reset 0x04[16]= 1*/ + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 2); + val8 |= BIT(0); + rtl8723au_write8(priv, REG_APS_FSMCO + 2, val8); + + /* disable HWPDN 0x04[15]= 0*/ + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 1); + val8 &= ~BIT(7); + rtl8723au_write8(priv, REG_APS_FSMCO + 1, val8); + + /* disable WL suspend*/ + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 1); + val8 &= ~(BIT(3) | BIT(4)); + rtl8723au_write8(priv, REG_APS_FSMCO + 1, val8); + + /* set, then poll until 0 */ + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 1); + val8 |= BIT(0); + rtl8723au_write8(priv, REG_APS_FSMCO + 1, val8); + + for (count = RTL8XXXU_MAX_REG_POLL; count; count--) { + val32 = rtl8723au_read32(priv, REG_APS_FSMCO); + if ((val32 & BIT(8)) == 0) { + ret = 0; + break; + } + udelay(10); + } + + if (!count) { + ret = -EBUSY; + goto exit; + } + + /* 0x4C[23] = 0x4E[7] = 1, switch DPDT_SEL_P output from WL BB */ + /* + * Note: Vendor driver actually clears this bit, despite the + * documentation claims it's being set! + */ + val8 = rtl8723au_read8(priv, REG_LEDCFG2); + val8 |= LEDCFG2_DPDT_SELECT; + val8 &= ~LEDCFG2_DPDT_SELECT; + rtl8723au_write8(priv, REG_LEDCFG2, val8); + +exit: + return ret; +} + +static int rtl8xxxu_emu_to_disabled(struct rtl8xxxu_priv *priv) +{ + u8 val8; + + /* 0x0007[7:0] = 0x20 SOP option to disable BG/MB */ + rtl8723au_write8(priv, REG_APS_FSMCO + 3, 0x20); + + /* 0x04[12:11] = 01 enable WL suspend */ + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 1); + val8 &= ~BIT(4); + val8 |= BIT(3); + rtl8723au_write8(priv, REG_APS_FSMCO + 1, val8); + + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 1); + val8 |= BIT(7); + rtl8723au_write8(priv, REG_APS_FSMCO + 1, val8); + + /* 0x48[16] = 1 to enable GPIO9 as EXT wakeup */ + val8 = rtl8723au_read8(priv, REG_GPIO_INTM + 2); + val8 |= BIT(0); + rtl8723au_write8(priv, REG_GPIO_INTM + 2, val8); + + return 0; +} + +static int rtl8xxxu_power_on(struct rtl8xxxu_priv *priv) +{ + u8 val8; + u16 val16; + u32 val32; + int ret; + + /* + * RSV_CTRL 0x001C[7:0] = 0x00, unlock ISO/CLK/Power control register + */ + rtl8723au_write8(priv, REG_RSV_CTRL, 0x0); + + rtl8xxxu_disabled_to_emu(priv); + + ret = rtl8xxxu_emu_to_active(priv); + if (ret) + goto exit; + + /* + * 0x0004[19] = 1, reset 8051 + */ + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 2); + val8 |= BIT(3); + rtl8723au_write8(priv, REG_APS_FSMCO + 2, val8); + + /* + * Enable MAC DMA/WMAC/SCHEDULE/SEC block + * Set CR bit10 to enable 32k calibration. + */ + val16 = rtl8723au_read16(priv, REG_CR); + val16 |= (CR_HCI_TXDMA_ENABLE | CR_HCI_RXDMA_ENABLE | + CR_TXDMA_ENABLE | CR_RXDMA_ENABLE | + CR_PROTOCOL_ENABLE | CR_SCHEDULE_ENABLE | + CR_MAC_TX_ENABLE | CR_MAC_RX_ENABLE | + CR_SECURITY_ENABLE | CR_CALTIMER_ENABLE); + rtl8723au_write16(priv, REG_CR, val16); + + /* For EFuse PG */ + val32 = rtl8723au_read32(priv, REG_EFUSE_CTRL); + val32 &= ~(BIT(28) | BIT(29) | BIT(30)); + val32 |= (0x06 << 28); + rtl8723au_write32(priv, REG_EFUSE_CTRL, val32); +exit: + return ret; +} + +static void rtl8xxxu_power_off(struct rtl8xxxu_priv *priv) +{ + u8 val8; + u16 val16; + + rtl8xxxu_active_to_lps(priv); + + /* Turn off RF */ + rtl8723au_write8(priv, REG_RF_CTRL, 0x00); + + /* Reset Firmware if running in RAM */ + if (rtl8723au_read8(priv, REG_MCU_FW_DL) & MCU_FW_RAM_SEL) + rtl8xxxu_firmware_self_reset(priv); + + /* Reset MCU */ + val16 = rtl8723au_read16(priv, REG_SYS_FUNC); + val16 &= ~SYS_FUNC_CPU_ENABLE; + rtl8723au_write16(priv, REG_SYS_FUNC, val16); + + /* Reset MCU ready status */ + rtl8723au_write8(priv, REG_MCU_FW_DL, 0x00); + + rtl8xxxu_active_to_emu(priv); + rtl8xxxu_emu_to_disabled(priv); + + /* Reset MCU IO Wrapper */ + val8 = rtl8723au_read8(priv, REG_RSV_CTRL + 1); + val8 &= ~BIT(0); + rtl8723au_write8(priv, REG_RSV_CTRL + 1, val8); + + val8 = rtl8723au_read8(priv, REG_RSV_CTRL + 1); + val8 |= BIT(0); + rtl8723au_write8(priv, REG_RSV_CTRL + 1, val8); + + /* RSV_CTRL 0x1C[7:0] = 0x0e lock ISO/CLK/Power control register */ + rtl8723au_write8(priv, REG_RSV_CTRL, 0x0e); +} + +static int rtl8xxxu_init_device(struct ieee80211_hw *hw) +{ + struct rtl8xxxu_priv *priv = hw->priv; + struct device *dev = &priv->udev->dev; + bool macpower; + int ret; + u8 val8; + u16 val16; + u32 val32; + + /* Check if MAC is already powered on */ + val8 = rtl8723au_read8(priv, REG_CR); + + /* + * Fix 92DU-VC S3 hang with the reason is that secondary mac is not + * initialized. First MAC returns 0xea, second MAC returns 0x00 + */ + if (val8 == 0xea) + macpower = false; + else + macpower = true; + + ret = rtl8xxxu_power_on(priv); + if (ret < 0) { + dev_warn(dev, "%s: Failed power on\n", __func__); + goto exit; + } + + dev_dbg(dev, "%s: macpower %i\n", __func__, macpower); + if (!macpower) { + ret = rtl8xxxu_init_llt_table(priv, TX_TOTAL_PAGE_NUM); + if (ret) { + dev_warn(dev, "%s: LLT table init failed\n", __func__); + goto exit; + } + } + + ret = rtl8xxxu_download_firmware(priv); + if (ret) + goto exit; + ret = rtl8xxxu_start_firmware(priv); + if (ret) + goto exit; + + ret = rtl8xxxu_init_mac(priv, rtl8723a_mac_init_table); + if (ret) + goto exit; + + ret = rtl8xxxu_init_phy_bb(priv); + if (ret) + goto exit; + + ret = rtl8xxxu_init_phy_rf(priv); + if (ret) + goto exit; + + /* Reduce 80M spur */ + rtl8723au_write32(priv, REG_AFE_XTAL_CTRL, 0x0381808d); + rtl8723au_write32(priv, REG_AFE_PLL_CTRL, 0xf0ffff83); + rtl8723au_write32(priv, REG_AFE_PLL_CTRL, 0xf0ffff82); + rtl8723au_write32(priv, REG_AFE_PLL_CTRL, 0xf0ffff83); + + /* RFSW Control - clear bit 14 ?? */ + rtl8723au_write32(priv, REG_FPGA0_TXINFO, 0x00000003); + /* 0x07000760 */ + val32 = 0x07000000 | FPGA0_RF_TRSW | FPGA0_RF_TRSWB | + FPGA0_RF_ANTSW | FPGA0_RF_ANTSWB | FPGA0_RF_PAPE; + rtl8723au_write32(priv, REG_FPGA0_XAB_RF_SW_CTRL, val32); + /* 0x860[6:5]= 00 - why? - this sets antenna B */ + rtl8723au_write32(priv, REG_FPGA0_XA_RF_INT_OE, 0x66F60210); + + priv->rf_mode_ag[0] = rtl8723au_read_rfreg(priv, RF6052_REG_MODE_AG); + + if (!macpower) { + if (priv->ep_tx_normal_queue) + val8 = TX_PAGE_NUM_NORM_PQ; + else + val8 = 0; + + rtl8723au_write8(priv, REG_RQPN_NPQ, val8); + + val32 = (TX_PAGE_NUM_PUBQ << RQPN_NORM_PQ_SHIFT) | RQPN_LOAD; + + if (priv->ep_tx_high_queue) + val32 |= (TX_PAGE_NUM_HI_PQ << RQPN_HI_PQ_SHIFT); + if (priv->ep_tx_low_queue) + val32 |= (TX_PAGE_NUM_LO_PQ << RQPN_LO_PQ_SHIFT); + + rtl8723au_write32(priv, REG_RQPN, val32); + + /* + * Set TX buffer boundary + */ + val8 = TX_TOTAL_PAGE_NUM + 1; + rtl8723au_write8(priv, REG_TXPKTBUF_BCNQ_BDNY, val8); + rtl8723au_write8(priv, REG_TXPKTBUF_MGQ_BDNY, val8); + rtl8723au_write8(priv, REG_TXPKTBUF_WMAC_LBK_BF_HD, val8); + rtl8723au_write8(priv, REG_TRXFF_BNDY, val8); + rtl8723au_write8(priv, REG_TDECTRL + 1, val8); + } + + ret = rtl8xxxu_init_queue_priority(priv); + if (ret) + goto exit; + + /* + * Set RX page boundary + */ + rtl8723au_write16(priv, REG_TRXFF_BNDY + 2, 0x27ff); + /* + * Transfer page size is always 128 + */ + val8 = (PBP_PAGE_SIZE_128 << PBP_PAGE_SIZE_RX_SHIFT) | + (PBP_PAGE_SIZE_128 << PBP_PAGE_SIZE_TX_SHIFT); + rtl8723au_write8(priv, REG_PBP, val8); + + /* + * Unit in 8 bytes, not obvious what it is used for + */ + rtl8723au_write8(priv, REG_RX_DRVINFO_SZ, 4); + + /* + * Enable all interrupts - not obvious USB needs to do this + */ + rtl8723au_write32(priv, REG_HISR, 0xffffffff); + rtl8723au_write32(priv, REG_HIMR, 0xffffffff); + + rtl8xxxu_set_mac(priv); + rtl8xxxu_set_linktype(priv, NL80211_IFTYPE_STATION); + + /* + * Configure initial WMAC settings + */ + val32 = RCR_ACCEPT_PHYS_MATCH | RCR_ACCEPT_MCAST | RCR_ACCEPT_BCAST | + /* RCR_CHECK_BSSID_MATCH | RCR_CHECK_BSSID_BEACON | */ + RCR_ACCEPT_MGMT_FRAME | RCR_HTC_LOC_CTRL | + RCR_APPEND_PHYSTAT | RCR_APPEND_ICV | RCR_APPEND_MIC; + rtl8723au_write32(priv, REG_RCR, val32); + + /* + * Accept all multicast + */ + rtl8723au_write32(priv, REG_MAR, 0xffffffff); + rtl8723au_write32(priv, REG_MAR + 4, 0xffffffff); + + /* + * Init adaptive controls + */ + val32 = rtl8723au_read32(priv, REG_RESPONSE_RATE_SET); + val32 &= ~RESPONSE_RATE_BITMAP_ALL; + val32 |= RESPONSE_RATE_RRSR_CCK_ONLY_1M; + rtl8723au_write32(priv, REG_RESPONSE_RATE_SET, val32); + + /* CCK = 0x0a, OFDM = 0x10 */ +#if 0 + rtl8xxxu_set_spec_sifs(priv, 0x0a, 0x10); +#else + rtl8xxxu_set_spec_sifs(priv, 0x10, 0x10); +#endif + rtl8xxxu_set_retry(priv, 0x30, 0x30); + rtl8xxxu_set_spec_sifs(priv, 0x0a, 0x10); + + /* + * Init EDCA + */ + rtl8723au_write16(priv, REG_MAC_SPEC_SIFS, 0x100a); + + /* Set CCK SIFS */ + rtl8723au_write16(priv, REG_SIFS_CCK, 0x100a); + + /* Set OFDM SIFS */ + rtl8723au_write16(priv, REG_SIFS_OFDM, 0x100a); + + /* TXOP */ + rtl8723au_write32(priv, REG_EDCA_BE_PARAM, 0x005ea42b); + rtl8723au_write32(priv, REG_EDCA_BK_PARAM, 0x0000a44f); + rtl8723au_write32(priv, REG_EDCA_VI_PARAM, 0x005ea324); + rtl8723au_write32(priv, REG_EDCA_VO_PARAM, 0x002fa226); + + /* Set data auto rate fallback retry count */ + rtl8723au_write32(priv, REG_DARFRC, 0x00000000); + rtl8723au_write32(priv, REG_DARFRC + 4, 0x10080404); + rtl8723au_write32(priv, REG_RARFRC, 0x04030201); + rtl8723au_write32(priv, REG_RARFRC + 4, 0x08070605); + + val8 = rtl8723au_read8(priv, REG_FWHW_TXQ_CTRL); + val8 |= FWHW_TXQ_CTRL_AMPDU_RETRY; + rtl8723au_write8(priv, REG_FWHW_TXQ_CTRL, val8); + + /* Set ACK timeout */ + rtl8723au_write8(priv, REG_ACKTO, 0x40); + + /* + * Initialize beacon parameters + */ + val16 = BEACON_DISABLE_TSF_UPDATE | (BEACON_DISABLE_TSF_UPDATE << 8); + rtl8723au_write16(priv, REG_BEACON_CTRL, val16); + rtl8723au_write16(priv, REG_TBTT_PROHIBIT, 0x6404); + rtl8723au_write8(priv, REG_DRIVER_EARLY_INT, DRIVER_EARLY_INT_TIME); + rtl8723au_write8(priv, REG_BEACON_DMA_TIME, BEACON_DMA_ATIME_INT_TIME); + rtl8723au_write16(priv, REG_BEACON_TCFG, 0x660F); + + /* + * Enable CCK and OFDM block + */ + val32 = rtl8723au_read32(priv, REG_FPGA0_RF_MODE); + val32 |= (FPGA_RF_MODE_CCK | FPGA_RF_MODE_OFDM); + rtl8723au_write32(priv, REG_FPGA0_RF_MODE, val32); + + /* + * Invalidate all CAM entries - bit 30 is undocumented + */ + rtl8723au_write32(priv, REG_CAM_CMD, CAM_CMD_POLLING | BIT(30)); + + /* + * Start out with default power levels for channel 6, 20MHz + */ + rtl8723a_set_tx_power(priv, 1, false); + + /* Let the 8051 take control of antenna setting */ + val8 = rtl8723au_read8(priv, REG_LEDCFG2); + val8 |= LEDCFG2_DPDT_SELECT; + rtl8723au_write8(priv, REG_LEDCFG2, val8); + + rtl8723au_write8(priv, REG_HWSEQ_CTRL, 0xff); + + /* Disable BAR - not sure if this has any effect on USB */ + rtl8723au_write32(priv, REG_BAR_MODE_CTRL, 0x0201ffff); + +#if 0 + if (priv->wifi_spec) + rtl8723au_write16(priv, REG_FAST_EDCA_CTRL, 0); +#endif + rtl8723au_write16(priv, REG_FAST_EDCA_CTRL, 0); + +#if 0 + /* + * From 8192cu driver + */ + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_RF_INT_OE); + val32 &= ~BIT(6); + val32 |= BIT(5); + rtl8723au_write32(priv, REG_FPGA0_XA_RF_INT_OE, val32); +#endif + + /* + * Not sure if we should get into this at all + */ + if (priv->iqk_initialized) { + rtl8723a_phy_iq_calibrate(priv, true); + } else { + rtl8723a_phy_iq_calibrate(priv, false); + priv->iqk_initialized = true; + } + + /* + * This should enable thermal meter + */ + rtl8723au_write_rfreg(priv, RF6052_REG_T_METER, 0x60); + + rtl8723a_phy_lc_calibrate(priv); + + /* fix USB interface interference issue */ + rtl8723au_write8(priv, 0xfe40, 0xe0); + rtl8723au_write8(priv, 0xfe41, 0x8d); + rtl8723au_write8(priv, 0xfe42, 0x80); + rtl8723au_write32(priv, REG_TXDMA_OFFSET_CHK, 0xfd0320); + + /* Solve too many protocol error on USB bus */ + /* Can't do this for 8188/8192 UMC A cut parts */ + rtl8723au_write8(priv, 0xfe40, 0xe6); + rtl8723au_write8(priv, 0xfe41, 0x94); + rtl8723au_write8(priv, 0xfe42, 0x80); + + rtl8723au_write8(priv, 0xfe40, 0xe0); + rtl8723au_write8(priv, 0xfe41, 0x19); + rtl8723au_write8(priv, 0xfe42, 0x80); + + rtl8723au_write8(priv, 0xfe40, 0xe5); + rtl8723au_write8(priv, 0xfe41, 0x91); + rtl8723au_write8(priv, 0xfe42, 0x80); + + rtl8723au_write8(priv, 0xfe40, 0xe2); + rtl8723au_write8(priv, 0xfe41, 0x81); + rtl8723au_write8(priv, 0xfe42, 0x80); + +#if 0 + /* Init BT hw config. */ + rtl8723a_init_bt(priv); +#endif + + /* + * Not sure if we really need to save these parameters, but the + * vendor driver does + */ + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_HSSI_PARM2); + if (val32 & FPGA0_HSSI_PARM2_CCK_HIGH_PWR) + priv->path_a_hi_power = 1; + + val32 = rtl8723au_read32(priv, REG_OFDM0_TRX_PATH_ENABLE); + priv->path_a_rf_paths = val32 & OFDM0_RF_PATH_RX_MASK; + + val32 = rtl8723au_read32(priv, REG_OFDM0_XA_AGC_CORE1); + priv->path_a_ig_value = val32 & OFDM0_X_AGC_CORE1_IGI_MASK; + + /* Set NAV_UPPER to 30000us */ + val8 = ((30000 + NAV_UPPER_UNIT - 1) / NAV_UPPER_UNIT); + rtl8723au_write8(priv, REG_NAV_UPPER, val8); + + /* + * 2011/03/09 MH debug only, UMC-B cut pass 2500 S5 test, + * but we need to fin root cause. + */ + val32 = rtl8723au_read32(priv, REG_FPGA0_RF_MODE); + if ((val32 & 0xff000000) != 0x83000000) { + val32 |= FPGA_RF_MODE_CCK; + rtl8723au_write32(priv, REG_FPGA0_RF_MODE, val32); + } + + val32 = rtl8723au_read32(priv, REG_FWHW_TXQ_CTRL); + val32 |= FWHW_TXQ_CTRL_XMIT_MGMT_ACK; + /* ack for xmit mgmt frames. */ + rtl8723au_write32(priv, REG_FWHW_TXQ_CTRL, val32); + +exit: + return ret; +} + +static void rtl8xxxu_disable_device(struct ieee80211_hw *hw) +{ + struct rtl8xxxu_priv *priv = hw->priv; + + rtl8xxxu_power_off(priv); +} + +static void rtl8xxxu_cam_write(struct rtl8xxxu_priv *priv, + struct ieee80211_key_conf *key, const u8 *mac) +{ + u32 cmd, val32, addr, ctrl; + int j, i, tmp_debug; + + tmp_debug = rtl8xxxu_debug; + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_KEY) + rtl8xxxu_debug |= RTL8XXXU_DEBUG_REG_WRITE; + + addr = key->keyidx << CAM_CMD_KEY_SHIFT; + ctrl = (key->cipher & 0x0f) << 2 | key->keyidx | CAM_WRITE_VALID; + + for (j = 5; j >= 0; j--) { + switch (j) { + case 0: + val32 = ctrl | (mac[0] << 16) | (mac[1] << 24); + break; + case 1: + val32 = mac[2] | (mac[3] << 8) | + (mac[4] << 16) | (mac[5] << 24); + break; + default: + i = (j - 2) << 2; + val32 = key->key[i] | (key->key[i + 1] << 8) | + key->key[i + 2] << 16 | key->key[i + 3] << 24; + break; + } + + rtl8723au_write32(priv, REG_CAM_WRITE, val32); + cmd = CAM_CMD_POLLING | CAM_CMD_WRITE | (addr + j); + rtl8723au_write32(priv, REG_CAM_CMD, cmd); + udelay(100); + } + + rtl8xxxu_debug = tmp_debug; +} + +static void rtl8xxxu_sw_scan_start(struct ieee80211_hw *hw, + struct ieee80211_vif *vif, const u8 *mac) +{ +#if 0 + struct rtl8xxxu_priv *priv = hw->priv; + u32 val32; + + val32 = rtl8723au_read32(priv, REG_RCR); + val32 &= ~(RCR_CHECK_BSSID_MATCH | RCR_CHECK_BSSID_BEACON); + rtl8723au_write32(priv, REG_RCR, val32); + + rtl8723au_write8(priv, REG_BEACON_CTRL, BEACON_ATIM | + BEACON_FUNCTION_ENABLE | BEACON_DISABLE_TSF_UPDATE); + + dev_dbg(&priv->udev->dev, "%s\n", __func__); +#endif +} + +static void rtl8xxxu_sw_scan_complete(struct ieee80211_hw *hw, + struct ieee80211_vif *vif) +{ + struct rtl8xxxu_priv *priv = hw->priv; + u8 val8; + +#if 0 + dev_dbg(&priv->udev->dev, "%s\n", __func__); +#endif + + val8 = rtl8723au_read8(priv, REG_BEACON_CTRL); + val8 &= ~BEACON_DISABLE_TSF_UPDATE; + rtl8723au_write8(priv, REG_BEACON_CTRL, val8); +} + +static void rtl8xxxu_update_rate_table(struct rtl8xxxu_priv *priv, + struct ieee80211_sta *sta) +{ + struct h2c_cmd h2c; + u32 ramask; + + /* TODO: Set bits 28-31 for rate adaptive id */ + ramask = (sta->supp_rates[0] & 0xfff) | + sta->ht_cap.mcs.rx_mask[0] << 12 | + sta->ht_cap.mcs.rx_mask[1] << 20; + + h2c.ramask.cmd = H2C_SET_RATE_MASK; + put_unaligned_le16(ramask & 0xffff, &h2c.ramask.mask_lo); + put_unaligned_le16(ramask >> 16, &h2c.ramask.mask_hi); + + h2c.ramask.arg = 0x80; + if (sta->ht_cap.cap & + (IEEE80211_HT_CAP_SGI_40 | IEEE80211_HT_CAP_SGI_20)) { + h2c.ramask.arg |= 0x20; + priv->use_shortgi = true; + } else { + priv->use_shortgi = false; + } + + dev_dbg(&priv->udev->dev, "%s: rate mask %08x, arg %02x\n", __func__, + ramask, h2c.ramask.arg); + rtl8723a_h2c_cmd(priv, &h2c); +} + +static void rtl8xxxu_set_basic_rates(struct rtl8xxxu_priv *priv, + struct ieee80211_sta *sta) +{ + u32 rate_cfg, val32; + u8 rate_idx = 0; + + rate_cfg = sta->supp_rates[0]; + rate_cfg &= 0x15f; + rate_cfg |= 1; + val32 = rtl8723au_read32(priv, REG_RESPONSE_RATE_SET); + val32 &= ~RESPONSE_RATE_BITMAP_ALL; + val32 |= rate_cfg; + rtl8723au_write32(priv, REG_RESPONSE_RATE_SET, val32); + + dev_dbg(&priv->udev->dev, "%s: supp_rates %08x rates %08x\n", __func__, + sta->supp_rates[0], rate_cfg); + + while (rate_cfg) { + rate_cfg = (rate_cfg >> 1); + rate_idx++; + } + rtl8723au_write8(priv, REG_INIRTS_RATE_SEL, rate_idx); +} + +static void +rtl8xxxu_bss_info_changed(struct ieee80211_hw *hw, struct ieee80211_vif *vif, + struct ieee80211_bss_conf *bss_conf, u32 changed) +{ + struct rtl8xxxu_priv *priv = hw->priv; + struct device *dev = &priv->udev->dev; + struct ieee80211_sta *sta; + u32 val32; +#if 0 + u16 val16; +#endif + u8 val8; + + if (changed & BSS_CHANGED_ASSOC) { + struct h2c_cmd h2c; + + memset(&h2c, 0, sizeof(struct h2c_cmd)); + rtl8xxxu_set_linktype(priv, vif->type); + + if (bss_conf->assoc) { + rcu_read_lock(); + sta = ieee80211_find_sta(vif, bss_conf->bssid); + if (!sta) { + dev_info(dev, "%s: ASSOC no sta found\n", + __func__); + rcu_read_unlock(); + goto error; + } + + if (sta->ht_cap.ht_supported) + dev_info(dev, "%s: HT supported\n", __func__); + if (sta->vht_cap.vht_supported) + dev_info(dev, "%s: VHT supported\n", __func__); + rtl8xxxu_update_rate_table(priv, sta); + rcu_read_unlock(); + + val32 = rtl8723au_read32(priv, REG_RCR); + val32 |= RCR_CHECK_BSSID_MATCH | RCR_CHECK_BSSID_BEACON; + rtl8723au_write32(priv, REG_RCR, val32); + + /* Enable RX of data frames */ + rtl8723au_write16(priv, REG_RXFLTMAP2, 0xffff); + + rtl8723au_write8(priv, REG_BCN_MAX_ERR, 0xff); + + /* Stop TX beacon */ + val8 = rtl8723au_read8(priv, REG_FWHW_TXQ_CTRL + 2); + val8 &= ~BIT(6); + rtl8723au_write8(priv, REG_FWHW_TXQ_CTRL + 2, val8); + + rtl8723au_write8(priv, REG_TBTT_PROHIBIT + 1, 0x64); + val8 = rtl8723au_read8(priv, REG_TBTT_PROHIBIT + 2); + val8 &= ~BIT(0); + rtl8723au_write8(priv, REG_TBTT_PROHIBIT + 2, val8); + + /* joinbss sequence */ + rtl8723au_write16(priv, REG_BCN_PSR_RPT, + 0xc000 | bss_conf->aid); + +#if 0 + val16 = rtl8723au_read16(priv, REG_CR); + val16 |= CR_SW_BEACON_ENABLE; + rtl8723au_read16(priv, REG_CR, val16); + + val8 = rtl8723au_read8(priv, REG_BEACON_CTRL); + val8 &= ~BEACON_FUNCTION_ENABLE; + val8 |= BEACON_DISABLE_TSF_UPDATE; + rtl8723au_write8(priv, REG_BEACON_CTRL, val8); + + val8 = rtl8723au_read8(priv, REG_FWHW_TXQ_CTRL + 2); + if (val8 & BIT(6)) + recover = true; + + val8 &= ~BIT(6); + rtl8723au_write8(priv, REG_FWHW_TXQ_CTRL + 2, val8); + + /* build fake beacon */ + + val8 = rtl8723au_read8(priv, REG_BEACON_CTRL); + val8 |= BEACON_FUNCTION_ENABLE; + val8 &= ~BEACON_DISABLE_TSF_UPDATE; + rtl8723au_write8(priv, REG_BEACON_CTRL, val8); + + if (recover) { + val8 = rtl8723au_read8(priv, + REG_FWHW_TXQ_CTRL + 2); + val8 |= BIT(6); + rtl8723au_write8(priv, REG_FWHW_TXQ_CTRL + 2, + val8); + } + val16 = rtl8723au_read16(priv, REG_CR); + val16 &= ~CR_SW_BEACON_ENABLE; + rtl8723au_read16(priv, REG_CR, val16); +#endif + h2c.joinbss.data = H2C_JOIN_BSS_CONNECT; + } else { + val32 = rtl8723au_read32(priv, REG_RCR); + val32 &= ~(RCR_CHECK_BSSID_MATCH | + RCR_CHECK_BSSID_BEACON); + rtl8723au_write32(priv, REG_RCR, val32); + + val8 = rtl8723au_read8(priv, REG_BEACON_CTRL); + val8 |= BEACON_DISABLE_TSF_UPDATE; + rtl8723au_write8(priv, REG_BEACON_CTRL, val8); + + /* Disable RX of data frames */ + rtl8723au_write16(priv, REG_RXFLTMAP2, 0x0000); + h2c.joinbss.data = H2C_JOIN_BSS_DISCONNECT; + } + h2c.joinbss.cmd = H2C_JOIN_BSS_REPORT; + rtl8723a_h2c_cmd(priv, &h2c); + } + + if (changed & BSS_CHANGED_ERP_PREAMBLE) { + dev_info(dev, "Changed ERP_PREAMBLE: Use short preamble %02x\n", + bss_conf->use_short_preamble); + val32 = rtl8723au_read32(priv, REG_RESPONSE_RATE_SET); + if (bss_conf->use_short_preamble) + val32 |= RSR_ACK_SHORT_PREAMBLE; + else + val32 &= ~RSR_ACK_SHORT_PREAMBLE; + rtl8723au_write32(priv, REG_RESPONSE_RATE_SET, val32); + } + + if (changed & BSS_CHANGED_ERP_SLOT) { + dev_info(dev, "Changed ERP_SLOT: short_slot_time %i\n", + bss_conf->use_short_slot); + + if (bss_conf->use_short_slot) + val8 = 9; + else + val8 = 20; + rtl8723au_write8(priv, REG_SLOT, val8); + } + + if (changed & BSS_CHANGED_HT) { + u8 ampdu_factor, ampdu_density; + u8 sifs; + + rcu_read_lock(); + sta = ieee80211_find_sta(vif, bss_conf->bssid); + if (!sta) { + dev_info(dev, "BSS_CHANGED_HT: No HT sta found!\n"); + rcu_read_unlock(); + goto error; + } + if (sta->ht_cap.ht_supported) { + ampdu_factor = sta->ht_cap.ampdu_factor; + ampdu_density = sta->ht_cap.ampdu_density; + sifs = 0x0e; + } else { + ampdu_factor = 0; + ampdu_density = 0; + sifs = 0x0a; + } + rcu_read_unlock(); +#if 0 + dev_info(dev, + "Changed HT: ampdu_factor %02x, ampdu_density %02x\n", + ampdu_factor, ampdu_density); + rtl8xxxu_set_ampdu_factor(priv, ampdu_factor); + rtl8xxxu_set_ampdu_min_space(priv, ampdu_density); +#endif + + rtl8723au_write8(priv, REG_SIFS_CCK + 1, sifs); + rtl8723au_write8(priv, REG_SIFS_OFDM + 1, sifs); + rtl8723au_write8(priv, REG_SPEC_SIFS + 1, sifs); + rtl8723au_write8(priv, REG_MAC_SPEC_SIFS + 1, sifs); + rtl8723au_write8(priv, REG_R2T_SIFS + 1, sifs); + rtl8723au_write8(priv, REG_T2T_SIFS + 1, sifs); + } + + if (changed & BSS_CHANGED_BSSID) { + dev_info(dev, "Changed BSSID!\n"); + rtl8xxxu_set_bssid(priv, bss_conf->bssid); + + rcu_read_lock(); + sta = ieee80211_find_sta(vif, bss_conf->bssid); + if (!sta) { + dev_info(dev, "No bssid sta found!\n"); + rcu_read_unlock(); + goto error; + } + rcu_read_unlock(); + } + + if (changed & BSS_CHANGED_BASIC_RATES) { + dev_info(dev, "Changed BASIC_RATES!\n"); + rcu_read_lock(); + sta = ieee80211_find_sta(vif, bss_conf->bssid); + if (sta) + rtl8xxxu_set_basic_rates(priv, sta); + else + dev_info(dev, + "BSS_CHANGED_BASIC_RATES: No sta found!\n"); + + rcu_read_unlock(); + } +error: + return; +} + +static u32 rtl8xxxu_80211_to_rtl_queue(u32 queue) +{ + u32 rtlqueue; + + switch (queue) { + case IEEE80211_AC_VO: + rtlqueue = TXDESC_QUEUE_VO; + break; + case IEEE80211_AC_VI: + rtlqueue = TXDESC_QUEUE_VI; + break; + case IEEE80211_AC_BE: + rtlqueue = TXDESC_QUEUE_BE; + break; + case IEEE80211_AC_BK: + rtlqueue = TXDESC_QUEUE_BK; + break; + default: + rtlqueue = TXDESC_QUEUE_BE; + } + + return rtlqueue; +} + +static u32 rtl8xxxu_queue_select(struct ieee80211_hw *hw, struct sk_buff *skb) +{ + struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data; + u32 queue; + + if (unlikely(ieee80211_is_beacon(hdr->frame_control))) + queue = TXDESC_QUEUE_BEACON; + if (ieee80211_is_mgmt(hdr->frame_control)) + queue = TXDESC_QUEUE_MGNT; + else + queue = rtl8xxxu_80211_to_rtl_queue(skb_get_queue_mapping(skb)); + + return queue; +} + +static void rtl8xxxu_calc_tx_desc_csum(struct rtl8xxxu_tx_desc *tx_desc) +{ + u16 *ptr = (u16 *)tx_desc; + u16 csum = 0; + int i; + + tx_desc->csum = cpu_to_le32(0); + + for (i = 0; i < (sizeof(struct rtl8xxxu_tx_desc) / sizeof(u16)); i++) + csum = csum ^ le16_to_cpu(ptr[i]); + + tx_desc->csum |= cpu_to_le32(csum); +} + +static void rtl8xxxu_tx_complete(struct urb *urb) +{ + struct sk_buff *skb = (struct sk_buff *)urb->context; + struct ieee80211_tx_info *tx_info; + struct ieee80211_hw *hw; + + tx_info = IEEE80211_SKB_CB(skb); + hw = tx_info->rate_driver_data[0]; + + skb_pull(skb, sizeof(struct rtl8xxxu_tx_desc)); + + ieee80211_tx_info_clear_status(tx_info); + tx_info->status.rates[0].idx = -1; + tx_info->status.rates[0].count = 0; + + tx_info->flags |= IEEE80211_TX_STAT_ACK; + + ieee80211_tx_status_irqsafe(hw, skb); + + usb_free_urb(urb); +} + +static void rtl8xxxu_tx(struct ieee80211_hw *hw, + struct ieee80211_tx_control *control, + struct sk_buff *skb) +{ + struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data; + struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(skb); + struct ieee80211_rate *tx_rate = ieee80211_get_tx_rate(hw, tx_info); + struct rtl8xxxu_priv *priv = hw->priv; + struct rtl8xxxu_tx_desc *tx_desc; + struct device *dev = &priv->udev->dev; + struct urb *urb; + u32 queue, rate; + u16 pktlen = skb->len; + u16 seq_number; + u16 rate_flag = tx_info->control.rates[0].flags; + int ret; + + if (skb_headroom(skb) < sizeof(struct rtl8xxxu_tx_desc)) { + dev_warn(dev, + "%s: Not enough headroom (%i) for tx descriptor\n", + __func__, skb_headroom(skb)); + goto error; + } + + if (unlikely(skb->len > (65535 - sizeof(struct rtl8xxxu_tx_desc)))) { + dev_warn(dev, "%s: Trying to send over-sized skb (%i)\n", + __func__, skb->len); + goto error; + } + + urb = usb_alloc_urb(0, GFP_KERNEL); + if (!urb) { + dev_warn(dev, "%s: Unable to allocate urb\n", __func__); + goto error; + } + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_TX) + dev_info(dev, "%s: TX rate: %d (%d), pkt size %d\n", + __func__, tx_rate->bitrate, tx_rate->hw_value, pktlen); + + tx_info->rate_driver_data[0] = hw; + + tx_desc = (struct rtl8xxxu_tx_desc *) + skb_push(skb, sizeof(struct rtl8xxxu_tx_desc)); + + memset(tx_desc, 0, sizeof(struct rtl8xxxu_tx_desc)); + tx_desc->pkt_size = cpu_to_le16(pktlen); + tx_desc->pkt_offset = sizeof(struct rtl8xxxu_tx_desc); + + tx_desc->txdw0 = TXDESC_OWN | TXDESC_FSG | TXDESC_LSG; + if (is_multicast_ether_addr(ieee80211_get_DA(hdr)) || + is_broadcast_ether_addr(ieee80211_get_DA(hdr))) + tx_desc->txdw0 |= TXDESC_BROADMULTICAST; + + queue = rtl8xxxu_queue_select(hw, skb); + tx_desc->txdw1 = cpu_to_le32(queue << TXDESC_QUEUE_SHIFT); + + if (tx_info->control.hw_key) { + switch (tx_info->control.hw_key->cipher) { + case WLAN_CIPHER_SUITE_WEP40: + case WLAN_CIPHER_SUITE_WEP104: + case WLAN_CIPHER_SUITE_TKIP: + tx_desc->txdw1 |= cpu_to_le32(TXDESC_SEC_RC4); + break; + case WLAN_CIPHER_SUITE_CCMP: + tx_desc->txdw1 |= cpu_to_le32(TXDESC_SEC_AES); + break; + default: + break; + } + } + + seq_number = IEEE80211_SEQ_TO_SN(le16_to_cpu(hdr->seq_ctrl)); + tx_desc->txdw3 = cpu_to_le32((u32)seq_number << TXDESC_SEQ_SHIFT); + + if (rate_flag & IEEE80211_TX_RC_MCS) + rate = tx_info->control.rates[0].idx + DESC_RATE_MCS0; + else + rate = tx_rate->hw_value; + tx_desc->txdw5 = cpu_to_le32(rate); + + /* + * Black magic! + */ +#if 0 + if (ieee80211_is_data(hdr->frame_control)) { + tx_desc->txdw5 = cpu_to_le32(0x0001ff00); + + if ((tx_info->flags & IEEE80211_TX_CTL_AMPDU) && + control->sta->ht_cap.ht_supported && + control && control->sta) { + u8 ampdu = control->sta->ht_cap.ampdu_density; + + tx_desc->txdw2 |= + cpu_to_le32(ampdu << TXDESC_AMPDU_DENSITY_SHIFT); + tx_desc->txdw1 |= cpu_to_le32(TXDESC_AGG_ENABLE); + } else + tx_desc->txdw1 |= cpu_to_le32(TXDESC_BK); + } else +#endif + tx_desc->txdw1 |= cpu_to_le32(TXDESC_BK); + if (ieee80211_is_data_qos(hdr->frame_control)) + tx_desc->txdw4 |= cpu_to_le32(TXDESC_QOS); + if (rate_flag & IEEE80211_TX_RC_USE_SHORT_PREAMBLE) + tx_desc->txdw4 |= cpu_to_le32(TXDESC_SHORT_PREAMBLE); + if (rate_flag & IEEE80211_TX_RC_SHORT_GI || priv->use_shortgi) + tx_desc->txdw5 |= cpu_to_le32(TXDESC_SHORT_GI); + if (ieee80211_is_mgmt(hdr->frame_control)) { + tx_desc->txdw5 = cpu_to_le32(tx_rate->hw_value); + tx_desc->txdw4 |= cpu_to_le32(TXDESC_USE_DRIVER_RATE); + tx_desc->txdw5 |= cpu_to_le32(6 << TXDESC_RETRY_LIMIT_SHIFT); + tx_desc->txdw5 |= cpu_to_le32(TXDESC_RETRY_LIMIT_ENABLE); + } + + if (rate_flag & IEEE80211_TX_RC_USE_RTS_CTS) { + /* Use RTS rate 24M - does the mac80211 tell us which to use? */ + tx_desc->txdw4 |= cpu_to_le32(DESC_RATE_24M); + tx_desc->txdw4 |= cpu_to_le32(TXDESC_RTS_ENABLE); + } + + rtl8xxxu_calc_tx_desc_csum(tx_desc); + + usb_fill_bulk_urb(urb, priv->udev, priv->pipe_out[queue], skb->data, + skb->len, rtl8xxxu_tx_complete, skb); + + usb_anchor_urb(urb, &priv->tx_anchor); + ret = usb_submit_urb(urb, GFP_KERNEL); + if (ret) { + usb_unanchor_urb(urb); + goto error; + } + return; +error: + dev_kfree_skb(skb); +} + + +static void rtl8xxxu_rx_complete(struct urb *urb) +{ + struct rtl8xxxu_rx_urb *rx_urb = + container_of(urb, struct rtl8xxxu_rx_urb, urb); + struct ieee80211_hw *hw = rx_urb->hw; + struct rtl8xxxu_priv *priv = hw->priv; + struct sk_buff *skb = (struct sk_buff *)urb->context; + struct rtl8xxxu_rx_desc *rx_desc = (struct rtl8xxxu_rx_desc *)skb->data; + struct rtl8723au_phy_stats *phy_stats; + struct ieee80211_rx_status *rx_status = IEEE80211_SKB_RXCB(skb); + struct ieee80211_mgmt *mgmt; + struct device *dev = &priv->udev->dev; + __le32 *_rx_desc_le = (__le32 *)skb->data; + u32 *_rx_desc = (u32 *)skb->data; + int cnt, len, skb_size, drvinfo_sz, desc_shift, i, ret; + + for (i = 0; i < (sizeof(struct rtl8xxxu_rx_desc) / sizeof(u32)); i++) + _rx_desc[i] = le32_to_cpu(_rx_desc_le[i]); + + cnt = rx_desc->frag; + len = rx_desc->pktlen; + drvinfo_sz = rx_desc->drvinfo_sz * 8; + desc_shift = rx_desc->shift; + skb_put(skb, urb->actual_length); + + if (urb->status == 0) { + skb_pull(skb, sizeof(struct rtl8xxxu_rx_desc)); + phy_stats = (struct rtl8723au_phy_stats *)skb->data; + + skb_pull(skb, drvinfo_sz + desc_shift); + + mgmt = (struct ieee80211_mgmt *)skb->data; + + memset(rx_status, 0, sizeof(struct ieee80211_rx_status)); + + /* + * Note this is valid for CCK rates only - FIXME + */ + if (rx_desc->phy_stats) { + u8 cck_agc_rpt = phy_stats->cck_agc_rpt_ofdm_cfosho_a; + + switch (cck_agc_rpt & 0xc0) { + case 0xc0: + rx_status->signal = -46 - (cck_agc_rpt & 0x3e); + break; + case 0x80: + rx_status->signal = -26 - (cck_agc_rpt & 0x3e); + break; + case 0x40: + rx_status->signal = -12 - (cck_agc_rpt & 0x3e); + break; + case 0x00: + rx_status->signal = 16 - (cck_agc_rpt & 0x3e); + break; + } + } + + rx_status->freq = hw->conf.chandef.chan->center_freq; + rx_status->band = hw->conf.chandef.chan->band; + + if (!rx_desc->swdec) + rx_status->flag |= RX_FLAG_DECRYPTED; + if (rx_desc->crc32) + rx_status->flag |= RX_FLAG_FAILED_FCS_CRC; + if (rx_desc->bw) + rx_status->flag |= RX_FLAG_40MHZ; + + if (rx_desc->rxht) { + rx_status->flag |= RX_FLAG_HT; + rx_status->rate_idx = rx_desc->rxmcs - DESC_RATE_MCS0; + } else { + rx_status->rate_idx = rx_desc->rxmcs; + } + + ieee80211_rx_irqsafe(hw, skb); + skb_size = sizeof(struct rtl8xxxu_rx_desc) + + RTL_RX_BUFFER_SIZE; + skb = dev_alloc_skb(skb_size); + if (!skb) { + dev_warn(dev, "%s: Unable to allocate skb\n", __func__); + goto cleanup; + } + + memset(skb->data, 0, sizeof(struct rtl8xxxu_rx_desc)); + usb_fill_bulk_urb(&rx_urb->urb, priv->udev, priv->pipe_in, + skb->data, skb_size, rtl8xxxu_rx_complete, + skb); + + usb_anchor_urb(&rx_urb->urb, &priv->rx_anchor); + ret = usb_submit_urb(&rx_urb->urb, GFP_ATOMIC); + if (ret) { + usb_unanchor_urb(&rx_urb->urb); + goto cleanup; + } + } else { + dev_dbg(dev, "%s: status %i\n", __func__, urb->status); + goto cleanup; + } + return; + +cleanup: + usb_free_urb(urb); + dev_kfree_skb(skb); + return; +} + +static int rtl8xxxu_submit_rx_urb(struct ieee80211_hw *hw) +{ + struct rtl8xxxu_priv *priv = hw->priv; + struct sk_buff *skb; + struct rtl8xxxu_rx_urb *rx_urb; + int skb_size; + int ret; + + skb_size = sizeof(struct rtl8xxxu_rx_desc) + RTL_RX_BUFFER_SIZE; + skb = dev_alloc_skb(skb_size); + if (!skb) + return -ENOMEM; + + memset(skb->data, 0, sizeof(struct rtl8xxxu_rx_desc)); + + rx_urb = kmalloc(sizeof(struct rtl8xxxu_rx_urb), GFP_ATOMIC); + if (!rx_urb) { + dev_kfree_skb(skb); + return -ENOMEM; + } + usb_init_urb(&rx_urb->urb); + rx_urb->hw = hw; + + usb_fill_bulk_urb(&rx_urb->urb, priv->udev, priv->pipe_in, skb->data, + skb_size, rtl8xxxu_rx_complete, skb); + usb_anchor_urb(&rx_urb->urb, &priv->rx_anchor); + ret = usb_submit_urb(&rx_urb->urb, GFP_ATOMIC); + if (ret) + usb_unanchor_urb(&rx_urb->urb); + return ret; +} + +static void rtl8xxxu_int_complete(struct urb *urb) +{ + struct rtl8xxxu_priv *priv = (struct rtl8xxxu_priv *)urb->context; + struct device *dev = &priv->udev->dev; + int i, ret; + + dev_dbg(dev, "%s: status %i\n", __func__, urb->status); + if (urb->status == 0) { + for (i = 0; i < USB_INTR_CONTENT_LENGTH; i++) { + printk("%02x ", priv->int_buf[i]); + if ((i & 0x0f) == 0x0f) + printk("\n"); + } + + usb_anchor_urb(urb, &priv->int_anchor); + ret = usb_submit_urb(urb, GFP_ATOMIC); + if (ret) + usb_unanchor_urb(urb); + } else { + dev_info(dev, "%s: Error %i\n", __func__, urb->status); + } +} + + +static int rtl8xxxu_submit_int_urb(struct ieee80211_hw *hw) +{ + struct rtl8xxxu_priv *priv = hw->priv; + struct urb *urb; + u32 val32; + int ret; + + urb = usb_alloc_urb(0, GFP_KERNEL); + if (!urb) + return -ENOMEM; + + usb_fill_int_urb(urb, priv->udev, priv->pipe_interrupt, + priv->int_buf, USB_INTR_CONTENT_LENGTH, + rtl8xxxu_int_complete, priv, 1); + usb_anchor_urb(urb, &priv->int_anchor); + ret = usb_submit_urb(urb, GFP_KERNEL); + if (ret) { + usb_unanchor_urb(urb); + goto error; + } + + val32 = rtl8723au_read32(priv, REG_USB_HIMR); + val32 |= USB_HIMR_CPWM; + rtl8723au_write32(priv, REG_USB_HIMR, val32); + +error: + return ret; +} + +static int rtl8xxxu_add_interface(struct ieee80211_hw *hw, + struct ieee80211_vif *vif) +{ + struct rtl8xxxu_priv *priv = hw->priv; + int ret; + u8 val8; + + switch (vif->type) { + case NL80211_IFTYPE_STATION: + rtl8723a_stop_tx_beacon(priv); + + val8 = rtl8723au_read8(priv, REG_BEACON_CTRL); + val8 |= BEACON_ATIM | BEACON_FUNCTION_ENABLE | + BEACON_DISABLE_TSF_UPDATE; + rtl8723au_write8(priv, REG_BEACON_CTRL, val8); + ret = 0; + break; + default: + ret = -EOPNOTSUPP; + } + + rtl8xxxu_set_linktype(priv, vif->type); + + return ret; +} + +static void rtl8xxxu_remove_interface(struct ieee80211_hw *hw, + struct ieee80211_vif *vif) +{ + struct rtl8xxxu_priv *priv = hw->priv; + + dev_dbg(&priv->udev->dev, "%s\n", __func__); +} + +static int rtl8xxxu_config(struct ieee80211_hw *hw, u32 changed) +{ + struct rtl8xxxu_priv *priv = hw->priv; + struct device *dev = &priv->udev->dev; + u16 val16; + int ret = 0, channel; + bool ht40; + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_CHANNEL) + dev_info(dev, + "%s: channel: %i (changed %08x chandef.width %02x)\n", + __func__, hw->conf.chandef.chan->hw_value, + changed, hw->conf.chandef.width); + + if (changed & IEEE80211_CONF_CHANGE_RETRY_LIMITS) { + val16 = ((hw->conf.long_frame_max_tx_count << + RETRY_LIMIT_LONG_SHIFT) & RETRY_LIMIT_LONG_MASK) | + ((hw->conf.short_frame_max_tx_count << + RETRY_LIMIT_SHORT_SHIFT) & RETRY_LIMIT_SHORT_MASK); + rtl8723au_write16(priv, REG_RETRY_LIMIT, val16); + } + + if (changed & IEEE80211_CONF_CHANGE_CHANNEL) { + switch (hw->conf.chandef.width) { + case NL80211_CHAN_WIDTH_20_NOHT: + case NL80211_CHAN_WIDTH_20: + ht40 = false; + break; + case NL80211_CHAN_WIDTH_40: + ht40 = true; + break; + default: + ret = -ENOTSUPP; + goto exit; + } + + channel = hw->conf.chandef.chan->hw_value; + + rtl8723a_set_tx_power(priv, channel, ht40); + + rtl8723au_config_channel(hw); + } + +exit: + return ret; +} + +static int rtl8xxxu_conf_tx(struct ieee80211_hw *hw, + struct ieee80211_vif *vif, u16 queue, + const struct ieee80211_tx_queue_params *param) +{ + struct rtl8xxxu_priv *priv = hw->priv; + struct device *dev = &priv->udev->dev; + u32 val32; + u16 cw_min, cw_max, txop; + u8 aifs, acm_ctrl, acm_bit; + + aifs = param->aifs; + cw_min = cpu_to_le16(param->cw_min); + cw_max = cpu_to_le16(param->cw_max); + txop = cpu_to_le16(param->txop); + + val32 = aifs | + (cw_min & 0xf) << EDCA_PARAM_ECW_MIN_SHIFT | + (cw_max & 0xf) << EDCA_PARAM_ECW_MAX_SHIFT | + txop << EDCA_PARAM_TXOP_SHIFT; + + acm_ctrl = rtl8723au_read8(priv, REG_ACM_HW_CTRL); + dev_dbg(dev, + "%s: IEEE80211 queue %02x val %08x, acm %i, acm_ctrl %02x\n", + __func__, queue, val32, param->acm, acm_ctrl); + + switch (queue) { + case IEEE80211_AC_VO: + acm_bit = ACM_HW_CTRL_VO; + rtl8723au_write32(priv, REG_EDCA_VO_PARAM, val32); + break; + case IEEE80211_AC_VI: + acm_bit = ACM_HW_CTRL_VI; + rtl8723au_write32(priv, REG_EDCA_VI_PARAM, val32); + break; + case IEEE80211_AC_BE: + acm_bit = ACM_HW_CTRL_BE; + rtl8723au_write32(priv, REG_EDCA_BE_PARAM, val32); + break; + case IEEE80211_AC_BK: + acm_bit = ACM_HW_CTRL_BK; + rtl8723au_write32(priv, REG_EDCA_BK_PARAM, val32); + break; + default: + acm_bit = 0; + break; + } + + if (param->acm) + acm_ctrl |= acm_bit; + else + acm_ctrl &= ~acm_bit; + rtl8723au_write8(priv, REG_ACM_HW_CTRL, acm_ctrl); + + return 0; +} + +static void rtl8xxxu_configure_filter(struct ieee80211_hw *hw, + unsigned int changed_flags, + unsigned int *total_flags, u64 multicast) +{ + struct rtl8xxxu_priv *priv = hw->priv; + + dev_dbg(&priv->udev->dev, "%s: changed_flags %08x, total_flags %08x\n", + __func__, changed_flags, *total_flags); + + *total_flags &= (FIF_ALLMULTI | FIF_CONTROL | FIF_BCN_PRBRESP_PROMISC); +} + +static int rtl8xxxu_set_rts_threshold(struct ieee80211_hw *hw, u32 rts) +{ + if (rts > 2347) + return -EINVAL; + + return 0; +} + +static int rtl8xxxu_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd, + struct ieee80211_vif *vif, + struct ieee80211_sta *sta, + struct ieee80211_key_conf *key) +{ + struct rtl8xxxu_priv *priv = hw->priv; + struct device *dev = &priv->udev->dev; + u8 mac_addr[ETH_ALEN]; + u8 val8; + u16 val16; + u32 val32; + int retval = -EOPNOTSUPP; + + dev_dbg(dev, "%s: cmd %02x, cipher %08x, index %i\n", + __func__, cmd, key->cipher, key->keyidx); + + if (vif->type != NL80211_IFTYPE_STATION) + return -EOPNOTSUPP; + + if (key->keyidx > 3) + return -EOPNOTSUPP; + + switch (key->cipher) { + case WLAN_CIPHER_SUITE_WEP40: + case WLAN_CIPHER_SUITE_WEP104: + + break; + case WLAN_CIPHER_SUITE_CCMP: + key->flags |= IEEE80211_KEY_FLAG_SW_MGMT_TX; + break; + case WLAN_CIPHER_SUITE_TKIP: + key->flags |= IEEE80211_KEY_FLAG_GENERATE_MMIC; + default: + return -EOPNOTSUPP; + } + + if (key->flags & IEEE80211_KEY_FLAG_PAIRWISE) { + dev_dbg(dev, "%s: pairwise key\n", __func__); + ether_addr_copy(mac_addr, sta->addr); + } else { + dev_dbg(dev, "%s: group key\n", __func__); + eth_broadcast_addr(mac_addr); + } + + val16 = rtl8723au_read16(priv, REG_CR); + val16 |= CR_SECURITY_ENABLE; + rtl8723au_write16(priv, REG_CR, val16); + + val8 = SEC_CFG_TX_SEC_ENABLE | SEC_CFG_TXBC_USE_DEFKEY | + SEC_CFG_RX_SEC_ENABLE | SEC_CFG_RXBC_USE_DEFKEY; + val8 |= SEC_CFG_TX_USE_DEFKEY | SEC_CFG_RX_USE_DEFKEY; + rtl8723au_write8(priv, REG_SECURITY_CFG, val8); + + switch (cmd) { + case SET_KEY: + /* + * This is a bit of a hack - the lower bits of the cipher + * suite selector happens to match the cipher index in the + * CAM + */ + key->hw_key_idx = key->keyidx; + key->flags |= IEEE80211_KEY_FLAG_GENERATE_IV; + rtl8xxxu_cam_write(priv, key, mac_addr); + retval = 0; + break; + case DISABLE_KEY: + rtl8723au_write32(priv, REG_CAM_WRITE, 0x00000000); + val32 = CAM_CMD_POLLING | CAM_CMD_WRITE | + key->keyidx << CAM_CMD_KEY_SHIFT; + rtl8723au_write32(priv, REG_CAM_CMD, val32); + retval = 0; + break; + default: + dev_warn(dev, "%s: Unsupported command %02x\n", __func__, cmd); + } + + return retval; +} + +static int rtl8xxxu_start(struct ieee80211_hw *hw) +{ + struct rtl8xxxu_priv *priv = hw->priv; + int ret, i; + + ret = 0; + + init_usb_anchor(&priv->rx_anchor); + init_usb_anchor(&priv->tx_anchor); + init_usb_anchor(&priv->int_anchor); + + rtl8723a_enable_rf(priv); + ret = rtl8xxxu_submit_int_urb(hw); + if (ret) + goto exit; + + for (i = 0; i < 32; i++) + ret = rtl8xxxu_submit_rx_urb(hw); + +exit: + /* + * Disable all data frames + */ + rtl8723au_write16(priv, REG_RXFLTMAP2, 0x0000); + /* + * Accept all mgmt frames + */ + rtl8723au_write16(priv, REG_RXFLTMAP0, 0xffff); + + rtl8723au_write32(priv, REG_OFDM0_XA_AGC_CORE1, 0x6954341e); + + return ret; +} + +static void rtl8xxxu_stop(struct ieee80211_hw *hw) +{ + struct rtl8xxxu_priv *priv = hw->priv; + + rtl8723au_write8(priv, REG_TXPAUSE, 0xff); + + rtl8723au_write16(priv, REG_RXFLTMAP0, 0x0000); + rtl8723au_write16(priv, REG_RXFLTMAP2, 0x0000); + + usb_kill_anchored_urbs(&priv->rx_anchor); + usb_kill_anchored_urbs(&priv->tx_anchor); + usb_kill_anchored_urbs(&priv->int_anchor); + + rtl8723a_disable_rf(priv); + + /* + * Disable interrupts + */ + rtl8723au_write32(priv, REG_USB_HIMR, 0); +} + +static const struct ieee80211_ops rtl8xxxu_ops = { + .tx = rtl8xxxu_tx, + .add_interface = rtl8xxxu_add_interface, + .remove_interface = rtl8xxxu_remove_interface, + .config = rtl8xxxu_config, + .conf_tx = rtl8xxxu_conf_tx, + .bss_info_changed = rtl8xxxu_bss_info_changed, + .configure_filter = rtl8xxxu_configure_filter, + .set_rts_threshold = rtl8xxxu_set_rts_threshold, + .start = rtl8xxxu_start, + .stop = rtl8xxxu_stop, + .sw_scan_start = rtl8xxxu_sw_scan_start, + .sw_scan_complete = rtl8xxxu_sw_scan_complete, + .set_key = rtl8xxxu_set_key, +}; + +static int rtl8xxxu_parse_usb(struct rtl8xxxu_priv *priv, + struct usb_interface *interface) +{ + struct usb_interface_descriptor *interface_desc; + struct usb_host_interface *host_interface; + struct usb_endpoint_descriptor *endpoint; + struct device *dev = &priv->udev->dev; + int i, j = 0, endpoints; + u8 dir, xtype, num; + int ret = 0; + + host_interface = &interface->altsetting[0]; + interface_desc = &host_interface->desc; + endpoints = interface_desc->bNumEndpoints; + + for (i = 0; i < endpoints; i++) { + endpoint = &host_interface->endpoint[i].desc; + + dir = endpoint->bEndpointAddress & USB_ENDPOINT_DIR_MASK; + num = usb_endpoint_num(endpoint); + xtype = usb_endpoint_type(endpoint); + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_USB) + dev_dbg(dev, + "%s: endpoint: dir %02x, # %02x, type %02x\n", + __func__, dir, num, xtype); + if (usb_endpoint_dir_in(endpoint) && + usb_endpoint_xfer_bulk(endpoint)) { + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_USB) + dev_dbg(dev, "%s: in endpoint num %i\n", + __func__, num); + + if (priv->pipe_in) { + dev_warn(dev, + "%s: Too many IN pipes\n", __func__); + ret = -EINVAL; + goto exit; + } + + priv->pipe_in = usb_rcvbulkpipe(priv->udev, num); + } + + if (usb_endpoint_dir_in(endpoint) && + usb_endpoint_xfer_int(endpoint)) { + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_USB) + dev_dbg(dev, "%s: interrupt endpoint num %i\n", + __func__, num); + + if (priv->pipe_interrupt) { + dev_warn(dev, "%s: Too many INTERRUPT pipes\n", + __func__); + ret = -EINVAL; + goto exit; + } + + priv->pipe_interrupt = usb_rcvintpipe(priv->udev, num); + } + + if (usb_endpoint_dir_out(endpoint) && + usb_endpoint_xfer_bulk(endpoint)) { + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_USB) + dev_dbg(dev, "%s: out endpoint num %i\n", + __func__, num); + if (j >= RTL8XXXU_OUT_ENDPOINTS) { + dev_warn(dev, + "%s: Too many OUT pipes\n", __func__); + ret = -EINVAL; + goto exit; + } + priv->out_ep[j++] = num; + } + } +exit: + return ret; +} + +static int rtl8xxxu_probe(struct usb_interface *interface, + const struct usb_device_id *id) +{ + struct rtl8xxxu_priv *priv; + struct ieee80211_hw *hw; + struct usb_device *udev; + struct ieee80211_supported_band *sband; + int ret = 0; + + udev = usb_get_dev(interface_to_usbdev(interface)); + + hw = ieee80211_alloc_hw(sizeof(struct rtl8xxxu_priv), &rtl8xxxu_ops); + if (!hw) { + ret = -ENOMEM; + goto exit; + } + + priv = hw->priv; + priv->hw = hw; + priv->udev = udev; + mutex_init(&priv->usb_buf_mutex); + mutex_init(&priv->h2c_mutex); + + usb_set_intfdata(interface, hw); + + ret = rtl8xxxu_parse_usb(priv, interface); + if (ret) + goto exit; + + rtl8xxxu_8723au_identify_chip(priv); + rtl8xxxu_read_efuse(priv); + ether_addr_copy(priv->mac_addr, priv->efuse_wifi.efuse.mac_addr); + + dev_info(&udev->dev, "RTL8723au MAC %02x:%02x:%02x:%02x:%02x:%02x\n", + priv->efuse_wifi.efuse.mac_addr[0], + priv->efuse_wifi.efuse.mac_addr[1], + priv->efuse_wifi.efuse.mac_addr[2], + priv->efuse_wifi.efuse.mac_addr[3], + priv->efuse_wifi.efuse.mac_addr[4], + priv->efuse_wifi.efuse.mac_addr[5]); + + rtl8xxxu_load_firmware(priv); + + ret = rtl8xxxu_init_device(hw); + + hw->wiphy->max_scan_ssids = 1; + hw->wiphy->max_scan_ie_len = IEEE80211_MAX_DATA_LEN; + hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION); + hw->queues = 4; + + sband = &rtl8xxxu_supported_band; + sband->ht_cap.ht_supported = true; +#if 0 + sband->ht_cap.ampdu_factor = IEEE80211_HT_MAX_AMPDU_8K; + sband->ht_cap.ampdu_density = IEEE80211_HT_MPDU_DENSITY_16; +#endif + sband->ht_cap.cap = /* IEEE80211_HT_CAP_SUP_WIDTH_20_40 | */ + IEEE80211_HT_CAP_SGI_20 | IEEE80211_HT_CAP_SGI_40; + memset(&sband->ht_cap.mcs, 0, sizeof(sband->ht_cap.mcs)); + sband->ht_cap.mcs.rx_mask[0] = 0xff; + sband->ht_cap.mcs.rx_mask[4] = 0x01; + if (priv->rf_paths > 1) { + sband->ht_cap.mcs.rx_mask[1] = 0xff; + sband->ht_cap.mcs.rx_highest = cpu_to_le16(300); + sband->ht_cap.cap |= IEEE80211_HT_CAP_SGI_40; + } else { + sband->ht_cap.mcs.rx_mask[1] = 0x00; + sband->ht_cap.mcs.rx_highest = cpu_to_le16(150); + } + sband->ht_cap.mcs.tx_params = IEEE80211_HT_MCS_TX_DEFINED; + hw->wiphy->bands[IEEE80211_BAND_2GHZ] = sband; + + hw->wiphy->max_remain_on_channel_duration = 65535; /* ms */ + hw->wiphy->cipher_suites = rtl8xxxu_cipher_suites; + hw->wiphy->n_cipher_suites = ARRAY_SIZE(rtl8xxxu_cipher_suites); + hw->wiphy->rts_threshold = 2347; + + SET_IEEE80211_DEV(priv->hw, &interface->dev); + SET_IEEE80211_PERM_ADDR(hw, priv->mac_addr); + + hw->extra_tx_headroom = sizeof(struct rtl8xxxu_tx_desc); + hw->flags = IEEE80211_HW_SIGNAL_DBM; + /* + * The firmware can handle rate control, but we need callbacks + */ + hw->flags |= IEEE80211_HW_HAS_RATE_CONTROL; + + ret = ieee80211_register_hw(priv->hw); + if (ret) { + dev_err(&udev->dev, "%s: Failed to register: %i\n", + __func__, ret); + goto exit; + } + +exit: + if (ret < 0) + usb_put_dev(udev); + return ret; +} + +static void rtl8xxxu_disconnect(struct usb_interface *interface) +{ + struct rtl8xxxu_priv *priv; + struct ieee80211_hw *hw; + + hw = usb_get_intfdata(interface); + priv = hw->priv; + + rtl8xxxu_disable_device(hw); + usb_set_intfdata(interface, NULL); + + ieee80211_unregister_hw(hw); + + kfree(priv->fw_data); + mutex_destroy(&priv->usb_buf_mutex); + mutex_destroy(&priv->h2c_mutex); + + usb_put_dev(priv->udev); + ieee80211_free_hw(hw); + + wiphy_info(hw->wiphy, "disconnecting\n"); +} + +static struct usb_driver rtl8xxxu_driver = { + .name = DRIVER_NAME, + .probe = rtl8xxxu_probe, + .disconnect = rtl8xxxu_disconnect, + .id_table = dev_table, + .disable_hub_initiated_lpm = 1, +}; + +static int __init rtl8xxxu_module_init(void) +{ + int res; + + res = usb_register(&rtl8xxxu_driver); + if (res < 0) + pr_err(DRIVER_NAME ": usb_register() failed (%i)\n", res); + + return res; +} + +static void __exit rtl8xxxu_module_exit(void) +{ + usb_deregister(&rtl8xxxu_driver); +} + +module_init(rtl8xxxu_module_init); +module_exit(rtl8xxxu_module_exit); diff --git a/drivers/net/wireless/rtl8xxxu.h b/drivers/net/wireless/rtl8xxxu.h new file mode 100644 index 0000000..65cfea8 --- /dev/null +++ b/drivers/net/wireless/rtl8xxxu.h @@ -0,0 +1,494 @@ +/* + * Copyright (c) 2014 Jes Sorensen <Jes.Sorensen@redhat.com> + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of version 2 of the GNU General Public License as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * Register definitions taken from original Realtek rtl8723au driver + */ + +#include <asm/byteorder.h> + +#define RTL8XXXU_DEBUG_REG_WRITE 0x01 +#define RTL8XXXU_DEBUG_REG_READ 0x02 +#define RTL8XXXU_DEBUG_RFREG_WRITE 0x04 +#define RTL8XXXU_DEBUG_RFREG_READ 0x08 +#define RTL8XXXU_DEBUG_CHANNEL 0x10 +#define RTL8XXXU_DEBUG_TX 0x20 +#define RTL8XXXU_DEBUG_TX_DUMP 0x40 +#define RTL8XXXU_DEBUG_RX 0x80 +#define RTL8XXXU_DEBUG_RX_DUMP 0x100 +#define RTL8XXXU_DEBUG_USB 0x200 +#define RTL8XXXU_DEBUG_KEY 0x400 +#define RTL8XXXU_DEBUG_H2C 0x800 + +#define RTW_USB_CONTROL_MSG_TIMEOUT 500 +#define RTL8XXXU_MAX_REG_POLL 500 +#define USB_INTR_CONTENT_LENGTH 56 + +#define RTL8XXXU_OUT_ENDPOINTS 3 + +#define REALTEK_USB_READ 0xc0 +#define REALTEK_USB_WRITE 0x40 +#define REALTEK_USB_CMD_REQ 0x05 +#define REALTEK_USB_CMD_IDX 0x00 + +#define TX_TOTAL_PAGE_NUM 0xf8 +/* (HPQ + LPQ + NPQ + PUBQ) = TX_TOTAL_PAGE_NUM */ +#define TX_PAGE_NUM_PUBQ 0xe7 +#define TX_PAGE_NUM_HI_PQ 0x0c +#define TX_PAGE_NUM_LO_PQ 0x02 +#define TX_PAGE_NUM_NORM_PQ 0x02 + +#define RTL_FW_PAGE_SIZE 4096 +#define RTL8XXXU_FIRMWARE_POLL_MAX 1000 + +#define RTL8723A_CHANNEL_GROUPS 3 +#define RTL8723A_MAX_RF_PATHS 2 +#define RF6052_MAX_TX_PWR 0x3f + +#define EFUSE_MAP_LEN_8723A 256 +#define EFUSE_MAX_SECTION_8723A 32 +#define EFUSE_REAL_CONTENT_LEN_8723A 512 +#define EFUSE_BT_MAP_LEN_8723A 1024 +#define EFUSE_MAX_WORD_UNIT 4 + +struct rtl8xxxu_rx_desc { + u32 pktlen:14; + u32 crc32:1; + u32 icverr:1; + u32 drvinfo_sz:4; + u32 security:3; + u32 qos:1; + u32 shift:2; + u32 phy_stats:1; + u32 swdec:1; + u32 ls:1; + u32 fs:1; + u32 eor:1; + u32 own:1; + + u32 macid:5; + u32 tid:4; + u32 hwrsvd:4; + u32 amsdu:1; + u32 paggr:1; + u32 faggr:1; + u32 a1fit:4; + u32 a2fit:4; + u32 pam:1; + u32 pwr:1; + u32 md:1; + u32 mf:1; + u32 type:2; + u32 mc:1; + u32 bc:1; + + u32 seq:12; + u32 frag:4; + u32 nextpktlen:14; + u32 nextind:1; + u32 reserved0:1; + + u32 rxmcs:6; + u32 rxht:1; + u32 gf:1; + u32 splcp:1; + u32 bw:1; + u32 htc:1; + u32 eosp:1; + u32 bssidfit:2; + u32 reserved1:16; + u32 unicastwake:1; + u32 magicwake:1; + + u32 pattern0match:1; + u32 pattern1match:1; + u32 pattern2match:1; + u32 pattern3match:1; + u32 pattern4match:1; + u32 pattern5match:1; + u32 pattern6match:1; + u32 pattern7match:1; + u32 pattern8match:1; + u32 pattern9match:1; + u32 patternamatch:1; + u32 patternbmatch:1; + u32 patterncmatch:1; + u32 reserved2:19; + + u32 tsfl; +#if 0 + u32 bassn:12; + u32 bavld:1; + u32 reserved3:19; +#endif +}; + +struct rtl8xxxu_tx_desc { + __le16 pkt_size; + u8 pkt_offset; + u8 txdw0; + __le32 txdw1; + __le32 txdw2; + __le32 txdw3; + __le32 txdw4; + __le32 txdw5; + __le32 txdw6; + __le16 csum; + __le16 txdw7; +}; + +/* CCK Rates, TxHT = 0 */ +#define DESC_RATE_1M 0x00 +#define DESC_RATE_2M 0x01 +#define DESC_RATE_5_5M 0x02 +#define DESC_RATE_11M 0x03 + +/* OFDM Rates, TxHT = 0 */ +#define DESC_RATE_6M 0x04 +#define DESC_RATE_9M 0x05 +#define DESC_RATE_12M 0x06 +#define DESC_RATE_18M 0x07 +#define DESC_RATE_24M 0x08 +#define DESC_RATE_36M 0x09 +#define DESC_RATE_48M 0x0a +#define DESC_RATE_54M 0x0b + +/* MCS Rates, TxHT = 1 */ +#define DESC_RATE_MCS0 0x0c +#define DESC_RATE_MCS1 0x0d +#define DESC_RATE_MCS2 0x0e +#define DESC_RATE_MCS3 0x0f +#define DESC_RATE_MCS4 0x10 +#define DESC_RATE_MCS5 0x11 +#define DESC_RATE_MCS6 0x12 +#define DESC_RATE_MCS7 0x13 +#define DESC_RATE_MCS8 0x14 +#define DESC_RATE_MCS9 0x15 +#define DESC_RATE_MCS10 0x16 +#define DESC_RATE_MCS11 0x17 +#define DESC_RATE_MCS12 0x18 +#define DESC_RATE_MCS13 0x19 +#define DESC_RATE_MCS14 0x1a +#define DESC_RATE_MCS15 0x1b +#define DESC_RATE_MCS15_SG 0x1c +#define DESC_RATE_MCS32 0x20 + +#define TXDESC_OFFSET_SZ 0 +#define TXDESC_OFFSET_SHT 16 +#if 0 +#define TXDESC_BMC BIT(24) +#define TXDESC_LSG BIT(26) +#define TXDESC_FSG BIT(27) +#define TXDESC_OWN BIT(31) +#else +#define TXDESC_BROADMULTICAST BIT(0) +#define TXDESC_LSG BIT(2) +#define TXDESC_FSG BIT(3) +#define TXDESC_OWN BIT(7) +#endif + +/* Word 1 */ +#define TXDESC_PKT_OFFSET_SZ 0 +#define TXDESC_AGG_ENABLE BIT(5) +#define TXDESC_BK BIT(6) +#define TXDESC_QUEUE_SHIFT 8 +#define TXDESC_QUEUE_MASK 0x1f00 +#define TXDESC_QUEUE_BK 0x2 +#define TXDESC_QUEUE_BE 0x0 +#define TXDESC_QUEUE_VI 0x5 +#define TXDESC_QUEUE_VO 0x7 +#define TXDESC_QUEUE_BEACON 0x10 +#define TXDESC_QUEUE_HIGH 0x11 +#define TXDESC_QUEUE_MGNT 0x12 +#define TXDESC_QUEUE_CMD 0x13 +#define TXDESC_QUEUE_MAX (TXDESC_QUEUE_CMD + 1) + +#define DESC_RATE_ID_SHIFT 16 +#define DESC_RATE_ID_MASK 0xf +#define TXDESC_NAVUSEHDR BIT(20) +#define TXDESC_SEC_RC4 0x00400000 +#define TXDESC_SEC_AES 0x00c00000 +#define TXDESC_PKT_OFFSET_SHIFT 26 +#define TXDESC_HWPC BIT(31) + +/* Word 2 */ +#define TXDESC_AMPDU_DENSITY_SHIFT 20 +#define TXDESC_AGG_EN BIT(29) + +/* Word 3 */ +#define TXDESC_SEQ_SHIFT 16 +#define TXDESC_SEQ_MASK 0x000fff0000 + +/* Word 4 */ +#define TXDESC_QOS BIT(6) +#define TXDESC_HW_SEQ_ENABLE BIT(7) +#define TXDESC_USE_DRIVER_RATE BIT(8) +#define TXDESC_DISABLE_DATA_FB BIT(10) +#define TXDESC_SHORT_PREAMBLE BIT(24) +#define TXDESC_DATA_BW BIT(25) + +/* Word 5 */ +#define TXDESC_RTS_RATE_SHIFT 0 +#define TXDESC_RTS_RATE_MASK 0x3f +#define TXDESC_SHORT_GI BIT(6) +#define TXDESC_CCX_TAG BIT(7) +#define TXDESC_RTS_ENABLE BIT(12) +#define TXDESC_RETRY_LIMIT_ENABLE BIT(17) +#define TXDESC_RETRY_LIMIT_SHIFT 18 +#define TXDESC_RETRY_LIMIT_MASK 0x003f0000 + +struct phy_rx_agc_info { +#ifdef __LITTLE_ENDIAN + u8 gain:7, trsw:1; +#else + u8 trsw:1, gain:7; +#endif +}; + +struct rtl8723au_phy_stats { + struct phy_rx_agc_info path_agc[RTL8723A_MAX_RF_PATHS]; + u8 ch_corr[RTL8723A_MAX_RF_PATHS]; + u8 cck_sig_qual_ofdm_pwdb_all; + u8 cck_agc_rpt_ofdm_cfosho_a; + u8 cck_rpt_b_ofdm_cfosho_b; + u8 reserved_1; + u8 noise_power_db_msb; + u8 path_cfotail[RTL8723A_MAX_RF_PATHS]; + u8 pcts_mask[RTL8723A_MAX_RF_PATHS]; + s8 stream_rxevm[RTL8723A_MAX_RF_PATHS]; + u8 path_rxsnr[RTL8723A_MAX_RF_PATHS]; + u8 noise_power_db_lsb; + u8 reserved_2[3]; + u8 stream_csi[RTL8723A_MAX_RF_PATHS]; + u8 stream_target_csi[RTL8723A_MAX_RF_PATHS]; + s8 sig_evm; + u8 reserved_3; + +#ifdef __LITTLE_ENDIAN + u8 antsel_rx_keep_2:1; /* ex_intf_flg:1; */ + u8 sgi_en:1; + u8 rxsc:2; + u8 idle_long:1; + u8 r_ant_train_en:1; + u8 antenna_select_b:1; + u8 antenna_select:1; +#else /* _BIG_ENDIAN_ */ + u8 antenna_select:1; + u8 antenna_select_b:1; + u8 r_ant_train_en:1; + u8 idle_long:1; + u8 rxsc:2; + u8 sgi_en:1; + u8 antsel_rx_keep_2:1; /* ex_intf_flg:1; */ +#endif +}; + +/* + * Regs to backup + */ +#define RTL8XXXU_ADDA_REGS 16 +#define RTL8XXXU_MAC_REGS 4 +#define RTL8XXXU_BB_REGS 9 + +struct rtl8xxxu_firmware_header { + __le16 signature; /* 92C0: test chip; 92C, + 88C0: test chip; + 88C1: MP A-cut; + 92C1: MP A-cut */ + u8 category; /* AP/NIC and USB/PCI */ + u8 function; + + __le16 major_version; /* FW Version */ + u8 minor_version; /* FW Subversion, default 0x00 */ + u8 reserved1; + + u8 month; /* Release time Month field */ + u8 date; /* Release time Date field */ + u8 hour; /* Release time Hour field */ + u8 minute; /* Release time Minute field */ + + __le16 ramcodesize; /* Size of RAM code */ + u16 reserved2; + + __le32 svn_idx; /* SVN entry index */ + u32 reserved3; + + u32 reserved4; + u32 reserved5; + + u8 data[0]; +}; + +/* + * The 8723au has 3 channel groups: 1-3, 4-9, and 10-14 + */ +struct rtl8723au_idx { +#ifdef __LITTLE_ENDIAN + int a:4; + int b:4; +#else + int b:4; + int a:4; +#endif +} __attribute__((packed)); + +struct rtl8723au_efuse { + __le16 rtl_id; + u8 res0[0xe]; + u8 cck_tx_power_index_A[3]; /* 0x10 */ + u8 cck_tx_power_index_B[3]; + u8 ht40_1s_tx_power_index_A[3]; /* 0x16 */ + u8 ht40_1s_tx_power_index_B[3]; + /* + * The following entries are half-bytes split as: + * bits 0-3: path A, bits 4-7: path B, all values 4 bits signed + */ + struct rtl8723au_idx ht20_tx_power_index_diff[3]; + struct rtl8723au_idx ofdm_tx_power_index_diff[3]; + struct rtl8723au_idx ht40_max_power_offset[3]; + struct rtl8723au_idx ht20_max_power_offset[3]; + u8 channel_plan; /* 0x28 */ + u8 tssi_a; + u8 thermal_meter; + u8 rf_regulatory; + u8 rf_option_2; + u8 rf_option_3; + u8 rf_option_4; + u8 res7; + u8 version /* 0x30 */; + u8 customer_id_major; + u8 customer_id_minor; + u8 xtal_k; + u8 chipset; /* 0x34 */ + u8 res8[0x82]; + u8 vid; /* 0xb7 */ + u8 res9; + u8 pid; /* 0xb9 */ + u8 res10[0x0c]; + u8 mac_addr[ETH_ALEN]; /* 0xc6 */ + u8 res11[2]; + u8 vendor_name[7]; + u8 res12[2]; + u8 device_name[0x29]; /* 0xd7 */ +}; + +struct rtl8xxxu_reg8val { + u16 reg; + u8 val; +}; + +struct rtl8xxxu_reg32val { + u16 reg; + u32 val; +}; + +struct rtl8xxxu_rfregval { + u8 reg; + u32 val; +}; + +#define H2C_MAX_MBOX 4 +#define H2C_EXT BIT(7) +#define H2C_SET_POWER_MODE 1 +#define H2C_JOIN_BSS_REPORT 2 +#define H2C_JOIN_BSS_DISCONNECT 0 +#define H2C_JOIN_BSS_CONNECT 1 +#define H2C_SET_RSSI 5 +#define H2C_SET_RATE_MASK (6 | H2C_EXT) + +struct h2c_cmd { + union { + struct { + u8 cmd; + u8 data[5]; + } __packed cmd; + struct { + __le32 data; + __le16 ext; + } __packed raw; + struct { + u8 cmd; + u8 data; + u8 pad[4]; + } __packed joinbss; + struct { + u8 cmd; + __le16 mask_hi; + u8 arg; + __le16 mask_lo; + } __packed ramask; + }; +}; + +struct rtl8xxxu_priv { + struct ieee80211_hw *hw; + struct usb_device *udev; + u8 mac_addr[ETH_ALEN]; + u32 chip_cut:4; + u32 rom_rev:4; + u32 has_wifi:1; + u32 has_bluetooth:1; + u32 enable_bluetooth:1; + u32 has_gps:1; + u32 vendor_umc:1; + u32 has_polarity_ctrl:1; + u32 has_eeprom:1; + u32 boot_eeprom:1; + u32 ep_tx_high_queue:1; + u32 ep_tx_normal_queue:1; + u32 ep_tx_low_queue:1; + u32 path_a_hi_power:1; + u32 path_a_rf_paths:4; + unsigned int pipe_interrupt; + unsigned int pipe_in; + unsigned int pipe_out[TXDESC_QUEUE_MAX]; + u8 out_ep[RTL8XXXU_OUT_ENDPOINTS]; + u8 path_a_ig_value; + int ep_tx_count; + int rf_paths; + u32 rf_mode_ag[2]; + u32 rege94; + u32 rege9c; + u32 regeb4; + u32 regebc; + int next_mbox; + + struct mutex h2c_mutex; + + struct usb_anchor rx_anchor; + struct usb_anchor tx_anchor; + struct usb_anchor int_anchor; + struct rtl8xxxu_firmware_header *fw_data; + size_t fw_size; + struct mutex usb_buf_mutex; + union { + __le32 val32; + __le16 val16; + u8 val8; + } usb_buf; + union { + u8 raw[EFUSE_MAP_LEN_8723A]; + struct rtl8723au_efuse efuse; + } efuse_wifi; + u32 adda_backup[RTL8XXXU_ADDA_REGS]; + u32 mac_backup[RTL8XXXU_MAC_REGS]; + u32 bb_backup[RTL8XXXU_BB_REGS]; + u32 bb_recovery_backup[RTL8XXXU_BB_REGS]; + u8 pi_enabled:1; + u8 iqk_initialized:1; + u8 int_buf[USB_INTR_CONTENT_LENGTH]; + bool use_shortgi; +}; + +struct rtl8xxxu_rx_urb { + struct urb urb; + struct ieee80211_hw *hw; +}; diff --git a/drivers/net/wireless/rtl8xxxu_regs.h b/drivers/net/wireless/rtl8xxxu_regs.h new file mode 100644 index 0000000..9b1a8bd --- /dev/null +++ b/drivers/net/wireless/rtl8xxxu_regs.h @@ -0,0 +1,940 @@ +/* + * Copyright (c) 2014 Jes Sorensen <Jes.Sorensen@redhat.com> + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of version 2 of the GNU General Public License as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * Register definitions taken from original Realtek rtl8723au driver + */ + +/* 0x0000 ~ 0x00FF System Configuration */ +#define REG_SYS_ISO_CTRL 0x0000 +#define SYS_ISO_PWC_EV25V BIT(14) +#define SYS_ISO_PWC_EV12V BIT(15) +#define SYS_ISO_ANALOG_IPS BIT(5) + +#define REG_SYS_FUNC 0x0002 +#define SYS_FUNC_BBRSTB BIT(0) +#define SYS_FUNC_BB_GLB_RSTN BIT(1) +#define SYS_FUNC_USBA BIT(2) +#define SYS_FUNC_UPLL BIT(3) +#define SYS_FUNC_USBD BIT(4) +#define SYS_FUNC_DIO_PCIE BIT(5) +#define SYS_FUNC_PCIEA BIT(6) +#define SYS_FUNC_PPLL BIT(7) +#define SYS_FUNC_PCIED BIT(8) +#define SYS_FUNC_DIOE BIT(9) +#define SYS_FUNC_CPU_ENABLE BIT(10) +#define SYS_FUNC_DCORE BIT(11) +#define SYS_FUNC_ELDR BIT(12) +#define SYS_FUNC_DIO_RF BIT(13) +#define SYS_FUNC_HWPDN BIT(14) +#define SYS_FUNC_MREGEN BIT(15) + +#define REG_APS_FSMCO 0x0004 +#define APS_FSMCO_HW_POWERDOWN BIT(15) +#define APS_FSMCO_WLON_RESET BIT(16) + +#define REG_SYS_CLKR 0x0008 +#define SYS_CLK_ANAD16V_ENABLE BIT(0) +#define SYS_CLK_ANA8M BIT(1) +#define SYS_CLK_MACSLP BIT(4) +#define SYS_CLK_LOADER_ENABLE BIT(5) +#define SYS_CLK_80M_SSC_DISABLE BIT(7) +#define SYS_CLK_80M_SSC_ENABLE_HO BIT(8) +#define SYS_CLK_PHY_SSC_RSTB BIT(9) +#define SYS_CLK_SEC_CLK_ENABLE BIT(10) +#define SYS_CLK_MAC_CLK_ENABLE BIT(11) +#define SYS_CLK_ENABLE BIT(12) +#define SYS_CLK_RING_CLK_ENABLE BIT(13) + +#define REG_9346CR 0x000a +#define EEPROM_BOOT BIT(4) +#define EEPROM_ENABLE BIT(5) + +#define REG_EE_VPD 0x000c +#define REG_AFE_MISC 0x0010 +#define REG_SPS0_CTRL 0x0011 +#define REG_SPS_OCP_CFG 0x0018 +#define REG_RSV_CTRL 0x001c + +#define REG_RF_CTRL 0x001f +#define RF_ENABLE BIT(0) +#define RF_RSTB BIT(1) +#define RF_SDMRSTB BIT(2) + +#define REG_LDOA15_CTRL 0x0020 +#define LDOA15_ENABLE BIT(0) +#define LDOA15_STANDBY BIT(1) +#define LDOA15_OBUF BIT(2) +#define LDOA15_REG_VOS BIT(3) +#define LDOA15_VOADJ_SHIFT 4 + +#define REG_LDOV12D_CTRL 0x0021 +#define LDOV12D_ENABLE BIT(0) +#define LDOV12D_STANDBY BIT(1) +#define LDOV12D_VADJ_SHIFT 4 + +#define REG_LDOHCI12_CTRL 0x0022 + +#define REG_LPLDO_CTRL 0x0023 +#define LPLDO_HSM BIT(2) +#define LPLDO_LSM_DIS BIT(3) + +#define REG_AFE_XTAL_CTRL 0x0024 +#define AFE_XTAL_ENABLE BIT(0) +#define AFE_XTAL_B_SELECT BIT(1) +#define AFE_XTAL_RF_GATE BIT(14) +#define AFE_XTAL_BT_GATE BIT(20) + +#define REG_AFE_PLL_CTRL 0x0028 +#define AFE_PLL_ENABLE BIT(0) +#define AFE_PLL_320_ENABLE BIT(1) +#define APE_PLL_FREF_SELECT BIT(2) +#define AFE_PLL_EDGE_SELECT BIT(3) +#define AFE_PLL_WDOGB BIT(4) +#define AFE_PLL_LPF_ENABLE BIT(5) + +#define REG_MAC_PHY_CTRL 0x002c + +#define REG_EFUSE_CTRL 0x0030 +#define REG_EFUSE_TEST 0x0034 +#define EFUSE_TRPT BIT(7) + /* 00: Wifi Efuse, 01: BT Efuse0, 10: BT Efuse1, 11: BT Efuse2 */ +#define EFUSE_CELL_SEL (BIT(8) | BIT(9)) +#define EFUSE_LDOE25_ENABLE BIT(31) +#define EFUSE_SELECT_MASK 0x0300 +#define EFUSE_WIFI_SELECT 0x0000 +#define EFUSE_BT0_SELECT 0x0100 +#define EFUSE_BT1_SELECT 0x0200 +#define EFUSE_BT2_SELECT 0x0300 + +#define EFUSE_ACCESS_ENABLE 0x69 /* RTL8723 only */ +#define EFUSE_ACCESS_DISABLE 0x00 /* RTL8723 only */ + +#define REG_PWR_DATA 0x0038 +#define REG_CAL_TIMER 0x003c +#define REG_ACLK_MON 0x003e +#define REG_GPIO_MUXCFG 0x0040 +#define REG_GPIO_IO_SEL 0x0042 +#define REG_MAC_PINMUX_CFG 0x0043 +#define REG_GPIO_PIN_CTRL 0x0044 +#define REG_GPIO_INTM 0x0048 +#define REG_LEDCFG0 0x004c +#define REG_LEDCFG1 0x004d +#define REG_LEDCFG2 0x004e +#define LEDCFG2_DPDT_SELECT BIT(7) +#define REG_LEDCFG3 0x004f +#define REG_LEDCFG REG_LEDCFG2 +#define REG_FSIMR 0x0050 +#define REG_FSISR 0x0054 +#define REG_HSIMR 0x0058 +#define REG_HSISR 0x005c +/* RTL8723 WIFI/BT/GPS Multi-Function GPIO Pin Control. */ +#define REG_GPIO_PIN_CTRL_2 0x0060 +/* RTL8723 WIFI/BT/GPS Multi-Function GPIO Select. */ +#define REG_GPIO_IO_SEL_2 0x0062 + +/* RTL8723 only WIFI/BT/GPS Multi-Function control source. */ +#define REG_MULTI_FUNC_CTRL 0x0068 + +#define MULTI_FN_WIFI_HW_PWRDOWN_EN BIT(0) /* Enable GPIO[9] as WiFi HW + powerdown source */ +#define MULTI_FN_WIFI_HW_PWRDOWN_SL BIT(1) /* WiFi HW powerdown polarity + control */ +#define MULTI_WIFI_FUNC_EN BIT(2) /* WiFi function enable */ + +#define MULTI_WIFI_HW_ROF_EN BIT(3) /* Enable GPIO[9] as WiFi RF HW + powerdown source */ +#define MULTI_BT_HW_PWRDOWN_EN BIT(16) /* Enable GPIO[11] as BT HW + powerdown source */ +#define MULTI_BT_HW_PWRDOWN_SL BIT(17) /* BT HW powerdown polarity + control */ +#define MULTI_BT_FUNC_EN BIT(18) /* BT function enable */ +#define MULTI_BT_HW_ROF_EN BIT(19) /* Enable GPIO[11] as BT/GPS + RF HW powerdown source */ +#define MULTI_GPS_HW_PWRDOWN_EN BIT(20) /* Enable GPIO[10] as GPS HW + powerdown source */ +#define MULTI_GPS_HW_PWRDOWN_SL BIT(21) /* GPS HW powerdown polarity + control */ +#define MULTI_GPS_FUNC_EN BIT(22) /* GPS function enable */ + + +#define REG_MCU_FW_DL 0x0080 +#define MCU_FW_DL_ENABLE BIT(0) +#define MCU_FW_DL_READY BIT(1) +#define MCU_FW_DL_CSUM_REPORT BIT(2) +#define MCU_MAC_INIT_READY BIT(3) +#define MCU_BB_INIT_READY BIT(4) +#define MCU_RF_INIT_READY BIT(5) +#define MCU_WINT_INIT_READY BIT(6) +#define MCU_FW_RAM_SEL BIT(7) /* 1: RAM, 0:ROM */ +#define MCU_CP_RESET BIT(23) + +#define REG_HMBOX_EXT_0 0x0088 +#define REG_HMBOX_EXT_1 0x008a +#define REG_HMBOX_EXT_2 0x008c +#define REG_HMBOX_EXT_3 0x008e +/* Host suspend counter on FPGA platform */ +#define REG_HOST_SUSP_CNT 0x00bc +/* Efuse access protection for RTL8723 */ +#define REG_EFUSE_ACCESS 0x00cf +#define REG_BIST_SCAN 0x00d0 +#define REG_BIST_RPT 0x00d4 +#define REG_BIST_ROM_RPT 0x00d8 +#define REG_USB_SIE_INTF 0x00e0 +#define REG_PCIE_MIO_INTF 0x00e4 +#define REG_PCIE_MIO_INTD 0x00e8 +#define REG_HPON_FSM 0x00ec +#define REG_SYS_CFG 0x00f0 +#define SYS_CFG_XCLK_VLD BIT(0) +#define SYS_CFG_ACLK_VLD BIT(1) +#define SYS_CFG_UCLK_VLD BIT(2) +#define SYS_CFG_PCLK_VLD BIT(3) +#define SYS_CFG_PCIRSTB BIT(4) +#define SYS_CFG_V15_VLD BIT(5) +#define SYS_CFG_TRP_B15V_EN BIT(7) +#define SYS_CFG_SIC_IDLE BIT(8) +#define SYS_CFG_BD_MAC2 BIT(9) +#define SYS_CFG_BD_MAC1 BIT(10) +#define SYS_CFG_IC_MACPHY_MODE BIT(11) +#define SYS_CFG_CHIP_VER (BIT(12) | BIT(13) | BIT(14) | BIT(15)) +#define SYS_CFG_BT_FUNC BIT(16) +#define SYS_CFG_VENDOR_ID BIT(19) +#define SYS_CFG_PAD_HWPD_IDN BIT(22) +#define SYS_CFG_TRP_VAUX_EN BIT(23) +#define SYS_CFG_TRP_BT_EN BIT(24) +#define SYS_CFG_BD_PKG_SEL BIT(25) +#define SYS_CFG_BD_HCI_SEL BIT(26) +#define SYS_CFG_TYPE_ID BIT(27) +#define SYS_CFG_RTL_ID BIT(23) /* TestChip ID, + 1:Test(RLE); 0:MP(RL) */ +#define SYS_CFG_SPS_SEL BIT(24) /* 1:LDO regulator mode; + 0:Switching regulator mode*/ +#define SYS_CFG_CHIP_VERSION_MASK 0xf000 /* Bit 12 - 15 */ +#define SYS_CFG_CHIP_VERSION_SHIFT 12 + + +#define REG_GPIO_OUTSTS 0x00f4 /* For RTL8723 only. */ +#define GPIO_EFS_HCI_SEL (BIT(0) | BIT(1)) +#define GPIO_PAD_HCI_SEL (BIT(2) | BIT(3)) +#define GPIO_HCI_SEL (BIT(4) | BIT(5)) +#define GPIO_PKG_SEL_HCI BIT(6) +#define GPIO_FEN_GPS BIT(7) +#define GPIO_FEN_BT BIT(8) +#define GPIO_FEN_WL BIT(9) +#define GPIO_FEN_PCI BIT(10) +#define GPIO_FEN_USB BIT(11) +#define GPIO_BTRF_HWPDN_N BIT(12) +#define GPIO_WLRF_HWPDN_N BIT(13) +#define GPIO_PDN_BT_N BIT(14) +#define GPIO_PDN_GPS_N BIT(15) +#define GPIO_BT_CTL_HWPDN BIT(16) +#define GPIO_GPS_CTL_HWPDN BIT(17) +#define GPIO_PPHY_SUSB BIT(20) +#define GPIO_UPHY_SUSB BIT(21) +#define GPIO_PCI_SUSEN BIT(22) +#define GPIO_USB_SUSEN BIT(23) +#define GPIO_RF_RL_ID (BIT(31) | BIT(30) | BIT(29) | BIT(28)) + +/* 0x0100 ~ 0x01FF MACTOP General Configuration */ +#define REG_CR 0x0100 +#define CR_HCI_TXDMA_ENABLE BIT(0) +#define CR_HCI_RXDMA_ENABLE BIT(1) +#define CR_TXDMA_ENABLE BIT(2) +#define CR_RXDMA_ENABLE BIT(3) +#define CR_PROTOCOL_ENABLE BIT(4) +#define CR_SCHEDULE_ENABLE BIT(5) +#define CR_MAC_TX_ENABLE BIT(6) +#define CR_MAC_RX_ENABLE BIT(7) +#define CR_SW_BEACON_ENABLE BIT(8) +#define CR_SECURITY_ENABLE BIT(9) +#define CR_CALTIMER_ENABLE BIT(10) + +/* Media Status Register */ +#define REG_MSR 0x0102 +#define MSR_LINKTYPE_MASK 0x3 +#define MSR_LINKTYPE_NONE 0x0 +#define MSR_LINKTYPE_ADHOC 0x1 +#define MSR_LINKTYPE_STATION 0x2 +#define MSR_LINKTYPE_AP 0x3 + +#define REG_PBP 0x0104 +#define PBP_PAGE_SIZE_RX_SHIFT 0 +#define PBP_PAGE_SIZE_TX_SHIFT 4 +#define PBP_PAGE_SIZE_64 0x0 +#define PBP_PAGE_SIZE_128 0x1 +#define PBP_PAGE_SIZE_256 0x2 +#define PBP_PAGE_SIZE_512 0x3 +#define PBP_PAGE_SIZE_1024 0x4 + +#define REG_TRXDMA_CTRL 0x010c +#define TRXDMA_CTRL_VOQ_SHIFT 4 +#define TRXDMA_CTRL_VIQ_SHIFT 6 +#define TRXDMA_CTRL_BEQ_SHIFT 8 +#define TRXDMA_CTRL_BKQ_SHIFT 10 +#define TRXDMA_CTRL_MGQ_SHIFT 12 +#define TRXDMA_CTRL_HIQ_SHIFT 14 +#define TRXDMA_QUEUE_LOW 1 +#define TRXDMA_QUEUE_NORMAL 2 +#define TRXDMA_QUEUE_HIGH 3 + + +#define REG_TRXFF_BNDY 0x0114 +#define REG_TRXFF_STATUS 0x0118 +#define REG_RXFF_PTR 0x011c +#define REG_HIMR 0x0120 +#define REG_HISR 0x0124 +#define REG_HIMRE 0x0128 +#define REG_HISRE 0x012c +#define REG_CPWM 0x012f +#define REG_FWIMR 0x0130 +#define REG_FWISR 0x0134 +#define REG_PKTBUF_DBG_CTRL 0x0140 +#define REG_PKTBUF_DBG_DATA_L 0x0144 +#define REG_PKTBUF_DBG_DATA_H 0x0148 + +#define REG_TC0_CTRL 0x0150 +#define REG_TC1_CTRL 0x0154 +#define REG_TC2_CTRL 0x0158 +#define REG_TC3_CTRL 0x015c +#define REG_TC4_CTRL 0x0160 +#define REG_TCUNIT_BASE 0x0164 +#define REG_MBIST_START 0x0174 +#define REG_MBIST_DONE 0x0178 +#define REG_MBIST_FAIL 0x017c +#define REG_C2HEVT_MSG_NORMAL 0x01a0 +#define REG_C2HEVT_CLEAR 0x01af +#define REG_C2HEVT_MSG_TEST 0x01b8 +#define REG_MCUTST_1 0x01c0 +#define REG_FMTHR 0x01c8 +#define REG_HMTFR 0x01cc +#define REG_HMBOX_0 0x01d0 +#define REG_HMBOX_1 0x01d4 +#define REG_HMBOX_2 0x01d8 +#define REG_HMBOX_3 0x01dc + +#define REG_LLT_INIT 0x01e0 +#define LLT_OP_INACTIVE 0x0 +#define LLT_OP_WRITE (0x1 << 30) +#define LLT_OP_READ (0x2 << 30) +#define LLT_OP_MASK (0x3 << 30) + +#define REG_BB_ACCEESS_CTRL 0x01e8 +#define REG_BB_ACCESS_DATA 0x01ec + +/* 0x0200 ~ 0x027F TXDMA Configuration */ +#define REG_RQPN 0x0200 +#define RQPN_HI_PQ_SHIFT 0 +#define RQPN_LO_PQ_SHIFT 8 +#define RQPN_NORM_PQ_SHIFT 16 +#define RQPN_LOAD BIT(31) + +#define REG_FIFOPAGE 0x0204 +#define REG_TDECTRL 0x0208 +#define REG_TXDMA_OFFSET_CHK 0x020c +#define REG_TXDMA_STATUS 0x0210 +#define REG_RQPN_NPQ 0x0214 + +/* 0x0280 ~ 0x02FF RXDMA Configuration */ +#define REG_RXDMA_AGG_PG_TH 0x0280 +#define REG_RXPKT_NUM 0x0284 +#define REG_RXDMA_STATUS 0x0288 + +#define REG_RF_BB_CMD_ADDR 0x02c0 +#define REG_RF_BB_CMD_DATA 0x02c4 + +/* spec version 11 */ +/* 0x0400 ~ 0x047F Protocol Configuration */ +#define REG_VOQ_INFORMATION 0x0400 +#define REG_VIQ_INFORMATION 0x0404 +#define REG_BEQ_INFORMATION 0x0408 +#define REG_BKQ_INFORMATION 0x040c +#define REG_MGQ_INFORMATION 0x0410 +#define REG_HGQ_INFORMATION 0x0414 +#define REG_BCNQ_INFORMATION 0x0418 + + +#define REG_CPU_MGQ_INFORMATION 0x041c +#define REG_FWHW_TXQ_CTRL 0x0420 +#define FWHW_TXQ_CTRL_AMPDU_RETRY BIT(7) +#define FWHW_TXQ_CTRL_XMIT_MGMT_ACK BIT(12) + +#define REG_HWSEQ_CTRL 0x0423 +#define REG_TXPKTBUF_BCNQ_BDNY 0x0424 +#define REG_TXPKTBUF_MGQ_BDNY 0x0425 +#define REG_LIFETIME_EN 0x0426 +#define REG_MULTI_BCNQ_OFFSET 0x0427 + +#define REG_SPEC_SIFS 0x0428 +#define SPEC_SIFS_CCK_MASK 0x00ff +#define SPEC_SIFS_CCK_SHIFT 0 +#define SPEC_SIFS_OFDM_MASK 0xff00 +#define SPEC_SIFS_OFDM_SHIFT 8 + +#define REG_RETRY_LIMIT 0x042a +#define RETRY_LIMIT_LONG_SHIFT 0 +#define RETRY_LIMIT_LONG_MASK 0x003f +#define RETRY_LIMIT_SHORT_SHIFT 8 +#define RETRY_LIMIT_SHORT_MASK 0x3f00 + +#define REG_DARFRC 0x0430 +#define REG_RARFRC 0x0438 +#define REG_RESPONSE_RATE_SET 0x0440 +#define RESPONSE_RATE_BITMAP_ALL 0xfffff +#define RESPONSE_RATE_RRSR_CCK_ONLY_1M 0xffff1 +#define RSR_1M BIT(0) +#define RSR_2M BIT(1) +#define RSR_5_5M BIT(2) +#define RSR_11M BIT(3) +#define RSR_6M BIT(4) +#define RSR_9M BIT(5) +#define RSR_12M BIT(6) +#define RSR_18M BIT(7) +#define RSR_24M BIT(8) +#define RSR_36M BIT(9) +#define RSR_48M BIT(10) +#define RSR_54M BIT(11) +#define RSR_MCS0 BIT(12) +#define RSR_MCS1 BIT(13) +#define RSR_MCS2 BIT(14) +#define RSR_MCS3 BIT(15) +#define RSR_MCS4 BIT(16) +#define RSR_MCS5 BIT(17) +#define RSR_MCS6 BIT(18) +#define RSR_MCS7 BIT(19) +#define RSR_RSC_LOWER_SUB_CHANNEL BIT(21) /* 0x200000 */ +#define RSR_RSC_UPPER_SUB_CHANNEL BIT(22) /* 0x400000 */ +#define RSR_RSC_BANDWIDTH_40M (RSR_RSC_UPPER_SUB_CHANNEL | \ + RSR_RSC_LOWER_SUB_CHANNEL) +#define RSR_ACK_SHORT_PREAMBLE BIT(23) + +#define REG_ARFR0 0x0444 +#define REG_ARFR1 0x0448 +#define REG_ARFR2 0x044c +#define REG_ARFR3 0x0450 +#define REG_AGGLEN_LMT 0x0458 +#define REG_AMPDU_MIN_SPACE 0x045c +#define REG_TXPKTBUF_WMAC_LBK_BF_HD 0x045d +#define REG_FAST_EDCA_CTRL 0x0460 +#define REG_RD_RESP_PKT_TH 0x0463 +#define REG_INIRTS_RATE_SEL 0x0480 +#define REG_INIDATA_RATE_SEL 0x0484 + + +#define REG_POWER_STATUS 0x04a4 +#define REG_POWER_STAGE1 0x04b4 +#define REG_POWER_STAGE2 0x04b8 +#define REG_PKT_VO_VI_LIFE_TIME 0x04c0 +#define REG_PKT_BE_BK_LIFE_TIME 0x04c2 +#define REG_STBC_SETTING 0x04c4 +#define REG_PROT_MODE_CTRL 0x04c8 +#define REG_MAX_AGGR_NUM 0x04ca +#define REG_RTS_MAX_AGGR_NUM 0x04cb +#define REG_BAR_MODE_CTRL 0x04cc +#define REG_RA_TRY_RATE_AGG_LMT 0x04cf +#define REG_NQOS_SEQ 0x04dc +#define REG_QOS_SEQ 0x04de +#define REG_NEED_CPU_HANDLE 0x04e0 +#define REG_PKT_LOSE_RPT 0x04e1 +#define REG_PTCL_ERR_STATUS 0x04e2 +#define REG_DUMMY 0x04fc + + +/* 0x0500 ~ 0x05FF EDCA Configuration */ +#define REG_EDCA_VO_PARAM 0x0500 +#define REG_EDCA_VI_PARAM 0x0504 +#define REG_EDCA_BE_PARAM 0x0508 +#define REG_EDCA_BK_PARAM 0x050c +#define EDCA_PARAM_ECW_MIN_SHIFT 8 +#define EDCA_PARAM_ECW_MAX_SHIFT 12 +#define EDCA_PARAM_TXOP_SHIFT 16 +#define REG_BEACON_TCFG 0x0510 +#define REG_PIFS 0x0512 +#define REG_RDG_PIFS 0x0513 +#define REG_SIFS_CCK 0x0514 +#define REG_SIFS_OFDM 0x0516 +#define REG_TSFTR_SYN_OFFSET 0x0518 +#define REG_AGGR_BREAK_TIME 0x051a +#define REG_SLOT 0x051b +#define REG_TX_PTCL_CTRL 0x0520 +#define REG_TXPAUSE 0x0522 +#define REG_DIS_TXREQ_CLR 0x0523 +#define REG_RD_CTRL 0x0524 +#define REG_TBTT_PROHIBIT 0x0540 +#define REG_RD_NAV_NXT 0x0544 +#define REG_NAV_PROT_LEN 0x0546 + +#define REG_BEACON_CTRL 0x0550 +#define REG_BEACON_CTRL_1 0x0551 +#define BEACON_ATIM BIT(0) +#define BEACON_CTRL_MBSSID BIT(1) +#define BEACON_CTRL_TX_BEACON_RPT BIT(2) +#define BEACON_FUNCTION_ENABLE BIT(3) +#define BEACON_DISABLE_TSF_UPDATE BIT(4) + +#define REG_MBID_NUM 0x0552 +#define REG_DUAL_TSF_RST 0x0553 + /* The same as REG_MBSSID_BCN_SPACE */ +#define REG_BCN_INTERVAL 0x0554 +#define REG_MBSSID_BCN_SPACE 0x0554 + +#define REG_DRIVER_EARLY_INT 0x0558 +#define DRIVER_EARLY_INT_TIME 5 + +#define REG_BEACON_DMA_TIME 0x0559 +#define BEACON_DMA_ATIME_INT_TIME 2 + +#define REG_ATIMWND 0x055a +#define REG_BCN_MAX_ERR 0x055d +#define REG_RXTSF_OFFSET_CCK 0x055e +#define REG_RXTSF_OFFSET_OFDM 0x055f +#define REG_TSFTR 0x0560 +#define REG_TSFTR1 0x0568 +#define REG_INIT_TSFTR 0x0564 +#define REG_ATIMWND_1 0x0570 +#define REG_PSTIMER 0x0580 +#define REG_TIMER0 0x0584 +#define REG_TIMER1 0x0588 +#define REG_ACM_HW_CTRL 0x05c0 +#define ACM_HW_CTRL_BK BIT(0) +#define ACM_HW_CTRL_BE BIT(1) +#define ACM_HW_CTRL_VI BIT(2) +#define ACM_HW_CTRL_VO BIT(3) +#define REG_ACM_RST_CTRL 0x05c1 +#define REG_ACMAVG 0x05c2 +#define REG_VO_ADMTIME 0x05c4 +#define REG_VI_ADMTIME 0x05c6 +#define REG_BE_ADMTIME 0x05c8 +#define REG_EDCA_RANDOM_GEN 0x05cc +#define REG_SCH_TXCMD 0x05d0 + +/* define REG_FW_TSF_SYNC_CNT 0x04a0 */ +#define REG_FW_RESET_TSF_CNT_1 0x05fc +#define REG_FW_RESET_TSF_CNT_0 0x05fd +#define REG_FW_BCN_DIS_CNT 0x05fe + +/* 0x0600 ~ 0x07FF WMAC Configuration */ +#define REG_APSD_CTRL 0x0600 +#define REG_BW_OPMODE 0x0603 +#define BW_OPMODE_20MHZ BIT(2) +#define BW_OPMODE_5G BIT(1) +#define BW_OPMODE_11J BIT(0) + +#define REG_TCR 0x0604 + +/* Receive Configuration Register */ +#define REG_RCR 0x0608 +#define RCR_ACCEPT_AP BIT(0) /* Accept all unicast packet */ +#define RCR_ACCEPT_PHYS_MATCH BIT(1) /* Accept phys match packet */ +#define RCR_ACCEPT_MCAST BIT(2) +#define RCR_ACCEPT_BCAST BIT(3) +#define RCR_ACCEPT_ADDR3 BIT(4) /* Accept address 3 match + packet */ +#define RCR_ACCEPT_PM BIT(5) /* Accept power management + packet */ +#define RCR_CHECK_BSSID_MATCH BIT(6) /* Accept BSSID match packet */ +#define RCR_CHECK_BSSID_BEACON BIT(7) /* Accept BSSID match packet + (Rx beacon, probe rsp) */ +#define RCR_ACCEPT_CRC32 BIT(8) /* Accept CRC32 error packet */ +#define RCR_ACCEPT_ICV BIT(9) /* Accept ICV error packet */ +#define RCR_ACCEPT_DATA_FRAME BIT(11) +#define RCR_ACCEPT_CTRL_FRAME BIT(12) +#define RCR_ACCEPT_MGMT_FRAME BIT(13) +#define RCR_HTC_LOC_CTRL BIT(14) /* MFC<--HTC=1 MFC-->HTC=0 */ +#define RCR_MFBEN BIT(22) +#define RCR_LSIGEN BIT(23) +#define RCR_MULTI_BSSID_ENABLE BIT(24) /* Enable Multiple BssId */ +#define RCR_ACCEPT_BA_SSN BIT(27) /* Accept BA SSN */ +#define RCR_APPEND_PHYSTAT BIT(28) +#define RCR_APPEND_ICV BIT(29) +#define RCR_APPEND_MIC BIT(30) +#define RCR_APPEND_FCS BIT(31) /* WMAC append FCS after */ + +#define REG_RX_PKT_LIMIT 0x060c +#define REG_RX_DLK_TIME 0x060d +#define REG_RX_DRVINFO_SZ 0x060f + +#define REG_MACID 0x0610 +#define REG_BSSID 0x0618 +#define REG_MAR 0x0620 +#define REG_MBIDCAMCFG 0x0628 + +#define REG_USTIME_EDCA 0x0638 +#define REG_MAC_SPEC_SIFS 0x063a + +/* 20100719 Joseph: Hardware register definition change. (HW datasheet v54) */ + /* [15:8]SIFS_R2T_OFDM, [7:0]SIFS_R2T_CCK */ +#define REG_R2T_SIFS 0x063c + /* [15:8]SIFS_T2T_OFDM, [7:0]SIFS_T2T_CCK */ +#define REG_T2T_SIFS 0x063e +#define REG_ACKTO 0x0640 +#define REG_CTS2TO 0x0641 +#define REG_EIFS 0x0642 + +/* WMA, BA, CCX */ +#define REG_NAV_CTRL 0x0650 +/* In units of 128us */ +#define REG_NAV_UPPER 0x0652 +#define NAV_UPPER_UNIT 128 + +#define REG_BACAMCMD 0x0654 +#define REG_BACAMCONTENT 0x0658 +#define REG_LBDLY 0x0660 +#define REG_FWDLY 0x0661 +#define REG_RXERR_RPT 0x0664 +#define REG_WMAC_TRXPTCL_CTL 0x0668 + + +/* Security */ +#define REG_CAM_CMD 0x0670 +#define CAM_CMD_POLLING BIT(31) +#define CAM_CMD_WRITE BIT(16) +#define CAM_CMD_KEY_SHIFT 3 +#define REG_CAM_WRITE 0x0674 +#define CAM_WRITE_VALID BIT(15) +#define REG_CAM_READ 0x0678 +#define REG_CAM_DEBUG 0x067c +#define REG_SECURITY_CFG 0x0680 +#define SEC_CFG_TX_USE_DEFKEY BIT(0) +#define SEC_CFG_RX_USE_DEFKEY BIT(1) +#define SEC_CFG_TX_SEC_ENABLE BIT(2) +#define SEC_CFG_RX_SEC_ENABLE BIT(3) +#define SEC_CFG_SKByA2 BIT(4) +#define SEC_CFG_NO_SKMC BIT(5) +#define SEC_CFG_TXBC_USE_DEFKEY BIT(6) +#define SEC_CFG_RXBC_USE_DEFKEY BIT(7) + +/* Power */ +#define REG_WOW_CTRL 0x0690 +#define REG_PSSTATUS 0x0691 +#define REG_PS_RX_INFO 0x0692 +#define REG_LPNAV_CTRL 0x0694 +#define REG_WKFMCAM_CMD 0x0698 +#define REG_WKFMCAM_RWD 0x069c +#define REG_RXFLTMAP0 0x06a0 +#define REG_RXFLTMAP1 0x06a2 +#define REG_RXFLTMAP2 0x06a4 +#define REG_BCN_PSR_RPT 0x06a8 +#define REG_CALB32K_CTRL 0x06ac +#define REG_PKT_MON_CTRL 0x06b4 +#define REG_BT_COEX_TABLE 0x06c0 +#define REG_WMAC_RESP_TXINFO 0x06d8 + +#define REG_MACID1 0x0700 +#define REG_BSSID1 0x0708 + +#define REG_FPGA0_RF_MODE 0x0800 +#define FPGA_RF_MODE BIT(0) +#define FPGA_RF_MODE_JAPAN BIT(1) +#define FPGA_RF_MODE_CCK BIT(24) +#define FPGA_RF_MODE_OFDM BIT(25) + +#define REG_FPGA0_TXINFO 0x0804 +#define REG_FPGA0_PSD_FUNC 0x0808 +#define REG_FPGA0_TX_GAIN 0x080c +#define REG_FPGA0_POWER_SAVE 0x0818 +#define FPGA0_PS_LOWER_CHANNEL BIT(26) +#define FPGA0_PS_UPPER_CHANNEL BIT(27) + +#define REG_FPGA0_XA_HSSI_PARM1 0x0820 /* RF 3 wire register */ +#define FPGA0_HSSI_PARM1_PI BIT(8) +#define REG_FPGA0_XA_HSSI_PARM2 0x0824 +#define REG_FPGA0_XB_HSSI_PARM1 0x0828 +#define REG_FPGA0_XB_HSSI_PARM2 0x082c +#define FPGA0_HSSI_3WIRE_DATA_LEN 0x800 +#define FPGA0_HSSI_3WIRE_ADDR_LEN 0x400 +#define FPGA0_HSSI_PARM2_ADDR_SHIFT 23 +#define FPGA0_HSSI_PARM2_ADDR_MASK 0x7f800000 /* 0xff << 23 */ +#define FPGA0_HSSI_PARM2_CCK_HIGH_PWR BIT(9) +#define FPGA0_HSSI_PARM2_EDGE_READ BIT(31) + +#define REG_TX_AGC_B_RATE18_06 0x0830 +#define REG_TX_AGC_B_RATE54_24 0x0834 +#define REG_TX_AGC_B_CCK1_55_MCS32 0x0838 +#define REG_TX_AGC_B_MCS03_MCS00 0x083c + +#define REG_FPGA0_XA_LSSI_PARM 0x0840 +#define REG_FPGA0_XB_LSSI_PARM 0x0844 +#define FPGA0_LSSI_PARM_ADDR_SHIFT 20 +#define FPGA0_LSSI_PARM_ADDR_MASK 0x0ff00000 +#define FPGA0_LSSI_PARM_DATA_MASK 0x000fffff + +#define REG_TX_AGC_B_MCS07_MCS04 0x0848 +#define REG_TX_AGC_B_MCS11_MCS08 0x084c + +#define REG_FPGA0_XCD_SWITCH_CTRL 0x085c + +#define REG_FPGA0_XA_RF_INT_OE 0x0860 /* RF Channel switch */ +#define REG_FPGA0_XB_RF_INT_OE 0x0864 +#define FPGA0_INT_OE_ANTENNA_AB_OPEN 0x000 +#define FPGA0_INT_OE_ANTENNA_A 0x100 +#define FPGA0_INT_OE_ANTENNA_B 0x200 +#define FPGA0_INT_OE_ANTENNA_MASK 0x300 + +#define REG_TX_AGC_B_MCS15_MCS12 0x0868 +#define REG_TX_AGC_B_CCK11_A_CCK2_11 0x086c + +#define REG_FPGA0_XAB_RF_SW_CTRL 0x0870 +#define REG_FPGA0_XA_RF_SW_CTRL 0x0870 /* 16 bit */ +#define REG_FPGA0_XB_RF_SW_CTRL 0x0872 /* 16 bit */ +#define REG_FPGA0_XCD_RF_SW_CTRL 0x0874 +#define REG_FPGA0_XC_RF_SW_CTRL 0x0874 /* 16 bit */ +#define REG_FPGA0_XD_RF_SW_CTRL 0x0876 /* 16 bit */ +#define FPGA0_RF_3WIRE_DATA 0x1 +#define FPGA0_RF_3WIRE_CLOC 0x2 +#define FPGA0_RF_3WIRE_LOAD 0x4 +#define FPGA0_RF_3WIRE_RW 0x8 +#define FPGA0_RF_3WIRE_MASK 0xf +#define FPGA0_RF_RFENV 0x10 +#define FPGA0_RF_TRSW 0x20 /* Useless now */ +#define FPGA0_RF_TRSWB 0x40 +#define FPGA0_RF_ANTSW 0x100 +#define FPGA0_RF_ANTSWB 0x200 +#define FPGA0_RF_PAPE 0x400 +#define FPGA0_RF_PAPE5G 0x800 + +#define REG_FPGA0_XAB_RF_PARM 0x0878 /* Antenna select path in ODM */ +#define REG_FPGA0_XA_RF_PARM 0x0878 /* 16 bit */ +#define REG_FPGA0_XB_RF_PARM 0x087a /* 16 bit */ +#define REG_FPGA0_XCD_RF_PARM 0x087c +#define REG_FPGA0_XC_RF_PARM 0x087c /* 16 bit */ +#define REG_FPGA0_XD_RF_PARM 0x087e /* 16 bit */ + +#define REG_FPGA0_ANALOG1 0x0880 +#define REG_FPGA0_ANALOG2 0x0884 +#define REG_FPGA0_ANALOG3 0x0888 +#define REG_FPGA0_ANALOG4 0x088c + +#define REG_FPGA0_XA_LSSI_READBACK 0x08a0 /* Tranceiver LSSI Readback */ +#define REG_FPGA0_XB_LSSI_READBACK 0x08a4 +#define REG_HSPI_XA_READBACK 0x08b8 /* Transceiver A HSPI read */ +#define REG_HSPI_XB_READBACK 0x08bc /* Transceiver B HSPI read */ + +#define REG_FPGA1_RF_MODE 0x0900 + +#define REG_CCK0_SYSTEM 0x0a00 +#define CCK0_SIDEBAND BIT(4) + +#define REG_CONFIG_ANT_A 0x0b68 +#define REG_CONFIG_ANT_B 0x0b6c + +#define REG_OFDM0_TRX_PATH_ENABLE 0x0c04 +#define OFDM0_RF_PATH_RX_MASK 0x0f + +#define REG_OFDM0_TR_MUX_PAR 0x0c08 + +#define REG_OFDM0_XA_RX_IQ_IMBALANCE 0x0c14 +#define REG_OFDM0_XB_RX_IQ_IMBALANCE 0x0c1c + +#define REG_OFDM0_ENERGY_CCA_THRES 0x0c4c + +#define REG_OFDM0_XA_AGC_CORE1 0x0c50 +#define REG_OFDM0_XA_AGC_CORE2 0x0c54 +#define REG_OFDM0_XB_AGC_CORE1 0x0c58 +#define REG_OFDM0_XB_AGC_CORE2 0x0c5c +#define REG_OFDM0_XC_AGC_CORE1 0x0c60 +#define REG_OFDM0_XC_AGC_CORE2 0x0c64 +#define REG_OFDM0_XD_AGC_CORE1 0x0c68 +#define REG_OFDM0_XD_AGC_CORE2 0x0c6c +#define OFDM0_X_AGC_CORE1_IGI_MASK 0x0000007F + +#define REG_OFDM0_AGCR_SSI_TABLE 0x0c78 + +#define REG_OFDM0_XA_TX_IQ_IMBALANCE 0x0c80 +#define REG_OFDM0_XB_TX_IQ_IMBALANCE 0x0c88 +#define REG_OFDM0_XC_TX_IQ_IMBALANCE 0x0c90 +#define REG_OFDM0_XD_TX_IQ_IMBALANCE 0x0c98 + +#define REG_OFDM0_XC_TX_AFE 0x0c94 +#define REG_OFDM0_XD_TX_AFE 0x0c9c + +#define REG_OFDM0_RX_IQ_EXT_ANTA 0x0ca0 + +#define REG_OFDM1_LSTF 0x0d00 +#define OFDM_CONTINUE_TX 0x10000000 +#define OFDM_SINGLE_CARRIER 0x20000000 +#define OFDM_SINGLE_TONE 0x40000000 +#define OFDM_LSTF_MASK 0x70000000 + +#define REG_OFDM1_TRX_PATH_ENABLE 0x0d04 + +#define REG_TX_AGC_A_RATE18_06 0x0e00 +#define REG_TX_AGC_A_RATE54_24 0x0e04 +#define REG_TX_AGC_A_CCK1_MCS32 0x0e08 +#define REG_TX_AGC_A_MCS03_MCS00 0x0e10 +#define REG_TX_AGC_A_MCS07_MCS04 0x0e14 +#define REG_TX_AGC_A_MCS11_MCS08 0x0e18 +#define REG_TX_AGC_A_MCS15_MCS12 0x0e1c + +#define REG_FPGA0_IQK 0x0e28 + +#define REG_TX_IQK_TONE_A 0x0e30 +#define REG_RX_IQK_TONE_A 0x0e34 +#define REG_TX_IQK_PI_A 0x0e38 +#define REG_RX_IQK_PI_A 0x0e3c + +#define REG_TX_IQK 0x0e40 +#define REG_RX_IQK 0x0e44 +#define REG_IQK_AGC_PTS 0x0e48 +#define REG_IQK_AGC_RSP 0x0e4c +#define REG_TX_IQK_TONE_B 0x0e50 +#define REG_RX_IQK_TONE_B 0x0e54 +#define REG_TX_IQK_PI_B 0x0e58 +#define REG_RX_IQK_PI_B 0x0e5c +#define REG_IQK_AGC_CONT 0x0e60 + +#define REG_BLUETOOTH 0x0e6c +#define REG_RX_WAIT_CCA 0x0e70 +#define REG_TX_CCK_RFON 0x0e74 +#define REG_TX_CCK_BBON 0x0e78 +#define REG_TX_OFDM_RFON 0x0e7c +#define REG_TX_OFDM_BBON 0x0e80 +#define REG_TX_TO_RX 0x0e84 +#define REG_TX_TO_TX 0x0e88 +#define REG_RX_CCK 0x0e8c + +#define REG_TX_POWER_BEFORE_IQK_A 0x0e94 +#define REG_TX_POWER_AFTER_IQK_A 0x0e9c + +#define REG_RX_POWER_BEFORE_IQK_A 0x0ea0 +#define REG_RX_POWER_BEFORE_IQK_A_2 0x0ea4 +#define REG_RX_POWER_AFTER_IQK_A 0x0ea8 +#define REG_RX_POWER_AFTER_IQK_A_2 0x0eac + +#define REG_TX_POWER_BEFORE_IQK_B 0x0eb4 +#define REG_TX_POWER_AFTER_IQK_B 0x0ebc + +#define REG_RX_POWER_BEFORE_IQK_B 0x0ec0 +#define REG_RX_POWER_BEFORE_IQK_B_2 0x0ec4 +#define REG_RX_POWER_AFTER_IQK_B 0x0ec8 +#define REG_RX_POWER_AFTER_IQK_B_2 0x0ecc + +#define REG_RX_OFDM 0x0ed0 +#define REG_RX_WAIT_RIFS 0x0ed4 +#define REG_RX_TO_RX 0x0ed8 +#define REG_STANDBY 0x0edc +#define REG_SLEEP 0x0ee0 +#define REG_PMPD_ANAEN 0x0eec + +#define REG_8723A_FW_START_ADDRESS 0x1000 + +#define REG_USB_INFO 0xfe17 +#define REG_USB_HIMR 0xfe38 +#define USB_HIMR_TIMEOUT2 BIT(31) +#define USB_HIMR_TIMEOUT1 BIT(30) +#define USB_HIMR_PSTIMEOUT BIT(29) +#define USB_HIMR_GTINT4 BIT(28) +#define USB_HIMR_GTINT3 BIT(27) +#define USB_HIMR_TXBCNERR BIT(26) +#define USB_HIMR_TXBCNOK BIT(25) +#define USB_HIMR_TSF_BIT32_TOGGLE BIT(24) +#define USB_HIMR_BCNDMAINT3 BIT(23) +#define USB_HIMR_BCNDMAINT2 BIT(22) +#define USB_HIMR_BCNDMAINT1 BIT(21) +#define USB_HIMR_BCNDMAINT0 BIT(20) +#define USB_HIMR_BCNDOK3 BIT(19) +#define USB_HIMR_BCNDOK2 BIT(18) +#define USB_HIMR_BCNDOK1 BIT(17) +#define USB_HIMR_BCNDOK0 BIT(16) +#define USB_HIMR_HSISR_IND BIT(15) +#define USB_HIMR_BCNDMAINT_E BIT(14) +/* RSVD BIT(13) */ +#define USB_HIMR_CTW_END BIT(12) +/* RSVD BIT(11) */ +#define USB_HIMR_C2HCMD BIT(10) +#define USB_HIMR_CPWM2 BIT(9) +#define USB_HIMR_CPWM BIT(8) +#define USB_HIMR_HIGHDOK BIT(7) /* High Queue DMA OK + Interrupt */ +#define USB_HIMR_MGNTDOK BIT(6) /* Management Queue DMA OK + Interrupt */ +#define USB_HIMR_BKDOK BIT(5) /* AC_BK DMA OK Interrupt */ +#define USB_HIMR_BEDOK BIT(4) /* AC_BE DMA OK Interrupt */ +#define USB_HIMR_VIDOK BIT(3) /* AC_VI DMA OK Interrupt */ +#define USB_HIMR_VODOK BIT(2) /* AC_VO DMA Interrupt */ +#define USB_HIMR_RDU BIT(1) /* Receive Descriptor + Unavailable */ +#define USB_HIMR_ROK BIT(0) /* Receive DMA OK Interrupt */ + +#define REG_USB_SPECIAL_OPTION 0xfe55 +#define REG_USB_DMA_AGG_TO 0xfe5b +#define REG_USB_AGG_TO 0xfe5c +#define REG_USB_AGG_TH 0xfe5d + +#define REG_NORMAL_SIE_VID 0xfe60 /* 0xfe60 - 0xfe61 */ +#define REG_NORMAL_SIE_PID 0xfe62 /* 0xfe62 - 0xfe63 */ +#define REG_NORMAL_SIE_OPTIONAL 0xfe64 +#define REG_NORMAL_SIE_EP 0xfe65 /* 0xfe65 - 0xfe67 */ +#define REG_NORMAL_SIE_EP_TX 0xfe66 +#define NORMAL_SIE_EP_TX_HIGH_MASK 0x000f +#define NORMAL_SIE_EP_TX_NORMAL_MASK 0x00f0 +#define NORMAL_SIE_EP_TX_LOW_MASK 0x0f00 + +#define REG_NORMAL_SIE_PHY 0xfe68 /* 0xfe68 - 0xfe6b */ +#define REG_NORMAL_SIE_OPTIONAL2 0xfe6c +#define REG_NORMAL_SIE_GPS_EP 0xfe6d /* RTL8723 only */ +#define REG_NORMAL_SIE_MAC_ADDR 0xfe70 /* 0xfe70 - 0xfe75 */ +#define REG_NORMAL_SIE_STRING 0xfe80 /* 0xfe80 - 0xfedf */ + +/* RF6052 registers */ +#define RF6052_REG_AC 0x00 +#define RF6052_REG_IQADJ_G1 0x01 +#define RF6052_REG_IQADJ_G2 0x02 +#define RF6052_REG_BS_PA_APSET_G1_G4 0x03 +#define RF6052_REG_BS_PA_APSET_G5_G8 0x04 +#define RF6052_REG_POW_TRSW 0x05 +#define RF6052_REG_GAIN_RX 0x06 +#define RF6052_REG_GAIN_TX 0x07 +#define RF6052_REG_TXM_IDAC 0x08 +#define RF6052_REG_IPA_G 0x09 +#define RF6052_REG_TXBIAS_G 0x0a +#define RF6052_REG_TXPA_AG 0x0b +#define RF6052_REG_IPA_A 0x0c +#define RF6052_REG_TXBIAS_A 0x0d +#define RF6052_REG_BS_PA_APSET_G9_G11 0x0e +#define RF6052_REG_BS_IQGEN 0x0f +#define RF6052_REG_MODE1 0x10 +#define RF6052_REG_MODE2 0x11 +#define RF6052_REG_RX_AGC_HP 0x12 +#define RF6052_REG_TX_AGC 0x13 +#define RF6052_REG_BIAS 0x14 +#define RF6052_REG_IPA 0x15 +#define RF6052_REG_TXBIAS 0x16 +#define RF6052_REG_POW_ABILITY 0x17 +#define RF6052_REG_MODE_AG 0x18 /* RF channel and BW switch */ +#define MODE_AG_CHANNEL_MASK 0x3ff +#define MODE_AG_CHANNEL_20MHZ BIT(10) + +#define RF6052_REG_TOP 0x19 +#define RF6052_REG_RX_G1 0x1a +#define RF6052_REG_RX_G2 0x1b +#define RF6052_REG_RX_BB2 0x1c +#define RF6052_REG_RX_BB1 0x1d +#define RF6052_REG_RCK1 0x1e +#define RF6052_REG_RCK2 0x1f +#define RF6052_REG_TX_G1 0x20 +#define RF6052_REG_TX_G2 0x21 +#define RF6052_REG_TX_G3 0x22 +#define RF6052_REG_TX_BB1 0x23 +#define RF6052_REG_T_METER 0x24 +#define RF6052_REG_SYN_G1 0x25 /* RF TX Power control */ +#define RF6052_REG_SYN_G2 0x26 /* RF TX Power control */ +#define RF6052_REG_SYN_G3 0x27 /* RF TX Power control */ +#define RF6052_REG_SYN_G4 0x28 /* RF TX Power control */ +#define RF6052_REG_SYN_G5 0x29 /* RF TX Power control */ +#define RF6052_REG_SYN_G6 0x2a /* RF TX Power control */ +#define RF6052_REG_SYN_G7 0x2b /* RF TX Power control */ +#define RF6052_REG_SYN_G8 0x2c /* RF TX Power control */ + +#define RF6052_REG_RCK_OS 0x30 /* RF TX PA control */ + +#define RF6052_REG_TXPA_G1 0x31 /* RF TX PA control */ +#define RF6052_REG_TXPA_G2 0x32 /* RF TX PA control */ +#define RF6052_REG_TXPA_G3 0x33 /* RF TX PA control */ -- 2.1.0 ^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-03-09 17:00 ` [PATCH 1/1] " Jes.Sorensen @ 2015-03-09 17:46 ` Johannes Berg 2015-03-09 18:35 ` Jes Sorensen 2015-03-09 18:20 ` Joe Perches 1 sibling, 1 reply; 35+ messages in thread From: Johannes Berg @ 2015-03-09 17:46 UTC (permalink / raw) To: Jes.Sorensen; +Cc: linux-wireless, Larry.Finger Hi Jes, > Many thanks to Johannes Berg for 802.11 insights and help and Larry > Finger for help with the vendor driver. :-) Just a few comments since this is really the first time I'm looking closely at the code. > + h2c.ramask.cmd = H2C_SET_RATE_MASK; > + put_unaligned_le16(ramask & 0xffff, &h2c.ramask.mask_lo); > + put_unaligned_le16(ramask >> 16, &h2c.ramask.mask_hi); you marked that __packed, so the put_unaligned_le16() isn't really needed, you can use regular assignments (= cpu_to_le16(...)) > +static void > +rtl8xxxu_bss_info_changed(struct ieee80211_hw *hw, struct ieee80211_vif *vif, > + struct ieee80211_bss_conf *bss_conf, u32 changed) > +{ > + struct rtl8xxxu_priv *priv = hw->priv; > + struct device *dev = &priv->udev->dev; > + struct ieee80211_sta *sta; > + u32 val32; > +#if 0 > + u16 val16; > +#endif > + u8 val8; > + > + if (changed & BSS_CHANGED_ASSOC) { > + struct h2c_cmd h2c; > + > + memset(&h2c, 0, sizeof(struct h2c_cmd)); > + rtl8xxxu_set_linktype(priv, vif->type); > + > + if (bss_conf->assoc) { > + rcu_read_lock(); > + sta = ieee80211_find_sta(vif, bss_conf->bssid); > + if (!sta) { > + dev_info(dev, "%s: ASSOC no sta found\n", > + __func__); > + rcu_read_unlock(); > + goto error; > + } > + > + if (sta->ht_cap.ht_supported) > + dev_info(dev, "%s: HT supported\n", __func__); > + if (sta->vht_cap.vht_supported) > + dev_info(dev, "%s: VHT supported\n", __func__); > + rtl8xxxu_update_rate_table(priv, sta); > + rcu_read_unlock(); You could perhaps consider doing this in the sta_state() callback, when the station becomes associated, which is just before (or just after?) this gets called. Then you don't need to do the find_sta() here. Not that it's really a problem, but might look a bit nicer/cleaner. > + if (changed & BSS_CHANGED_HT) { > + u8 ampdu_factor, ampdu_density; > + u8 sifs; > + > + rcu_read_lock(); > + sta = ieee80211_find_sta(vif, bss_conf->bssid); > + if (!sta) { > + dev_info(dev, "BSS_CHANGED_HT: No HT sta found!\n"); > + rcu_read_unlock(); > + goto error; > + } > + if (sta->ht_cap.ht_supported) { > + ampdu_factor = sta->ht_cap.ampdu_factor; > + ampdu_density = sta->ht_cap.ampdu_density; > + sifs = 0x0e; > + } else { > + ampdu_factor = 0; > + ampdu_density = 0; > + sifs = 0x0a; > + } > + rcu_read_unlock(); This doesn't really make much sense - BSS_CHANGED_HT only says we changed bss_conf.ht_operation_mode which you don't use here. > + if (changed & BSS_CHANGED_BSSID) { > + dev_info(dev, "Changed BSSID!\n"); > + rtl8xxxu_set_bssid(priv, bss_conf->bssid); > + > + rcu_read_lock(); > + sta = ieee80211_find_sta(vif, bss_conf->bssid); > + if (!sta) { > + dev_info(dev, "No bssid sta found!\n"); > + rcu_read_unlock(); > + goto error; > + } > + rcu_read_unlock(); > + } You probably want to roll this up into CHANGED_ASSOC, since CHANGED_BSSID always really comes together with that for station mode. For IBSS things would be different but you don't seem to do that. > + if (changed & BSS_CHANGED_BASIC_RATES) { > + dev_info(dev, "Changed BASIC_RATES!\n"); > + rcu_read_lock(); > + sta = ieee80211_find_sta(vif, bss_conf->bssid); > + if (sta) > + rtl8xxxu_set_basic_rates(priv, sta); > + else > + dev_info(dev, > + "BSS_CHANGED_BASIC_RATES: No sta found!\n"); > + > + rcu_read_unlock(); > + } Ditto, this ever change during the lifetime of a BSS either, i.e. it cannot change while you're associated, and you don't care while you're not. Again, IBSS could be different, not quite sure off the top of my head. > +static u32 rtl8xxxu_queue_select(struct ieee80211_hw *hw, struct sk_buff *skb) > +{ > + struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data; > + u32 queue; > + > + if (unlikely(ieee80211_is_beacon(hdr->frame_control))) > + queue = TXDESC_QUEUE_BEACON; > + if (ieee80211_is_mgmt(hdr->frame_control)) I think you mean else if? Anyway beacons cannot happen here except perhaps for injection, in which case you probably wouldn't want to use the beacon queue anyway. I'd remove the beacon case here entirely. > + queue = TXDESC_QUEUE_MGNT; > + else > + queue = rtl8xxxu_80211_to_rtl_queue(skb_get_queue_mapping(skb)); > + > + return queue; > +} > + > +static void rtl8xxxu_calc_tx_desc_csum(struct rtl8xxxu_tx_desc *tx_desc) > +{ > + u16 *ptr = (u16 *)tx_desc; > + u16 csum = 0; > + int i; > + > + tx_desc->csum = cpu_to_le32(0); > + > + for (i = 0; i < (sizeof(struct rtl8xxxu_tx_desc) / sizeof(u16)); i++) > + csum = csum ^ le16_to_cpu(ptr[i]); > + > + tx_desc->csum |= cpu_to_le32(csum); This seems kinda pointless - you can remove the = 0 above and just use = below? > +static void rtl8xxxu_tx_complete(struct urb *urb) > +{ > + struct sk_buff *skb = (struct sk_buff *)urb->context; > + struct ieee80211_tx_info *tx_info; > + struct ieee80211_hw *hw; > + > + tx_info = IEEE80211_SKB_CB(skb); > + hw = tx_info->rate_driver_data[0]; Seems a bit odd to do one initialisation in the declarations, and the other two not, but hey, that really doesn't matter :) > + skb_pull(skb, sizeof(struct rtl8xxxu_tx_desc)); > + > + ieee80211_tx_info_clear_status(tx_info); > + tx_info->status.rates[0].idx = -1; > + tx_info->status.rates[0].count = 0; This is ... suboptimal. If you have any idea what the rates were it'd be good to report at least the one that went through. > + tx_info->flags |= IEEE80211_TX_STAT_ACK; This shouldn't be done I think, if you can't report ACK status then I think you shouldn't do it at all, you aren't setting the IEEE80211_HW_REPORTS_TX_ACK_STATUS flag (though if you could have the ack status it would certainly be better to report it properly) [snip code] Something about the TX is a bit fishy, you're using some software rate control data but aren't reporting any data back for rate control which seems to imply the device does it. You're also setting IEEE80211_HW_HAS_RATE_CONTROL which means you can't be using rates etc. here? I'll probably have to look into this more, it's an area that I'm not intimately familiar with. > + for (i = 0; i < (sizeof(struct rtl8xxxu_rx_desc) / sizeof(u32)); i++) > + _rx_desc[i] = le32_to_cpu(_rx_desc_le[i]); This is ... interesting. Wouldn't it make more sense to declare with little endian and without bitfields instead? bitfields are a bit of a minefield anyway as far as the C standard is concerned, so since you need to rely here on exact memory layout to satisfy the firmware API, I'd really avoid them. > + ieee80211_rx_irqsafe(hw, skb); Here you give up ownership of the skb > + skb_size = sizeof(struct rtl8xxxu_rx_desc) + > + RTL_RX_BUFFER_SIZE; > + skb = dev_alloc_skb(skb_size); And then you allocate a new one into the same variable. From a maintenance POV that seems a bit ugly, perhaps you should avoid that. > + if (!skb) { > + dev_warn(dev, "%s: Unable to allocate skb\n", __func__); > + goto cleanup; > + } > + > + memset(skb->data, 0, sizeof(struct rtl8xxxu_rx_desc)); > + usb_fill_bulk_urb(&rx_urb->urb, priv->udev, priv->pipe_in, > + skb->data, skb_size, rtl8xxxu_rx_complete, This is also very strange, you're sending essentially random data, from an skb pointer that's not even a proper skb len? I think you just want to use kmalloc() here instead of having an skb? Or at least use skb_put() to reserve that memory area - it doesn't make a big difference to you but using the skb API in this way is likely to confuse people in the future. In fact you could even allocate a page instead, and then add it to the skb as a frag like iwlwifi does for example, and potentially not have to copy the data around later when it goes somewhere. Not sure that's worth it for this device though :) Or perhaps just refactor the resubmission code into a small new function ... would also help with the error path here :) Also, what happens if you cannot allocate an skb here a few times? do your outstanding URBs get fewer every time? Or do you just have one? > +static int rtl8xxxu_submit_rx_urb(struct ieee80211_hw *hw) > +{ > + struct rtl8xxxu_priv *priv = hw->priv; > + struct sk_buff *skb; > + struct rtl8xxxu_rx_urb *rx_urb; > + int skb_size; > + int ret; > + > + skb_size = sizeof(struct rtl8xxxu_rx_desc) + RTL_RX_BUFFER_SIZE; > + skb = dev_alloc_skb(skb_size); > + if (!skb) > + return -ENOMEM; > + > + memset(skb->data, 0, sizeof(struct rtl8xxxu_rx_desc)); > + > + rx_urb = kmalloc(sizeof(struct rtl8xxxu_rx_urb), GFP_ATOMIC); > + if (!rx_urb) { > + dev_kfree_skb(skb); > + return -ENOMEM; > + } > + usb_init_urb(&rx_urb->urb); > + rx_urb->hw = hw; > + > + usb_fill_bulk_urb(&rx_urb->urb, priv->udev, priv->pipe_in, skb->data, > + skb_size, rtl8xxxu_rx_complete, skb); > + usb_anchor_urb(&rx_urb->urb, &priv->rx_anchor); > + ret = usb_submit_urb(&rx_urb->urb, GFP_ATOMIC); > + if (ret) > + usb_unanchor_urb(&rx_urb->urb); > + return ret; > +} Perhaps some part of this could also be refactored with the above resubmission? It looks essentially the same, perhaps the above code could even just call this. > +static int rtl8xxxu_set_rts_threshold(struct ieee80211_hw *hw, u32 rts) > +{ > + if (rts > 2347) > + return -EINVAL; > + > + return 0; > +} You should either use the value here, or not implement this callback if you want to rely on mac80211 setting the flags, IIRC. > + switch (cmd) { > + case SET_KEY: > + /* > + * This is a bit of a hack - the lower bits of the cipher > + * suite selector happens to match the cipher index in the > + * CAM > + */ It's probably not really a hack - the cipher suite selectors are defined in the spec, and we prefix them with the OUI to get the 32-bit identifier. If you assume standard-only ciphers then the lower 8 bits are just the number given to the suite in the spec. > + if (priv->rf_paths > 1) { > + sband->ht_cap.mcs.rx_mask[1] = 0xff; > + sband->ht_cap.mcs.rx_highest = cpu_to_le16(300); > + sband->ht_cap.cap |= IEEE80211_HT_CAP_SGI_40; > + } else { > + sband->ht_cap.mcs.rx_mask[1] = 0x00; > + sband->ht_cap.mcs.rx_highest = cpu_to_le16(150); > + } You don't really need to set rx_highest, and you already cleared rx_mask[1], so you don't need the else branch and can remove the rx_highest from the if branch. > + sband->ht_cap.mcs.tx_params = IEEE80211_HT_MCS_TX_DEFINED; That doesn't seem true? > + hw->wiphy->max_remain_on_channel_duration = 65535; /* ms */ That's a bit excessive, but you don't implement ROC in hw anyway? so I'd remove this part I think. > + hw->wiphy->cipher_suites = rtl8xxxu_cipher_suites; > + hw->wiphy->n_cipher_suites = ARRAY_SIZE(rtl8xxxu_cipher_suites); If you can deal with software crypto (which I believe you can) then you should just remove this and get all the ciphers, just making the ones you can do in software faster. You'll get all the new GCM ones, and CCM-256 too, in SW. johannes ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-03-09 17:46 ` Johannes Berg @ 2015-03-09 18:35 ` Jes Sorensen 2015-03-09 19:52 ` Johannes Berg 0 siblings, 1 reply; 35+ messages in thread From: Jes Sorensen @ 2015-03-09 18:35 UTC (permalink / raw) To: Johannes Berg; +Cc: linux-wireless, Larry.Finger Johannes Berg <johannes@sipsolutions.net> writes: > Hi Jes, > >> Many thanks to Johannes Berg for 802.11 insights and help and Larry >> Finger for help with the vendor driver. > > :-) > > Just a few comments since this is really the first time I'm looking > closely at the code. Thanks! >> + h2c.ramask.cmd = H2C_SET_RATE_MASK; >> + put_unaligned_le16(ramask & 0xffff, &h2c.ramask.mask_lo); >> + put_unaligned_le16(ramask >> 16, &h2c.ramask.mask_hi); > > you marked that __packed, so the put_unaligned_le16() isn't really > needed, you can use regular assignments (= cpu_to_le16(...)) I see, I wasn't aware of this, so figured better safe than sorry. >> +static void >> +rtl8xxxu_bss_info_changed(struct ieee80211_hw *hw, struct ieee80211_vif *vif, >> + struct ieee80211_bss_conf *bss_conf, u32 changed) >> +{ >> + struct rtl8xxxu_priv *priv = hw->priv; >> + struct device *dev = &priv->udev->dev; >> + struct ieee80211_sta *sta; >> + u32 val32; >> +#if 0 >> + u16 val16; >> +#endif >> + u8 val8; >> + >> + if (changed & BSS_CHANGED_ASSOC) { >> + struct h2c_cmd h2c; >> + >> + memset(&h2c, 0, sizeof(struct h2c_cmd)); >> + rtl8xxxu_set_linktype(priv, vif->type); >> + >> + if (bss_conf->assoc) { >> + rcu_read_lock(); >> + sta = ieee80211_find_sta(vif, bss_conf->bssid); >> + if (!sta) { >> + dev_info(dev, "%s: ASSOC no sta found\n", >> + __func__); >> + rcu_read_unlock(); >> + goto error; >> + } >> + >> + if (sta->ht_cap.ht_supported) >> + dev_info(dev, "%s: HT supported\n", __func__); >> + if (sta->vht_cap.vht_supported) >> + dev_info(dev, "%s: VHT supported\n", __func__); >> + rtl8xxxu_update_rate_table(priv, sta); >> + rcu_read_unlock(); > > You could perhaps consider doing this in the sta_state() callback, when > the station becomes associated, which is just before (or just after?) > this gets called. Then you don't need to do the find_sta() here. Not > that it's really a problem, but might look a bit nicer/cleaner. I'll have a look. I wasn't sure which cases were only valid as a sub-case of others, as I didn't find any documentation on it (but admittedly I didn't look too hard). >> + if (changed & BSS_CHANGED_HT) { >> + u8 ampdu_factor, ampdu_density; >> + u8 sifs; >> + >> + rcu_read_lock(); >> + sta = ieee80211_find_sta(vif, bss_conf->bssid); >> + if (!sta) { >> + dev_info(dev, "BSS_CHANGED_HT: No HT sta found!\n"); >> + rcu_read_unlock(); >> + goto error; >> + } >> + if (sta->ht_cap.ht_supported) { >> + ampdu_factor = sta->ht_cap.ampdu_factor; >> + ampdu_density = sta->ht_cap.ampdu_density; >> + sifs = 0x0e; >> + } else { >> + ampdu_factor = 0; >> + ampdu_density = 0; >> + sifs = 0x0a; >> + } >> + rcu_read_unlock(); > > This doesn't really make much sense - BSS_CHANGED_HT only says we > changed bss_conf.ht_operation_mode which you don't use here. In this case, is there another flag that would be more appropriate to handle this under? >> + if (changed & BSS_CHANGED_BSSID) { >> + dev_info(dev, "Changed BSSID!\n"); >> + rtl8xxxu_set_bssid(priv, bss_conf->bssid); >> + >> + rcu_read_lock(); >> + sta = ieee80211_find_sta(vif, bss_conf->bssid); >> + if (!sta) { >> + dev_info(dev, "No bssid sta found!\n"); >> + rcu_read_unlock(); >> + goto error; >> + } >> + rcu_read_unlock(); >> + } > > You probably want to roll this up into CHANGED_ASSOC, since > CHANGED_BSSID always really comes together with that for station mode. > For IBSS things would be different but you don't seem to do that. OK, sounds reasonable. >> + if (changed & BSS_CHANGED_BASIC_RATES) { >> + dev_info(dev, "Changed BASIC_RATES!\n"); >> + rcu_read_lock(); >> + sta = ieee80211_find_sta(vif, bss_conf->bssid); >> + if (sta) >> + rtl8xxxu_set_basic_rates(priv, sta); >> + else >> + dev_info(dev, >> + "BSS_CHANGED_BASIC_RATES: No sta found!\n"); >> + >> + rcu_read_unlock(); >> + } > > Ditto, this ever change during the lifetime of a BSS either, i.e. it > cannot change while you're associated, and you don't care while you're > not. Again, IBSS could be different, not quite sure off the top of my > head. Ditto >> +static u32 rtl8xxxu_queue_select(struct ieee80211_hw *hw, struct >> sk_buff *skb) >> +{ >> + struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data; >> + u32 queue; >> + >> + if (unlikely(ieee80211_is_beacon(hdr->frame_control))) >> + queue = TXDESC_QUEUE_BEACON; >> + if (ieee80211_is_mgmt(hdr->frame_control)) > > I think you mean else if? > > Anyway beacons cannot happen here except perhaps for injection, in which > case you probably wouldn't want to use the beacon queue anyway. I'd > remove the beacon case here entirely. This is probably suffer from being derived from vendor driver. They have a special beacon queue in the hardware which doesn't seem to map directly to anything the Linux stack does. Until I or someone else eventually implements AP support in this driver, it probably doesn't matter. >> + queue = TXDESC_QUEUE_MGNT; >> + else >> + queue = rtl8xxxu_80211_to_rtl_queue(skb_get_queue_mapping(skb)); >> + >> + return queue; >> +} >> + >> +static void rtl8xxxu_calc_tx_desc_csum(struct rtl8xxxu_tx_desc *tx_desc) >> +{ >> + u16 *ptr = (u16 *)tx_desc; >> + u16 csum = 0; >> + int i; >> + >> + tx_desc->csum = cpu_to_le32(0); >> + >> + for (i = 0; i < (sizeof(struct rtl8xxxu_tx_desc) / sizeof(u16)); i++) >> + csum = csum ^ le16_to_cpu(ptr[i]); >> + >> + tx_desc->csum |= cpu_to_le32(csum); > > This seems kinda pointless - you can remove the = 0 above and just use = > below? Good point! >> +static void rtl8xxxu_tx_complete(struct urb *urb) >> +{ >> + struct sk_buff *skb = (struct sk_buff *)urb->context; >> + struct ieee80211_tx_info *tx_info; >> + struct ieee80211_hw *hw; >> + >> + tx_info = IEEE80211_SKB_CB(skb); >> + hw = tx_info->rate_driver_data[0]; > > Seems a bit odd to do one initialisation in the declarations, and the > other two not, but hey, that really doesn't matter :) > >> + skb_pull(skb, sizeof(struct rtl8xxxu_tx_desc)); >> + >> + ieee80211_tx_info_clear_status(tx_info); >> + tx_info->status.rates[0].idx = -1; >> + tx_info->status.rates[0].count = 0; > > This is ... suboptimal. If you have any idea what the rates were it'd be > good to report at least the one that went through. I have been trying to find a way to get the actual rate used from the hardware/firmware, but so far I haven't figured out how to get it. This is the fun about having no specs. >> + tx_info->flags |= IEEE80211_TX_STAT_ACK; > > This shouldn't be done I think, if you can't report ACK status then I > think you shouldn't do it at all, you aren't setting the > IEEE80211_HW_REPORTS_TX_ACK_STATUS flag (though if you could have the > ack status it would certainly be better to report it properly) I think I was inspired by rtlwifi on this one. I can remove it. > [snip code] > > Something about the TX is a bit fishy, you're using some software rate > control data but aren't reporting any data back for rate control which > seems to imply the device does it. You're also setting > IEEE80211_HW_HAS_RATE_CONTROL which means you can't be using rates etc. > here? I'll probably have to look into this more, it's an area that I'm > not intimately familiar with. The reason for this is that I can do either way and I have been playing around with both. The vendor driver explicitly uses sw rate control for management packets, whether this is necessary or legacy I cannot tell, but I was trying to map to what they were doing. >> + for (i = 0; i < (sizeof(struct rtl8xxxu_rx_desc) / sizeof(u32)); i++) >> + _rx_desc[i] = le32_to_cpu(_rx_desc_le[i]); > > This is ... interesting. Wouldn't it make more sense to declare with > little endian and without bitfields instead? bitfields are a bit of a > minefield anyway as far as the C standard is concerned, so since you > need to rely here on exact memory layout to satisfy the firmware API, > I'd really avoid them. Why declare things if you can blow your foot off with a machine gun? It's something I was planning to look at eventually. >> + ieee80211_rx_irqsafe(hw, skb); > > Here you give up ownership of the skb > >> + skb_size = sizeof(struct rtl8xxxu_rx_desc) + >> + RTL_RX_BUFFER_SIZE; >> + skb = dev_alloc_skb(skb_size); > > And then you allocate a new one into the same variable. From a > maintenance POV that seems a bit ugly, perhaps you should avoid that. I have always done this, kinda like it, but I am not really objecting to it. >> + if (!skb) { >> + dev_warn(dev, "%s: Unable to allocate skb\n", __func__); >> + goto cleanup; >> + } >> + >> + memset(skb->data, 0, sizeof(struct rtl8xxxu_rx_desc)); >> + usb_fill_bulk_urb(&rx_urb->urb, priv->udev, priv->pipe_in, >> + skb->data, skb_size, rtl8xxxu_rx_complete, > > This is also very strange, you're sending essentially random data, from > an skb pointer that's not even a proper skb len? I think you just want > to use kmalloc() here instead of having an skb? Or at least use > skb_put() to reserve that memory area - it doesn't make a big difference > to you but using the skb API in this way is likely to confuse people in > the future. I wanted to avoid having to allocate and then copy on arrival. It's been quite common for drivers to do this, but I guess I ought to set the skb len as well at this point to keep it clean. > In fact you could even allocate a page instead, and then add it to the > skb as a frag like iwlwifi does for example, and potentially not have to > copy the data around later when it goes somewhere. Not sure that's worth > it for this device though :) I think the device can handle fragments, problem is I have zero documentation on how it does so. > Or perhaps just refactor the resubmission code into a small new > function ... would also help with the error path here :) > > Also, what happens if you cannot allocate an skb here a few times? do > your outstanding URBs get fewer every time? Or do you just have one? Most likely I roll over and die, I'll make sure to sign the life insurance over to you first though :) >> +static int rtl8xxxu_submit_rx_urb(struct ieee80211_hw *hw) >> +{ >> + struct rtl8xxxu_priv *priv = hw->priv; >> + struct sk_buff *skb; >> + struct rtl8xxxu_rx_urb *rx_urb; >> + int skb_size; >> + int ret; >> + >> + skb_size = sizeof(struct rtl8xxxu_rx_desc) + RTL_RX_BUFFER_SIZE; >> + skb = dev_alloc_skb(skb_size); >> + if (!skb) >> + return -ENOMEM; >> + >> + memset(skb->data, 0, sizeof(struct rtl8xxxu_rx_desc)); >> + >> + rx_urb = kmalloc(sizeof(struct rtl8xxxu_rx_urb), GFP_ATOMIC); >> + if (!rx_urb) { >> + dev_kfree_skb(skb); >> + return -ENOMEM; >> + } >> + usb_init_urb(&rx_urb->urb); >> + rx_urb->hw = hw; >> + >> + usb_fill_bulk_urb(&rx_urb->urb, priv->udev, priv->pipe_in, skb->data, >> + skb_size, rtl8xxxu_rx_complete, skb); >> + usb_anchor_urb(&rx_urb->urb, &priv->rx_anchor); >> + ret = usb_submit_urb(&rx_urb->urb, GFP_ATOMIC); >> + if (ret) >> + usb_unanchor_urb(&rx_urb->urb); >> + return ret; >> +} > > Perhaps some part of this could also be refactored with the above > resubmission? It looks essentially the same, perhaps the above code > could even just call this. I'll have to look into this. > >> +static int rtl8xxxu_set_rts_threshold(struct ieee80211_hw *hw, u32 rts) >> +{ >> + if (rts > 2347) >> + return -EINVAL; >> + >> + return 0; >> +} > > You should either use the value here, or not implement this callback if > you want to rely on mac80211 setting the flags, IIRC. I'll just remove it for now then - another one of these cases where I looked at other code to see what it was doing, but didn't get to figuring out what to do with it in this case. >> + switch (cmd) { >> + case SET_KEY: >> + /* >> + * This is a bit of a hack - the lower bits of the cipher >> + * suite selector happens to match the cipher index in the >> + * CAM >> + */ > > It's probably not really a hack - the cipher suite selectors are defined > in the spec, and we prefix them with the OUI to get the 32-bit > identifier. If you assume standard-only ciphers then the lower 8 bits > are just the number given to the suite in the spec. Well yes and no, the hardware happens to match to those values too, which is a bit of good luck. I think when it uses some of the strange encryptions it no longer matches up. >> + if (priv->rf_paths > 1) { >> + sband->ht_cap.mcs.rx_mask[1] = 0xff; >> + sband->ht_cap.mcs.rx_highest = cpu_to_le16(300); >> + sband->ht_cap.cap |= IEEE80211_HT_CAP_SGI_40; >> + } else { >> + sband->ht_cap.mcs.rx_mask[1] = 0x00; >> + sband->ht_cap.mcs.rx_highest = cpu_to_le16(150); >> + } > > You don't really need to set rx_highest, and you already cleared > rx_mask[1], so you don't need the else branch and can remove the > rx_highest from the if branch. I wanted to prepare the code for adding support for 2r2t devices, but I'll remove the rx_highest bits. >> + sband->ht_cap.mcs.tx_params = IEEE80211_HT_MCS_TX_DEFINED; > > That doesn't seem true? I may misunderstand the meaning of this parameter. >> + hw->wiphy->max_remain_on_channel_duration = 65535; /* ms */ > > That's a bit excessive, but you don't implement ROC in hw anyway? so I'd > remove this part I think. OK >> + hw->wiphy->cipher_suites = rtl8xxxu_cipher_suites; >> + hw->wiphy->n_cipher_suites = ARRAY_SIZE(rtl8xxxu_cipher_suites); > > If you can deal with software crypto (which I believe you can) then you > should just remove this and get all the ciphers, just making the ones > you can do in software faster. You'll get all the new GCM ones, and > CCM-256 too, in SW. I'll try to remove it - this came in with some of the earliest pieces of code I looked at when I started writing the driver. Thanks for the feedback, it's very much appreciated! Jes ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-03-09 18:35 ` Jes Sorensen @ 2015-03-09 19:52 ` Johannes Berg 0 siblings, 0 replies; 35+ messages in thread From: Johannes Berg @ 2015-03-09 19:52 UTC (permalink / raw) To: Jes Sorensen; +Cc: linux-wireless, Larry.Finger On Mon, 2015-03-09 at 14:35 -0400, Jes Sorensen wrote: > >> + if (sta->ht_cap.ht_supported) { > >> + ampdu_factor = sta->ht_cap.ampdu_factor; > >> + ampdu_density = sta->ht_cap.ampdu_density; > >> + sifs = 0x0e; > >> + } else { > >> + ampdu_factor = 0; > >> + ampdu_density = 0; > >> + sifs = 0x0a; > >> + } > >> + rcu_read_unlock(); > > > > This doesn't really make much sense - BSS_CHANGED_HT only says we > > changed bss_conf.ht_operation_mode which you don't use here. > > In this case, is there another flag that would be more appropriate to > handle this under? I think this would be similarly appropriate to handle in the sta_state() call (when it becomes associated) since these values also cannot change on the fly. Or just also roll it up into ASSOC where you seem to need it mostly. > >> + if (unlikely(ieee80211_is_beacon(hdr->frame_control))) > >> + queue = TXDESC_QUEUE_BEACON; > >> + if (ieee80211_is_mgmt(hdr->frame_control)) > > > > I think you mean else if? > > > > Anyway beacons cannot happen here except perhaps for injection, in which > > case you probably wouldn't want to use the beacon queue anyway. I'd > > remove the beacon case here entirely. > > This is probably suffer from being derived from vendor driver. They have > a special beacon queue in the hardware which doesn't seem to map > directly to anything the Linux stack does. > > Until I or someone else eventually implements AP support in this driver, > it probably doesn't matter. Indeed. Nonetheless, I'd remove the is_beacon() as you could hit this code path from userspace by injecting beacon frames, and it's unlikely to work correctly. When you actually add AP mode, you probably won't go through this function to send beacons anyway, but through some other code path that can just statically select the beacon queue, so even then it doesn't seem like you'd need this. > > Something about the TX is a bit fishy, you're using some software rate > > control data but aren't reporting any data back for rate control which > > seems to imply the device does it. You're also setting > > IEEE80211_HW_HAS_RATE_CONTROL which means you can't be using rates etc. > > here? I'll probably have to look into this more, it's an area that I'm > > not intimately familiar with. > > The reason for this is that I can do either way and I have been playing > around with both. The vendor driver explicitly uses sw rate control for > management packets, whether this is necessary or legacy I cannot tell, > but I was trying to map to what they were doing. Ok. If you're actually getting good rates out of it then you probably do have firmware rate control kicking in, so it's probably fine. Reporting things back would be nice but isn't really essential. > >> + skb_size = sizeof(struct rtl8xxxu_rx_desc) + > >> + RTL_RX_BUFFER_SIZE; > >> + skb = dev_alloc_skb(skb_size); > > > > And then you allocate a new one into the same variable. From a > > maintenance POV that seems a bit ugly, perhaps you should avoid that. > > I have always done this, kinda like it, but I am not really objecting to > it. Sure, if you like doing it that way I certainly won't object to it. It just caught my eye because initially I thought that you were using the skb after giving up ownership by passing to mac80211. > > This is also very strange, you're sending essentially random data, from > > an skb pointer that's not even a proper skb len? I think you just want > > to use kmalloc() here instead of having an skb? Or at least use > > skb_put() to reserve that memory area - it doesn't make a big difference > > to you but using the skb API in this way is likely to confuse people in > > the future. > > I wanted to avoid having to allocate and then copy on arrival. It's been > quite common for drivers to do this, but I guess I ought to set the skb > len as well at this point to keep it clean. Yeah I kinda understood that later :) I guess you set the len later, so perhaps just adding some comments would be best, since otherwise you could also arguably have to initialize the skb memory which you really don't want to. Btw, there doesn't seem to be much point in initialising the hdr either? > > In fact you could even allocate a page instead, and then add it to the > > skb as a frag like iwlwifi does for example, and potentially not have to > > copy the data around later when it goes somewhere. Not sure that's worth > > it for this device though :) > > I think the device can handle fragments, problem is I have zero > documentation on how it does so. Oh, no, I meant on RX. Submit URBs with pages, and then allocate a very small skb only later, etc. But anyway since this works for you it's probably better to keep as is unless you notice performance issues with it. Using pages has some downsides as well. > Well yes and no, the hardware happens to match to those values too, > which is a bit of good luck. I think when it uses some of the strange > encryptions it no longer matches up. That's probably because the "strange encryption" is SMS4, which is defined by the Chinese and not by the 802.11 spec :) > >> + if (priv->rf_paths > 1) { > >> + sband->ht_cap.mcs.rx_mask[1] = 0xff; > >> + sband->ht_cap.mcs.rx_highest = cpu_to_le16(300); > >> + sband->ht_cap.cap |= IEEE80211_HT_CAP_SGI_40; > >> + } else { > >> + sband->ht_cap.mcs.rx_mask[1] = 0x00; > >> + sband->ht_cap.mcs.rx_highest = cpu_to_le16(150); > >> + } > > > > You don't really need to set rx_highest, and you already cleared > > rx_mask[1], so you don't need the else branch and can remove the > > rx_highest from the if branch. > > I wanted to prepare the code for adding support for 2r2t devices, but > I'll remove the rx_highest bits. Right but all I wrote above applies even when you do have a 2x2 device. > >> + sband->ht_cap.mcs.tx_params = IEEE80211_HT_MCS_TX_DEFINED; > > > > That doesn't seem true? > > I may misunderstand the meaning of this parameter. Sorry, no, I got confused. Perhaps VHT has this differently? Can't say why I got confused, but I double-checked the spec and this is correct. johannes ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-03-09 17:00 ` [PATCH 1/1] " Jes.Sorensen 2015-03-09 17:46 ` Johannes Berg @ 2015-03-09 18:20 ` Joe Perches 2015-03-09 18:43 ` Jes Sorensen 1 sibling, 1 reply; 35+ messages in thread From: Joe Perches @ 2015-03-09 18:20 UTC (permalink / raw) To: Jes.Sorensen; +Cc: linux-wireless, Larry.Finger On Mon, 2015-03-09 at 13:00 -0400, Jes.Sorensen@redhat.com wrote: > This is an alternate driver for the Realtek 8723AU (rtl8723au) written > from scratch utilizing the mac80211 stack. Mostly trivial comments: > diff --git a/MAINTAINERS b/MAINTAINERS [] > +RTL8XXXU WIRELESS DRIVER (rtl8xxxu) > +M: Jes Sorensen <Jes.Sorensen@redhat.com> > +L: linux-wireless@vger.kernel.org > +W: http://intellinuxwireless.org > +T: git git://git.Mkernel.org/pub/scm/linux/kernel/git/jes/linux.git > + git branch rtl8723au-mac80211 please keep this on one line T: git git://git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git rtl8723au-mac80211 > diff --git a/drivers/net/wireless/rtl8xxxu.c b/drivers/net/wireless/rtl8xxxu.c [] > +static struct usb_device_id dev_table[] = { Please use const where appropriate. > +static struct ieee80211_rate rtl8xxxu_rates[] = { [] > +static struct ieee80211_channel rtl8xxxu_channels_2g[] = { [] > +static struct ieee80211_supported_band rtl8xxxu_supported_band = { [] > +static struct rtl8xxxu_reg8val rtl8723a_mac_init_table[] = { [] > +static struct rtl8xxxu_reg32val rtl8723a_phy_1t_init_table[] = { [] > +static struct rtl8xxxu_reg32val rtl8723a_agc_1t_init_table[] = { [] > +static struct rtl8xxxu_rfregval rtl8723au_radioa_rf6052_1t_init_table[] = { > +static u8 rtl8723au_read8(struct rtl8xxxu_priv *priv, u16 addr) > + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_REG_READ) > + dev_info(&udev->dev, "%s(%04x) = 0x%02x, len %i\n", > + __func__, addr, data, len); Probably better to use a local rtl_dbg which use whatever flag you want (or no flag at all) #define rtl_dbg(dev, flag, fmt, ...) do { if (rtl8xxxu_debug & RTL8XXX_DEBUG_##flag) dev_dbg(dev, fmt, ##__VA_ARGS__); } while (0) so this becomes rtl_dbg(&udev->dev, REG_REG, "%s(%04x) = 0x%02x, len %i\n", __func__, addr, data, len); though you could remove the __func__ here as dynamic_debug can add it for you. > +static bool rtl8xxxu_simularity_compare(struct rtl8xxxu_priv *priv, > + int result[][8], int c1, int c2) similarity ? > +{ [] > + if (simubitmap == 0) { > + for (i = 0; i < (bound / 4); i++) { > + if (candidate[i] >= 0) { > + for (j = i * 4; j < (i + 1) * 4 - 2; j++) > + result[3][j] = result[candidate[i]][j]; > + retval = false; > + } > + } > + return retval; > + } else if (!(simubitmap & 0x0f)) { Maybe remove the else > + /* path A OK */ > + for (i = 0; i < 4; i++) > + result[3][i] = result[c1][i]; > + } else if (!(simubitmap & 0xf0) && is_2t) { > + /* path B OK */ > + for (i = 4; i < 8; i++) > + result[3][i] = result[c1][i]; > + } > + > + return false; > +} [] > +static int rtl8xxxu_iqk_path_a(struct rtl8xxxu_priv *priv, bool configpathb) It might be helpful to describe the return flags here as it's not negative error > + if (!(reg_eac & BIT(28)) && > + ((reg_e94 & 0x03ff0000) != 0x01420000) && > + ((reg_e9c & 0x03ff0000) != 0x00420000)) > + result |= 0x01; > + else /* If TX not OK, ignore RX */ > + goto out; > + > + /* If TX is OK, check whether RX is OK */ > + if (!(reg_eac & BIT(27)) && > + ((reg_ea4 & 0x03ff0000) != 0x01320000) && > + ((reg_eac & 0x03ff0000) != 0x00360000)) > + result |= 0x02; > + else > + dev_warn(&priv->udev->dev, "%s: Path A RX IQK failed!\n", > + __func__); > +out: > + return result; > +} > + > +static void rtl8xxxu_phy_iqcalibrate(struct rtl8xxxu_priv *priv, > + int result[][8], int t, bool is_2t) > +{ > + struct device *dev = &priv->udev->dev; > + u32 i, val32; > + int path_a_ok /*, path_b_ok */; > + int retry = 2; > + > + u32 ADDA_REG[RTL8XXXU_ADDA_REGS] = { > + REG_FPGA0_XCD_SWITCH_CTRL, REG_BLUETOOTH, > + REG_RX_WAIT_CCA, REG_TX_CCK_RFON, > + REG_TX_CCK_BBON, REG_TX_OFDM_RFON, > + REG_TX_OFDM_BBON, REG_TX_TO_RX, > + REG_TX_TO_TX, REG_RX_CCK, > + REG_RX_OFDM, REG_RX_WAIT_RIFS, > + REG_RX_TO_RX, REG_STANDBY, > + REG_SLEEP, REG_PMPD_ANAEN > + }; static const is generally better. > + > + u32 IQK_MAC_REG[RTL8XXXU_MAC_REGS] = { > + REG_TXPAUSE, REG_BEACON_CTRL, > + REG_BEACON_CTRL_1, REG_GPIO_MUXCFG > + }; > + > + u32 IQK_BB_REG_92C[RTL8XXXU_BB_REGS] = { > + REG_OFDM0_TRX_PATH_ENABLE, REG_OFDM0_TR_MUX_PAR, > + REG_FPGA0_XCD_RF_SW_CTRL, REG_CONFIG_ANT_A, REG_CONFIG_ANT_B, > + REG_FPGA0_XAB_RF_SW_CTRL, REG_FPGA0_XA_RF_INT_OE, > + REG_FPGA0_XB_RF_INT_OE, REG_FPGA0_RF_MODE > + }; [] > +static void rtl8723a_phy_iq_calibrate(struct rtl8xxxu_priv *priv, bool recovery) > +{ [] > + u32 iqk_bb_reg_92c[RTL8XXXU_BB_REGS] = { > + REG_OFDM0_XA_RX_IQ_IMBALANCE, REG_OFDM0_XB_RX_IQ_IMBALANCE, > + REG_OFDM0_ENERGY_CCA_THRES, REG_OFDM0_AGCR_SSI_TABLE, > + REG_OFDM0_XA_TX_IQ_IMBALANCE, REG_OFDM0_XB_TX_IQ_IMBALANCE, > + REG_OFDM0_XC_TX_AFE, REG_OFDM0_XD_TX_AFE, > + REG_OFDM0_RX_IQ_EXT_ANTA > + }; More static const? > +static int rtl8xxxu_set_bssid(struct rtl8xxxu_priv *priv, const u8 *bssid) > +{ > + int i; > + u16 reg; > + > + dev_dbg(&priv->udev->dev, > + "%s: (%02x:%02x:%02x:%02x:%02x:%02x)\n", %pM > __func__, > + bssid[0], bssid[1], bssid[2], bssid[3], bssid[4], bssid[5]); [] > +static int rtl8xxxu_init_device(struct ieee80211_hw *hw) > +{ > + ret = rtl8xxxu_power_on(priv); > + if (ret < 0) { > + dev_warn(dev, "%s: Failed power on\n", __func__); Do you want to use _func__ on every logging message? If so, I suggest using custom macros to add them instead of adding it at every use. Something like: #define rtl_err(dev, fmt, ...) \ dev_err(dev, "%s: " fmt, __func__, ##__VA_ARGS__) #define rtl_notice(dev, fmt, ...) \ dev_notice(dev, "%s: " fmt, __func__, ##__VA_ARGS__) #define rtl_warn(dev, fmt, ...) \ dev_warn(dev, "%s: " fmt, __func__, ##__VA_ARGS__) #define rtl_info(dev, fmt, ...) \ dev_info(dev, "%s: " fmt, __func__, ##__VA_ARGS__) > +static void rtl8xxxu_int_complete(struct urb *urb) > +{ > + struct rtl8xxxu_priv *priv = (struct rtl8xxxu_priv *)urb->context; > + struct device *dev = &priv->udev->dev; > + int i, ret; > + > + dev_dbg(dev, "%s: status %i\n", __func__, urb->status); > + if (urb->status == 0) { > + for (i = 0; i < USB_INTR_CONTENT_LENGTH; i++) { > + printk("%02x ", priv->int_buf[i]); > + if ((i & 0x0f) == 0x0f) > + printk("\n"); > + } print_hex_dump(); > +static int rtl8xxxu_probe(struct usb_interface *interface, > + const struct usb_device_id *id) > +{ [] > + dev_info(&udev->dev, "RTL8723au MAC %02x:%02x:%02x:%02x:%02x:%02x\n", > + priv->efuse_wifi.efuse.mac_addr[0], > + priv->efuse_wifi.efuse.mac_addr[1], > + priv->efuse_wifi.efuse.mac_addr[2], > + priv->efuse_wifi.efuse.mac_addr[3], > + priv->efuse_wifi.efuse.mac_addr[4], > + priv->efuse_wifi.efuse.mac_addr[5]); %pM [] > +struct rtl8xxxu_priv { [] > + u32 has_wifi:1; > + u32 has_bluetooth:1; > + u32 enable_bluetooth:1; > + u32 has_gps:1; > + u32 vendor_umc:1; > + u32 has_polarity_ctrl:1; > + u32 has_eeprom:1; > + u32 boot_eeprom:1; > + u32 ep_tx_high_queue:1; > + u32 ep_tx_normal_queue:1; > + u32 ep_tx_low_queue:1; > + u32 path_a_hi_power:1; These might be better as bool instead of packed bitfields. ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-03-09 18:20 ` Joe Perches @ 2015-03-09 18:43 ` Jes Sorensen 2015-03-09 18:51 ` Joe Perches 0 siblings, 1 reply; 35+ messages in thread From: Jes Sorensen @ 2015-03-09 18:43 UTC (permalink / raw) To: Joe Perches; +Cc: linux-wireless, Larry.Finger Joe Perches <joe@perches.com> writes: > On Mon, 2015-03-09 at 13:00 -0400, Jes.Sorensen@redhat.com wrote: >> This is an alternate driver for the Realtek 8723AU (rtl8723au) written >> from scratch utilizing the mac80211 stack. > > Mostly trivial comments: > >> diff --git a/MAINTAINERS b/MAINTAINERS > [] >> +RTL8XXXU WIRELESS DRIVER (rtl8xxxu) >> +M: Jes Sorensen <Jes.Sorensen@redhat.com> >> +L: linux-wireless@vger.kernel.org >> +W: http://intellinuxwireless.org >> +T: git git://git.Mkernel.org/pub/scm/linux/kernel/git/jes/linux.git >> + git branch rtl8723au-mac80211 > > please keep this on one line Lines are 80 characters, and it won't fit. > T: git git://git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git > rtl8723au-mac80211 > >> diff --git a/drivers/net/wireless/rtl8xxxu.c b/drivers/net/wireless/rtl8xxxu.c > > [] > >> +static struct usb_device_id dev_table[] = { > > Please use const where appropriate. > > >> +static struct ieee80211_rate rtl8xxxu_rates[] = { > [] >> +static struct ieee80211_channel rtl8xxxu_channels_2g[] = { > [] >> +static struct ieee80211_supported_band rtl8xxxu_supported_band = { > [] >> +static struct rtl8xxxu_reg8val rtl8723a_mac_init_table[] = { > [] >> +static struct rtl8xxxu_reg32val rtl8723a_phy_1t_init_table[] = { > [] >> +static struct rtl8xxxu_reg32val rtl8723a_agc_1t_init_table[] = { > [] >> +static struct rtl8xxxu_rfregval rtl8723au_radioa_rf6052_1t_init_table[] = { > >> +static u8 rtl8723au_read8(struct rtl8xxxu_priv *priv, u16 addr) > >> + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_REG_READ) >> + dev_info(&udev->dev, "%s(%04x) = 0x%02x, len %i\n", >> + __func__, addr, data, len); > > Probably better to use a local rtl_dbg which use > whatever flag you want (or no flag at all) > > #define rtl_dbg(dev, flag, fmt, ...) > do { > if (rtl8xxxu_debug & RTL8XXX_DEBUG_##flag) > dev_dbg(dev, fmt, ##__VA_ARGS__); > } while (0) Ewww, absolutely not! This is way worse than how I wrote it! > so this becomes > > rtl_dbg(&udev->dev, REG_REG, "%s(%04x) = 0x%02x, len %i\n", > __func__, addr, data, len); > > though you could remove the __func__ here as > dynamic_debug can add it for you. > > >> +static bool rtl8xxxu_simularity_compare(struct rtl8xxxu_priv *priv, >> + int result[][8], int c1, int c2) > > similarity ? Simularity came from the vendor driver, I assume it references comparing the radio signal quality. Unless you have evidence to the contrary, I am not changing it. >> +{ > [] >> + if (simubitmap == 0) { >> + for (i = 0; i < (bound / 4); i++) { >> + if (candidate[i] >= 0) { >> + for (j = i * 4; j < (i + 1) * 4 - 2; j++) >> + result[3][j] = result[candidate[i]][j]; >> + retval = false; >> + } >> + } >> + return retval; >> + } else if (!(simubitmap & 0x0f)) { > > Maybe remove the else > >> + /* path A OK */ >> + for (i = 0; i < 4; i++) >> + result[3][i] = result[c1][i]; >> + } else if (!(simubitmap & 0xf0) && is_2t) { >> + /* path B OK */ >> + for (i = 4; i < 8; i++) >> + result[3][i] = result[c1][i]; >> + } >> + >> + return false; >> +} These are part of the same comparison chain, removing the else would be inconsistent. >> +static int rtl8xxxu_iqk_path_a(struct rtl8xxxu_priv *priv, bool configpathb) > > It might be helpful to describe the return > flags here as it's not negative error > >> + if (!(reg_eac & BIT(28)) && >> + ((reg_e94 & 0x03ff0000) != 0x01420000) && >> + ((reg_e9c & 0x03ff0000) != 0x00420000)) >> + result |= 0x01; >> + else /* If TX not OK, ignore RX */ >> + goto out; >> + >> + /* If TX is OK, check whether RX is OK */ >> + if (!(reg_eac & BIT(27)) && >> + ((reg_ea4 & 0x03ff0000) != 0x01320000) && >> + ((reg_eac & 0x03ff0000) != 0x00360000)) >> + result |= 0x02; >> + else >> + dev_warn(&priv->udev->dev, "%s: Path A RX IQK failed!\n", >> + __func__); >> +out: >> + return result; >> +} >> + >> +static void rtl8xxxu_phy_iqcalibrate(struct rtl8xxxu_priv *priv, >> + int result[][8], int t, bool is_2t) >> +{ >> + struct device *dev = &priv->udev->dev; >> + u32 i, val32; >> + int path_a_ok /*, path_b_ok */; >> + int retry = 2; >> + >> + u32 ADDA_REG[RTL8XXXU_ADDA_REGS] = { >> + REG_FPGA0_XCD_SWITCH_CTRL, REG_BLUETOOTH, >> + REG_RX_WAIT_CCA, REG_TX_CCK_RFON, >> + REG_TX_CCK_BBON, REG_TX_OFDM_RFON, >> + REG_TX_OFDM_BBON, REG_TX_TO_RX, >> + REG_TX_TO_TX, REG_RX_CCK, >> + REG_RX_OFDM, REG_RX_WAIT_RIFS, >> + REG_RX_TO_RX, REG_STANDBY, >> + REG_SLEEP, REG_PMPD_ANAEN >> + }; > > static const is generally better. It's irrelevant >> + >> + u32 IQK_MAC_REG[RTL8XXXU_MAC_REGS] = { >> + REG_TXPAUSE, REG_BEACON_CTRL, >> + REG_BEACON_CTRL_1, REG_GPIO_MUXCFG >> + }; >> + >> + u32 IQK_BB_REG_92C[RTL8XXXU_BB_REGS] = { >> + REG_OFDM0_TRX_PATH_ENABLE, REG_OFDM0_TR_MUX_PAR, >> + REG_FPGA0_XCD_RF_SW_CTRL, REG_CONFIG_ANT_A, REG_CONFIG_ANT_B, >> + REG_FPGA0_XAB_RF_SW_CTRL, REG_FPGA0_XA_RF_INT_OE, >> + REG_FPGA0_XB_RF_INT_OE, REG_FPGA0_RF_MODE >> + }; > > [] > >> +static void rtl8723a_phy_iq_calibrate(struct rtl8xxxu_priv *priv, >> bool recovery) >> +{ > [] >> + u32 iqk_bb_reg_92c[RTL8XXXU_BB_REGS] = { >> + REG_OFDM0_XA_RX_IQ_IMBALANCE, REG_OFDM0_XB_RX_IQ_IMBALANCE, >> + REG_OFDM0_ENERGY_CCA_THRES, REG_OFDM0_AGCR_SSI_TABLE, >> + REG_OFDM0_XA_TX_IQ_IMBALANCE, REG_OFDM0_XB_TX_IQ_IMBALANCE, >> + REG_OFDM0_XC_TX_AFE, REG_OFDM0_XD_TX_AFE, >> + REG_OFDM0_RX_IQ_EXT_ANTA >> + }; > > More static const? > >> +static int rtl8xxxu_set_bssid(struct rtl8xxxu_priv *priv, const u8 *bssid) >> +{ >> + int i; >> + u16 reg; >> + >> + dev_dbg(&priv->udev->dev, >> + "%s: (%02x:%02x:%02x:%02x:%02x:%02x)\n", > > %pM > >> __func__, >> + bssid[0], bssid[1], bssid[2], bssid[3], bssid[4], bssid[5]); > > [] > >> +static int rtl8xxxu_init_device(struct ieee80211_hw *hw) >> +{ > >> + ret = rtl8xxxu_power_on(priv); >> + if (ret < 0) { >> + dev_warn(dev, "%s: Failed power on\n", __func__); > > Do you want to use _func__ on every logging message? > If so, I suggest using custom macros to add them > instead of adding it at every use. Something like: I use them when I find it appropriate, your suggestion for custom macros is ugly, and will not go in here! > #define rtl_err(dev, fmt, ...) \ > dev_err(dev, "%s: " fmt, __func__, ##__VA_ARGS__) > #define rtl_notice(dev, fmt, ...) \ > dev_notice(dev, "%s: " fmt, __func__, ##__VA_ARGS__) > #define rtl_warn(dev, fmt, ...) \ > dev_warn(dev, "%s: " fmt, __func__, ##__VA_ARGS__) > #define rtl_info(dev, fmt, ...) \ > dev_info(dev, "%s: " fmt, __func__, ##__VA_ARGS__) > > >> +static void rtl8xxxu_int_complete(struct urb *urb) >> +{ >> + struct rtl8xxxu_priv *priv = (struct rtl8xxxu_priv *)urb->context; >> + struct device *dev = &priv->udev->dev; >> + int i, ret; >> + >> + dev_dbg(dev, "%s: status %i\n", __func__, urb->status); >> + if (urb->status == 0) { >> + for (i = 0; i < USB_INTR_CONTENT_LENGTH; i++) { >> + printk("%02x ", priv->int_buf[i]); >> + if ((i & 0x0f) == 0x0f) >> + printk("\n"); >> + } > > print_hex_dump(); > > > >> +static int rtl8xxxu_probe(struct usb_interface *interface, >> + const struct usb_device_id *id) >> +{ > [] >> + dev_info(&udev->dev, "RTL8723au MAC %02x:%02x:%02x:%02x:%02x:%02x\n", >> + priv->efuse_wifi.efuse.mac_addr[0], >> + priv->efuse_wifi.efuse.mac_addr[1], >> + priv->efuse_wifi.efuse.mac_addr[2], >> + priv->efuse_wifi.efuse.mac_addr[3], >> + priv->efuse_wifi.efuse.mac_addr[4], >> + priv->efuse_wifi.efuse.mac_addr[5]); > > %pM > > [] > >> +struct rtl8xxxu_priv { > [] >> + u32 has_wifi:1; >> + u32 has_bluetooth:1; >> + u32 enable_bluetooth:1; >> + u32 has_gps:1; >> + u32 vendor_umc:1; >> + u32 has_polarity_ctrl:1; >> + u32 has_eeprom:1; >> + u32 boot_eeprom:1; >> + u32 ep_tx_high_queue:1; >> + u32 ep_tx_normal_queue:1; >> + u32 ep_tx_low_queue:1; >> + u32 path_a_hi_power:1; > > These might be better as bool instead of packed bitfields. bool wastes 4 bytes in the struct, so no that would be worse. If you have any *bugs* to report, I welcome those comments very much. However if you are just looking to nag, please do that somewhere else. Jes ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-03-09 18:43 ` Jes Sorensen @ 2015-03-09 18:51 ` Joe Perches 2015-03-09 19:02 ` Jes Sorensen 0 siblings, 1 reply; 35+ messages in thread From: Joe Perches @ 2015-03-09 18:51 UTC (permalink / raw) To: Jes Sorensen; +Cc: linux-wireless, Larry.Finger On Mon, 2015-03-09 at 14:43 -0400, Jes Sorensen wrote: > Joe Perches <joe@perches.com> writes: > > On Mon, 2015-03-09 at 13:00 -0400, Jes.Sorensen@redhat.com wrote: > >> This is an alternate driver for the Realtek 8723AU (rtl8723au) written > >> from scratch utilizing the mac80211 stack. > > > > Mostly trivial comments: > > > >> diff --git a/MAINTAINERS b/MAINTAINERS > > [] > >> +RTL8XXXU WIRELESS DRIVER (rtl8xxxu) > >> +M: Jes Sorensen <Jes.Sorensen@redhat.com> > >> +L: linux-wireless@vger.kernel.org > >> +W: http://intellinuxwireless.org > >> +T: git git://git.Mkernel.org/pub/scm/linux/kernel/git/jes/linux.git > >> + git branch rtl8723au-mac80211 > > > > please keep this on one line > > Lines are 80 characters, and it won't fit. For code yes, for MAINTAINERS no. There are many lines > 80 chars there. Please keep: <TYPE>: entry on single lines. > >> +static void rtl8xxxu_phy_iqcalibrate(struct rtl8xxxu_priv *priv, > >> + int result[][8], int t, bool is_2t) > >> +{ > >> + struct device *dev = &priv->udev->dev; > >> + u32 i, val32; > >> + int path_a_ok /*, path_b_ok */; > >> + int retry = 2; > >> + > >> + u32 ADDA_REG[RTL8XXXU_ADDA_REGS] = { > >> + REG_FPGA0_XCD_SWITCH_CTRL, REG_BLUETOOTH, > >> + REG_RX_WAIT_CCA, REG_TX_CCK_RFON, > >> + REG_TX_CCK_BBON, REG_TX_OFDM_RFON, > >> + REG_TX_OFDM_BBON, REG_TX_TO_RX, > >> + REG_TX_TO_TX, REG_RX_CCK, > >> + REG_RX_OFDM, REG_RX_WAIT_RIFS, > >> + REG_RX_TO_RX, REG_STANDBY, > >> + REG_SLEEP, REG_PMPD_ANAEN > >> + }; > > > > static const is generally better. > > It's irrelevant Not really, it requires an initialization on entry and would make the object code smaller to use const. > >> +struct rtl8xxxu_priv { > > [] > >> + u32 has_wifi:1; > >> + u32 has_bluetooth:1; > >> + u32 enable_bluetooth:1; > >> + u32 has_gps:1; > >> + u32 vendor_umc:1; > >> + u32 has_polarity_ctrl:1; > >> + u32 has_eeprom:1; > >> + u32 boot_eeprom:1; > >> + u32 ep_tx_high_queue:1; > >> + u32 ep_tx_normal_queue:1; > >> + u32 ep_tx_low_queue:1; > >> + u32 path_a_hi_power:1; > > > > These might be better as bool instead of packed bitfields. > > bool wastes 4 bytes in the struct, so no that would be worse. It's a used-once struct. 4 bytes, wow. > If you have any *bugs* to report, I welcome those comments very much. > However if you are just looking to nag, please do that somewhere else. Imperious much? ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-03-09 18:51 ` Joe Perches @ 2015-03-09 19:02 ` Jes Sorensen 2015-03-09 19:07 ` Joe Perches 0 siblings, 1 reply; 35+ messages in thread From: Jes Sorensen @ 2015-03-09 19:02 UTC (permalink / raw) To: Joe Perches; +Cc: linux-wireless, Larry.Finger Joe Perches <joe@perches.com> writes: > On Mon, 2015-03-09 at 14:43 -0400, Jes Sorensen wrote: >> Joe Perches <joe@perches.com> writes: >> > On Mon, 2015-03-09 at 13:00 -0400, Jes.Sorensen@redhat.com wrote: >> >> This is an alternate driver for the Realtek 8723AU (rtl8723au) written >> >> from scratch utilizing the mac80211 stack. >> > >> > Mostly trivial comments: >> > >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> > [] >> >> +RTL8XXXU WIRELESS DRIVER (rtl8xxxu) >> >> +M: Jes Sorensen <Jes.Sorensen@redhat.com> >> >> +L: linux-wireless@vger.kernel.org >> >> +W: http://intellinuxwireless.org >> >> +T: git git://git.Mkernel.org/pub/scm/linux/kernel/git/jes/linux.git >> >> + git branch rtl8723au-mac80211 >> > >> > please keep this on one line >> >> Lines are 80 characters, and it won't fit. > > For code yes, for MAINTAINERS no. > There are many lines > 80 chars there. > Please keep: > <TYPE>: entry > on single lines. Longer than 80 characters is ugly and you haven't provided any justification for putting it on one line. >> >> +static void rtl8xxxu_phy_iqcalibrate(struct rtl8xxxu_priv *priv, >> >> + int result[][8], int t, bool is_2t) >> >> +{ >> >> + struct device *dev = &priv->udev->dev; >> >> + u32 i, val32; >> >> + int path_a_ok /*, path_b_ok */; >> >> + int retry = 2; >> >> + >> >> + u32 ADDA_REG[RTL8XXXU_ADDA_REGS] = { >> >> + REG_FPGA0_XCD_SWITCH_CTRL, REG_BLUETOOTH, >> >> + REG_RX_WAIT_CCA, REG_TX_CCK_RFON, >> >> + REG_TX_CCK_BBON, REG_TX_OFDM_RFON, >> >> + REG_TX_OFDM_BBON, REG_TX_TO_RX, >> >> + REG_TX_TO_TX, REG_RX_CCK, >> >> + REG_RX_OFDM, REG_RX_WAIT_RIFS, >> >> + REG_RX_TO_RX, REG_STANDBY, >> >> + REG_SLEEP, REG_PMPD_ANAEN >> >> + }; >> > >> > static const is generally better. >> >> It's irrelevant > > Not really, it requires an initialization on entry > and would make the object code smaller to use const. As I said, it's irrelevant. The gain from this is microscopic, sure it can be done, but it's not a priority. >> >> +struct rtl8xxxu_priv { >> > [] >> >> + u32 has_wifi:1; >> >> + u32 has_bluetooth:1; >> >> + u32 enable_bluetooth:1; >> >> + u32 has_gps:1; >> >> + u32 vendor_umc:1; >> >> + u32 has_polarity_ctrl:1; >> >> + u32 has_eeprom:1; >> >> + u32 boot_eeprom:1; >> >> + u32 ep_tx_high_queue:1; >> >> + u32 ep_tx_normal_queue:1; >> >> + u32 ep_tx_low_queue:1; >> >> + u32 path_a_hi_power:1; >> > >> > These might be better as bool instead of packed bitfields. >> >> bool wastes 4 bytes in the struct, so no that would be worse. > > It's a used-once struct. 4 bytes, wow. Once per device - but it all comes down to a matter of style and taste of the developer in the end. You seem to be obsessed with imposing your ideas on everybody, rather than actually looking for real bugs. >> If you have any *bugs* to report, I welcome those comments very much. >> However if you are just looking to nag, please do that somewhere else. > > Imperious much? So far you have reported one real bug (the endian issue) and a couple of trailing whitespace and messed up indentation issues. If you find more *real* issues to report, I would welcome those reports very much. However you are clearly on a mission to have the last word on every patch posted to the kernel - how about looking at real bugs or writing code instead, that would be a lot more constructive for the kernel as a whole! Jes ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-03-09 19:02 ` Jes Sorensen @ 2015-03-09 19:07 ` Joe Perches 0 siblings, 0 replies; 35+ messages in thread From: Joe Perches @ 2015-03-09 19:07 UTC (permalink / raw) To: Jes Sorensen; +Cc: linux-wireless, Larry.Finger On Mon, 2015-03-09 at 15:02 -0400, Jes Sorensen wrote: > Joe Perches <joe@perches.com> writes: > > On Mon, 2015-03-09 at 14:43 -0400, Jes Sorensen wrote: > >> Joe Perches <joe@perches.com> writes: > >> > On Mon, 2015-03-09 at 13:00 -0400, Jes.Sorensen@redhat.com wrote: > >> >> This is an alternate driver for the Realtek 8723AU (rtl8723au) written > >> >> from scratch utilizing the mac80211 stack. > >> > > >> > Mostly trivial comments: > >> > > >> >> diff --git a/MAINTAINERS b/MAINTAINERS > >> > [] > >> >> +RTL8XXXU WIRELESS DRIVER (rtl8xxxu) > >> >> +M: Jes Sorensen <Jes.Sorensen@redhat.com> > >> >> +L: linux-wireless@vger.kernel.org > >> >> +W: http://intellinuxwireless.org > >> >> +T: git git://git.Mkernel.org/pub/scm/linux/kernel/git/jes/linux.git > >> >> + git branch rtl8723au-mac80211 > >> > > >> > please keep this on one line > >> > >> Lines are 80 characters, and it won't fit. > > > > For code yes, for MAINTAINERS no. > > There are many lines > 80 chars there. > > Please keep: > > <TYPE>: entry > > on single lines. > > Longer than 80 characters is ugly and you haven't provided any > justification for putting it on one line. <TYPE>: entries are single line. > >> >> +struct rtl8xxxu_priv { > >> > [] > >> >> + u32 has_wifi:1; > >> >> + u32 has_bluetooth:1; > >> >> + u32 enable_bluetooth:1; > >> >> + u32 has_gps:1; > >> >> + u32 vendor_umc:1; > >> >> + u32 has_polarity_ctrl:1; > >> >> + u32 has_eeprom:1; > >> >> + u32 boot_eeprom:1; > >> >> + u32 ep_tx_high_queue:1; > >> >> + u32 ep_tx_normal_queue:1; > >> >> + u32 ep_tx_low_queue:1; > >> >> + u32 path_a_hi_power:1; > >> > > >> > These might be better as bool instead of packed bitfields. > >> > >> bool wastes 4 bytes in the struct, so no that would be worse. > > > > It's a used-once struct. 4 bytes, wow. > > Once per device - but it all comes down to a matter of style and taste > of the developer in the end. You seem to be obsessed with imposing your > ideas on everybody, rather than actually looking for real bugs. I'm not imposing anything. You can accept it or not. btw: every use of any bitfield requires more code for RMW than a byte access does. ^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH 0/1] New driver: rtl8723au (mac80211) @ 2015-03-06 22:15 Jes.Sorensen 2015-03-06 22:15 ` [PATCH 1/1] " Jes.Sorensen 0 siblings, 1 reply; 35+ messages in thread From: Jes.Sorensen @ 2015-03-06 22:15 UTC (permalink / raw) To: linux-wireless; +Cc: Larry.Finger, Jes Sorensen From: Jes Sorensen <Jes.Sorensen@redhat.com> This is a new driver for the rtl8723au which was written from scratch, to utilize the Linux mac80211 stack. This has been a pet project for me for some time I finally feel it is stable enough to submit. I have used it for a while without any serious issues. I started working on cleaning up the vendor provided driver in staging/rtl8723au over a year ago. After spending 6 months on it, it became obvious to me that it was a rather hopeless task, and I started writing this driver from scratch. I do not have any specs for the chip, so everything is based on knowledge I obtained from dissecting the vendor driver. Special thanks to Larry Finger for help with the original rtl8723au driver, and Johannes Berg for answering all my silly questions about 802.11 innards and the mac80211 stack. Had I known then what I know today about 802.11, I probably would never have so mad as to start this project in the first place! Cheers, Jes Jes Sorensen (1): New driver: rtl8723au (mac80211) MAINTAINERS | 9 + drivers/net/wireless/Kconfig | 19 + drivers/net/wireless/Makefile | 2 + drivers/net/wireless/rtl8xxxu.c | 4465 ++++++++++++++++++++++++++++++++++ drivers/net/wireless/rtl8xxxu.h | 497 ++++ drivers/net/wireless/rtl8xxxu_regs.h | 941 +++++++ 6 files changed, 5933 insertions(+) create mode 100644 drivers/net/wireless/rtl8xxxu.c create mode 100644 drivers/net/wireless/rtl8xxxu.h create mode 100644 drivers/net/wireless/rtl8xxxu_regs.h -- 2.1.0 ^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-03-06 22:15 [PATCH 0/1] " Jes.Sorensen @ 2015-03-06 22:15 ` Jes.Sorensen 2015-03-06 22:59 ` Joe Perches 2015-03-07 21:30 ` Larry Finger 0 siblings, 2 replies; 35+ messages in thread From: Jes.Sorensen @ 2015-03-06 22:15 UTC (permalink / raw) To: linux-wireless; +Cc: Larry.Finger, Jes Sorensen From: Jes Sorensen <Jes.Sorensen@redhat.com> This is an alternate driver for the Realtek 8723AU (rtl8723au) written from scratch utilizing the mac80211 stack. After spending months cleaning up the vendor provided rtl8723au driver, which comes with it's own 802.11 stack included, I decided to rewrite this driver from the bottom up. Many thanks to Johannes Berg for 802.11 insights and help and Larry Finger for help with the vendor driver. The full git log for the development of this driver can be found here: git git://git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git branch rtl8723au-mac80211 This driver is still experimental, but has proven to be rather stable for me. It lacks some features found in the staging driver, such as power management, AMPDU, and 40MHz channel support. In addition there is no AP and monitor support at this point. Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> --- MAINTAINERS | 9 + drivers/net/wireless/Kconfig | 19 + drivers/net/wireless/Makefile | 2 + drivers/net/wireless/rtl8xxxu.c | 4465 ++++++++++++++++++++++++++++++++++ drivers/net/wireless/rtl8xxxu.h | 497 ++++ drivers/net/wireless/rtl8xxxu_regs.h | 941 +++++++ 6 files changed, 5933 insertions(+) create mode 100644 drivers/net/wireless/rtl8xxxu.c create mode 100644 drivers/net/wireless/rtl8xxxu.h create mode 100644 drivers/net/wireless/rtl8xxxu_regs.h diff --git a/MAINTAINERS b/MAINTAINERS index 42f686f..8ce6297 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8297,6 +8297,15 @@ S: Maintained F: drivers/net/wireless/rtlwifi/ F: drivers/net/wireless/rtlwifi/rtl8192ce/ +RTL8XXXU WIRELESS DRIVER (rtl8xxxu) +M: Jes Sorensen <Jes.Sorensen@redhat.com> +L: linux-wireless@vger.kernel.org +W: http://intellinuxwireless.org +T: git git://git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git + git branch rtl8723au-mac80211 +S: Maintained +F: drivers/net/wireless/rtl8xxxu*.[ch] + S3 SAVAGE FRAMEBUFFER DRIVER M: Antonino Daplas <adaplas@gmail.com> L: linux-fbdev@vger.kernel.org diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig index 16604bd..dda80d6 100644 --- a/drivers/net/wireless/Kconfig +++ b/drivers/net/wireless/Kconfig @@ -243,6 +243,25 @@ config ADM8211 Thanks to Infineon-ADMtek for their support of this driver. +config RTL8XXXU + tristate "RTL8723AU (mac80211) support (EXPERIMENTAL)" + depends on MAC80211 && USB + ---help--- + This is an alternative driver for the RTL8723AU, written to + utilize the Linux mac80211 stack. + + This driver is under development and has a limited feature + set. In particular it does not yet support 40MHz channels, + AMPDU, and power management. However it should have a + smaller memory footprint than the vendor driver and benetifs + from the in kernel mac80211 stack. + + It can coexist with the driver from drivers/staging/rtl8723au, + but you will need to control which module you wish to load. + + To compile this driver as a module, choose M here: the module will + be called r8xxxu. If unsure, say N. + config MAC80211_HWSIM tristate "Simulated radio testing tool for mac80211" depends on MAC80211 diff --git a/drivers/net/wireless/Makefile b/drivers/net/wireless/Makefile index 0c88916..e3911cc 100644 --- a/drivers/net/wireless/Makefile +++ b/drivers/net/wireless/Makefile @@ -39,6 +39,8 @@ obj-$(CONFIG_LIBERTAS_THINFIRM) += libertas_tf/ obj-$(CONFIG_ADM8211) += adm8211.o +obj-$(CONFIG_RTL8XXXU) += rtl8xxxu.o + obj-$(CONFIG_MWL8K) += mwl8k.o obj-$(CONFIG_IWLWIFI) += iwlwifi/ diff --git a/drivers/net/wireless/rtl8xxxu.c b/drivers/net/wireless/rtl8xxxu.c new file mode 100644 index 0000000..6728a74 --- /dev/null +++ b/drivers/net/wireless/rtl8xxxu.c @@ -0,0 +1,4465 @@ +/* + * RTL8723au mac80211 USB driver + * + * Copyright (c) 2014 Jes Sorensen <Jes.Sorensen@redhat.com> + * + * Portions, notably calibration code: + * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved. + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of version 2 of the GNU General Public License as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + */ + +#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/sched.h> +#include <linux/errno.h> +#include <linux/slab.h> +#include <linux/module.h> +#include <linux/spinlock.h> +#include <linux/list.h> +#include <linux/usb.h> +#include <linux/netdevice.h> +#include <linux/etherdevice.h> +#include <linux/ethtool.h> +#include <linux/wireless.h> +#include <linux/firmware.h> +#include <net/mac80211.h> +#include "rtl8xxxu.h" +#include "rtl8xxxu_regs.h" + +#define DRIVER_NAME "rtl8xxxu" + +static int rtl8xxxu_debug = 0 /*RTL8XXXU_DEBUG_REG_WRITE*/; + +MODULE_AUTHOR("Jes Sorensen <Jes.Sorensen@redhat.com>"); +MODULE_DESCRIPTION("RTL8723au USB mac80211 Wireless LAN Driver"); +MODULE_LICENSE("GPL"); +MODULE_FIRMWARE("rtlwifi/rtl8723aufw_A.bin"); +MODULE_FIRMWARE("rtlwifi/rtl8723aufw_B.bin"); +MODULE_FIRMWARE("rtlwifi/rtl8723aufw_B_NoBT.bin"); + +#define USB_VENDER_ID_REALTEK 0x0BDA +/* Minimum IEEE80211_MAX_FRAME_LEN */ +#define RTL_RX_BUFFER_SIZE IEEE80211_MAX_FRAME_LEN + +static struct usb_device_id dev_table[] = { + {USB_DEVICE_AND_INTERFACE_INFO(USB_VENDER_ID_REALTEK, 0x8724, + 0xff, 0xff, 0xff)}, + {USB_DEVICE_AND_INTERFACE_INFO(USB_VENDER_ID_REALTEK, 0x1724, + 0xff, 0xff, 0xff)}, + {USB_DEVICE_AND_INTERFACE_INFO(USB_VENDER_ID_REALTEK, 0x0724, + 0xff, 0xff, 0xff)}, + { } +}; + +MODULE_DEVICE_TABLE(usb, dev_table); + +static struct ieee80211_rate rtl8xxxu_rates[] = { + { .bitrate = 10, .hw_value = DESC_RATE_1M, .flags = 0 }, + { .bitrate = 20, .hw_value = DESC_RATE_2M, .flags = 0 }, + { .bitrate = 55, .hw_value = DESC_RATE_5_5M, .flags = 0 }, + { .bitrate = 110, .hw_value = DESC_RATE_11M, .flags = 0 }, + { .bitrate = 60, .hw_value = DESC_RATE_6M, .flags = 0 }, + { .bitrate = 90, .hw_value = DESC_RATE_9M, .flags = 0 }, + { .bitrate = 120, .hw_value = DESC_RATE_12M, .flags = 0 }, + { .bitrate = 180, .hw_value = DESC_RATE_18M, .flags = 0 }, + { .bitrate = 240, .hw_value = DESC_RATE_24M, .flags = 0 }, + { .bitrate = 360, .hw_value = DESC_RATE_36M, .flags = 0 }, + { .bitrate = 480, .hw_value = DESC_RATE_48M, .flags = 0 }, + { .bitrate = 540, .hw_value = DESC_RATE_54M, .flags = 0 }, +}; + +static struct ieee80211_channel rtl8xxxu_channels_2g[] = { + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2412, + .hw_value = 1, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2417, + .hw_value = 2, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2422, + .hw_value = 3, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2427, + .hw_value = 4, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2432, + .hw_value = 5, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2437, + .hw_value = 6, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2442, + .hw_value = 7, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2447, + .hw_value = 8, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2452, + .hw_value = 9, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2457, + .hw_value = 10, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2462, + .hw_value = 11, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2467, + .hw_value = 12, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2472, + .hw_value = 13, .max_power = 30 }, + { .band = IEEE80211_BAND_2GHZ, .center_freq = 2484, + .hw_value = 14, .max_power = 30 } +}; + +static struct ieee80211_supported_band rtl8xxxu_supported_band = { + .channels = rtl8xxxu_channels_2g, + .n_channels = ARRAY_SIZE(rtl8xxxu_channels_2g), + .bitrates = rtl8xxxu_rates, + .n_bitrates = ARRAY_SIZE(rtl8xxxu_rates), +}; + +static const u32 rtl8xxxu_cipher_suites[] = { + WLAN_CIPHER_SUITE_WEP40, + WLAN_CIPHER_SUITE_WEP104, + WLAN_CIPHER_SUITE_TKIP, + WLAN_CIPHER_SUITE_CCMP, +}; + +static struct rtl8xxxu_reg8val rtl8723a_mac_init_table[] = { + {0x420, 0x80}, {0x423, 0x00}, {0x430, 0x00}, {0x431, 0x00}, + {0x432, 0x00}, {0x433, 0x01}, {0x434, 0x04}, {0x435, 0x05}, + {0x436, 0x06}, {0x437, 0x07}, {0x438, 0x00}, {0x439, 0x00}, + {0x43a, 0x00}, {0x43b, 0x01}, {0x43c, 0x04}, {0x43d, 0x05}, + {0x43e, 0x06}, {0x43f, 0x07}, {0x440, 0x5d}, {0x441, 0x01}, + {0x442, 0x00}, {0x444, 0x15}, {0x445, 0xf0}, {0x446, 0x0f}, + {0x447, 0x00}, {0x458, 0x41}, {0x459, 0xa8}, {0x45a, 0x72}, + {0x45b, 0xb9}, {0x460, 0x66}, {0x461, 0x66}, {0x462, 0x08}, + {0x463, 0x03}, {0x4c8, 0xff}, {0x4c9, 0x08}, {0x4cc, 0xff}, + {0x4cd, 0xff}, {0x4ce, 0x01}, {0x500, 0x26}, {0x501, 0xa2}, + {0x502, 0x2f}, {0x503, 0x00}, {0x504, 0x28}, {0x505, 0xa3}, + {0x506, 0x5e}, {0x507, 0x00}, {0x508, 0x2b}, {0x509, 0xa4}, + {0x50a, 0x5e}, {0x50b, 0x00}, {0x50c, 0x4f}, {0x50d, 0xa4}, + {0x50e, 0x00}, {0x50f, 0x00}, {0x512, 0x1c}, {0x514, 0x0a}, + {0x515, 0x10}, {0x516, 0x0a}, {0x517, 0x10}, {0x51a, 0x16}, + {0x524, 0x0f}, {0x525, 0x4f}, {0x546, 0x40}, {0x547, 0x00}, + {0x550, 0x10}, {0x551, 0x10}, {0x559, 0x02}, {0x55a, 0x02}, + {0x55d, 0xff}, {0x605, 0x30}, {0x608, 0x0e}, {0x609, 0x2a}, + {0x652, 0x20}, {0x63c, 0x0a}, {0x63d, 0x0a}, {0x63e, 0x0e}, + {0x63f, 0x0e}, {0x66e, 0x05}, {0x700, 0x21}, {0x701, 0x43}, + {0x702, 0x65}, {0x703, 0x87}, {0x708, 0x21}, {0x709, 0x43}, + {0x70a, 0x65}, {0x70b, 0x87}, {0xffff, 0xff}, +}; + +static struct rtl8xxxu_reg32val rtl8723a_phy_1t_init_table[] = { + {0x800, 0x80040000}, {0x804, 0x00000003}, + {0x808, 0x0000fc00}, {0x80c, 0x0000000a}, + {0x810, 0x10001331}, {0x814, 0x020c3d10}, + {0x818, 0x02200385}, {0x81c, 0x00000000}, + {0x820, 0x01000100}, {0x824, 0x00390004}, + {0x828, 0x00000000}, {0x82c, 0x00000000}, + {0x830, 0x00000000}, {0x834, 0x00000000}, + {0x838, 0x00000000}, {0x83c, 0x00000000}, + {0x840, 0x00010000}, {0x844, 0x00000000}, + {0x848, 0x00000000}, {0x84c, 0x00000000}, + {0x850, 0x00000000}, {0x854, 0x00000000}, + {0x858, 0x569a569a}, {0x85c, 0x001b25a4}, + {0x860, 0x66f60110}, {0x864, 0x061f0130}, + {0x868, 0x00000000}, {0x86c, 0x32323200}, + {0x870, 0x07000760}, {0x874, 0x22004000}, + {0x878, 0x00000808}, {0x87c, 0x00000000}, + {0x880, 0xc0083070}, {0x884, 0x000004d5}, + {0x888, 0x00000000}, {0x88c, 0xccc000c0}, + {0x890, 0x00000800}, {0x894, 0xfffffffe}, + {0x898, 0x40302010}, {0x89c, 0x00706050}, + {0x900, 0x00000000}, {0x904, 0x00000023}, + {0x908, 0x00000000}, {0x90c, 0x81121111}, + {0xa00, 0x00d047c8}, {0xa04, 0x80ff000c}, + {0xa08, 0x8c838300}, {0xa0c, 0x2e68120f}, + {0xa10, 0x9500bb78}, {0xa14, 0x11144028}, + {0xa18, 0x00881117}, {0xa1c, 0x89140f00}, + {0xa20, 0x1a1b0000}, {0xa24, 0x090e1317}, + {0xa28, 0x00000204}, {0xa2c, 0x00d30000}, + {0xa70, 0x101fbf00}, {0xa74, 0x00000007}, + {0xa78, 0x00000900}, {0xc00, 0x48071d40}, + {0xc04, 0x03a05611}, {0xc08, 0x000000e4}, + {0xc0c, 0x6c6c6c6c}, {0xc10, 0x08800000}, + {0xc14, 0x40000100}, {0xc18, 0x08800000}, + {0xc1c, 0x40000100}, {0xc20, 0x00000000}, + {0xc24, 0x00000000}, {0xc28, 0x00000000}, + {0xc2c, 0x00000000}, {0xc30, 0x69e9ac44}, +#if 0 /* Not for USB */ + {0xff0f011f, 0xabcd}, + {0xc34, 0x469652cf}, + {0xcdcdcdcd, 0xcdcd}, +#endif + {0xc34, 0x469652af}, +#if 0 + {0xff0f011f, 0xdead}, +#endif + {0xc38, 0x49795994}, + {0xc3c, 0x0a97971c}, {0xc40, 0x1f7c403f}, + {0xc44, 0x000100b7}, {0xc48, 0xec020107}, + {0xc4c, 0x007f037f}, {0xc50, 0x69543420}, + {0xc54, 0x43bc0094}, {0xc58, 0x69543420}, + {0xc5c, 0x433c0094}, {0xc60, 0x00000000}, +#if 0 /* Not for USB */ + {0xff0f011f, 0xabcd}, + {0xc64, 0x7116848b}, + {0xcdcdcdcd, 0xcdcd}, +#endif + {0xc64, 0x7112848b}, +#if 0 + {0xff0f011f, 0xdead}, +#endif + {0xc68, 0x47c00bff}, + {0xc6c, 0x00000036}, {0xc70, 0x2c7f000d}, + {0xc74, 0x018610db}, {0xc78, 0x0000001f}, + {0xc7c, 0x00b91612}, {0xc80, 0x40000100}, + {0xc84, 0x20f60000}, {0xc88, 0x40000100}, + {0xc8c, 0x20200000}, {0xc90, 0x00121820}, + {0xc94, 0x00000000}, {0xc98, 0x00121820}, + {0xc9c, 0x00007f7f}, {0xca0, 0x00000000}, + {0xca4, 0x00000080}, {0xca8, 0x00000000}, + {0xcac, 0x00000000}, {0xcb0, 0x00000000}, + {0xcb4, 0x00000000}, {0xcb8, 0x00000000}, + {0xcbc, 0x28000000}, {0xcc0, 0x00000000}, + {0xcc4, 0x00000000}, {0xcc8, 0x00000000}, + {0xccc, 0x00000000}, {0xcd0, 0x00000000}, + {0xcd4, 0x00000000}, {0xcd8, 0x64b22427}, + {0xcdc, 0x00766932}, {0xce0, 0x00222222}, + {0xce4, 0x00000000}, {0xce8, 0x37644302}, + {0xcec, 0x2f97d40c}, {0xd00, 0x00080740}, + {0xd04, 0x00020401}, {0xd08, 0x0000907f}, + {0xd0c, 0x20010201}, {0xd10, 0xa0633333}, + {0xd14, 0x3333bc43}, {0xd18, 0x7a8f5b6b}, + {0xd2c, 0xcc979975}, {0xd30, 0x00000000}, + {0xd34, 0x80608000}, {0xd38, 0x00000000}, + {0xd3c, 0x00027293}, {0xd40, 0x00000000}, + {0xd44, 0x00000000}, {0xd48, 0x00000000}, + {0xd4c, 0x00000000}, {0xd50, 0x6437140a}, + {0xd54, 0x00000000}, {0xd58, 0x00000000}, + {0xd5c, 0x30032064}, {0xd60, 0x4653de68}, + {0xd64, 0x04518a3c}, {0xd68, 0x00002101}, + {0xd6c, 0x2a201c16}, {0xd70, 0x1812362e}, + {0xd74, 0x322c2220}, {0xd78, 0x000e3c24}, + {0xe00, 0x2a2a2a2a}, {0xe04, 0x2a2a2a2a}, + {0xe08, 0x03902a2a}, {0xe10, 0x2a2a2a2a}, + {0xe14, 0x2a2a2a2a}, {0xe18, 0x2a2a2a2a}, + {0xe1c, 0x2a2a2a2a}, {0xe28, 0x00000000}, + {0xe30, 0x1000dc1f}, {0xe34, 0x10008c1f}, + {0xe38, 0x02140102}, {0xe3c, 0x681604c2}, + {0xe40, 0x01007c00}, {0xe44, 0x01004800}, + {0xe48, 0xfb000000}, {0xe4c, 0x000028d1}, + {0xe50, 0x1000dc1f}, {0xe54, 0x10008c1f}, + {0xe58, 0x02140102}, {0xe5c, 0x28160d05}, + {0xe60, 0x00000008}, {0xe68, 0x001b25a4}, + {0xe6c, 0x631b25a0}, {0xe70, 0x631b25a0}, + {0xe74, 0x081b25a0}, {0xe78, 0x081b25a0}, + {0xe7c, 0x081b25a0}, {0xe80, 0x081b25a0}, + {0xe84, 0x631b25a0}, {0xe88, 0x081b25a0}, + {0xe8c, 0x631b25a0}, {0xed0, 0x631b25a0}, + {0xed4, 0x631b25a0}, {0xed8, 0x631b25a0}, + {0xedc, 0x001b25a0}, {0xee0, 0x001b25a0}, + {0xeec, 0x6b1b25a0}, {0xf14, 0x00000003}, + {0xf4c, 0x00000000}, {0xf00, 0x00000300}, + {0xffff, 0xffffffff}, +}; + +static struct rtl8xxxu_reg32val rtl8723a_agc_1t_init_table[] = { + {0xc78, 0x7b000001}, {0xc78, 0x7b010001}, + {0xc78, 0x7b020001}, {0xc78, 0x7b030001}, + {0xc78, 0x7b040001}, {0xc78, 0x7b050001}, + {0xc78, 0x7a060001}, {0xc78, 0x79070001}, + {0xc78, 0x78080001}, {0xc78, 0x77090001}, + {0xc78, 0x760a0001}, {0xc78, 0x750b0001}, + {0xc78, 0x740c0001}, {0xc78, 0x730d0001}, + {0xc78, 0x720e0001}, {0xc78, 0x710f0001}, + {0xc78, 0x70100001}, {0xc78, 0x6f110001}, + {0xc78, 0x6e120001}, {0xc78, 0x6d130001}, + {0xc78, 0x6c140001}, {0xc78, 0x6b150001}, + {0xc78, 0x6a160001}, {0xc78, 0x69170001}, + {0xc78, 0x68180001}, {0xc78, 0x67190001}, + {0xc78, 0x661a0001}, {0xc78, 0x651b0001}, + {0xc78, 0x641c0001}, {0xc78, 0x631d0001}, + {0xc78, 0x621e0001}, {0xc78, 0x611f0001}, + {0xc78, 0x60200001}, {0xc78, 0x49210001}, + {0xc78, 0x48220001}, {0xc78, 0x47230001}, + {0xc78, 0x46240001}, {0xc78, 0x45250001}, + {0xc78, 0x44260001}, {0xc78, 0x43270001}, + {0xc78, 0x42280001}, {0xc78, 0x41290001}, + {0xc78, 0x402a0001}, {0xc78, 0x262b0001}, + {0xc78, 0x252c0001}, {0xc78, 0x242d0001}, + {0xc78, 0x232e0001}, {0xc78, 0x222f0001}, + {0xc78, 0x21300001}, {0xc78, 0x20310001}, + {0xc78, 0x06320001}, {0xc78, 0x05330001}, + {0xc78, 0x04340001}, {0xc78, 0x03350001}, + {0xc78, 0x02360001}, {0xc78, 0x01370001}, + {0xc78, 0x00380001}, {0xc78, 0x00390001}, + {0xc78, 0x003a0001}, {0xc78, 0x003b0001}, + {0xc78, 0x003c0001}, {0xc78, 0x003d0001}, + {0xc78, 0x003e0001}, {0xc78, 0x003f0001}, + {0xc78, 0x7b400001}, {0xc78, 0x7b410001}, + {0xc78, 0x7b420001}, {0xc78, 0x7b430001}, + {0xc78, 0x7b440001}, {0xc78, 0x7b450001}, + {0xc78, 0x7a460001}, {0xc78, 0x79470001}, + {0xc78, 0x78480001}, {0xc78, 0x77490001}, + {0xc78, 0x764a0001}, {0xc78, 0x754b0001}, + {0xc78, 0x744c0001}, {0xc78, 0x734d0001}, + {0xc78, 0x724e0001}, {0xc78, 0x714f0001}, + {0xc78, 0x70500001}, {0xc78, 0x6f510001}, + {0xc78, 0x6e520001}, {0xc78, 0x6d530001}, + {0xc78, 0x6c540001}, {0xc78, 0x6b550001}, + {0xc78, 0x6a560001}, {0xc78, 0x69570001}, + {0xc78, 0x68580001}, {0xc78, 0x67590001}, + {0xc78, 0x665a0001}, {0xc78, 0x655b0001}, + {0xc78, 0x645c0001}, {0xc78, 0x635d0001}, + {0xc78, 0x625e0001}, {0xc78, 0x615f0001}, + {0xc78, 0x60600001}, {0xc78, 0x49610001}, + {0xc78, 0x48620001}, {0xc78, 0x47630001}, + {0xc78, 0x46640001}, {0xc78, 0x45650001}, + {0xc78, 0x44660001}, {0xc78, 0x43670001}, + {0xc78, 0x42680001}, {0xc78, 0x41690001}, + {0xc78, 0x406a0001}, {0xc78, 0x266b0001}, + {0xc78, 0x256c0001}, {0xc78, 0x246d0001}, + {0xc78, 0x236e0001}, {0xc78, 0x226f0001}, + {0xc78, 0x21700001}, {0xc78, 0x20710001}, + {0xc78, 0x06720001}, {0xc78, 0x05730001}, + {0xc78, 0x04740001}, {0xc78, 0x03750001}, + {0xc78, 0x02760001}, {0xc78, 0x01770001}, + {0xc78, 0x00780001}, {0xc78, 0x00790001}, + {0xc78, 0x007a0001}, {0xc78, 0x007b0001}, + {0xc78, 0x007c0001}, {0xc78, 0x007d0001}, + {0xc78, 0x007e0001}, {0xc78, 0x007f0001}, + {0xc78, 0x3800001e}, {0xc78, 0x3801001e}, + {0xc78, 0x3802001e}, {0xc78, 0x3803001e}, + {0xc78, 0x3804001e}, {0xc78, 0x3805001e}, + {0xc78, 0x3806001e}, {0xc78, 0x3807001e}, + {0xc78, 0x3808001e}, {0xc78, 0x3c09001e}, + {0xc78, 0x3e0a001e}, {0xc78, 0x400b001e}, + {0xc78, 0x440c001e}, {0xc78, 0x480d001e}, + {0xc78, 0x4c0e001e}, {0xc78, 0x500f001e}, + {0xc78, 0x5210001e}, {0xc78, 0x5611001e}, + {0xc78, 0x5a12001e}, {0xc78, 0x5e13001e}, + {0xc78, 0x6014001e}, {0xc78, 0x6015001e}, + {0xc78, 0x6016001e}, {0xc78, 0x6217001e}, + {0xc78, 0x6218001e}, {0xc78, 0x6219001e}, + {0xc78, 0x621a001e}, {0xc78, 0x621b001e}, + {0xc78, 0x621c001e}, {0xc78, 0x621d001e}, + {0xc78, 0x621e001e}, {0xc78, 0x621f001e}, + {0xffff, 0xffffffff} +}; + +static struct rtl8xxxu_rfregval rtl8723au_radioa_rf6052_1t_init_table[] = { + {0x00, 0x00030159}, {0x01, 0x00031284}, + {0x02, 0x00098000}, +#if 0 /* Only for PCIE */ + {0xff0f011f, 0xabcd}, + {0x03, 0x00018c63}, + {0xcdcdcdcd, 0xcdcd}, +#endif + {0x03, 0x00039c63}, +#if 0 + {0xff0f011f, 0xdead}, +#endif + {0x04, 0x000210e7}, {0x09, 0x0002044f}, + {0x0a, 0x0001a3f1}, {0x0b, 0x00014787}, + {0x0c, 0x000896fe}, {0x0d, 0x0000e02c}, + {0x0e, 0x00039ce7}, {0x0f, 0x00000451}, + {0x19, 0x00000000}, {0x1a, 0x00030355}, + {0x1b, 0x00060a00}, {0x1c, 0x000fc378}, + {0x1d, 0x000a1250}, {0x1e, 0x0000024f}, + {0x1f, 0x00000000}, {0x20, 0x0000b614}, + {0x21, 0x0006c000}, {0x22, 0x00000000}, + {0x23, 0x00001558}, {0x24, 0x00000060}, + {0x25, 0x00000483}, {0x26, 0x0004f000}, + {0x27, 0x000ec7d9}, {0x28, 0x00057730}, + {0x29, 0x00004783}, {0x2a, 0x00000001}, + {0x2b, 0x00021334}, {0x2a, 0x00000000}, + {0x2b, 0x00000054}, {0x2a, 0x00000001}, + {0x2b, 0x00000808}, {0x2b, 0x00053333}, + {0x2c, 0x0000000c}, {0x2a, 0x00000002}, + {0x2b, 0x00000808}, {0x2b, 0x0005b333}, + {0x2c, 0x0000000d}, {0x2a, 0x00000003}, + {0x2b, 0x00000808}, {0x2b, 0x00063333}, + {0x2c, 0x0000000d}, {0x2a, 0x00000004}, + {0x2b, 0x00000808}, {0x2b, 0x0006b333}, + {0x2c, 0x0000000d}, {0x2a, 0x00000005}, + {0x2b, 0x00000808}, {0x2b, 0x00073333}, + {0x2c, 0x0000000d}, {0x2a, 0x00000006}, + {0x2b, 0x00000709}, {0x2b, 0x0005b333}, + {0x2c, 0x0000000d}, {0x2a, 0x00000007}, + {0x2b, 0x00000709}, {0x2b, 0x00063333}, + {0x2c, 0x0000000d}, {0x2a, 0x00000008}, + {0x2b, 0x0000060a}, {0x2b, 0x0004b333}, + {0x2c, 0x0000000d}, {0x2a, 0x00000009}, + {0x2b, 0x0000060a}, {0x2b, 0x00053333}, + {0x2c, 0x0000000d}, {0x2a, 0x0000000a}, + {0x2b, 0x0000060a}, {0x2b, 0x0005b333}, + {0x2c, 0x0000000d}, {0x2a, 0x0000000b}, + {0x2b, 0x0000060a}, {0x2b, 0x00063333}, + {0x2c, 0x0000000d}, {0x2a, 0x0000000c}, + {0x2b, 0x0000060a}, {0x2b, 0x0006b333}, + {0x2c, 0x0000000d}, {0x2a, 0x0000000d}, + {0x2b, 0x0000060a}, {0x2b, 0x00073333}, + {0x2c, 0x0000000d}, {0x2a, 0x0000000e}, + {0x2b, 0x0000050b}, {0x2b, 0x00066666}, + {0x2c, 0x0000001a}, {0x2a, 0x000e0000}, + {0x10, 0x0004000f}, {0x11, 0x000e31fc}, + {0x10, 0x0006000f}, {0x11, 0x000ff9f8}, + {0x10, 0x0002000f}, {0x11, 0x000203f9}, + {0x10, 0x0003000f}, {0x11, 0x000ff500}, + {0x10, 0x00000000}, {0x11, 0x00000000}, + {0x10, 0x0008000f}, {0x11, 0x0003f100}, + {0x10, 0x0009000f}, {0x11, 0x00023100}, + {0x12, 0x00032000}, {0x12, 0x00071000}, + {0x12, 0x000b0000}, {0x12, 0x000fc000}, + {0x13, 0x000287b3}, {0x13, 0x000244b7}, + {0x13, 0x000204ab}, {0x13, 0x0001c49f}, + {0x13, 0x00018493}, {0x13, 0x0001429b}, + {0x13, 0x00010299}, {0x13, 0x0000c29c}, + {0x13, 0x000081a0}, {0x13, 0x000040ac}, + {0x13, 0x00000020}, {0x14, 0x0001944c}, + {0x14, 0x00059444}, {0x14, 0x0009944c}, + {0x14, 0x000d9444}, +#if 0 /* Only for PCIE */ + {0xff0f011f, 0xabcd}, + {0x15, 0x0000f424}, + {0x15, 0x0004f424}, + {0x15, 0x0008f424}, + {0x15, 0x000cf424}, + {0xcdcdcdcd, 0xcdcd}, +#endif + {0x15, 0x0000f474}, {0x15, 0x0004f477}, + {0x15, 0x0008f455}, {0x15, 0x000cf455}, +#if 0 + {0xff0f011f, 0xdead}, +#endif + {0x16, 0x00000339}, {0x16, 0x00040339}, + {0x16, 0x00080339}, +#if 0 /* Only for PCIE */ + {0xff0f011f, 0xabcd}, + {0x16, 0x000c0356}, + {0xcdcdcdcd, 0xcdcd}, +#endif + {0x16, 0x000c0366}, +#if 0 + {0xff0f011f, 0xdead}, +#endif + {0x00, 0x00010159}, {0x18, 0x0000f401}, + {0xfe, 0x00000000}, {0xfe, 0x00000000}, + {0x1f, 0x00000003}, {0xfe, 0x00000000}, + {0xfe, 0x00000000}, {0x1e, 0x00000247}, + {0x1f, 0x00000000}, {0x00, 0x00030159}, + {0xff, 0xffffffff} +}; + +static u8 rtl8723au_read8(struct rtl8xxxu_priv *priv, u16 addr) +{ + struct usb_device *udev = priv->udev; + int len; + u8 data; + + mutex_lock(&priv->usb_buf_mutex); + len = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), + REALTEK_USB_CMD_REQ, REALTEK_USB_READ, + addr, 0, &priv->usb_buf.val8, sizeof(u8), + RTW_USB_CONTROL_MSG_TIMEOUT); + data = priv->usb_buf.val8; + mutex_unlock(&priv->usb_buf_mutex); + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_REG_READ) + pr_debug("%s(%04x) = 0x%02x, len %i\n", + __func__, addr, data, len); + return data; +} + +static u16 rtl8723au_read16(struct rtl8xxxu_priv *priv, u16 addr) +{ + struct usb_device *udev = priv->udev; + int len; + u16 data; + + mutex_lock(&priv->usb_buf_mutex); + len = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), + REALTEK_USB_CMD_REQ, REALTEK_USB_READ, + addr, 0, &priv->usb_buf.val16, sizeof(u16), + RTW_USB_CONTROL_MSG_TIMEOUT); + data = le16_to_cpu(priv->usb_buf.val16); + mutex_unlock(&priv->usb_buf_mutex); + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_REG_READ) + pr_debug("%s(%04x) = 0x%04x, len %i\n", + __func__, addr, data, len); + return data; +} + +static u32 rtl8723au_read32(struct rtl8xxxu_priv *priv, u16 addr) +{ + struct usb_device *udev = priv->udev; + int len; + u32 data; + + mutex_lock(&priv->usb_buf_mutex); + len = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), + REALTEK_USB_CMD_REQ, REALTEK_USB_READ, + addr, 0, &priv->usb_buf.val32, sizeof(u32), + RTW_USB_CONTROL_MSG_TIMEOUT); + data = le32_to_cpu(priv->usb_buf.val32); + mutex_unlock(&priv->usb_buf_mutex); + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_REG_READ) + pr_debug("%s(%04x) = 0x%08x, len %i\n", + __func__, addr, data, len); + return data; +} + +static int rtl8723au_write8(struct rtl8xxxu_priv *priv, u16 addr, u8 val) +{ + struct usb_device *udev = priv->udev; + int ret; + + mutex_lock(&priv->usb_buf_mutex); + priv->usb_buf.val8 = val; + ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), + REALTEK_USB_CMD_REQ, REALTEK_USB_WRITE, + addr, 0, &priv->usb_buf.val8, sizeof(u8), + RTW_USB_CONTROL_MSG_TIMEOUT); + + mutex_unlock(&priv->usb_buf_mutex); + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_REG_WRITE) + pr_debug("%s(%04x) = 0x%02x\n", __func__, addr, val); + return ret; +} + +static int rtl8723au_write16(struct rtl8xxxu_priv *priv, u16 addr, u16 val) +{ + struct usb_device *udev = priv->udev; + int ret; + + mutex_lock(&priv->usb_buf_mutex); + priv->usb_buf.val16 = cpu_to_le16(val); + ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), + REALTEK_USB_CMD_REQ, REALTEK_USB_WRITE, + addr, 0, &priv->usb_buf.val16, sizeof(u16), + RTW_USB_CONTROL_MSG_TIMEOUT); + mutex_unlock(&priv->usb_buf_mutex); + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_REG_WRITE) + pr_debug("%s(%04x) = 0x%04x\n", __func__, addr, val); + return ret; +} + +static int rtl8723au_write32(struct rtl8xxxu_priv *priv, u16 addr, u32 val) +{ + struct usb_device *udev = priv->udev; + int ret; + + mutex_lock(&priv->usb_buf_mutex); + priv->usb_buf.val32 = cpu_to_le32(val); + ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), + REALTEK_USB_CMD_REQ, REALTEK_USB_WRITE, + addr, 0, &priv->usb_buf.val32, sizeof(u32), + RTW_USB_CONTROL_MSG_TIMEOUT); + mutex_unlock(&priv->usb_buf_mutex); + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_REG_WRITE) + pr_debug("%s(%04x) = 0x%08x\n", __func__, addr, val); + return ret; +} + +static int +rtl8723au_writeN(struct rtl8xxxu_priv *priv, u16 addr, u8 *buf, u16 len) +{ + struct usb_device *udev = priv->udev; + int ret; + + ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), + REALTEK_USB_CMD_REQ, REALTEK_USB_WRITE, + addr, 0, buf, len, RTW_USB_CONTROL_MSG_TIMEOUT); + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_REG_WRITE) + pr_debug("%s(%04x) = %p, len 0x%02x\n", + __func__, addr, buf, len); + return ret; +} + +static u32 rtl8723au_read_rfreg(struct rtl8xxxu_priv *priv, u8 reg) +{ + u32 hssia, val32, retval; + + hssia = rtl8723au_read32(priv, REG_FPGA0_XA_HSSI_PARM2); + /* + * For path B it seems we should be reading REG_FPGA0_XB_HSSI_PARM1 + * into val32 + */ + val32 = hssia; + val32 &= ~FPGA0_HSSI_PARM2_ADDR_MASK; + val32 |= (reg << FPGA0_HSSI_PARM2_ADDR_SHIFT) | + FPGA0_HSSI_PARM2_EDGE_READ; + rtl8723au_write32(priv, REG_FPGA0_XA_HSSI_PARM2, + hssia &= ~FPGA0_HSSI_PARM2_EDGE_READ); + udelay(10); + /* Here use XB for path B */ + rtl8723au_write32(priv, REG_FPGA0_XA_HSSI_PARM2, val32); + udelay(100); + rtl8723au_write32(priv, REG_FPGA0_XA_HSSI_PARM2, + hssia |= FPGA0_HSSI_PARM2_EDGE_READ); + udelay(10); + /* Use XB for path B */ + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_HSSI_PARM1); + if (val32 & BIT(8)) /* RF PI enabled */ + retval = rtl8723au_read32(priv, REG_HSPI_XA_READBACK); + else + retval = rtl8723au_read32(priv, REG_FPGA0_XA_LSSI_READBACK); + + retval &= 0xfffff; + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_RFREG_READ) + pr_debug("%s(%02x) = 0x%06x\n", __func__, reg, retval); + return retval; +} + +static int rtl8723au_write_rfreg(struct rtl8xxxu_priv *priv, u8 reg, u32 data) +{ + int ret, retval; + u32 dataaddr; + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_RFREG_WRITE) + pr_debug("%s(%02x) = 0x%06x\n", __func__, reg, data); + + data &= FPGA0_LSSI_PARM_DATA_MASK; + dataaddr = (reg << FPGA0_LSSI_PARM_ADDR_SHIFT) | data; + + /* Use XB for path B */ + ret = rtl8723au_write32(priv, REG_FPGA0_XA_LSSI_PARM, dataaddr); + if (ret != sizeof(dataaddr)) + retval = -EIO; + else + retval = 0; + + udelay(1); + + return retval; +} + +static int rtl8723a_h2c_cmd(struct rtl8xxxu_priv *priv, struct h2c_cmd *h2c) +{ + int mbox_nr, retry, retval = 0; + int mbox_reg, mbox_ext_reg; + u8 val8; + + mbox_nr = priv->next_mbox; + + mbox_reg = REG_HMBOX_0 + (mbox_nr * 4); + mbox_ext_reg = REG_HMBOX_EXT_0 + (mbox_nr * 2); + + mutex_lock(&priv->h2c_mutex); + /* + * MBOX ready? + */ + retry = 100; + do { + val8 = rtl8723au_read8(priv, REG_HMTFR); + if (!(val8 & BIT(mbox_nr))) + break; + } while (retry--); + + if (!retry) { + pr_debug("%s: Mailbox busy\n", __func__); + retval = -EBUSY; + goto error; + } + + /* + * Need to swap as it's being swapped again by rtl8723au_write16/32() + */ + if (h2c->cmd.cmd & H2C_EXT) { + rtl8723au_write16(priv, mbox_ext_reg, + le16_to_cpu(h2c->raw.ext)); + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_H2C) + pr_debug("H2C_EXT %04x\n", le16_to_cpu(h2c->raw.ext)); + } + rtl8723au_write32(priv, mbox_reg, le32_to_cpu(h2c->raw.data)); + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_H2C) + pr_debug("H2C %08x\n", le16_to_cpu(h2c->raw.data)); + + priv->next_mbox = (mbox_nr + 1) % H2C_MAX_MBOX; + +error: + mutex_unlock(&priv->h2c_mutex); + return retval; +} + +static void rtl8723a_enable_rf(struct rtl8xxxu_priv *priv) +{ + u8 val8; + u32 val32; + + val8 = rtl8723au_read8(priv, REG_SPS0_CTRL); + val8 |= BIT(0) | BIT(3); + rtl8723au_write8(priv, REG_SPS0_CTRL, val8); + + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_RF_PARM); + val32 &= ~(BIT(4) | BIT(5)); + val32 |= BIT(3); + rtl8723au_write32(priv, REG_FPGA0_XA_RF_PARM, val32); + + val32 = rtl8723au_read32(priv, REG_OFDM0_TRX_PATH_ENABLE); + val32 &= ~(BIT(4) | BIT(5) | BIT(6) | BIT(7)); + val32 |= BIT(4); + rtl8723au_write32(priv, REG_OFDM0_TRX_PATH_ENABLE, val32); + + val32 = rtl8723au_read32(priv, REG_FPGA0_RF_MODE); + val32 &= ~FPGA_RF_MODE_JAPAN; + rtl8723au_write32(priv, REG_FPGA0_RF_MODE, val32); + + rtl8723au_write32(priv, REG_RX_WAIT_CCA, 0x631B25A0); + + rtl8723au_write_rfreg(priv, RF6052_REG_AC, 0x32d95); + +#if 0 + rtl8723au_write8(priv, REG_SYS_FUNC, 0xE3); + rtl8723au_write8(priv, REG_APSD_CTRL, 0x00); + rtl8723au_write8(priv, REG_SYS_FUNC, 0xE2); + rtl8723au_write8(priv, REG_SYS_FUNC, 0xE3); +#endif + rtl8723au_write8(priv, REG_TXPAUSE, 0x00); +} + +static void rtl8723a_disable_rf(struct rtl8xxxu_priv *priv) +{ + u8 sps0; + u32 val32; + + rtl8723au_write8(priv, REG_TXPAUSE, 0xff); + + sps0 = rtl8723au_read8(priv, REG_SPS0_CTRL); + + /* RF RX code for preamble power saving */ + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_RF_PARM); + val32 &= ~(BIT(3) | BIT(4) | BIT(5)); + rtl8723au_write32(priv, REG_FPGA0_XA_RF_PARM, val32); + + /* Disable all packet detection for all four paths */ + val32 = rtl8723au_read32(priv, REG_OFDM0_TRX_PATH_ENABLE); + val32 &= ~(BIT(4) | BIT(5) | BIT(6) | BIT(7)); + rtl8723au_write32(priv, REG_OFDM0_TRX_PATH_ENABLE, val32); + + /* Enable power saving */ + val32 = rtl8723au_read32(priv, REG_FPGA0_RF_MODE); + val32 |= FPGA_RF_MODE_JAPAN; + rtl8723au_write32(priv, REG_FPGA0_RF_MODE, val32); + + /* AFE control register to power down bits [30:22] */ + rtl8723au_write32(priv, REG_RX_WAIT_CCA, 0x001b25a0); + + /* Power down RF module */ + rtl8723au_write_rfreg(priv, RF6052_REG_AC, 0); + + sps0 &= ~(BIT(0) | BIT(3)); + rtl8723au_write8(priv, REG_SPS0_CTRL, sps0); +} + + +static void rtl8723a_stop_tx_beacon(struct rtl8xxxu_priv *priv) +{ + u8 val8; + + val8 = rtl8723au_read8(priv, REG_FWHW_TXQ_CTRL + 2); + val8 &= ~BIT(6); + val8 = 0x00; /* FIXME */ + rtl8723au_write8(priv, REG_FWHW_TXQ_CTRL + 2, val8); + + rtl8723au_write8(priv, REG_TBTT_PROHIBIT + 1, 0x64); + val8 = rtl8723au_read8(priv, REG_TBTT_PROHIBIT + 2); + val8 &= ~BIT(0); + val8 = 0x00; /* FIXME */ + rtl8723au_write8(priv, REG_TBTT_PROHIBIT + 2, val8); +} + + +/* + * The rtl8723a has 3 channel groups for it's efuse settings. It only + * supports the 2.4GHz band, so channels 1 - 14: + * group 0: channels 1 - 3 + * group 1: channels 4 - 9 + * group 2: channels 10 - 14 + * + * Note: We index from 0 in the code + */ +static int rtl8723a_channel_to_group(int channel) +{ + int group; + + if (channel < 4) + group = 0; + else if (channel < 10) + group = 1; + else + group = 2; + + return group; +} + +static void rtl8723au_config_channel(struct ieee80211_hw *hw) +{ + struct rtl8xxxu_priv *priv = hw->priv; + u32 val32, rsr; + u8 val8, opmode; + bool ht = true; + int sec_ch_above; + + val32 = rtl8723au_read_rfreg(priv, RF6052_REG_MODE_AG); + val32 &= ~MODE_AG_CHANNEL_MASK; + val32 |= hw->conf.chandef.chan->hw_value; + rtl8723au_write_rfreg(priv, RF6052_REG_MODE_AG, val32); + + opmode = rtl8723au_read8(priv, REG_BW_OPMODE); + rsr = rtl8723au_read32(priv, REG_RESPONSE_RATE_SET); + + switch (hw->conf.chandef.width) { + case NL80211_CHAN_WIDTH_20_NOHT: + ht = false; + case NL80211_CHAN_WIDTH_20: + opmode |= BW_OPMODE_20MHZ; + rtl8723au_write8(priv, REG_BW_OPMODE, opmode); + + val32 = rtl8723au_read32(priv, REG_FPGA0_RF_MODE); + val32 &= ~FPGA_RF_MODE; + rtl8723au_write32(priv, REG_FPGA0_RF_MODE, val32); + + val32 = rtl8723au_read32(priv, REG_FPGA1_RF_MODE); + val32 &= ~FPGA_RF_MODE; + rtl8723au_write32(priv, REG_FPGA1_RF_MODE, val32); + + val32 = rtl8723au_read32(priv, REG_FPGA0_ANALOG2); + val32 |= BIT(10); + rtl8723au_write32(priv, REG_FPGA0_ANALOG2, val32); + break; + case NL80211_CHAN_WIDTH_40: + if (hw->conf.chandef.center_freq1 > + hw->conf.chandef.chan->center_freq) + sec_ch_above = 1; + else + sec_ch_above = 0; + + opmode &= ~BW_OPMODE_20MHZ; + rtl8723au_write8(priv, REG_BW_OPMODE, opmode); + rsr &= ~RSR_RSC_BANDWIDTH_40M; + if (sec_ch_above) + rsr |= RSR_RSC_UPPER_SUB_CHANNEL; + else + rsr |= RSR_RSC_LOWER_SUB_CHANNEL; + rtl8723au_write32(priv, REG_RESPONSE_RATE_SET, rsr); + + val32 = rtl8723au_read32(priv, REG_FPGA0_RF_MODE); + val32 |= FPGA_RF_MODE; + rtl8723au_write32(priv, REG_FPGA0_RF_MODE, val32); + + val32 = rtl8723au_read32(priv, REG_FPGA1_RF_MODE); + val32 |= FPGA_RF_MODE; + rtl8723au_write32(priv, REG_FPGA1_RF_MODE, val32); + + /* Set Control channel to upper or lower. These settings + are required only for 40MHz */ + val32 = rtl8723au_read32(priv, REG_CCK0_SYSTEM); + val32 &= ~CCK0_SIDEBAND; + if (!sec_ch_above) + val32 |= CCK0_SIDEBAND; + rtl8723au_write32(priv, REG_CCK0_SYSTEM, val32); + + val32 = rtl8723au_read32(priv, REG_OFDM1_LSTF); + val32 &= ~(BIT(10) | BIT(11)); /* 0xc00 */ + if (sec_ch_above) + val32 |= BIT(10); + else + val32 |= BIT(11); + rtl8723au_write32(priv, REG_OFDM1_LSTF, val32); + + val32 = rtl8723au_read32(priv, REG_FPGA0_ANALOG2); + val32 &= ~BIT(10); + rtl8723au_write32(priv, REG_FPGA0_ANALOG2, val32); + + val32 = rtl8723au_read32(priv, REG_FPGA0_POWER_SAVE); + val32 &= ~(FPGA0_PS_LOWER_CHANNEL | FPGA0_PS_UPPER_CHANNEL); + if (sec_ch_above) + val32 |= FPGA0_PS_UPPER_CHANNEL; + else + val32 |= FPGA0_PS_LOWER_CHANNEL; + rtl8723au_write32(priv, REG_FPGA0_POWER_SAVE, val32); + break; + + default: + break; + } + + if (ht) + val8 = 0x0e; + else + val8 = 0x0a; + + rtl8723au_write8(priv, REG_SIFS_CCK + 1, val8); + rtl8723au_write8(priv, REG_SIFS_OFDM + 1, val8); + + rtl8723au_write16(priv, REG_R2T_SIFS, 0x0808); + rtl8723au_write16(priv, REG_T2T_SIFS, 0x0a0a); + + val32 = rtl8723au_read_rfreg(priv, RF6052_REG_MODE_AG); + if (hw->conf.chandef.width == NL80211_CHAN_WIDTH_40) + val32 &= ~MODE_AG_CHANNEL_20MHZ; + else + val32 |= MODE_AG_CHANNEL_20MHZ; + rtl8723au_write_rfreg(priv, RF6052_REG_MODE_AG, val32); +} + +static void +rtl8723a_set_tx_power(struct rtl8xxxu_priv *priv, int channel, bool ht40) +{ + struct rtl8723au_efuse *efuse; + u8 cck[RTL8723A_MAX_RF_PATHS], ofdm[RTL8723A_MAX_RF_PATHS]; + u8 ofdmbase[RTL8723A_MAX_RF_PATHS], mcsbase[RTL8723A_MAX_RF_PATHS]; + u32 val32, ofdm_a, ofdm_b, mcs_a, mcs_b; + u8 val8; + int group, i; + + efuse = &priv->efuse_wifi.efuse; + + group = rtl8723a_channel_to_group(channel); + + cck[0] = efuse->cck_tx_power_index_A[group]; + ofdm[0] = efuse->ht40_1s_tx_power_index_A[group]; + + if (priv->rf_paths > 1) { + cck[1] = efuse->cck_tx_power_index_B[group]; + ofdm[1] = efuse->ht40_1s_tx_power_index_B[group]; + } else { + cck[1] = 0; + ofdm[1] = 0; + } + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_CHANNEL) + pr_debug("%s: Setting TX power CCK A: %02x, " + "CCK B: %02x, OFDM A: %02x, OFDM B: %02x\n", + DRIVER_NAME, cck[0], cck[1], ofdm[0], ofdm[1]); + + for (i = 0; i < RTL8723A_MAX_RF_PATHS; i++) { + if (cck[i] > RF6052_MAX_TX_PWR) + cck[i] = RF6052_MAX_TX_PWR; + if (ofdm[i] > RF6052_MAX_TX_PWR) + ofdm[i] = RF6052_MAX_TX_PWR; + } + + val32 = rtl8723au_read32(priv, REG_TX_AGC_A_CCK1_MCS32); + val32 &= 0xffff00ff; + val32 |= (cck[0] << 8); + rtl8723au_write32(priv, REG_TX_AGC_A_CCK1_MCS32, val32); + + val32 = rtl8723au_read32(priv, REG_TX_AGC_B_CCK11_A_CCK2_11); + val32 &= 0xff; + val32 |= ((cck[0] << 8) | (cck[0] << 16) | (cck[0] << 24)); + rtl8723au_write32(priv, REG_TX_AGC_B_CCK11_A_CCK2_11, val32); + + val32 = rtl8723au_read32(priv, REG_TX_AGC_B_CCK11_A_CCK2_11); + val32 &= 0xffffff00; + val32 |= cck[1]; + rtl8723au_write32(priv, REG_TX_AGC_B_CCK11_A_CCK2_11, val32); + + val32 = rtl8723au_read32(priv, REG_TX_AGC_B_CCK1_55_MCS32); + val32 &= 0xff; + val32 |= ((cck[1] << 8) | (cck[1] << 16) | (cck[1] << 24)); + rtl8723au_write32(priv, REG_TX_AGC_B_CCK1_55_MCS32, val32); + + ofdmbase[0] = ofdm[0] + efuse->ofdm_tx_power_index_diff[group].a; + mcsbase[0] = ofdm[0]; + if (!ht40) + mcsbase[0] += efuse->ht20_tx_power_index_diff[group].a; + + ofdmbase[1] = ofdm[1] + efuse->ofdm_tx_power_index_diff[group].b; + mcsbase[1] = ofdm[1]; + if (!ht40) + mcsbase[1] += efuse->ht20_tx_power_index_diff[group].b; + + ofdm_a = ofdmbase[0] | ofdmbase[0] << 8 | + ofdmbase[0] << 16 | ofdmbase[0] <<24; + ofdm_b = ofdmbase[1] | ofdmbase[1] << 8 | + ofdmbase[1] << 16 | ofdmbase[1] <<24; + rtl8723au_write32(priv, REG_TX_AGC_A_RATE18_06, ofdm_a); + rtl8723au_write32(priv, REG_TX_AGC_B_RATE18_06, ofdm_b); + + rtl8723au_write32(priv, REG_TX_AGC_A_RATE54_24, ofdm_a); + rtl8723au_write32(priv, REG_TX_AGC_B_RATE54_24, ofdm_b); + + mcs_a = mcsbase[0] | mcsbase[0] << 8 | + mcsbase[0] << 16 | mcsbase[0] <<24; + mcs_b = mcsbase[1] | mcsbase[1] << 8 | + mcsbase[1] << 16 | mcsbase[1] <<24; + + rtl8723au_write32(priv, REG_TX_AGC_A_MCS03_MCS00, mcs_a); + rtl8723au_write32(priv, REG_TX_AGC_B_MCS03_MCS00, mcs_b); + + rtl8723au_write32(priv, REG_TX_AGC_A_MCS07_MCS04, mcs_a); + rtl8723au_write32(priv, REG_TX_AGC_B_MCS07_MCS04, mcs_b); + + rtl8723au_write32(priv, REG_TX_AGC_A_MCS11_MCS08, mcs_a); + rtl8723au_write32(priv, REG_TX_AGC_B_MCS11_MCS08, mcs_b); + + rtl8723au_write32(priv, REG_TX_AGC_A_MCS15_MCS12, mcs_a); + for (i = 0; i < 3; i++) { + if (i != 2) + val8 = (mcsbase[0] > 8) ? (mcsbase[0] - 8) : 0; + else + val8 = (mcsbase[0] > 6) ? (mcsbase[0] - 6) : 0; + rtl8723au_write8(priv, REG_OFDM0_XC_TX_IQ_IMBALANCE + i, val8); + } + rtl8723au_write32(priv, REG_TX_AGC_B_MCS15_MCS12, mcs_b); + for (i = 0; i < 3; i++) { + if (i != 2) + val8 = (mcsbase[1] > 8) ? (mcsbase[1] - 8) : 0; + else + val8 = (mcsbase[1] > 6) ? (mcsbase[1] - 6) : 0; + rtl8723au_write8(priv, REG_OFDM0_XD_TX_IQ_IMBALANCE + i, val8); + } +} + +static void rtl8xxxu_set_linktype(struct rtl8xxxu_priv *priv, + enum nl80211_iftype linktype) +{ + u16 val8; + + val8 = rtl8723au_read16(priv, REG_MSR); + val8 &= ~MSR_LINKTYPE_MASK; + + switch (linktype) { + case NL80211_IFTYPE_UNSPECIFIED: + val8 |= MSR_LINKTYPE_NONE; + break; + case NL80211_IFTYPE_ADHOC: + val8 |= MSR_LINKTYPE_ADHOC; + break; + case NL80211_IFTYPE_STATION: + val8 |= MSR_LINKTYPE_STATION; + break; + case NL80211_IFTYPE_AP: + val8 |= MSR_LINKTYPE_AP; + break; + default: + goto out; + } + + rtl8723au_write8(priv, REG_MSR, val8); +out: + return; +} + +static void +rtl8xxxu_set_retry(struct rtl8xxxu_priv *priv, u16 short_retry, u16 long_retry) +{ + u16 val16; + + val16 = ((short_retry << RETRY_LIMIT_SHORT_SHIFT) & + RETRY_LIMIT_SHORT_MASK) | + ((long_retry << RETRY_LIMIT_LONG_SHIFT) & + RETRY_LIMIT_LONG_MASK); + + rtl8723au_write16(priv, REG_RETRY_LIMIT, val16); +} + +static void +rtl8xxxu_set_spec_sifs(struct rtl8xxxu_priv *priv, u16 cck, u16 ofdm) +{ + u16 val16; + + val16 = ((cck << SPEC_SIFS_CCK_SHIFT) & SPEC_SIFS_CCK_MASK) | + ((ofdm << SPEC_SIFS_OFDM_SHIFT) & SPEC_SIFS_OFDM_MASK); + + rtl8723au_write16(priv, REG_SPEC_SIFS, val16); +} + +static void rtl8xxxu_8723au_identify_chip(struct rtl8xxxu_priv *priv) +{ + u32 val32; + u16 val16; + char *cut; + + val32 = rtl8723au_read32(priv, REG_SYS_CFG); + priv->chip_cut = (val32 & SYS_CFG_CHIP_VERSION_MASK) >> + SYS_CFG_CHIP_VERSION_SHIFT; + switch(priv->chip_cut) { + case 0: + cut = "A"; + break; + case 1: + cut = "B"; + break; + default: + cut = "unknown"; + } + + val32 = rtl8723au_read32(priv, REG_GPIO_OUTSTS); + priv->rom_rev = (val32 & GPIO_RF_RL_ID) >> 28; + + val32 = rtl8723au_read32(priv, REG_MULTI_FUNC_CTRL); + if (val32 & MULTI_WIFI_FUNC_EN) + priv->has_wifi = 1; + if (val32 & MULTI_BT_FUNC_EN) + priv->has_bluetooth = 1; + if (val32 & MULTI_GPS_FUNC_EN) + priv->has_gps = 1; + + if (val32 & SYS_CFG_VENDOR_ID) + priv->vendor_umc = 1; + + /* The rtl8192 presumably can have 2 */ + priv->rf_paths = 1; + + val16 = rtl8723au_read16(priv, REG_NORMAL_SIE_EP_TX); + if (val16 & NORMAL_SIE_EP_TX_HIGH_MASK) { + priv->ep_tx_high_queue = 1; + priv->ep_tx_count++; + } + + if (val16 & NORMAL_SIE_EP_TX_NORMAL_MASK) { + priv->ep_tx_normal_queue = 1; + priv->ep_tx_count++; + } + + if (val16 & NORMAL_SIE_EP_TX_LOW_MASK) { + priv->ep_tx_low_queue = 1; + priv->ep_tx_count++; + } + + pr_info("%s: RTL8723au rev %s, features: WiFi=%i, BT=%i, GPS=%i\n", + DRIVER_NAME, cut, priv->has_wifi, priv->has_bluetooth, + priv->has_gps); + + pr_debug("%s: RTL8723au number of TX queues: %i\n", + DRIVER_NAME, priv->ep_tx_count); +} + +static int +rtl8xxxu_read_efuse8(struct rtl8xxxu_priv *priv, u16 offset, u8 *data) +{ + int i; + u8 val8; + u32 val32; + + /* Write Address */ + rtl8723au_write8(priv, REG_EFUSE_CTRL + 1, offset & 0xff); + val8 = rtl8723au_read8(priv, REG_EFUSE_CTRL + 2); + val8 &= 0xfc; + val8 |= (offset >> 8) & 0x03; + rtl8723au_write8(priv, REG_EFUSE_CTRL + 2, val8); + + val8 = rtl8723au_read8(priv, REG_EFUSE_CTRL + 3); + rtl8723au_write8(priv, REG_EFUSE_CTRL + 3, val8 & 0x7f); + + /* Poll for data read */ + val32 = rtl8723au_read32(priv, REG_EFUSE_CTRL); + for (i = 0; i < RTL8XXXU_MAX_REG_POLL; i++) { + val32 = rtl8723au_read32(priv, REG_EFUSE_CTRL); + if (val32 & BIT(31)) + break; + } + + if (i == RTL8XXXU_MAX_REG_POLL) + return -EIO; + + udelay(50); + val32 = rtl8723au_read32(priv, REG_EFUSE_CTRL); + + *data = val32 & 0xff; + return 0; +} + +static int rtl8xxxu_read_efuse(struct rtl8xxxu_priv *priv) +{ + int i, ret = 0; + u8 val8, word_mask, header, extheader; + u16 val16, efuse_addr, offset; + u32 val32; + + val16 = rtl8723au_read16(priv, REG_9346CR); + if (val16 & EEPROM_ENABLE) + priv->has_eeprom = 1; + if (val16 & EEPROM_BOOT) + priv->boot_eeprom = 1; + + val32 = rtl8723au_read32(priv, REG_EFUSE_TEST); + val32 = (val32 & ~EFUSE_SELECT_MASK) | EFUSE_WIFI_SELECT; + rtl8723au_write32(priv, REG_EFUSE_TEST, val32); + + pr_debug("%s: Booting from %s\n", DRIVER_NAME, + priv->boot_eeprom ? "EEPROM" : "EFUSE"); + + rtl8723au_write8(priv, REG_EFUSE_ACCESS, EFUSE_ACCESS_ENABLE); + + /* 1.2V Power: From VDDON with Power Cut(0x0000[15]), default valid */ + val16 = rtl8723au_read16(priv, REG_SYS_ISO_CTRL); + if (!(val16 & SYS_ISO_PWC_EV12V)) { + val16 |= SYS_ISO_PWC_EV12V; + rtl8723au_write16(priv, REG_SYS_ISO_CTRL, val16); + } + /* Reset: 0x0000[28], default valid */ + val16 = rtl8723au_read16(priv, REG_SYS_FUNC); + if (!(val16 & SYS_FUNC_ELDR)) { + val16 |= SYS_FUNC_ELDR; + rtl8723au_write16(priv, REG_SYS_FUNC, val16); + } + + /* Clock: Gated(0x0008[5]) 8M(0x0008[1]) clock from ANA, + default valid */ + val16 = rtl8723au_read16(priv, REG_SYS_CLKR); + if (!(val16 & SYS_CLK_LOADER_ENABLE) || !(val16 & SYS_CLK_ANA8M)) { + val16 |= (SYS_CLK_LOADER_ENABLE | SYS_CLK_ANA8M); + rtl8723au_write16(priv, REG_SYS_CLKR, val16); + } + + /* Default value is 0xff */ + memset(priv->efuse_wifi.raw, 0xff, EFUSE_MAP_LEN_8723A); + + efuse_addr = 0; + while (efuse_addr < EFUSE_REAL_CONTENT_LEN_8723A) { + ret = rtl8xxxu_read_efuse8(priv, efuse_addr++, &header); + if (ret || header == 0xff) + goto exit; + + if ((header & 0x1f) == 0x0f) { /* extended header */ + offset = (header & 0xe0) >> 5; + + ret = rtl8xxxu_read_efuse8(priv, efuse_addr++, + &extheader); + if (ret) + goto exit; + /* All words disabled */ + if ((extheader & 0x0f) == 0x0f) + continue; + + offset |= ((extheader & 0xf0) >> 1); + word_mask = extheader & 0x0f; + } else { + offset = (header >> 4) & 0x0f; + word_mask = header & 0x0f; + } + + if (offset < EFUSE_MAX_SECTION_8723A) { + u16 map_addr; + /* Get word enable value from PG header */ + + /* We have 8 bits to indicate validity */ + map_addr = offset * 8; + if (map_addr >= EFUSE_MAP_LEN_8723A) { + pr_debug("%s: %s: Illegal map_addr (%04x), " + "efuse corrupt!\n", DRIVER_NAME, + __func__, map_addr); + ret = -EINVAL; + goto exit; + + ret = -EINVAL; + } + for (i = 0; i < EFUSE_MAX_WORD_UNIT; i++) { + /* Check word enable condition in the section */ + if (!(word_mask & BIT(i))) { + ret = rtl8xxxu_read_efuse8(priv, + efuse_addr++, + &val8); + priv->efuse_wifi.raw[map_addr++] = val8; + + ret = rtl8xxxu_read_efuse8(priv, + efuse_addr++, + &val8); + priv->efuse_wifi.raw[map_addr++] = val8; + } else + map_addr += 2; + } + } else { + pr_debug("%s: %s: Illegal offset (%04x), " + "efuse corrupt!\n", DRIVER_NAME, __func__, + offset); + ret = -EINVAL; + goto exit; + } + } + +exit: + rtl8723au_write8(priv, REG_EFUSE_ACCESS, EFUSE_ACCESS_DISABLE); + + if (priv->efuse_wifi.efuse.rtl_id != cpu_to_le16(0x8129)) + ret = EINVAL; + + return ret; +} + +static int rtl8xxxu_start_firmware(struct rtl8xxxu_priv *priv) +{ + int ret = 0, i; + u32 val32; + + /* Poll checksum report */ + for (i = 0; i < RTL8XXXU_FIRMWARE_POLL_MAX; i++) { + val32 = rtl8723au_read32(priv, REG_MCU_FW_DL); + if (val32 & MCU_FW_DL_CSUM_REPORT) + break; + } + + if (i == RTL8XXXU_FIRMWARE_POLL_MAX) { + pr_warn("%s: Firmware checksum poll timed out\n", DRIVER_NAME); + ret = -EAGAIN; + goto exit; + } + + val32 = rtl8723au_read32(priv, REG_MCU_FW_DL); + val32 |= MCU_FW_DL_READY; + val32 &= ~MCU_WINT_INIT_READY; + rtl8723au_write32(priv, REG_MCU_FW_DL, val32); + + /* Wait for firmware to become ready */ + for (i = 0; i < RTL8XXXU_FIRMWARE_POLL_MAX; i++) { + val32 = rtl8723au_read32(priv, REG_MCU_FW_DL); + if (val32 & MCU_WINT_INIT_READY) + break; + + udelay(100); + } + + if (i == RTL8XXXU_FIRMWARE_POLL_MAX) { + pr_warn("%s: Firmware failed to start\n", DRIVER_NAME); + ret = -EAGAIN; + goto exit; + } + +exit: + return ret; +} + +static int rtl8xxxu_download_firmware(struct rtl8xxxu_priv *priv) +{ + int pages, remainder, i, ret; + u8 val8; + u16 val16; + u32 val32; + u8 *fwptr; + + val8 = rtl8723au_read8(priv, REG_SYS_FUNC + 1); + val8 |= 4; + rtl8723au_write8(priv, REG_SYS_FUNC + 1, val8); + + /* 8051 enable */ + val16 = rtl8723au_read16(priv, REG_SYS_FUNC); + rtl8723au_write16(priv, REG_SYS_FUNC, val16 | SYS_FUNC_CPU_ENABLE); + + /* MCU firmware download enable */ + val8 = rtl8723au_read8(priv, REG_MCU_FW_DL); + rtl8723au_write8(priv, REG_MCU_FW_DL, val8 | MCU_FW_DL_ENABLE); + + /* 8051 reset */ + val32 = rtl8723au_read32(priv, REG_MCU_FW_DL); + rtl8723au_write32(priv, REG_MCU_FW_DL, val32 & ~BIT(19)); + + /* Reset firmware download checksum */ + val8 = rtl8723au_read8(priv, REG_MCU_FW_DL); + rtl8723au_write8(priv, REG_MCU_FW_DL, val8 | MCU_FW_DL_CSUM_REPORT); + + pages = priv->fw_size / RTL_FW_PAGE_SIZE; + remainder = priv->fw_size % RTL_FW_PAGE_SIZE; + + fwptr = priv->fw_data->data; + + for (i = 0; i < pages; i++) { + val8 = rtl8723au_read8(priv, REG_MCU_FW_DL + 2) & 0xF8; + rtl8723au_write8(priv, REG_MCU_FW_DL + 2, val8 | i); + + ret = rtl8723au_writeN(priv, REG_8723A_FW_START_ADDRESS, + fwptr, RTL_FW_PAGE_SIZE); + if (ret != RTL_FW_PAGE_SIZE) { + ret = -EAGAIN; + goto fw_abort; + } + + fwptr += RTL_FW_PAGE_SIZE; + } + + if (remainder) { + val8 = rtl8723au_read8(priv, REG_MCU_FW_DL + 2) & 0xF8; + rtl8723au_write8(priv, REG_MCU_FW_DL + 2, val8 | i); + ret = rtl8723au_writeN(priv, REG_8723A_FW_START_ADDRESS, + fwptr, remainder); + if (ret != remainder) { + ret = -EAGAIN; + goto fw_abort; + } + + } + + ret = 0; +fw_abort: + /* MCU firmware download disable */ + val16 = rtl8723au_read16(priv, REG_MCU_FW_DL); + rtl8723au_write16(priv, REG_MCU_FW_DL, + val16 & (~MCU_FW_DL_ENABLE & 0xff)); + + return ret; +} + +static int rtl8xxxu_load_firmware(struct rtl8xxxu_priv *priv) +{ + const struct firmware *fw; + char *fw_name; + int ret = 0; + u16 signature; + + switch(priv->chip_cut) { + case 0: + fw_name = "rtlwifi/rtl8723aufw_A.bin"; + break; + case 1: + if (priv->enable_bluetooth) + fw_name = "rtlwifi/rtl8723aufw_B.bin"; + else + fw_name = "rtlwifi/rtl8723aufw_B_NoBT.bin"; + + break; + default: + return -EINVAL; + } + + pr_debug("%s: Loading firmware %s\n", DRIVER_NAME, fw_name); + if (request_firmware(&fw, fw_name, &priv->udev->dev)) { + pr_warn("%s: request_firmware(%s) failed\n", + DRIVER_NAME, fw_name); + ret = -EAGAIN; + goto exit; + } + if (!fw) { + pr_warn("%s: Firmware data not available\n", DRIVER_NAME); + ret = -EINVAL; + goto exit; + } + + priv->fw_data = kmemdup(fw->data, fw->size, GFP_KERNEL); + priv->fw_size = fw->size - sizeof(struct rtl8xxxu_firmware_header); + + signature = le16_to_cpu(priv->fw_data->signature); + switch(signature & 0xfff0) { + case 0x92c0: + case 0x88c0: + case 0x2300: + break; + default: + ret = -EINVAL; + pr_debug("%s: Invalid firmware signature: 0x%04x\n", + DRIVER_NAME, signature); + } + + pr_debug("%s: Firmware revision %i.%i (signature 0x%04x)\n", + DRIVER_NAME, le16_to_cpu(priv->fw_data->major_version), + priv->fw_data->minor_version, signature); + +exit: + release_firmware(fw); + return ret; +} + +static void rtl8xxxu_firmware_self_reset(struct rtl8xxxu_priv *priv) +{ + u16 val16; + int i = 100; + + /* Inform 8051 to perform reset */ + rtl8723au_write8(priv, REG_HMTFR + 3, 0x20); + + for (i = 100; i > 0; i--) { + val16 = rtl8723au_read16(priv, REG_SYS_FUNC); + + if (!(val16 & SYS_FUNC_CPU_ENABLE)) { + pr_debug("%s: Firmware self reset success!\n", + __func__); + break; + } + udelay(50); + } + + if (!i) { + /* Force firmware reset */ + val16 = rtl8723au_read16(priv, REG_SYS_FUNC); + val16 &= ~SYS_FUNC_CPU_ENABLE; + rtl8723au_write16(priv, REG_SYS_FUNC, val16); + } +} + +static int +rtl8xxxu_init_mac(struct rtl8xxxu_priv *priv, struct rtl8xxxu_reg8val *array) +{ + int i, ret; + u16 reg; + u8 val; + + for (i = 0; ; i++) { + reg = array[i].reg; + val = array[i].val; + + if (reg == 0xffff && val == 0xff) + break; + + ret = rtl8723au_write8(priv, reg, val); + if (ret != 1) { + pr_warn("%s: Failed to initialize MAC\n", DRIVER_NAME); + return -EAGAIN; + } + } + + rtl8723au_write8(priv, REG_MAX_AGGR_NUM, 0x0a); + + return 0; +} + +static int rtl8xxxu_init_phy_regs(struct rtl8xxxu_priv *priv, + struct rtl8xxxu_reg32val *array) +{ + int i, ret; + u16 reg; + u32 val; + + for (i = 0; ; i++) { + reg = array[i].reg; + val = array[i].val; + + if (reg == 0xffff && val == 0xffffffff) + break; + + ret = rtl8723au_write32(priv, reg, val); + if (ret != sizeof(val)) { + pr_warn("%s: Failed to initialize PHY\n", DRIVER_NAME); + return -EAGAIN; + } + udelay(1); + } + + return 0; +} + +/* + * Most of this is black magic retrieved from the old rtl8723au driver + */ +static int rtl8xxxu_init_phy_bb(struct rtl8xxxu_priv *priv) +{ + u8 val8, ldoa15, ldov12d, lpldo, ldohci12; + u32 val32; + + /* + * Todo: The vendor driver maintains a table of PHY register + * addresses, which is initialized here. Do we need this? + */ + + val8 = rtl8723au_read8(priv, REG_AFE_PLL_CTRL); + udelay(2); + val8 |= AFE_PLL_320_ENABLE; + rtl8723au_write8(priv, REG_AFE_PLL_CTRL, val8); + udelay(2); + + rtl8723au_write8(priv, REG_AFE_PLL_CTRL + 1, 0xff); + udelay(2); + + val8 = rtl8723au_read8(priv, REG_SYS_FUNC); + val8 |= SYS_FUNC_BB_GLB_RSTN | SYS_FUNC_BBRSTB; + rtl8723au_write8(priv, REG_SYS_FUNC, val8); + + /* AFE_XTAL_RF_GATE (bit 14) if addressing as 32 bit register */ + val8 = rtl8723au_read8(priv, REG_AFE_XTAL_CTRL + 1); + val8 &= ~BIT(6); + rtl8723au_write8(priv, REG_AFE_XTAL_CTRL + 1, val8); + + /* AFE_XTAL_BT_GATE (bit 20) if addressing as 32 bit register */ + val8 = rtl8723au_read8(priv, REG_AFE_XTAL_CTRL + 2); + val8 &= ~BIT(4); + rtl8723au_write8(priv, REG_AFE_XTAL_CTRL + 2, val8); + + /* 6. 0x1f[7:0] = 0x07 */ + val8 = RF_ENABLE | RF_RSTB | RF_SDMRSTB; + rtl8723au_write8(priv, REG_RF_CTRL, val8); + + rtl8xxxu_init_phy_regs(priv, rtl8723a_phy_1t_init_table); + + rtl8xxxu_init_phy_regs(priv, rtl8723a_agc_1t_init_table); + if (priv->efuse_wifi.efuse.version >= 0x01) { + val32 = rtl8723au_read32(priv, REG_MAC_PHY_CTRL); + + val8 = priv->efuse_wifi.efuse.xtal_k & 0x3f; + val32 &= 0xff000fff; + val32 |= ((val8 | (val8 << 6)) << 12); + + rtl8723au_write32(priv, REG_MAC_PHY_CTRL, val32); + } + + ldoa15 = LDOA15_ENABLE | LDOA15_OBUF; + ldov12d = LDOV12D_ENABLE | BIT(2) | (2 << LDOV12D_VADJ_SHIFT); + ldohci12 = 0x57; + lpldo = 1; + val32 = (lpldo << 24) | (ldohci12 << 16) | (ldov12d << 8)| ldoa15; + + rtl8723au_write32(priv, REG_LDOA15_CTRL, val32); + + return 0; +} + +static int rtl8xxxu_init_rf_regs(struct rtl8xxxu_priv *priv, + struct rtl8xxxu_rfregval *array) +{ + int i, ret; + u8 reg; + u32 val; + + for (i = 0; ; i++) { + reg = array[i].reg; + val = array[i].val; + + if (reg == 0xff && val == 0xffffffff) + break; + + switch(reg) { + case 0xfe: + msleep(50); + continue; + case 0xfd: + mdelay(5); + continue; + case 0xfc: + mdelay(1); + continue; + case 0xfb: + udelay(50); + continue; + case 0xfa: + udelay(5); + continue; + case 0xf9: + udelay(1); + continue; + } + + reg &= 0x3f; + + ret = rtl8723au_write_rfreg(priv, reg, val); + if (ret) { + pr_warn("%s: Failed to initialize RF\n", DRIVER_NAME); + return -EAGAIN; + } + udelay(1); + } + + return 0; +} + +static int rtl8xxxu_init_phy_rf(struct rtl8xxxu_priv *priv) +{ + u32 val32; + u16 val16, rfsi_rfenv; + + /* For path B, use XB */ + rfsi_rfenv = rtl8723au_read16(priv, REG_FPGA0_XA_RF_SW_CTRL); + rfsi_rfenv &= FPGA0_RF_RFENV; + + /* + * These two we might be able to optimize into one + */ + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_RF_INT_OE); + val32 |= BIT(20); /* 0x10 << 16 */ + rtl8723au_write32(priv, REG_FPGA0_XA_RF_INT_OE, val32); + udelay(1); + + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_RF_INT_OE); + val32 |= BIT(4); + rtl8723au_write32(priv, REG_FPGA0_XA_RF_INT_OE, val32); + udelay(1); + + /* + * These two we might be able to optimize into one + */ + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_HSSI_PARM2); + val32 &= ~FPGA0_HSSI_3WIRE_ADDR_LEN; + rtl8723au_write32(priv, REG_FPGA0_XA_HSSI_PARM2, val32); + udelay(1); + + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_HSSI_PARM2); + val32 &= ~FPGA0_HSSI_3WIRE_DATA_LEN; + rtl8723au_write32(priv, REG_FPGA0_XA_HSSI_PARM2, val32); + udelay(1); + + rtl8xxxu_init_rf_regs(priv, rtl8723au_radioa_rf6052_1t_init_table); + + /* For path B, use XB */ + val16 = rtl8723au_read16(priv, REG_FPGA0_XA_RF_SW_CTRL); + val16 &= ~FPGA0_RF_RFENV; + val16 |= rfsi_rfenv; + rtl8723au_write16(priv, REG_FPGA0_XA_RF_SW_CTRL, val16); + + return 0; +} + +static int rtl8xxxu_llt_write(struct rtl8xxxu_priv *priv, u8 address, u8 data) +{ + int ret = -EBUSY; + int count = 0; + u32 value; + + value = LLT_OP_WRITE | address << 8 | data; + + rtl8723au_write32(priv, REG_LLT_INIT, value); + + do { + value = rtl8723au_read32(priv, REG_LLT_INIT); + if ((value & LLT_OP_MASK) == LLT_OP_INACTIVE) { + ret = 0; + break; + } + } while (count++ < 20); + + return ret; +} + +static int rtl8xxxu_init_llt_table(struct rtl8xxxu_priv *priv, u8 last_tx_page) +{ + int ret; + int i; + + for (i = 0; i < last_tx_page; i++) { + ret = rtl8xxxu_llt_write(priv, i, i + 1); + if (ret) + goto exit; + } + + ret = rtl8xxxu_llt_write(priv, last_tx_page, 0xff); + if (ret) + goto exit; + + /* Mark remaining pages as a ring buffer */ + for (i = last_tx_page + 1; i < 0xff; i++) { + ret = rtl8xxxu_llt_write(priv, i, (i + 1)); + if (ret) + goto exit; + } + + /* Let last entry point to the start entry of ring buffer */ + ret = rtl8xxxu_llt_write(priv, 0xff, last_tx_page + 1); + if (ret) + goto exit; + +exit: + return ret; +} + +static int rtl8xxxu_init_queue_priority(struct rtl8xxxu_priv *priv) +{ + u16 val16, hi, lo; + u16 hiq, mgq, bkq, beq, viq, voq; + int hip, mgp, bkp, bep, vip, vop; + int ret = 0; + + switch(priv->ep_tx_count) { + case 1: + if (priv->ep_tx_high_queue) { + hi = TRXDMA_QUEUE_HIGH; + } else if (priv->ep_tx_low_queue) { + hi = TRXDMA_QUEUE_LOW; + } else if (priv->ep_tx_normal_queue) { + hi = TRXDMA_QUEUE_NORMAL; + } else { + hi = 0; + ret = -EINVAL; + } + + hiq = hi; + mgq = hi; + bkq = hi; + beq = hi; + viq = hi; + voq = hi; + + hip = 0; + mgp = 0; + bkp = 0; + bep = 0; + vip = 0; + vop = 0; + break; + case 2: + if (priv->ep_tx_high_queue && priv->ep_tx_low_queue) { + hi = TRXDMA_QUEUE_HIGH; + lo = TRXDMA_QUEUE_LOW; + } else if (priv->ep_tx_normal_queue && priv->ep_tx_low_queue) { + hi = TRXDMA_QUEUE_NORMAL; + lo = TRXDMA_QUEUE_LOW; + } else if (priv->ep_tx_high_queue && priv->ep_tx_normal_queue) { + hi = TRXDMA_QUEUE_HIGH; + lo = TRXDMA_QUEUE_NORMAL; + } else { + ret = -EINVAL; + hi = 0; + lo = 0; + } + + hiq = hi; + mgq = hi; + bkq = lo; + beq = lo; + viq = hi; + voq = hi; + + hip = 0; + mgp = 0; + bkp = 1; + bep = 1; + vip = 0; + vop = 0; + break; + case 3: + beq = TRXDMA_QUEUE_LOW; + bkq = TRXDMA_QUEUE_LOW; + viq = TRXDMA_QUEUE_NORMAL; + voq = TRXDMA_QUEUE_HIGH; + mgq = TRXDMA_QUEUE_HIGH; + hiq = TRXDMA_QUEUE_HIGH; + + hip = hiq ^ 3; + mgp = mgq ^ 3; + bkp = bkq ^ 3; + bep = beq ^ 3; + vip = viq ^ 3; + vop = viq ^ 3; + break; + default: + ret = -EINVAL; + } + + /* + * None of the vendor drivers are configuring the beacon + * queue here .... why? + */ + if (!ret) { + val16 = rtl8723au_read16(priv, REG_TRXDMA_CTRL); + val16 &= 0x7; + val16 |= (voq << TRXDMA_CTRL_VOQ_SHIFT) | + (viq << TRXDMA_CTRL_VIQ_SHIFT) | + (beq << TRXDMA_CTRL_BEQ_SHIFT) | + (bkq << TRXDMA_CTRL_BKQ_SHIFT) | + (mgq << TRXDMA_CTRL_MGQ_SHIFT) | + (hiq << TRXDMA_CTRL_HIQ_SHIFT); + rtl8723au_write16(priv, REG_TRXDMA_CTRL, val16); + + priv->pipe_out[TXDESC_QUEUE_VO] = + usb_sndbulkpipe(priv->udev, priv->out_ep[vop]); + priv->pipe_out[TXDESC_QUEUE_VI] = + usb_sndbulkpipe(priv->udev, priv->out_ep[vip]); + priv->pipe_out[TXDESC_QUEUE_BE] = + usb_sndbulkpipe(priv->udev, priv->out_ep[bep]); + priv->pipe_out[TXDESC_QUEUE_BK] = + usb_sndbulkpipe(priv->udev, priv->out_ep[bkp]); + priv->pipe_out[TXDESC_QUEUE_BEACON] = + usb_sndbulkpipe(priv->udev, priv->out_ep[0]); + priv->pipe_out[TXDESC_QUEUE_MGNT] = + usb_sndbulkpipe(priv->udev, priv->out_ep[mgp]); + priv->pipe_out[TXDESC_QUEUE_HIGH] = + usb_sndbulkpipe(priv->udev, priv->out_ep[hip]); + priv->pipe_out[TXDESC_QUEUE_CMD] = + usb_sndbulkpipe(priv->udev, priv->out_ep[0]); + } + + return ret; +} + +static void rtl8xxxu_fill_iqk_matrix_a(struct rtl8xxxu_priv *priv, + bool iqk_ok, int result[][8], + int candidate, bool tx_only) +{ + u32 oldval, x, tx0_a, reg; + int y, tx0_c; + u32 val32; + + if (!iqk_ok) + return; + + val32 = rtl8723au_read32(priv, REG_OFDM0_XA_TX_IQ_IMBALANCE); + oldval = val32 >> 22; + + x = result[candidate][0]; + if ((x & 0x00000200) != 0) + x = x | 0xfffffc00; + tx0_a = (x * oldval) >> 8; + + val32 = rtl8723au_read32(priv, REG_OFDM0_XA_TX_IQ_IMBALANCE); + val32 &= ~0x3ff; + val32 |= tx0_a; + rtl8723au_write32(priv, REG_OFDM0_XA_TX_IQ_IMBALANCE, val32); + + val32 = rtl8723au_read32(priv, REG_OFDM0_ENERGY_CCA_THRES); + val32 &= ~BIT(31); + if ((x * oldval >> 7) & 0x1) + val32 |= BIT(31); + rtl8723au_write32(priv, REG_OFDM0_ENERGY_CCA_THRES, val32); + + y = result[candidate][1]; + if ((y & 0x00000200) != 0) + y = y | 0xfffffc00; + tx0_c = (y * oldval) >> 8; + + val32 = rtl8723au_read32(priv, REG_OFDM0_XC_TX_AFE); + val32 &= ~0xf0000000; + val32 |= (((tx0_c & 0x3c0) >> 6) << 28); + rtl8723au_write32(priv, REG_OFDM0_XC_TX_AFE, val32); + + val32 = rtl8723au_read32(priv, REG_OFDM0_XA_TX_IQ_IMBALANCE); + val32 &= ~0x003f0000; + val32 |= ((tx0_c & 0x3f) << 16); + rtl8723au_write32(priv, REG_OFDM0_XA_TX_IQ_IMBALANCE, val32); + + val32 = rtl8723au_read32(priv, REG_OFDM0_ENERGY_CCA_THRES); + val32 &= ~BIT(29); + if ((y * oldval >> 7) & 0x1) + val32 |= BIT(29); + rtl8723au_write32(priv, REG_OFDM0_ENERGY_CCA_THRES, val32); + + if (tx_only) { + pr_debug("%s: only TX\n", __func__); + return; + } + + reg = result[candidate][2]; + + val32 = rtl8723au_read32(priv, REG_OFDM0_XA_RX_IQ_IMBALANCE); + val32 &= ~0x3ff; + val32 |= (reg & 0x3ff); + rtl8723au_write32(priv, REG_OFDM0_XA_RX_IQ_IMBALANCE, val32); + + reg = result[candidate][3] & 0x3F; + + val32 = rtl8723au_read32(priv, REG_OFDM0_XA_RX_IQ_IMBALANCE); + val32 &= ~0xfc00; + val32 |= ((reg << 10) & 0xfc00); + rtl8723au_write32(priv, REG_OFDM0_XA_RX_IQ_IMBALANCE, val32); + + reg = (result[candidate][3] >> 6) & 0xF; + + val32 = rtl8723au_read32(priv, REG_OFDM0_RX_IQ_EXT_ANTA); + val32 &= ~0xf0000000; + val32 |= (reg << 28); + rtl8723au_write32(priv, REG_OFDM0_RX_IQ_EXT_ANTA, val32); +} + +#define MAX_TOLERANCE 5 + +static bool rtl8xxxu_simularity_compare(struct rtl8xxxu_priv *priv, + int result[][8], int c1, int c2) +{ + u32 i, j, diff, simubitmap, bound = 0; + int candidate[2] = {-1, -1}; /* for path A and path B */ + bool retval = true, is_2t = false; + + if (is_2t) + bound = 8; + else + bound = 4; + + simubitmap = 0; + + for (i = 0; i < bound; i++) { + diff = (result[c1][i] > result[c2][i]) ? + (result[c1][i] - result[c2][i]) : + (result[c2][i] - result[c1][i]); + if (diff > MAX_TOLERANCE) { + if ((i == 2 || i == 6) && !simubitmap) { + if (result[c1][i] + result[c1][i + 1] == 0) + candidate[(i / 4)] = c2; + else if (result[c2][i] + result[c2][i + 1] == 0) + candidate[(i / 4)] = c1; + else + simubitmap = simubitmap | (1 << i); + } else { + simubitmap = simubitmap | (1 << i); + } + } + } + + if (simubitmap == 0) { + for (i = 0; i < (bound / 4); i++) { + if (candidate[i] >= 0) { + for (j = i * 4; j < (i + 1) * 4 - 2; j++) + result[3][j] = result[candidate[i]][j]; + retval = false; + } + } + return retval; + } else if (!(simubitmap & 0x0f)) { + /* path A OK */ + for (i = 0; i < 4; i++) + result[3][i] = result[c1][i]; + } else if (!(simubitmap & 0xf0) && is_2t) { + /* path B OK */ + for (i = 4; i < 8; i++) + result[3][i] = result[c1][i]; + } + + return false; +} + +static void +rtl8xxxu_save_mac_regs(struct rtl8xxxu_priv *priv, u32 *reg, u32 *backup) +{ + int i; + + for (i = 0; i < (RTL8XXXU_MAC_REGS - 1); i++) { + backup[i] = rtl8723au_read8(priv, reg[i]); + } + backup[i] = rtl8723au_read32(priv, reg[i]); +} + +static void +rtl8xxxu_restore_mac_regs(struct rtl8xxxu_priv *priv, u32 *reg, u32 *backup) +{ + int i; + + for (i = 0; i < (RTL8XXXU_MAC_REGS - 1); i++) { + rtl8723au_write8(priv, reg[i], backup[i]); + } + rtl8723au_write32(priv, reg[i], backup[i]); +} + +static void rtl8xxxu_save_regs(struct rtl8xxxu_priv *priv, u32 *regs, + u32 *backup, int count) +{ + int i; + + for (i = 0; i < count; i++) + backup[i] = rtl8723au_read32(priv, regs[i]); +} + +static void rtl8xxxu_restore_regs(struct rtl8xxxu_priv *priv, u32 *regs, + u32 *backup, int count) +{ + int i; + + for (i = 0; i < count; i++) + rtl8723au_write32(priv, regs[i], backup[i]); +} + + +static void rtl8xxxu_path_adda_on(struct rtl8xxxu_priv *priv, u32 *regs, + bool path_a_on, bool is_2t) +{ + u32 path_on; + int i; + + path_on = path_a_on ? 0x04db25a4 : 0x0b1b25a4; + if (!is_2t) { + path_on = 0x0bdb25a0; + rtl8723au_write32(priv, regs[0], 0x0b1b25a0); + } else { + rtl8723au_write32(priv, regs[0], path_on); + } + + for (i = 1 ; i < RTL8XXXU_ADDA_REGS ; i++) + rtl8723au_write32(priv, regs[i], path_on); +} + +static void +rtl8xxxu_mac_calibration(struct rtl8xxxu_priv *priv, u32 *regs, u32 *backup) +{ + int i = 0; + + rtl8723au_write8(priv, regs[i], 0x3f); + + for (i = 1 ; i < (RTL8XXXU_MAC_REGS - 1); i++) { + rtl8723au_write8(priv, regs[i], + (u8)(backup[i] & ~BIT(3))); + } + rtl8723au_write8(priv, regs[i], (u8)(backup[i] & ~BIT(5))); +} + +static int rtl8xxxu_iqk_path_a(struct rtl8xxxu_priv *priv, bool configpathb) +{ + u32 regEAC, regE94, regE9C, regEA4; + int result = 0; + + /* path-A IQK setting */ + rtl8723au_write32(priv, REG_TX_IQK_TONE_A, 0x10008c1f); + rtl8723au_write32(priv, REG_RX_IQK_TONE_A, 0x10008c1f); + rtl8723au_write32(priv, REG_TX_IQK_PI_A, 0x82140102); + + rtl8723au_write32(priv, REG_RX_IQK_PI_A, configpathb ? 0x28160202 : + /*IS_81xxC_VENDOR_UMC_B_CUT(pHalData->VersionID)?0x28160202: */ 0x28160502); + + /* path-B IQK setting */ + if (configpathb) { + rtl8723au_write32(priv, REG_TX_IQK_TONE_B, 0x10008c22); + rtl8723au_write32(priv, REG_RX_IQK_TONE_B, 0x10008c22); + rtl8723au_write32(priv, REG_TX_IQK_PI_B, 0x82140102); + rtl8723au_write32(priv, REG_RX_IQK_PI_B, 0x28160202); + } + + /* LO calibration setting */ + rtl8723au_write32(priv, REG_IQK_AGC_RSP, 0x001028d1); + + /* One shot, path A LOK & IQK */ + rtl8723au_write32(priv, REG_IQK_AGC_PTS, 0xf9000000); + rtl8723au_write32(priv, REG_IQK_AGC_PTS, 0xf8000000); + + mdelay(1); + + /* Check failed */ + regEAC = rtl8723au_read32(priv, REG_RX_POWER_AFTER_IQK_A_2); + regE94 = rtl8723au_read32(priv, REG_TX_POWER_BEFORE_IQK_A); + regE9C = rtl8723au_read32(priv, REG_TX_POWER_AFTER_IQK_A); + regEA4 = rtl8723au_read32(priv, REG_RX_POWER_BEFORE_IQK_A_2); + + if (!(regEAC & BIT(28)) && + ((regE94 & 0x03ff0000) != 0x01420000) && + ((regE9C & 0x03ff0000) != 0x00420000)) + result |= 0x01; + else /* If TX not OK, ignore RX */ + return result; + + /* If TX is OK, check whether RX is OK */ + if (!(regEAC & BIT(27)) && + ((regEA4 & 0x03ff0000) != 0x01320000) && + ((regEAC & 0x03ff0000) != 0x00360000)) + result |= 0x02; + else + pr_warn("%s: Path A Rx IQK fail!\n", __func__); + return result; +} + +static void rtl8xxxu_phy_iqcalibrate(struct rtl8xxxu_priv *priv, + int result[][8], int t, bool is_2t) +{ + u32 i, val32; + int path_a_ok /*, path_b_ok */; + int retry = 2; + + u32 ADDA_REG[RTL8XXXU_ADDA_REGS] = { + REG_FPGA0_XCD_SWITCH_CTRL, REG_BLUETOOTH, + REG_RX_WAIT_CCA, REG_TX_CCK_RFON, + REG_TX_CCK_BBON, REG_TX_OFDM_RFON, + REG_TX_OFDM_BBON, REG_TX_TO_RX, + REG_TX_TO_TX, REG_RX_CCK, + REG_RX_OFDM, REG_RX_WAIT_RIFS, + REG_RX_TO_RX, REG_STANDBY, + REG_SLEEP, REG_PMPD_ANAEN + }; + + u32 IQK_MAC_REG[RTL8XXXU_MAC_REGS] = { + REG_TXPAUSE, REG_BEACON_CTRL, + REG_BEACON_CTRL_1, REG_GPIO_MUXCFG + }; + + u32 IQK_BB_REG_92C[RTL8XXXU_BB_REGS] = { + REG_OFDM0_TRX_PATH_ENABLE, REG_OFDM0_TR_MUX_PAR, + REG_FPGA0_XCD_RF_SW_CTRL, REG_CONFIG_ANT_A, REG_CONFIG_ANT_B, + REG_FPGA0_XAB_RF_SW_CTRL, REG_FPGA0_XA_RF_INT_OE, + REG_FPGA0_XB_RF_INT_OE, REG_FPGA0_RF_MODE + }; + + /* Note: IQ calibration must be performed after loading */ + /* PHY_REG.txt , and radio_a, radio_b.txt */ + + if (t == 0) { + /* Save ADDA parameters, turn Path A ADDA on */ + rtl8xxxu_save_regs(priv, ADDA_REG, priv->adda_backup, + RTL8XXXU_ADDA_REGS); + rtl8xxxu_save_mac_regs(priv, IQK_MAC_REG, priv->mac_backup); + rtl8xxxu_save_regs(priv, IQK_BB_REG_92C, + priv->bb_backup, RTL8XXXU_BB_REGS); + } + + rtl8xxxu_path_adda_on(priv, ADDA_REG, true, is_2t); + + if (t == 0) { + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_HSSI_PARM1); + if (val32 & FPGA0_HSSI_PARM1_PI) + priv->pi_enabled = 1; + } + + if (!priv->pi_enabled) { + /* Switch BB to PI mode to do IQ Calibration. */ + rtl8723au_write32(priv, REG_FPGA0_XA_HSSI_PARM1, + 0x01000100); + rtl8723au_write32(priv, REG_FPGA0_XB_HSSI_PARM1, + 0x01000100); + } + + val32 = rtl8723au_read32(priv, REG_FPGA0_RF_MODE); + val32 &= ~FPGA_RF_MODE_CCK; + rtl8723au_write32(priv, REG_FPGA0_RF_MODE, val32); + + rtl8723au_write32(priv, REG_OFDM0_TRX_PATH_ENABLE, 0x03a05600); + rtl8723au_write32(priv, REG_OFDM0_TR_MUX_PAR, 0x000800e4); + rtl8723au_write32(priv, REG_FPGA0_XCD_RF_SW_CTRL, 0x22204000); + + val32 = rtl8723au_read32(priv, REG_FPGA0_XAB_RF_SW_CTRL); + val32 |= (BIT(10) | BIT(26)); + rtl8723au_write32(priv, REG_FPGA0_XAB_RF_SW_CTRL, val32); + + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_RF_INT_OE); + val32 &= ~BIT(10); + rtl8723au_write32(priv, REG_FPGA0_XA_RF_INT_OE, val32); + val32 = rtl8723au_read32(priv, REG_FPGA0_XB_RF_INT_OE); + val32 &= ~BIT(10); + rtl8723au_write32(priv, REG_FPGA0_XB_RF_INT_OE, val32); + + if (is_2t) { + rtl8723au_write32(priv, REG_FPGA0_XA_LSSI_PARM, 0x00010000); + rtl8723au_write32(priv, REG_FPGA0_XB_LSSI_PARM, 0x00010000); + } + + /* MAC settings */ + rtl8xxxu_mac_calibration(priv, IQK_MAC_REG, priv->mac_backup); + + /* Page B init */ + rtl8723au_write32(priv, REG_CONFIG_ANT_A, 0x00080000); + + if (is_2t) + rtl8723au_write32(priv, REG_CONFIG_ANT_B, 0x00080000); + + /* IQ calibration setting */ + rtl8723au_write32(priv, REG_FPGA0_IQK, 0x80800000); + rtl8723au_write32(priv, REG_TX_IQK, 0x01007c00); + rtl8723au_write32(priv, REG_RX_IQK, 0x01004800); + + for (i = 0; i < retry; i++) { + path_a_ok = rtl8xxxu_iqk_path_a(priv, is_2t); + if (path_a_ok == 0x03) { + val32 = rtl8723au_read32(priv, + REG_TX_POWER_BEFORE_IQK_A); + result[t][0] = (val32 >> 16) & 0x3ff; + val32 = rtl8723au_read32(priv, + REG_TX_POWER_AFTER_IQK_A); + result[t][1] = (val32 >> 16) & 0x3ff; + val32 = rtl8723au_read32(priv, + REG_RX_POWER_BEFORE_IQK_A_2); + result[t][2] = (val32 >> 16) & 0x3ff; + val32 = rtl8723au_read32(priv, + REG_RX_POWER_AFTER_IQK_A_2); + result[t][3] = (val32 >> 16) & 0x3ff; + break; + } else if (i == (retry - 1) && path_a_ok == 0x01) { + /* TX IQK OK */ + pr_debug("Path A IQK Only Tx Success!!\n"); + + val32 = rtl8723au_read32(priv, + REG_TX_POWER_BEFORE_IQK_A); + result[t][0] = (val32 >> 16) & 0x3ff; + val32 = rtl8723au_read32(priv, + REG_TX_POWER_AFTER_IQK_A); + result[t][1] = (val32 >> 16) & 0x3ff; + } + } + + if (!path_a_ok) + pr_debug("%s: Path A IQK failed!\n", __func__); + +#if 0 + if (is_2t) { + rtl8xxxu_phy_path_a_standby(priv); + + /* Turn Path B ADDA on */ + rtl8xxxu_phy_path_adda_on(priv, ADDA_REG, false, is_2t); + + for (i = 0; i < retry; i++) { + path_b_ok = _PHY_PathB_IQK(priv); + if (path_b_ok == 0x03) { + val32 = rtl8723au_read32(priv, REG_TX_POWER_BEFORE_IQK_B); + result[t][4] = (val32 >> 16) & 0x3ff; + val32 = rtl8723au_read32(priv, REG_TX_POWER_AFTER_IQK_B); + result[t][5] = (val32 >> 16) & 0x3ff; + val32 = rtl8723au_read32(priv, REG_RX_POWER_BEFORE_IQK_B_2); + result[t][6] = (val32 >> 16) & 0x3ff; + val32 = rtl8723au_read32(priv, REG_RX_POWER_AFTER_IQK_B_2); + result[t][7] = (val32 >> 16) & 0x3ff; + break; + } else if (i == (retry - 1) && path_b_ok == 0x01) { + /* TX IQK OK */ + val32 = rtl8723au_read32(priv, REG_TX_POWER_BEFORE_IQK_B); + result[t][4] = (val32 >> 16) & 0x3ff; + val32 = rtl8723au_read32(priv, REG_TX_POWER_AFTER_IQK_B); + result[t][5] = (val32 >> 16) & 0x3ff; + } + } + + if (!path_b_ok) + pr_debug("%s: Path B IQK failed!\n", __func__); + } +#endif + + /* Back to BB mode, load original value */ + rtl8723au_write32(priv, REG_FPGA0_IQK, 0); + + if (t) { + if (!priv->pi_enabled) { + /* + * Switch back BB to SI mode after finishing + * IQ Calibration + */ + val32 = 0x01000000; + rtl8723au_write32(priv, REG_FPGA0_XA_HSSI_PARM1, val32); + rtl8723au_write32(priv, REG_FPGA0_XB_HSSI_PARM1, val32); + } + + /* Reload ADDA power saving parameters */ + rtl8xxxu_restore_regs(priv, ADDA_REG, priv->adda_backup, + RTL8XXXU_ADDA_REGS); + + /* Reload MAC parameters */ + rtl8xxxu_restore_mac_regs(priv, IQK_MAC_REG, priv->mac_backup); + + /* Reload BB parameters */ + rtl8xxxu_restore_regs(priv, IQK_BB_REG_92C, + priv->bb_backup, RTL8XXXU_BB_REGS); + + /* Restore RX initial gain */ + rtl8723au_write32(priv, REG_FPGA0_XA_LSSI_PARM, 0x00032ed3); + + if (is_2t) { + rtl8723au_write32(priv, REG_FPGA0_XB_LSSI_PARM, + 0x00032ed3); + } + + /* load 0xe30 IQC default value */ + rtl8723au_write32(priv, REG_TX_IQK_TONE_A, 0x01008c00); + rtl8723au_write32(priv, REG_RX_IQK_TONE_A, 0x01008c00); + } +} + +static void rtl8723a_phy_iq_calibrate(struct rtl8xxxu_priv *priv, bool recovery) +{ + int result[4][8]; /* last is final result */ + int i, candidate; + bool path_a_ok /*, path_b_ok */; + u32 reg_e94, reg_e9c, reg_ea4, reg_eac; + u32 reg_eb4, reg_ebc, reg_ec4, reg_ecc; + s32 reg_tmp = 0; + bool simu; + u32 iqk_bb_reg_92c[RTL8XXXU_BB_REGS] = { + REG_OFDM0_XA_RX_IQ_IMBALANCE, REG_OFDM0_XB_RX_IQ_IMBALANCE, + REG_OFDM0_ENERGY_CCA_THRES, REG_OFDM0_AGCR_SSI_TABLE, + REG_OFDM0_XA_TX_IQ_IMBALANCE, REG_OFDM0_XB_TX_IQ_IMBALANCE, + REG_OFDM0_XC_TX_AFE, REG_OFDM0_XD_TX_AFE, + REG_OFDM0_RX_IQ_EXT_ANTA + }; + + if (recovery) { + rtl8xxxu_restore_regs(priv, iqk_bb_reg_92c, + priv->bb_recovery_backup, + RTL8XXXU_BB_REGS); + return; + } + + memset(result, 0, sizeof(result)); + candidate = -1; + + path_a_ok = false; +#if 0 + path_b_ok = false; +#endif + rtl8723au_read32(priv, REG_FPGA0_RF_MODE); + + for (i = 0; i < 3; i++) { + rtl8xxxu_phy_iqcalibrate(priv, result, i, false); + + if (i == 1) { + simu = rtl8xxxu_simularity_compare(priv, result, 0, 1); + if (simu) { + candidate = 0; + break; + } + } + + if (i == 2) { + simu = rtl8xxxu_simularity_compare(priv, result, 0, 2); + if (simu) { + candidate = 0; + break; + } + + simu = rtl8xxxu_simularity_compare(priv, result, 1, 2); + if (simu) { + candidate = 1; + } else { + for (i = 0; i < 8; i++) + reg_tmp += result[3][i]; + + if (reg_tmp) + candidate = 3; + else + candidate = -1; + } + } + } + + for (i = 0; i < 4; i++) { + reg_e94 = result[i][0]; + reg_e9c = result[i][1]; + reg_ea4 = result[i][2]; + reg_eac = result[i][3]; + reg_eb4 = result[i][4]; + reg_ebc = result[i][5]; + reg_ec4 = result[i][6]; + reg_ecc = result[i][7]; + } + + if (candidate >= 0) { + reg_e94 = result[candidate][0]; + priv->rege94 = reg_e94; + reg_e9c = result[candidate][1]; + priv->rege9c = reg_e9c; + reg_ea4 = result[candidate][2]; + reg_eac = result[candidate][3]; + reg_eb4 = result[candidate][4]; + priv->regeb4 = reg_eb4; + reg_ebc = result[candidate][5]; + priv->regebc = reg_ebc; + reg_ec4 = result[candidate][6]; + reg_ecc = result[candidate][7]; + pr_debug("%s: candidate is %x\n", __func__, candidate); + pr_debug("%s: reg_e94 =%x reg_e9C =%x reg_eA4 =%x " + "reg_eAC =%x reg_eB4 =%x reg_eBC =%x reg_eC4 =%x " + "reg_eCC =%x\n ", __func__, reg_e94, reg_e9c, + reg_ea4, reg_eac, reg_eb4, reg_ebc, reg_ec4, reg_ecc); + path_a_ok = true; +#if 0 + path_b_ok = true; +#endif + } else { + reg_e94 = reg_eb4 = priv->rege94 = priv->regeb4 = 0x100; + reg_e9c = reg_ebc = priv->rege9c = priv->regebc = 0x0; + } + + if (reg_e94 && candidate >= 0) + rtl8xxxu_fill_iqk_matrix_a(priv, path_a_ok, result, + candidate, (reg_ea4 == 0)); + + rtl8xxxu_save_regs(priv, iqk_bb_reg_92c, + priv->bb_recovery_backup, RTL8XXXU_BB_REGS); +} + +static void rtl8723a_phy_lc_calibrate(struct rtl8xxxu_priv *priv) +{ + u32 val32; + u32 rf_amode, lstf; + + /* Check continuous TX and Packet TX */ + lstf = rtl8723au_read32(priv, REG_OFDM1_LSTF); + + if (lstf & OFDM_LSTF_MASK) { + /* Disable all continuous TX */ + val32 = lstf & ~OFDM_LSTF_MASK; + rtl8723au_write32(priv, REG_OFDM1_LSTF, val32); + + /* Read original RF mode Path A */ + rf_amode = rtl8723au_read_rfreg(priv, RF6052_REG_AC); + +#if 0 + /* Path-B */ + if (is_2t) + rf_bmode = PHY_QueryRFReg(priv, RF_PATH_B, RF_AC, + bMask12Bits); +#endif + + /* Set RF mode to standby Path A */ + rtl8723au_write_rfreg(priv, RF6052_REG_AC, + (rf_amode & 0xfff) | 0x10000); + +#if 0 + /* Path-B */ + if (is_2t) + PHY_SetRFReg(priv, RF_PATH_B, RF_AC, bMask12Bits, + (RF_Bmode & 0x8ffff) | 0x10000); +#endif + } else { + /* Deal with Packet TX case */ + /* block all queues */ + rtl8723au_write8(priv, REG_TXPAUSE, 0xff); + } + + /* Start LC calibration */ + val32 = rtl8723au_read_rfreg(priv, RF6052_REG_MODE_AG); + val32 |= 0x08000; + rtl8723au_write_rfreg(priv, RF6052_REG_MODE_AG, val32); + + msleep(100); + + /* Restore original parameters */ + if (lstf & OFDM_LSTF_MASK) { + /* Path-A */ + rtl8723au_write32(priv, REG_OFDM1_LSTF, lstf); + rtl8723au_write_rfreg(priv, RF6052_REG_AC, rf_amode); + +#if 0 + /* Path-B */ + if (is_2t) + PHY_SetRFReg(priv, RF_PATH_B, RF_AC, bMask12Bits, + RF_Bmode); +#endif + } else /* Deal with Packet TX case */ + rtl8723au_write8(priv, REG_TXPAUSE, 0x00); +} + +static int rtl8xxxu_set_mac(struct rtl8xxxu_priv *priv) +{ + int i; + u16 reg; + + reg = REG_MACID; + + for (i = 0; i < ETH_ALEN; i++) + rtl8723au_write8(priv, reg + i, priv->mac_addr[i]); + + return 0; +} + +static int rtl8xxxu_set_bssid(struct rtl8xxxu_priv *priv, const u8 *bssid) +{ + int i; + u16 reg; + + pr_debug("%s (%02x:%02x:%02x:%02x:%02x:%02x)\n", __func__, + bssid[0], bssid[1], bssid[2], bssid[3], bssid[4], bssid[5]); + + reg = REG_BSSID; + + for (i = 0; i < ETH_ALEN; i++) + rtl8723au_write8(priv, reg + i, bssid[i]); + + return 0; +} + +void rtl8xxxu_set_ampdu_factor(struct rtl8xxxu_priv *priv, u8 ampdu_factor) +{ + u8 vals[4] = { 0x41, 0xa8, 0x72, 0xb9 }; + u8 max_agg = 0xf; + int i; + + ampdu_factor = 1 << (ampdu_factor + 2); + if (ampdu_factor > max_agg) + ampdu_factor = max_agg; + + for (i = 0; i < 4; i++) { + if ((vals[i] & 0xf0) > (ampdu_factor << 4)) + vals[i] = (vals[i] & 0x0f) | (ampdu_factor << 4); + + if ((vals[i] & 0x0f) > ampdu_factor) + vals[i] = (vals[i] & 0xf0) | ampdu_factor; + + rtl8723au_write8(priv, REG_AGGLEN_LMT + i, vals[i]); + } +} + +void rtl8xxxu_set_ampdu_min_space(struct rtl8xxxu_priv *priv, u8 density) +{ + u8 val8; + + val8 = rtl8723au_read8(priv, REG_AMPDU_MIN_SPACE); + val8 &= 0xf8; + val8 |= density; + rtl8723au_write8(priv, REG_AMPDU_MIN_SPACE, val8); +} + +static int rtl8xxxu_active_to_emu(struct rtl8xxxu_priv *priv) +{ + u8 val8; + int count, ret; + + /* Start of rtl8723AU_card_enable_flow */ + /* Act to Cardemu sequence*/ + /* Turn off RF */ + rtl8723au_write8(priv, REG_RF_CTRL, 0); + + /* 0x004E[7] = 0, switch DPDT_SEL_P output from register 0x0065[2] */ + val8 = rtl8723au_read8(priv, REG_LEDCFG2); + val8 &= ~LEDCFG2_DPDT_SELECT; + rtl8723au_write8(priv, REG_LEDCFG2, val8); + + /* 0x0005[1] = 1 turn off MAC by HW state machine*/ + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 1); + val8 |= BIT(1); + rtl8723au_write8(priv, REG_APS_FSMCO + 1, val8); + + for (count = RTL8XXXU_MAX_REG_POLL; count; count--) { + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 1); + if ((val8 & BIT(1)) == 0) + break; + udelay(10); + } + + if (!count) { + pr_warn("%s: Turn off MAC timed out\n", __func__); + ret = -EBUSY; + goto exit; + } + + /* 0x0000[5] = 1 analog Ips to digital, 1:isolation */ + val8 = rtl8723au_read8(priv, REG_SYS_ISO_CTRL); + val8 |= SYS_ISO_ANALOG_IPS; + rtl8723au_write8(priv, REG_SYS_ISO_CTRL, val8); + + /* 0x0020[0] = 0 disable LDOA12 MACRO block*/ + val8 = rtl8723au_read8(priv, REG_LDOA15_CTRL); + val8 &= ~LDOA15_ENABLE; + rtl8723au_write8(priv, REG_LDOA15_CTRL, val8); + +exit: + return ret; +} + +static int rtl8xxxu_active_to_lps(struct rtl8xxxu_priv *priv) +{ + u8 val8; + u8 val32; + int count, ret; + + rtl8723au_write8(priv, REG_TXPAUSE, 0xff); + + /* + * Poll - wait for RX packet to complete + */ + for (count = RTL8XXXU_MAX_REG_POLL; count; count--) { + val32 = rtl8723au_read8(priv, 0x5f8); + if (!val32) + break; + udelay(10); + } + + if (!count) { + pr_warn("%s: RX poll timed out (0x05f8)\n", __func__); + ret = -EBUSY; + goto exit; + } + + /* Disable CCK and OFDM, clock gated */ + val8 = rtl8723au_read8(priv, REG_SYS_FUNC); + val8 &= ~SYS_FUNC_BBRSTB; + rtl8723au_write8(priv, REG_SYS_FUNC, val8); + + udelay(2); + + /* Reset baseband */ + val8 = rtl8723au_read8(priv, REG_SYS_FUNC); + val8 &= ~SYS_FUNC_BB_GLB_RSTN; + rtl8723au_write8(priv, REG_SYS_FUNC, val8); + + /* Reset MAC TRX */ + val8 = rtl8723au_read8(priv, REG_CR); + val8 = CR_HCI_TXDMA_ENABLE | CR_HCI_RXDMA_ENABLE; + rtl8723au_write8(priv, REG_CR, val8); + + /* Reset MAC TRX */ + val8 = rtl8723au_read8(priv, REG_CR + 1); + val8 &= ~BIT(1); /* CR_SECURITY_ENABLE */ + rtl8723au_write8(priv, REG_CR + 1, val8); + + /* Respond TX OK to scheduler */ + val8 = rtl8723au_read8(priv, REG_DUAL_TSF_RST); + val8 |= BIT(5); + rtl8723au_write8(priv, REG_DUAL_TSF_RST, val8); + +exit: + return ret; +} + +static void rtl8xxxu_disabled_to_emu(struct rtl8xxxu_priv *priv) +{ + u8 val8; + + /* Clear suspend enable and power down enable*/ + val8 = rtl8723au_read8(priv, 0x05); + val8 &= ~(BIT(3) | BIT(7)); + rtl8723au_write8(priv, 0x05, val8); + + /* 0x48[16] = 0 to disable GPIO9 as EXT WAKEUP*/ + val8 = rtl8723au_read8(priv, 0x4a); + val8 &= ~BIT(0); + rtl8723au_write8(priv, 0x4a, val8); + + /* 0x04[12:11] = 11 enable WL suspend*/ + val8 = rtl8723au_read8(priv, 0x05); + val8 &= ~(BIT(3) | BIT(4)); + rtl8723au_write8(priv, 0x05, val8); +} + +static int rtl8xxxu_emu_to_active(struct rtl8xxxu_priv *priv) +{ + u8 val8; + u32 val32; + int count, ret = 0; + + /* 0x20[0] = 1 enable LDOA12 MACRO block for all interface*/ + val8 = rtl8723au_read8(priv, REG_LDOA15_CTRL); + val8 |= LDOA15_ENABLE; + rtl8723au_write8(priv, REG_LDOA15_CTRL, val8); + + /* 0x67[0] = 0 to disable BT_GPS_SEL pins*/ + val8 = rtl8723au_read8(priv, 0x0067); + val8 &= ~BIT(4); + rtl8723au_write8(priv, 0x0067, val8); + + mdelay(1); + + /* 0x00[5] = 0 release analog Ips to digital, 1:isolation */ + val8 = rtl8723au_read8(priv, REG_SYS_ISO_CTRL); + val8 &= ~BIT(5); + rtl8723au_write8(priv, REG_SYS_ISO_CTRL, val8); + + /* disable SW LPS 0x04[10]= 0 */ + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 1); + val8 &= ~BIT(2); + rtl8723au_write8(priv, REG_APS_FSMCO + 1, val8); + + /* wait till 0x04[17] = 1 power ready*/ + for (count = RTL8XXXU_MAX_REG_POLL; count; count--) { + val32 = rtl8723au_read32(priv, REG_APS_FSMCO); + if (val32 & BIT(17)) { + break; + } + udelay(10); + } + + if (!count) { + ret = -EBUSY; + goto exit; + } + + /* We should be able to optimize the following three entries into one */ + + /* release WLON reset 0x04[16]= 1*/ + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 2); + val8 |= BIT(0); + rtl8723au_write8(priv, REG_APS_FSMCO + 2, val8); + + /* disable HWPDN 0x04[15]= 0*/ + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 1); + val8 &= ~BIT(7); + rtl8723au_write8(priv, REG_APS_FSMCO + 1, val8); + + /* disable WL suspend*/ + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 1); + val8 &= ~(BIT(3) | BIT(4)); + rtl8723au_write8(priv, REG_APS_FSMCO + 1, val8); + + /* set, then poll until 0 */ + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 1); + val8 |= BIT(0); + rtl8723au_write8(priv, REG_APS_FSMCO + 1, val8); + + for (count = RTL8XXXU_MAX_REG_POLL; count; count--) { + val32 = rtl8723au_read32(priv, REG_APS_FSMCO); + if ((val32 & BIT(8)) == 0) { + ret = 0; + break; + } + udelay(10); + } + + if (!count) { + ret = -EBUSY; + goto exit; + } + + /* 0x4C[23] = 0x4E[7] = 1, switch DPDT_SEL_P output from WL BB */ + /* + * Note: Vendor driver actually clears this bit, despite the + * documentation claims it's being set! + */ + val8 = rtl8723au_read8(priv, REG_LEDCFG2); + val8 |= LEDCFG2_DPDT_SELECT; + val8 &= ~LEDCFG2_DPDT_SELECT; + rtl8723au_write8(priv, REG_LEDCFG2, val8); + +exit: + return ret; +} + +static int rtl8xxxu_emu_to_disabled(struct rtl8xxxu_priv *priv) +{ + u8 val8; + + /* 0x0007[7:0] = 0x20 SOP option to disable BG/MB */ + rtl8723au_write8(priv, REG_APS_FSMCO + 3, 0x20); + + /* 0x04[12:11] = 01 enable WL suspend */ + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 1); + val8 &= ~BIT(4); + val8 |= BIT(3); + rtl8723au_write8(priv, REG_APS_FSMCO + 1, val8); + + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 1); + val8 |= BIT(7); + rtl8723au_write8(priv, REG_APS_FSMCO + 1, val8); + + /* 0x48[16] = 1 to enable GPIO9 as EXT wakeup */ + val8 = rtl8723au_read8(priv, REG_GPIO_INTM + 2); + val8 |= BIT(0); + rtl8723au_write8(priv, REG_GPIO_INTM + 2, val8); + + return 0; +} + +static int rtl8xxxu_power_on(struct rtl8xxxu_priv *priv) +{ + u8 val8; + u16 val16; + u32 val32; + int ret; + + /* RSV_CTRL 0x001C[7:0] = 0x00 + unlock ISO/CLK/Power control register */ + rtl8723au_write8(priv, REG_RSV_CTRL, 0x0); + + rtl8xxxu_disabled_to_emu(priv); + + ret = rtl8xxxu_emu_to_active(priv); + if (ret) + goto exit; + + /* 0x0004[19] = 1, reset 8051 */ + val8 = rtl8723au_read8(priv, REG_APS_FSMCO + 2); + val8 |= BIT(3); + rtl8723au_write8(priv, REG_APS_FSMCO + 2, val8); + + /* Enable MAC DMA/WMAC/SCHEDULE/SEC block */ + /* Set CR bit10 to enable 32k calibration. */ + val16 = rtl8723au_read16(priv, REG_CR); + val16 |= (CR_HCI_TXDMA_ENABLE | CR_HCI_RXDMA_ENABLE | + CR_TXDMA_ENABLE | CR_RXDMA_ENABLE | + CR_PROTOCOL_ENABLE | CR_SCHEDULE_ENABLE | + CR_MAC_TX_ENABLE | CR_MAC_RX_ENABLE | + CR_SECURITY_ENABLE | CR_CALTIMER_ENABLE); + rtl8723au_write16(priv, REG_CR, val16); + + /* for Efuse PG */ + val32 = rtl8723au_read32(priv, REG_EFUSE_CTRL); + val32 &= ~(BIT(28)|BIT(29)|BIT(30)); + val32 |= (0x06 << 28); + rtl8723au_write32(priv, REG_EFUSE_CTRL, val32); +exit: + return ret; +} + +static void rtl8xxxu_power_off(struct rtl8xxxu_priv *priv) +{ + u8 val8; + u16 val16; + + rtl8xxxu_active_to_lps(priv); + + /* Turn off RF */ + rtl8723au_write8(priv, REG_RF_CTRL, 0x00); + + /* Reset Firmware if running in RAM */ + if (rtl8723au_read8(priv, REG_MCU_FW_DL) & MCU_FW_RAM_SEL) + rtl8xxxu_firmware_self_reset(priv); + + /* Reset MCU */ + val16 = rtl8723au_read16(priv, REG_SYS_FUNC); + val16 &= ~SYS_FUNC_CPU_ENABLE; + rtl8723au_write16(priv, REG_SYS_FUNC, val16); + + /* Reset MCU ready status */ + rtl8723au_write8(priv, REG_MCU_FW_DL, 0x00); + + rtl8xxxu_active_to_emu(priv); + rtl8xxxu_emu_to_disabled(priv); + + /* Reset MCU IO Wrapper */ + val8 = rtl8723au_read8(priv, REG_RSV_CTRL + 1); + val8 &= ~BIT(0); + rtl8723au_write8(priv, REG_RSV_CTRL + 1, val8); + + val8 = rtl8723au_read8(priv, REG_RSV_CTRL + 1); + val8 |= BIT(0); + rtl8723au_write8(priv, REG_RSV_CTRL + 1, val8); + + /* RSV_CTRL 0x1C[7:0] = 0x0e lock ISO/CLK/Power control register */ + rtl8723au_write8(priv, REG_RSV_CTRL, 0x0e); +} + +static int rtl8xxxu_init_device(struct ieee80211_hw *hw) +{ + struct rtl8xxxu_priv *priv = hw->priv; + bool macpower; + int ret; + u8 val8; + u16 val16; + u32 val32; + + /* Check if MAC is already powered on */ + val8 = rtl8723au_read8(priv, REG_CR); + + /* Fix 92DU-VC S3 hang with the reason is that secondary mac is not + initialized. First MAC returns 0xea, second MAC returns 0x00 */ + if (val8 == 0xea) + macpower = false; + else + macpower = true; + + ret = rtl8xxxu_power_on(priv); + if (ret < 0) { + pr_warn("%s: Failed power on\n", __func__); + goto exit; + } + + pr_debug("macpower %i\n", macpower); + if (!macpower) { + ret = rtl8xxxu_init_llt_table(priv, TX_TOTAL_PAGE_NUM); + if (ret) { + pr_debug("%s: LLT table init failed\n", __func__); + goto exit; + } + } + + ret = rtl8xxxu_download_firmware(priv); + if (ret) + goto exit; + ret = rtl8xxxu_start_firmware(priv); + if (ret) + goto exit; + + ret = rtl8xxxu_init_mac(priv, rtl8723a_mac_init_table); + if (ret) + goto exit; + + ret = rtl8xxxu_init_phy_bb(priv); + if (ret) + goto exit; + + ret = rtl8xxxu_init_phy_rf(priv); + if (ret) + goto exit; + + /* Reduce 80M spur */ + rtl8723au_write32(priv, REG_AFE_XTAL_CTRL, 0x0381808d); + rtl8723au_write32(priv, REG_AFE_PLL_CTRL, 0xf0ffff83); + rtl8723au_write32(priv, REG_AFE_PLL_CTRL, 0xf0ffff82); + rtl8723au_write32(priv, REG_AFE_PLL_CTRL, 0xf0ffff83); + + /* RFSW Control - clear bit 14 ?? */ + rtl8723au_write32(priv, REG_FPGA0_TXINFO, 0x00000003); + /* 0x07000760 */ + val32 = 0x07000000 | FPGA0_RF_TRSW | FPGA0_RF_TRSWB | + FPGA0_RF_ANTSW | FPGA0_RF_ANTSWB | FPGA0_RF_PAPE; + rtl8723au_write32(priv, REG_FPGA0_XAB_RF_SW_CTRL, val32); + /* 0x860[6:5]= 00 - why? - this sets antenna B */ + rtl8723au_write32(priv, REG_FPGA0_XA_RF_INT_OE, 0x66F60210); + + priv->rf_mode_ag[0] = rtl8723au_read_rfreg(priv, RF6052_REG_MODE_AG); + + if (!macpower) { + if (priv->ep_tx_normal_queue) + val8 = TX_PAGE_NUM_NORM_PQ; + else + val8 = 0; + + rtl8723au_write8(priv, REG_RQPN_NPQ, val8); + + val32 = (TX_PAGE_NUM_PUBQ << RQPN_NORM_PQ_SHIFT) | RQPN_LOAD; + + if (priv->ep_tx_high_queue) + val32 |= (TX_PAGE_NUM_HI_PQ << RQPN_HI_PQ_SHIFT); + if (priv->ep_tx_low_queue) + val32 |= (TX_PAGE_NUM_LO_PQ << RQPN_LO_PQ_SHIFT); + + rtl8723au_write32(priv, REG_RQPN, val32); + + /* + * Set TX buffer boundary + */ + val8 = TX_TOTAL_PAGE_NUM + 1; + rtl8723au_write8(priv, REG_TXPKTBUF_BCNQ_BDNY, val8); + rtl8723au_write8(priv, REG_TXPKTBUF_MGQ_BDNY, val8); + rtl8723au_write8(priv, REG_TXPKTBUF_WMAC_LBK_BF_HD, val8); + rtl8723au_write8(priv, REG_TRXFF_BNDY, val8); + rtl8723au_write8(priv, REG_TDECTRL + 1, val8); + } + + ret = rtl8xxxu_init_queue_priority(priv); + if (ret) + goto exit; + + /* + * Set RX page boundary + */ + rtl8723au_write16(priv, REG_TRXFF_BNDY + 2, 0x27ff); + /* + * Transfer page size is always 128 + */ + val8 = (PBP_PAGE_SIZE_128 << PBP_PAGE_SIZE_RX_SHIFT) | + (PBP_PAGE_SIZE_128 << PBP_PAGE_SIZE_TX_SHIFT); + rtl8723au_write8(priv, REG_PBP, val8); + + /* + * Unit in 8 bytes, not obvious what it is used for + */ + rtl8723au_write8(priv, REG_RX_DRVINFO_SZ, 4); + + /* + * Enable all interrupts - not obvious USB needs to do this + */ + rtl8723au_write32(priv, REG_HISR, 0xffffffff); + rtl8723au_write32(priv, REG_HIMR, 0xffffffff); + + rtl8xxxu_set_mac(priv); + rtl8xxxu_set_linktype(priv, NL80211_IFTYPE_STATION); + + /* + * Configure initial WMAC settings + */ + val32 = RCR_ACCEPT_PHYS_MATCH | RCR_ACCEPT_MCAST | RCR_ACCEPT_BCAST | + /* RCR_CHECK_BSSID_MATCH | RCR_CHECK_BSSID_BEACON | */ + RCR_ACCEPT_MGMT_FRAME | RCR_HTC_LOC_CTRL | + RCR_APPEND_PHYSTAT | RCR_APPEND_ICV | RCR_APPEND_MIC; + rtl8723au_write32(priv, REG_RCR, val32); + + /* + * Accept all multicast + */ + rtl8723au_write32(priv, REG_MAR, 0xffffffff); + rtl8723au_write32(priv, REG_MAR + 4, 0xffffffff); + + /* + * Init adaptive controls + */ + val32 = rtl8723au_read32(priv, REG_RESPONSE_RATE_SET); + val32 &= ~RESPONSE_RATE_BITMAP_ALL; + val32 |= RESPONSE_RATE_RRSR_CCK_ONLY_1M; + rtl8723au_write32(priv, REG_RESPONSE_RATE_SET, val32); + + /* CCK = 0x0a, OFDM = 0x10 */ +#if 0 + rtl8xxxu_set_spec_sifs(priv, 0x0a, 0x10); +#else + rtl8xxxu_set_spec_sifs(priv, 0x10, 0x10); +#endif + rtl8xxxu_set_retry(priv, 0x30, 0x30); + rtl8xxxu_set_spec_sifs(priv, 0x0a, 0x10); + + /* + * Init EDCA + */ + rtl8723au_write16(priv, REG_MAC_SPEC_SIFS, 0x100a); + + /* Set CCK SIFS */ + rtl8723au_write16(priv, REG_SIFS_CCK, 0x100a); + + /* Set OFDM SIFS */ + rtl8723au_write16(priv, REG_SIFS_OFDM, 0x100a); + + /* TXOP */ + rtl8723au_write32(priv, REG_EDCA_BE_PARAM, 0x005ea42b); + rtl8723au_write32(priv, REG_EDCA_BK_PARAM, 0x0000a44f); + rtl8723au_write32(priv, REG_EDCA_VI_PARAM, 0x005ea324); + rtl8723au_write32(priv, REG_EDCA_VO_PARAM, 0x002fa226); + + /* Set data auto rate fallback retry count */ + rtl8723au_write32(priv, REG_DARFRC, 0x00000000); + rtl8723au_write32(priv, REG_DARFRC + 4, 0x10080404); + rtl8723au_write32(priv, REG_RARFRC, 0x04030201); + rtl8723au_write32(priv, REG_RARFRC + 4, 0x08070605); + + val8 = rtl8723au_read8(priv, REG_FWHW_TXQ_CTRL); + val8 |= FWHW_TXQ_CTRL_AMPDU_RETRY; + rtl8723au_write8(priv, REG_FWHW_TXQ_CTRL, val8); + + /* Set ACK timeout */ + rtl8723au_write8(priv, REG_ACKTO, 0x40); + + /* + * Initialize beacon parameters + */ + val16 = BEACON_DISABLE_TSF_UPDATE | (BEACON_DISABLE_TSF_UPDATE << 8); + rtl8723au_write16(priv, REG_BEACON_CTRL, val16); + rtl8723au_write16(priv, REG_TBTT_PROHIBIT, 0x6404); + rtl8723au_write8(priv, REG_DRIVER_EARLY_INT, DRIVER_EARLY_INT_TIME); + rtl8723au_write8(priv, REG_BEACON_DMA_TIME, BEACON_DMA_ATIME_INT_TIME); + rtl8723au_write16(priv, REG_BEACON_TCFG, 0x660F); + + /* + * Enable CCK and OFDM block + */ + val32 = rtl8723au_read32(priv, REG_FPGA0_RF_MODE); + val32 |= (FPGA_RF_MODE_CCK | FPGA_RF_MODE_OFDM); + rtl8723au_write32(priv, REG_FPGA0_RF_MODE, val32); + + /* + * Invalidate all CAM entries - bit 30 is undocumented + */ + rtl8723au_write32(priv, REG_CAM_CMD, CAM_CMD_POLLING | BIT(30)); + + /* + * Start out with default power levels for channel 6, 20MHz + */ + rtl8723a_set_tx_power(priv, 1, false); + + /* Let the 8051 take control of antenna setting */ + val8 = rtl8723au_read8(priv, REG_LEDCFG2); + val8 |= LEDCFG2_DPDT_SELECT; + rtl8723au_write8(priv, REG_LEDCFG2, val8); + + rtl8723au_write8(priv, REG_HWSEQ_CTRL, 0xff); + + /* Disable BAR - not sure if this has any effect on USB */ + rtl8723au_write32(priv, REG_BAR_MODE_CTRL, 0x0201ffff); + +#if 0 + if (priv->wifi_spec) + rtl8723au_write16(priv, REG_FAST_EDCA_CTRL, 0); +#endif + rtl8723au_write16(priv, REG_FAST_EDCA_CTRL, 0); + +#if 0 + /* + * From 8192cu driver + */ + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_RF_INT_OE); + val32 &= ~BIT(6); + val32 |= BIT(5); + rtl8723au_write32(priv, REG_FPGA0_XA_RF_INT_OE, val32); +#endif + + /* + * Not sure if we should get into this at all + */ + if (priv->iqk_initialized) { + rtl8723a_phy_iq_calibrate(priv, true); + } else { + rtl8723a_phy_iq_calibrate(priv, false); + priv->iqk_initialized = true; + } + + /* + * This should enable thermal meter + */ + rtl8723au_write_rfreg(priv, RF6052_REG_T_METER, 0x60); + + rtl8723a_phy_lc_calibrate(priv); + + /* fix USB interface interference issue */ + rtl8723au_write8(priv, 0xfe40, 0xe0); + rtl8723au_write8(priv, 0xfe41, 0x8d); + rtl8723au_write8(priv, 0xfe42, 0x80); + rtl8723au_write32(priv, REG_TXDMA_OFFSET_CHK, 0xfd0320); + + /* Solve too many protocol error on USB bus */ + /* Can't do this for 8188/8192 UMC A cut parts */ + rtl8723au_write8(priv, 0xfe40, 0xe6); + rtl8723au_write8(priv, 0xfe41, 0x94); + rtl8723au_write8(priv, 0xfe42, 0x80); + + rtl8723au_write8(priv, 0xfe40, 0xe0); + rtl8723au_write8(priv, 0xfe41, 0x19); + rtl8723au_write8(priv, 0xfe42, 0x80); + + rtl8723au_write8(priv, 0xfe40, 0xe5); + rtl8723au_write8(priv, 0xfe41, 0x91); + rtl8723au_write8(priv, 0xfe42, 0x80); + + rtl8723au_write8(priv, 0xfe40, 0xe2); + rtl8723au_write8(priv, 0xfe41, 0x81); + rtl8723au_write8(priv, 0xfe42, 0x80); + +#if 0 + /* Init BT hw config. */ + rtl8723a_init_bt(priv); +#endif + + /* + * Not sure if we really need to save these parameters, but the + * vendor driver does + */ + val32 = rtl8723au_read32(priv, REG_FPGA0_XA_HSSI_PARM2); + if (val32 & FPGA0_HSSI_PARM2_CCK_HIGH_PWR) + priv->path_a_hi_power = 1; + + val32 = rtl8723au_read32(priv, REG_OFDM0_TRX_PATH_ENABLE); + priv->path_a_rf_paths = val32 & OFDM0_RF_PATH_RX_MASK; + + val32 = rtl8723au_read32(priv, REG_OFDM0_XA_AGC_CORE1); + priv->path_a_ig_value = val32 & OFDM0_X_AGC_CORE1_IGI_MASK; + + /* Set NAV_UPPER to 30000us */ + val8 = ((30000 + NAV_UPPER_UNIT - 1) / NAV_UPPER_UNIT); + rtl8723au_write8(priv, REG_NAV_UPPER, val8); + + /* 2011/03/09 MH debug only, UMC-B cut pass 2500 S5 test, + but we need to fin root cause. */ + val32 = rtl8723au_read32(priv, REG_FPGA0_RF_MODE); + if ((val32 & 0xff000000) != 0x83000000) { + val32 |= FPGA_RF_MODE_CCK; + rtl8723au_write32(priv, REG_FPGA0_RF_MODE, val32); + } + + val32 = rtl8723au_read32(priv, REG_FWHW_TXQ_CTRL); + val32 |= FWHW_TXQ_CTRL_XMIT_MGMT_ACK; + /* ack for xmit mgmt frames. */ + rtl8723au_write32(priv, REG_FWHW_TXQ_CTRL, val32); + +exit: + return ret; +} + +static void rtl8xxxu_disable_device(struct ieee80211_hw *hw) +{ + struct rtl8xxxu_priv *priv = hw->priv; + + rtl8xxxu_power_off(priv); +} + +static void rtl8xxxu_cam_write(struct rtl8xxxu_priv *priv, + struct ieee80211_key_conf *key, const u8 *mac) +{ + u32 cmd, val32, addr, ctrl; + int j, i, tmp_debug; + + tmp_debug = rtl8xxxu_debug; + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_KEY) + rtl8xxxu_debug |= RTL8XXXU_DEBUG_REG_WRITE; + + addr = key->keyidx << CAM_CMD_KEY_SHIFT; + ctrl = (key->cipher & 0x0f) << 2 | key->keyidx | CAM_WRITE_VALID; + + for (j = 5; j >= 0; j--) { + switch (j) { + case 0: + val32 = ctrl | (mac[0] << 16) | (mac[1] << 24); + break; + case 1: + val32 = mac[2] | (mac[3] << 8) | + (mac[4] << 16) | (mac[5] << 24); + break; + default: + i = (j - 2) << 2; + val32 = key->key[i] | (key->key[i + 1] << 8) | + key->key[i + 2] << 16 | key->key[i + 3] << 24; + break; + } + + rtl8723au_write32(priv, REG_CAM_WRITE, val32); + cmd = CAM_CMD_POLLING | CAM_CMD_WRITE | (addr + j); + rtl8723au_write32(priv, REG_CAM_CMD, cmd); + udelay(100); + } + + rtl8xxxu_debug = tmp_debug; +} + +static void rtl8xxxu_sw_scan_start(struct ieee80211_hw *hw, + struct ieee80211_vif *vif, const u8 *mac) +{ +#if 0 + struct rtl8xxxu_priv *priv = hw->priv; + u32 val32; + + val32 = rtl8723au_read32(priv, REG_RCR); + val32 &= ~(RCR_CHECK_BSSID_MATCH | RCR_CHECK_BSSID_BEACON); + rtl8723au_write32(priv, REG_RCR, val32); + + rtl8723au_write8(priv, REG_BEACON_CTRL, BEACON_ATIM | + BEACON_FUNCTION_ENABLE | BEACON_DISABLE_TSF_UPDATE); + + pr_debug("%s\n", __func__); +#endif +} + +static void rtl8xxxu_sw_scan_complete(struct ieee80211_hw *hw, + struct ieee80211_vif *vif) +{ + struct rtl8xxxu_priv *priv = hw->priv; + u8 val8; + +#if 0 + pr_debug("%s\n", __func__); +#endif + + val8 = rtl8723au_read8(priv, REG_BEACON_CTRL); + val8 &= ~BEACON_DISABLE_TSF_UPDATE; + rtl8723au_write8(priv, REG_BEACON_CTRL, val8); +} + +static void rtl8xxxu_update_rate_table(struct rtl8xxxu_priv *priv, + struct ieee80211_sta *sta) +{ + struct h2c_cmd h2c; + u32 ramask; + + /* TODO: Set bits 28-31 for rate adaptive id */ + ramask = (sta->supp_rates[0] & 0xfff) | + sta->ht_cap.mcs.rx_mask[0] << 12 | + sta->ht_cap.mcs.rx_mask[1] << 20; + + h2c.ramask.cmd = H2C_SET_RATE_MASK; + put_unaligned_le16(ramask & 0xffff, &h2c.ramask.mask_lo); + put_unaligned_le16(ramask >> 16, &h2c.ramask.mask_hi); + + h2c.ramask.arg = 0x80; + if (sta->ht_cap.cap & + (IEEE80211_HT_CAP_SGI_40 | IEEE80211_HT_CAP_SGI_20)) { + h2c.ramask.arg |= 0x20; + priv->use_shortgi = true; + } else { + priv->use_shortgi = false; + } + + pr_debug("%s: rate mask %08x, arg %02x\n", __func__, + ramask, h2c.ramask.arg); + rtl8723a_h2c_cmd(priv, &h2c); +} + +static void rtl8xxxu_set_basic_rates(struct rtl8xxxu_priv *priv, + struct ieee80211_sta *sta) +{ + u32 rate_cfg, val32; + u8 rate_idx = 0; + + rate_cfg = sta->supp_rates[0]; + rate_cfg &= 0x15f; + rate_cfg |= 1; + val32 = rtl8723au_read32(priv, REG_RESPONSE_RATE_SET); + val32 &= ~RESPONSE_RATE_BITMAP_ALL; + val32 |= rate_cfg; + rtl8723au_write32(priv, REG_RESPONSE_RATE_SET, val32); + + pr_debug("%s: supp_rates %08x rates %08x\n", __func__, + sta->supp_rates[0], rate_cfg); + + while(rate_cfg) { + rate_cfg = (rate_cfg >> 1); + rate_idx++; + } + rtl8723au_write8(priv, REG_INIRTS_RATE_SEL, rate_idx); +} + +static void +rtl8xxxu_bss_info_changed(struct ieee80211_hw *hw, struct ieee80211_vif *vif, + struct ieee80211_bss_conf *bss_conf, u32 changed) +{ + struct rtl8xxxu_priv *priv = hw->priv; + struct ieee80211_sta *sta; + u32 val32; +#if 0 + u16 val16; +#endif + u8 val8; + + if (changed & BSS_CHANGED_ASSOC) { + struct h2c_cmd h2c; + + memset(&h2c, 0, sizeof(struct h2c_cmd)); + rtl8xxxu_set_linktype(priv, vif->type); + + if (bss_conf->assoc) { + rcu_read_lock(); + sta = ieee80211_find_sta(vif, bss_conf->bssid); + if (!sta) { + pr_debug("%s: ASSOC no sta found\n", __func__); + rcu_read_unlock(); + goto error; + } + + if (sta->ht_cap.ht_supported) + pr_debug("%s: HT supported\n", __func__); + if (sta->vht_cap.vht_supported) + pr_debug("%s: VHT supported\n", __func__); + rtl8xxxu_update_rate_table(priv, sta); + rcu_read_unlock(); + + val32 = rtl8723au_read32(priv, REG_RCR); + val32 |= RCR_CHECK_BSSID_MATCH | RCR_CHECK_BSSID_BEACON; + rtl8723au_write32(priv, REG_RCR, val32); + + /* Enable RX of data frames */ + rtl8723au_write16(priv, REG_RXFLTMAP2, 0xffff); + + rtl8723au_write8(priv, REG_BCN_MAX_ERR, 0xff); + + /* Stop TX beacon */ + val8 = rtl8723au_read8(priv, REG_FWHW_TXQ_CTRL + 2); + val8 &= ~BIT(6); + rtl8723au_write8(priv, REG_FWHW_TXQ_CTRL + 2, val8); + + rtl8723au_write8(priv, REG_TBTT_PROHIBIT + 1, 0x64); + val8 = rtl8723au_read8(priv, REG_TBTT_PROHIBIT + 2); + val8 &= ~BIT(0); + rtl8723au_write8(priv, REG_TBTT_PROHIBIT + 2, val8); + + /* joinbss sequence */ + rtl8723au_write16(priv, REG_BCN_PSR_RPT, + 0xc000 | bss_conf->aid); + +#if 0 + val16 = rtl8723au_read16(priv, REG_CR); + val16 |= CR_SW_BEACON_ENABLE; + rtl8723au_read16(priv, REG_CR, val16); + + val8 = rtl8723au_read8(priv, REG_BEACON_CTRL); + val8 &= ~BEACON_FUNCTION_ENABLE; + val8 |= BEACON_DISABLE_TSF_UPDATE; + rtl8723au_write8(priv, REG_BEACON_CTRL, val8); + + val8 = rtl8723au_read8(priv, REG_FWHW_TXQ_CTRL + 2); + if (val8 & BIT(6)) + recover = true; + + val8 &= ~BIT(6); + rtl8723au_write8(priv, REG_FWHW_TXQ_CTRL + 2, val8); + + /* build fake beacon */ + + val8 = rtl8723au_read8(priv, REG_BEACON_CTRL); + val8 |= BEACON_FUNCTION_ENABLE; + val8 &= ~BEACON_DISABLE_TSF_UPDATE; + rtl8723au_write8(priv, REG_BEACON_CTRL, val8); + + if (recover) { + val8 = rtl8723au_read8(priv, + REG_FWHW_TXQ_CTRL + 2); + val8 |= BIT(6); + rtl8723au_write8(priv, REG_FWHW_TXQ_CTRL + 2, + val8); + } + val16 = rtl8723au_read16(priv, REG_CR); + val16 &= ~CR_SW_BEACON_ENABLE; + rtl8723au_read16(priv, REG_CR, val16); +#endif + h2c.joinbss.data = H2C_JOIN_BSS_CONNECT; + } else { + val32 = rtl8723au_read32(priv, REG_RCR); + val32 &= ~(RCR_CHECK_BSSID_MATCH | + RCR_CHECK_BSSID_BEACON); + rtl8723au_write32(priv, REG_RCR, val32); + + val8 = rtl8723au_read8(priv, REG_BEACON_CTRL); + val8 |= BEACON_DISABLE_TSF_UPDATE; + rtl8723au_write8(priv, REG_BEACON_CTRL, val8); + + /* Disable RX of data frames */ + rtl8723au_write16(priv, REG_RXFLTMAP2, 0x0000); + h2c.joinbss.data = H2C_JOIN_BSS_DISCONNECT; + } + h2c.joinbss.cmd = H2C_JOIN_BSS_REPORT; + rtl8723a_h2c_cmd(priv, &h2c); + } + + if (changed & BSS_CHANGED_ERP_PREAMBLE) { + pr_debug("Changed ERP_PREAMBLE: Use short preamble %02x\n", + bss_conf->use_short_preamble); + val32 = rtl8723au_read32(priv, REG_RESPONSE_RATE_SET); + if (bss_conf->use_short_preamble) + val32 |= RSR_ACK_SHORT_PREAMBLE; + else + val32 &= ~RSR_ACK_SHORT_PREAMBLE; + rtl8723au_write32(priv, REG_RESPONSE_RATE_SET, val32); + } + + if (changed & BSS_CHANGED_ERP_SLOT) { + pr_debug("Changed ERP_SLOT: short_slot_time %i\n", + bss_conf->use_short_slot); + + if (bss_conf->use_short_slot) + val8 = 9; + else + val8 = 20; + rtl8723au_write8(priv, REG_SLOT, val8); + } + + if (changed & BSS_CHANGED_HT) { + u8 ampdu_factor, ampdu_density; + u8 sifs; + + rcu_read_lock(); + sta = ieee80211_find_sta(vif, bss_conf->bssid); + if (!sta) { + pr_debug("BSS_CHANGED_HT: No HT sta found!\n"); + rcu_read_unlock(); + goto error; + } + if (sta->ht_cap.ht_supported) { + ampdu_factor = sta->ht_cap.ampdu_factor; + ampdu_density = sta->ht_cap.ampdu_density; + sifs = 0x0e; + } else { + ampdu_factor = 0; + ampdu_density = 0; + sifs = 0x0a; + } + rcu_read_unlock(); +#if 0 + pr_debug("Changed HT: ampdu_factor %02x, ampdu_density %02x\n", + ampdu_factor, ampdu_density); + rtl8xxxu_set_ampdu_factor(priv, ampdu_factor); + rtl8xxxu_set_ampdu_min_space(priv, ampdu_density); +#endif + + rtl8723au_write8(priv, REG_SIFS_CCK + 1, sifs); + rtl8723au_write8(priv, REG_SIFS_OFDM + 1, sifs); + rtl8723au_write8(priv, REG_SPEC_SIFS + 1, sifs); + rtl8723au_write8(priv, REG_MAC_SPEC_SIFS + 1, sifs); + rtl8723au_write8(priv, REG_R2T_SIFS + 1, sifs); + rtl8723au_write8(priv, REG_T2T_SIFS + 1, sifs); + } + + if (changed & BSS_CHANGED_BSSID) { + pr_debug("Changed BSSID!\n"); + rtl8xxxu_set_bssid(priv, bss_conf->bssid); + + rcu_read_lock(); + sta = ieee80211_find_sta(vif, bss_conf->bssid); + if (!sta) { + pr_debug("No bssid sta found!\n"); + rcu_read_unlock(); + goto error; + } + rcu_read_unlock(); + } + + if (changed & BSS_CHANGED_BASIC_RATES) { + pr_debug("Changed BASIC_RATES!\n"); + rcu_read_lock(); + sta = ieee80211_find_sta(vif, bss_conf->bssid); + if (sta) + rtl8xxxu_set_basic_rates(priv, sta); + else + pr_debug("BSS_CHANGED_BASIC_RATES: No sta found!\n"); + + rcu_read_unlock(); + } +error: + return; +} + +static u32 rtl8xxxu_80211_to_rtl_queue(u32 queue) +{ + u32 rtlqueue; + + switch(queue) { + case IEEE80211_AC_VO: + rtlqueue = TXDESC_QUEUE_VO; + break; + case IEEE80211_AC_VI: + rtlqueue = TXDESC_QUEUE_VI; + break; + case IEEE80211_AC_BE: + rtlqueue = TXDESC_QUEUE_BE; + break; + case IEEE80211_AC_BK: + rtlqueue = TXDESC_QUEUE_BK; + break; + default: + rtlqueue = TXDESC_QUEUE_BE; + } + + return rtlqueue; +} + +static u32 rtl8xxxu_queue_select(struct ieee80211_hw *hw, struct sk_buff *skb) +{ + struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data; + u32 queue; + + if (unlikely(ieee80211_is_beacon(hdr->frame_control))) { + queue = TXDESC_QUEUE_BEACON; + } + if (ieee80211_is_mgmt(hdr->frame_control)) + queue = TXDESC_QUEUE_MGNT; + else + queue = rtl8xxxu_80211_to_rtl_queue(skb_get_queue_mapping(skb)); + + return queue; +} + +static void rtl8xxxu_calc_tx_desc_csum(struct rtl8xxxu_tx_desc *tx_desc) +{ + u16 *ptr = (u16 *)tx_desc; + u16 csum = 0; + int i; + + tx_desc->csum = cpu_to_le32(0); + + for (i = 0; i < (sizeof(struct rtl8xxxu_tx_desc) / sizeof(u16)); i++) + csum = csum ^ le16_to_cpu(ptr[i]); + + tx_desc->csum |= cpu_to_le32(csum); +} + +static void rtl8xxxu_tx_complete(struct urb *urb) +{ + struct sk_buff *skb = (struct sk_buff *)urb->context; + struct ieee80211_tx_info *tx_info; + struct ieee80211_hw *hw; + + tx_info = IEEE80211_SKB_CB(skb); + hw = tx_info->rate_driver_data[0]; + + skb_pull(skb, sizeof(struct rtl8xxxu_tx_desc)); + + ieee80211_tx_info_clear_status(tx_info); + tx_info->status.rates[0].idx = -1; + tx_info->status.rates[0].count = 0; + + tx_info->flags |= IEEE80211_TX_STAT_ACK; + + ieee80211_tx_status_irqsafe(hw, skb); + + usb_free_urb(urb); +} + + +static void rtl8xxxu_tx(struct ieee80211_hw *hw, + struct ieee80211_tx_control *control, + struct sk_buff *skb) +{ + struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data; + struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(skb); + struct ieee80211_rate *tx_rate = ieee80211_get_tx_rate(hw, tx_info); + struct rtl8xxxu_priv *priv = hw->priv; + struct rtl8xxxu_tx_desc *tx_desc; + struct urb *urb; + u32 queue, rate; + u16 pktlen = skb->len; + u16 seq_number; + u16 rate_flag = tx_info->control.rates[0].flags; + int ret; + + if (skb_headroom(skb) < sizeof(struct rtl8xxxu_tx_desc)) { + pr_debug("%s: Not enough headroom (%i) for tx descriptor\n", + __func__, skb_headroom(skb)); + goto error; + } + + if (unlikely(skb->len > (65535 - sizeof(struct rtl8xxxu_tx_desc)))) { + pr_debug("%s: Trying to send over-sized skb (%i)\n", + __func__, skb->len); + goto error; + } + + urb = usb_alloc_urb(0, GFP_KERNEL); + if (!urb) { + pr_debug("%s: Unable to allocate urb\n", __func__); + goto error; + } + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_TX) + pr_debug("%s: TX rate: %d (%d), pkt size %d\n", + __func__, tx_rate->bitrate, tx_rate->hw_value, pktlen); + + tx_info->rate_driver_data[0] = hw; + + tx_desc = (struct rtl8xxxu_tx_desc *) + skb_push(skb, sizeof(struct rtl8xxxu_tx_desc)); + + memset(tx_desc, 0, sizeof(struct rtl8xxxu_tx_desc)); + tx_desc->pkt_size = cpu_to_le16(pktlen); + tx_desc->pkt_offset = sizeof(struct rtl8xxxu_tx_desc); + + tx_desc->txdw0 = TXDESC_OWN | TXDESC_FSG | TXDESC_LSG; + if (is_multicast_ether_addr(ieee80211_get_DA(hdr)) || + is_broadcast_ether_addr(ieee80211_get_DA(hdr))) + tx_desc->txdw0 |= TXDESC_BROADMULTICAST; + + queue = rtl8xxxu_queue_select(hw, skb); + tx_desc->txdw1 = cpu_to_le32(queue << TXDESC_QUEUE_SHIFT); + + if (tx_info->control.hw_key) { + switch (tx_info->control.hw_key->cipher) { + case WLAN_CIPHER_SUITE_WEP40: + case WLAN_CIPHER_SUITE_WEP104: + case WLAN_CIPHER_SUITE_TKIP: + tx_desc->txdw1 |= cpu_to_le32(TXDESC_SEC_RC4); + break; + case WLAN_CIPHER_SUITE_CCMP: + tx_desc->txdw1 |= cpu_to_le32(TXDESC_SEC_AES); + break; + default: + break; + } + } + + seq_number = IEEE80211_SEQ_TO_SN(le16_to_cpu(hdr->seq_ctrl)); + tx_desc->txdw3 = cpu_to_le32((u32)seq_number << TXDESC_SEQ_SHIFT); + + if (rate_flag & IEEE80211_TX_RC_MCS) + rate = tx_info->control.rates[0].idx + DESC_RATE_MCS0; + else + rate = tx_rate->hw_value; + tx_desc->txdw5 = cpu_to_le32(rate); + + /* + * Black magic! + */ +#if 0 + if (ieee80211_is_data(hdr->frame_control)) { + tx_desc->txdw5 = cpu_to_le32(0x0001ff00); + + if ((tx_info->flags & IEEE80211_TX_CTL_AMPDU) && + control->sta->ht_cap.ht_supported && + control && control->sta) { + u8 ampdu = control->sta->ht_cap.ampdu_density; + tx_desc->txdw2 |= + cpu_to_le32(ampdu << TXDESC_AMPDU_DENSITY_SHIFT); + tx_desc->txdw1 |= cpu_to_le32(TXDESC_AGG_ENABLE); + } else + tx_desc->txdw1 |= cpu_to_le32(TXDESC_BK); + } else +#endif + tx_desc->txdw1 |= cpu_to_le32(TXDESC_BK); + if (ieee80211_is_data_qos(hdr->frame_control)) + tx_desc->txdw4 |= cpu_to_le32(TXDESC_QOS); + if (rate_flag & IEEE80211_TX_RC_USE_SHORT_PREAMBLE) + tx_desc->txdw4 |= cpu_to_le32(TXDESC_SHORT_PREAMBLE); + if (rate_flag & IEEE80211_TX_RC_SHORT_GI || priv->use_shortgi) + tx_desc->txdw5 |= cpu_to_le32(TXDESC_SHORT_GI); + if (ieee80211_is_mgmt(hdr->frame_control)) { + tx_desc->txdw5 = cpu_to_le32(tx_rate->hw_value); + tx_desc->txdw4 |= cpu_to_le32(TXDESC_USE_DRIVER_RATE); + tx_desc->txdw5 |= cpu_to_le32(6 << TXDESC_RETRY_LIMIT_SHIFT); + tx_desc->txdw5 |= cpu_to_le32(TXDESC_RETRY_LIMIT_ENABLE); + } + + if (rate_flag & IEEE80211_TX_RC_USE_RTS_CTS) { + /* Use RTS rate 24M - does the mac80211 tell us which to use? */ + tx_desc->txdw4 |= cpu_to_le32(DESC_RATE_24M); + tx_desc->txdw4 |= cpu_to_le32(TXDESC_RTS_ENABLE); + } + + rtl8xxxu_calc_tx_desc_csum(tx_desc); + + usb_fill_bulk_urb(urb, priv->udev, priv->pipe_out[queue], skb->data, + skb->len, rtl8xxxu_tx_complete, skb); + + usb_anchor_urb(urb, &priv->tx_anchor); + ret = usb_submit_urb(urb, GFP_KERNEL); + if (ret) { + usb_unanchor_urb(urb); + goto error; + } + return; +error: + dev_kfree_skb(skb); +} + + +static void rtl8xxxu_rx_complete(struct urb *urb) +{ + struct rtl8xxxu_rx_urb *rx_urb = + container_of(urb, struct rtl8xxxu_rx_urb, urb); + struct ieee80211_hw *hw = rx_urb->hw; + struct rtl8xxxu_priv *priv = hw->priv; + struct sk_buff *skb = (struct sk_buff *)urb->context; + struct rtl8xxxu_rx_desc *rx_desc = (struct rtl8xxxu_rx_desc *)skb->data; + struct rtl8723au_phy_stats *phy_stats; + struct ieee80211_rx_status *rx_status = IEEE80211_SKB_RXCB(skb); + struct ieee80211_mgmt *mgmt; + __le32 *_rx_desc_le = (__le32 *)skb->data; + u32 *_rx_desc = (u32 *)skb->data; + int cnt, len, skb_size, drvinfo_sz, desc_shift, i, ret; + + for (i = 0; i < (sizeof(struct rtl8xxxu_rx_desc) / sizeof(u32)); i++) + _rx_desc[i] = le32_to_cpu(_rx_desc_le[i]); + + cnt = rx_desc->frag; + len = rx_desc->pktlen; + drvinfo_sz = rx_desc->drvinfo_sz * 8; + desc_shift = rx_desc->shift; + skb_put(skb, urb->actual_length); + + if (urb->status == 0) { + skb_pull(skb, sizeof(struct rtl8xxxu_rx_desc)); + phy_stats = (struct rtl8723au_phy_stats *)skb->data; + + skb_pull(skb, drvinfo_sz + desc_shift); + + mgmt = (struct ieee80211_mgmt *)skb->data; + +#if 0 + if (ieee80211_is_assoc_req(mgmt->frame_control)) { + pr_debug("Received assoc req\n"); + } else if (ieee80211_is_assoc_resp(mgmt->frame_control)) { + pr_debug("Received assoc resp\n"); + } if (ieee80211_is_probe_req(mgmt->frame_control)) { + pr_debug("Received probe req\n"); + } if (ieee80211_is_probe_resp(mgmt->frame_control)) { + pr_debug("Received probe resp\n"); + } if (ieee80211_is_mgmt(mgmt->frame_control)) { + pr_debug("Received mgmt\n"); + } else { + pr_debug("Received something else\n"); + } +#endif + + memset(rx_status, 0, sizeof(struct ieee80211_rx_status)); + + /* + * Note this is valid for CCK rates only - FIXME + */ + if (rx_desc->phy_stats) { + u8 cck_agc_rpt = phy_stats->cck_agc_rpt_ofdm_cfosho_a; + + switch (cck_agc_rpt & 0xc0) { + case 0xc0: + rx_status->signal = -46 - (cck_agc_rpt & 0x3e); + break; + case 0x80: + rx_status->signal = -26 - (cck_agc_rpt & 0x3e); + break; + case 0x40: + rx_status->signal = -12 - (cck_agc_rpt & 0x3e); + break; + case 0x00: + rx_status->signal = 16 - (cck_agc_rpt & 0x3e); + break; + } + } + + rx_status->freq = hw->conf.chandef.chan->center_freq; + rx_status->band = hw->conf.chandef.chan->band; + + if (!rx_desc->swdec) + rx_status->flag |= RX_FLAG_DECRYPTED; + if (rx_desc->crc32) + rx_status->flag |= RX_FLAG_FAILED_FCS_CRC; + if (rx_desc->bw) + rx_status->flag |= RX_FLAG_40MHZ; + + if (rx_desc->rxht) { + rx_status->flag |= RX_FLAG_HT; + rx_status->rate_idx = rx_desc->rxmcs - DESC_RATE_MCS0; + } else { + rx_status->rate_idx = rx_desc->rxmcs; + } + + ieee80211_rx_irqsafe(hw, skb); + skb_size = sizeof(struct rtl8xxxu_rx_desc) + + RTL_RX_BUFFER_SIZE; + skb = dev_alloc_skb(skb_size); + if (!skb) { + pr_warn("%s: Out of memory\n", __func__); + goto cleanup; + } + + memset(skb->data, 0, sizeof(struct rtl8xxxu_rx_desc)); + usb_fill_bulk_urb(&rx_urb->urb, priv->udev, priv->pipe_in, + skb->data, skb_size, rtl8xxxu_rx_complete, skb); + + usb_anchor_urb(&rx_urb->urb, &priv->rx_anchor); + ret = usb_submit_urb(&rx_urb->urb, GFP_ATOMIC); + if (ret) { + usb_unanchor_urb(&rx_urb->urb); + goto cleanup; + } + } else { + pr_debug("%s: status %i\n", __func__, urb->status); + goto cleanup; + } + return; + +cleanup: + usb_free_urb(urb); + dev_kfree_skb(skb); + return; +} + +static int rtl8xxxu_submit_rx_urb(struct ieee80211_hw *hw) +{ + struct rtl8xxxu_priv *priv = hw->priv; + struct sk_buff *skb; + struct rtl8xxxu_rx_urb *rx_urb; + int skb_size; + int ret; + + skb_size = sizeof(struct rtl8xxxu_rx_desc) + RTL_RX_BUFFER_SIZE; + skb = dev_alloc_skb(skb_size); + if (!skb) + return -ENOMEM; + + memset(skb->data, 0, sizeof(struct rtl8xxxu_rx_desc)); + + rx_urb = kmalloc(sizeof(struct rtl8xxxu_rx_urb), GFP_ATOMIC); + if (!rx_urb) { + dev_kfree_skb(skb); + return -ENOMEM; + } + usb_init_urb(&rx_urb->urb); + rx_urb->hw = hw; + + usb_fill_bulk_urb(&rx_urb->urb, priv->udev, priv->pipe_in, skb->data, + skb_size, rtl8xxxu_rx_complete, skb); + usb_anchor_urb(&rx_urb->urb, &priv->rx_anchor); + ret = usb_submit_urb(&rx_urb->urb, GFP_ATOMIC); + if (ret) + usb_unanchor_urb(&rx_urb->urb); + return ret; +} + +static void rtl8xxxu_int_complete(struct urb *urb) +{ + struct rtl8xxxu_priv *priv = (struct rtl8xxxu_priv *)urb->context; + int i, ret; + + pr_debug("%s: status %i\n", __func__, urb->status); + if (urb->status == 0) { + for (i = 0; i < USB_INTR_CONTENT_LENGTH; i++) { + printk("%02x ", priv->int_buf[i]); + if ((i & 0x0f) == 0x0f) + printk("\n"); + } + + usb_anchor_urb(urb, &priv->int_anchor); + ret = usb_submit_urb(urb, GFP_ATOMIC); + if (ret) + usb_unanchor_urb(urb); + } else { + pr_debug("%s: Error %i\n", __func__, urb->status); + } +} + + +static int rtl8xxxu_submit_int_urb(struct ieee80211_hw *hw) +{ + struct rtl8xxxu_priv *priv = hw->priv; + struct urb *urb; + u32 val32; + int ret; + + urb = usb_alloc_urb(0, GFP_KERNEL); + if (!urb) + return -ENOMEM; + + usb_fill_int_urb(urb, priv->udev, priv->pipe_interrupt, + priv->int_buf, USB_INTR_CONTENT_LENGTH, + rtl8xxxu_int_complete, priv, 1); + usb_anchor_urb(urb, &priv->int_anchor); + ret = usb_submit_urb(urb, GFP_KERNEL); + if (ret) { + usb_unanchor_urb(urb); + goto error; + } + + val32 = rtl8723au_read32(priv, REG_USB_HIMR); + val32 |= USB_HIMR_CPWM; + rtl8723au_write32(priv, REG_USB_HIMR, val32); + +error: + return ret; +} + +static int rtl8xxxu_add_interface(struct ieee80211_hw *hw, + struct ieee80211_vif *vif) +{ + struct rtl8xxxu_priv *priv = hw->priv; + int ret; + u8 val8; + + switch (vif->type) { + case NL80211_IFTYPE_STATION: + rtl8723a_stop_tx_beacon(priv); + + val8 = rtl8723au_read8(priv, REG_BEACON_CTRL); + val8 |= BEACON_ATIM | BEACON_FUNCTION_ENABLE | + BEACON_DISABLE_TSF_UPDATE; + rtl8723au_write8(priv, REG_BEACON_CTRL, val8); + ret = 0; + break; + default: + ret = -EOPNOTSUPP; + } + + rtl8xxxu_set_linktype(priv, vif->type); + + return ret; +} + +static void rtl8xxxu_remove_interface(struct ieee80211_hw *hw, + struct ieee80211_vif *vif) +{ + pr_debug("%s\n", __func__); +} + +static int rtl8xxxu_config(struct ieee80211_hw *hw, u32 changed) +{ + struct rtl8xxxu_priv *priv = hw->priv; + u16 val16; + int ret = 0, channel; + bool ht40; + + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_CHANNEL) + pr_debug("%s: channel: %i (changed %08x chandef.width %02x)\n", + __func__, hw->conf.chandef.chan->hw_value, + changed, hw->conf.chandef.width); + + if (changed & IEEE80211_CONF_CHANGE_RETRY_LIMITS) { + val16 = ((hw->conf.long_frame_max_tx_count << + RETRY_LIMIT_LONG_SHIFT) & RETRY_LIMIT_LONG_MASK) | + ((hw->conf.short_frame_max_tx_count << + RETRY_LIMIT_SHORT_SHIFT) & RETRY_LIMIT_SHORT_MASK); + rtl8723au_write16(priv, REG_RETRY_LIMIT, val16); + } + + if (changed & IEEE80211_CONF_CHANGE_CHANNEL) { + switch (hw->conf.chandef.width) { + case NL80211_CHAN_WIDTH_20_NOHT: + case NL80211_CHAN_WIDTH_20: + ht40 = false; + break; + case NL80211_CHAN_WIDTH_40: + ht40 = true; + break; + default: + ret = -ENOTSUPP; + goto exit; + } + + channel = hw->conf.chandef.chan->hw_value; + + rtl8723a_set_tx_power(priv, channel, ht40); + + rtl8723au_config_channel(hw); + } + +exit: + return ret; +} + +static int rtl8xxxu_conf_tx(struct ieee80211_hw *hw, + struct ieee80211_vif *vif, u16 queue, + const struct ieee80211_tx_queue_params *param) +{ + struct rtl8xxxu_priv *priv = hw->priv; + u32 val32; + u16 cw_min, cw_max, txop; + u8 aifs, acm_ctrl, acm_bit; + + aifs = param->aifs; + cw_min = cpu_to_le16(param->cw_min); + cw_max = cpu_to_le16(param->cw_max); + txop = cpu_to_le16(param->txop); + + val32 = aifs | + (cw_min & 0xf) << EDCA_PARAM_ECW_MIN_SHIFT | + (cw_max & 0xf) << EDCA_PARAM_ECW_MAX_SHIFT | + txop << EDCA_PARAM_TXOP_SHIFT; + + acm_ctrl = rtl8723au_read8(priv, REG_ACM_HW_CTRL); + pr_debug("%s: IEEE80211 queue %02x val %08x, acm %i, acm_ctrl %02x\n", + __func__, queue, val32, param->acm, acm_ctrl); + + switch(queue) { + case IEEE80211_AC_VO: + acm_bit = ACM_HW_CTRL_VO; + rtl8723au_write32(priv, REG_EDCA_VO_PARAM, val32); + break; + case IEEE80211_AC_VI: + acm_bit = ACM_HW_CTRL_VI; + rtl8723au_write32(priv, REG_EDCA_VI_PARAM, val32); + break; + case IEEE80211_AC_BE: + acm_bit = ACM_HW_CTRL_BE; + rtl8723au_write32(priv, REG_EDCA_BE_PARAM, val32); + break; + case IEEE80211_AC_BK: + acm_bit = ACM_HW_CTRL_BK; + rtl8723au_write32(priv, REG_EDCA_BK_PARAM, val32); + break; + default: + acm_bit = 0; + break; + } + + if (param->acm) + acm_ctrl |= acm_bit; + else + acm_ctrl &= ~acm_bit; + rtl8723au_write8(priv, REG_ACM_HW_CTRL, acm_ctrl); + + return 0; +} + +static void rtl8xxxu_configure_filter(struct ieee80211_hw *hw, + unsigned int changed_flags, + unsigned int *total_flags, u64 multicast) +{ +#if 0 + pr_debug("%s: changed_flags %08x, total_flags %08x\n", + __func__, changed_flags, *total_flags); +#endif + + *total_flags &= (FIF_ALLMULTI | FIF_CONTROL | FIF_BCN_PRBRESP_PROMISC); +} + +static int rtl8xxxu_set_rts_threshold(struct ieee80211_hw *hw, u32 rts) +{ + if (rts > 2347) + return -EINVAL; + + return 0; +} + +static int rtl8xxxu_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd, + struct ieee80211_vif *vif, + struct ieee80211_sta *sta, + struct ieee80211_key_conf *key) +{ + struct rtl8xxxu_priv *priv = hw->priv; + u8 mac_addr[ETH_ALEN]; + u8 val8; + u16 val16; + u32 val32; + int retval = -EOPNOTSUPP; + + pr_debug("%s: cmd %02x, cipher %08x, index %i\n", + __func__, cmd, key->cipher, key->keyidx); + + if (vif->type != NL80211_IFTYPE_STATION) + return -EOPNOTSUPP; + + if (key->keyidx > 3) + return -EOPNOTSUPP; + + switch (key->cipher) { + case WLAN_CIPHER_SUITE_WEP40: + case WLAN_CIPHER_SUITE_WEP104: + + break; + case WLAN_CIPHER_SUITE_CCMP: + key->flags |= IEEE80211_KEY_FLAG_SW_MGMT_TX; + break; + case WLAN_CIPHER_SUITE_TKIP: + key->flags |= IEEE80211_KEY_FLAG_GENERATE_MMIC; + default: + return -EOPNOTSUPP; + } + + if (key->flags & IEEE80211_KEY_FLAG_PAIRWISE) { + pr_debug("%s: pairwise key\n", __func__); + ether_addr_copy(mac_addr, sta->addr); + } else { + pr_debug("%s: group key\n", __func__); + eth_broadcast_addr(mac_addr); + } + + val16 = rtl8723au_read16(priv, REG_CR); + val16 |= CR_SECURITY_ENABLE; + rtl8723au_write16(priv, REG_CR, val16); + + val8 = SEC_CFG_TX_SEC_ENABLE | SEC_CFG_TXBC_USE_DEFKEY | + SEC_CFG_RX_SEC_ENABLE | SEC_CFG_RXBC_USE_DEFKEY; + val8 |= SEC_CFG_TX_USE_DEFKEY | SEC_CFG_RX_USE_DEFKEY; + rtl8723au_write8(priv, REG_SECURITY_CFG, val8); + + switch(cmd) { + case SET_KEY: + /* + * This is a bit of a hack - the lower bits of the cipher + * suite selector happens to match the cipher index in the + * CAM + */ + key->hw_key_idx = key->keyidx; + key->flags |= IEEE80211_KEY_FLAG_GENERATE_IV; + rtl8xxxu_cam_write(priv, key, mac_addr); + retval = 0; + break; + case DISABLE_KEY: + rtl8723au_write32(priv, REG_CAM_WRITE, 0x00000000); + val32 = CAM_CMD_POLLING | CAM_CMD_WRITE | + key->keyidx << CAM_CMD_KEY_SHIFT; + rtl8723au_write32(priv, REG_CAM_CMD, val32); + retval = 0; + break; + default: + pr_debug("%s: Unsupported command %02x\n", __func__, cmd); + } + + return retval; +} + +static int rtl8xxxu_start(struct ieee80211_hw *hw) +{ + struct rtl8xxxu_priv *priv = hw->priv; + int ret, i; + + ret = 0; + + init_usb_anchor(&priv->rx_anchor); + init_usb_anchor(&priv->tx_anchor); + init_usb_anchor(&priv->int_anchor); + + rtl8723a_enable_rf(priv); + ret = rtl8xxxu_submit_int_urb(hw); + if (ret) + goto exit; + + for (i = 0; i < 32; i++) + ret = rtl8xxxu_submit_rx_urb(hw); + +exit: + /* + * Disable all data frames + */ + rtl8723au_write16(priv, REG_RXFLTMAP2, 0x0000); + /* + * Accept all mgmt frames + */ + rtl8723au_write16(priv, REG_RXFLTMAP0, 0xffff); + + rtl8723au_write32(priv, REG_OFDM0_XA_AGC_CORE1, 0x6954341e); + + return ret; +} + +static void rtl8xxxu_stop(struct ieee80211_hw *hw) +{ + struct rtl8xxxu_priv *priv = hw->priv; + + rtl8723au_write8(priv, REG_TXPAUSE, 0xff); + + rtl8723au_write16(priv, REG_RXFLTMAP0, 0x0000); + rtl8723au_write16(priv, REG_RXFLTMAP2, 0x0000); + + usb_kill_anchored_urbs(&priv->rx_anchor); + usb_kill_anchored_urbs(&priv->tx_anchor); + usb_kill_anchored_urbs(&priv->int_anchor); + + rtl8723a_disable_rf(priv); + + /* + * Disable interrupts + */ + rtl8723au_write32(priv, REG_USB_HIMR, 0); +} + +static const struct ieee80211_ops rtl8xxxu_ops = { + .tx = rtl8xxxu_tx, + .add_interface = rtl8xxxu_add_interface, + .remove_interface = rtl8xxxu_remove_interface, + .config = rtl8xxxu_config, + .conf_tx = rtl8xxxu_conf_tx, + .bss_info_changed = rtl8xxxu_bss_info_changed, + .configure_filter = rtl8xxxu_configure_filter, + .set_rts_threshold = rtl8xxxu_set_rts_threshold, + .start = rtl8xxxu_start, + .stop = rtl8xxxu_stop, + .sw_scan_start = rtl8xxxu_sw_scan_start, + .sw_scan_complete = rtl8xxxu_sw_scan_complete, + .set_key = rtl8xxxu_set_key, +}; + +static int rtl8xxxu_parse_usb(struct rtl8xxxu_priv *priv, + struct usb_interface *interface) +{ + struct usb_interface_descriptor *interface_desc; + struct usb_host_interface *host_interface; + struct usb_endpoint_descriptor *endpoint; + int i, j = 0, endpoints; + u8 dir, xtype, num; + int ret = 0; + + host_interface = &interface->altsetting[0]; + interface_desc = &host_interface->desc; + endpoints = interface_desc->bNumEndpoints; + + for (i = 0; i < endpoints; i++) { + endpoint = &host_interface->endpoint[i].desc; + + dir = endpoint->bEndpointAddress & USB_ENDPOINT_DIR_MASK; + num = usb_endpoint_num(endpoint); + xtype = usb_endpoint_type(endpoint); + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_USB) + pr_debug("%s: endpoint: dir %02x, # %02x, type %02x\n", + __func__, dir, num, xtype); + if (usb_endpoint_dir_in(endpoint) && + usb_endpoint_xfer_bulk(endpoint)) { + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_USB) + pr_debug("%s: in endpoint num %i\n", + __func__, num); + + if (priv->pipe_in) { + pr_warn("%s: Too many IN pipes\n", __func__); + ret = -EINVAL; + goto exit; + } + + priv->pipe_in = usb_rcvbulkpipe(priv->udev, num); + } + + if (usb_endpoint_dir_in(endpoint) && + usb_endpoint_xfer_int(endpoint)) { + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_USB) + pr_debug("%s: interrupt endpoint num %i\n", + __func__, num); + + if (priv->pipe_interrupt) { + pr_warn("%s: Too many INTERRUPT pipes\n", + __func__); + ret = -EINVAL; + goto exit; + } + + priv->pipe_interrupt = usb_rcvintpipe(priv->udev, num); + } + + if (usb_endpoint_dir_out(endpoint) && + usb_endpoint_xfer_bulk(endpoint)) { + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_USB) + pr_debug("%s: out endpoint num %i\n", + __func__, num); + if (j >= RTL8XXXU_OUT_ENDPOINTS) { + pr_warn("%s: Unsupported number of OUT pipes\n", + __func__); + ret = -EINVAL; + goto exit; + } + priv->out_ep[j++] = num; + } + } +exit: + return ret; +} + +static int rtl8xxxu_probe(struct usb_interface *interface, + const struct usb_device_id *id) +{ + struct rtl8xxxu_priv *priv; + struct ieee80211_hw *hw; + struct usb_device *udev; + struct ieee80211_supported_band *sband; + int ret = 0; + + udev = usb_get_dev(interface_to_usbdev(interface)); + + hw = ieee80211_alloc_hw(sizeof(struct rtl8xxxu_priv), &rtl8xxxu_ops); + if (!hw) { + ret = -ENOMEM; + goto exit; + } + + priv = hw->priv; + priv->hw = hw; + priv->udev = udev; + mutex_init(&priv->usb_buf_mutex); + mutex_init(&priv->h2c_mutex); + + usb_set_intfdata(interface, hw); + + ret = rtl8xxxu_parse_usb(priv, interface); + if (ret) + goto exit; + + rtl8xxxu_8723au_identify_chip(priv); + rtl8xxxu_read_efuse(priv); + ether_addr_copy(priv->mac_addr, priv->efuse_wifi.efuse.mac_addr); + + pr_info("%s: RTL8723au MAC %02x:%02x:%02x:%02x:%02x:%02x\n", + DRIVER_NAME, + priv->efuse_wifi.efuse.mac_addr[0], + priv->efuse_wifi.efuse.mac_addr[1], + priv->efuse_wifi.efuse.mac_addr[2], + priv->efuse_wifi.efuse.mac_addr[3], + priv->efuse_wifi.efuse.mac_addr[4], + priv->efuse_wifi.efuse.mac_addr[5]); + + rtl8xxxu_load_firmware(priv); + + ret = rtl8xxxu_init_device(hw); + + hw->wiphy->max_scan_ssids = 1; + hw->wiphy->max_scan_ie_len = IEEE80211_MAX_DATA_LEN; + hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION); + hw->queues = 4; + + sband = &rtl8xxxu_supported_band; + sband->ht_cap.ht_supported = true; +#if 0 + sband->ht_cap.ampdu_factor = IEEE80211_HT_MAX_AMPDU_8K; + sband->ht_cap.ampdu_density = IEEE80211_HT_MPDU_DENSITY_16; +#endif + sband->ht_cap.cap = /* IEEE80211_HT_CAP_SUP_WIDTH_20_40 | */ + IEEE80211_HT_CAP_SGI_20 | IEEE80211_HT_CAP_SGI_40; + memset(&sband->ht_cap.mcs, 0, sizeof(sband->ht_cap.mcs)); + sband->ht_cap.mcs.rx_mask[0] = 0xff; + sband->ht_cap.mcs.rx_mask[4] = 0x01; + if (priv->rf_paths > 1) { + sband->ht_cap.mcs.rx_mask[1] = 0xff; + sband->ht_cap.mcs.rx_highest = cpu_to_le16(300); + sband->ht_cap.cap |= IEEE80211_HT_CAP_SGI_40; + } else { + sband->ht_cap.mcs.rx_mask[1] = 0x00; + sband->ht_cap.mcs.rx_highest = cpu_to_le16(150); + } + sband->ht_cap.mcs.tx_params = IEEE80211_HT_MCS_TX_DEFINED; + hw->wiphy->bands[IEEE80211_BAND_2GHZ] = sband; + + hw->wiphy->max_remain_on_channel_duration = 65535; /* ms */ + hw->wiphy->cipher_suites = rtl8xxxu_cipher_suites; + hw->wiphy->n_cipher_suites = ARRAY_SIZE(rtl8xxxu_cipher_suites); + hw->wiphy->rts_threshold = 2347; + + SET_IEEE80211_DEV(priv->hw, &interface->dev); + SET_IEEE80211_PERM_ADDR(hw, priv->mac_addr); + + hw->extra_tx_headroom = sizeof(struct rtl8xxxu_tx_desc); + hw->flags = IEEE80211_HW_SIGNAL_DBM; + /* + * The firmware can handle rate control, but we need callbacks + */ + hw->flags |= IEEE80211_HW_HAS_RATE_CONTROL; + + ret = ieee80211_register_hw(priv->hw); + if (ret) { + pr_err("%s: Failed to register: %i\n", DRIVER_NAME, ret); + goto exit; + } + +exit: + if (ret < 0) + usb_put_dev(udev); + return ret; +} + +static void rtl8xxxu_disconnect(struct usb_interface *interface) +{ + struct rtl8xxxu_priv *priv; + struct ieee80211_hw *hw; + + hw = usb_get_intfdata(interface); + priv = hw->priv; + + rtl8xxxu_disable_device(hw); + usb_set_intfdata(interface, NULL); + + ieee80211_unregister_hw(hw); + + kfree(priv->fw_data); + mutex_destroy(&priv->usb_buf_mutex); + mutex_destroy(&priv->h2c_mutex); + + usb_put_dev(priv->udev); + ieee80211_free_hw(hw); + + wiphy_info(hw->wiphy, "disconnecting\n"); +} + +static struct usb_driver rtl8xxxu_driver = { + .name = DRIVER_NAME, + .probe = rtl8xxxu_probe, + .disconnect = rtl8xxxu_disconnect, + .id_table = dev_table, + .disable_hub_initiated_lpm = 1, +}; + +static int __init rtl8xxxu_module_init(void) +{ + int res = 0; + + res = usb_register(&rtl8xxxu_driver); + if (res < 0) + pr_err(DRIVER_NAME ": usb_register() failed (%i)\n", res); + + return res; +} + +static void __exit rtl8xxxu_module_exit(void) +{ + usb_deregister(&rtl8xxxu_driver); +} + +module_init(rtl8xxxu_module_init); +module_exit(rtl8xxxu_module_exit); diff --git a/drivers/net/wireless/rtl8xxxu.h b/drivers/net/wireless/rtl8xxxu.h new file mode 100644 index 0000000..8d9f64c --- /dev/null +++ b/drivers/net/wireless/rtl8xxxu.h @@ -0,0 +1,497 @@ +/* + * Copyright (c) 2014 Jes Sorensen <Jes.Sorensen@redhat.com> + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of version 2 of the GNU General Public License as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * Register definitions taken from original Realtek rtl8723au driver + */ + +#include <asm/byteorder.h> + +#define RTL8XXXU_DEBUG_REG_WRITE 0x01 +#define RTL8XXXU_DEBUG_REG_READ 0x02 +#define RTL8XXXU_DEBUG_RFREG_WRITE 0x04 +#define RTL8XXXU_DEBUG_RFREG_READ 0x08 +#define RTL8XXXU_DEBUG_CHANNEL 0x10 +#define RTL8XXXU_DEBUG_TX 0x20 +#define RTL8XXXU_DEBUG_TX_DUMP 0x40 +#define RTL8XXXU_DEBUG_RX 0x80 +#define RTL8XXXU_DEBUG_RX_DUMP 0x100 +#define RTL8XXXU_DEBUG_USB 0x200 +#define RTL8XXXU_DEBUG_KEY 0x400 +#define RTL8XXXU_DEBUG_H2C 0x800 + +#define RTW_USB_CONTROL_MSG_TIMEOUT 500 +#define RTL8XXXU_MAX_REG_POLL 500 +#define USB_INTR_CONTENT_LENGTH 56 + +#define RTL8XXXU_OUT_ENDPOINTS 3 + +#define REALTEK_USB_READ 0xc0 +#define REALTEK_USB_WRITE 0x40 +#define REALTEK_USB_CMD_REQ 0x05 +#define REALTEK_USB_CMD_IDX 0x00 + +#define TX_TOTAL_PAGE_NUM 0xf8 +/* (HPQ + LPQ + NPQ + PUBQ) = TX_TOTAL_PAGE_NUM */ +#define TX_PAGE_NUM_PUBQ 0xe7 +#define TX_PAGE_NUM_HI_PQ 0x0c +#define TX_PAGE_NUM_LO_PQ 0x02 +#define TX_PAGE_NUM_NORM_PQ 0x02 + +#define RTL_FW_PAGE_SIZE 4096 +#define RTL8XXXU_FIRMWARE_POLL_MAX 1000 + +#define RTL8723A_CHANNEL_GROUPS 3 +#define RTL8723A_MAX_RF_PATHS 2 +#define RF6052_MAX_TX_PWR 0x3f + +#define EFUSE_MAP_LEN_8723A 256 +#define EFUSE_MAX_SECTION_8723A 32 +#define EFUSE_REAL_CONTENT_LEN_8723A 512 +#define EFUSE_BT_MAP_LEN_8723A 1024 +#define EFUSE_MAX_WORD_UNIT 4 + +struct rtl8xxxu_rx_desc { + u32 pktlen:14; + u32 crc32:1; + u32 icverr:1; + u32 drvinfo_sz:4; + u32 security:3; + u32 qos:1; + u32 shift:2; + u32 phy_stats:1; + u32 swdec:1; + u32 ls:1; + u32 fs:1; + u32 eor:1; + u32 own:1; + + u32 macid:5; + u32 tid:4; + u32 hwrsvd:4; + u32 amsdu:1; + u32 paggr:1; + u32 faggr:1; + u32 a1fit:4; + u32 a2fit:4; + u32 pam:1; + u32 pwr:1; + u32 md:1; + u32 mf:1; + u32 type:2; + u32 mc:1; + u32 bc:1; + + u32 seq:12; + u32 frag:4; + u32 nextpktlen:14; + u32 nextind:1; + u32 reserved0:1; + + u32 rxmcs:6; + u32 rxht:1; + u32 gf:1; + u32 splcp:1; + u32 bw:1; + u32 htc:1; + u32 eosp:1; + u32 bssidfit:2; + u32 reserved1:16; + u32 unicastwake:1; + u32 magicwake:1; + + u32 pattern0match:1; + u32 pattern1match:1; + u32 pattern2match:1; + u32 pattern3match:1; + u32 pattern4match:1; + u32 pattern5match:1; + u32 pattern6match:1; + u32 pattern7match:1; + u32 pattern8match:1; + u32 pattern9match:1; + u32 patternamatch:1; + u32 patternbmatch:1; + u32 patterncmatch:1; + u32 reserved2:19; + + u32 tsfl; +#if 0 + u32 bassn:12; + u32 bavld:1; + u32 reserved3:19; +#endif +}; + +struct rtl8xxxu_tx_desc { + __le16 pkt_size; + u8 pkt_offset; + u8 txdw0; + __le32 txdw1; + __le32 txdw2; + __le32 txdw3; + __le32 txdw4; + __le32 txdw5; + __le32 txdw6; + __le16 csum; + __le16 txdw7; +}; + +/* CCK Rates, TxHT = 0 */ +#define DESC_RATE_1M 0x00 +#define DESC_RATE_2M 0x01 +#define DESC_RATE_5_5M 0x02 +#define DESC_RATE_11M 0x03 + +/* OFDM Rates, TxHT = 0 */ +#define DESC_RATE_6M 0x04 +#define DESC_RATE_9M 0x05 +#define DESC_RATE_12M 0x06 +#define DESC_RATE_18M 0x07 +#define DESC_RATE_24M 0x08 +#define DESC_RATE_36M 0x09 +#define DESC_RATE_48M 0x0a +#define DESC_RATE_54M 0x0b + +/* MCS Rates, TxHT = 1 */ +#define DESC_RATE_MCS0 0x0c +#define DESC_RATE_MCS1 0x0d +#define DESC_RATE_MCS2 0x0e +#define DESC_RATE_MCS3 0x0f +#define DESC_RATE_MCS4 0x10 +#define DESC_RATE_MCS5 0x11 +#define DESC_RATE_MCS6 0x12 +#define DESC_RATE_MCS7 0x13 +#define DESC_RATE_MCS8 0x14 +#define DESC_RATE_MCS9 0x15 +#define DESC_RATE_MCS10 0x16 +#define DESC_RATE_MCS11 0x17 +#define DESC_RATE_MCS12 0x18 +#define DESC_RATE_MCS13 0x19 +#define DESC_RATE_MCS14 0x1a +#define DESC_RATE_MCS15 0x1b +#define DESC_RATE_MCS15_SG 0x1c +#define DESC_RATE_MCS32 0x20 + +#define TXDESC_OFFSET_SZ 0 +#define TXDESC_OFFSET_SHT 16 +#if 0 +#define TXDESC_BMC BIT(24) +#define TXDESC_LSG BIT(26) +#define TXDESC_FSG BIT(27) +#define TXDESC_OWN BIT(31) +#else +#define TXDESC_BROADMULTICAST BIT(0) +#define TXDESC_LSG BIT(2) +#define TXDESC_FSG BIT(3) +#define TXDESC_OWN BIT(7) +#endif + +/* Word 1 */ +#define TXDESC_PKT_OFFSET_SZ 0 +#define TXDESC_AGG_ENABLE BIT(5) +#define TXDESC_BK BIT(6) +#define TXDESC_QUEUE_SHIFT 8 +#define TXDESC_QUEUE_MASK 0x1f00 +#define TXDESC_QUEUE_BK 0x2 +#define TXDESC_QUEUE_BE 0x0 +#define TXDESC_QUEUE_VI 0x5 +#define TXDESC_QUEUE_VO 0x7 +#define TXDESC_QUEUE_BEACON 0x10 +#define TXDESC_QUEUE_HIGH 0x11 +#define TXDESC_QUEUE_MGNT 0x12 +#define TXDESC_QUEUE_CMD 0x13 +#define TXDESC_QUEUE_MAX (TXDESC_QUEUE_CMD + 1) + +#define DESC_RATE_ID_SHIFT 16 +#define DESC_RATE_ID_MASK 0xf +#define TXDESC_NAVUSEHDR BIT(20) +#define TXDESC_SEC_RC4 0x00400000 +#define TXDESC_SEC_AES 0x00c00000 +#define TXDESC_PKT_OFFSET_SHIFT 26 +#define TXDESC_HWPC BIT(31) + +/* Word 2 */ +#define TXDESC_AMPDU_DENSITY_SHIFT 20 +#define TXDESC_AGG_EN BIT(29) + +/* Word 3 */ +#define TXDESC_SEQ_SHIFT 16 +#define TXDESC_SEQ_MASK 0x000fff0000 + +/* Word 4 */ +#define TXDESC_QOS BIT(6) +#define TXDESC_HW_SEQ_ENABLE BIT(7) +#define TXDESC_USE_DRIVER_RATE BIT(8) +#define TXDESC_DISABLE_DATA_FB BIT(10) +#define TXDESC_SHORT_PREAMBLE BIT(24) +#define TXDESC_DATA_BW BIT(25) + +/* Word 5 */ +#define TXDESC_RTS_RATE_SHIFT 0 +#define TXDESC_RTS_RATE_MASK 0x3f +#define TXDESC_SHORT_GI BIT(6) +#define TXDESC_CCX_TAG BIT(7) +#define TXDESC_RTS_ENABLE BIT(12) +#define TXDESC_RETRY_LIMIT_ENABLE BIT(17) +#define TXDESC_RETRY_LIMIT_SHIFT 18 +#define TXDESC_RETRY_LIMIT_MASK 0x003f0000 + +struct phy_rx_agc_info { +#ifdef __LITTLE_ENDIAN + u8 gain:7, trsw:1; +#else + u8 trsw:1, gain:7; +#endif +}; + +struct rtl8723au_phy_stats { + struct phy_rx_agc_info path_agc[RTL8723A_MAX_RF_PATHS]; + u8 ch_corr[RTL8723A_MAX_RF_PATHS]; + u8 cck_sig_qual_ofdm_pwdb_all; + u8 cck_agc_rpt_ofdm_cfosho_a; + u8 cck_rpt_b_ofdm_cfosho_b; + u8 reserved_1; + u8 noise_power_db_msb; + u8 path_cfotail[RTL8723A_MAX_RF_PATHS]; + u8 pcts_mask[RTL8723A_MAX_RF_PATHS]; + s8 stream_rxevm[RTL8723A_MAX_RF_PATHS]; + u8 path_rxsnr[RTL8723A_MAX_RF_PATHS]; + u8 noise_power_db_lsb; + u8 reserved_2[3]; + u8 stream_csi[RTL8723A_MAX_RF_PATHS]; + u8 stream_target_csi[RTL8723A_MAX_RF_PATHS]; + s8 sig_evm; + u8 reserved_3; + +#ifdef __LITTLE_ENDIAN + u8 antsel_rx_keep_2:1; /* ex_intf_flg:1; */ + u8 sgi_en:1; + u8 rxsc:2; + u8 idle_long:1; + u8 r_ant_train_en:1; + u8 antenna_select_b:1; + u8 antenna_select:1; +#else /* _BIG_ENDIAN_ */ + u8 antenna_select:1; + u8 antenna_select_b:1; + u8 r_ant_train_en:1; + u8 idle_long:1; + u8 rxsc:2; + u8 sgi_en:1; + u8 antsel_rx_keep_2:1; /* ex_intf_flg:1; */ +#endif +}; + +/* + * Regs to backup + */ +#define RTL8XXXU_ADDA_REGS 16 +#define RTL8XXXU_MAC_REGS 4 +#define RTL8XXXU_BB_REGS 9 + +struct rtl8xxxu_firmware_header { + __le16 signature; /* 92C0: test chip; 92C, + 88C0: test chip; + 88C1: MP A-cut; + 92C1: MP A-cut */ + u8 category; /* AP/NIC and USB/PCI */ + u8 function; + + __le16 major_version; /* FW Version */ + u8 minor_version; /* FW Subversion, default 0x00 */ + u8 reserved1; + + u8 month; /* Release time Month field */ + u8 date; /* Release time Date field */ + u8 hour; /* Release time Hour field */ + u8 minute; /* Release time Minute field */ + + __le16 ramcodesize; /* Size of RAM code */ + u16 reserved2; + + __le32 svn_idx; /* SVN entry index */ + u32 reserved3; + + u32 reserved4; + u32 reserved5; + + u8 data[0]; +}; + +/* + * The 8723au has 3 channel groups: 1-3, 4-9, and 10-14 + */ +struct rtl8723au_idx { +#if defined (__LITTLE_ENDIAN) + int a:4; + int b:4; +#elif defined (__LITTLE_ENDIAN) + int b:4; + int a:4; +#else +#error "no endianess defined" +#endif +} __attribute__((packed)); + +struct rtl8723au_efuse { + __le16 rtl_id; + u8 res0[0xe]; + u8 cck_tx_power_index_A[3]; /* 0x10 */ + u8 cck_tx_power_index_B[3]; + u8 ht40_1s_tx_power_index_A[3]; /* 0x16 */ + u8 ht40_1s_tx_power_index_B[3]; + /* + * The following entries are half-bytes split as: + * bits 0-3: path A, bits 4-7: path B, all values 4 bits signed + */ + struct rtl8723au_idx ht20_tx_power_index_diff[3]; + struct rtl8723au_idx ofdm_tx_power_index_diff[3]; + struct rtl8723au_idx ht40_max_power_offset[3]; + struct rtl8723au_idx ht20_max_power_offset[3]; + u8 channel_plan; /* 0x28 */ + u8 tssi_a; + u8 thermal_meter; + u8 rf_regulatory; + u8 rf_option_2; + u8 rf_option_3; + u8 rf_option_4; + u8 res7; + u8 version /* 0x30 */; + u8 customer_id_major; + u8 customer_id_minor; + u8 xtal_k; + u8 chipset; /* 0x34 */ + u8 res8[0x82]; + u8 vid; /* 0xb7 */ + u8 res9; + u8 pid; /* 0xb9 */ + u8 res10[0x0c]; + u8 mac_addr[ETH_ALEN]; /* 0xc6 */ + u8 res11[2]; + u8 vendor_name[7]; + u8 res12[2]; + u8 device_name[0x29]; /* 0xd7 */ +}; + +struct rtl8xxxu_reg8val { + u16 reg; + u8 val; +}; + +struct rtl8xxxu_reg32val { + u16 reg; + u32 val; +}; + +struct rtl8xxxu_rfregval { + u8 reg; + u32 val; +}; + +#define H2C_MAX_MBOX 4 +#define H2C_EXT BIT(7) +#define H2C_SET_POWER_MODE 1 +#define H2C_JOIN_BSS_REPORT 2 +#define H2C_JOIN_BSS_DISCONNECT 0 +#define H2C_JOIN_BSS_CONNECT 1 +#define H2C_SET_RSSI 5 +#define H2C_SET_RATE_MASK (6 | H2C_EXT) + +struct h2c_cmd { + union { + struct { + u8 cmd; + u8 data[5]; + } __packed cmd; + struct { + __le32 data; + __le16 ext; + } __packed raw; + struct { + u8 cmd; + u8 data; + u8 pad[4]; + } __packed joinbss; + struct { + u8 cmd; + __le16 mask_hi; + u8 arg; + __le16 mask_lo; + } __packed ramask; + }; +}; + +struct rtl8xxxu_priv { + struct ieee80211_hw *hw; + struct usb_device *udev; + u8 mac_addr[ETH_ALEN]; + u32 chip_cut:4; + u32 rom_rev:4; + u32 has_wifi:1; + u32 has_bluetooth:1; + u32 enable_bluetooth:1; + u32 has_gps:1; + u32 vendor_umc:1; + u32 has_polarity_ctrl:1; + u32 has_eeprom:1; + u32 boot_eeprom:1; + u32 ep_tx_high_queue:1; + u32 ep_tx_normal_queue:1; + u32 ep_tx_low_queue:1; + u32 path_a_hi_power:1; + u32 path_a_rf_paths:4; + unsigned int pipe_interrupt; + unsigned int pipe_in; + unsigned int pipe_out[TXDESC_QUEUE_MAX]; + u8 out_ep[RTL8XXXU_OUT_ENDPOINTS]; + u8 path_a_ig_value; + int ep_tx_count; + int rf_paths; + u32 rf_mode_ag[2]; + u32 rege94; + u32 rege9c; + u32 regeb4; + u32 regebc; + int next_mbox; + + struct mutex h2c_mutex; + + struct usb_anchor rx_anchor; + struct usb_anchor tx_anchor; + struct usb_anchor int_anchor; + struct rtl8xxxu_firmware_header *fw_data; + size_t fw_size; + struct mutex usb_buf_mutex; + union { + __le32 val32; + __le16 val16; + u8 val8; + } usb_buf; + union { + u8 raw[EFUSE_MAP_LEN_8723A]; + struct rtl8723au_efuse efuse; + } efuse_wifi; + u32 adda_backup[RTL8XXXU_ADDA_REGS]; + u32 mac_backup[RTL8XXXU_MAC_REGS]; + u32 bb_backup[RTL8XXXU_BB_REGS]; + u32 bb_recovery_backup[RTL8XXXU_BB_REGS]; + u8 pi_enabled:1; + u8 iqk_initialized:1; + u8 int_buf[USB_INTR_CONTENT_LENGTH]; + bool use_shortgi; +}; + +struct rtl8xxxu_rx_urb +{ + struct urb urb; + struct ieee80211_hw *hw; +}; diff --git a/drivers/net/wireless/rtl8xxxu_regs.h b/drivers/net/wireless/rtl8xxxu_regs.h new file mode 100644 index 0000000..97320b3 --- /dev/null +++ b/drivers/net/wireless/rtl8xxxu_regs.h @@ -0,0 +1,941 @@ +/* + * Copyright (c) 2014 Jes Sorensen <Jes.Sorensen@redhat.com> + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of version 2 of the GNU General Public License as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * Register definitions taken from original Realtek rtl8723au driver + */ + +/* 0x0000 ~ 0x00FF System Configuration */ +#define REG_SYS_ISO_CTRL 0x0000 +#define SYS_ISO_PWC_EV25V BIT(14) +#define SYS_ISO_PWC_EV12V BIT(15) +#define SYS_ISO_ANALOG_IPS BIT(5) + +#define REG_SYS_FUNC 0x0002 +#define SYS_FUNC_BBRSTB BIT(0) +#define SYS_FUNC_BB_GLB_RSTN BIT(1) +#define SYS_FUNC_USBA BIT(2) +#define SYS_FUNC_UPLL BIT(3) +#define SYS_FUNC_USBD BIT(4) +#define SYS_FUNC_DIO_PCIE BIT(5) +#define SYS_FUNC_PCIEA BIT(6) +#define SYS_FUNC_PPLL BIT(7) +#define SYS_FUNC_PCIED BIT(8) +#define SYS_FUNC_DIOE BIT(9) +#define SYS_FUNC_CPU_ENABLE BIT(10) +#define SYS_FUNC_DCORE BIT(11) +#define SYS_FUNC_ELDR BIT(12) +#define SYS_FUNC_DIO_RF BIT(13) +#define SYS_FUNC_HWPDN BIT(14) +#define SYS_FUNC_MREGEN BIT(15) + +#define REG_APS_FSMCO 0x0004 +#define APS_FSMCO_HW_POWERDOWN BIT(15) +#define APS_FSMCO_WLON_RESET BIT(16) + +#define REG_SYS_CLKR 0x0008 +#define SYS_CLK_ANAD16V_ENABLE BIT(0) +#define SYS_CLK_ANA8M BIT(1) +#define SYS_CLK_MACSLP BIT(4) +#define SYS_CLK_LOADER_ENABLE BIT(5) +#define SYS_CLK_80M_SSC_DISABLE BIT(7) +#define SYS_CLK_80M_SSC_ENABLE_HO BIT(8) +#define SYS_CLK_PHY_SSC_RSTB BIT(9) +#define SYS_CLK_SEC_CLK_ENABLE BIT(10) +#define SYS_CLK_MAC_CLK_ENABLE BIT(11) +#define SYS_CLK_ENABLE BIT(12) +#define SYS_CLK_RING_CLK_ENABLE BIT(13) + +#define REG_9346CR 0x000a +#define EEPROM_BOOT BIT(4) +#define EEPROM_ENABLE BIT(5) + +#define REG_EE_VPD 0x000c +#define REG_AFE_MISC 0x0010 +#define REG_SPS0_CTRL 0x0011 +#define REG_SPS_OCP_CFG 0x0018 +#define REG_RSV_CTRL 0x001c + +#define REG_RF_CTRL 0x001f +#define RF_ENABLE BIT(0) +#define RF_RSTB BIT(1) +#define RF_SDMRSTB BIT(2) + +#define REG_LDOA15_CTRL 0x0020 +#define LDOA15_ENABLE BIT(0) +#define LDOA15_STANDBY BIT(1) +#define LDOA15_OBUF BIT(2) +#define LDOA15_REG_VOS BIT(3) +#define LDOA15_VOADJ_SHIFT 4 + +#define REG_LDOV12D_CTRL 0x0021 +#define LDOV12D_ENABLE BIT(0) +#define LDOV12D_STANDBY BIT(1) +#define LDOV12D_VADJ_SHIFT 4 + +#define REG_LDOHCI12_CTRL 0x0022 + +#define REG_LPLDO_CTRL 0x0023 +#define LPLDO_HSM BIT(2) +#define LPLDO_LSM_DIS BIT(3) + +#define REG_AFE_XTAL_CTRL 0x0024 +#define AFE_XTAL_ENABLE BIT(0) +#define AFE_XTAL_B_SELECT BIT(1) +#define AFE_XTAL_RF_GATE BIT(14) +#define AFE_XTAL_BT_GATE BIT(20) + +#define REG_AFE_PLL_CTRL 0x0028 +#define AFE_PLL_ENABLE BIT(0) +#define AFE_PLL_320_ENABLE BIT(1) +#define APE_PLL_FREF_SELECT BIT(2) +#define AFE_PLL_EDGE_SELECT BIT(3) +#define AFE_PLL_WDOGB BIT(4) +#define AFE_PLL_LPF_ENABLE BIT(5) + +#define REG_MAC_PHY_CTRL 0x002c + +#define REG_EFUSE_CTRL 0x0030 +#define REG_EFUSE_TEST 0x0034 +#define EFUSE_TRPT BIT(7) + /* 00: Wifi Efuse, 01: BT Efuse0, 10: BT Efuse1, 11: BT Efuse2 */ +#define EFUSE_CELL_SEL (BIT(8)|BIT(9)) +#define EFUSE_LDOE25_ENABLE BIT(31) +#define EFUSE_SELECT_MASK 0x0300 +#define EFUSE_WIFI_SELECT 0x0000 +#define EFUSE_BT0_SELECT 0x0100 +#define EFUSE_BT1_SELECT 0x0200 +#define EFUSE_BT2_SELECT 0x0300 + +#define EFUSE_ACCESS_ENABLE 0x69 /* RTL8723 only */ +#define EFUSE_ACCESS_DISABLE 0x00 /* RTL8723 only */ + +#define REG_PWR_DATA 0x0038 +#define REG_CAL_TIMER 0x003c +#define REG_ACLK_MON 0x003e +#define REG_GPIO_MUXCFG 0x0040 +#define REG_GPIO_IO_SEL 0x0042 +#define REG_MAC_PINMUX_CFG 0x0043 +#define REG_GPIO_PIN_CTRL 0x0044 +#define REG_GPIO_INTM 0x0048 +#define REG_LEDCFG0 0x004c +#define REG_LEDCFG1 0x004d +#define REG_LEDCFG2 0x004e +#define LEDCFG2_DPDT_SELECT BIT(7) +#define REG_LEDCFG3 0x004f +#define REG_LEDCFG REG_LEDCFG2 +#define REG_FSIMR 0x0050 +#define REG_FSISR 0x0054 +#define REG_HSIMR 0x0058 +#define REG_HSISR 0x005c +/* RTL8723 WIFI/BT/GPS Multi-Function GPIO Pin Control. */ +#define REG_GPIO_PIN_CTRL_2 0x0060 +/* RTL8723 WIFI/BT/GPS Multi-Function GPIO Select. */ +#define REG_GPIO_IO_SEL_2 0x0062 + +/* RTL8723 only WIFI/BT/GPS Multi-Function control source. */ +#define REG_MULTI_FUNC_CTRL 0x0068 + +#define MULTI_FN_WIFI_HW_PWRDOWN_EN BIT(0) /* Enable GPIO[9] as WiFi HW + powerdown source */ +#define MULTI_FN_WIFI_HW_PWRDOWN_SL BIT(1) /* WiFi HW powerdown polarity + control */ +#define MULTI_WIFI_FUNC_EN BIT(2) /* WiFi function enable */ + +#define MULTI_WIFI_HW_ROF_EN BIT(3) /* Enable GPIO[9] as WiFi RF HW + powerdown source */ +#define MULTI_BT_HW_PWRDOWN_EN BIT(16) /* Enable GPIO[11] as BT HW + powerdown source */ +#define MULTI_BT_HW_PWRDOWN_SL BIT(17) /* BT HW powerdown polarity + control */ +#define MULTI_BT_FUNC_EN BIT(18) /* BT function enable */ +#define MULTI_BT_HW_ROF_EN BIT(19) /* Enable GPIO[11] as BT/GPS + RF HW powerdown source */ +#define MULTI_GPS_HW_PWRDOWN_EN BIT(20) /* Enable GPIO[10] as GPS HW + powerdown source */ +#define MULTI_GPS_HW_PWRDOWN_SL BIT(21) /* GPS HW powerdown polarity + control */ +#define MULTI_GPS_FUNC_EN BIT(22) /* GPS function enable */ + + +#define REG_MCU_FW_DL 0x0080 +#define MCU_FW_DL_ENABLE BIT(0) +#define MCU_FW_DL_READY BIT(1) +#define MCU_FW_DL_CSUM_REPORT BIT(2) +#define MCU_MAC_INIT_READY BIT(3) +#define MCU_BB_INIT_READY BIT(4) +#define MCU_RF_INIT_READY BIT(5) +#define MCU_WINT_INIT_READY BIT(6) +#define MCU_FW_RAM_SEL BIT(7) /* 1: RAM, 0:ROM */ +#define MCU_CP_RESET BIT(23) + +#define REG_HMBOX_EXT_0 0x0088 +#define REG_HMBOX_EXT_1 0x008a +#define REG_HMBOX_EXT_2 0x008c +#define REG_HMBOX_EXT_3 0x008e +/* Host suspend counter on FPGA platform */ +#define REG_HOST_SUSP_CNT 0x00bc +/* Efuse access protection for RTL8723 */ +#define REG_EFUSE_ACCESS 0x00cf +#define REG_BIST_SCAN 0x00d0 +#define REG_BIST_RPT 0x00d4 +#define REG_BIST_ROM_RPT 0x00d8 +#define REG_USB_SIE_INTF 0x00e0 +#define REG_PCIE_MIO_INTF 0x00e4 +#define REG_PCIE_MIO_INTD 0x00e8 +#define REG_HPON_FSM 0x00ec +#define REG_SYS_CFG 0x00f0 +#define SYS_CFG_XCLK_VLD BIT(0) +#define SYS_CFG_ACLK_VLD BIT(1) +#define SYS_CFG_UCLK_VLD BIT(2) +#define SYS_CFG_PCLK_VLD BIT(3) +#define SYS_CFG_PCIRSTB BIT(4) +#define SYS_CFG_V15_VLD BIT(5) +#define SYS_CFG_TRP_B15V_EN BIT(7) +#define SYS_CFG_SIC_IDLE BIT(8) +#define SYS_CFG_BD_MAC2 BIT(9) +#define SYS_CFG_BD_MAC1 BIT(10) +#define SYS_CFG_IC_MACPHY_MODE BIT(11) +#define SYS_CFG_CHIP_VER (BIT(12)|BIT(13)|BIT(14)|BIT(15)) +#define SYS_CFG_BT_FUNC BIT(16) +#define SYS_CFG_VENDOR_ID BIT(19) +#define SYS_CFG_PAD_HWPD_IDN BIT(22) +#define SYS_CFG_TRP_VAUX_EN BIT(23) +#define SYS_CFG_TRP_BT_EN BIT(24) +#define SYS_CFG_BD_PKG_SEL BIT(25) +#define SYS_CFG_BD_HCI_SEL BIT(26) +#define SYS_CFG_TYPE_ID BIT(27) +#define SYS_CFG_RTL_ID BIT(23) /* TestChip ID, + 1:Test(RLE); 0:MP(RL) */ +#define SYS_CFG_SPS_SEL BIT(24) /* 1:LDO regulator mode; + 0:Switching regulator mode*/ +#define SYS_CFG_CHIP_VERSION_MASK 0xf000 /* Bit 12 - 15 */ +#define SYS_CFG_CHIP_VERSION_SHIFT 12 + + +#define REG_GPIO_OUTSTS 0x00f4 /* For RTL8723 only. */ +#define GPIO_EFS_HCI_SEL (BIT(0)|BIT(1)) +#define GPIO_PAD_HCI_SEL (BIT(2)|BIT(3)) +#define GPIO_HCI_SEL (BIT(4)|BIT(5)) +#define GPIO_PKG_SEL_HCI BIT(6) +#define GPIO_FEN_GPS BIT(7) +#define GPIO_FEN_BT BIT(8) +#define GPIO_FEN_WL BIT(9) +#define GPIO_FEN_PCI BIT(10) +#define GPIO_FEN_USB BIT(11) +#define GPIO_BTRF_HWPDN_N BIT(12) +#define GPIO_WLRF_HWPDN_N BIT(13) +#define GPIO_PDN_BT_N BIT(14) +#define GPIO_PDN_GPS_N BIT(15) +#define GPIO_BT_CTL_HWPDN BIT(16) +#define GPIO_GPS_CTL_HWPDN BIT(17) +#define GPIO_PPHY_SUSB BIT(20) +#define GPIO_UPHY_SUSB BIT(21) +#define GPIO_PCI_SUSEN BIT(22) +#define GPIO_USB_SUSEN BIT(23) +#define GPIO_RF_RL_ID (BIT(31)|BIT(30)|BIT(29)|BIT(28)) + +/* 0x0100 ~ 0x01FF MACTOP General Configuration */ +#define REG_CR 0x0100 +#define CR_HCI_TXDMA_ENABLE BIT(0) +#define CR_HCI_RXDMA_ENABLE BIT(1) +#define CR_TXDMA_ENABLE BIT(2) +#define CR_RXDMA_ENABLE BIT(3) +#define CR_PROTOCOL_ENABLE BIT(4) +#define CR_SCHEDULE_ENABLE BIT(5) +#define CR_MAC_TX_ENABLE BIT(6) +#define CR_MAC_RX_ENABLE BIT(7) +#define CR_SW_BEACON_ENABLE BIT(8) +#define CR_SECURITY_ENABLE BIT(9) +#define CR_CALTIMER_ENABLE BIT(10) + +/* Media Status Register */ +#define REG_MSR 0x0102 +#define MSR_LINKTYPE_MASK 0x3 +#define MSR_LINKTYPE_NONE 0x0 +#define MSR_LINKTYPE_ADHOC 0x1 +#define MSR_LINKTYPE_STATION 0x2 +#define MSR_LINKTYPE_AP 0x3 + +#define REG_PBP 0x0104 +#define PBP_PAGE_SIZE_RX_SHIFT 0 +#define PBP_PAGE_SIZE_TX_SHIFT 4 +#define PBP_PAGE_SIZE_64 0x0 +#define PBP_PAGE_SIZE_128 0x1 +#define PBP_PAGE_SIZE_256 0x2 +#define PBP_PAGE_SIZE_512 0x3 +#define PBP_PAGE_SIZE_1024 0x4 + +#define REG_TRXDMA_CTRL 0x010c +#define TRXDMA_CTRL_VOQ_SHIFT 4 +#define TRXDMA_CTRL_VIQ_SHIFT 6 +#define TRXDMA_CTRL_BEQ_SHIFT 8 +#define TRXDMA_CTRL_BKQ_SHIFT 10 +#define TRXDMA_CTRL_MGQ_SHIFT 12 +#define TRXDMA_CTRL_HIQ_SHIFT 14 +#define TRXDMA_QUEUE_LOW 1 +#define TRXDMA_QUEUE_NORMAL 2 +#define TRXDMA_QUEUE_HIGH 3 + + +#define REG_TRXFF_BNDY 0x0114 +#define REG_TRXFF_STATUS 0x0118 +#define REG_RXFF_PTR 0x011c +#define REG_HIMR 0x0120 +#define REG_HISR 0x0124 +#define REG_HIMRE 0x0128 +#define REG_HISRE 0x012c +#define REG_CPWM 0x012f +#define REG_FWIMR 0x0130 +#define REG_FWISR 0x0134 +#define REG_PKTBUF_DBG_CTRL 0x0140 +#define REG_PKTBUF_DBG_DATA_L 0x0144 +#define REG_PKTBUF_DBG_DATA_H 0x0148 + +#define REG_TC0_CTRL 0x0150 +#define REG_TC1_CTRL 0x0154 +#define REG_TC2_CTRL 0x0158 +#define REG_TC3_CTRL 0x015c +#define REG_TC4_CTRL 0x0160 +#define REG_TCUNIT_BASE 0x0164 +#define REG_MBIST_START 0x0174 +#define REG_MBIST_DONE 0x0178 +#define REG_MBIST_FAIL 0x017c +#define REG_C2HEVT_MSG_NORMAL 0x01a0 +#define REG_C2HEVT_CLEAR 0x01af +#define REG_C2HEVT_MSG_TEST 0x01b8 +#define REG_MCUTST_1 0x01c0 +#define REG_FMTHR 0x01c8 +#define REG_HMTFR 0x01cc +#define REG_HMBOX_0 0x01d0 +#define REG_HMBOX_1 0x01d4 +#define REG_HMBOX_2 0x01d8 +#define REG_HMBOX_3 0x01dc + +#define REG_LLT_INIT 0x01e0 +#define LLT_OP_INACTIVE 0x0 +#define LLT_OP_WRITE (0x1 << 30) +#define LLT_OP_READ (0x2 << 30) +#define LLT_OP_MASK (0x3 << 30) + +#define REG_BB_ACCEESS_CTRL 0x01e8 +#define REG_BB_ACCESS_DATA 0x01ec + +/* 0x0200 ~ 0x027F TXDMA Configuration */ +#define REG_RQPN 0x0200 +#define RQPN_HI_PQ_SHIFT 0 +#define RQPN_LO_PQ_SHIFT 8 +#define RQPN_NORM_PQ_SHIFT 16 +#define RQPN_LOAD BIT(31) + +#define REG_FIFOPAGE 0x0204 +#define REG_TDECTRL 0x0208 +#define REG_TXDMA_OFFSET_CHK 0x020c +#define REG_TXDMA_STATUS 0x0210 +#define REG_RQPN_NPQ 0x0214 + +/* 0x0280 ~ 0x02FF RXDMA Configuration */ +#define REG_RXDMA_AGG_PG_TH 0x0280 +#define REG_RXPKT_NUM 0x0284 +#define REG_RXDMA_STATUS 0x0288 + +#define REG_RF_BB_CMD_ADDR 0x02c0 +#define REG_RF_BB_CMD_DATA 0x02c4 + +/* spec version 11 */ +/* 0x0400 ~ 0x047F Protocol Configuration */ +#define REG_VOQ_INFORMATION 0x0400 +#define REG_VIQ_INFORMATION 0x0404 +#define REG_BEQ_INFORMATION 0x0408 +#define REG_BKQ_INFORMATION 0x040c +#define REG_MGQ_INFORMATION 0x0410 +#define REG_HGQ_INFORMATION 0x0414 +#define REG_BCNQ_INFORMATION 0x0418 + + +#define REG_CPU_MGQ_INFORMATION 0x041c +#define REG_FWHW_TXQ_CTRL 0x0420 +#define FWHW_TXQ_CTRL_AMPDU_RETRY BIT(7) +#define FWHW_TXQ_CTRL_XMIT_MGMT_ACK BIT(12) + +#define REG_HWSEQ_CTRL 0x0423 +#define REG_TXPKTBUF_BCNQ_BDNY 0x0424 +#define REG_TXPKTBUF_MGQ_BDNY 0x0425 +#define REG_LIFETIME_EN 0x0426 +#define REG_MULTI_BCNQ_OFFSET 0x0427 + +#define REG_SPEC_SIFS 0x0428 +#define SPEC_SIFS_CCK_MASK 0x00ff +#define SPEC_SIFS_CCK_SHIFT 0 +#define SPEC_SIFS_OFDM_MASK 0xff00 +#define SPEC_SIFS_OFDM_SHIFT 8 + +#define REG_RETRY_LIMIT 0x042a +#define RETRY_LIMIT_LONG_SHIFT 0 +#define RETRY_LIMIT_LONG_MASK 0x003f +#define RETRY_LIMIT_SHORT_SHIFT 8 +#define RETRY_LIMIT_SHORT_MASK 0x3f00 + +#define REG_DARFRC 0x0430 +#define REG_RARFRC 0x0438 +#define REG_RESPONSE_RATE_SET 0x0440 +#define RESPONSE_RATE_BITMAP_ALL 0xfffff +#define RESPONSE_RATE_RRSR_CCK_ONLY_1M 0xffff1 +#define RSR_1M BIT(0) +#define RSR_2M BIT(1) +#define RSR_5_5M BIT(2) +#define RSR_11M BIT(3) +#define RSR_6M BIT(4) +#define RSR_9M BIT(5) +#define RSR_12M BIT(6) +#define RSR_18M BIT(7) +#define RSR_24M BIT(8) +#define RSR_36M BIT(9) +#define RSR_48M BIT(10) +#define RSR_54M BIT(11) +#define RSR_MCS0 BIT(12) +#define RSR_MCS1 BIT(13) +#define RSR_MCS2 BIT(14) +#define RSR_MCS3 BIT(15) +#define RSR_MCS4 BIT(16) +#define RSR_MCS5 BIT(17) +#define RSR_MCS6 BIT(18) +#define RSR_MCS7 BIT(19) +#define RSR_RSC_LOWER_SUB_CHANNEL BIT(21) /* 0x200000 */ +#define RSR_RSC_UPPER_SUB_CHANNEL BIT(22) /* 0x400000 */ +#define RSR_RSC_BANDWIDTH_40M (RSR_RSC_UPPER_SUB_CHANNEL|\ + RSR_RSC_LOWER_SUB_CHANNEL) +#define RSR_ACK_SHORT_PREAMBLE BIT(23) + +#define REG_ARFR0 0x0444 +#define REG_ARFR1 0x0448 +#define REG_ARFR2 0x044c +#define REG_ARFR3 0x0450 +#define REG_AGGLEN_LMT 0x0458 +#define REG_AMPDU_MIN_SPACE 0x045c +#define REG_TXPKTBUF_WMAC_LBK_BF_HD 0x045d +#define REG_FAST_EDCA_CTRL 0x0460 +#define REG_RD_RESP_PKT_TH 0x0463 +#define REG_INIRTS_RATE_SEL 0x0480 +#define REG_INIDATA_RATE_SEL 0x0484 + + +#define REG_POWER_STATUS 0x04a4 +#define REG_POWER_STAGE1 0x04b4 +#define REG_POWER_STAGE2 0x04b8 +#define REG_PKT_VO_VI_LIFE_TIME 0x04c0 +#define REG_PKT_BE_BK_LIFE_TIME 0x04c2 +#define REG_STBC_SETTING 0x04c4 +#define REG_PROT_MODE_CTRL 0x04c8 +#define REG_MAX_AGGR_NUM 0x04ca +#define REG_RTS_MAX_AGGR_NUM 0x04cb +#define REG_BAR_MODE_CTRL 0x04cc +#define REG_RA_TRY_RATE_AGG_LMT 0x04cf +#define REG_NQOS_SEQ 0x04dc +#define REG_QOS_SEQ 0x04de +#define REG_NEED_CPU_HANDLE 0x04e0 +#define REG_PKT_LOSE_RPT 0x04e1 +#define REG_PTCL_ERR_STATUS 0x04e2 +#define REG_DUMMY 0x04fc + + + +/* 0x0500 ~ 0x05FF EDCA Configuration */ +#define REG_EDCA_VO_PARAM 0x0500 +#define REG_EDCA_VI_PARAM 0x0504 +#define REG_EDCA_BE_PARAM 0x0508 +#define REG_EDCA_BK_PARAM 0x050c +#define EDCA_PARAM_ECW_MIN_SHIFT 8 +#define EDCA_PARAM_ECW_MAX_SHIFT 12 +#define EDCA_PARAM_TXOP_SHIFT 16 +#define REG_BEACON_TCFG 0x0510 +#define REG_PIFS 0x0512 +#define REG_RDG_PIFS 0x0513 +#define REG_SIFS_CCK 0x0514 +#define REG_SIFS_OFDM 0x0516 +#define REG_TSFTR_SYN_OFFSET 0x0518 +#define REG_AGGR_BREAK_TIME 0x051a +#define REG_SLOT 0x051b +#define REG_TX_PTCL_CTRL 0x0520 +#define REG_TXPAUSE 0x0522 +#define REG_DIS_TXREQ_CLR 0x0523 +#define REG_RD_CTRL 0x0524 +#define REG_TBTT_PROHIBIT 0x0540 +#define REG_RD_NAV_NXT 0x0544 +#define REG_NAV_PROT_LEN 0x0546 + +#define REG_BEACON_CTRL 0x0550 +#define REG_BEACON_CTRL_1 0x0551 +#define BEACON_ATIM BIT(0) +#define BEACON_CTRL_MBSSID BIT(1) +#define BEACON_CTRL_TX_BEACON_RPT BIT(2) +#define BEACON_FUNCTION_ENABLE BIT(3) +#define BEACON_DISABLE_TSF_UPDATE BIT(4) + +#define REG_MBID_NUM 0x0552 +#define REG_DUAL_TSF_RST 0x0553 + /* The same as REG_MBSSID_BCN_SPACE */ +#define REG_BCN_INTERVAL 0x0554 +#define REG_MBSSID_BCN_SPACE 0x0554 + +#define REG_DRIVER_EARLY_INT 0x0558 +#define DRIVER_EARLY_INT_TIME 5 + +#define REG_BEACON_DMA_TIME 0x0559 +#define BEACON_DMA_ATIME_INT_TIME 2 + +#define REG_ATIMWND 0x055a +#define REG_BCN_MAX_ERR 0x055d +#define REG_RXTSF_OFFSET_CCK 0x055e +#define REG_RXTSF_OFFSET_OFDM 0x055f +#define REG_TSFTR 0x0560 +#define REG_TSFTR1 0x0568 +#define REG_INIT_TSFTR 0x0564 +#define REG_ATIMWND_1 0x0570 +#define REG_PSTIMER 0x0580 +#define REG_TIMER0 0x0584 +#define REG_TIMER1 0x0588 +#define REG_ACM_HW_CTRL 0x05c0 +#define ACM_HW_CTRL_BK BIT(0) +#define ACM_HW_CTRL_BE BIT(1) +#define ACM_HW_CTRL_VI BIT(2) +#define ACM_HW_CTRL_VO BIT(3) +#define REG_ACM_RST_CTRL 0x05c1 +#define REG_ACMAVG 0x05c2 +#define REG_VO_ADMTIME 0x05c4 +#define REG_VI_ADMTIME 0x05c6 +#define REG_BE_ADMTIME 0x05c8 +#define REG_EDCA_RANDOM_GEN 0x05cc +#define REG_SCH_TXCMD 0x05d0 + +/* define REG_FW_TSF_SYNC_CNT 0x04a0 */ +#define REG_FW_RESET_TSF_CNT_1 0x05fc +#define REG_FW_RESET_TSF_CNT_0 0x05fd +#define REG_FW_BCN_DIS_CNT 0x05fe + +/* 0x0600 ~ 0x07FF WMAC Configuration */ +#define REG_APSD_CTRL 0x0600 +#define REG_BW_OPMODE 0x0603 +#define BW_OPMODE_20MHZ BIT(2) +#define BW_OPMODE_5G BIT(1) +#define BW_OPMODE_11J BIT(0) + +#define REG_TCR 0x0604 + +/* Receive Configuration Register */ +#define REG_RCR 0x0608 +#define RCR_ACCEPT_AP BIT(0) /* Accept all unicast packet */ +#define RCR_ACCEPT_PHYS_MATCH BIT(1) /* Accept phys match packet */ +#define RCR_ACCEPT_MCAST BIT(2) +#define RCR_ACCEPT_BCAST BIT(3) +#define RCR_ACCEPT_ADDR3 BIT(4) /* Accept address 3 match + packet */ +#define RCR_ACCEPT_PM BIT(5) /* Accept power management + packet */ +#define RCR_CHECK_BSSID_MATCH BIT(6) /* Accept BSSID match packet */ +#define RCR_CHECK_BSSID_BEACON BIT(7) /* Accept BSSID match packet + (Rx beacon, probe rsp) */ +#define RCR_ACCEPT_CRC32 BIT(8) /* Accept CRC32 error packet */ +#define RCR_ACCEPT_ICV BIT(9) /* Accept ICV error packet */ +#define RCR_ACCEPT_DATA_FRAME BIT(11) +#define RCR_ACCEPT_CTRL_FRAME BIT(12) +#define RCR_ACCEPT_MGMT_FRAME BIT(13) +#define RCR_HTC_LOC_CTRL BIT(14) /* MFC<--HTC=1 MFC-->HTC=0 */ +#define RCR_MFBEN BIT(22) +#define RCR_LSIGEN BIT(23) +#define RCR_MULTI_BSSID_ENABLE BIT(24) /* Enable Multiple BssId */ +#define RCR_ACCEPT_BA_SSN BIT(27) /* Accept BA SSN */ +#define RCR_APPEND_PHYSTAT BIT(28) +#define RCR_APPEND_ICV BIT(29) +#define RCR_APPEND_MIC BIT(30) +#define RCR_APPEND_FCS BIT(31) /* WMAC append FCS after */ + +#define REG_RX_PKT_LIMIT 0x060c +#define REG_RX_DLK_TIME 0x060d +#define REG_RX_DRVINFO_SZ 0x060f + +#define REG_MACID 0x0610 +#define REG_BSSID 0x0618 +#define REG_MAR 0x0620 +#define REG_MBIDCAMCFG 0x0628 + +#define REG_USTIME_EDCA 0x0638 +#define REG_MAC_SPEC_SIFS 0x063a + +/* 20100719 Joseph: Hardware register definition change. (HW datasheet v54) */ + /* [15:8]SIFS_R2T_OFDM, [7:0]SIFS_R2T_CCK */ +#define REG_R2T_SIFS 0x063c + /* [15:8]SIFS_T2T_OFDM, [7:0]SIFS_T2T_CCK */ +#define REG_T2T_SIFS 0x063e +#define REG_ACKTO 0x0640 +#define REG_CTS2TO 0x0641 +#define REG_EIFS 0x0642 + +/* WMA, BA, CCX */ +#define REG_NAV_CTRL 0x0650 +/* In units of 128us */ +#define REG_NAV_UPPER 0x0652 +#define NAV_UPPER_UNIT 128 + +#define REG_BACAMCMD 0x0654 +#define REG_BACAMCONTENT 0x0658 +#define REG_LBDLY 0x0660 +#define REG_FWDLY 0x0661 +#define REG_RXERR_RPT 0x0664 +#define REG_WMAC_TRXPTCL_CTL 0x0668 + + +/* Security */ +#define REG_CAM_CMD 0x0670 +#define CAM_CMD_POLLING BIT(31) +#define CAM_CMD_WRITE BIT(16) +#define CAM_CMD_KEY_SHIFT 3 +#define REG_CAM_WRITE 0x0674 +#define CAM_WRITE_VALID BIT(15) +#define REG_CAM_READ 0x0678 +#define REG_CAM_DEBUG 0x067c +#define REG_SECURITY_CFG 0x0680 +#define SEC_CFG_TX_USE_DEFKEY BIT(0) +#define SEC_CFG_RX_USE_DEFKEY BIT(1) +#define SEC_CFG_TX_SEC_ENABLE BIT(2) +#define SEC_CFG_RX_SEC_ENABLE BIT(3) +#define SEC_CFG_SKByA2 BIT(4) +#define SEC_CFG_NO_SKMC BIT(5) +#define SEC_CFG_TXBC_USE_DEFKEY BIT(6) +#define SEC_CFG_RXBC_USE_DEFKEY BIT(7) + +/* Power */ +#define REG_WOW_CTRL 0x0690 +#define REG_PSSTATUS 0x0691 +#define REG_PS_RX_INFO 0x0692 +#define REG_LPNAV_CTRL 0x0694 +#define REG_WKFMCAM_CMD 0x0698 +#define REG_WKFMCAM_RWD 0x069c +#define REG_RXFLTMAP0 0x06a0 +#define REG_RXFLTMAP1 0x06a2 +#define REG_RXFLTMAP2 0x06a4 +#define REG_BCN_PSR_RPT 0x06a8 +#define REG_CALB32K_CTRL 0x06ac +#define REG_PKT_MON_CTRL 0x06b4 +#define REG_BT_COEX_TABLE 0x06c0 +#define REG_WMAC_RESP_TXINFO 0x06d8 + +#define REG_MACID1 0x0700 +#define REG_BSSID1 0x0708 + +#define REG_FPGA0_RF_MODE 0x0800 +#define FPGA_RF_MODE BIT(0) +#define FPGA_RF_MODE_JAPAN BIT(1) +#define FPGA_RF_MODE_CCK BIT(24) +#define FPGA_RF_MODE_OFDM BIT(25) + +#define REG_FPGA0_TXINFO 0x0804 +#define REG_FPGA0_PSD_FUNC 0x0808 +#define REG_FPGA0_TX_GAIN 0x080c +#define REG_FPGA0_POWER_SAVE 0x0818 +#define FPGA0_PS_LOWER_CHANNEL BIT(26) +#define FPGA0_PS_UPPER_CHANNEL BIT(27) + +#define REG_FPGA0_XA_HSSI_PARM1 0x0820 /* RF 3 wire register */ +#define FPGA0_HSSI_PARM1_PI BIT(8) +#define REG_FPGA0_XA_HSSI_PARM2 0x0824 +#define REG_FPGA0_XB_HSSI_PARM1 0x0828 +#define REG_FPGA0_XB_HSSI_PARM2 0x082c +#define FPGA0_HSSI_3WIRE_DATA_LEN 0x800 +#define FPGA0_HSSI_3WIRE_ADDR_LEN 0x400 +#define FPGA0_HSSI_PARM2_ADDR_SHIFT 23 +#define FPGA0_HSSI_PARM2_ADDR_MASK 0x7f800000 /* 0xff << 23 */ +#define FPGA0_HSSI_PARM2_CCK_HIGH_PWR BIT(9) +#define FPGA0_HSSI_PARM2_EDGE_READ BIT(31) + +#define REG_TX_AGC_B_RATE18_06 0x0830 +#define REG_TX_AGC_B_RATE54_24 0x0834 +#define REG_TX_AGC_B_CCK1_55_MCS32 0x0838 +#define REG_TX_AGC_B_MCS03_MCS00 0x083c + +#define REG_FPGA0_XA_LSSI_PARM 0x0840 +#define REG_FPGA0_XB_LSSI_PARM 0x0844 +#define FPGA0_LSSI_PARM_ADDR_SHIFT 20 +#define FPGA0_LSSI_PARM_ADDR_MASK 0x0ff00000 +#define FPGA0_LSSI_PARM_DATA_MASK 0x000fffff + +#define REG_TX_AGC_B_MCS07_MCS04 0x0848 +#define REG_TX_AGC_B_MCS11_MCS08 0x084c + +#define REG_FPGA0_XCD_SWITCH_CTRL 0x085c + +#define REG_FPGA0_XA_RF_INT_OE 0x0860 /* RF Channel switch */ +#define REG_FPGA0_XB_RF_INT_OE 0x0864 +#define FPGA0_INT_OE_ANTENNA_AB_OPEN 0x000 +#define FPGA0_INT_OE_ANTENNA_A 0x100 +#define FPGA0_INT_OE_ANTENNA_B 0x200 +#define FPGA0_INT_OE_ANTENNA_MASK 0x300 + +#define REG_TX_AGC_B_MCS15_MCS12 0x0868 +#define REG_TX_AGC_B_CCK11_A_CCK2_11 0x086c + +#define REG_FPGA0_XAB_RF_SW_CTRL 0x0870 +#define REG_FPGA0_XA_RF_SW_CTRL 0x0870 /* 16 bit */ +#define REG_FPGA0_XB_RF_SW_CTRL 0x0872 /* 16 bit */ +#define REG_FPGA0_XCD_RF_SW_CTRL 0x0874 +#define REG_FPGA0_XC_RF_SW_CTRL 0x0874 /* 16 bit */ +#define REG_FPGA0_XD_RF_SW_CTRL 0x0876 /* 16 bit */ +#define FPGA0_RF_3WIRE_DATA 0x1 +#define FPGA0_RF_3WIRE_CLOC 0x2 +#define FPGA0_RF_3WIRE_LOAD 0x4 +#define FPGA0_RF_3WIRE_RW 0x8 +#define FPGA0_RF_3WIRE_MASK 0xf +#define FPGA0_RF_RFENV 0x10 +#define FPGA0_RF_TRSW 0x20 /* Useless now */ +#define FPGA0_RF_TRSWB 0x40 +#define FPGA0_RF_ANTSW 0x100 +#define FPGA0_RF_ANTSWB 0x200 +#define FPGA0_RF_PAPE 0x400 +#define FPGA0_RF_PAPE5G 0x800 + +#define REG_FPGA0_XAB_RF_PARM 0x0878 /* Antenna select path in ODM */ +#define REG_FPGA0_XA_RF_PARM 0x0878 /* 16 bit */ +#define REG_FPGA0_XB_RF_PARM 0x087a /* 16 bit */ +#define REG_FPGA0_XCD_RF_PARM 0x087c +#define REG_FPGA0_XC_RF_PARM 0x087c /* 16 bit */ +#define REG_FPGA0_XD_RF_PARM 0x087e /* 16 bit */ + +#define REG_FPGA0_ANALOG1 0x0880 +#define REG_FPGA0_ANALOG2 0x0884 +#define REG_FPGA0_ANALOG3 0x0888 +#define REG_FPGA0_ANALOG4 0x088c + +#define REG_FPGA0_XA_LSSI_READBACK 0x08a0 /* Tranceiver LSSI Readback */ +#define REG_FPGA0_XB_LSSI_READBACK 0x08a4 +#define REG_HSPI_XA_READBACK 0x08b8 /* Transceiver A HSPI read */ +#define REG_HSPI_XB_READBACK 0x08bc /* Transceiver B HSPI read */ + +#define REG_FPGA1_RF_MODE 0x0900 + +#define REG_CCK0_SYSTEM 0x0a00 +#define CCK0_SIDEBAND BIT(4) + +#define REG_CONFIG_ANT_A 0x0b68 +#define REG_CONFIG_ANT_B 0x0b6c + +#define REG_OFDM0_TRX_PATH_ENABLE 0x0c04 +#define OFDM0_RF_PATH_RX_MASK 0x0f + +#define REG_OFDM0_TR_MUX_PAR 0x0c08 + +#define REG_OFDM0_XA_RX_IQ_IMBALANCE 0x0c14 +#define REG_OFDM0_XB_RX_IQ_IMBALANCE 0x0c1c + +#define REG_OFDM0_ENERGY_CCA_THRES 0x0c4c + +#define REG_OFDM0_XA_AGC_CORE1 0x0c50 +#define REG_OFDM0_XA_AGC_CORE2 0x0c54 +#define REG_OFDM0_XB_AGC_CORE1 0x0c58 +#define REG_OFDM0_XB_AGC_CORE2 0x0c5c +#define REG_OFDM0_XC_AGC_CORE1 0x0c60 +#define REG_OFDM0_XC_AGC_CORE2 0x0c64 +#define REG_OFDM0_XD_AGC_CORE1 0x0c68 +#define REG_OFDM0_XD_AGC_CORE2 0x0c6c +#define OFDM0_X_AGC_CORE1_IGI_MASK 0x0000007F + +#define REG_OFDM0_AGCR_SSI_TABLE 0x0c78 + +#define REG_OFDM0_XA_TX_IQ_IMBALANCE 0x0c80 +#define REG_OFDM0_XB_TX_IQ_IMBALANCE 0x0c88 +#define REG_OFDM0_XC_TX_IQ_IMBALANCE 0x0c90 +#define REG_OFDM0_XD_TX_IQ_IMBALANCE 0x0c98 + +#define REG_OFDM0_XC_TX_AFE 0x0c94 +#define REG_OFDM0_XD_TX_AFE 0x0c9c + +#define REG_OFDM0_RX_IQ_EXT_ANTA 0x0ca0 + +#define REG_OFDM1_LSTF 0x0d00 +#define OFDM_CONTINUE_TX 0x10000000 +#define OFDM_SINGLE_CARRIER 0x20000000 +#define OFDM_SINGLE_TONE 0x40000000 +#define OFDM_LSTF_MASK 0x70000000 + +#define REG_OFDM1_TRX_PATH_ENABLE 0x0d04 + +#define REG_TX_AGC_A_RATE18_06 0x0e00 +#define REG_TX_AGC_A_RATE54_24 0x0e04 +#define REG_TX_AGC_A_CCK1_MCS32 0x0e08 +#define REG_TX_AGC_A_MCS03_MCS00 0x0e10 +#define REG_TX_AGC_A_MCS07_MCS04 0x0e14 +#define REG_TX_AGC_A_MCS11_MCS08 0x0e18 +#define REG_TX_AGC_A_MCS15_MCS12 0x0e1c + +#define REG_FPGA0_IQK 0x0e28 + +#define REG_TX_IQK_TONE_A 0x0e30 +#define REG_RX_IQK_TONE_A 0x0e34 +#define REG_TX_IQK_PI_A 0x0e38 +#define REG_RX_IQK_PI_A 0x0e3c + +#define REG_TX_IQK 0x0e40 +#define REG_RX_IQK 0x0e44 +#define REG_IQK_AGC_PTS 0x0e48 +#define REG_IQK_AGC_RSP 0x0e4c +#define REG_TX_IQK_TONE_B 0x0e50 +#define REG_RX_IQK_TONE_B 0x0e54 +#define REG_TX_IQK_PI_B 0x0e58 +#define REG_RX_IQK_PI_B 0x0e5c +#define REG_IQK_AGC_CONT 0x0e60 + +#define REG_BLUETOOTH 0x0e6c +#define REG_RX_WAIT_CCA 0x0e70 +#define REG_TX_CCK_RFON 0x0e74 +#define REG_TX_CCK_BBON 0x0e78 +#define REG_TX_OFDM_RFON 0x0e7c +#define REG_TX_OFDM_BBON 0x0e80 +#define REG_TX_TO_RX 0x0e84 +#define REG_TX_TO_TX 0x0e88 +#define REG_RX_CCK 0x0e8c + +#define REG_TX_POWER_BEFORE_IQK_A 0x0e94 +#define REG_TX_POWER_AFTER_IQK_A 0x0e9c + +#define REG_RX_POWER_BEFORE_IQK_A 0x0ea0 +#define REG_RX_POWER_BEFORE_IQK_A_2 0x0ea4 +#define REG_RX_POWER_AFTER_IQK_A 0x0ea8 +#define REG_RX_POWER_AFTER_IQK_A_2 0x0eac + +#define REG_TX_POWER_BEFORE_IQK_B 0x0eb4 +#define REG_TX_POWER_AFTER_IQK_B 0x0ebc + +#define REG_RX_POWER_BEFORE_IQK_B 0x0ec0 +#define REG_RX_POWER_BEFORE_IQK_B_2 0x0ec4 +#define REG_RX_POWER_AFTER_IQK_B 0x0ec8 +#define REG_RX_POWER_AFTER_IQK_B_2 0x0ecc + +#define REG_RX_OFDM 0x0ed0 +#define REG_RX_WAIT_RIFS 0x0ed4 +#define REG_RX_TO_RX 0x0ed8 +#define REG_STANDBY 0x0edc +#define REG_SLEEP 0x0ee0 +#define REG_PMPD_ANAEN 0x0eec + +#define REG_8723A_FW_START_ADDRESS 0x1000 + +#define REG_USB_INFO 0xfe17 +#define REG_USB_HIMR 0xfe38 +#define USB_HIMR_TIMEOUT2 BIT(31) +#define USB_HIMR_TIMEOUT1 BIT(30) +#define USB_HIMR_PSTIMEOUT BIT(29) +#define USB_HIMR_GTINT4 BIT(28) +#define USB_HIMR_GTINT3 BIT(27) +#define USB_HIMR_TXBCNERR BIT(26) +#define USB_HIMR_TXBCNOK BIT(25) +#define USB_HIMR_TSF_BIT32_TOGGLE BIT(24) +#define USB_HIMR_BCNDMAINT3 BIT(23) +#define USB_HIMR_BCNDMAINT2 BIT(22) +#define USB_HIMR_BCNDMAINT1 BIT(21) +#define USB_HIMR_BCNDMAINT0 BIT(20) +#define USB_HIMR_BCNDOK3 BIT(19) +#define USB_HIMR_BCNDOK2 BIT(18) +#define USB_HIMR_BCNDOK1 BIT(17) +#define USB_HIMR_BCNDOK0 BIT(16) +#define USB_HIMR_HSISR_IND BIT(15) +#define USB_HIMR_BCNDMAINT_E BIT(14) +/* RSVD BIT(13) */ +#define USB_HIMR_CTW_END BIT(12) +/* RSVD BIT(11) */ +#define USB_HIMR_C2HCMD BIT(10) +#define USB_HIMR_CPWM2 BIT(9) +#define USB_HIMR_CPWM BIT(8) +#define USB_HIMR_HIGHDOK BIT(7) /* High Queue DMA OK + Interrupt */ +#define USB_HIMR_MGNTDOK BIT(6) /* Management Queue DMA OK + Interrupt */ +#define USB_HIMR_BKDOK BIT(5) /* AC_BK DMA OK Interrupt */ +#define USB_HIMR_BEDOK BIT(4) /* AC_BE DMA OK Interrupt */ +#define USB_HIMR_VIDOK BIT(3) /* AC_VI DMA OK Interrupt */ +#define USB_HIMR_VODOK BIT(2) /* AC_VO DMA Interrupt */ +#define USB_HIMR_RDU BIT(1) /* Receive Descriptor + Unavailable */ +#define USB_HIMR_ROK BIT(0) /* Receive DMA OK Interrupt */ + +#define REG_USB_SPECIAL_OPTION 0xfe55 +#define REG_USB_DMA_AGG_TO 0xfe5b +#define REG_USB_AGG_TO 0xfe5c +#define REG_USB_AGG_TH 0xfe5d + +#define REG_NORMAL_SIE_VID 0xfe60 /* 0xfe60 - 0xfe61 */ +#define REG_NORMAL_SIE_PID 0xfe62 /* 0xfe62 - 0xfe63 */ +#define REG_NORMAL_SIE_OPTIONAL 0xfe64 +#define REG_NORMAL_SIE_EP 0xfe65 /* 0xfe65 - 0xfe67 */ +#define REG_NORMAL_SIE_EP_TX 0xfe66 +#define NORMAL_SIE_EP_TX_HIGH_MASK 0x000f +#define NORMAL_SIE_EP_TX_NORMAL_MASK 0x00f0 +#define NORMAL_SIE_EP_TX_LOW_MASK 0x0f00 + +#define REG_NORMAL_SIE_PHY 0xfe68 /* 0xfe68 - 0xfe6b */ +#define REG_NORMAL_SIE_OPTIONAL2 0xfe6c +#define REG_NORMAL_SIE_GPS_EP 0xfe6d /* RTL8723 only */ +#define REG_NORMAL_SIE_MAC_ADDR 0xfe70 /* 0xfe70 - 0xfe75 */ +#define REG_NORMAL_SIE_STRING 0xfe80 /* 0xfe80 - 0xfedf */ + +/* RF6052 registers */ +#define RF6052_REG_AC 0x00 +#define RF6052_REG_IQADJ_G1 0x01 +#define RF6052_REG_IQADJ_G2 0x02 +#define RF6052_REG_BS_PA_APSET_G1_G4 0x03 +#define RF6052_REG_BS_PA_APSET_G5_G8 0x04 +#define RF6052_REG_POW_TRSW 0x05 +#define RF6052_REG_GAIN_RX 0x06 +#define RF6052_REG_GAIN_TX 0x07 +#define RF6052_REG_TXM_IDAC 0x08 +#define RF6052_REG_IPA_G 0x09 +#define RF6052_REG_TXBIAS_G 0x0a +#define RF6052_REG_TXPA_AG 0x0b +#define RF6052_REG_IPA_A 0x0c +#define RF6052_REG_TXBIAS_A 0x0d +#define RF6052_REG_BS_PA_APSET_G9_G11 0x0e +#define RF6052_REG_BS_IQGEN 0x0f +#define RF6052_REG_MODE1 0x10 +#define RF6052_REG_MODE2 0x11 +#define RF6052_REG_RX_AGC_HP 0x12 +#define RF6052_REG_TX_AGC 0x13 +#define RF6052_REG_BIAS 0x14 +#define RF6052_REG_IPA 0x15 +#define RF6052_REG_TXBIAS 0x16 +#define RF6052_REG_POW_ABILITY 0x17 +#define RF6052_REG_MODE_AG 0x18 /* RF channel and BW switch */ +#define MODE_AG_CHANNEL_MASK 0x3ff +#define MODE_AG_CHANNEL_20MHZ BIT(10) + +#define RF6052_REG_TOP 0x19 +#define RF6052_REG_RX_G1 0x1a +#define RF6052_REG_RX_G2 0x1b +#define RF6052_REG_RX_BB2 0x1c +#define RF6052_REG_RX_BB1 0x1d +#define RF6052_REG_RCK1 0x1e +#define RF6052_REG_RCK2 0x1f +#define RF6052_REG_TX_G1 0x20 +#define RF6052_REG_TX_G2 0x21 +#define RF6052_REG_TX_G3 0x22 +#define RF6052_REG_TX_BB1 0x23 +#define RF6052_REG_T_METER 0x24 +#define RF6052_REG_SYN_G1 0x25 /* RF TX Power control */ +#define RF6052_REG_SYN_G2 0x26 /* RF TX Power control */ +#define RF6052_REG_SYN_G3 0x27 /* RF TX Power control */ +#define RF6052_REG_SYN_G4 0x28 /* RF TX Power control */ +#define RF6052_REG_SYN_G5 0x29 /* RF TX Power control */ +#define RF6052_REG_SYN_G6 0x2a /* RF TX Power control */ +#define RF6052_REG_SYN_G7 0x2b /* RF TX Power control */ +#define RF6052_REG_SYN_G8 0x2c /* RF TX Power control */ + +#define RF6052_REG_RCK_OS 0x30 /* RF TX PA control */ + +#define RF6052_REG_TXPA_G1 0x31 /* RF TX PA control */ +#define RF6052_REG_TXPA_G2 0x32 /* RF TX PA control */ +#define RF6052_REG_TXPA_G3 0x33 /* RF TX PA control */ -- 2.1.0 ^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-03-06 22:15 ` [PATCH 1/1] " Jes.Sorensen @ 2015-03-06 22:59 ` Joe Perches 2015-03-07 5:18 ` Jes Sorensen 2015-03-07 21:30 ` Larry Finger 1 sibling, 1 reply; 35+ messages in thread From: Joe Perches @ 2015-03-06 22:59 UTC (permalink / raw) To: Jes.Sorensen; +Cc: linux-wireless, Larry.Finger On Fri, 2015-03-06 at 17:15 -0500, Jes.Sorensen@redhat.com wrote: > From: Jes Sorensen <Jes.Sorensen@redhat.com> > > This is an alternate driver for the Realtek 8723AU (rtl8723au) written > from scratch utilizing the mac80211 stack. > > After spending months cleaning up the vendor provided rtl8723au > driver, which comes with it's own 802.11 stack included, I decided to > rewrite this driver from the bottom up. > > Many thanks to Johannes Berg for 802.11 insights and help and Larry > Finger for help with the vendor driver. cool. I hope it can be fairly modular so that it can be extensible to support multiple devices more sensibly than the realtek code. btw: Here are some trivial checkpatch cleanups. There are a few places where it seems there are missing braces because indentation changes occur. see: @@ -1245,11 +1242,11 @@ static int rtl8xxxu_read_efuse(struct rtl8xxxu_priv *priv) @@ -2540,10 +2534,10 @@ void rtl8xxxu_set_ampdu_factor(struct rtl8xxxu_priv *priv, u8 ampdu_factor) and +++ b/drivers/net/wireless/rtl8xxxu.h [] struct rtl8723au_idx { -#if defined (__LITTLE_ENDIAN) +#if defined(__LITTLE_ENDIAN) int a:4; int b:4; -#elif defined (__LITTLE_ENDIAN) +#elif defined(__LITTLE_ENDIAN) int b:4; int a:4; Presumably the second should be __BIG_ENDIAN. --- drivers/net/wireless/rtl8xxxu.c | 124 ++++++++++++++++------------------- drivers/net/wireless/rtl8xxxu.h | 9 ++- drivers/net/wireless/rtl8xxxu_regs.h | 22 ++----- 3 files changed, 69 insertions(+), 86 deletions(-) diff --git a/drivers/net/wireless/rtl8xxxu.c b/drivers/net/wireless/rtl8xxxu.c index 6728a74..af1c44d 100644 --- a/drivers/net/wireless/rtl8xxxu.c +++ b/drivers/net/wireless/rtl8xxxu.c @@ -677,8 +677,8 @@ static int rtl8723a_h2c_cmd(struct rtl8xxxu_priv *priv, struct h2c_cmd *h2c) pr_debug("H2C_EXT %04x\n", le16_to_cpu(h2c->raw.ext)); } rtl8723au_write32(priv, mbox_reg, le32_to_cpu(h2c->raw.data)); - if (rtl8xxxu_debug & RTL8XXXU_DEBUG_H2C) - pr_debug("H2C %08x\n", le16_to_cpu(h2c->raw.data)); + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_H2C) + pr_debug("H2C %08x\n", le16_to_cpu(h2c->raw.data)); priv->next_mbox = (mbox_nr + 1) % H2C_MAX_MBOX; @@ -757,7 +757,6 @@ static void rtl8723a_disable_rf(struct rtl8xxxu_priv *priv) rtl8723au_write8(priv, REG_SPS0_CTRL, sps0); } - static void rtl8723a_stop_tx_beacon(struct rtl8xxxu_priv *priv) { u8 val8; @@ -774,7 +773,6 @@ static void rtl8723a_stop_tx_beacon(struct rtl8xxxu_priv *priv) rtl8723au_write8(priv, REG_TBTT_PROHIBIT + 2, val8); } - /* * The rtl8723a has 3 channel groups for it's efuse settings. It only * supports the 2.4GHz band, so channels 1 - 14: @@ -834,9 +832,9 @@ static void rtl8723au_config_channel(struct ieee80211_hw *hw) rtl8723au_write32(priv, REG_FPGA0_ANALOG2, val32); break; case NL80211_CHAN_WIDTH_40: - if (hw->conf.chandef.center_freq1 > + if (hw->conf.chandef.center_freq1 > hw->conf.chandef.chan->center_freq) - sec_ch_above = 1; + sec_ch_above = 1; else sec_ch_above = 0; @@ -935,8 +933,7 @@ rtl8723a_set_tx_power(struct rtl8xxxu_priv *priv, int channel, bool ht40) } if (rtl8xxxu_debug & RTL8XXXU_DEBUG_CHANNEL) - pr_debug("%s: Setting TX power CCK A: %02x, " - "CCK B: %02x, OFDM A: %02x, OFDM B: %02x\n", + pr_debug("%s: Setting TX power CCK A: %02x, CCK B: %02x, OFDM A: %02x, OFDM B: %02x\n", DRIVER_NAME, cck[0], cck[1], ofdm[0], ofdm[1]); for (i = 0; i < RTL8723A_MAX_RF_PATHS; i++) { @@ -977,9 +974,9 @@ rtl8723a_set_tx_power(struct rtl8xxxu_priv *priv, int channel, bool ht40) mcsbase[1] += efuse->ht20_tx_power_index_diff[group].b; ofdm_a = ofdmbase[0] | ofdmbase[0] << 8 | - ofdmbase[0] << 16 | ofdmbase[0] <<24; + ofdmbase[0] << 16 | ofdmbase[0] << 24; ofdm_b = ofdmbase[1] | ofdmbase[1] << 8 | - ofdmbase[1] << 16 | ofdmbase[1] <<24; + ofdmbase[1] << 16 | ofdmbase[1] << 24; rtl8723au_write32(priv, REG_TX_AGC_A_RATE18_06, ofdm_a); rtl8723au_write32(priv, REG_TX_AGC_B_RATE18_06, ofdm_b); @@ -987,9 +984,9 @@ rtl8723a_set_tx_power(struct rtl8xxxu_priv *priv, int channel, bool ht40) rtl8723au_write32(priv, REG_TX_AGC_B_RATE54_24, ofdm_b); mcs_a = mcsbase[0] | mcsbase[0] << 8 | - mcsbase[0] << 16 | mcsbase[0] <<24; + mcsbase[0] << 16 | mcsbase[0] << 24; mcs_b = mcsbase[1] | mcsbase[1] << 8 | - mcsbase[1] << 16 | mcsbase[1] <<24; + mcsbase[1] << 16 | mcsbase[1] << 24; rtl8723au_write32(priv, REG_TX_AGC_A_MCS03_MCS00, mcs_a); rtl8723au_write32(priv, REG_TX_AGC_B_MCS03_MCS00, mcs_b); @@ -1081,7 +1078,7 @@ static void rtl8xxxu_8723au_identify_chip(struct rtl8xxxu_priv *priv) val32 = rtl8723au_read32(priv, REG_SYS_CFG); priv->chip_cut = (val32 & SYS_CFG_CHIP_VERSION_MASK) >> SYS_CFG_CHIP_VERSION_SHIFT; - switch(priv->chip_cut) { + switch (priv->chip_cut) { case 0: cut = "A"; break; @@ -1224,7 +1221,7 @@ static int rtl8xxxu_read_efuse(struct rtl8xxxu_priv *priv) offset = (header & 0xe0) >> 5; ret = rtl8xxxu_read_efuse8(priv, efuse_addr++, - &extheader); + &extheader); if (ret) goto exit; /* All words disabled */ @@ -1245,11 +1242,11 @@ static int rtl8xxxu_read_efuse(struct rtl8xxxu_priv *priv) /* We have 8 bits to indicate validity */ map_addr = offset * 8; if (map_addr >= EFUSE_MAP_LEN_8723A) { - pr_debug("%s: %s: Illegal map_addr (%04x), " - "efuse corrupt!\n", DRIVER_NAME, + pr_debug("%s: %s: Illegal map_addr (%04x), efuse corrupt!\n", + DRIVER_NAME, __func__, map_addr); - ret = -EINVAL; - goto exit; + ret = -EINVAL; + goto exit; ret = -EINVAL; } @@ -1257,21 +1254,21 @@ static int rtl8xxxu_read_efuse(struct rtl8xxxu_priv *priv) /* Check word enable condition in the section */ if (!(word_mask & BIT(i))) { ret = rtl8xxxu_read_efuse8(priv, - efuse_addr++, - &val8); + efuse_addr++, + &val8); priv->efuse_wifi.raw[map_addr++] = val8; ret = rtl8xxxu_read_efuse8(priv, - efuse_addr++, - &val8); + efuse_addr++, + &val8); priv->efuse_wifi.raw[map_addr++] = val8; } else map_addr += 2; } } else { - pr_debug("%s: %s: Illegal offset (%04x), " - "efuse corrupt!\n", DRIVER_NAME, __func__, - offset); + pr_debug("%s: %s: Illegal offset (%04x), efuse corrupt!\n", + DRIVER_NAME, __func__, + offset); ret = -EINVAL; goto exit; } @@ -1384,7 +1381,6 @@ static int rtl8xxxu_download_firmware(struct rtl8xxxu_priv *priv) ret = -EAGAIN; goto fw_abort; } - } ret = 0; @@ -1404,7 +1400,7 @@ static int rtl8xxxu_load_firmware(struct rtl8xxxu_priv *priv) int ret = 0; u16 signature; - switch(priv->chip_cut) { + switch (priv->chip_cut) { case 0: fw_name = "rtlwifi/rtl8723aufw_A.bin"; break; @@ -1436,7 +1432,7 @@ static int rtl8xxxu_load_firmware(struct rtl8xxxu_priv *priv) priv->fw_size = fw->size - sizeof(struct rtl8xxxu_firmware_header); signature = le16_to_cpu(priv->fw_data->signature); - switch(signature & 0xfff0) { + switch (signature & 0xfff0) { case 0x92c0: case 0x88c0: case 0x2300: @@ -1591,7 +1587,7 @@ static int rtl8xxxu_init_phy_bb(struct rtl8xxxu_priv *priv) ldov12d = LDOV12D_ENABLE | BIT(2) | (2 << LDOV12D_VADJ_SHIFT); ldohci12 = 0x57; lpldo = 1; - val32 = (lpldo << 24) | (ldohci12 << 16) | (ldov12d << 8)| ldoa15; + val32 = (lpldo << 24) | (ldohci12 << 16) | (ldov12d << 8) | ldoa15; rtl8723au_write32(priv, REG_LDOA15_CTRL, val32); @@ -1612,7 +1608,7 @@ static int rtl8xxxu_init_rf_regs(struct rtl8xxxu_priv *priv, if (reg == 0xff && val == 0xffffffff) break; - switch(reg) { + switch (reg) { case 0xfe: msleep(50); continue; @@ -1751,7 +1747,7 @@ static int rtl8xxxu_init_queue_priority(struct rtl8xxxu_priv *priv) int hip, mgp, bkp, bep, vip, vop; int ret = 0; - switch(priv->ep_tx_count) { + switch (priv->ep_tx_count) { case 1: if (priv->ep_tx_high_queue) { hi = TRXDMA_QUEUE_HIGH; @@ -2037,7 +2033,6 @@ static void rtl8xxxu_restore_regs(struct rtl8xxxu_priv *priv, u32 *regs, rtl8723au_write32(priv, regs[i], backup[i]); } - static void rtl8xxxu_path_adda_on(struct rtl8xxxu_priv *priv, u32 *regs, bool path_a_on, bool is_2t) { @@ -2159,10 +2154,10 @@ static void rtl8xxxu_phy_iqcalibrate(struct rtl8xxxu_priv *priv, if (t == 0) { /* Save ADDA parameters, turn Path A ADDA on */ rtl8xxxu_save_regs(priv, ADDA_REG, priv->adda_backup, - RTL8XXXU_ADDA_REGS); + RTL8XXXU_ADDA_REGS); rtl8xxxu_save_mac_regs(priv, IQK_MAC_REG, priv->mac_backup); rtl8xxxu_save_regs(priv, IQK_BB_REG_92C, - priv->bb_backup, RTL8XXXU_BB_REGS); + priv->bb_backup, RTL8XXXU_BB_REGS); } rtl8xxxu_path_adda_on(priv, ADDA_REG, true, is_2t); @@ -2414,9 +2409,8 @@ static void rtl8723a_phy_iq_calibrate(struct rtl8xxxu_priv *priv, bool recovery) reg_ec4 = result[candidate][6]; reg_ecc = result[candidate][7]; pr_debug("%s: candidate is %x\n", __func__, candidate); - pr_debug("%s: reg_e94 =%x reg_e9C =%x reg_eA4 =%x " - "reg_eAC =%x reg_eB4 =%x reg_eBC =%x reg_eC4 =%x " - "reg_eCC =%x\n ", __func__, reg_e94, reg_e9c, + pr_debug("%s: reg_e94 =%x reg_e9C =%x reg_eA4 =%x reg_eAC =%x reg_eB4 =%x reg_eBC =%x reg_eC4 =%x reg_eCC =%x\n", + __func__, reg_e94, reg_e9c, reg_ea4, reg_eac, reg_eb4, reg_ebc, reg_ec4, reg_ecc); path_a_ok = true; #if 0 @@ -2540,10 +2534,10 @@ void rtl8xxxu_set_ampdu_factor(struct rtl8xxxu_priv *priv, u8 ampdu_factor) if ((vals[i] & 0xf0) > (ampdu_factor << 4)) vals[i] = (vals[i] & 0x0f) | (ampdu_factor << 4); - if ((vals[i] & 0x0f) > ampdu_factor) - vals[i] = (vals[i] & 0xf0) | ampdu_factor; + if ((vals[i] & 0x0f) > ampdu_factor) + vals[i] = (vals[i] & 0xf0) | ampdu_factor; - rtl8723au_write8(priv, REG_AGGLEN_LMT + i, vals[i]); + rtl8723au_write8(priv, REG_AGGLEN_LMT + i, vals[i]); } } @@ -2830,7 +2824,7 @@ static int rtl8xxxu_power_on(struct rtl8xxxu_priv *priv) /* for Efuse PG */ val32 = rtl8723au_read32(priv, REG_EFUSE_CTRL); - val32 &= ~(BIT(28)|BIT(29)|BIT(30)); + val32 &= ~(BIT(28) | BIT(29) | BIT(30)); val32 |= (0x06 << 28); rtl8723au_write32(priv, REG_EFUSE_CTRL, val32); exit: @@ -2859,7 +2853,7 @@ static void rtl8xxxu_power_off(struct rtl8xxxu_priv *priv) /* Reset MCU ready status */ rtl8723au_write8(priv, REG_MCU_FW_DL, 0x00); - rtl8xxxu_active_to_emu(priv); + rtl8xxxu_active_to_emu(priv); rtl8xxxu_emu_to_disabled(priv); /* Reset MCU IO Wrapper */ @@ -2940,7 +2934,7 @@ static int rtl8xxxu_init_device(struct ieee80211_hw *hw) val32 = 0x07000000 | FPGA0_RF_TRSW | FPGA0_RF_TRSWB | FPGA0_RF_ANTSW | FPGA0_RF_ANTSWB | FPGA0_RF_PAPE; rtl8723au_write32(priv, REG_FPGA0_XAB_RF_SW_CTRL, val32); - /* 0x860[6:5]= 00 - why? - this sets antenna B */ + /* 0x860[6:5]= 00 - why? - this sets antenna B */ rtl8723au_write32(priv, REG_FPGA0_XA_RF_INT_OE, 0x66F60210); priv->rf_mode_ag[0] = rtl8723au_read_rfreg(priv, RF6052_REG_MODE_AG); @@ -3057,12 +3051,12 @@ static int rtl8xxxu_init_device(struct ieee80211_hw *hw) rtl8723au_write32(priv, REG_RARFRC, 0x04030201); rtl8723au_write32(priv, REG_RARFRC + 4, 0x08070605); - val8 = rtl8723au_read8(priv, REG_FWHW_TXQ_CTRL); - val8 |= FWHW_TXQ_CTRL_AMPDU_RETRY; - rtl8723au_write8(priv, REG_FWHW_TXQ_CTRL, val8); + val8 = rtl8723au_read8(priv, REG_FWHW_TXQ_CTRL); + val8 |= FWHW_TXQ_CTRL_AMPDU_RETRY; + rtl8723au_write8(priv, REG_FWHW_TXQ_CTRL, val8); - /* Set ACK timeout */ - rtl8723au_write8(priv, REG_ACKTO, 0x40); + /* Set ACK timeout */ + rtl8723au_write8(priv, REG_ACKTO, 0x40); /* * Initialize beacon parameters @@ -3206,7 +3200,7 @@ static void rtl8xxxu_disable_device(struct ieee80211_hw *hw) } static void rtl8xxxu_cam_write(struct rtl8xxxu_priv *priv, - struct ieee80211_key_conf *key, const u8 *mac) + struct ieee80211_key_conf *key, const u8 *mac) { u32 cmd, val32, addr, ctrl; int j, i, tmp_debug; @@ -3244,7 +3238,7 @@ static void rtl8xxxu_cam_write(struct rtl8xxxu_priv *priv, } static void rtl8xxxu_sw_scan_start(struct ieee80211_hw *hw, - struct ieee80211_vif *vif, const u8 *mac) + struct ieee80211_vif *vif, const u8 *mac) { #if 0 struct rtl8xxxu_priv *priv = hw->priv; @@ -3262,7 +3256,7 @@ static void rtl8xxxu_sw_scan_start(struct ieee80211_hw *hw, } static void rtl8xxxu_sw_scan_complete(struct ieee80211_hw *hw, - struct ieee80211_vif *vif) + struct ieee80211_vif *vif) { struct rtl8xxxu_priv *priv = hw->priv; u8 val8; @@ -3270,14 +3264,14 @@ static void rtl8xxxu_sw_scan_complete(struct ieee80211_hw *hw, #if 0 pr_debug("%s\n", __func__); #endif - + val8 = rtl8723au_read8(priv, REG_BEACON_CTRL); val8 &= ~BEACON_DISABLE_TSF_UPDATE; rtl8723au_write8(priv, REG_BEACON_CTRL, val8); } static void rtl8xxxu_update_rate_table(struct rtl8xxxu_priv *priv, - struct ieee80211_sta *sta) + struct ieee80211_sta *sta) { struct h2c_cmd h2c; u32 ramask; @@ -3306,7 +3300,7 @@ static void rtl8xxxu_update_rate_table(struct rtl8xxxu_priv *priv, } static void rtl8xxxu_set_basic_rates(struct rtl8xxxu_priv *priv, - struct ieee80211_sta *sta) + struct ieee80211_sta *sta) { u32 rate_cfg, val32; u8 rate_idx = 0; @@ -3322,7 +3316,7 @@ static void rtl8xxxu_set_basic_rates(struct rtl8xxxu_priv *priv, pr_debug("%s: supp_rates %08x rates %08x\n", __func__, sta->supp_rates[0], rate_cfg); - while(rate_cfg) { + while (rate_cfg) { rate_cfg = (rate_cfg >> 1); rate_idx++; } @@ -3331,7 +3325,7 @@ static void rtl8xxxu_set_basic_rates(struct rtl8xxxu_priv *priv, static void rtl8xxxu_bss_info_changed(struct ieee80211_hw *hw, struct ieee80211_vif *vif, - struct ieee80211_bss_conf *bss_conf, u32 changed) + struct ieee80211_bss_conf *bss_conf, u32 changed) { struct rtl8xxxu_priv *priv = hw->priv; struct ieee80211_sta *sta; @@ -3489,7 +3483,7 @@ rtl8xxxu_bss_info_changed(struct ieee80211_hw *hw, struct ieee80211_vif *vif, rtl8xxxu_set_ampdu_factor(priv, ampdu_factor); rtl8xxxu_set_ampdu_min_space(priv, ampdu_density); #endif - + rtl8723au_write8(priv, REG_SIFS_CCK + 1, sifs); rtl8723au_write8(priv, REG_SIFS_OFDM + 1, sifs); rtl8723au_write8(priv, REG_SPEC_SIFS + 1, sifs); @@ -3518,7 +3512,7 @@ rtl8xxxu_bss_info_changed(struct ieee80211_hw *hw, struct ieee80211_vif *vif, sta = ieee80211_find_sta(vif, bss_conf->bssid); if (sta) rtl8xxxu_set_basic_rates(priv, sta); - else + else pr_debug("BSS_CHANGED_BASIC_RATES: No sta found!\n"); rcu_read_unlock(); @@ -3531,7 +3525,7 @@ static u32 rtl8xxxu_80211_to_rtl_queue(u32 queue) { u32 rtlqueue; - switch(queue) { + switch (queue) { case IEEE80211_AC_VO: rtlqueue = TXDESC_QUEUE_VO; break; @@ -3603,7 +3597,6 @@ static void rtl8xxxu_tx_complete(struct urb *urb) usb_free_urb(urb); } - static void rtl8xxxu_tx(struct ieee80211_hw *hw, struct ieee80211_tx_control *control, struct sk_buff *skb) @@ -3691,9 +3684,10 @@ static void rtl8xxxu_tx(struct ieee80211_hw *hw, tx_desc->txdw5 = cpu_to_le32(0x0001ff00); if ((tx_info->flags & IEEE80211_TX_CTL_AMPDU) && - control->sta->ht_cap.ht_supported && - control && control->sta) { + control->sta->ht_cap.ht_supported && + control && control->sta) { u8 ampdu = control->sta->ht_cap.ampdu_density; + tx_desc->txdw2 |= cpu_to_le32(ampdu << TXDESC_AMPDU_DENSITY_SHIFT); tx_desc->txdw1 |= cpu_to_le32(TXDESC_AGG_ENABLE); @@ -3737,7 +3731,6 @@ error: dev_kfree_skb(skb); } - static void rtl8xxxu_rx_complete(struct urb *urb) { struct rtl8xxxu_rx_urb *rx_urb = @@ -3912,7 +3905,6 @@ static void rtl8xxxu_int_complete(struct urb *urb) } } - static int rtl8xxxu_submit_int_urb(struct ieee80211_hw *hw) { struct rtl8xxxu_priv *priv = hw->priv; @@ -4042,7 +4034,7 @@ static int rtl8xxxu_conf_tx(struct ieee80211_hw *hw, pr_debug("%s: IEEE80211 queue %02x val %08x, acm %i, acm_ctrl %02x\n", __func__, queue, val32, param->acm, acm_ctrl); - switch(queue) { + switch (queue) { case IEEE80211_AC_VO: acm_bit = ACM_HW_CTRL_VO; rtl8723au_write32(priv, REG_EDCA_VO_PARAM, val32); @@ -4145,7 +4137,7 @@ static int rtl8xxxu_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd, val8 |= SEC_CFG_TX_USE_DEFKEY | SEC_CFG_RX_USE_DEFKEY; rtl8723au_write8(priv, REG_SECURITY_CFG, val8); - switch(cmd) { + switch (cmd) { case SET_KEY: /* * This is a bit of a hack - the lower bits of the cipher diff --git a/drivers/net/wireless/rtl8xxxu.h b/drivers/net/wireless/rtl8xxxu.h index 8d9f64c..20e0317 100644 --- a/drivers/net/wireless/rtl8xxxu.h +++ b/drivers/net/wireless/rtl8xxxu.h @@ -331,14 +331,14 @@ struct rtl8xxxu_firmware_header { * The 8723au has 3 channel groups: 1-3, 4-9, and 10-14 */ struct rtl8723au_idx { -#if defined (__LITTLE_ENDIAN) +#if defined(__LITTLE_ENDIAN) int a:4; int b:4; -#elif defined (__LITTLE_ENDIAN) +#elif defined(__LITTLE_ENDIAN) int b:4; int a:4; #else -#error "no endianess defined" +#error "no endianness defined" #endif } __attribute__((packed)); @@ -490,8 +490,7 @@ struct rtl8xxxu_priv { bool use_shortgi; }; -struct rtl8xxxu_rx_urb -{ +struct rtl8xxxu_rx_urb { struct urb urb; struct ieee80211_hw *hw; }; diff --git a/drivers/net/wireless/rtl8xxxu_regs.h b/drivers/net/wireless/rtl8xxxu_regs.h index 97320b3..43fde73 100644 --- a/drivers/net/wireless/rtl8xxxu_regs.h +++ b/drivers/net/wireless/rtl8xxxu_regs.h @@ -107,7 +107,7 @@ #define REG_EFUSE_TEST 0x0034 #define EFUSE_TRPT BIT(7) /* 00: Wifi Efuse, 01: BT Efuse0, 10: BT Efuse1, 11: BT Efuse2 */ -#define EFUSE_CELL_SEL (BIT(8)|BIT(9)) +#define EFUSE_CELL_SEL (BIT(8) | BIT(9)) #define EFUSE_LDOE25_ENABLE BIT(31) #define EFUSE_SELECT_MASK 0x0300 #define EFUSE_WIFI_SELECT 0x0000 @@ -165,7 +165,6 @@ control */ #define MULTI_GPS_FUNC_EN BIT(22) /* GPS function enable */ - #define REG_MCU_FW_DL 0x0080 #define MCU_FW_DL_ENABLE BIT(0) #define MCU_FW_DL_READY BIT(1) @@ -204,7 +203,7 @@ #define SYS_CFG_BD_MAC2 BIT(9) #define SYS_CFG_BD_MAC1 BIT(10) #define SYS_CFG_IC_MACPHY_MODE BIT(11) -#define SYS_CFG_CHIP_VER (BIT(12)|BIT(13)|BIT(14)|BIT(15)) +#define SYS_CFG_CHIP_VER (BIT(12) | BIT(13) | BIT(14) | BIT(15)) #define SYS_CFG_BT_FUNC BIT(16) #define SYS_CFG_VENDOR_ID BIT(19) #define SYS_CFG_PAD_HWPD_IDN BIT(22) @@ -220,11 +219,10 @@ #define SYS_CFG_CHIP_VERSION_MASK 0xf000 /* Bit 12 - 15 */ #define SYS_CFG_CHIP_VERSION_SHIFT 12 - #define REG_GPIO_OUTSTS 0x00f4 /* For RTL8723 only. */ -#define GPIO_EFS_HCI_SEL (BIT(0)|BIT(1)) -#define GPIO_PAD_HCI_SEL (BIT(2)|BIT(3)) -#define GPIO_HCI_SEL (BIT(4)|BIT(5)) +#define GPIO_EFS_HCI_SEL (BIT(0) | BIT(1)) +#define GPIO_PAD_HCI_SEL (BIT(2) | BIT(3)) +#define GPIO_HCI_SEL (BIT(4) | BIT(5)) #define GPIO_PKG_SEL_HCI BIT(6) #define GPIO_FEN_GPS BIT(7) #define GPIO_FEN_BT BIT(8) @@ -241,7 +239,7 @@ #define GPIO_UPHY_SUSB BIT(21) #define GPIO_PCI_SUSEN BIT(22) #define GPIO_USB_SUSEN BIT(23) -#define GPIO_RF_RL_ID (BIT(31)|BIT(30)|BIT(29)|BIT(28)) +#define GPIO_RF_RL_ID (BIT(31) | BIT(30) | BIT(29) | BIT(28)) /* 0x0100 ~ 0x01FF MACTOP General Configuration */ #define REG_CR 0x0100 @@ -285,7 +283,6 @@ #define TRXDMA_QUEUE_NORMAL 2 #define TRXDMA_QUEUE_HIGH 3 - #define REG_TRXFF_BNDY 0x0114 #define REG_TRXFF_STATUS 0x0118 #define REG_RXFF_PTR 0x011c @@ -360,7 +357,6 @@ #define REG_HGQ_INFORMATION 0x0414 #define REG_BCNQ_INFORMATION 0x0418 - #define REG_CPU_MGQ_INFORMATION 0x041c #define REG_FWHW_TXQ_CTRL 0x0420 #define FWHW_TXQ_CTRL_AMPDU_RETRY BIT(7) @@ -411,7 +407,7 @@ #define RSR_MCS7 BIT(19) #define RSR_RSC_LOWER_SUB_CHANNEL BIT(21) /* 0x200000 */ #define RSR_RSC_UPPER_SUB_CHANNEL BIT(22) /* 0x400000 */ -#define RSR_RSC_BANDWIDTH_40M (RSR_RSC_UPPER_SUB_CHANNEL|\ +#define RSR_RSC_BANDWIDTH_40M (RSR_RSC_UPPER_SUB_CHANNEL | \ RSR_RSC_LOWER_SUB_CHANNEL) #define RSR_ACK_SHORT_PREAMBLE BIT(23) @@ -427,7 +423,6 @@ #define REG_INIRTS_RATE_SEL 0x0480 #define REG_INIDATA_RATE_SEL 0x0484 - #define REG_POWER_STATUS 0x04a4 #define REG_POWER_STAGE1 0x04b4 #define REG_POWER_STAGE2 0x04b8 @@ -446,8 +441,6 @@ #define REG_PTCL_ERR_STATUS 0x04e2 #define REG_DUMMY 0x04fc - - /* 0x0500 ~ 0x05FF EDCA Configuration */ #define REG_EDCA_VO_PARAM 0x0500 #define REG_EDCA_VI_PARAM 0x0504 @@ -592,7 +585,6 @@ #define REG_RXERR_RPT 0x0664 #define REG_WMAC_TRXPTCL_CTL 0x0668 - /* Security */ #define REG_CAM_CMD 0x0670 #define CAM_CMD_POLLING BIT(31) ^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-03-06 22:59 ` Joe Perches @ 2015-03-07 5:18 ` Jes Sorensen 2015-03-07 5:23 ` Joe Perches 0 siblings, 1 reply; 35+ messages in thread From: Jes Sorensen @ 2015-03-07 5:18 UTC (permalink / raw) To: Joe Perches; +Cc: linux-wireless, Larry.Finger Joe Perches <joe@perches.com> writes: > On Fri, 2015-03-06 at 17:15 -0500, Jes.Sorensen@redhat.com wrote: >> From: Jes Sorensen <Jes.Sorensen@redhat.com> >> >> This is an alternate driver for the Realtek 8723AU (rtl8723au) written >> from scratch utilizing the mac80211 stack. >> >> After spending months cleaning up the vendor provided rtl8723au >> driver, which comes with it's own 802.11 stack included, I decided to >> rewrite this driver from the bottom up. >> >> Many thanks to Johannes Berg for 802.11 insights and help and Larry >> Finger for help with the vendor driver. > > cool. > > I hope it can be fairly modular so that it can be > extensible to support multiple devices more sensibly > than the realtek code. > > btw: Here are some trivial checkpatch cleanups. > > There are a few places where it seems there are > missing braces because indentation changes occur. > > see: > @@ -1245,11 +1242,11 @@ static int rtl8xxxu_read_efuse(struct rtl8xxxu_priv *priv) > @@ -2540,10 +2534,10 @@ void rtl8xxxu_set_ampdu_factor(struct rtl8xxxu_priv *priv, u8 ampdu_factor) > > and > > +++ b/drivers/net/wireless/rtl8xxxu.h > [] > struct rtl8723au_idx { > -#if defined (__LITTLE_ENDIAN) > +#if defined(__LITTLE_ENDIAN) > int a:4; > int b:4; > -#elif defined (__LITTLE_ENDIAN) > +#elif defined(__LITTLE_ENDIAN) > int b:4; > int a:4; > > Presumably the second should be __BIG_ENDIAN. Seems reasonable :) > > --- > drivers/net/wireless/rtl8xxxu.c | 124 ++++++++++++++++------------------- > drivers/net/wireless/rtl8xxxu.h | 9 ++- > drivers/net/wireless/rtl8xxxu_regs.h | 22 ++----- > 3 files changed, 69 insertions(+), 86 deletions(-) > > diff --git a/drivers/net/wireless/rtl8xxxu.c b/drivers/net/wireless/rtl8xxxu.c > index 6728a74..af1c44d 100644 > --- a/drivers/net/wireless/rtl8xxxu.c > +++ b/drivers/net/wireless/rtl8xxxu.c > @@ -677,8 +677,8 @@ static int rtl8723a_h2c_cmd(struct rtl8xxxu_priv *priv, struct h2c_cmd *h2c) > pr_debug("H2C_EXT %04x\n", le16_to_cpu(h2c->raw.ext)); > } > rtl8723au_write32(priv, mbox_reg, le32_to_cpu(h2c->raw.data)); > - if (rtl8xxxu_debug & RTL8XXXU_DEBUG_H2C) > - pr_debug("H2C %08x\n", le16_to_cpu(h2c->raw.data)); > + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_H2C) > + pr_debug("H2C %08x\n", le16_to_cpu(h2c->raw.data)); > > priv->next_mbox = (mbox_nr + 1) % H2C_MAX_MBOX; > > @@ -757,7 +757,6 @@ static void rtl8723a_disable_rf(struct rtl8xxxu_priv *priv) > rtl8723au_write8(priv, REG_SPS0_CTRL, sps0); > } > > - > static void rtl8723a_stop_tx_beacon(struct rtl8xxxu_priv *priv) > { > u8 val8; > @@ -774,7 +773,6 @@ static void rtl8723a_stop_tx_beacon(struct rtl8xxxu_priv *priv) > rtl8723au_write8(priv, REG_TBTT_PROHIBIT + 2, val8); > } > > - > /* > * The rtl8723a has 3 channel groups for it's efuse settings. It only > * supports the 2.4GHz band, so channels 1 - 14: I like double blank lines in some places, so no to that one. > @@ -834,9 +832,9 @@ static void rtl8723au_config_channel(struct ieee80211_hw *hw) > rtl8723au_write32(priv, REG_FPGA0_ANALOG2, val32); > break; > case NL80211_CHAN_WIDTH_40: > - if (hw->conf.chandef.center_freq1 > > + if (hw->conf.chandef.center_freq1 > > hw->conf.chandef.chan->center_freq) > - sec_ch_above = 1; > + sec_ch_above = 1; > else > sec_ch_above = 0; > > @@ -935,8 +933,7 @@ rtl8723a_set_tx_power(struct rtl8xxxu_priv *priv, int channel, bool ht40) > } > > if (rtl8xxxu_debug & RTL8XXXU_DEBUG_CHANNEL) > - pr_debug("%s: Setting TX power CCK A: %02x, " > - "CCK B: %02x, OFDM A: %02x, OFDM B: %02x\n", > + pr_debug("%s: Setting TX power CCK A: %02x, CCK B: %02x, OFDM A: %02x, OFDM B: %02x\n", > DRIVER_NAME, cck[0], cck[1], ofdm[0], ofdm[1]); > > for (i = 0; i < RTL8723A_MAX_RF_PATHS; i++) { NAK, I break my lines carefully > 80 character lines suck. > @@ -977,9 +974,9 @@ rtl8723a_set_tx_power(struct rtl8xxxu_priv *priv, int channel, bool ht40) > mcsbase[1] += efuse->ht20_tx_power_index_diff[group].b; > > ofdm_a = ofdmbase[0] | ofdmbase[0] << 8 | > - ofdmbase[0] << 16 | ofdmbase[0] <<24; > + ofdmbase[0] << 16 | ofdmbase[0] << 24; > ofdm_b = ofdmbase[1] | ofdmbase[1] << 8 | > - ofdmbase[1] << 16 | ofdmbase[1] <<24; > + ofdmbase[1] << 16 | ofdmbase[1] << 24; > rtl8723au_write32(priv, REG_TX_AGC_A_RATE18_06, ofdm_a); > rtl8723au_write32(priv, REG_TX_AGC_B_RATE18_06, ofdm_b); > > @@ -987,9 +984,9 @@ rtl8723a_set_tx_power(struct rtl8xxxu_priv *priv, int channel, bool ht40) > rtl8723au_write32(priv, REG_TX_AGC_B_RATE54_24, ofdm_b); > > mcs_a = mcsbase[0] | mcsbase[0] << 8 | > - mcsbase[0] << 16 | mcsbase[0] <<24; > + mcsbase[0] << 16 | mcsbase[0] << 24; > mcs_b = mcsbase[1] | mcsbase[1] << 8 | > - mcsbase[1] << 16 | mcsbase[1] <<24; > + mcsbase[1] << 16 | mcsbase[1] << 24; > > rtl8723au_write32(priv, REG_TX_AGC_A_MCS03_MCS00, mcs_a); > rtl8723au_write32(priv, REG_TX_AGC_B_MCS03_MCS00, mcs_b); > @@ -1081,7 +1078,7 @@ static void rtl8xxxu_8723au_identify_chip(struct rtl8xxxu_priv *priv) > val32 = rtl8723au_read32(priv, REG_SYS_CFG); > priv->chip_cut = (val32 & SYS_CFG_CHIP_VERSION_MASK) >> > SYS_CFG_CHIP_VERSION_SHIFT; > - switch(priv->chip_cut) { > + switch (priv->chip_cut) { > case 0: > cut = "A"; > break; > @@ -1224,7 +1221,7 @@ static int rtl8xxxu_read_efuse(struct rtl8xxxu_priv *priv) > offset = (header & 0xe0) >> 5; > > ret = rtl8xxxu_read_efuse8(priv, efuse_addr++, > - &extheader); > + &extheader); > if (ret) > goto exit; > /* All words disabled */ > @@ -1245,11 +1242,11 @@ static int rtl8xxxu_read_efuse(struct rtl8xxxu_priv *priv) > /* We have 8 bits to indicate validity */ > map_addr = offset * 8; > if (map_addr >= EFUSE_MAP_LEN_8723A) { > - pr_debug("%s: %s: Illegal map_addr (%04x), " > - "efuse corrupt!\n", DRIVER_NAME, > + pr_debug("%s: %s: Illegal map_addr (%04x), efuse corrupt!\n", > + DRIVER_NAME, NAK > __func__, map_addr); > - ret = -EINVAL; > - goto exit; > + ret = -EINVAL; > + goto exit; > > ret = -EINVAL; > } > @@ -1257,21 +1254,21 @@ static int rtl8xxxu_read_efuse(struct rtl8xxxu_priv *priv) > /* Check word enable condition in the section */ > if (!(word_mask & BIT(i))) { > ret = rtl8xxxu_read_efuse8(priv, > - efuse_addr++, > - &val8); > + efuse_addr++, > + &val8); > priv->efuse_wifi.raw[map_addr++] = val8; > > ret = rtl8xxxu_read_efuse8(priv, > - efuse_addr++, > - &val8); > + efuse_addr++, > + &val8); > priv->efuse_wifi.raw[map_addr++] = val8; > } else > map_addr += 2; > } > } else { > - pr_debug("%s: %s: Illegal offset (%04x), " > - "efuse corrupt!\n", DRIVER_NAME, __func__, > - offset); > + pr_debug("%s: %s: Illegal offset (%04x), efuse corrupt!\n", > + DRIVER_NAME, __func__, > + offset); > ret = -EINVAL; > goto exit; > } > @@ -1384,7 +1381,6 @@ static int rtl8xxxu_download_firmware(struct rtl8xxxu_priv *priv) > ret = -EAGAIN; > goto fw_abort; > } > - > } > > ret = 0; > @@ -1404,7 +1400,7 @@ static int rtl8xxxu_load_firmware(struct rtl8xxxu_priv *priv) > int ret = 0; > u16 signature; > > - switch(priv->chip_cut) { > + switch (priv->chip_cut) { > case 0: > fw_name = "rtlwifi/rtl8723aufw_A.bin"; > break; > @@ -1436,7 +1432,7 @@ static int rtl8xxxu_load_firmware(struct rtl8xxxu_priv *priv) > priv->fw_size = fw->size - sizeof(struct rtl8xxxu_firmware_header); > > signature = le16_to_cpu(priv->fw_data->signature); > - switch(signature & 0xfff0) { > + switch (signature & 0xfff0) { > case 0x92c0: > case 0x88c0: > case 0x2300: > @@ -1591,7 +1587,7 @@ static int rtl8xxxu_init_phy_bb(struct rtl8xxxu_priv *priv) > ldov12d = LDOV12D_ENABLE | BIT(2) | (2 << LDOV12D_VADJ_SHIFT); > ldohci12 = 0x57; > lpldo = 1; > - val32 = (lpldo << 24) | (ldohci12 << 16) | (ldov12d << 8)| ldoa15; > + val32 = (lpldo << 24) | (ldohci12 << 16) | (ldov12d << 8) | ldoa15; > > rtl8723au_write32(priv, REG_LDOA15_CTRL, val32); > > @@ -1612,7 +1608,7 @@ static int rtl8xxxu_init_rf_regs(struct rtl8xxxu_priv *priv, > if (reg == 0xff && val == 0xffffffff) > break; > > - switch(reg) { > + switch (reg) { > case 0xfe: > msleep(50); > continue; > @@ -1751,7 +1747,7 @@ static int rtl8xxxu_init_queue_priority(struct rtl8xxxu_priv *priv) > int hip, mgp, bkp, bep, vip, vop; > int ret = 0; > > - switch(priv->ep_tx_count) { > + switch (priv->ep_tx_count) { > case 1: > if (priv->ep_tx_high_queue) { > hi = TRXDMA_QUEUE_HIGH; > @@ -2037,7 +2033,6 @@ static void rtl8xxxu_restore_regs(struct rtl8xxxu_priv *priv, u32 *regs, > rtl8723au_write32(priv, regs[i], backup[i]); > } > > - > static void rtl8xxxu_path_adda_on(struct rtl8xxxu_priv *priv, u32 *regs, > bool path_a_on, bool is_2t) > { > @@ -2159,10 +2154,10 @@ static void rtl8xxxu_phy_iqcalibrate(struct rtl8xxxu_priv *priv, > if (t == 0) { > /* Save ADDA parameters, turn Path A ADDA on */ > rtl8xxxu_save_regs(priv, ADDA_REG, priv->adda_backup, > - RTL8XXXU_ADDA_REGS); > + RTL8XXXU_ADDA_REGS); > rtl8xxxu_save_mac_regs(priv, IQK_MAC_REG, priv->mac_backup); > rtl8xxxu_save_regs(priv, IQK_BB_REG_92C, > - priv->bb_backup, RTL8XXXU_BB_REGS); > + priv->bb_backup, RTL8XXXU_BB_REGS); > } > > rtl8xxxu_path_adda_on(priv, ADDA_REG, true, is_2t); > @@ -2414,9 +2409,8 @@ static void rtl8723a_phy_iq_calibrate(struct rtl8xxxu_priv *priv, bool recovery) > reg_ec4 = result[candidate][6]; > reg_ecc = result[candidate][7]; > pr_debug("%s: candidate is %x\n", __func__, candidate); > - pr_debug("%s: reg_e94 =%x reg_e9C =%x reg_eA4 =%x " > - "reg_eAC =%x reg_eB4 =%x reg_eBC =%x reg_eC4 =%x " > - "reg_eCC =%x\n ", __func__, reg_e94, reg_e9c, > + pr_debug("%s: reg_e94 =%x reg_e9C =%x reg_eA4 =%x reg_eAC =%x reg_eB4 =%x reg_eBC =%x reg_eC4 =%x reg_eCC =%x\n", > + __func__, reg_e94, reg_e9c, > reg_ea4, reg_eac, reg_eb4, reg_ebc, reg_ec4, reg_ecc); > path_a_ok = true; > #if 0 NAK > @@ -2540,10 +2534,10 @@ void rtl8xxxu_set_ampdu_factor(struct rtl8xxxu_priv *priv, u8 ampdu_factor) > if ((vals[i] & 0xf0) > (ampdu_factor << 4)) > vals[i] = (vals[i] & 0x0f) | (ampdu_factor << 4); > > - if ((vals[i] & 0x0f) > ampdu_factor) > - vals[i] = (vals[i] & 0xf0) | ampdu_factor; > + if ((vals[i] & 0x0f) > ampdu_factor) > + vals[i] = (vals[i] & 0xf0) | ampdu_factor; > > - rtl8723au_write8(priv, REG_AGGLEN_LMT + i, vals[i]); > + rtl8723au_write8(priv, REG_AGGLEN_LMT + i, vals[i]); > } > } > > @@ -2830,7 +2824,7 @@ static int rtl8xxxu_power_on(struct rtl8xxxu_priv *priv) > > /* for Efuse PG */ > val32 = rtl8723au_read32(priv, REG_EFUSE_CTRL); > - val32 &= ~(BIT(28)|BIT(29)|BIT(30)); > + val32 &= ~(BIT(28) | BIT(29) | BIT(30)); > val32 |= (0x06 << 28); > rtl8723au_write32(priv, REG_EFUSE_CTRL, val32); > exit: > @@ -2859,7 +2853,7 @@ static void rtl8xxxu_power_off(struct rtl8xxxu_priv *priv) > /* Reset MCU ready status */ > rtl8723au_write8(priv, REG_MCU_FW_DL, 0x00); > > - rtl8xxxu_active_to_emu(priv); > + rtl8xxxu_active_to_emu(priv); > rtl8xxxu_emu_to_disabled(priv); > > /* Reset MCU IO Wrapper */ > @@ -2940,7 +2934,7 @@ static int rtl8xxxu_init_device(struct ieee80211_hw *hw) > val32 = 0x07000000 | FPGA0_RF_TRSW | FPGA0_RF_TRSWB | > FPGA0_RF_ANTSW | FPGA0_RF_ANTSWB | FPGA0_RF_PAPE; > rtl8723au_write32(priv, REG_FPGA0_XAB_RF_SW_CTRL, val32); > - /* 0x860[6:5]= 00 - why? - this sets antenna B */ > + /* 0x860[6:5]= 00 - why? - this sets antenna B */ > rtl8723au_write32(priv, REG_FPGA0_XA_RF_INT_OE, 0x66F60210); > > priv->rf_mode_ag[0] = rtl8723au_read_rfreg(priv, RF6052_REG_MODE_AG); > @@ -3057,12 +3051,12 @@ static int rtl8xxxu_init_device(struct ieee80211_hw *hw) > rtl8723au_write32(priv, REG_RARFRC, 0x04030201); > rtl8723au_write32(priv, REG_RARFRC + 4, 0x08070605); > > - val8 = rtl8723au_read8(priv, REG_FWHW_TXQ_CTRL); > - val8 |= FWHW_TXQ_CTRL_AMPDU_RETRY; > - rtl8723au_write8(priv, REG_FWHW_TXQ_CTRL, val8); > + val8 = rtl8723au_read8(priv, REG_FWHW_TXQ_CTRL); > + val8 |= FWHW_TXQ_CTRL_AMPDU_RETRY; > + rtl8723au_write8(priv, REG_FWHW_TXQ_CTRL, val8); > > - /* Set ACK timeout */ > - rtl8723au_write8(priv, REG_ACKTO, 0x40); > + /* Set ACK timeout */ > + rtl8723au_write8(priv, REG_ACKTO, 0x40); > > /* > * Initialize beacon parameters > @@ -3206,7 +3200,7 @@ static void rtl8xxxu_disable_device(struct ieee80211_hw *hw) > } > > static void rtl8xxxu_cam_write(struct rtl8xxxu_priv *priv, > - struct ieee80211_key_conf *key, const u8 *mac) > + struct ieee80211_key_conf *key, const u8 *mac) > { > u32 cmd, val32, addr, ctrl; > int j, i, tmp_debug; > @@ -3244,7 +3238,7 @@ static void rtl8xxxu_cam_write(struct rtl8xxxu_priv *priv, > } > > static void rtl8xxxu_sw_scan_start(struct ieee80211_hw *hw, > - struct ieee80211_vif *vif, const u8 *mac) > + struct ieee80211_vif *vif, const u8 *mac) > { > #if 0 > struct rtl8xxxu_priv *priv = hw->priv; > @@ -3262,7 +3256,7 @@ static void rtl8xxxu_sw_scan_start(struct ieee80211_hw *hw, > } > > static void rtl8xxxu_sw_scan_complete(struct ieee80211_hw *hw, > - struct ieee80211_vif *vif) > + struct ieee80211_vif *vif) > { > struct rtl8xxxu_priv *priv = hw->priv; > u8 val8; > @@ -3270,14 +3264,14 @@ static void rtl8xxxu_sw_scan_complete(struct ieee80211_hw *hw, > #if 0 > pr_debug("%s\n", __func__); > #endif > - > + > val8 = rtl8723au_read8(priv, REG_BEACON_CTRL); > val8 &= ~BEACON_DISABLE_TSF_UPDATE; > rtl8723au_write8(priv, REG_BEACON_CTRL, val8); > } > > static void rtl8xxxu_update_rate_table(struct rtl8xxxu_priv *priv, > - struct ieee80211_sta *sta) > + struct ieee80211_sta *sta) > { > struct h2c_cmd h2c; > u32 ramask; > @@ -3306,7 +3300,7 @@ static void rtl8xxxu_update_rate_table(struct rtl8xxxu_priv *priv, > } > > static void rtl8xxxu_set_basic_rates(struct rtl8xxxu_priv *priv, > - struct ieee80211_sta *sta) > + struct ieee80211_sta *sta) > { > u32 rate_cfg, val32; > u8 rate_idx = 0; > @@ -3322,7 +3316,7 @@ static void rtl8xxxu_set_basic_rates(struct rtl8xxxu_priv *priv, > pr_debug("%s: supp_rates %08x rates %08x\n", __func__, > sta->supp_rates[0], rate_cfg); > > - while(rate_cfg) { > + while (rate_cfg) { > rate_cfg = (rate_cfg >> 1); > rate_idx++; > } > @@ -3331,7 +3325,7 @@ static void rtl8xxxu_set_basic_rates(struct rtl8xxxu_priv *priv, > > static void > rtl8xxxu_bss_info_changed(struct ieee80211_hw *hw, struct ieee80211_vif *vif, > - struct ieee80211_bss_conf *bss_conf, u32 changed) > + struct ieee80211_bss_conf *bss_conf, u32 changed) > { > struct rtl8xxxu_priv *priv = hw->priv; > struct ieee80211_sta *sta; > @@ -3489,7 +3483,7 @@ rtl8xxxu_bss_info_changed(struct ieee80211_hw *hw, struct ieee80211_vif *vif, > rtl8xxxu_set_ampdu_factor(priv, ampdu_factor); > rtl8xxxu_set_ampdu_min_space(priv, ampdu_density); > #endif > - > + > rtl8723au_write8(priv, REG_SIFS_CCK + 1, sifs); > rtl8723au_write8(priv, REG_SIFS_OFDM + 1, sifs); > rtl8723au_write8(priv, REG_SPEC_SIFS + 1, sifs); > @@ -3518,7 +3512,7 @@ rtl8xxxu_bss_info_changed(struct ieee80211_hw *hw, struct ieee80211_vif *vif, > sta = ieee80211_find_sta(vif, bss_conf->bssid); > if (sta) > rtl8xxxu_set_basic_rates(priv, sta); > - else > + else > pr_debug("BSS_CHANGED_BASIC_RATES: No sta found!\n"); > > rcu_read_unlock(); > @@ -3531,7 +3525,7 @@ static u32 rtl8xxxu_80211_to_rtl_queue(u32 queue) > { > u32 rtlqueue; > > - switch(queue) { > + switch (queue) { > case IEEE80211_AC_VO: > rtlqueue = TXDESC_QUEUE_VO; > break; > @@ -3603,7 +3597,6 @@ static void rtl8xxxu_tx_complete(struct urb *urb) > usb_free_urb(urb); > } > > - > static void rtl8xxxu_tx(struct ieee80211_hw *hw, > struct ieee80211_tx_control *control, > struct sk_buff *skb) > @@ -3691,9 +3684,10 @@ static void rtl8xxxu_tx(struct ieee80211_hw *hw, > tx_desc->txdw5 = cpu_to_le32(0x0001ff00); > > if ((tx_info->flags & IEEE80211_TX_CTL_AMPDU) && > - control->sta->ht_cap.ht_supported && > - control && control->sta) { > + control->sta->ht_cap.ht_supported && > + control && control->sta) { > u8 ampdu = control->sta->ht_cap.ampdu_density; > + > tx_desc->txdw2 |= > cpu_to_le32(ampdu << TXDESC_AMPDU_DENSITY_SHIFT); > tx_desc->txdw1 |= cpu_to_le32(TXDESC_AGG_ENABLE); > @@ -3737,7 +3731,6 @@ error: > dev_kfree_skb(skb); > } > > - > static void rtl8xxxu_rx_complete(struct urb *urb) > { > struct rtl8xxxu_rx_urb *rx_urb = > @@ -3912,7 +3905,6 @@ static void rtl8xxxu_int_complete(struct urb *urb) > } > } > > - > static int rtl8xxxu_submit_int_urb(struct ieee80211_hw *hw) > { > struct rtl8xxxu_priv *priv = hw->priv; > @@ -4042,7 +4034,7 @@ static int rtl8xxxu_conf_tx(struct ieee80211_hw *hw, > pr_debug("%s: IEEE80211 queue %02x val %08x, acm %i, acm_ctrl %02x\n", > __func__, queue, val32, param->acm, acm_ctrl); > > - switch(queue) { > + switch (queue) { > case IEEE80211_AC_VO: > acm_bit = ACM_HW_CTRL_VO; > rtl8723au_write32(priv, REG_EDCA_VO_PARAM, val32); > @@ -4145,7 +4137,7 @@ static int rtl8xxxu_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd, > val8 |= SEC_CFG_TX_USE_DEFKEY | SEC_CFG_RX_USE_DEFKEY; > rtl8723au_write8(priv, REG_SECURITY_CFG, val8); > > - switch(cmd) { > + switch (cmd) { > case SET_KEY: > /* > * This is a bit of a hack - the lower bits of the cipher > diff --git a/drivers/net/wireless/rtl8xxxu.h b/drivers/net/wireless/rtl8xxxu.h > index 8d9f64c..20e0317 100644 > --- a/drivers/net/wireless/rtl8xxxu.h > +++ b/drivers/net/wireless/rtl8xxxu.h > @@ -331,14 +331,14 @@ struct rtl8xxxu_firmware_header { > * The 8723au has 3 channel groups: 1-3, 4-9, and 10-14 > */ > struct rtl8723au_idx { > -#if defined (__LITTLE_ENDIAN) > +#if defined(__LITTLE_ENDIAN) > int a:4; > int b:4; > -#elif defined (__LITTLE_ENDIAN) > +#elif defined(__LITTLE_ENDIAN) > int b:4; > int a:4; > #else > -#error "no endianess defined" > +#error "no endianness defined" > #endif > } __attribute__((packed)); > > @@ -490,8 +490,7 @@ struct rtl8xxxu_priv { > bool use_shortgi; > }; > > -struct rtl8xxxu_rx_urb > -{ > +struct rtl8xxxu_rx_urb { > struct urb urb; > struct ieee80211_hw *hw; > }; > diff --git a/drivers/net/wireless/rtl8xxxu_regs.h b/drivers/net/wireless/rtl8xxxu_regs.h > index 97320b3..43fde73 100644 > --- a/drivers/net/wireless/rtl8xxxu_regs.h > +++ b/drivers/net/wireless/rtl8xxxu_regs.h > @@ -107,7 +107,7 @@ > #define REG_EFUSE_TEST 0x0034 > #define EFUSE_TRPT BIT(7) > /* 00: Wifi Efuse, 01: BT Efuse0, 10: BT Efuse1, 11: BT Efuse2 */ > -#define EFUSE_CELL_SEL (BIT(8)|BIT(9)) > +#define EFUSE_CELL_SEL (BIT(8) | BIT(9)) > #define EFUSE_LDOE25_ENABLE BIT(31) > #define EFUSE_SELECT_MASK 0x0300 > #define EFUSE_WIFI_SELECT 0x0000 > @@ -165,7 +165,6 @@ > control */ > #define MULTI_GPS_FUNC_EN BIT(22) /* GPS function enable */ > > - > #define REG_MCU_FW_DL 0x0080 > #define MCU_FW_DL_ENABLE BIT(0) > #define MCU_FW_DL_READY BIT(1) > @@ -204,7 +203,7 @@ > #define SYS_CFG_BD_MAC2 BIT(9) > #define SYS_CFG_BD_MAC1 BIT(10) > #define SYS_CFG_IC_MACPHY_MODE BIT(11) > -#define SYS_CFG_CHIP_VER (BIT(12)|BIT(13)|BIT(14)|BIT(15)) > +#define SYS_CFG_CHIP_VER (BIT(12) | BIT(13) | BIT(14) | BIT(15)) > #define SYS_CFG_BT_FUNC BIT(16) > #define SYS_CFG_VENDOR_ID BIT(19) > #define SYS_CFG_PAD_HWPD_IDN BIT(22) > @@ -220,11 +219,10 @@ > #define SYS_CFG_CHIP_VERSION_MASK 0xf000 /* Bit 12 - 15 */ > #define SYS_CFG_CHIP_VERSION_SHIFT 12 > > - > #define REG_GPIO_OUTSTS 0x00f4 /* For RTL8723 only. */ > -#define GPIO_EFS_HCI_SEL (BIT(0)|BIT(1)) > -#define GPIO_PAD_HCI_SEL (BIT(2)|BIT(3)) > -#define GPIO_HCI_SEL (BIT(4)|BIT(5)) > +#define GPIO_EFS_HCI_SEL (BIT(0) | BIT(1)) > +#define GPIO_PAD_HCI_SEL (BIT(2) | BIT(3)) > +#define GPIO_HCI_SEL (BIT(4) | BIT(5)) > #define GPIO_PKG_SEL_HCI BIT(6) > #define GPIO_FEN_GPS BIT(7) > #define GPIO_FEN_BT BIT(8) > @@ -241,7 +239,7 @@ > #define GPIO_UPHY_SUSB BIT(21) > #define GPIO_PCI_SUSEN BIT(22) > #define GPIO_USB_SUSEN BIT(23) > -#define GPIO_RF_RL_ID (BIT(31)|BIT(30)|BIT(29)|BIT(28)) > +#define GPIO_RF_RL_ID (BIT(31) | BIT(30) | BIT(29) | BIT(28)) > > /* 0x0100 ~ 0x01FF MACTOP General Configuration */ > #define REG_CR 0x0100 > @@ -285,7 +283,6 @@ > #define TRXDMA_QUEUE_NORMAL 2 > #define TRXDMA_QUEUE_HIGH 3 > > - > #define REG_TRXFF_BNDY 0x0114 > #define REG_TRXFF_STATUS 0x0118 > #define REG_RXFF_PTR 0x011c > @@ -360,7 +357,6 @@ > #define REG_HGQ_INFORMATION 0x0414 > #define REG_BCNQ_INFORMATION 0x0418 > > - > #define REG_CPU_MGQ_INFORMATION 0x041c > #define REG_FWHW_TXQ_CTRL 0x0420 > #define FWHW_TXQ_CTRL_AMPDU_RETRY BIT(7) > @@ -411,7 +407,7 @@ > #define RSR_MCS7 BIT(19) > #define RSR_RSC_LOWER_SUB_CHANNEL BIT(21) /* 0x200000 */ > #define RSR_RSC_UPPER_SUB_CHANNEL BIT(22) /* 0x400000 */ > -#define RSR_RSC_BANDWIDTH_40M (RSR_RSC_UPPER_SUB_CHANNEL|\ > +#define RSR_RSC_BANDWIDTH_40M (RSR_RSC_UPPER_SUB_CHANNEL | \ > RSR_RSC_LOWER_SUB_CHANNEL) > #define RSR_ACK_SHORT_PREAMBLE BIT(23) > > @@ -427,7 +423,6 @@ > #define REG_INIRTS_RATE_SEL 0x0480 > #define REG_INIDATA_RATE_SEL 0x0484 > > - > #define REG_POWER_STATUS 0x04a4 > #define REG_POWER_STAGE1 0x04b4 > #define REG_POWER_STAGE2 0x04b8 > @@ -446,8 +441,6 @@ > #define REG_PTCL_ERR_STATUS 0x04e2 > #define REG_DUMMY 0x04fc > > - > - > /* 0x0500 ~ 0x05FF EDCA Configuration */ > #define REG_EDCA_VO_PARAM 0x0500 > #define REG_EDCA_VI_PARAM 0x0504 > @@ -592,7 +585,6 @@ > #define REG_RXERR_RPT 0x0664 > #define REG_WMAC_TRXPTCL_CTL 0x0668 > > - > /* Security */ > #define REG_CAM_CMD 0x0670 > #define CAM_CMD_POLLING BIT(31) > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Except for the endian issue, which is a real bug, this is mostly patch noise. The long strings are an outright nack. Jes ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-03-07 5:18 ` Jes Sorensen @ 2015-03-07 5:23 ` Joe Perches 2015-03-07 5:33 ` Jes Sorensen 0 siblings, 1 reply; 35+ messages in thread From: Joe Perches @ 2015-03-07 5:23 UTC (permalink / raw) To: Jes Sorensen; +Cc: linux-wireless, Larry.Finger On Sat, 2015-03-07 at 00:18 -0500, Jes Sorensen wrote: > The long strings are an outright nack. Pity. There's a specific exclusion in CodingStyle. Chapter 2: Breaking long lines and strings never break user-visible strings such as printk messages, because that breaks the ability to grep for them. ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-03-07 5:23 ` Joe Perches @ 2015-03-07 5:33 ` Jes Sorensen 0 siblings, 0 replies; 35+ messages in thread From: Jes Sorensen @ 2015-03-07 5:33 UTC (permalink / raw) To: Joe Perches; +Cc: linux-wireless, Larry.Finger Joe Perches <joe@perches.com> writes: > On Sat, 2015-03-07 at 00:18 -0500, Jes Sorensen wrote: >> The long strings are an outright nack. > > Pity. There's a specific exclusion in CodingStyle. > > Chapter 2: Breaking long lines and strings > > never break user-visible strings such as > printk messages, because that breaks the ability to grep for them. I know some people like this, and I disagree with this rule! I wrote this driver, and I am the one maintaining it. I love receiving fixes for bugs, but this is not a bug! If you wrote a piece of code, I wouldn't question how you prefer to maintain it. Jes ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-03-06 22:15 ` [PATCH 1/1] " Jes.Sorensen 2015-03-06 22:59 ` Joe Perches @ 2015-03-07 21:30 ` Larry Finger 2015-03-09 17:08 ` Jes Sorensen 1 sibling, 1 reply; 35+ messages in thread From: Larry Finger @ 2015-03-07 21:30 UTC (permalink / raw) To: Jes.Sorensen, linux-wireless On 03/06/2015 04:15 PM, Jes.Sorensen@redhat.com wrote: > From: Jes Sorensen <Jes.Sorensen@redhat.com> > > This is an alternate driver for the Realtek 8723AU (rtl8723au) written > from scratch utilizing the mac80211 stack. > > After spending months cleaning up the vendor provided rtl8723au > driver, which comes with it's own 802.11 stack included, I decided to > rewrite this driver from the bottom up. > > Many thanks to Johannes Berg for 802.11 insights and help and Larry > Finger for help with the vendor driver. > > The full git log for the development of this driver can be found here: > git git://git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git > branch rtl8723au-mac80211 > > This driver is still experimental, but has proven to be rather stable > for me. It lacks some features found in the staging driver, such as > power management, AMPDU, and 40MHz channel support. In addition there > is no AP and monitor support at this point. > > Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Quilt reports the following when this patch is refreshed: Warning: trailing whitespace in lines 2862,3273,3492,3521 of drivers/net/wireless/rtl8xxxu.c I have not analyzed all the temporary manipulations of rtl8xxxu_debug to see what you are doing; however, I suggest that you add a module parameter so that debugging can be enabled without rebuilding the module. That way a user who is using a distro binary can enable debugging without the hassle of a full kernel rebuild. Because this driver is under drivers/net, checkpatch.pl adds additional tests that may not be used in other trees. For instance, it complains when it finds a block comment that starts with a bare "/*". What is usually done is to use "/**" instead. I think I understand why some of the "#if 0" blocks are present, but others are not clear. For example, I see no value of keeping code that is labelled "only for PCIe". Is it your intention to add the RTL8723AE to this driver? Running checkpatch.pl on this patch results in total of 24 errors, 99 warnings, and 105 checks. From your mail exchange with Joe Perches, I understand that you will not wish to fix all of these; however, the errors should be handled. The fewer of the warnings or checks that are left, the better, if only to prevent interference from the script kiddies. I like the clean look of the code. That is particularly impressive given the look of the original. I wish I had the hardware on which to test it. Perhaps I can wedge it into a kernel version that builds and runs on my Radxa Rock, Larry ^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/1] New driver: rtl8723au (mac80211) 2015-03-07 21:30 ` Larry Finger @ 2015-03-09 17:08 ` Jes Sorensen 0 siblings, 0 replies; 35+ messages in thread From: Jes Sorensen @ 2015-03-09 17:08 UTC (permalink / raw) To: Larry Finger; +Cc: linux-wireless Larry Finger <Larry.Finger@lwfinger.net> writes: > Quilt reports the following when this patch is refreshed: > > Warning: trailing whitespace in lines 2862,3273,3492,3521 of > drivers/net/wireless/rtl8xxxu.c Hi Larry, I fixed up the trailing whitespaces in v2 (and added a (setq show-trailing-whitespace t) to my config file). > I have not analyzed all the temporary manipulations of rtl8xxxu_debug > to see what you are doing; however, I suggest that you add a module > parameter so that debugging can be enabled without rebuilding the > module. That way a user who is using a distro binary can enable > debugging without the hassle of a full kernel rebuild. I added a module paramter, and worked around the %@#$%#$%#$ dynamic debug issues to get the driver to actually print stuff when you set it. For some reason I was convinced I already had this as a module parameter. > Because this driver is under drivers/net, checkpatch.pl adds > additional tests that may not be used in other trees. For instance, it > complains when it finds a block comment that starts with a bare > "/*". What is usually done is to use "/**" instead. This part I will leave as is. > I think I understand why some of the "#if 0" blocks are present, but > others are not clear. For example, I see no value of keeping code that > is labelled "only for PCIe". Is it your intention to add the RTL8723AE > to this driver? I prefer to keep them in place for now, as it makes it easier for me to debug the tables when I compare them to the tables in the vendor driver. I will eventually remove those, but it's to early to do that just yet. > Running checkpatch.pl on this patch results in total of 24 errors, 99 > warnings, and 105 checks. From your mail exchange with Joe Perches, I > understand that you will not wish to fix all of these; however, the > errors should be handled. The fewer of the warnings or checks that are > left, the better, if only to prevent interference from the script > kiddies. I should have run checkpatch on Friday when I posted the first version. Some of the formatting was due to converting from printk() to other wrappers. It's rather disturbing how checkpatch has been turned into a trolling tool used by the script kiddies to harrass actual development, and to bump their number of commits in the git log, but I guess there isn't much to do about it. As always, I very much appreciate real bug reports! > I like the clean look of the code. That is particularly impressive > given the look of the original. I wish I had the hardware on which to > test it. Perhaps I can wedge it into a kernel version that builds and > runs on my Radxa Rock, Thanks, I tried hard to keep it clean, even though there were parts of badness that crept over from the original driver. In particular in the radio configuration portions. Cheers, Jes ^ permalink raw reply [flat|nested] 35+ messages in thread
end of thread, other threads:[~2015-09-29 10:42 UTC | newest] Thread overview: 35+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-05-05 20:04 [PATCH 1/1] New driver: rtl8723au (mac80211) Xose Vazquez Perez 2015-05-05 21:40 ` Jes Sorensen 2015-05-07 9:43 ` Xose Vazquez Perez 2015-05-07 15:43 ` Larry Finger -- strict thread matches above, loose matches on Subject: below -- 2015-03-23 20:24 [PATCH v3 0/1] " Jes.Sorensen 2015-03-23 20:25 ` [PATCH 1/1] " Jes.Sorensen 2015-03-23 22:51 ` Joe Perches 2015-03-24 1:25 ` Jes Sorensen 2015-04-28 8:37 ` Kalle Valo 2015-04-28 12:55 ` Kalle Valo 2015-04-28 14:27 ` Jes Sorensen 2015-04-28 15:15 ` Larry Finger 2015-09-06 13:38 ` Kalle Valo 2015-09-06 16:41 ` Larry Finger 2015-09-07 13:37 ` Kalle Valo 2015-09-07 18:43 ` Jes Sorensen 2015-09-07 18:50 ` Larry Finger 2015-09-09 14:16 ` Jes Sorensen 2015-09-29 8:56 ` Kalle Valo 2015-09-29 10:42 ` Jes Sorensen 2015-03-09 17:00 [PATCH v2 0/1] " Jes.Sorensen 2015-03-09 17:00 ` [PATCH 1/1] " Jes.Sorensen 2015-03-09 17:46 ` Johannes Berg 2015-03-09 18:35 ` Jes Sorensen 2015-03-09 19:52 ` Johannes Berg 2015-03-09 18:20 ` Joe Perches 2015-03-09 18:43 ` Jes Sorensen 2015-03-09 18:51 ` Joe Perches 2015-03-09 19:02 ` Jes Sorensen 2015-03-09 19:07 ` Joe Perches 2015-03-06 22:15 [PATCH 0/1] " Jes.Sorensen 2015-03-06 22:15 ` [PATCH 1/1] " Jes.Sorensen 2015-03-06 22:59 ` Joe Perches 2015-03-07 5:18 ` Jes Sorensen 2015-03-07 5:23 ` Joe Perches 2015-03-07 5:33 ` Jes Sorensen 2015-03-07 21:30 ` Larry Finger 2015-03-09 17:08 ` Jes Sorensen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).