Re: [PATCH] brcmfmac: check result of USB firmware request

[Arend van Spriel <arend@broadcom.com>]

On 05/07/15 14:13, Rafał Miłecki wrote:
> This prevents silence failures with driver waiting (infinitely) for a
> callback.

Looks like proper thing to do :-p

Acked-by: Arend van Spriel <arend@broadcom.com>
> Signed-off-by: Rafał Miłecki<zajec5@gmail.com>
> ---
> I don't really have any opinion if this should go for next or as a fix.
> ---
>   drivers/net/wireless/brcm80211/brcmfmac/usb.c | 9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/brcm80211/brcmfmac/usb.c
> index 5df6aa7..daba86d 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/usb.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/usb.c
> @@ -1270,8 +1270,13 @@ static int brcmf_usb_probe_cb(struct brcmf_usbdev_info *devinfo)
>   	bus->chiprev = bus_pub->chiprev;
>
>   	/* request firmware here */
> -	brcmf_fw_get_firmwares(dev, 0, brcmf_usb_get_fwname(devinfo), NULL,
> -			       brcmf_usb_probe_phase2);
> +	ret = brcmf_fw_get_firmwares(dev, 0, brcmf_usb_get_fwname(devinfo),
> +				     NULL, brcmf_usb_probe_phase2);
> +	if (ret) {
> +		brcmf_err("firmware request failed: %d\n", ret);
> +		goto fail;
> +	}
> +
>   	return 0;
>
>   fail: