* [PATCH 1/2] brcmfmac: move strings debugging Broadcom errors to debug.c
@ 2015-05-07 19:07 Rafał Miłecki
2015-05-07 19:07 ` [PATCH 2/2] brcmfmac: fix debugging info for received hw messages with errors Rafał Miłecki
2015-05-08 10:08 ` [PATCH 1/2] brcmfmac: move strings debugging Broadcom errors to debug.c Arend van Spriel
0 siblings, 2 replies; 5+ messages in thread
From: Rafał Miłecki @ 2015-05-07 19:07 UTC (permalink / raw)
To: Kalle Valo, linux-wireless
Cc: Brett Rudley, Arend van Spriel, Franky (Zhenhui) Lin,
Hante Meuleman, brcm80211-dev-list, Rafał Miłecki
They are used with CONFIG_BRCMDBG so it makes sense to put them in debug
specific file. Also they aren't really specific to fwil.c.
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
drivers/net/wireless/brcm80211/brcmfmac/debug.c | 64 ++++++++++++++++++++++
drivers/net/wireless/brcm80211/brcmfmac/debug.h | 5 ++
drivers/net/wireless/brcm80211/brcmfmac/fwil.c | 73 +------------------------
3 files changed, 70 insertions(+), 72 deletions(-)
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/debug.c b/drivers/net/wireless/brcm80211/brcmfmac/debug.c
index 9b473d5..2d9a1c0 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/debug.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/debug.c
@@ -115,3 +115,67 @@ int brcmf_debugfs_add_entry(struct brcmf_pub *drvr, const char *fn,
return PTR_ERR_OR_ZERO(dentry);
}
+
+static const char * const brcmf_errstr[] = {
+ "BCME_OK",
+ "BCME_ERROR",
+ "BCME_BADARG",
+ "BCME_BADOPTION",
+ "BCME_NOTUP",
+ "BCME_NOTDOWN",
+ "BCME_NOTAP",
+ "BCME_NOTSTA",
+ "BCME_BADKEYIDX",
+ "BCME_RADIOOFF",
+ "BCME_NOTBANDLOCKED",
+ "BCME_NOCLK",
+ "BCME_BADRATESET",
+ "BCME_BADBAND",
+ "BCME_BUFTOOSHORT",
+ "BCME_BUFTOOLONG",
+ "BCME_BUSY",
+ "BCME_NOTASSOCIATED",
+ "BCME_BADSSIDLEN",
+ "BCME_OUTOFRANGECHAN",
+ "BCME_BADCHAN",
+ "BCME_BADADDR",
+ "BCME_NORESOURCE",
+ "BCME_UNSUPPORTED",
+ "BCME_BADLEN",
+ "BCME_NOTREADY",
+ "BCME_EPERM",
+ "BCME_NOMEM",
+ "BCME_ASSOCIATED",
+ "BCME_RANGE",
+ "BCME_NOTFOUND",
+ "BCME_WME_NOT_ENABLED",
+ "BCME_TSPEC_NOTFOUND",
+ "BCME_ACM_NOTSUPPORTED",
+ "BCME_NOT_WME_ASSOCIATION",
+ "BCME_SDIO_ERROR",
+ "BCME_DONGLE_DOWN",
+ "BCME_VERSION",
+ "BCME_TXFAIL",
+ "BCME_RXFAIL",
+ "BCME_NODEVICE",
+ "BCME_NMODE_DISABLED",
+ "BCME_NONRESIDENT",
+ "BCME_SCANREJECT",
+ "BCME_USAGE_ERROR",
+ "BCME_IOCTL_ERROR",
+ "BCME_SERIAL_PORT_ERR",
+ "BCME_DISABLED",
+ "BCME_DECERR",
+ "BCME_ENCERR",
+ "BCME_MICERR",
+ "BCME_REPLAY",
+ "BCME_IE_NOTFOUND",
+};
+
+const char *brcmf_get_errstr(u32 err)
+{
+ if (err >= ARRAY_SIZE(brcmf_errstr))
+ return "(unknown)";
+
+ return brcmf_errstr[err];
+}
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/debug.h b/drivers/net/wireless/brcm80211/brcmfmac/debug.h
index eb0b8c4..d1b2a5c 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/debug.h
+++ b/drivers/net/wireless/brcm80211/brcmfmac/debug.h
@@ -111,6 +111,7 @@ void brcmf_debugfs_detach(struct brcmf_pub *drvr);
struct dentry *brcmf_debugfs_get_devdir(struct brcmf_pub *drvr);
int brcmf_debugfs_add_entry(struct brcmf_pub *drvr, const char *fn,
int (*read_fn)(struct seq_file *seq, void *data));
+const char *brcmf_get_errstr(u32 err);
#else
static inline void brcmf_debugfs_init(void)
{
@@ -131,6 +132,10 @@ int brcmf_debugfs_add_entry(struct brcmf_pub *drvr, const char *fn,
{
return 0;
}
+static inline const char *brcmf_get_errstr(u32 err)
+{
+ return "";
+}
#endif
#endif /* BRCMFMAC_DEBUG_H */
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/fwil.c b/drivers/net/wireless/brcm80211/brcmfmac/fwil.c
index dcfa0bb..bdbdc9e 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/fwil.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/fwil.c
@@ -32,77 +32,6 @@
#define MAX_HEX_DUMP_LEN 64
-#ifdef DEBUG
-static const char * const brcmf_fil_errstr[] = {
- "BCME_OK",
- "BCME_ERROR",
- "BCME_BADARG",
- "BCME_BADOPTION",
- "BCME_NOTUP",
- "BCME_NOTDOWN",
- "BCME_NOTAP",
- "BCME_NOTSTA",
- "BCME_BADKEYIDX",
- "BCME_RADIOOFF",
- "BCME_NOTBANDLOCKED",
- "BCME_NOCLK",
- "BCME_BADRATESET",
- "BCME_BADBAND",
- "BCME_BUFTOOSHORT",
- "BCME_BUFTOOLONG",
- "BCME_BUSY",
- "BCME_NOTASSOCIATED",
- "BCME_BADSSIDLEN",
- "BCME_OUTOFRANGECHAN",
- "BCME_BADCHAN",
- "BCME_BADADDR",
- "BCME_NORESOURCE",
- "BCME_UNSUPPORTED",
- "BCME_BADLEN",
- "BCME_NOTREADY",
- "BCME_EPERM",
- "BCME_NOMEM",
- "BCME_ASSOCIATED",
- "BCME_RANGE",
- "BCME_NOTFOUND",
- "BCME_WME_NOT_ENABLED",
- "BCME_TSPEC_NOTFOUND",
- "BCME_ACM_NOTSUPPORTED",
- "BCME_NOT_WME_ASSOCIATION",
- "BCME_SDIO_ERROR",
- "BCME_DONGLE_DOWN",
- "BCME_VERSION",
- "BCME_TXFAIL",
- "BCME_RXFAIL",
- "BCME_NODEVICE",
- "BCME_NMODE_DISABLED",
- "BCME_NONRESIDENT",
- "BCME_SCANREJECT",
- "BCME_USAGE_ERROR",
- "BCME_IOCTL_ERROR",
- "BCME_SERIAL_PORT_ERR",
- "BCME_DISABLED",
- "BCME_DECERR",
- "BCME_ENCERR",
- "BCME_MICERR",
- "BCME_REPLAY",
- "BCME_IE_NOTFOUND",
-};
-
-static const char *brcmf_fil_get_errstr(u32 err)
-{
- if (err >= ARRAY_SIZE(brcmf_fil_errstr))
- return "(unknown)";
-
- return brcmf_fil_errstr[err];
-}
-#else
-static const char *brcmf_fil_get_errstr(u32 err)
-{
- return "";
-}
-#endif /* DEBUG */
-
static s32
brcmf_fil_cmd_data(struct brcmf_if *ifp, u32 cmd, void *data, u32 len, bool set)
{
@@ -125,7 +54,7 @@ brcmf_fil_cmd_data(struct brcmf_if *ifp, u32 cmd, void *data, u32 len, bool set)
return 0;
brcmf_dbg(FIL, "Failed: %s (%d)\n",
- brcmf_fil_get_errstr((u32)(-err)), err);
+ brcmf_get_errstr((u32)(-err)), err);
return -EBADE;
}
--
1.8.4.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] brcmfmac: fix debugging info for received hw messages with errors
2015-05-07 19:07 [PATCH 1/2] brcmfmac: move strings debugging Broadcom errors to debug.c Rafał Miłecki
@ 2015-05-07 19:07 ` Rafał Miłecki
2015-05-08 10:29 ` Arend van Spriel
2015-05-08 10:08 ` [PATCH 1/2] brcmfmac: move strings debugging Broadcom errors to debug.c Arend van Spriel
1 sibling, 1 reply; 5+ messages in thread
From: Rafał Miłecki @ 2015-05-07 19:07 UTC (permalink / raw)
To: Kalle Valo, linux-wireless
Cc: Brett Rudley, Arend van Spriel, Franky (Zhenhui) Lin,
Hante Meuleman, brcm80211-dev-list, Rafał Miłecki
Code in function setting/querying device was treating every error as
Broadcom protocol specific one. It wasn't right thing to do as most of
subcalls return "normal" errors (errno-base.h). This resulted in e.g.:
brcmf_usb_rx_ctlpkt: rxctl wait timed out
brcmfmac: brcmf_fil_cmd_data Failed: BCME_NOTDOWN (-5)
which was misleading because of interpreting -EIO as BCME_NOTDOWN.
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
drivers/net/wireless/brcm80211/brcmfmac/bcdc.c | 5 ++++-
drivers/net/wireless/brcm80211/brcmfmac/fwil.c | 3 +--
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcdc.c b/drivers/net/wireless/brcm80211/brcmfmac/bcdc.c
index 8e0e91c..47941ab 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/bcdc.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/bcdc.c
@@ -203,8 +203,11 @@ retry:
}
/* Check the ERROR flag */
- if (flags & BCDC_DCMD_ERROR)
+ if (flags & BCDC_DCMD_ERROR) {
ret = le32_to_cpu(msg->status);
+ brcmf_dbg(BCDC, "received message with error %s (%d)\n",
+ brcmf_get_errstr((u32)(-ret)), ret);
+ }
done:
return ret;
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/fwil.c b/drivers/net/wireless/brcm80211/brcmfmac/fwil.c
index bdbdc9e..c86a522 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/fwil.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/fwil.c
@@ -53,8 +53,7 @@ brcmf_fil_cmd_data(struct brcmf_if *ifp, u32 cmd, void *data, u32 len, bool set)
if (err >= 0)
return 0;
- brcmf_dbg(FIL, "Failed: %s (%d)\n",
- brcmf_get_errstr((u32)(-err)), err);
+ brcmf_dbg(FIL, "Failed: %d\n", err);
return -EBADE;
}
--
1.8.4.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] brcmfmac: fix debugging info for received hw messages with errors
2015-05-07 19:07 ` [PATCH 2/2] brcmfmac: fix debugging info for received hw messages with errors Rafał Miłecki
@ 2015-05-08 10:29 ` Arend van Spriel
0 siblings, 0 replies; 5+ messages in thread
From: Arend van Spriel @ 2015-05-08 10:29 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Kalle Valo, linux-wireless, Brett Rudley, Franky (Zhenhui) Lin,
Hante Meuleman, brcm80211-dev-list
On 05/07/15 21:07, Rafał Miłecki wrote:
> Code in function setting/querying device was treating every error as
> Broadcom protocol specific one. It wasn't right thing to do as most of
> subcalls return "normal" errors (errno-base.h). This resulted in e.g.:
> brcmf_usb_rx_ctlpkt: rxctl wait timed out
> brcmfmac: brcmf_fil_cmd_data Failed: BCME_NOTDOWN (-5)
> which was misleading because of interpreting -EIO as BCME_NOTDOWN.
So this is the reason for putting the error map in debug.c, but you are
only addressing devices using bcdc protocol, ie. SDIO and USB. Also need
to address PCIE. I would prefer to extend the query and set callbacks in
struct brcmf_proto (proto.h) to pass firmware error code up so fwil can
keep doing the mapping to string representation and have the callbacks
return -EPROTO if firmware error code is not BCME_OK. Need to assure it
can not get -EPROTO for other reasons.
Regards,
Arend
> Signed-off-by: Rafał Miłecki<zajec5@gmail.com>
> ---
> drivers/net/wireless/brcm80211/brcmfmac/bcdc.c | 5 ++++-
> drivers/net/wireless/brcm80211/brcmfmac/fwil.c | 3 +--
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcdc.c b/drivers/net/wireless/brcm80211/brcmfmac/bcdc.c
> index 8e0e91c..47941ab 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/bcdc.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/bcdc.c
> @@ -203,8 +203,11 @@ retry:
> }
>
> /* Check the ERROR flag */
> - if (flags& BCDC_DCMD_ERROR)
> + if (flags& BCDC_DCMD_ERROR) {
> ret = le32_to_cpu(msg->status);
> + brcmf_dbg(BCDC, "received message with error %s (%d)\n",
> + brcmf_get_errstr((u32)(-ret)), ret);
> + }
>
> done:
> return ret;
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/fwil.c b/drivers/net/wireless/brcm80211/brcmfmac/fwil.c
> index bdbdc9e..c86a522 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/fwil.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/fwil.c
> @@ -53,8 +53,7 @@ brcmf_fil_cmd_data(struct brcmf_if *ifp, u32 cmd, void *data, u32 len, bool set)
> if (err>= 0)
> return 0;
>
> - brcmf_dbg(FIL, "Failed: %s (%d)\n",
> - brcmf_get_errstr((u32)(-err)), err);
> + brcmf_dbg(FIL, "Failed: %d\n", err);
> return -EBADE;
> }
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] brcmfmac: move strings debugging Broadcom errors to debug.c
2015-05-07 19:07 [PATCH 1/2] brcmfmac: move strings debugging Broadcom errors to debug.c Rafał Miłecki
2015-05-07 19:07 ` [PATCH 2/2] brcmfmac: fix debugging info for received hw messages with errors Rafał Miłecki
@ 2015-05-08 10:08 ` Arend van Spriel
2015-05-08 10:24 ` Rafał Miłecki
1 sibling, 1 reply; 5+ messages in thread
From: Arend van Spriel @ 2015-05-08 10:08 UTC (permalink / raw)
To: Rafał Miłecki; +Cc: Kalle Valo, linux-wireless, brcm80211-dev-list
On 05/07/15 21:07, Rafał Miłecki wrote:
> They are used with CONFIG_BRCMDBG so it makes sense to put them in debug
> specific file. Also they aren't really specific to fwil.c.
Actually they are. fwil is abbreviation of firmware interface layer and
the intention is to give the error as given by firmware. However, as you
discovered it also (wrongly) maps linux errors and that needs to be
fixed as it can confuse people staring at the log.
Regards,
Arend
> Signed-off-by: Rafał Miłecki<zajec5@gmail.com>
> ---
> drivers/net/wireless/brcm80211/brcmfmac/debug.c | 64 ++++++++++++++++++++++
> drivers/net/wireless/brcm80211/brcmfmac/debug.h | 5 ++
> drivers/net/wireless/brcm80211/brcmfmac/fwil.c | 73 +------------------------
> 3 files changed, 70 insertions(+), 72 deletions(-)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/debug.c b/drivers/net/wireless/brcm80211/brcmfmac/debug.c
> index 9b473d5..2d9a1c0 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/debug.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/debug.c
> @@ -115,3 +115,67 @@ int brcmf_debugfs_add_entry(struct brcmf_pub *drvr, const char *fn,
>
> return PTR_ERR_OR_ZERO(dentry);
> }
> +
> +static const char * const brcmf_errstr[] = {
> + "BCME_OK",
> + "BCME_ERROR",
> + "BCME_BADARG",
> + "BCME_BADOPTION",
> + "BCME_NOTUP",
> + "BCME_NOTDOWN",
> + "BCME_NOTAP",
> + "BCME_NOTSTA",
> + "BCME_BADKEYIDX",
> + "BCME_RADIOOFF",
> + "BCME_NOTBANDLOCKED",
> + "BCME_NOCLK",
> + "BCME_BADRATESET",
> + "BCME_BADBAND",
> + "BCME_BUFTOOSHORT",
> + "BCME_BUFTOOLONG",
> + "BCME_BUSY",
> + "BCME_NOTASSOCIATED",
> + "BCME_BADSSIDLEN",
> + "BCME_OUTOFRANGECHAN",
> + "BCME_BADCHAN",
> + "BCME_BADADDR",
> + "BCME_NORESOURCE",
> + "BCME_UNSUPPORTED",
> + "BCME_BADLEN",
> + "BCME_NOTREADY",
> + "BCME_EPERM",
> + "BCME_NOMEM",
> + "BCME_ASSOCIATED",
> + "BCME_RANGE",
> + "BCME_NOTFOUND",
> + "BCME_WME_NOT_ENABLED",
> + "BCME_TSPEC_NOTFOUND",
> + "BCME_ACM_NOTSUPPORTED",
> + "BCME_NOT_WME_ASSOCIATION",
> + "BCME_SDIO_ERROR",
> + "BCME_DONGLE_DOWN",
> + "BCME_VERSION",
> + "BCME_TXFAIL",
> + "BCME_RXFAIL",
> + "BCME_NODEVICE",
> + "BCME_NMODE_DISABLED",
> + "BCME_NONRESIDENT",
> + "BCME_SCANREJECT",
> + "BCME_USAGE_ERROR",
> + "BCME_IOCTL_ERROR",
> + "BCME_SERIAL_PORT_ERR",
> + "BCME_DISABLED",
> + "BCME_DECERR",
> + "BCME_ENCERR",
> + "BCME_MICERR",
> + "BCME_REPLAY",
> + "BCME_IE_NOTFOUND",
> +};
> +
> +const char *brcmf_get_errstr(u32 err)
> +{
> + if (err>= ARRAY_SIZE(brcmf_errstr))
> + return "(unknown)";
> +
> + return brcmf_errstr[err];
> +}
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/debug.h b/drivers/net/wireless/brcm80211/brcmfmac/debug.h
> index eb0b8c4..d1b2a5c 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/debug.h
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/debug.h
> @@ -111,6 +111,7 @@ void brcmf_debugfs_detach(struct brcmf_pub *drvr);
> struct dentry *brcmf_debugfs_get_devdir(struct brcmf_pub *drvr);
> int brcmf_debugfs_add_entry(struct brcmf_pub *drvr, const char *fn,
> int (*read_fn)(struct seq_file *seq, void *data));
> +const char *brcmf_get_errstr(u32 err);
> #else
> static inline void brcmf_debugfs_init(void)
> {
> @@ -131,6 +132,10 @@ int brcmf_debugfs_add_entry(struct brcmf_pub *drvr, const char *fn,
> {
> return 0;
> }
> +static inline const char *brcmf_get_errstr(u32 err)
> +{
> + return "";
> +}
> #endif
>
> #endif /* BRCMFMAC_DEBUG_H */
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/fwil.c b/drivers/net/wireless/brcm80211/brcmfmac/fwil.c
> index dcfa0bb..bdbdc9e 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/fwil.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/fwil.c
> @@ -32,77 +32,6 @@
>
> #define MAX_HEX_DUMP_LEN 64
>
> -#ifdef DEBUG
> -static const char * const brcmf_fil_errstr[] = {
> - "BCME_OK",
> - "BCME_ERROR",
> - "BCME_BADARG",
> - "BCME_BADOPTION",
> - "BCME_NOTUP",
> - "BCME_NOTDOWN",
> - "BCME_NOTAP",
> - "BCME_NOTSTA",
> - "BCME_BADKEYIDX",
> - "BCME_RADIOOFF",
> - "BCME_NOTBANDLOCKED",
> - "BCME_NOCLK",
> - "BCME_BADRATESET",
> - "BCME_BADBAND",
> - "BCME_BUFTOOSHORT",
> - "BCME_BUFTOOLONG",
> - "BCME_BUSY",
> - "BCME_NOTASSOCIATED",
> - "BCME_BADSSIDLEN",
> - "BCME_OUTOFRANGECHAN",
> - "BCME_BADCHAN",
> - "BCME_BADADDR",
> - "BCME_NORESOURCE",
> - "BCME_UNSUPPORTED",
> - "BCME_BADLEN",
> - "BCME_NOTREADY",
> - "BCME_EPERM",
> - "BCME_NOMEM",
> - "BCME_ASSOCIATED",
> - "BCME_RANGE",
> - "BCME_NOTFOUND",
> - "BCME_WME_NOT_ENABLED",
> - "BCME_TSPEC_NOTFOUND",
> - "BCME_ACM_NOTSUPPORTED",
> - "BCME_NOT_WME_ASSOCIATION",
> - "BCME_SDIO_ERROR",
> - "BCME_DONGLE_DOWN",
> - "BCME_VERSION",
> - "BCME_TXFAIL",
> - "BCME_RXFAIL",
> - "BCME_NODEVICE",
> - "BCME_NMODE_DISABLED",
> - "BCME_NONRESIDENT",
> - "BCME_SCANREJECT",
> - "BCME_USAGE_ERROR",
> - "BCME_IOCTL_ERROR",
> - "BCME_SERIAL_PORT_ERR",
> - "BCME_DISABLED",
> - "BCME_DECERR",
> - "BCME_ENCERR",
> - "BCME_MICERR",
> - "BCME_REPLAY",
> - "BCME_IE_NOTFOUND",
> -};
> -
> -static const char *brcmf_fil_get_errstr(u32 err)
> -{
> - if (err>= ARRAY_SIZE(brcmf_fil_errstr))
> - return "(unknown)";
> -
> - return brcmf_fil_errstr[err];
> -}
> -#else
> -static const char *brcmf_fil_get_errstr(u32 err)
> -{
> - return "";
> -}
> -#endif /* DEBUG */
> -
> static s32
> brcmf_fil_cmd_data(struct brcmf_if *ifp, u32 cmd, void *data, u32 len, bool set)
> {
> @@ -125,7 +54,7 @@ brcmf_fil_cmd_data(struct brcmf_if *ifp, u32 cmd, void *data, u32 len, bool set)
> return 0;
>
> brcmf_dbg(FIL, "Failed: %s (%d)\n",
> - brcmf_fil_get_errstr((u32)(-err)), err);
> + brcmf_get_errstr((u32)(-err)), err);
> return -EBADE;
> }
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] brcmfmac: move strings debugging Broadcom errors to debug.c
2015-05-08 10:08 ` [PATCH 1/2] brcmfmac: move strings debugging Broadcom errors to debug.c Arend van Spriel
@ 2015-05-08 10:24 ` Rafał Miłecki
0 siblings, 0 replies; 5+ messages in thread
From: Rafał Miłecki @ 2015-05-08 10:24 UTC (permalink / raw)
To: Arend van Spriel
Cc: Kalle Valo, linux-wireless@vger.kernel.org, brcm80211 development
On 8 May 2015 at 12:08, Arend van Spriel <arend@broadcom.com> wrote:
> On 05/07/15 21:07, Rafał Miłecki wrote:
>>
>> They are used with CONFIG_BRCMDBG so it makes sense to put them in debug
>> specific file. Also they aren't really specific to fwil.c.
>
> Actually they are. fwil is abbreviation of firmware interface layer and the
> intention is to give the error as given by firmware. However, as you
> discovered it also (wrongly) maps linux errors and that needs to be fixed as
> it can confuse people staring at the log.
OK, my commit message is wrong. What about change itself? Should I
just fix the commit message?
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-05-08 10:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-07 19:07 [PATCH 1/2] brcmfmac: move strings debugging Broadcom errors to debug.c Rafał Miłecki
2015-05-07 19:07 ` [PATCH 2/2] brcmfmac: fix debugging info for received hw messages with errors Rafał Miłecki
2015-05-08 10:29 ` Arend van Spriel
2015-05-08 10:08 ` [PATCH 1/2] brcmfmac: move strings debugging Broadcom errors to debug.c Arend van Spriel
2015-05-08 10:24 ` Rafał Miłecki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).