Re: [PATCH] ath9k: add phy.c

[Oleksij Rempel <linux@rempel-privat.de>]

[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]

Am 16.05.2015 um 07:36 schrieb Joe Perches:
> On Sat, 2015-05-16 at 07:27 +0200, Oleksij Rempel wrote:
> 
>> Am 15.05.2015 um 20:35 schrieb Joe Perches:
>>> On Fri, 2015-05-15 at 14:35 +0200, Oleksij Rempel wrote:
>>>> ... and move dup code from ar5008_phy.c and ar9002_phy.c to phy.c
>>> []
>>>> diff --git a/drivers/net/wireless/ath/ath9k/phy.c b/drivers/net/wireless/ath/ath9k/phy.c
>>>
>>>> +void phy_hw_spur_mitigate(struct ath_hw *ah,
>>>> +			  struct ath9k_channel *chan, int bin)
>>>> +{
> []
>>>> +	static int inc[4] = { 0, 100, 0, 0 };
>>>
>>> static const
> 
>> This is cleanup patch, no fixes optimisations
>> or regressions should be introduced.
> 
> Hello Oleksij.
> 
> One of the old compilation units (ar9002_phy.c) had const on
> all those arrays, the other did not.

ok, thanks. changed to const version.

> const should be used here.
> 
>> If you see some problems in this
>> code, you are welcome to provide a patch on top of this one :)
> 
> I think you should take comments on the patches you submit.

What do you mean?

-- 
Regards,
Oleksij


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 230 bytes --]