From: Felix Fietkau <nbd@openwrt.org>
To: Oleksij Rempel <linux@rempel-privat.de>,
ath9k-devel@qca.qualcomm.com, kvalo@codeaurora.org,
linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net
Subject: Re: [PATCH] ath9k: add phy.c
Date: Sat, 16 May 2015 07:45:02 +0200 [thread overview]
Message-ID: <5556D95E.40706@openwrt.org> (raw)
In-Reply-To: <5556D48B.3090708@rempel-privat.de>
On 2015-05-16 07:24, Oleksij Rempel wrote:
> Am 15.05.2015 um 21:34 schrieb Felix Fietkau:
>> On 2015-05-15 14:35, Oleksij Rempel wrote:
>>> ... and move dup code from ar5008_phy.c and ar9002_phy.c to phy.c
>>>
>>> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
>> We already have base functionality for AR5008-AR9002 provided in some
>> ar5008_phy.c, and ar5008_hw_attach_phy_ops is called for those chipsets
>> as well. Please keep the de-duplicated code there instead of adding a
>> new phy.c, because AR9003+ uses a completely different codepath.
>>
>> - Felix
>>
>
> ok, thanks.
> Currently i celled this function phy_hw_spur_mitigate(), is it ok or
> there is some better name for this code?
Just use the ar5008 prefix like in the other functions.
- Felix
next prev parent reply other threads:[~2015-05-16 5:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 12:35 [PATCH] ath9k: add phy.c Oleksij Rempel
2015-05-15 14:38 ` Julian Calaby
2015-05-15 14:44 ` Sedat Dilek
2015-05-15 18:35 ` Joe Perches
2015-05-16 5:27 ` Oleksij Rempel
2015-05-16 5:36 ` Joe Perches
2015-05-16 5:43 ` Oleksij Rempel
2015-05-15 19:34 ` Felix Fietkau
2015-05-16 5:24 ` Oleksij Rempel
2015-05-16 5:45 ` Felix Fietkau [this message]
2015-05-17 19:49 ` [PATCH] ath9k: split ar5008_hw_spur_mitigate and reuse common code in ar9002_hw_spur_mitigate Oleksij Rempel
2015-05-26 11:03 ` ath9k: split ar5008_hw_spur_mitigate and reuse common code inar9002_hw_spur_mitigate Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5556D95E.40706@openwrt.org \
--to=nbd@openwrt.org \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=ath9k-devel@venema.h4ckr.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@rempel-privat.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).