From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Michael Büsch" <m@bues.ch>, "Chaoming Li" <chaoming_li@realsil.com.cn>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: Fix EFUSE_ANA8M map value
Date: Thu, 21 May 2015 16:54:59 -0500 [thread overview]
Message-ID: <555E5433.7000904@lwfinger.net> (raw)
In-Reply-To: <20150521214421.15983b0a@milhouse>
On 05/21/2015 02:44 PM, Michael Büsch wrote:
> The map entry EFUSE_ANA8M is supposed to be a bit mask of the SYS_CLK register (see efuse.c)
> It doesn't make sense to assign the enumeration value EFUSE_ANA8M. Assign the bitmask ANA8M instead.
> rtl8192se does not have ANA8M, so use 0 as bitmask.
>
> Signed-off-by: Michael Buesch <m@bues.ch>
>
> ---
>
> This is RFC, because I don't really know the device.
> The rtl8192se part of the patch is just a guess, because this driver's reg.h doesn't have an ANA8M define.
I think the patch is correct. Certainly loading an array entry with the offset
of the array makes little sense. This change makes the older drivers
(rtl8192c{e,u} and rtl8192se match the newer ones.
Once I test the patch, I will send it on to Kalle with my S-o-b.
Thanks,
Larry
next prev parent reply other threads:[~2015-05-21 21:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 19:44 [PATCH] rtlwifi: Fix EFUSE_ANA8M map value Michael Büsch
2015-05-21 21:54 ` Larry Finger [this message]
2015-05-22 5:00 ` Michael Büsch
2015-05-22 20:21 ` Larry Finger
2015-05-22 21:13 ` Michael Büsch
2015-05-23 5:15 ` Larry Finger
2015-05-23 10:40 ` Michael Büsch
2015-05-23 18:01 ` Michael Büsch
2015-05-25 16:10 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555E5433.7000904@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=linux-wireless@vger.kernel.org \
--cc=m@bues.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).