From: Varka Bhadram <varkabhadram@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Varka Bhadram <varkab@cdac.in>
Subject: Re: [PATCH wireless-next] mac80211: fix double flush workqueue
Date: Mon, 25 May 2015 09:32:18 +0530 [thread overview]
Message-ID: <55629ECA.9050203@gmail.com> (raw)
In-Reply-To: <1432020391.7437.2.camel@sipsolutions.net>
Hi Johannes Berg,
On 05/19/2015 12:56 PM, Johannes Berg wrote:
> On Fri, 2015-05-15 at 11:56 +0530, Varka Bhadram wrote:
>> In suspend functionality flushing of the workqueue is done
>> with ieee80211_stop_device(). This patch avoid flushing
>> the workqueue for two times.
> Why do you think this makes sense?
>
> This is done in entirely different places in the code.
Initially flushing of workqueue is done at [1], and also flushing of the same workqueue
has done with ieee80211_stop_device() at [2].
[1]:https://git.kernel.org/cgit/linux/kernel/git/jberg/mac80211-next.git/tree/net/mac80211/pm.c#n50
[2]:https://git.kernel.org/cgit/linux/kernel/git/jberg/mac80211-next.git/tree/net/mac80211/pm.c#n154
--
Thanks,
Varka Bhadram.
next prev parent reply other threads:[~2015-05-25 4:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 6:26 [PATCH wireless-next] mac80211: fix double flush workqueue Varka Bhadram
2015-05-19 7:26 ` Johannes Berg
2015-05-25 4:02 ` Varka Bhadram [this message]
2015-05-26 13:16 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55629ECA.9050203@gmail.com \
--to=varkabhadram@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=varkab@cdac.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).