From: Larry Finger <Larry.Finger@lwfinger.net>
To: Taehee Yoo <ap420073@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/3] rtlwifi: rtl8192cu: Fix variable isfirst_ampdu
Date: Fri, 05 Jun 2015 10:31:47 -0500 [thread overview]
Message-ID: <5571C0E3.1050601@lwfinger.net> (raw)
In-Reply-To: <1433512898-30137-3-git-send-email-ap420073@gmail.com>
On 06/05/2015 09:01 AM, Taehee Yoo wrote:
> rtl92cu_rx_query_desc set a isampdu twice.
> but second code is related to isfirst_ampdu.
> so i change it.
>
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
> ---
> drivers/net/wireless/rtlwifi/rtl8192cu/trx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Looks good.
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/trx.c b/drivers/net/wireless/rtlwifi/rtl8192cu/trx.c
> index cbead00..95880fe 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/trx.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/trx.c
> @@ -321,7 +321,7 @@ bool rtl92cu_rx_query_desc(struct ieee80211_hw *hw,
> stats->rate = (u8) GET_RX_DESC_RX_MCS(pdesc);
> stats->shortpreamble = (u16) GET_RX_DESC_SPLCP(pdesc);
> stats->isampdu = (bool) (GET_RX_DESC_PAGGR(pdesc) == 1);
> - stats->isampdu = (bool) ((GET_RX_DESC_PAGGR(pdesc) == 1)
> + stats->isfirst_ampdu = (bool)((GET_RX_DESC_PAGGR(pdesc) == 1)
> && (GET_RX_DESC_FAGGR(pdesc) == 1));
> stats->timestamp_low = GET_RX_DESC_TSFL(pdesc);
> stats->rx_is40Mhzpacket = (bool) GET_RX_DESC_BW(pdesc);
>
next prev parent reply other threads:[~2015-06-05 15:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 14:01 [PATCH 1/3] rtlwifi: rtl8192cu: remove duplicated routine in _rtl92c_phy_rf6052_config_parafile Taehee Yoo
2015-06-05 14:01 ` [PATCH 2/3] rtlwifi: rtl8192cu: debug message change "RTL8192CE" to "RTL8192CU" Taehee Yoo
2015-06-05 15:33 ` Larry Finger
2015-06-05 14:01 ` [PATCH 3/3] rtlwifi: rtl8192cu: Fix variable isfirst_ampdu Taehee Yoo
2015-06-05 15:31 ` Larry Finger [this message]
2015-06-05 15:37 ` [PATCH 1/3] rtlwifi: rtl8192cu: remove duplicated routine in _rtl92c_phy_rf6052_config_parafile Larry Finger
2015-06-06 4:57 ` Taehee Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5571C0E3.1050601@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=ap420073@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).