From: Larry Finger <Larry.Finger@lwfinger.net>
To: Taehee Yoo <ap420073@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/3] rtlwifi: rtl8192cu: debug message change "RTL8192CE" to "RTL8192CU"
Date: Fri, 05 Jun 2015 10:33:20 -0500 [thread overview]
Message-ID: <5571C140.6000504@lwfinger.net> (raw)
In-Reply-To: <1433512898-30137-2-git-send-email-ap420073@gmail.com>
On 06/05/2015 09:01 AM, Taehee Yoo wrote:
> In the rtlwifi/rtl8192cu, I change debug message "RTL8192CE" to
> "RTL8192CU".
>
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
> ---
> drivers/net/wireless/rtlwifi/rtl8192cu/phy.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
I am not sure that anyone ever uses this level of debug, but the changes are OK.
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/phy.c b/drivers/net/wireless/rtlwifi/rtl8192cu/phy.c
> index 12f6d47..5534dad 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/phy.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/phy.c
> @@ -162,7 +162,7 @@ bool _rtl92cu_phy_config_mac_with_headerfile(struct ieee80211_hw *hw)
> RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, "Read Rtl819XMACPHY_Array\n");
> arraylength = rtlphy->hwparam_tables[MAC_REG].length ;
> ptrarray = rtlphy->hwparam_tables[MAC_REG].pdata;
> - RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, "Img:RTL8192CEMAC_2T_ARRAY\n");
> + RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, "Img:RTL8192CUMAC_2T_ARRAY\n");
> for (i = 0; i < arraylength; i = i + 2)
> rtl_write_byte(rtlpriv, ptrarray[i], (u8) ptrarray[i + 1]);
> return true;
> @@ -259,18 +259,18 @@ bool rtl92cu_phy_config_rf_with_headerfile(struct ieee80211_hw *hw,
> radiob_arraylen = rtlphy->hwparam_tables[RADIOB_2T].length;
> radiob_array_table = rtlphy->hwparam_tables[RADIOB_2T].pdata;
> RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
> - "Radio_A:RTL8192CERADIOA_2TARRAY\n");
> + "Radio_A:RTL8192CURADIOA_2TARRAY\n");
> RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
> - "Radio_B:RTL8192CE_RADIOB_2TARRAY\n");
> + "Radio_B:RTL8192CU_RADIOB_2TARRAY\n");
> } else {
> radioa_arraylen = rtlphy->hwparam_tables[RADIOA_1T].length;
> radioa_array_table = rtlphy->hwparam_tables[RADIOA_1T].pdata;
> radiob_arraylen = rtlphy->hwparam_tables[RADIOB_1T].length;
> radiob_array_table = rtlphy->hwparam_tables[RADIOB_1T].pdata;
> RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
> - "Radio_A:RTL8192CE_RADIOA_1TARRAY\n");
> + "Radio_A:RTL8192CU_RADIOA_1TARRAY\n");
> RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
> - "Radio_B:RTL8192CE_RADIOB_1TARRAY\n");
> + "Radio_B:RTL8192CU_RADIOB_1TARRAY\n");
> }
> RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, "Radio No %x\n", rfpath);
> switch (rfpath) {
>
next prev parent reply other threads:[~2015-06-05 15:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 14:01 [PATCH 1/3] rtlwifi: rtl8192cu: remove duplicated routine in _rtl92c_phy_rf6052_config_parafile Taehee Yoo
2015-06-05 14:01 ` [PATCH 2/3] rtlwifi: rtl8192cu: debug message change "RTL8192CE" to "RTL8192CU" Taehee Yoo
2015-06-05 15:33 ` Larry Finger [this message]
2015-06-05 14:01 ` [PATCH 3/3] rtlwifi: rtl8192cu: Fix variable isfirst_ampdu Taehee Yoo
2015-06-05 15:31 ` Larry Finger
2015-06-05 15:37 ` [PATCH 1/3] rtlwifi: rtl8192cu: remove duplicated routine in _rtl92c_phy_rf6052_config_parafile Larry Finger
2015-06-06 4:57 ` Taehee Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5571C140.6000504@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=ap420073@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).