linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: Add netdev name to  NL80211_CMD_STOP_AP event?
Date: Wed, 10 Jun 2015 14:43:44 -0700	[thread overview]
Message-ID: <5578AF90.5030609@candelatech.com> (raw)
In-Reply-To: <1433972365.3145.18.camel@sipsolutions.net>

On 06/10/2015 02:39 PM, Johannes Berg wrote:
> On Wed, 2015-06-10 at 14:20 -0700, Ben Greear wrote:
>> While trying to make 'iw' able to print out something useful for
>> the 'stop_ap' event, I notice there is not really any human friendly
>> info in the message (just phy id (which may not match phy name), ifindex, and some other
>> wiphy related numeric ID.
>>
>> Any reason not to add the netdev name (NL80211_ATTR_IFNAME) to this and
>> related messages?
> 
> We're not really adding that *anywhere*, and you can trivially look it
> up based on the ifindex, so why bother?

I was thinking netdevice might go away before user-space can decode the
message ( I was assuming that on delete you would stop and very shortly
after that delete the netdev).

It's a small patch to iw and the kernel as far as I can tell...when I
get it working, I'll post for consideration..if you don't want it,
I won't complain :)

Thanks,
Ben

> 
> johannes
> 


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


  reply	other threads:[~2015-06-10 21:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-10 21:20 Add netdev name to NL80211_CMD_STOP_AP event? Ben Greear
2015-06-10 21:39 ` Johannes Berg
2015-06-10 21:43   ` Ben Greear [this message]
2015-06-10 21:49     ` Johannes Berg
2015-06-10 21:52       ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5578AF90.5030609@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).