Add netdev name to NL80211_CMD_STOP_AP event?

Add netdev name to NL80211_CMD_STOP_AP event?

[Ben Greear]

While trying to make 'iw' able to print out something useful for
the 'stop_ap' event, I notice there is not really any human friendly
info in the message (just phy id (which may not match phy name), ifindex, and some other
wiphy related numeric ID.

Any reason not to add the netdev name (NL80211_ATTR_IFNAME) to this and
related messages?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

Re: Add netdev name to NL80211_CMD_STOP_AP event?

[Johannes Berg]

On Wed, 2015-06-10 at 14:20 -0700, Ben Greear wrote:
> While trying to make 'iw' able to print out something useful for
> the 'stop_ap' event, I notice there is not really any human friendly
> info in the message (just phy id (which may not match phy name), ifindex, and some other
> wiphy related numeric ID.
> 
> Any reason not to add the netdev name (NL80211_ATTR_IFNAME) to this and
> related messages?

We're not really adding that *anywhere*, and you can trivially look it
up based on the ifindex, so why bother?

johannes

Re: Add netdev name to NL80211_CMD_STOP_AP event?

[Ben Greear]

On 06/10/2015 02:39 PM, Johannes Berg wrote:
> On Wed, 2015-06-10 at 14:20 -0700, Ben Greear wrote:
>> While trying to make 'iw' able to print out something useful for
>> the 'stop_ap' event, I notice there is not really any human friendly
>> info in the message (just phy id (which may not match phy name), ifindex, and some other
>> wiphy related numeric ID.
>>
>> Any reason not to add the netdev name (NL80211_ATTR_IFNAME) to this and
>> related messages?
> 
> We're not really adding that *anywhere*, and you can trivially look it
> up based on the ifindex, so why bother?

I was thinking netdevice might go away before user-space can decode the
message ( I was assuming that on delete you would stop and very shortly
after that delete the netdev).

It's a small patch to iw and the kernel as far as I can tell...when I
get it working, I'll post for consideration..if you don't want it,
I won't complain :)

Thanks,
Ben

> 
> johannes
> 


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

Re: Add netdev name to NL80211_CMD_STOP_AP event?

[Johannes Berg]

On Wed, 2015-06-10 at 14:43 -0700, Ben Greear wrote:

> I was thinking netdevice might go away before user-space can decode the
> message ( I was assuming that on delete you would stop and very shortly
> after that delete the netdev).

Yeah, but in that case ... does it matter? :)

> It's a small patch to iw and the kernel as far as I can tell...

It's small *now*, but if we add it to all events it'll end up pretty
big...

johannes

Re: Add netdev name to NL80211_CMD_STOP_AP event?

[Ben Greear]

On 06/10/2015 02:49 PM, Johannes Berg wrote:
> On Wed, 2015-06-10 at 14:43 -0700, Ben Greear wrote:
> 
>> I was thinking netdevice might go away before user-space can decode the
>> message ( I was assuming that on delete you would stop and very shortly
>> after that delete the netdev).
> 
> Yeah, but in that case ... does it matter? :)

iw will probably print stack garbage, but that would be fixed
easily enough w/out the kernel patch.

>> It's a small patch to iw and the kernel as far as I can tell...
> 
> It's small *now*, but if we add it to all events it'll end up pretty
> big...

I'll stick with just the stop_ap cmd for now.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com