From: Larry Finger <Larry.Finger@lwfinger.net>
To: Nicholas Mc Guire <hofrat@osadl.org>
Cc: Chaoming Li <chaoming_li@realsil.com.cn>,
Kalle Valo <kvalo@codeaurora.org>,
"John W. Linville" <linville@tuxdriver.com>,
Jiri Kosina <jkosina@suse.cz>,
Randy Dunlap <rdunlap@infradead.org>,
Masanari Iida <standby24x7@gmail.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [BUG ?] rtlwifi: rtl8723be: condition with no effect
Date: Sun, 14 Jun 2015 10:17:29 -0500 [thread overview]
Message-ID: <557D9B09.7020100@lwfinger.net> (raw)
In-Reply-To: <1434192211-5855-1-git-send-email-hofrat@osadl.org>
On 06/13/2015 05:43 AM, Nicholas Mc Guire wrote:
> From: Nicholas Mc Guire <hofrat@osadl.org>
>
> scanning for trivial bug-patters with coccinelle spatches returned:
> ./drivers/net/wireless/rtlwifi/rtl8723be/dm.c:886
> WARNING: condition with no effect (if branch == else)
>
> Added in 'commit a619d1abe20c ("rtlwifi: rtl8723be: Add new driver")'
>
> drivers/net/wireless/rtlwifi/rtl8723be/dm.c - line numbers from 4.1-rc7
> 886 if (thermalvalue > rtlefuse->eeprom_thermalmeter)
> 887 rtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,
> 888 index_for_channel);
> 889 else
> 890 rtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,
> 891 index_for_channel);
>
> Can't figure out what the intent of this condition is but it currently has
> no effect as if == else and this most likely is not the intent.
I do not know what the correct code should be here, but I will contact the
Realtek engineers and get their interpretation. In the meantime, please do not
change this code.
Thanks,
Larry
next prev parent reply other threads:[~2015-06-14 15:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-13 10:43 [BUG ?] rtlwifi: rtl8723be: condition with no effect Nicholas Mc Guire
2015-06-14 15:17 ` Larry Finger [this message]
2015-06-14 15:46 ` Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557D9B09.7020100@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=hofrat@osadl.org \
--cc=jkosina@suse.cz \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=standby24x7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).