From: Larry Finger <Larry.Finger@lwfinger.net>
To: Kalle Valo <kvalo@codeaurora.org>, Taehee Yoo <ap420073@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [V2] rtlwifi: rtl8192c: Add init codes for "fw_version" and"fw_subversion".
Date: Mon, 15 Jun 2015 10:50:23 -0500 [thread overview]
Message-ID: <557EF43F.4030309@lwfinger.net> (raw)
In-Reply-To: <87lhfl9mj4.fsf@kamboji.qca.qualcomm.com>
On 06/15/2015 07:35 AM, Kalle Valo wrote:
> Kalle Valo <kvalo@codeaurora.org> writes:
>
>>> The variable "fw_version" is used in the _ResetDigitalProcedure1().
>>> but It is not initialized. so I add init codes for "fw_version" and
>>> "fw_subversion".
>>>
>>> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
>>> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
>>
>> Thanks, applied to wireless-drivers-next.git.
>
> This patch adds a new sparse warning. Please send a new patch to fix
> this.
>
>>> drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c:242:36: sparse: incorrect type in assignment (different base types)
> drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c:242:36: expected unsigned short [unsigned] [usertype] fw_version
> drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c:242:36: got restricted __le16 [usertype] version
Sorry, I missed that when I reviewed the patch.
Larry
prev parent reply other threads:[~2015-06-15 15:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-07 13:33 [PATCH V2] rtlwifi: rtl8192c: Add init codes for "fw_version" and "fw_subversion" Taehee Yoo
2015-06-07 15:05 ` Larry Finger
2015-06-07 15:18 ` Taehee Yoo
2015-06-07 16:23 ` Larry Finger
2015-06-15 9:38 ` [V2] rtlwifi: rtl8192c: Add init codes for "fw_version" and"fw_subversion" Kalle Valo
2015-06-15 12:35 ` Kalle Valo
2015-06-15 15:50 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557EF43F.4030309@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=ap420073@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).