* [PATCH py80211] py80211: scan: fix call to _add_scan_attrs() in the sched_scan_start class
@ 2015-06-16 7:32 Luca Coelho
2015-06-19 8:07 ` Arend van Spriel
0 siblings, 1 reply; 2+ messages in thread
From: Luca Coelho @ 2015-06-16 7:32 UTC (permalink / raw)
To: aspriel; +Cc: linux-wireless
From: Luciano Coelho <luciano.coelho@intel.com>
We should not pass self explicitly when calling the superclass's
_add_scan_attrs() in the sched_scan_start class. Fix it.
Signed-off-by: Luciano Coelho <luciano.coelho@intel.com>
---
lib/scan.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/scan.py b/lib/scan.py
index 32cb68b..3ce242e 100644
--- a/lib/scan.py
+++ b/lib/scan.py
@@ -191,7 +191,7 @@ class sched_scan_start(scan_start_base):
self._matches = None
def _add_scan_attrs(self):
- super(sched_scan_start, self)._add_scan_attrs(self)
+ super(sched_scan_start, self)._add_scan_attrs()
if self._interval != None:
nl.nla_put_u32(self._nl_msg._msg, nl80211.ATTR_SCHED_SCAN_INTERVAL, self._interval)
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH py80211] py80211: scan: fix call to _add_scan_attrs() in the sched_scan_start class
2015-06-16 7:32 [PATCH py80211] py80211: scan: fix call to _add_scan_attrs() in the sched_scan_start class Luca Coelho
@ 2015-06-19 8:07 ` Arend van Spriel
0 siblings, 0 replies; 2+ messages in thread
From: Arend van Spriel @ 2015-06-19 8:07 UTC (permalink / raw)
To: Luca Coelho; +Cc: aspriel, linux-wireless
On 06/16/15 09:32, Luca Coelho wrote:
> From: Luciano Coelho<luciano.coelho@intel.com>
>
> We should not pass self explicitly when calling the superclass's
> _add_scan_attrs() in the sched_scan_start class. Fix it.
Sloppy maintainer at work ;-) My python knowledge need a refresh. I like
the super() concept, but did not do the training yet. :-)
Thanks for the fix. Applied to py80211 master branch.
Regards,
Arend
> Signed-off-by: Luciano Coelho<luciano.coelho@intel.com>
> ---
> lib/scan.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/scan.py b/lib/scan.py
> index 32cb68b..3ce242e 100644
> --- a/lib/scan.py
> +++ b/lib/scan.py
> @@ -191,7 +191,7 @@ class sched_scan_start(scan_start_base):
> self._matches = None
>
> def _add_scan_attrs(self):
> - super(sched_scan_start, self)._add_scan_attrs(self)
> + super(sched_scan_start, self)._add_scan_attrs()
> if self._interval != None:
> nl.nla_put_u32(self._nl_msg._msg, nl80211.ATTR_SCHED_SCAN_INTERVAL, self._interval)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-19 8:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-16 7:32 [PATCH py80211] py80211: scan: fix call to _add_scan_attrs() in the sched_scan_start class Luca Coelho
2015-06-19 8:07 ` Arend van Spriel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).