From: Larry Finger <Larry.Finger@lwfinger.net>
To: Nik Nyby <nikolas@gnu.org>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org
Subject: Re: [PATCH] b43: Fix typo in function name
Date: Mon, 29 Jun 2015 20:29:24 -0500 [thread overview]
Message-ID: <5591F0F4.3010008@lwfinger.net> (raw)
In-Reply-To: <1435625147-23535-1-git-send-email-nikolas@gnu.org>
On 06/29/2015 07:45 PM, Nik Nyby wrote:
> This fixes a typo in the "b43_lo_g_maintenance_work" function
> name.
>
> Signed-off-by: Nik Nyby <nikolas@gnu.org>
> ---
> drivers/net/wireless/b43/lo.c | 4 ++--
> drivers/net/wireless/b43/lo.h | 2 +-
> drivers/net/wireless/b43/phy_g.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
This patch is OK; however, can there really be a typo in a function name? How do
you ever know that the author did not mean to use a name that looks like a typo?
Please be careful with these.
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry
>
> diff --git a/drivers/net/wireless/b43/lo.c b/drivers/net/wireless/b43/lo.c
> index 916123a..a335f94 100644
> --- a/drivers/net/wireless/b43/lo.c
> +++ b/drivers/net/wireless/b43/lo.c
> @@ -929,8 +929,8 @@ void b43_lo_g_adjust_to(struct b43_wldev *dev,
> b43_lo_write(dev, &cal->ctl);
> }
>
> -/* Periodic LO maintanance work */
> -void b43_lo_g_maintanance_work(struct b43_wldev *dev)
> +/* Periodic LO maintenance work */
> +void b43_lo_g_maintenance_work(struct b43_wldev *dev)
> {
> struct b43_phy *phy = &dev->phy;
> struct b43_phy_g *gphy = phy->g;
> diff --git a/drivers/net/wireless/b43/lo.h b/drivers/net/wireless/b43/lo.h
> index 3b27e20..7b4df38 100644
> --- a/drivers/net/wireless/b43/lo.h
> +++ b/drivers/net/wireless/b43/lo.h
> @@ -80,7 +80,7 @@ void b43_lo_g_adjust_to(struct b43_wldev *dev,
>
> void b43_gphy_dc_lt_init(struct b43_wldev *dev, bool update_all);
>
> -void b43_lo_g_maintanance_work(struct b43_wldev *dev);
> +void b43_lo_g_maintenance_work(struct b43_wldev *dev);
> void b43_lo_g_cleanup(struct b43_wldev *dev);
> void b43_lo_g_init(struct b43_wldev *dev);
>
> diff --git a/drivers/net/wireless/b43/phy_g.c b/drivers/net/wireless/b43/phy_g.c
> index 727ce6e..462310e 100644
> --- a/drivers/net/wireless/b43/phy_g.c
> +++ b/drivers/net/wireless/b43/phy_g.c
> @@ -3004,7 +3004,7 @@ static void b43_gphy_op_pwork_15sec(struct b43_wldev *dev)
> phy->rev == 1) {
> //TODO: implement rev1 workaround
> }
> - b43_lo_g_maintanance_work(dev);
> + b43_lo_g_maintenance_work(dev);
> b43_mac_enable(dev);
> }
>
>
next prev parent reply other threads:[~2015-06-30 1:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 0:45 [PATCH] b43: Fix typo in function name Nik Nyby
2015-06-30 1:29 ` Larry Finger [this message]
2015-06-30 15:15 ` Michael Büsch
2015-07-21 13:53 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5591F0F4.3010008@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nikolas@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).