* linux-4.2-rc1/drivers/staging/wilc1000/linux_wlan.c:1874: bad test ?
@ 2015-07-07 11:19 David Binderman
2015-07-07 17:22 ` Randy Dunlap
2015-07-08 0:56 ` Kim, Johnny
0 siblings, 2 replies; 3+ messages in thread
From: David Binderman @ 2015-07-07 11:19 UTC (permalink / raw)
To: Johnny Kim, Rachel Kim, dean.lee@atmel.com, Chris Park,
linux-wireless@vger.kernel.org
Hello there,
[linux-4.2-rc1/drivers/staging/wilc1000/linux_wlan.c:1874]: (style) A pointer can not be negative so it is either pointless or an error to check if it is.
Source code is
if (wilc_mac_thread < 0) {
but
struct task_struct *wilc_mac_thread;
Regards
David Binderman
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: linux-4.2-rc1/drivers/staging/wilc1000/linux_wlan.c:1874: bad test ?
2015-07-07 11:19 linux-4.2-rc1/drivers/staging/wilc1000/linux_wlan.c:1874: bad test ? David Binderman
@ 2015-07-07 17:22 ` Randy Dunlap
2015-07-08 0:56 ` Kim, Johnny
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2015-07-07 17:22 UTC (permalink / raw)
To: David Binderman, Johnny Kim, Rachel Kim, dean.lee@atmel.com,
Chris Park, linux-wireless@vger.kernel.org
On 07/07/15 04:19, David Binderman wrote:
> Hello there,
>
> [linux-4.2-rc1/drivers/staging/wilc1000/linux_wlan.c:1874]: (style) A pointer can not be negative so it is either pointless or an error to check if it is.
>
> Source code is
>
> if (wilc_mac_thread < 0) {
>
> but
>
> struct task_struct *wilc_mac_thread;
#include <linux/err.h>
if (IS_ERR(wilc_mac_thread)) {
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: linux-4.2-rc1/drivers/staging/wilc1000/linux_wlan.c:1874: bad test ?
2015-07-07 11:19 linux-4.2-rc1/drivers/staging/wilc1000/linux_wlan.c:1874: bad test ? David Binderman
2015-07-07 17:22 ` Randy Dunlap
@ 2015-07-08 0:56 ` Kim, Johnny
1 sibling, 0 replies; 3+ messages in thread
From: Kim, Johnny @ 2015-07-08 0:56 UTC (permalink / raw)
To: 'David Binderman', Kim, Rachel, Lee, Dean, Park, Chris,
linux-wireless@vger.kernel.org
Hello David.
Thanks for your detail review.
The code is wrong and will be removed because of unused code later.
Regards.
Johnny.
-----Original Message-----
From: David Binderman [mailto:dcb314@hotmail.com]
Sent: Tuesday, July 07, 2015 8:19 PM
To: Kim, Johnny; Kim, Rachel; Lee, Dean; Park, Chris; linux-wireless@vger.kernel.org
Subject: linux-4.2-rc1/drivers/staging/wilc1000/linux_wlan.c:1874: bad test ?
Hello there,
[linux-4.2-rc1/drivers/staging/wilc1000/linux_wlan.c:1874]: (style) A pointer can not be negative so it is either pointless or an error to check if it is.
Source code is
if (wilc_mac_thread < 0) {
but
struct task_struct *wilc_mac_thread;
Regards
David Binderman
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-08 0:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-07 11:19 linux-4.2-rc1/drivers/staging/wilc1000/linux_wlan.c:1874: bad test ? David Binderman
2015-07-07 17:22 ` Randy Dunlap
2015-07-08 0:56 ` Kim, Johnny
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).