From: Mike Looijmans <mike.looijmans@topic.nl>
To: <linux-wireless@vger.kernel.org>
Cc: <khoroshilov@ispras.ru>, <kvalo@codeaurora.org>
Subject: Commit "rsi: fix memory leak in rsi_load_ta_instructions()" breaks things
Date: Fri, 24 Jul 2015 09:01:31 +0200 [thread overview]
Message-ID: <55B1E2CB.3040908@topic.nl> (raw)
Regarding this commit:
https://lkml.org/lkml/2014/12/12/709
rsi: fix memory leak in rsi_load_ta_instructions()
Memory allocated by kmemdup() in rsi_load_ta_instructions() is leaked.
But duplication of firmware data here is useless,
so the patch removes kmemdup() at all.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
We use this driver for the Redpine Wifi chip on our "florida" board, and after
this commit it stopped working. Symptom was that the "wlan0" device was not
created at all. Reverting the commit makes it work again.
Apparently, the kmemdup action is needed for something. I suspect the DMA
controller is still copying the firmware data before the method returned.
Having no experience with this part of the kernel, I wasn't able to come up
with a more constructive solution than just reverting the patch.
Kind regards,
Mike Looijmans.
Kind regards,
Mike Looijmans
System Expert
TOPIC Embedded Products
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
Telefax: +31 (0) 499 33 69 70
E-mail: mike.looijmans@topicproducts.com
Website: www.topicproducts.com
Please consider the environment before printing this e-mail
next reply other threads:[~2015-07-24 7:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 7:01 Mike Looijmans [this message]
2015-07-24 8:02 ` Commit "rsi: fix memory leak in rsi_load_ta_instructions()" breaks things Kalle Valo
2015-07-24 8:39 ` Alexey Khoroshilov
2015-07-24 11:02 ` Mike Looijmans
2015-07-24 11:35 ` Alexey Khoroshilov
2015-07-24 13:42 ` Mike Looijmans
2015-07-24 14:12 ` Kalle Valo
2015-07-24 16:26 ` Alexey Khoroshilov
2015-07-24 16:59 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B1E2CB.3040908@topic.nl \
--to=mike.looijmans@topic.nl \
--cc=khoroshilov@ispras.ru \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).