Re: Commit "rsi: fix memory leak in rsi_load_ta_instructions()" breaks things

[Alexey Khoroshilov <khoroshilov@ispras.ru>]

Dear Mike,

On 24.07.2015 14:01, Mike Looijmans wrote:
> Regarding this commit:
> 
> https://lkml.org/lkml/2014/12/12/709
> 
>     rsi: fix memory leak in rsi_load_ta_instructions()
> 
>     Memory allocated by kmemdup() in rsi_load_ta_instructions() is leaked.
>     But duplication of firmware data here is useless,
>     so the patch removes kmemdup() at all.
> 
>     Found by Linux Driver Verification project (linuxtesting.org).
> 
>     Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
>     Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
> 
> We use this driver for the Redpine Wifi chip on our "florida" board, and
> after this commit it stopped working. Symptom was that the "wlan0"
> device was not created at all. Reverting the commit makes it work again.
> 
> Apparently, the kmemdup action is needed for something. I suspect the
> DMA controller is still copying the firmware data before the method
> returned.

To test your hypothesis, could you please check if it is still broken
with kfree(fw); added just after release_firmware(fw_entry); in
rsi_load_ta_instructions().

--
Thanks,
Alexey