Re: [PATCH] b43: fix extpa_gain check for 2GHz

[Hauke Mehrtens <hauke@hauke-m.de>]

On 07/30/2015 08:54 AM, Rafał Miłecki wrote:
> On 30 July 2015 at 07:40, Kalle Valo <kvalo@codeaurora.org> wrote:
>> Hauke Mehrtens <hauke@hauke-m.de> writes:
>>
>>> On the 2GHz and and on the 5GHZ band only the extpa_gain setting from
>>> the 5GHz band was checked. this patch makes it check the property from
>>> the correct band.
>>>
>>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
>>
>> Is this a regression? If yes, please add a Fixes line.
>>
>> Should this go to 4.2?
> 
> Not a regression. It's like this for a loooong time.
> 
> AFAIK PCI(e) cards don't have external power amplifier, so this code
> is most likely used for some fancy SoCs only. There are 3 known SoCs
> with N-PHY rev 5 or 6: BCM4717A1, BCM4718A1 & BCM4716B0.
> 
> So we may consider taking it for 4.2 without any "Fixes: " line but I
> wouldn't care too much about Cc-ing stable.
> 
> Hauke: do you agree?
> 
Yes, I do not have a device I know of which is affected by this error, I
just saw this while looking at code close by. Just put this into the
next Linux version and not to stable.

Hauke