From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-gw1-out.broadcom.com ([216.31.210.62]:19012 "EHLO mail-gw1-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751992AbbHSU4D (ORCPT ); Wed, 19 Aug 2015 16:56:03 -0400 Message-ID: <55D4ED5E.8080504@broadcom.com> (sfid-20150819_225609_826991_728F38D3) Date: Wed, 19 Aug 2015 22:55:58 +0200 From: Arend van Spriel MIME-Version: 1.0 To: Kalle Valo CC: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , linux-wireless , Hante Meuleman Subject: Re: [PATCH V2 1/7] brcmfmac: Add support for host platform NVRAM loading. References: <1439708139-7527-1-git-send-email-arend@broadcom.com> <1439708139-7527-2-git-send-email-arend@broadcom.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 08/19/2015 06:38 PM, Rafał Miłecki wrote: > On 16 August 2015 at 08:55, Arend van Spriel wrote: >> From: Hante Meuleman >> >> Host platforms such as routers supported by OpenWRT can >> support NVRAM reading directly from internal NVRAM store. >> With this patch the nvram load routines will fall back to >> this method when there is no nvram file and support is >> available in the kernel. >> >> Cc: Rafał Miłecki >> Reviewed-by: Arend Van Spriel >> Reviewed-by: Franky (Zhenhui) Lin >> Reviewed-by: Pieter-Paul Giesberts >> Reviewed-by: Daniel (Deognyoun) Kim >> Signed-off-by: Hante Meuleman >> Signed-off-by: Arend van Spriel >> --- >> V2: >> - addressed comments from Rafał. > > Well, you dropped unneeded change to the brcmf_nvram_handle_value > function, but you ignored the rest of my comments. Take a look at them > again please: > https://patchwork.kernel.org/patch/6767961/ Kalle, Can you remove this patch from the series and apply the rest. Just verified over here the remaining patches apply cleanly on wireless-drivers-next. Regards, Arend