From: Arend van Spriel <arend@broadcom.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
"Hante Meuleman" <meuleman@broadcom.com>
Subject: Re: [PATCH V2 1/7] brcmfmac: Add support for host platform NVRAM loading.
Date: Thu, 20 Aug 2015 21:50:41 +0200 [thread overview]
Message-ID: <55D62F91.8080501@broadcom.com> (raw)
In-Reply-To: <55D4ED5E.8080504@broadcom.com>
On 08/19/2015 10:55 PM, Arend van Spriel wrote:
> On 08/19/2015 06:38 PM, Rafał Miłecki wrote:
>> On 16 August 2015 at 08:55, Arend van Spriel <arend@broadcom.com> wrote:
>>> From: Hante Meuleman <meuleman@broadcom.com>
>>>
>>> Host platforms such as routers supported by OpenWRT can
>>> support NVRAM reading directly from internal NVRAM store.
>>> With this patch the nvram load routines will fall back to
>>> this method when there is no nvram file and support is
>>> available in the kernel.
>>>
>>> Cc: Rafał Miłecki <zajec5@gmail.com>
>>> Reviewed-by: Arend Van Spriel <arend@broadcom.com>
>>> Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
>>> Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
>>> Reviewed-by: Daniel (Deognyoun) Kim <dekim@broadcom.com>
>>> Signed-off-by: Hante Meuleman <meuleman@broadcom.com>
>>> Signed-off-by: Arend van Spriel <arend@broadcom.com>
>>> ---
>>> V2:
>>> - addressed comments from Rafał.
>>
>> Well, you dropped unneeded change to the brcmf_nvram_handle_value
>> function, but you ignored the rest of my comments. Take a look at them
>> again please:
>> https://patchwork.kernel.org/patch/6767961/
>
> Kalle,
>
> Can you remove this patch from the series and apply the rest. Just
> verified over here the remaining patches apply cleanly on
> wireless-drivers-next.
Hi Kalle,
Just drop this series. I will send a V3 shortly.
Regards,
Arend
next prev parent reply other threads:[~2015-08-20 19:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-16 6:55 [PATCH V2 0/7] brcmfmac: nvram loading and code rework Arend van Spriel
2015-08-16 6:55 ` [PATCH V2 1/7] brcmfmac: Add support for host platform NVRAM loading Arend van Spriel
2015-08-19 16:38 ` Rafał Miłecki
2015-08-19 20:55 ` Arend van Spriel
2015-08-20 19:50 ` Arend van Spriel [this message]
2015-08-24 19:28 ` Kalle Valo
2015-08-16 6:55 ` [PATCH V2 2/7] brcmfmac: correct interface combination info Arend van Spriel
2015-08-19 21:49 ` Rafał Miłecki
2015-08-19 21:59 ` Arend van Spriel
2015-08-16 6:55 ` [PATCH V2 3/7] brcmfmac: Increase nr of supported flowrings Arend van Spriel
2015-08-19 21:56 ` Rafał Miłecki
2015-08-24 14:15 ` Arend van Spriel
2015-08-24 20:02 ` Rafał Miłecki
2015-08-29 8:13 ` Arend van Spriel
2015-08-29 9:38 ` Rafał Miłecki
2015-08-29 10:48 ` Arend van Spriel
2015-08-20 16:16 ` Rafał Miłecki
2015-08-20 16:39 ` Arend van Spriel
2015-08-16 6:55 ` [PATCH V2 4/7] brcmfmac: add debugfs entry for msgbuf statistics Arend van Spriel
2015-08-16 6:55 ` [PATCH V2 5/7] brcmfmac: make use of cfg80211_check_combinations() Arend van Spriel
2015-08-16 6:55 ` [PATCH V2 6/7] brcmfmac: block the correct flowring when backup queue overflow Arend van Spriel
2015-08-16 6:55 ` [PATCH V2 7/7] brcmfmac: bump highest event number for 4339 firmware Arend van Spriel
2015-08-16 15:10 ` [PATCH V2 0/7] brcmfmac: nvram loading and code rework Rafał Miłecki
2015-08-17 8:01 ` Arend van Spriel
2015-08-17 14:25 ` Rafał Miłecki
-- strict thread matches above, loose matches on Subject: below --
2015-07-10 18:31 [PATCH " Arend van Spriel
2015-07-10 18:31 ` [PATCH 1/7] brcmfmac: Add support for host platform NVRAM loading Arend van Spriel
2015-07-11 17:09 ` Rafał Miłecki
2015-08-19 21:21 ` [PATCH v2 " Arend van Spriel
2015-08-19 21:43 ` Arend van Spriel
2015-08-20 15:53 ` Rafał Miłecki
2015-08-20 16:06 ` Arend van Spriel
2015-08-20 16:21 ` Rafał Miłecki
2015-08-20 15:59 ` Rafał Miłecki
2015-08-20 16:14 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D62F91.8080501@broadcom.com \
--to=arend@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=meuleman@broadcom.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).