Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

[Larry Finger <Larry.Finger@lwfinger.net>]

On 09/06/2015 08:38 AM, Kalle Valo wrote:
> Hi,
>
> replying to an old thread first.
>
> Jes Sorensen <Jes.Sorensen@redhat.com> writes:
>
>> Kalle Valo <kvalo@codeaurora.org> writes:
>>> Jes.Sorensen@redhat.com writes:
>>>
>>>>   MAINTAINERS                          |    8 +
>>>>   drivers/net/wireless/Kconfig         |   19 +
>>>>   drivers/net/wireless/Makefile        |    2 +
>>>>   drivers/net/wireless/rtl8xxxu.c | 4500
>>>> ++++++++++++++++++++++++++++++++++
>>>>   drivers/net/wireless/rtl8xxxu.h      |  497 ++++
>>>>   drivers/net/wireless/rtl8xxxu_regs.h |  941 +++++++
>>>
>>> I think someone else already mentioned, but it would be better that has
>>> it's own directory. Or should this actually be under rtlwifi
>>> directory?
>>
>> I didn't see the need here - it's just 3 files, as long as it doesn't
>> have a huge hierachy of files, a new directory doesn't add much
>> value. If it becomes an issue later, we can move it into a
>> subdirectory.
>
> It's easier that the driver has it's on directory as everything
> (makefile, kconfig etc) is cleanly separated. And actually I would like
> to create a new vendor directory for realtek and have this in
> drivers/net/wireless/realtek/rtl8xxxu/. And later we could move rtlwifi
> under realtek directory as well.

I agree with the proposal for this driver to be under a separate directory. As 
this driver evolves to support more devices, it will likely be useful to split 
the current single .c file into a set of files, each containing the specific 
code needed for a given device. At that point, placing these files into a 
separate directory will be needed to keep the base drivers/net/wireless/ as 
clean as possible. We might as well do that now. I have no objections to moving 
rtlwifi under drivers/net/wireless/realtek/. We should even move rtl818x as well.

Larry