From: Tony Cho <tony.cho@atmel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: <devel@driverdev.osuosl.org>, <linux-wireless@vger.kernel.org>,
<johnny.kim@atmel.com>, <chris.park@atmel.com>,
<rachel.kim@atmel.com>, <glen.lee@atmel.com>, <leo.kim@atmel.com>,
<austin.shin@atmel.com>, <adel.noureldin@atmel.com>,
<adham.abozaeid@atmel.com>, <Nicolas.FERRE@atmel.com>
Subject: Re: [PATCH 1/4] staging: wilc1000: remove kmalloc wrapper
Date: Thu, 10 Sep 2015 10:41:33 +0900 [thread overview]
Message-ID: <55F0DFCD.509@atmel.com> (raw)
In-Reply-To: <20150909181712.GA30637@kroah.com>
On 2015년 09월 10일 03:17, Greg KH wrote:
> On Wed, Sep 09, 2015 at 04:08:10PM +0900, Tony Cho wrote:
>> From: Glen Lee <glen.lee@atmel.com>
>>
>> Call kmalloc directly. No need to wrap kmalloc.
>> Only one function, wilc_mq_send which use WILC_MALLOC, can be running in
>> interrupt context or process context. In this case, We call in_interrupt to
>> decide the flag, GFP_ATOMIC or GFP_KERNEL, for kmalloc properly. Additionally,
>> there is one kmalloc which flag is always GFP_ATOMIC. This also changed
>> together.
>> Others are not holding a spin lock or in interrupt context. So use GFP_KERNEL
>> flag for kmalloc.
>>
>> Signed-off-by: Glen Lee <glen.lee@atmel.com>
>> Signed-off-by: Tony Cho <tony.cho@atmel.com>
>> ---
>> drivers/staging/wilc1000/host_interface.c | 110 +++++++++++-----------
>> drivers/staging/wilc1000/linux_wlan.c | 2 +-
>> drivers/staging/wilc1000/wilc_msgqueue.c | 10 +-
>> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 38 ++++----
>> 4 files changed, 83 insertions(+), 77 deletions(-)
> This no longer applies to my staging-testing branch, can you rebase it
> and resend it and the other patches in this series?
>
> thanks,
>
> greg k-h
I will resend this patch with Kconfig with BROKEN removed.
Thanks,
Tony.
prev parent reply other threads:[~2015-09-10 1:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 7:08 [PATCH 1/4] staging: wilc1000: remove kmalloc wrapper Tony Cho
2015-09-09 7:08 ` [PATCH 2/4] staging: wilc1000: delete wilc_memory.c and wilc_memory.h Tony Cho
2015-09-09 7:08 ` [PATCH 3/4] staging: wilc1000: delete wilc_oswrapper.h and wilc_platform.h Tony Cho
2015-09-09 18:19 ` Greg KH
2015-09-10 2:08 ` Tony Cho
2015-09-10 5:07 ` Greg KH
2015-09-09 7:08 ` [PATCH 4/4] staging: wilc1000: remove unused PLAT_RK3026_TCHIP Tony Cho
2015-09-09 18:17 ` [PATCH 1/4] staging: wilc1000: remove kmalloc wrapper Greg KH
2015-09-10 1:41 ` Tony Cho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F0DFCD.509@atmel.com \
--to=tony.cho@atmel.com \
--cc=Nicolas.FERRE@atmel.com \
--cc=adel.noureldin@atmel.com \
--cc=adham.abozaeid@atmel.com \
--cc=austin.shin@atmel.com \
--cc=chris.park@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=glen.lee@atmel.com \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=leo.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).