From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from eusmtp01.atmel.com ([212.144.249.242]:19443 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752102AbbIJBlt (ORCPT ); Wed, 9 Sep 2015 21:41:49 -0400 Subject: Re: [PATCH 1/4] staging: wilc1000: remove kmalloc wrapper To: Greg KH References: <1441782493-11338-1-git-send-email-tony.cho@atmel.com> <20150909181712.GA30637@kroah.com> CC: , , , , , , , , , , From: Tony Cho Message-ID: <55F0DFCD.509@atmel.com> (sfid-20150910_034211_762168_8BA6EEB7) Date: Thu, 10 Sep 2015 10:41:33 +0900 MIME-Version: 1.0 In-Reply-To: <20150909181712.GA30637@kroah.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2015년 09월 10일 03:17, Greg KH wrote: > On Wed, Sep 09, 2015 at 04:08:10PM +0900, Tony Cho wrote: >> From: Glen Lee >> >> Call kmalloc directly. No need to wrap kmalloc. >> Only one function, wilc_mq_send which use WILC_MALLOC, can be running in >> interrupt context or process context. In this case, We call in_interrupt to >> decide the flag, GFP_ATOMIC or GFP_KERNEL, for kmalloc properly. Additionally, >> there is one kmalloc which flag is always GFP_ATOMIC. This also changed >> together. >> Others are not holding a spin lock or in interrupt context. So use GFP_KERNEL >> flag for kmalloc. >> >> Signed-off-by: Glen Lee >> Signed-off-by: Tony Cho >> --- >> drivers/staging/wilc1000/host_interface.c | 110 +++++++++++----------- >> drivers/staging/wilc1000/linux_wlan.c | 2 +- >> drivers/staging/wilc1000/wilc_msgqueue.c | 10 +- >> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 38 ++++---- >> 4 files changed, 83 insertions(+), 77 deletions(-) > This no longer applies to my staging-testing branch, can you rebase it > and resend it and the other patches in this series? > > thanks, > > greg k-h I will resend this patch with Kconfig with BROKEN removed. Thanks, Tony.