Re: [PATCH 3/4] staging: wilc1000: delete wilc_oswrapper.h and wilc_platform.h

[Tony Cho <tony.cho@atmel.com>]

Hi Greg,

I want to make sure one thing before moving further. Are you saying the errorsupport.h file as the os wrapper remaining in the oswrapper.h file?
If not, can you let me know what you point out as remaining os wrapper in the oswrapper.h file?
If yes, I have been already replacing all of error values defined in the errorsupport.h file so that I send you the next patch when done.

Thanks,
Tony.

On 2015년 09월 10일 03:19, Greg KH wrote:
> On Wed, Sep 09, 2015 at 04:08:12PM +0900, Tony Cho wrote:
>> From: Glen Lee <glen.lee@atmel.com>
>>
>> wilc1000 driver runs on Linux. No need to have oswrapper or platform
>> dependent files.
>> Before delete two header files, move two structures in wilc_platform.h to
>> wilc_msgqueue.h where it is used. Include linux header files where is needs
>> since wilc_platform is deleted.
>> Finally, remove wilc_oswrapper.h and wilc_platform.h.
> That's a lot of different things to be doing all in one patch.  Please
> break this up into individual patches.
>
> And you can't just delete the oswrapper.h file, you still have things in
> it, don't move it for no reason, get rid of those wrapper functions
> properly first, making the file empty, and then you can delete it.
> Moving them to a different .h file just hides the fact that this work
> still needs to be done.
>
> thanks,
>
> greg k-h