From: Tony Cho <tony.cho@atmel.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: <gregkh@linuxfoundation.org>, <devel@driverdev.osuosl.org>,
<rachel.kim@atmel.com>, <chris.park@atmel.com>,
<austin.shin@atmel.com>, <linux-wireless@vger.kernel.org>,
<johnny.kim@atmel.com>, <Nicolas.FERRE@atmel.com>,
<adel.noureldin@atmel.com>, <leo.kim@atmel.com>,
<adham.abozaeid@atmel.com>
Subject: Re: [PATCH 1/4] staging: wilc1000: remove unused variable g_num_total_switches
Date: Tue, 15 Sep 2015 17:26:35 +0900 [thread overview]
Message-ID: <55F7D63B.3040502@atmel.com> (raw)
In-Reply-To: <20150915071337.GH12611@sudip-pc>
On 2015년 09월 15일 16:13, Sudip Mukherjee wrote:
> On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote:
>> From: Glen Lee <glen.lee@atmel.com>
>>
>> g_num_total_switches is never used so just delete it.
>>
>> Signed-off-by: Glen Lee <glen.lee@atmel.com>
>> Signed-off-by: Tony Cho <tony.cho@atmel.com>
>> ---
> you only deleted from the .h file but it still remains in
> coreconfigurator.c
>
> regards
> sudip
The variable was removed in previous patch (staging: wilc1000: remove unused variables) and the patch was sent
but it's not accepted yet. So, you can find the variable still in c file.
Thanks for your advice,
Tony.
next prev parent reply other threads:[~2015-09-15 8:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 5:33 [PATCH 1/4] staging: wilc1000: remove unused variable g_num_total_switches Tony Cho
2015-09-15 5:33 ` [PATCH 2/4] staging: wilc1000: delete function declaration SendRawPacket Tony Cho
2015-09-15 7:16 ` Sudip Mukherjee
2015-09-15 5:33 ` [PATCH 3/4] staging: wilc1000: coreconfigurator.h: remove unused defines Tony Cho
2015-09-15 5:33 ` [PATCH 4/4] staging: wilc1000: remove unused variable g_flushing_in_progress Tony Cho
2015-09-15 7:13 ` [PATCH 1/4] staging: wilc1000: remove unused variable g_num_total_switches Sudip Mukherjee
2015-09-15 8:26 ` Tony Cho [this message]
2015-09-15 13:46 ` Greg KH
2015-09-15 14:06 ` Sudip Mukherjee
2015-09-16 1:21 ` Tony Cho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F7D63B.3040502@atmel.com \
--to=tony.cho@atmel.com \
--cc=Nicolas.FERRE@atmel.com \
--cc=adel.noureldin@atmel.com \
--cc=adham.abozaeid@atmel.com \
--cc=austin.shin@atmel.com \
--cc=chris.park@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=leo.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).