[PATCH 1/4] staging: wilc1000: remove unused variable g_num_total_switches

[PATCH 1/4] staging: wilc1000: remove unused variable g_num_total_switches

[Tony Cho]

From: Glen Lee <glen.lee@atmel.com>

g_num_total_switches is never used so just delete it.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
---
 drivers/staging/wilc1000/coreconfigurator.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging/wilc1000/coreconfigurator.h
index 3af1935..d2a0a0b 100644
--- a/drivers/staging/wilc1000/coreconfigurator.h
+++ b/drivers/staging/wilc1000/coreconfigurator.h
@@ -29,8 +29,6 @@
 #define NUM_11N_HUT_SWITCHES    0
 #endif /* MAC_802_11N */
 
-extern u16 g_num_total_switches;
-
 #define MAC_HDR_LEN             24          /* No Address4 - non-ESS         */
 #define MAX_SSID_LEN            33
 #define FCS_LEN                 4
-- 
1.9.1

[PATCH 2/4] staging: wilc1000: delete function declaration SendRawPacket

[Tony Cho]

From: Glen Lee <glen.lee@atmel.com>

SendRawpacket is declared but not implemented. It is not used also.
So just delete it.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
---
 drivers/staging/wilc1000/coreconfigurator.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging/wilc1000/coreconfigurator.h
index d2a0a0b..c2aee05 100644
--- a/drivers/staging/wilc1000/coreconfigurator.h
+++ b/drivers/staging/wilc1000/coreconfigurator.h
@@ -180,7 +180,6 @@ s32 ParseSurveyResults(u8 ppu8RcvdSiteSurveyResults[][MAX_SURVEY_RESULT_FRAG_SIZ
 s32 DeallocateSurveyResults(wid_site_survey_reslts_s *pstrSurveyResults);
 #endif
 
-s32 SendRawPacket(s8 *pspacket, s32 s32PacketLen);
 void NetworkInfoReceived(u8 *pu8Buffer, u32 u32Length);
 void GnrlAsyncInfoReceived(u8 *pu8Buffer, u32 u32Length);
 void host_int_ScanCompleteReceived(u8 *pu8Buffer, u32 u32Length);
-- 
1.9.1

Re: [PATCH 2/4] staging: wilc1000: delete function declaration SendRawPacket

[Sudip Mukherjee]

On Tue, Sep 15, 2015 at 02:33:55PM +0900, Tony Cho wrote:
> From: Glen Lee <glen.lee@atmel.com>
> 
> SendRawpacket is declared but not implemented. It is not used also.
> So just delete it.
> 
> Signed-off-by: Glen Lee <glen.lee@atmel.com>
> Signed-off-by: Tony Cho <tony.cho@atmel.com>
> ---
Still remains in coreconfigurator.c

regards
sudip

[PATCH 3/4] staging: wilc1000: coreconfigurator.h: remove unused defines

[Tony Cho]

From: Glen Lee <glen.lee@atmel.com>

The define MAX_PACKET_BUFF_SIZE and STATUS_MSG_LEN is not used in the driver.
Delete two defines.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
---
 drivers/staging/wilc1000/coreconfigurator.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging/wilc1000/coreconfigurator.h
index c2aee05..32e5b31 100644
--- a/drivers/staging/wilc1000/coreconfigurator.h
+++ b/drivers/staging/wilc1000/coreconfigurator.h
@@ -44,14 +44,11 @@
 /* Operating Mode: GET */
 #define GET_CFG              1
 
-#define MAX_PACKET_BUFF_SIZE 1596
-
 #define MAX_STRING_LEN               256
 #define MAX_SURVEY_RESULT_FRAG_SIZE  MAX_STRING_LEN
 #define SURVEY_RESULT_LENGTH         44
 #define MAX_ASSOC_RESP_FRAME_SIZE    MAX_STRING_LEN
 
-#define STATUS_MSG_LEN               12
 #define MAC_CONNECTED                1
 #define MAC_DISCONNECTED             0
 
-- 
1.9.1

[PATCH 4/4] staging: wilc1000: remove unused variable g_flushing_in_progress

[Tony Cho]

From: Glen Lee <glen.lee@atmel.com>

g_flushing_in_progress is never used so just delete it.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
---
 drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
index 8cdd1d5..4fdb980 100644
--- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
+++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
@@ -132,7 +132,6 @@ struct wilc_wfi_key g_key_gtk_params;
 struct add_key_params g_add_ptk_key_params;
 struct wilc_wfi_key g_key_ptk_params;
 struct wilc_wfi_wep_key g_key_wep_params;
-u8 g_flushing_in_progress;
 bool g_ptk_keys_saved;
 bool g_gtk_keys_saved;
 bool g_wep_keys_saved;
-- 
1.9.1

Re: [PATCH 1/4] staging: wilc1000: remove unused variable g_num_total_switches

[Sudip Mukherjee]

On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote:
> From: Glen Lee <glen.lee@atmel.com>
> 
> g_num_total_switches is never used so just delete it.
> 
> Signed-off-by: Glen Lee <glen.lee@atmel.com>
> Signed-off-by: Tony Cho <tony.cho@atmel.com>
> ---
you only deleted from the .h file but it still remains in
coreconfigurator.c

regards
sudip

Re: [PATCH 1/4] staging: wilc1000: remove unused variable g_num_total_switches

[Tony Cho]

On 2015년 09월 15일 16:13, Sudip Mukherjee wrote:
> On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote:
>> From: Glen Lee <glen.lee@atmel.com>
>>
>> g_num_total_switches is never used so just delete it.
>>
>> Signed-off-by: Glen Lee <glen.lee@atmel.com>
>> Signed-off-by: Tony Cho <tony.cho@atmel.com>
>> ---
> you only deleted from the .h file but it still remains in
> coreconfigurator.c
>
> regards
> sudip

The variable was removed in previous patch (staging: wilc1000: remove unused variables) and the patch was sent
but it's not accepted yet. So, you can find the variable still in c file.

Thanks for your advice,
Tony.

Re: [PATCH 1/4] staging: wilc1000: remove unused variable g_num_total_switches

[Greg KH]

On Tue, Sep 15, 2015 at 05:26:35PM +0900, Tony Cho wrote:
> 
> 
> On 2015년 09월 15일 16:13, Sudip Mukherjee wrote:
> >On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote:
> >>From: Glen Lee <glen.lee@atmel.com>
> >>
> >>g_num_total_switches is never used so just delete it.
> >>
> >>Signed-off-by: Glen Lee <glen.lee@atmel.com>
> >>Signed-off-by: Tony Cho <tony.cho@atmel.com>
> >>---
> >you only deleted from the .h file but it still remains in
> >coreconfigurator.c
> >
> >regards
> >sudip
> 
> The variable was removed in previous patch (staging: wilc1000: remove unused variables) and the patch was sent
> but it's not accepted yet. So, you can find the variable still in c file.

I don't see that patch here in my queue :(

Please resend all of your outstanding patches, I think we are out of
sync somehow.

thanks,

greg k-h

Re: [PATCH 1/4] staging: wilc1000: remove unused variable g_num_total_switches

[Sudip Mukherjee]

On Tue, Sep 15, 2015 at 06:46:25AM -0700, Greg KH wrote:
> On Tue, Sep 15, 2015 at 05:26:35PM +0900, Tony Cho wrote:
> > 
> > 
> > On 2015년 09월 15일 16:13, Sudip Mukherjee wrote:
> > >On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote:
> > >>From: Glen Lee <glen.lee@atmel.com>
> > >>
> > >>g_num_total_switches is never used so just delete it.
> > >>
> > >>Signed-off-by: Glen Lee <glen.lee@atmel.com>
> > >>Signed-off-by: Tony Cho <tony.cho@atmel.com>
> > >>---
> > >you only deleted from the .h file but it still remains in
> > >coreconfigurator.c
> > >
> > >regards
> > >sudip
> > 
> > The variable was removed in previous patch (staging: wilc1000: remove unused variables) and the patch was sent
> > but it's not accepted yet. So, you can find the variable still in c file.
> 
> I don't see that patch here in my queue :(
> 
> Please resend all of your outstanding patches, I think we are out of
> sync somehow.
This was the series of 7 patches and the first patch was
"remove PANDA_BOARD".
And the series is indeed not applied.

patch 7/7 was removing g_num_total_switches from the .c file, while
resending please modify and remove it from the .h file also.

And when your patch depends on some previous unapplied patch it will be
better if you can mention that in the comments.

regards
sudip

Re: [PATCH 1/4] staging: wilc1000: remove unused variable g_num_total_switches

[Tony Cho]

On 2015년 09월 15일 22:46, Greg KH wrote:
> On Tue, Sep 15, 2015 at 05:26:35PM +0900, Tony Cho wrote:
>>
>> On 2015년 09월 15일 16:13, Sudip Mukherjee wrote:
>>> On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote:
>>>> From: Glen Lee <glen.lee@atmel.com>
>>>>
>>>> g_num_total_switches is never used so just delete it.
>>>>
>>>> Signed-off-by: Glen Lee <glen.lee@atmel.com>
>>>> Signed-off-by: Tony Cho <tony.cho@atmel.com>
>>>> ---
>>> you only deleted from the .h file but it still remains in
>>> coreconfigurator.c
>>>
>>> regards
>>> sudip
>> The variable was removed in previous patch (staging: wilc1000: remove unused variables) and the patch was sent
>> but it's not accepted yet. So, you can find the variable still in c file.
> I don't see that patch here in my queue :(
>
> Please resend all of your outstanding patches, I think we are out of
> sync somehow.

OK, I will resend all of remaining patches by marking with "v2".

>
> thanks,
>
> greg k-h