From: Arend van Spriel <arend@broadcom.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Hante Meuleman <meuleman@broadcom.com>
Subject: Re: [PATCH 01/16] brcmfmac: Fix exception handling.
Date: Sat, 19 Sep 2015 11:43:26 +0200 [thread overview]
Message-ID: <55FD2E3E.4020804@broadcom.com> (raw)
In-Reply-To: <1442606899-31872-2-git-send-email-arend@broadcom.com>
On 09/18/2015 10:08 PM, Arend van Spriel wrote:
> From: Hante Meuleman <meuleman@broadcom.com>
>
> In some exception situations the ifp->vif was not properly assigned
> which could result in crash.
Tested-by: Rafał Miłecki <zajec5@gmail.com>
> Reviewed-by: Arend Van Spriel <arend@broadcom.com>
> Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
> Signed-off-by: Hante Meuleman <meuleman@broadcom.com>
> Signed-off-by: Arend van Spriel <arend@broadcom.com>
> ---
> drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c
> index 600098d..da24bf0 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c
> @@ -6332,6 +6332,7 @@ wiphy_unreg_out:
> priv_out:
> wl_deinit_priv(cfg);
> brcmf_free_vif(vif);
> + ifp->vif = NULL;
> wiphy_out:
> brcmf_free_wiphy(wiphy);
> return NULL;
>
next prev parent reply other threads:[~2015-09-19 9:43 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 20:08 [PATCH 00/16] brcmfmac: new device support and P2P fixes Arend van Spriel
2015-09-18 20:08 ` [PATCH 01/16] brcmfmac: Fix exception handling Arend van Spriel
2015-09-19 9:43 ` Arend van Spriel [this message]
2015-09-29 7:57 ` [01/16] " Kalle Valo
2015-09-18 20:08 ` [PATCH 02/16] brcmfmac: Add support for the BCM4350 PCIE device Arend van Spriel
2015-09-18 20:08 ` [PATCH 03/16] brcmfmac: Fix set and get tx-power functions Arend van Spriel
2015-09-18 20:08 ` [PATCH 04/16] brcmfmac: Only assign primary netdev to if2bss array Arend van Spriel
2015-09-18 20:08 ` [PATCH 05/16] brcmfmac: Inform p2p module about p2pon through API Arend van Spriel
2015-09-18 20:08 ` [PATCH 06/16] brcmfmac: Fix bug in flowring management Arend van Spriel
2015-09-18 20:08 ` [PATCH 07/16] brcmfmac: Make p2pon module param always available Arend van Spriel
2015-09-18 20:08 ` [PATCH 08/16] brcmfmac: Workaround in change vif for wpa_supplicant support Arend van Spriel
2015-09-18 20:08 ` [PATCH 09/16] brcmfmac: Deleting of p2p device is leaking memory Arend van Spriel
2015-09-18 20:08 ` [PATCH 10/16] brcmfmac: Only handle p2p_stop_device if vif is valid Arend van Spriel
2015-09-18 20:08 ` [PATCH 11/16] brcmfmac: Fix p2p bug for older firmwares Arend van Spriel
2015-09-18 20:08 ` [PATCH 12/16] brcmfmac: Add module parameter to disable features Arend van Spriel
2015-09-18 20:08 ` [PATCH 13/16] brcmfmac: Fix race condition bug when deleting p2p interface Arend van Spriel
2015-09-18 20:08 ` [PATCH 14/16] brcmfmac: Add support for the BCM4365 and BCM4366 PCIE devices Arend van Spriel
2015-09-18 20:08 ` [PATCH 15/16] brcmfmac: Fix TDLS setup by properly handling p2p noif Arend van Spriel
2015-09-18 20:08 ` [PATCH 16/16] brcmfmac: Accept events when TDLS is used in combination with p2p Arend van Spriel
2015-09-19 9:43 ` Arend van Spriel
2015-09-18 21:29 ` [PATCH 00/16] brcmfmac: new device support and P2P fixes Rafał Miłecki
2015-09-19 9:40 ` Arend van Spriel
2015-09-19 14:24 ` Arend van Spriel
2015-09-19 15:05 ` Rafał Miłecki
2015-09-19 16:32 ` Arend van Spriel
2015-09-21 12:17 ` Kalle Valo
2015-09-28 17:48 ` Arend van Spriel
2015-09-28 18:14 ` Pending patches in patchwork and their states Kalle Valo
2016-01-09 23:48 ` [PATCH 00/16] brcmfmac: new device support and P2P fixes Rafał Miłecki
2016-01-10 20:59 ` Arend van Spriel
2016-01-10 21:12 ` Rafał Miłecki
2016-01-11 8:33 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FD2E3E.4020804@broadcom.com \
--to=arend@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=meuleman@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).