From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D72A61A6836 for ; Fri, 22 May 2026 12:45:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779453931; cv=none; b=lpM/pF4Mq9MUyb8lqU5JtIFb6idYqH2/i8GYMwFxnEewIpMmv3IeA1QERFTHP3GZL63dDHt6DCfFT/ERHbgd0wag9TZBzBQE+nOoL16DZi1Bz09jwscvsZywvJMgtIElYUgiAhriR6z4Zka3k9MBa6ajh/yAijFJYK9gZc2zKTA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779453931; c=relaxed/simple; bh=B6Wrx8wptznPEXE7GgI4oCIpRWZlbijf1SHKh604G6I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CSlXWq3MkzFrcqQmdvRRdS1qlbhNHDqh7oaxsqXEnwjpg3jwuYsoP3dVW3GxgQ86P/lWZwx0ZSzUdgqIcQe/pRZ1PUIYPM8KH2SCYu1QNGHvr077y/dVR8UYGybvH36BXZAiXKqNuJP/UT5uSjS1JKQ1T7TiLpje8XiC0+Shcxw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S9TdA1s9; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S9TdA1s9" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-5aa1b2327c8so8975576e87.0 for ; Fri, 22 May 2026 05:45:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779453928; x=1780058728; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jEx08WhtJbuH9Jvv5ffuVG6XRuDs6AIyFWz3HRiJmYw=; b=S9TdA1s9sU06k7pAAsQhZgPt6Jm2cy1jpfHiVjy/+4+phsKTB39AbQjFrUaHHvTuHa 7xcha/kC9qOvlrvOc+x2JTP+jZxZ/e3H1ei/X60CDqJpjGmR8Nzbf9OwEeh6jXSYmMe6 1lqGhLX9WLcsDUNoRDwB8RN2/7jcZGUB/8QVzZr9eANTujcgTuVz1xsDUvY1h5CzWkhw CjjnUJzTgxZB4Xvh+ERZIfoeKsbVY7GHoFXwuSABK574IaI9xqc2uETLj3zU1ZFqV2YS GuqN5wtrNjE3MnCX7eUhhI4j839ntAaSS2DRdL1e8/Q6vQSCXDKpTqbm32FekGdEJyes Fk2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779453928; x=1780058728; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jEx08WhtJbuH9Jvv5ffuVG6XRuDs6AIyFWz3HRiJmYw=; b=lxRUJniNbv6jCaRL9KmJyj98OZBXgfyHOOegH+8s9l7Z9g2pxooJymtIXmSOvtJtTe 8Ef1jmqEdkYuyiB7wXG4HPgCGAku2vOnSYulT5EMMsFL2l6nuvcWrb0dTp+xxdOBdyiL VmJ9s8eonnmyAk1NCtFTNbwEJoSB504F1rIinV+4EThqOmX8AdcwP158+BtPkqjTkMnQ hG/P2HU9+yzCExAxxRHa4w8/jMLhbI1KW8CgdeuE+GDP7175jBiu+Viy4bceHAz8rtFf cCr5mSKilBqwd82aYA2JQDzH85HaZX+bniiBk3nExeRHwzbhdTcLNIDkJT3nfbyb6Sqn nUQA== X-Forwarded-Encrypted: i=1; AFNElJ94pK9dmKfPIDbjv4NIaXP7/nB0Hrq8mm5mZQghgCYKcVF7rRZrVhgebqg6KajbZ8mfTPT2n47m+ts1VbO7Aw==@vger.kernel.org X-Gm-Message-State: AOJu0YzNdjCNJmwHpirY/NhJ9rJL9GbLen9ZYRzbVzhRdsb31MDcWyNy xxunezQpC1rBDsfLQc4LxatK/hSlHsvTM90pfWx4jx+uxaaLc5G3ZTdK X-Gm-Gg: Acq92OEnBsqezFkXldW5hfsocQEWVEoXIhu8gl0p37icpWUiV/Xkw/Y9QFJkiajGTZd VcKZVneqsqpkc1wMoekLTIeWW0mebgeAtYnOFxlDFNdItNAM555l1g0iaOllkzGKXS6sQoYyEsi gtC3vpUqLbGYTS2Pn5Xco17Q7cWvSM9wjUT15whGgtPb7DjbNyqNg+Mb+mx3xAVYfHB4JxMR8kW x2kBPHu3yHQ5Xp6/IH5fguwVmVFbz3rk+tRdHAYbqSddg9pBHGw9rlG46mz32Hef11h9AEies6k Gd4h6lYLobFzfxg8CNQuKqDPjko6IFI0GvO/+8tn6Cz0bQyYGL24gkKB3Uy84OOqCJu/Syr20nU RdGHVoDXxp2kwVvEP/wv7HYyNX5nwNZWsZWOwI4M6lV6RqjrCFbO6xd1mNP6w5k+hpK36Wps40m 1hXtFScVa+E9QEUsYwK6EId+rttElPFZStkM1Op0KqeNfkSVtmFnzzcbpJ5/yRw0nMvjO8+0sqh z03j6dM X-Received: by 2002:a05:6512:33c9:b0:5a8:64c4:38c4 with SMTP id 2adb3069b0e04-5aa32314258mr1031399e87.8.1779453927777; Fri, 22 May 2026 05:45:27 -0700 (PDT) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aa32cb37bfsm401018e87.11.2026.05.22.05.45.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 May 2026 05:45:27 -0700 (PDT) Message-ID: <55c36da0-6cc4-4c95-88ef-3dd5b2181b0d@gmail.com> Date: Fri, 22 May 2026 15:45:25 +0300 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/10] [v3] input: gpio-keys: make legacy gpiolib optional To: Arnd Bergmann , Arnd Bergmann , "open list:GPIO SUBSYSTEM" Cc: linux-kernel@vger.kernel.org, Christian Lamparter , Johannes Berg , Aaro Koskinen , Andreas Kemnade , Kevin Hilman , Roger Quadros , Tony Lindgren , Thomas Bogendoerfer , John Paul Adrian Glaubitz , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Linus Walleij , Bartosz Golaszewski , Dmitry Torokhov , Lee Jones , Pavel Machek , Florian Fainelli , Jonas Gorski , Andrew Lunn , Vladimir Oltean , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-wireless@vger.kernel.org, Linux-OMAP , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-sh@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, Netdev References: <20260520183815.2510387-1-arnd@kernel.org> <20260520183815.2510387-3-arnd@kernel.org> <681f328c-bc8a-4410-b876-f8c5f116325d@app.fastmail.com> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: <681f328c-bc8a-4410-b876-f8c5f116325d@app.fastmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22/05/2026 11:28, Arnd Bergmann wrote: > On Fri, May 22, 2026, at 06:55, Matti Vaittinen wrote: >> On 20/05/2026 21:38, Arnd Bergmann wrote: >>> From: Arnd Bergmann >>> >>> The two Rohm PMIC drivers use a gpio-keys device without an actual GPIO, >>> passing an IRQ number instead. In order to keep this working both with >>> and with CONFIG_GPIOLIB_LEGACY, change the gpio-keys driver to ignore >>> the gpio number if an IRQ is passed. >>> >> >> I am (still) all fine with this, even though I like Dmitry's set. I >> suppose you already have a plan for merging this, but I still have to >> ask - why the MFD changes aren't in own patch? I feel it would have >> simplified merging, backporting, reviewing and reverting if needed. > > Splitting it out would break bisection: The gpio-leds change without > the mfd change causes a build failure when assigning the .gpio > field, and the reverse causes a runtime failure when .gpio=0 is > a valid line. Ah, yes. Thanks for explanation. (I feel a bit [a lot] stupid, as I somehow missed the problem of .gpio = 0 being valid. That even though I had it explicitly set to -1 myself :rolleyes: ). No further questions ;) Yours, -- Matti -- --- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~