From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Michael Büsch" <m@bues.ch>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
linux-wireless@vger.kernel.org,
"Hauke Mehrtens" <hauke@hauke-m.de>,
b43-dev@lists.infradead.org
Subject: Re: [PATCH][RFC][RFT] ssb: pick PCMCIA host code support from b43 driver
Date: Mon, 21 Sep 2015 11:38:30 -0500 [thread overview]
Message-ID: <56003286.4010800@lwfinger.net> (raw)
In-Reply-To: <20150921182622.0727f224@wiggum>
On 09/21/2015 11:26 AM, Michael Büsch wrote:
> On Mon, 21 Sep 2015 11:14:32 -0500
> Larry Finger <Larry.Finger@lwfinger.net> wrote:
>
>> This patch has been tested on PPC architecture with Linksys WPC54G PCMCIA cards.
>
> Are you sure that this really is a 16 bit PCMCIA card and not a PC-Card?
> If it shows up in lspci, it's not a PCMCIA card.
Point taken. These are indeed PC-Cards in a PCMCIA format.
>> It probably does not matter here, but I prefer that hexadecimal constants in
>> device tables contain only the lower-case versions of a-f. That makes searching
>> for such constants with grep a lot easier.
>
> I prefer coffee over tea. That doesn't make coffee any better, though.
>
> Is it really so that the rest of the kernel only uses lower case here?
> Grep also supports case insensitive regexes, if done correctly. And if
> not everybody uses lower case here, you'll have to do that anyway.
Yes, I know how to use grep to ignore case.
Larry
>
next prev parent reply other threads:[~2015-09-21 16:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 9:04 [PATCH][RFC][RFT] ssb: pick PCMCIA host code support from b43 driver Rafał Miłecki
2015-09-21 16:14 ` Larry Finger
2015-09-21 16:26 ` Michael Büsch
2015-09-21 16:38 ` Larry Finger [this message]
2015-09-21 16:20 ` Michael Büsch
2015-09-23 10:02 ` Rafał Miłecki
2015-09-23 15:58 ` Michael Büsch
2015-10-14 11:17 ` Rafał Miłecki
2015-10-14 14:48 ` Michael Büsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56003286.4010800@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=m@bues.ch \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).